Fabio Estevam | 9473a62 | 2015-05-24 17:45:54 -0300 | [diff] [blame] | 1 | /// Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests") |
| 2 | /// threaded IRQs without a primary handler need to be requested with |
| 3 | /// IRQF_ONESHOT, otherwise the request will fail. |
| 4 | /// |
| 5 | /// So pass the IRQF_ONESHOT flag in this case. |
Lars-Peter Clausen | f1f4550 | 2012-07-01 13:17:07 +0200 | [diff] [blame] | 6 | /// |
| 7 | // |
Vaishali Thakkar | d1e774f | 2016-11-23 14:16:42 +0530 | [diff] [blame^] | 8 | // Confidence: Moderate |
Lars-Peter Clausen | f1f4550 | 2012-07-01 13:17:07 +0200 | [diff] [blame] | 9 | // Comments: |
| 10 | // Options: --no-includes |
| 11 | |
| 12 | virtual patch |
| 13 | virtual context |
| 14 | virtual org |
| 15 | virtual report |
| 16 | |
| 17 | @r1@ |
Vaishali Thakkar | dca24c4 | 2016-11-23 14:16:39 +0530 | [diff] [blame] | 18 | expression dev, irq, thread_fn; |
Lars-Peter Clausen | f1f4550 | 2012-07-01 13:17:07 +0200 | [diff] [blame] | 19 | position p; |
| 20 | @@ |
Valentin Rothberg | 2c2b913 | 2015-03-04 09:32:32 +0100 | [diff] [blame] | 21 | ( |
Lars-Peter Clausen | f1f4550 | 2012-07-01 13:17:07 +0200 | [diff] [blame] | 22 | request_threaded_irq@p(irq, NULL, thread_fn, |
| 23 | ( |
Vaishali Thakkar | dca24c4 | 2016-11-23 14:16:39 +0530 | [diff] [blame] | 24 | IRQF_ONESHOT | ... |
Lars-Peter Clausen | f1f4550 | 2012-07-01 13:17:07 +0200 | [diff] [blame] | 25 | | |
| 26 | IRQF_ONESHOT |
| 27 | ) |
| 28 | , ...) |
Valentin Rothberg | 2c2b913 | 2015-03-04 09:32:32 +0100 | [diff] [blame] | 29 | | |
| 30 | devm_request_threaded_irq@p(dev, irq, NULL, thread_fn, |
| 31 | ( |
Vaishali Thakkar | dca24c4 | 2016-11-23 14:16:39 +0530 | [diff] [blame] | 32 | IRQF_ONESHOT | ... |
Valentin Rothberg | 2c2b913 | 2015-03-04 09:32:32 +0100 | [diff] [blame] | 33 | | |
| 34 | IRQF_ONESHOT |
| 35 | ) |
| 36 | , ...) |
| 37 | ) |
Lars-Peter Clausen | f1f4550 | 2012-07-01 13:17:07 +0200 | [diff] [blame] | 38 | |
Vaishali Thakkar | dca24c4 | 2016-11-23 14:16:39 +0530 | [diff] [blame] | 39 | @r2@ |
| 40 | expression dev, irq, thread_fn, flags, e; |
Lars-Peter Clausen | f1f4550 | 2012-07-01 13:17:07 +0200 | [diff] [blame] | 41 | position p != r1.p; |
| 42 | @@ |
Valentin Rothberg | 2c2b913 | 2015-03-04 09:32:32 +0100 | [diff] [blame] | 43 | ( |
Vaishali Thakkar | dca24c4 | 2016-11-23 14:16:39 +0530 | [diff] [blame] | 44 | flags = IRQF_ONESHOT | ... |
| 45 | | |
| 46 | flags |= IRQF_ONESHOT | ... |
| 47 | ) |
| 48 | ... when != flags = e |
| 49 | ( |
| 50 | request_threaded_irq@p(irq, NULL, thread_fn, flags, ...); |
| 51 | | |
| 52 | devm_request_threaded_irq@p(dev, irq, NULL, thread_fn, flags, ...); |
| 53 | ) |
| 54 | |
| 55 | @depends on patch@ |
| 56 | expression dev, irq, thread_fn, flags; |
| 57 | position p != {r1.p,r2.p}; |
| 58 | @@ |
| 59 | ( |
Lars-Peter Clausen | f1f4550 | 2012-07-01 13:17:07 +0200 | [diff] [blame] | 60 | request_threaded_irq@p(irq, NULL, thread_fn, |
| 61 | ( |
| 62 | -0 |
| 63 | +IRQF_ONESHOT |
| 64 | | |
| 65 | -flags |
| 66 | +flags | IRQF_ONESHOT |
| 67 | ) |
| 68 | , ...) |
Valentin Rothberg | 2c2b913 | 2015-03-04 09:32:32 +0100 | [diff] [blame] | 69 | | |
| 70 | devm_request_threaded_irq@p(dev, irq, NULL, thread_fn, |
| 71 | ( |
| 72 | -0 |
| 73 | +IRQF_ONESHOT |
| 74 | | |
| 75 | -flags |
| 76 | +flags | IRQF_ONESHOT |
| 77 | ) |
| 78 | , ...) |
| 79 | ) |
Lars-Peter Clausen | f1f4550 | 2012-07-01 13:17:07 +0200 | [diff] [blame] | 80 | |
| 81 | @depends on context@ |
Vaishali Thakkar | d1e774f | 2016-11-23 14:16:42 +0530 | [diff] [blame^] | 82 | expression dev, irq; |
Vaishali Thakkar | dca24c4 | 2016-11-23 14:16:39 +0530 | [diff] [blame] | 83 | position p != {r1.p,r2.p}; |
Lars-Peter Clausen | f1f4550 | 2012-07-01 13:17:07 +0200 | [diff] [blame] | 84 | @@ |
Vaishali Thakkar | d1e774f | 2016-11-23 14:16:42 +0530 | [diff] [blame^] | 85 | ( |
Vaishali Thakkar | 35b303a | 2016-11-23 14:16:46 +0530 | [diff] [blame] | 86 | *request_threaded_irq@p(irq, NULL, ...) |
Vaishali Thakkar | d1e774f | 2016-11-23 14:16:42 +0530 | [diff] [blame^] | 87 | | |
| 88 | *devm_request_threaded_irq@p(dev, irq, NULL, ...) |
| 89 | ) |
| 90 | |
Lars-Peter Clausen | f1f4550 | 2012-07-01 13:17:07 +0200 | [diff] [blame] | 91 | |
| 92 | @match depends on report || org@ |
Vaishali Thakkar | d1e774f | 2016-11-23 14:16:42 +0530 | [diff] [blame^] | 93 | expression dev, irq; |
Vaishali Thakkar | dca24c4 | 2016-11-23 14:16:39 +0530 | [diff] [blame] | 94 | position p != {r1.p,r2.p}; |
Lars-Peter Clausen | f1f4550 | 2012-07-01 13:17:07 +0200 | [diff] [blame] | 95 | @@ |
Vaishali Thakkar | d1e774f | 2016-11-23 14:16:42 +0530 | [diff] [blame^] | 96 | ( |
Lars-Peter Clausen | f1f4550 | 2012-07-01 13:17:07 +0200 | [diff] [blame] | 97 | request_threaded_irq@p(irq, NULL, ...) |
Vaishali Thakkar | d1e774f | 2016-11-23 14:16:42 +0530 | [diff] [blame^] | 98 | | |
| 99 | devm_request_threaded_irq@p(dev, irq, NULL, ...) |
| 100 | ) |
Lars-Peter Clausen | f1f4550 | 2012-07-01 13:17:07 +0200 | [diff] [blame] | 101 | |
| 102 | @script:python depends on org@ |
| 103 | p << match.p; |
| 104 | @@ |
| 105 | msg = "ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT" |
| 106 | coccilib.org.print_todo(p[0],msg) |
| 107 | |
| 108 | @script:python depends on report@ |
| 109 | p << match.p; |
| 110 | @@ |
| 111 | msg = "ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT" |
| 112 | coccilib.report.print_report(p[0],msg) |