blob: a7e45e6cd732937ce787c6c2010fb8249ae0dbac [file] [log] [blame]
Miklos Szeredie9be9d52014-10-24 00:14:38 +02001/*
2 *
3 * Copyright (C) 2011 Novell Inc.
4 *
5 * This program is free software; you can redistribute it and/or modify it
6 * under the terms of the GNU General Public License version 2 as published by
7 * the Free Software Foundation.
8 */
9
10#include <linux/fs.h>
11#include <linux/slab.h>
12#include <linux/namei.h>
13#include <linux/file.h>
14#include <linux/xattr.h>
15#include <linux/rbtree.h>
16#include <linux/security.h>
17#include <linux/cred.h>
Amir Goldsteinb5efccbe2017-05-11 16:42:27 +030018#include <linux/ratelimit.h>
Miklos Szeredie9be9d52014-10-24 00:14:38 +020019#include "overlayfs.h"
20
21struct ovl_cache_entry {
Miklos Szeredie9be9d52014-10-24 00:14:38 +020022 unsigned int len;
23 unsigned int type;
Amir Goldsteinb5efccbe2017-05-11 16:42:27 +030024 u64 real_ino;
Miklos Szeredie9be9d52014-10-24 00:14:38 +020025 u64 ino;
Miklos Szeredie9be9d52014-10-24 00:14:38 +020026 struct list_head l_node;
27 struct rb_node node;
Miklos Szeredicdb67272015-06-22 13:53:48 +020028 struct ovl_cache_entry *next_maybe_whiteout;
zhangyi (F)95e598e2017-10-31 22:57:00 +020029 bool is_upper;
Miklos Szeredic2096532014-10-27 13:48:48 +010030 bool is_whiteout;
Al Viro68bf8612014-10-23 22:58:56 -040031 char name[];
Miklos Szeredie9be9d52014-10-24 00:14:38 +020032};
33
34struct ovl_dir_cache {
35 long refcount;
36 u64 version;
37 struct list_head entries;
Miklos Szeredi4edb83b2017-07-27 21:54:06 +020038 struct rb_root root;
Miklos Szeredie9be9d52014-10-24 00:14:38 +020039};
40
41struct ovl_readdir_data {
42 struct dir_context ctx;
Antonio Murdaca3fe6e522016-04-07 15:48:25 +020043 struct dentry *dentry;
Miklos Szeredi56656e92016-03-21 17:31:46 +010044 bool is_lowest;
Miklos Szeredi4edb83b2017-07-27 21:54:06 +020045 struct rb_root *root;
Miklos Szeredie9be9d52014-10-24 00:14:38 +020046 struct list_head *list;
Al Virodb6ec212014-10-23 23:03:03 -040047 struct list_head middle;
Miklos Szeredicdb67272015-06-22 13:53:48 +020048 struct ovl_cache_entry *first_maybe_whiteout;
Miklos Szeredie9be9d52014-10-24 00:14:38 +020049 int count;
50 int err;
Amir Goldsteinb5efccbe2017-05-11 16:42:27 +030051 bool is_upper;
Vivek Goyal45aebea2016-02-22 09:28:34 -050052 bool d_type_supported;
Miklos Szeredie9be9d52014-10-24 00:14:38 +020053};
54
55struct ovl_dir_file {
56 bool is_real;
57 bool is_upper;
58 struct ovl_dir_cache *cache;
hujianyang43303972014-12-11 10:30:18 +080059 struct list_head *cursor;
Miklos Szeredie9be9d52014-10-24 00:14:38 +020060 struct file *realfile;
61 struct file *upperfile;
62};
63
64static struct ovl_cache_entry *ovl_cache_entry_from_node(struct rb_node *n)
65{
Miklos Szeredi4edb83b2017-07-27 21:54:06 +020066 return rb_entry(n, struct ovl_cache_entry, node);
67}
68
69static bool ovl_cache_entry_find_link(const char *name, int len,
70 struct rb_node ***link,
71 struct rb_node **parent)
72{
73 bool found = false;
74 struct rb_node **newp = *link;
75
76 while (!found && *newp) {
77 int cmp;
78 struct ovl_cache_entry *tmp;
79
80 *parent = *newp;
81 tmp = ovl_cache_entry_from_node(*newp);
82 cmp = strncmp(name, tmp->name, len);
83 if (cmp > 0)
84 newp = &tmp->node.rb_right;
85 else if (cmp < 0 || len < tmp->len)
86 newp = &tmp->node.rb_left;
87 else
88 found = true;
89 }
90 *link = newp;
91
92 return found;
Miklos Szeredie9be9d52014-10-24 00:14:38 +020093}
94
95static struct ovl_cache_entry *ovl_cache_entry_find(struct rb_root *root,
96 const char *name, int len)
97{
98 struct rb_node *node = root->rb_node;
99 int cmp;
100
101 while (node) {
102 struct ovl_cache_entry *p = ovl_cache_entry_from_node(node);
103
104 cmp = strncmp(name, p->name, len);
105 if (cmp > 0)
106 node = p->node.rb_right;
107 else if (cmp < 0 || len < p->len)
108 node = p->node.rb_left;
109 else
110 return p;
111 }
112
113 return NULL;
114}
115
Amir Goldsteinb5efccbe2017-05-11 16:42:27 +0300116static bool ovl_calc_d_ino(struct ovl_readdir_data *rdd,
117 struct ovl_cache_entry *p)
118{
119 /* Don't care if not doing ovl_iter() */
120 if (!rdd->dentry)
121 return false;
122
123 /* Always recalc d_ino for parent */
124 if (strcmp(p->name, "..") == 0)
125 return true;
126
127 /* If this is lower, then native d_ino will do */
128 if (!rdd->is_upper)
129 return false;
130
131 /*
132 * Recalc d_ino for '.' and for all entries if dir is impure (contains
133 * copied up entries)
134 */
135 if ((p->name[0] == '.' && p->len == 1) ||
136 ovl_test_flag(OVL_IMPURE, d_inode(rdd->dentry)))
137 return true;
138
139 return false;
140}
141
Miklos Szeredicdb67272015-06-22 13:53:48 +0200142static struct ovl_cache_entry *ovl_cache_entry_new(struct ovl_readdir_data *rdd,
Miklos Szeredi3e01cee2014-12-13 00:59:45 +0100143 const char *name, int len,
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200144 u64 ino, unsigned int d_type)
145{
146 struct ovl_cache_entry *p;
Al Viro68bf8612014-10-23 22:58:56 -0400147 size_t size = offsetof(struct ovl_cache_entry, name[len + 1]);
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200148
Al Viro68bf8612014-10-23 22:58:56 -0400149 p = kmalloc(size, GFP_KERNEL);
Miklos Szeredi3e01cee2014-12-13 00:59:45 +0100150 if (!p)
151 return NULL;
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200152
Miklos Szeredi3e01cee2014-12-13 00:59:45 +0100153 memcpy(p->name, name, len);
154 p->name[len] = '\0';
155 p->len = len;
156 p->type = d_type;
Amir Goldsteinb5efccbe2017-05-11 16:42:27 +0300157 p->real_ino = ino;
Miklos Szeredi3e01cee2014-12-13 00:59:45 +0100158 p->ino = ino;
Amir Goldsteinb5efccbe2017-05-11 16:42:27 +0300159 /* Defer setting d_ino for upper entry to ovl_iterate() */
160 if (ovl_calc_d_ino(rdd, p))
161 p->ino = 0;
zhangyi (F)95e598e2017-10-31 22:57:00 +0200162 p->is_upper = rdd->is_upper;
Miklos Szeredi3e01cee2014-12-13 00:59:45 +0100163 p->is_whiteout = false;
Miklos Szeredi3e01cee2014-12-13 00:59:45 +0100164
165 if (d_type == DT_CHR) {
Miklos Szeredicdb67272015-06-22 13:53:48 +0200166 p->next_maybe_whiteout = rdd->first_maybe_whiteout;
167 rdd->first_maybe_whiteout = p;
Miklos Szeredi3e01cee2014-12-13 00:59:45 +0100168 }
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200169 return p;
170}
171
172static int ovl_cache_entry_add_rb(struct ovl_readdir_data *rdd,
173 const char *name, int len, u64 ino,
174 unsigned int d_type)
175{
Miklos Szeredi4edb83b2017-07-27 21:54:06 +0200176 struct rb_node **newp = &rdd->root->rb_node;
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200177 struct rb_node *parent = NULL;
178 struct ovl_cache_entry *p;
179
Miklos Szeredi4edb83b2017-07-27 21:54:06 +0200180 if (ovl_cache_entry_find_link(name, len, &newp, &parent))
181 return 0;
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200182
Miklos Szeredicdb67272015-06-22 13:53:48 +0200183 p = ovl_cache_entry_new(rdd, name, len, ino, d_type);
Miklos Szeredi31e8cce2017-07-27 21:54:06 +0200184 if (p == NULL) {
185 rdd->err = -ENOMEM;
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200186 return -ENOMEM;
Miklos Szeredi31e8cce2017-07-27 21:54:06 +0200187 }
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200188
189 list_add_tail(&p->l_node, rdd->list);
190 rb_link_node(&p->node, parent, newp);
Miklos Szeredi4edb83b2017-07-27 21:54:06 +0200191 rb_insert_color(&p->node, rdd->root);
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200192
193 return 0;
194}
195
Miklos Szeredi56656e92016-03-21 17:31:46 +0100196static int ovl_fill_lowest(struct ovl_readdir_data *rdd,
197 const char *name, int namelen,
198 loff_t offset, u64 ino, unsigned int d_type)
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200199{
200 struct ovl_cache_entry *p;
201
Miklos Szeredi4edb83b2017-07-27 21:54:06 +0200202 p = ovl_cache_entry_find(rdd->root, name, namelen);
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200203 if (p) {
Al Virodb6ec212014-10-23 23:03:03 -0400204 list_move_tail(&p->l_node, &rdd->middle);
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200205 } else {
Miklos Szeredicdb67272015-06-22 13:53:48 +0200206 p = ovl_cache_entry_new(rdd, name, namelen, ino, d_type);
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200207 if (p == NULL)
208 rdd->err = -ENOMEM;
209 else
Al Virodb6ec212014-10-23 23:03:03 -0400210 list_add_tail(&p->l_node, &rdd->middle);
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200211 }
212
213 return rdd->err;
214}
215
216void ovl_cache_free(struct list_head *list)
217{
218 struct ovl_cache_entry *p;
219 struct ovl_cache_entry *n;
220
221 list_for_each_entry_safe(p, n, list, l_node)
222 kfree(p);
223
224 INIT_LIST_HEAD(list);
225}
226
Miklos Szeredi4edb83b2017-07-27 21:54:06 +0200227void ovl_dir_cache_free(struct inode *inode)
228{
229 struct ovl_dir_cache *cache = ovl_dir_cache(inode);
230
231 if (cache) {
232 ovl_cache_free(&cache->entries);
233 kfree(cache);
234 }
235}
236
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200237static void ovl_cache_put(struct ovl_dir_file *od, struct dentry *dentry)
238{
239 struct ovl_dir_cache *cache = od->cache;
240
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200241 WARN_ON(cache->refcount <= 0);
242 cache->refcount--;
243 if (!cache->refcount) {
Miklos Szeredi4edb83b2017-07-27 21:54:06 +0200244 if (ovl_dir_cache(d_inode(dentry)) == cache)
245 ovl_set_dir_cache(d_inode(dentry), NULL);
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200246
247 ovl_cache_free(&cache->entries);
248 kfree(cache);
249 }
250}
251
Miklos Szerediac7576f2014-10-30 17:37:34 +0100252static int ovl_fill_merge(struct dir_context *ctx, const char *name,
253 int namelen, loff_t offset, u64 ino,
254 unsigned int d_type)
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200255{
Miklos Szerediac7576f2014-10-30 17:37:34 +0100256 struct ovl_readdir_data *rdd =
257 container_of(ctx, struct ovl_readdir_data, ctx);
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200258
259 rdd->count++;
Miklos Szeredi56656e92016-03-21 17:31:46 +0100260 if (!rdd->is_lowest)
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200261 return ovl_cache_entry_add_rb(rdd, name, namelen, ino, d_type);
262 else
Miklos Szeredi56656e92016-03-21 17:31:46 +0100263 return ovl_fill_lowest(rdd, name, namelen, offset, ino, d_type);
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200264}
265
Miklos Szeredicdb67272015-06-22 13:53:48 +0200266static int ovl_check_whiteouts(struct dentry *dir, struct ovl_readdir_data *rdd)
267{
268 int err;
269 struct ovl_cache_entry *p;
270 struct dentry *dentry;
271 const struct cred *old_cred;
Miklos Szeredicdb67272015-06-22 13:53:48 +0200272
Antonio Murdaca3fe6e522016-04-07 15:48:25 +0200273 old_cred = ovl_override_creds(rdd->dentry->d_sb);
Miklos Szeredicdb67272015-06-22 13:53:48 +0200274
Al Viro00235412016-05-26 00:05:12 -0400275 err = down_write_killable(&dir->d_inode->i_rwsem);
Miklos Szeredicdb67272015-06-22 13:53:48 +0200276 if (!err) {
277 while (rdd->first_maybe_whiteout) {
278 p = rdd->first_maybe_whiteout;
279 rdd->first_maybe_whiteout = p->next_maybe_whiteout;
280 dentry = lookup_one_len(p->name, dir, p->len);
281 if (!IS_ERR(dentry)) {
282 p->is_whiteout = ovl_is_whiteout(dentry);
283 dput(dentry);
284 }
285 }
Al Viro59551022016-01-22 15:40:57 -0500286 inode_unlock(dir->d_inode);
Miklos Szeredicdb67272015-06-22 13:53:48 +0200287 }
288 revert_creds(old_cred);
Miklos Szeredicdb67272015-06-22 13:53:48 +0200289
290 return err;
291}
292
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200293static inline int ovl_dir_read(struct path *realpath,
294 struct ovl_readdir_data *rdd)
295{
296 struct file *realfile;
297 int err;
298
299 realfile = ovl_path_open(realpath, O_RDONLY | O_DIRECTORY);
300 if (IS_ERR(realfile))
301 return PTR_ERR(realfile);
302
Miklos Szeredicdb67272015-06-22 13:53:48 +0200303 rdd->first_maybe_whiteout = NULL;
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200304 rdd->ctx.pos = 0;
305 do {
306 rdd->count = 0;
307 rdd->err = 0;
308 err = iterate_dir(realfile, &rdd->ctx);
309 if (err >= 0)
310 err = rdd->err;
311 } while (!err && rdd->count);
Miklos Szeredicdb67272015-06-22 13:53:48 +0200312
Miklos Szeredieea2fb42016-09-01 11:11:59 +0200313 if (!err && rdd->first_maybe_whiteout && rdd->dentry)
Miklos Szeredicdb67272015-06-22 13:53:48 +0200314 err = ovl_check_whiteouts(realpath->dentry, rdd);
315
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200316 fput(realfile);
317
318 return err;
319}
320
Amir Goldsteinb79e05a2017-06-25 16:37:17 +0300321/*
322 * Can we iterate real dir directly?
323 *
324 * Non-merge dir may contain whiteouts from a time it was a merge upper, before
325 * lower dir was removed under it and possibly before it was rotated from upper
326 * to lower layer.
327 */
328static bool ovl_dir_is_real(struct dentry *dir)
329{
330 return !ovl_test_flag(OVL_WHITEOUTS, d_inode(dir));
331}
332
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200333static void ovl_dir_reset(struct file *file)
334{
335 struct ovl_dir_file *od = file->private_data;
336 struct ovl_dir_cache *cache = od->cache;
337 struct dentry *dentry = file->f_path.dentry;
Amir Goldsteinb79e05a2017-06-25 16:37:17 +0300338 bool is_real;
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200339
340 if (cache && ovl_dentry_version_get(dentry) != cache->version) {
341 ovl_cache_put(od, dentry);
342 od->cache = NULL;
hujianyang43303972014-12-11 10:30:18 +0800343 od->cursor = NULL;
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200344 }
Amir Goldsteinb79e05a2017-06-25 16:37:17 +0300345 is_real = ovl_dir_is_real(dentry);
346 if (od->is_real != is_real) {
347 /* is_real can only become false when dir is copied up */
348 if (WARN_ON(is_real))
349 return;
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200350 od->is_real = false;
Amir Goldsteinb79e05a2017-06-25 16:37:17 +0300351 }
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200352}
353
Miklos Szeredi4edb83b2017-07-27 21:54:06 +0200354static int ovl_dir_read_merged(struct dentry *dentry, struct list_head *list,
355 struct rb_root *root)
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200356{
357 int err;
Miklos Szeredi9d7459d2014-12-13 00:59:44 +0100358 struct path realpath;
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200359 struct ovl_readdir_data rdd = {
360 .ctx.actor = ovl_fill_merge,
Antonio Murdaca3fe6e522016-04-07 15:48:25 +0200361 .dentry = dentry,
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200362 .list = list,
Miklos Szeredi4edb83b2017-07-27 21:54:06 +0200363 .root = root,
Miklos Szeredi56656e92016-03-21 17:31:46 +0100364 .is_lowest = false,
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200365 };
Miklos Szeredi9d7459d2014-12-13 00:59:44 +0100366 int idx, next;
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200367
Miklos Szeredi9d7459d2014-12-13 00:59:44 +0100368 for (idx = 0; idx != -1; idx = next) {
369 next = ovl_path_next(idx, dentry, &realpath);
Amir Goldsteinb5efccbe2017-05-11 16:42:27 +0300370 rdd.is_upper = ovl_dentry_upper(dentry) == realpath.dentry;
Miklos Szeredic9f00fd2014-11-20 16:40:01 +0100371
Miklos Szeredi9d7459d2014-12-13 00:59:44 +0100372 if (next != -1) {
Miklos Szeredi9d7459d2014-12-13 00:59:44 +0100373 err = ovl_dir_read(&realpath, &rdd);
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200374 if (err)
Miklos Szeredi9d7459d2014-12-13 00:59:44 +0100375 break;
376 } else {
377 /*
378 * Insert lowest layer entries before upper ones, this
379 * allows offsets to be reasonably constant
380 */
381 list_add(&rdd.middle, rdd.list);
Miklos Szeredi56656e92016-03-21 17:31:46 +0100382 rdd.is_lowest = true;
Miklos Szeredi9d7459d2014-12-13 00:59:44 +0100383 err = ovl_dir_read(&realpath, &rdd);
384 list_del(&rdd.middle);
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200385 }
386 }
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200387 return err;
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200388}
389
390static void ovl_seek_cursor(struct ovl_dir_file *od, loff_t pos)
391{
hujianyang43303972014-12-11 10:30:18 +0800392 struct list_head *p;
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200393 loff_t off = 0;
394
hujianyang43303972014-12-11 10:30:18 +0800395 list_for_each(p, &od->cache->entries) {
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200396 if (off >= pos)
397 break;
398 off++;
399 }
hujianyang43303972014-12-11 10:30:18 +0800400 /* Cursor is safe since the cache is stable */
401 od->cursor = p;
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200402}
403
404static struct ovl_dir_cache *ovl_cache_get(struct dentry *dentry)
405{
406 int res;
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200407 struct ovl_dir_cache *cache;
408
Miklos Szeredi4edb83b2017-07-27 21:54:06 +0200409 cache = ovl_dir_cache(d_inode(dentry));
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200410 if (cache && ovl_dentry_version_get(dentry) == cache->version) {
Miklos Szeredi4edb83b2017-07-27 21:54:06 +0200411 WARN_ON(!cache->refcount);
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200412 cache->refcount++;
413 return cache;
414 }
Miklos Szeredi4edb83b2017-07-27 21:54:06 +0200415 ovl_set_dir_cache(d_inode(dentry), NULL);
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200416
417 cache = kzalloc(sizeof(struct ovl_dir_cache), GFP_KERNEL);
418 if (!cache)
419 return ERR_PTR(-ENOMEM);
420
421 cache->refcount = 1;
422 INIT_LIST_HEAD(&cache->entries);
Miklos Szeredi4edb83b2017-07-27 21:54:06 +0200423 cache->root = RB_ROOT;
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200424
Miklos Szeredi4edb83b2017-07-27 21:54:06 +0200425 res = ovl_dir_read_merged(dentry, &cache->entries, &cache->root);
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200426 if (res) {
427 ovl_cache_free(&cache->entries);
428 kfree(cache);
429 return ERR_PTR(res);
430 }
431
432 cache->version = ovl_dentry_version_get(dentry);
Miklos Szeredi4edb83b2017-07-27 21:54:06 +0200433 ovl_set_dir_cache(d_inode(dentry), cache);
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200434
435 return cache;
436}
437
Amir Goldsteinb5efccbe2017-05-11 16:42:27 +0300438/*
439 * Set d_ino for upper entries. Non-upper entries should always report
440 * the uppermost real inode ino and should not call this function.
441 *
442 * When not all layer are on same fs, report real ino also for upper.
443 *
444 * When all layers are on the same fs, and upper has a reference to
445 * copy up origin, call vfs_getattr() on the overlay entry to make
446 * sure that d_ino will be consistent with st_ino from stat(2).
447 */
448static int ovl_cache_update_ino(struct path *path, struct ovl_cache_entry *p)
449
450{
451 struct dentry *dir = path->dentry;
452 struct dentry *this = NULL;
453 enum ovl_path_type type;
454 u64 ino = p->real_ino;
455 int err = 0;
456
457 if (!ovl_same_sb(dir->d_sb))
458 goto out;
459
460 if (p->name[0] == '.') {
461 if (p->len == 1) {
462 this = dget(dir);
463 goto get;
464 }
465 if (p->len == 2 && p->name[1] == '.') {
466 /* we shall not be moved */
467 this = dget(dir->d_parent);
468 goto get;
469 }
470 }
471 this = lookup_one_len(p->name, dir, p->len);
472 if (IS_ERR_OR_NULL(this) || !this->d_inode) {
473 if (IS_ERR(this)) {
474 err = PTR_ERR(this);
475 this = NULL;
476 goto fail;
477 }
478 goto out;
479 }
480
481get:
482 type = ovl_path_type(this);
483 if (OVL_TYPE_ORIGIN(type)) {
484 struct kstat stat;
485 struct path statpath = *path;
486
487 statpath.dentry = this;
488 err = vfs_getattr(&statpath, &stat, STATX_INO, 0);
489 if (err)
490 goto fail;
491
492 WARN_ON_ONCE(dir->d_sb->s_dev != stat.dev);
493 ino = stat.ino;
494 }
495
496out:
497 p->ino = ino;
498 dput(this);
499 return err;
500
501fail:
Amir Goldsteinda2e6b72017-11-22 20:27:34 +0200502 pr_warn_ratelimited("overlayfs: failed to look up (%s) for ino (%i)\n",
Amir Goldsteinb5efccbe2017-05-11 16:42:27 +0300503 p->name, err);
504 goto out;
505}
506
Miklos Szeredi4edb83b2017-07-27 21:54:06 +0200507static int ovl_fill_plain(struct dir_context *ctx, const char *name,
508 int namelen, loff_t offset, u64 ino,
509 unsigned int d_type)
510{
511 struct ovl_cache_entry *p;
512 struct ovl_readdir_data *rdd =
513 container_of(ctx, struct ovl_readdir_data, ctx);
514
515 rdd->count++;
516 p = ovl_cache_entry_new(rdd, name, namelen, ino, d_type);
517 if (p == NULL) {
518 rdd->err = -ENOMEM;
519 return -ENOMEM;
520 }
521 list_add_tail(&p->l_node, rdd->list);
522
523 return 0;
524}
525
526static int ovl_dir_read_impure(struct path *path, struct list_head *list,
527 struct rb_root *root)
528{
529 int err;
530 struct path realpath;
531 struct ovl_cache_entry *p, *n;
532 struct ovl_readdir_data rdd = {
533 .ctx.actor = ovl_fill_plain,
534 .list = list,
535 .root = root,
536 };
537
538 INIT_LIST_HEAD(list);
539 *root = RB_ROOT;
540 ovl_path_upper(path->dentry, &realpath);
541
542 err = ovl_dir_read(&realpath, &rdd);
543 if (err)
544 return err;
545
546 list_for_each_entry_safe(p, n, list, l_node) {
547 if (strcmp(p->name, ".") != 0 &&
548 strcmp(p->name, "..") != 0) {
549 err = ovl_cache_update_ino(path, p);
550 if (err)
551 return err;
552 }
553 if (p->ino == p->real_ino) {
554 list_del(&p->l_node);
555 kfree(p);
556 } else {
557 struct rb_node **newp = &root->rb_node;
558 struct rb_node *parent = NULL;
559
560 if (WARN_ON(ovl_cache_entry_find_link(p->name, p->len,
561 &newp, &parent)))
562 return -EIO;
563
564 rb_link_node(&p->node, parent, newp);
565 rb_insert_color(&p->node, root);
566 }
567 }
568 return 0;
569}
570
571static struct ovl_dir_cache *ovl_cache_get_impure(struct path *path)
572{
573 int res;
574 struct dentry *dentry = path->dentry;
575 struct ovl_dir_cache *cache;
576
577 cache = ovl_dir_cache(d_inode(dentry));
578 if (cache && ovl_dentry_version_get(dentry) == cache->version)
579 return cache;
580
581 /* Impure cache is not refcounted, free it here */
582 ovl_dir_cache_free(d_inode(dentry));
583 ovl_set_dir_cache(d_inode(dentry), NULL);
584
585 cache = kzalloc(sizeof(struct ovl_dir_cache), GFP_KERNEL);
586 if (!cache)
587 return ERR_PTR(-ENOMEM);
588
589 res = ovl_dir_read_impure(path, &cache->entries, &cache->root);
590 if (res) {
591 ovl_cache_free(&cache->entries);
592 kfree(cache);
593 return ERR_PTR(res);
594 }
595 if (list_empty(&cache->entries)) {
596 /* Good oportunity to get rid of an unnecessary "impure" flag */
597 ovl_do_removexattr(ovl_dentry_upper(dentry), OVL_XATTR_IMPURE);
598 ovl_clear_flag(OVL_IMPURE, d_inode(dentry));
599 kfree(cache);
600 return NULL;
601 }
602
603 cache->version = ovl_dentry_version_get(dentry);
604 ovl_set_dir_cache(d_inode(dentry), cache);
605
606 return cache;
607}
608
609struct ovl_readdir_translate {
610 struct dir_context *orig_ctx;
611 struct ovl_dir_cache *cache;
612 struct dir_context ctx;
613 u64 parent_ino;
614};
615
616static int ovl_fill_real(struct dir_context *ctx, const char *name,
617 int namelen, loff_t offset, u64 ino,
618 unsigned int d_type)
619{
620 struct ovl_readdir_translate *rdt =
621 container_of(ctx, struct ovl_readdir_translate, ctx);
622 struct dir_context *orig_ctx = rdt->orig_ctx;
623
624 if (rdt->parent_ino && strcmp(name, "..") == 0)
625 ino = rdt->parent_ino;
626 else if (rdt->cache) {
627 struct ovl_cache_entry *p;
628
629 p = ovl_cache_entry_find(&rdt->cache->root, name, namelen);
630 if (p)
631 ino = p->ino;
632 }
633
634 return orig_ctx->actor(orig_ctx, name, namelen, offset, ino, d_type);
635}
636
637static int ovl_iterate_real(struct file *file, struct dir_context *ctx)
638{
639 int err;
640 struct ovl_dir_file *od = file->private_data;
641 struct dentry *dir = file->f_path.dentry;
642 struct ovl_readdir_translate rdt = {
643 .ctx.actor = ovl_fill_real,
644 .orig_ctx = ctx,
645 };
646
647 if (OVL_TYPE_MERGE(ovl_path_type(dir->d_parent))) {
648 struct kstat stat;
649 struct path statpath = file->f_path;
650
651 statpath.dentry = dir->d_parent;
652 err = vfs_getattr(&statpath, &stat, STATX_INO, 0);
653 if (err)
654 return err;
655
656 WARN_ON_ONCE(dir->d_sb->s_dev != stat.dev);
657 rdt.parent_ino = stat.ino;
658 }
659
660 if (ovl_test_flag(OVL_IMPURE, d_inode(dir))) {
661 rdt.cache = ovl_cache_get_impure(&file->f_path);
662 if (IS_ERR(rdt.cache))
663 return PTR_ERR(rdt.cache);
664 }
665
Amir Goldsteinb02a16e2017-11-29 07:35:21 +0200666 err = iterate_dir(od->realfile, &rdt.ctx);
667 ctx->pos = rdt.ctx.pos;
668
669 return err;
Miklos Szeredi4edb83b2017-07-27 21:54:06 +0200670}
671
672
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200673static int ovl_iterate(struct file *file, struct dir_context *ctx)
674{
675 struct ovl_dir_file *od = file->private_data;
676 struct dentry *dentry = file->f_path.dentry;
hujianyang43303972014-12-11 10:30:18 +0800677 struct ovl_cache_entry *p;
Amir Goldsteinb5efccbe2017-05-11 16:42:27 +0300678 int err;
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200679
680 if (!ctx->pos)
681 ovl_dir_reset(file);
682
Miklos Szeredi4edb83b2017-07-27 21:54:06 +0200683 if (od->is_real) {
684 /*
685 * If parent is merge, then need to adjust d_ino for '..', if
686 * dir is impure then need to adjust d_ino for copied up
687 * entries.
688 */
689 if (ovl_same_sb(dentry->d_sb) &&
690 (ovl_test_flag(OVL_IMPURE, d_inode(dentry)) ||
691 OVL_TYPE_MERGE(ovl_path_type(dentry->d_parent)))) {
692 return ovl_iterate_real(file, ctx);
693 }
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200694 return iterate_dir(od->realfile, ctx);
Miklos Szeredi4edb83b2017-07-27 21:54:06 +0200695 }
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200696
697 if (!od->cache) {
698 struct ovl_dir_cache *cache;
699
700 cache = ovl_cache_get(dentry);
701 if (IS_ERR(cache))
702 return PTR_ERR(cache);
703
704 od->cache = cache;
705 ovl_seek_cursor(od, ctx->pos);
706 }
707
hujianyang43303972014-12-11 10:30:18 +0800708 while (od->cursor != &od->cache->entries) {
709 p = list_entry(od->cursor, struct ovl_cache_entry, l_node);
Amir Goldsteinb5efccbe2017-05-11 16:42:27 +0300710 if (!p->is_whiteout) {
711 if (!p->ino) {
712 err = ovl_cache_update_ino(&file->f_path, p);
713 if (err)
714 return err;
715 }
hujianyang43303972014-12-11 10:30:18 +0800716 if (!dir_emit(ctx, p->name, p->len, p->ino, p->type))
717 break;
Amir Goldsteinb5efccbe2017-05-11 16:42:27 +0300718 }
hujianyang43303972014-12-11 10:30:18 +0800719 od->cursor = p->l_node.next;
720 ctx->pos++;
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200721 }
722 return 0;
723}
724
725static loff_t ovl_dir_llseek(struct file *file, loff_t offset, int origin)
726{
727 loff_t res;
728 struct ovl_dir_file *od = file->private_data;
729
Al Viro59551022016-01-22 15:40:57 -0500730 inode_lock(file_inode(file));
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200731 if (!file->f_pos)
732 ovl_dir_reset(file);
733
734 if (od->is_real) {
735 res = vfs_llseek(od->realfile, offset, origin);
736 file->f_pos = od->realfile->f_pos;
737 } else {
738 res = -EINVAL;
739
740 switch (origin) {
741 case SEEK_CUR:
742 offset += file->f_pos;
743 break;
744 case SEEK_SET:
745 break;
746 default:
747 goto out_unlock;
748 }
749 if (offset < 0)
750 goto out_unlock;
751
752 if (offset != file->f_pos) {
753 file->f_pos = offset;
754 if (od->cache)
755 ovl_seek_cursor(od, offset);
756 }
757 res = offset;
758 }
759out_unlock:
Al Viro59551022016-01-22 15:40:57 -0500760 inode_unlock(file_inode(file));
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200761
762 return res;
763}
764
765static int ovl_dir_fsync(struct file *file, loff_t start, loff_t end,
766 int datasync)
767{
768 struct ovl_dir_file *od = file->private_data;
769 struct dentry *dentry = file->f_path.dentry;
770 struct file *realfile = od->realfile;
771
Amir Goldsteind796e772017-11-08 09:39:46 +0200772 /* Nothing to sync for lower */
773 if (!OVL_TYPE_UPPER(ovl_path_type(dentry)))
774 return 0;
775
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200776 /*
777 * Need to check if we started out being a lower dir, but got copied up
778 */
Amir Goldsteind796e772017-11-08 09:39:46 +0200779 if (!od->is_upper) {
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200780 struct inode *inode = file_inode(file);
781
Will Deacon506458e2017-10-24 11:22:48 +0100782 realfile = READ_ONCE(od->upperfile);
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200783 if (!realfile) {
784 struct path upperpath;
785
786 ovl_path_upper(dentry, &upperpath);
787 realfile = ovl_path_open(&upperpath, O_RDONLY);
Peter Zijlstraff7a5fb2017-06-07 17:43:46 +0200788
Al Viro59551022016-01-22 15:40:57 -0500789 inode_lock(inode);
Al Viro3d268c92014-10-23 22:56:05 -0400790 if (!od->upperfile) {
791 if (IS_ERR(realfile)) {
Al Viro59551022016-01-22 15:40:57 -0500792 inode_unlock(inode);
Al Viro3d268c92014-10-23 22:56:05 -0400793 return PTR_ERR(realfile);
794 }
Peter Zijlstraff7a5fb2017-06-07 17:43:46 +0200795 smp_store_release(&od->upperfile, realfile);
Al Viro3d268c92014-10-23 22:56:05 -0400796 } else {
797 /* somebody has beaten us to it */
798 if (!IS_ERR(realfile))
799 fput(realfile);
800 realfile = od->upperfile;
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200801 }
Al Viro59551022016-01-22 15:40:57 -0500802 inode_unlock(inode);
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200803 }
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200804 }
805
806 return vfs_fsync_range(realfile, start, end, datasync);
807}
808
809static int ovl_dir_release(struct inode *inode, struct file *file)
810{
811 struct ovl_dir_file *od = file->private_data;
812
813 if (od->cache) {
Al Viro59551022016-01-22 15:40:57 -0500814 inode_lock(inode);
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200815 ovl_cache_put(od, file->f_path.dentry);
Al Viro59551022016-01-22 15:40:57 -0500816 inode_unlock(inode);
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200817 }
818 fput(od->realfile);
819 if (od->upperfile)
820 fput(od->upperfile);
821 kfree(od);
822
823 return 0;
824}
825
826static int ovl_dir_open(struct inode *inode, struct file *file)
827{
828 struct path realpath;
829 struct file *realfile;
830 struct ovl_dir_file *od;
831 enum ovl_path_type type;
832
833 od = kzalloc(sizeof(struct ovl_dir_file), GFP_KERNEL);
834 if (!od)
835 return -ENOMEM;
836
837 type = ovl_path_real(file->f_path.dentry, &realpath);
838 realfile = ovl_path_open(&realpath, file->f_flags);
839 if (IS_ERR(realfile)) {
840 kfree(od);
841 return PTR_ERR(realfile);
842 }
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200843 od->realfile = realfile;
Amir Goldsteinb79e05a2017-06-25 16:37:17 +0300844 od->is_real = ovl_dir_is_real(file->f_path.dentry);
Miklos Szeredi1afaba12014-12-13 00:59:42 +0100845 od->is_upper = OVL_TYPE_UPPER(type);
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200846 file->private_data = od;
847
848 return 0;
849}
850
851const struct file_operations ovl_dir_operations = {
852 .read = generic_read_dir,
853 .open = ovl_dir_open,
854 .iterate = ovl_iterate,
855 .llseek = ovl_dir_llseek,
856 .fsync = ovl_dir_fsync,
857 .release = ovl_dir_release,
858};
859
860int ovl_check_empty_dir(struct dentry *dentry, struct list_head *list)
861{
862 int err;
zhangyi (F)95e598e2017-10-31 22:57:00 +0200863 struct ovl_cache_entry *p, *n;
Miklos Szeredi4edb83b2017-07-27 21:54:06 +0200864 struct rb_root root = RB_ROOT;
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200865
Miklos Szeredi4edb83b2017-07-27 21:54:06 +0200866 err = ovl_dir_read_merged(dentry, list, &root);
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200867 if (err)
868 return err;
869
870 err = 0;
871
zhangyi (F)95e598e2017-10-31 22:57:00 +0200872 list_for_each_entry_safe(p, n, list, l_node) {
873 /*
874 * Select whiteouts in upperdir, they should
875 * be cleared when deleting this directory.
876 */
877 if (p->is_whiteout) {
878 if (p->is_upper)
879 continue;
880 goto del_entry;
881 }
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200882
883 if (p->name[0] == '.') {
884 if (p->len == 1)
zhangyi (F)95e598e2017-10-31 22:57:00 +0200885 goto del_entry;
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200886 if (p->len == 2 && p->name[1] == '.')
zhangyi (F)95e598e2017-10-31 22:57:00 +0200887 goto del_entry;
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200888 }
889 err = -ENOTEMPTY;
890 break;
zhangyi (F)95e598e2017-10-31 22:57:00 +0200891
892del_entry:
893 list_del(&p->l_node);
894 kfree(p);
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200895 }
896
897 return err;
898}
899
900void ovl_cleanup_whiteouts(struct dentry *upper, struct list_head *list)
901{
902 struct ovl_cache_entry *p;
903
Al Viro59551022016-01-22 15:40:57 -0500904 inode_lock_nested(upper->d_inode, I_MUTEX_CHILD);
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200905 list_for_each_entry(p, list, l_node) {
906 struct dentry *dentry;
907
zhangyi (F)95e598e2017-10-31 22:57:00 +0200908 if (WARN_ON(!p->is_whiteout || !p->is_upper))
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200909 continue;
910
911 dentry = lookup_one_len(p->name, upper, p->len);
912 if (IS_ERR(dentry)) {
913 pr_err("overlayfs: lookup '%s/%.*s' failed (%i)\n",
914 upper->d_name.name, p->len, p->name,
915 (int) PTR_ERR(dentry));
916 continue;
917 }
Konstantin Khlebnikov84889d42015-11-16 18:44:11 +0300918 if (dentry->d_inode)
919 ovl_cleanup(upper->d_inode, dentry);
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200920 dput(dentry);
921 }
Al Viro59551022016-01-22 15:40:57 -0500922 inode_unlock(upper->d_inode);
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200923}
Vivek Goyal45aebea2016-02-22 09:28:34 -0500924
925static int ovl_check_d_type(struct dir_context *ctx, const char *name,
926 int namelen, loff_t offset, u64 ino,
927 unsigned int d_type)
928{
929 struct ovl_readdir_data *rdd =
930 container_of(ctx, struct ovl_readdir_data, ctx);
931
932 /* Even if d_type is not supported, DT_DIR is returned for . and .. */
933 if (!strncmp(name, ".", namelen) || !strncmp(name, "..", namelen))
934 return 0;
935
936 if (d_type != DT_UNKNOWN)
937 rdd->d_type_supported = true;
938
939 return 0;
940}
941
942/*
943 * Returns 1 if d_type is supported, 0 not supported/unknown. Negative values
944 * if error is encountered.
945 */
946int ovl_check_d_type_supported(struct path *realpath)
947{
948 int err;
949 struct ovl_readdir_data rdd = {
950 .ctx.actor = ovl_check_d_type,
951 .d_type_supported = false,
952 };
953
954 err = ovl_dir_read(realpath, &rdd);
955 if (err)
956 return err;
957
958 return rdd.d_type_supported;
959}
Miklos Szeredieea2fb42016-09-01 11:11:59 +0200960
961static void ovl_workdir_cleanup_recurse(struct path *path, int level)
962{
963 int err;
964 struct inode *dir = path->dentry->d_inode;
965 LIST_HEAD(list);
Miklos Szeredi4edb83b2017-07-27 21:54:06 +0200966 struct rb_root root = RB_ROOT;
Miklos Szeredieea2fb42016-09-01 11:11:59 +0200967 struct ovl_cache_entry *p;
968 struct ovl_readdir_data rdd = {
969 .ctx.actor = ovl_fill_merge,
970 .dentry = NULL,
971 .list = &list,
Miklos Szeredi4edb83b2017-07-27 21:54:06 +0200972 .root = &root,
Miklos Szeredieea2fb42016-09-01 11:11:59 +0200973 .is_lowest = false,
974 };
975
976 err = ovl_dir_read(path, &rdd);
977 if (err)
978 goto out;
979
980 inode_lock_nested(dir, I_MUTEX_PARENT);
981 list_for_each_entry(p, &list, l_node) {
982 struct dentry *dentry;
983
984 if (p->name[0] == '.') {
985 if (p->len == 1)
986 continue;
987 if (p->len == 2 && p->name[1] == '.')
988 continue;
989 }
990 dentry = lookup_one_len(p->name, path->dentry, p->len);
991 if (IS_ERR(dentry))
992 continue;
993 if (dentry->d_inode)
994 ovl_workdir_cleanup(dir, path->mnt, dentry, level);
995 dput(dentry);
996 }
997 inode_unlock(dir);
998out:
999 ovl_cache_free(&list);
1000}
1001
1002void ovl_workdir_cleanup(struct inode *dir, struct vfsmount *mnt,
1003 struct dentry *dentry, int level)
1004{
1005 int err;
1006
1007 if (!d_is_dir(dentry) || level > 1) {
1008 ovl_cleanup(dir, dentry);
1009 return;
1010 }
1011
1012 err = ovl_do_rmdir(dir, dentry);
1013 if (err) {
1014 struct path path = { .mnt = mnt, .dentry = dentry };
1015
1016 inode_unlock(dir);
1017 ovl_workdir_cleanup_recurse(&path, level + 1);
1018 inode_lock_nested(dir, I_MUTEX_PARENT);
1019 ovl_cleanup(dir, dentry);
1020 }
1021}
Amir Goldstein415543d2017-06-21 15:28:42 +03001022
1023int ovl_indexdir_cleanup(struct dentry *dentry, struct vfsmount *mnt,
Chandan Rajendrab9343632017-07-24 01:57:54 -05001024 struct ovl_path *lower, unsigned int numlower)
Amir Goldstein415543d2017-06-21 15:28:42 +03001025{
1026 int err;
Amir Goldsteindc7ab672017-09-24 22:19:10 +03001027 struct dentry *index = NULL;
Amir Goldstein415543d2017-06-21 15:28:42 +03001028 struct inode *dir = dentry->d_inode;
1029 struct path path = { .mnt = mnt, .dentry = dentry };
1030 LIST_HEAD(list);
Miklos Szeredi4edb83b2017-07-27 21:54:06 +02001031 struct rb_root root = RB_ROOT;
Amir Goldstein415543d2017-06-21 15:28:42 +03001032 struct ovl_cache_entry *p;
1033 struct ovl_readdir_data rdd = {
1034 .ctx.actor = ovl_fill_merge,
1035 .dentry = NULL,
1036 .list = &list,
Miklos Szeredi4edb83b2017-07-27 21:54:06 +02001037 .root = &root,
Amir Goldstein415543d2017-06-21 15:28:42 +03001038 .is_lowest = false,
1039 };
1040
1041 err = ovl_dir_read(&path, &rdd);
1042 if (err)
1043 goto out;
1044
1045 inode_lock_nested(dir, I_MUTEX_PARENT);
1046 list_for_each_entry(p, &list, l_node) {
Amir Goldstein415543d2017-06-21 15:28:42 +03001047 if (p->name[0] == '.') {
1048 if (p->len == 1)
1049 continue;
1050 if (p->len == 2 && p->name[1] == '.')
1051 continue;
1052 }
1053 index = lookup_one_len(p->name, dentry, p->len);
1054 if (IS_ERR(index)) {
1055 err = PTR_ERR(index);
Amir Goldsteindc7ab672017-09-24 22:19:10 +03001056 index = NULL;
Amir Goldstein415543d2017-06-21 15:28:42 +03001057 break;
1058 }
Chandan Rajendrab9343632017-07-24 01:57:54 -05001059 err = ovl_verify_index(index, lower, numlower);
Amir Goldsteinfa0096e2017-10-24 12:24:11 +03001060 /* Cleanup stale and orphan index entries */
1061 if (err && (err == -ESTALE || err == -ENOENT))
Amir Goldstein415543d2017-06-21 15:28:42 +03001062 err = ovl_cleanup(dir, index);
Amir Goldsteinfa0096e2017-10-24 12:24:11 +03001063 if (err)
1064 break;
1065
Amir Goldstein415543d2017-06-21 15:28:42 +03001066 dput(index);
Amir Goldsteindc7ab672017-09-24 22:19:10 +03001067 index = NULL;
Amir Goldstein415543d2017-06-21 15:28:42 +03001068 }
Amir Goldsteindc7ab672017-09-24 22:19:10 +03001069 dput(index);
Amir Goldstein415543d2017-06-21 15:28:42 +03001070 inode_unlock(dir);
1071out:
1072 ovl_cache_free(&list);
1073 if (err)
1074 pr_err("overlayfs: failed index dir cleanup (%i)\n", err);
1075 return err;
1076}