blob: 0359a67f8f8dd1e74d7e7113b8f67d5f94e29783 [file] [log] [blame]
Rob Clarkcd5351f2011-11-12 12:09:40 -06001/*
Rob Clark8bb0daf2013-02-11 12:43:09 -05002 * drivers/gpu/drm/omapdrm/omap_crtc.c
Rob Clarkcd5351f2011-11-12 12:09:40 -06003 *
4 * Copyright (C) 2011 Texas Instruments
5 * Author: Rob Clark <rob@ti.com>
6 *
7 * This program is free software; you can redistribute it and/or modify it
8 * under the terms of the GNU General Public License version 2 as published by
9 * the Free Software Foundation.
10 *
11 * This program is distributed in the hope that it will be useful, but WITHOUT
12 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
13 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
14 * more details.
15 *
16 * You should have received a copy of the GNU General Public License along with
17 * this program. If not, see <http://www.gnu.org/licenses/>.
18 */
19
Laurent Pincharta42133a2015-01-17 19:09:26 +020020#include <linux/completion.h>
21
Laurent Pinchart2d278f52015-03-05 21:31:37 +020022#include <drm/drm_crtc.h>
23#include <drm/drm_crtc_helper.h>
Andy Grossb9ed9f02012-10-16 00:17:40 -050024#include <drm/drm_mode.h>
Daniel Vetter3cb9ae42014-10-29 10:03:57 +010025#include <drm/drm_plane_helper.h>
Laurent Pinchart2d278f52015-03-05 21:31:37 +020026
27#include "omap_drv.h"
Rob Clarkcd5351f2011-11-12 12:09:40 -060028
29#define to_omap_crtc(x) container_of(x, struct omap_crtc, base)
30
Laurent Pinchart15d02e92015-01-25 22:42:30 +020031enum omap_page_flip_state {
32 OMAP_PAGE_FLIP_IDLE,
33 OMAP_PAGE_FLIP_WAIT,
34 OMAP_PAGE_FLIP_QUEUED,
35 OMAP_PAGE_FLIP_CANCELLED,
36};
37
Rob Clarkcd5351f2011-11-12 12:09:40 -060038struct omap_crtc {
39 struct drm_crtc base;
Rob Clarkf5f94542012-12-04 13:59:12 -060040
Rob Clarkbb5c2d92012-01-16 12:51:16 -060041 const char *name;
Rob Clarkf5f94542012-12-04 13:59:12 -060042 int pipe;
43 enum omap_channel channel;
44 struct omap_overlay_manager_info info;
Tomi Valkeinenc7aef122014-04-03 16:30:03 +030045 struct drm_encoder *current_encoder;
Rob Clarkf5f94542012-12-04 13:59:12 -060046
47 /*
48 * Temporary: eventually this will go away, but it is needed
49 * for now to keep the output's happy. (They only need
50 * mgr->id.) Eventually this will be replaced w/ something
51 * more common-panel-framework-y
52 */
Tomi Valkeinen04b1fc02013-05-14 10:55:19 +030053 struct omap_overlay_manager *mgr;
Rob Clarkf5f94542012-12-04 13:59:12 -060054
55 struct omap_video_timings timings;
56 bool enabled;
Rob Clarkf5f94542012-12-04 13:59:12 -060057
Laurent Pincharta42133a2015-01-17 19:09:26 +020058 struct omap_drm_irq vblank_irq;
Rob Clarkf5f94542012-12-04 13:59:12 -060059 struct omap_drm_irq error_irq;
60
Laurent Pincharta42133a2015-01-17 19:09:26 +020061 /* list of framebuffers to unpin */
62 struct list_head pending_unpins;
Rob Clarkcd5351f2011-11-12 12:09:40 -060063
Laurent Pinchart42fb61c2015-01-26 02:58:51 +020064 /*
Laurent Pinchart15d02e92015-01-25 22:42:30 +020065 * flip_state flag indicates the current page flap state: IDLE if no
66 * page queue has been submitted, WAIT when waiting for GEM async
67 * completion, QUEUED when the page flip has been queued to the hardware
68 * or CANCELLED when the CRTC is turned off before the flip gets queued
Laurent Pinchart0c19ac92015-03-04 18:24:18 +020069 * to the hardware. The flip event, if any, is stored in flip_event, and
70 * the framebuffer queued for page flip is stored in flip_fb. The
Laurent Pinchart15d02e92015-01-25 22:42:30 +020071 * flip_wait wait queue is used to wait for page flip completion.
Laurent Pinchart42fb61c2015-01-26 02:58:51 +020072 *
73 * The flip_work work queue handles page flip requests without caring
74 * about what context the GEM async callback is called from. Possibly we
75 * should just make omap_gem always call the cb from the worker so we
76 * don't have to care about this.
77 */
Laurent Pinchart15d02e92015-01-25 22:42:30 +020078 enum omap_page_flip_state flip_state;
Laurent Pinchart42fb61c2015-01-26 02:58:51 +020079 struct drm_pending_vblank_event *flip_event;
Laurent Pinchart0c19ac92015-03-04 18:24:18 +020080 struct drm_framebuffer *flip_fb;
Laurent Pinchartc397cfd2015-01-25 22:42:30 +020081 wait_queue_head_t flip_wait;
Laurent Pinchart42fb61c2015-01-26 02:58:51 +020082 struct work_struct flip_work;
Rob Clarkf5f94542012-12-04 13:59:12 -060083
Laurent Pincharta42133a2015-01-17 19:09:26 +020084 struct completion completion;
85
Tomi Valkeinena36af732015-02-26 15:20:24 +020086 bool ignore_digit_sync_lost;
Rob Clarkcd5351f2011-11-12 12:09:40 -060087};
88
Laurent Pincharta42133a2015-01-17 19:09:26 +020089struct omap_framebuffer_unpin {
90 struct list_head list;
91 struct drm_framebuffer *fb;
92};
93
Laurent Pinchart971fb3e2015-01-18 01:12:59 +020094/* -----------------------------------------------------------------------------
95 * Helper Functions
96 */
97
Archit Taneja0d8f3712013-03-26 19:15:19 +053098uint32_t pipe2vbl(struct drm_crtc *crtc)
99{
100 struct omap_crtc *omap_crtc = to_omap_crtc(crtc);
101
102 return dispc_mgr_get_vsync_irq(omap_crtc->channel);
103}
104
Laurent Pinchart971fb3e2015-01-18 01:12:59 +0200105const struct omap_video_timings *omap_crtc_timings(struct drm_crtc *crtc)
106{
107 struct omap_crtc *omap_crtc = to_omap_crtc(crtc);
108 return &omap_crtc->timings;
109}
110
111enum omap_channel omap_crtc_channel(struct drm_crtc *crtc)
112{
113 struct omap_crtc *omap_crtc = to_omap_crtc(crtc);
114 return omap_crtc->channel;
115}
116
117/* -----------------------------------------------------------------------------
118 * DSS Manager Functions
119 */
120
Rob Clarkf5f94542012-12-04 13:59:12 -0600121/*
122 * Manager-ops, callbacks from output when they need to configure
123 * the upstream part of the video pipe.
124 *
125 * Most of these we can ignore until we add support for command-mode
126 * panels.. for video-mode the crtc-helpers already do an adequate
127 * job of sequencing the setup of the video pipe in the proper order
128 */
129
Tomi Valkeinen04b1fc02013-05-14 10:55:19 +0300130/* ovl-mgr-id -> crtc */
131static struct omap_crtc *omap_crtcs[8];
132
Rob Clarkf5f94542012-12-04 13:59:12 -0600133/* we can probably ignore these until we support command-mode panels: */
Laurent Pinchart4343f0f2015-03-05 22:01:02 +0200134static int omap_crtc_dss_connect(struct omap_overlay_manager *mgr,
Tomi Valkeinen1f68d9c2013-04-19 15:09:34 +0300135 struct omap_dss_device *dst)
Tomi Valkeinena7e71e72013-05-08 16:23:32 +0300136{
137 if (mgr->output)
138 return -EINVAL;
139
140 if ((mgr->supported_outputs & dst->id) == 0)
141 return -EINVAL;
142
143 dst->manager = mgr;
144 mgr->output = dst;
145
146 return 0;
147}
148
Laurent Pinchart4343f0f2015-03-05 22:01:02 +0200149static void omap_crtc_dss_disconnect(struct omap_overlay_manager *mgr,
Tomi Valkeinen1f68d9c2013-04-19 15:09:34 +0300150 struct omap_dss_device *dst)
Tomi Valkeinena7e71e72013-05-08 16:23:32 +0300151{
152 mgr->output->manager = NULL;
153 mgr->output = NULL;
154}
155
Laurent Pinchart4343f0f2015-03-05 22:01:02 +0200156static void omap_crtc_dss_start_update(struct omap_overlay_manager *mgr)
Rob Clarkf5f94542012-12-04 13:59:12 -0600157{
158}
159
Laurent Pincharta42133a2015-01-17 19:09:26 +0200160/* Called only from omap_crtc_setup and suspend/resume handlers. */
Laurent Pinchart8472b572015-01-15 00:45:17 +0200161static void omap_crtc_set_enabled(struct drm_crtc *crtc, bool enable)
162{
163 struct drm_device *dev = crtc->dev;
164 struct omap_crtc *omap_crtc = to_omap_crtc(crtc);
165 enum omap_channel channel = omap_crtc->channel;
166 struct omap_irq_wait *wait;
167 u32 framedone_irq, vsync_irq;
168 int ret;
169
170 if (dispc_mgr_is_enabled(channel) == enable)
171 return;
172
Tomi Valkeinenef422282015-02-26 15:20:25 +0200173 if (omap_crtc->channel == OMAP_DSS_CHANNEL_DIGIT) {
174 /*
175 * Digit output produces some sync lost interrupts during the
176 * first frame when enabling, so we need to ignore those.
177 */
178 omap_crtc->ignore_digit_sync_lost = true;
179 }
Laurent Pinchart8472b572015-01-15 00:45:17 +0200180
181 framedone_irq = dispc_mgr_get_framedone_irq(channel);
182 vsync_irq = dispc_mgr_get_vsync_irq(channel);
183
184 if (enable) {
185 wait = omap_irq_wait_init(dev, vsync_irq, 1);
186 } else {
187 /*
188 * When we disable the digit output, we need to wait for
189 * FRAMEDONE to know that DISPC has finished with the output.
190 *
191 * OMAP2/3 does not have FRAMEDONE irq for digit output, and in
192 * that case we need to use vsync interrupt, and wait for both
193 * even and odd frames.
194 */
195
196 if (framedone_irq)
197 wait = omap_irq_wait_init(dev, framedone_irq, 1);
198 else
199 wait = omap_irq_wait_init(dev, vsync_irq, 2);
200 }
201
202 dispc_mgr_enable(channel, enable);
203
204 ret = omap_irq_wait(dev, wait, msecs_to_jiffies(100));
205 if (ret) {
206 dev_err(dev->dev, "%s: timeout waiting for %s\n",
207 omap_crtc->name, enable ? "enable" : "disable");
208 }
209
Tomi Valkeinenef422282015-02-26 15:20:25 +0200210 if (omap_crtc->channel == OMAP_DSS_CHANNEL_DIGIT) {
211 omap_crtc->ignore_digit_sync_lost = false;
212 /* make sure the irq handler sees the value above */
213 mb();
214 }
Laurent Pinchart8472b572015-01-15 00:45:17 +0200215}
216
Tomi Valkeinen506096a2014-04-03 13:11:54 +0300217
Laurent Pinchart4343f0f2015-03-05 22:01:02 +0200218static int omap_crtc_dss_enable(struct omap_overlay_manager *mgr)
Rob Clarkf5f94542012-12-04 13:59:12 -0600219{
Tomi Valkeinen506096a2014-04-03 13:11:54 +0300220 struct omap_crtc *omap_crtc = omap_crtcs[mgr->id];
221
222 dispc_mgr_setup(omap_crtc->channel, &omap_crtc->info);
223 dispc_mgr_set_timings(omap_crtc->channel,
224 &omap_crtc->timings);
Laurent Pinchart8472b572015-01-15 00:45:17 +0200225 omap_crtc_set_enabled(&omap_crtc->base, true);
Tomi Valkeinen506096a2014-04-03 13:11:54 +0300226
Rob Clarkf5f94542012-12-04 13:59:12 -0600227 return 0;
228}
229
Laurent Pinchart4343f0f2015-03-05 22:01:02 +0200230static void omap_crtc_dss_disable(struct omap_overlay_manager *mgr)
Rob Clarkf5f94542012-12-04 13:59:12 -0600231{
Tomi Valkeinen506096a2014-04-03 13:11:54 +0300232 struct omap_crtc *omap_crtc = omap_crtcs[mgr->id];
233
Laurent Pinchart8472b572015-01-15 00:45:17 +0200234 omap_crtc_set_enabled(&omap_crtc->base, false);
Rob Clarkf5f94542012-12-04 13:59:12 -0600235}
236
Laurent Pinchart4343f0f2015-03-05 22:01:02 +0200237static void omap_crtc_dss_set_timings(struct omap_overlay_manager *mgr,
Rob Clarkf5f94542012-12-04 13:59:12 -0600238 const struct omap_video_timings *timings)
239{
Tomi Valkeinen04b1fc02013-05-14 10:55:19 +0300240 struct omap_crtc *omap_crtc = omap_crtcs[mgr->id];
Rob Clarkf5f94542012-12-04 13:59:12 -0600241 DBG("%s", omap_crtc->name);
242 omap_crtc->timings = *timings;
Rob Clarkf5f94542012-12-04 13:59:12 -0600243}
244
Laurent Pinchart4343f0f2015-03-05 22:01:02 +0200245static void omap_crtc_dss_set_lcd_config(struct omap_overlay_manager *mgr,
Rob Clarkf5f94542012-12-04 13:59:12 -0600246 const struct dss_lcd_mgr_config *config)
247{
Tomi Valkeinen04b1fc02013-05-14 10:55:19 +0300248 struct omap_crtc *omap_crtc = omap_crtcs[mgr->id];
Rob Clarkf5f94542012-12-04 13:59:12 -0600249 DBG("%s", omap_crtc->name);
250 dispc_mgr_set_lcd_config(omap_crtc->channel, config);
251}
252
Laurent Pinchart4343f0f2015-03-05 22:01:02 +0200253static int omap_crtc_dss_register_framedone(
Rob Clarkf5f94542012-12-04 13:59:12 -0600254 struct omap_overlay_manager *mgr,
255 void (*handler)(void *), void *data)
256{
257 return 0;
258}
259
Laurent Pinchart4343f0f2015-03-05 22:01:02 +0200260static void omap_crtc_dss_unregister_framedone(
Rob Clarkf5f94542012-12-04 13:59:12 -0600261 struct omap_overlay_manager *mgr,
262 void (*handler)(void *), void *data)
263{
264}
265
266static const struct dss_mgr_ops mgr_ops = {
Laurent Pinchart4343f0f2015-03-05 22:01:02 +0200267 .connect = omap_crtc_dss_connect,
268 .disconnect = omap_crtc_dss_disconnect,
269 .start_update = omap_crtc_dss_start_update,
270 .enable = omap_crtc_dss_enable,
271 .disable = omap_crtc_dss_disable,
272 .set_timings = omap_crtc_dss_set_timings,
273 .set_lcd_config = omap_crtc_dss_set_lcd_config,
274 .register_framedone_handler = omap_crtc_dss_register_framedone,
275 .unregister_framedone_handler = omap_crtc_dss_unregister_framedone,
Rob Clarkf5f94542012-12-04 13:59:12 -0600276};
277
Laurent Pinchart971fb3e2015-01-18 01:12:59 +0200278/* -----------------------------------------------------------------------------
Laurent Pinchart1d5e5ea2015-01-18 16:57:36 +0200279 * Setup, Flush and Page Flip
Laurent Pinchart971fb3e2015-01-18 01:12:59 +0200280 */
281
Laurent Pinchart1d5e5ea2015-01-18 16:57:36 +0200282void omap_crtc_cancel_page_flip(struct drm_crtc *crtc, struct drm_file *file)
283{
284 struct omap_crtc *omap_crtc = to_omap_crtc(crtc);
285 struct drm_device *dev = crtc->dev;
286 unsigned long flags;
287
288 spin_lock_irqsave(&dev->event_lock, flags);
289
290 /* Only complete events queued for our file handle. */
291 if (omap_crtc->flip_event &&
292 file == omap_crtc->flip_event->base.file_priv) {
293 drm_send_vblank_event(dev, omap_crtc->pipe,
294 omap_crtc->flip_event);
295 omap_crtc->flip_event = NULL;
296 }
297
298 spin_unlock_irqrestore(&dev->event_lock, flags);
299}
300
Laurent Pinchart15d02e92015-01-25 22:42:30 +0200301/* Must be called with dev->event_lock locked. */
302static void omap_crtc_complete_page_flip(struct drm_crtc *crtc,
303 enum omap_page_flip_state state)
304{
305 struct omap_crtc *omap_crtc = to_omap_crtc(crtc);
306 struct drm_device *dev = crtc->dev;
307
308 if (omap_crtc->flip_event) {
309 drm_send_vblank_event(dev, omap_crtc->pipe,
310 omap_crtc->flip_event);
311 omap_crtc->flip_event = NULL;
312 }
313
314 omap_crtc->flip_state = state;
Laurent Pinchartc397cfd2015-01-25 22:42:30 +0200315
316 if (state == OMAP_PAGE_FLIP_IDLE)
317 wake_up(&omap_crtc->flip_wait);
318}
319
320static bool omap_crtc_page_flip_pending(struct drm_crtc *crtc)
321{
322 struct omap_crtc *omap_crtc = to_omap_crtc(crtc);
323 struct drm_device *dev = crtc->dev;
324 unsigned long flags;
325 bool pending;
326
327 spin_lock_irqsave(&dev->event_lock, flags);
328 pending = omap_crtc->flip_state != OMAP_PAGE_FLIP_IDLE;
329 spin_unlock_irqrestore(&dev->event_lock, flags);
330
331 return pending;
332}
333
334static void omap_crtc_wait_page_flip(struct drm_crtc *crtc)
335{
336 struct omap_crtc *omap_crtc = to_omap_crtc(crtc);
337 struct drm_device *dev = crtc->dev;
338 bool cancelled = false;
339 unsigned long flags;
340
341 /*
342 * If we're still waiting for the GEM async operation to complete just
343 * cancel the page flip, as we're holding the CRTC mutex preventing the
344 * page flip work handler from queueing the page flip.
345 *
346 * We can't release the reference to the frame buffer here as the async
347 * operation doesn't keep its own reference to the buffer. We'll just
348 * let the page flip work queue handle that.
349 */
350 spin_lock_irqsave(&dev->event_lock, flags);
351 if (omap_crtc->flip_state == OMAP_PAGE_FLIP_WAIT) {
352 omap_crtc_complete_page_flip(crtc, OMAP_PAGE_FLIP_CANCELLED);
353 cancelled = true;
354 }
355 spin_unlock_irqrestore(&dev->event_lock, flags);
356
357 if (cancelled)
358 return;
359
360 if (wait_event_timeout(omap_crtc->flip_wait,
361 !omap_crtc_page_flip_pending(crtc),
362 msecs_to_jiffies(50)))
363 return;
364
365 dev_warn(crtc->dev->dev, "page flip timeout!\n");
366
367 spin_lock_irqsave(&dev->event_lock, flags);
368 omap_crtc_complete_page_flip(crtc, OMAP_PAGE_FLIP_IDLE);
369 spin_unlock_irqrestore(&dev->event_lock, flags);
Laurent Pinchart15d02e92015-01-25 22:42:30 +0200370}
371
Laurent Pinchart971fb3e2015-01-18 01:12:59 +0200372static void omap_crtc_error_irq(struct omap_drm_irq *irq, uint32_t irqstatus)
373{
374 struct omap_crtc *omap_crtc =
375 container_of(irq, struct omap_crtc, error_irq);
Tomi Valkeinena36af732015-02-26 15:20:24 +0200376
377 if (omap_crtc->ignore_digit_sync_lost) {
378 irqstatus &= ~DISPC_IRQ_SYNC_LOST_DIGIT;
379 if (!irqstatus)
380 return;
381 }
382
Tomi Valkeinen3b143fc2014-11-19 12:50:13 +0200383 DRM_ERROR_RATELIMITED("%s: errors: %08x\n", omap_crtc->name, irqstatus);
Laurent Pinchart971fb3e2015-01-18 01:12:59 +0200384}
385
Laurent Pincharta42133a2015-01-17 19:09:26 +0200386static void omap_crtc_vblank_irq(struct omap_drm_irq *irq, uint32_t irqstatus)
Laurent Pinchart971fb3e2015-01-18 01:12:59 +0200387{
388 struct omap_crtc *omap_crtc =
Laurent Pincharta42133a2015-01-17 19:09:26 +0200389 container_of(irq, struct omap_crtc, vblank_irq);
390 struct drm_device *dev = omap_crtc->base.dev;
391 unsigned long flags;
Laurent Pinchart971fb3e2015-01-18 01:12:59 +0200392
Laurent Pincharta42133a2015-01-17 19:09:26 +0200393 if (dispc_mgr_go_busy(omap_crtc->channel))
394 return;
395
396 DBG("%s: apply done", omap_crtc->name);
397 __omap_irq_unregister(dev, &omap_crtc->vblank_irq);
398
Laurent Pincharta42133a2015-01-17 19:09:26 +0200399 /* wakeup userspace */
Laurent Pinchart15d02e92015-01-25 22:42:30 +0200400 spin_lock_irqsave(&dev->event_lock, flags);
401 omap_crtc_complete_page_flip(&omap_crtc->base, OMAP_PAGE_FLIP_IDLE);
Laurent Pincharta42133a2015-01-17 19:09:26 +0200402 spin_unlock_irqrestore(&dev->event_lock, flags);
403
404 complete(&omap_crtc->completion);
Laurent Pinchart971fb3e2015-01-18 01:12:59 +0200405}
406
Laurent Pincharta42133a2015-01-17 19:09:26 +0200407int omap_crtc_flush(struct drm_crtc *crtc)
Laurent Pinchart971fb3e2015-01-18 01:12:59 +0200408{
409 struct omap_crtc *omap_crtc = to_omap_crtc(crtc);
Laurent Pincharta42133a2015-01-17 19:09:26 +0200410 struct omap_framebuffer_unpin *fb, *next;
411
412 DBG("%s: GO", omap_crtc->name);
Laurent Pinchart971fb3e2015-01-18 01:12:59 +0200413
414 WARN_ON(!drm_modeset_is_locked(&crtc->mutex));
Laurent Pincharta42133a2015-01-17 19:09:26 +0200415 WARN_ON(omap_crtc->vblank_irq.registered);
Laurent Pinchart971fb3e2015-01-18 01:12:59 +0200416
Laurent Pincharta42133a2015-01-17 19:09:26 +0200417 dispc_runtime_get();
Laurent Pinchart971fb3e2015-01-18 01:12:59 +0200418
Laurent Pincharta42133a2015-01-17 19:09:26 +0200419 if (dispc_mgr_is_enabled(omap_crtc->channel)) {
420 dispc_mgr_go(omap_crtc->channel);
421 omap_irq_register(crtc->dev, &omap_crtc->vblank_irq);
Laurent Pinchart971fb3e2015-01-18 01:12:59 +0200422
Laurent Pincharta42133a2015-01-17 19:09:26 +0200423 WARN_ON(!wait_for_completion_timeout(&omap_crtc->completion,
424 msecs_to_jiffies(100)));
425 reinit_completion(&omap_crtc->completion);
426 }
427
428 dispc_runtime_put();
429
430 /* Unpin and unreference pending framebuffers. */
431 list_for_each_entry_safe(fb, next, &omap_crtc->pending_unpins, list) {
432 omap_framebuffer_unpin(fb->fb);
433 drm_framebuffer_unreference(fb->fb);
434 list_del(&fb->list);
435 kfree(fb);
Laurent Pinchart971fb3e2015-01-18 01:12:59 +0200436 }
437
438 return 0;
439}
440
Laurent Pincharta42133a2015-01-17 19:09:26 +0200441int omap_crtc_queue_unpin(struct drm_crtc *crtc, struct drm_framebuffer *fb)
Laurent Pinchart971fb3e2015-01-18 01:12:59 +0200442{
Laurent Pincharta42133a2015-01-17 19:09:26 +0200443 struct omap_crtc *omap_crtc = to_omap_crtc(crtc);
444 struct omap_framebuffer_unpin *unpin;
445
446 unpin = kzalloc(sizeof(*unpin), GFP_KERNEL);
447 if (!unpin)
448 return -ENOMEM;
449
450 unpin->fb = fb;
451 list_add_tail(&unpin->list, &omap_crtc->pending_unpins);
452
453 return 0;
454}
455
456static void omap_crtc_setup(struct drm_crtc *crtc)
457{
458 struct omap_crtc *omap_crtc = to_omap_crtc(crtc);
Laurent Pinchart971fb3e2015-01-18 01:12:59 +0200459 struct omap_drm_private *priv = crtc->dev->dev_private;
460 struct drm_encoder *encoder = NULL;
461 unsigned int i;
462
463 DBG("%s: enabled=%d", omap_crtc->name, omap_crtc->enabled);
464
Laurent Pincharta42133a2015-01-17 19:09:26 +0200465 dispc_runtime_get();
466
Laurent Pinchart971fb3e2015-01-18 01:12:59 +0200467 for (i = 0; i < priv->num_encoders; i++) {
468 if (priv->encoders[i]->crtc == crtc) {
469 encoder = priv->encoders[i];
470 break;
471 }
472 }
473
474 if (omap_crtc->current_encoder && encoder != omap_crtc->current_encoder)
475 omap_encoder_set_enabled(omap_crtc->current_encoder, false);
476
477 omap_crtc->current_encoder = encoder;
478
479 if (!omap_crtc->enabled) {
480 if (encoder)
481 omap_encoder_set_enabled(encoder, false);
482 } else {
483 if (encoder) {
484 omap_encoder_set_enabled(encoder, false);
485 omap_encoder_update(encoder, omap_crtc->mgr,
486 &omap_crtc->timings);
487 omap_encoder_set_enabled(encoder, true);
488 }
489 }
Laurent Pinchart971fb3e2015-01-18 01:12:59 +0200490
Laurent Pincharta42133a2015-01-17 19:09:26 +0200491 dispc_runtime_put();
Laurent Pinchart971fb3e2015-01-18 01:12:59 +0200492}
493
494/* -----------------------------------------------------------------------------
495 * CRTC Functions
Rob Clarkf5f94542012-12-04 13:59:12 -0600496 */
497
Rob Clarkcd5351f2011-11-12 12:09:40 -0600498static void omap_crtc_destroy(struct drm_crtc *crtc)
499{
500 struct omap_crtc *omap_crtc = to_omap_crtc(crtc);
Rob Clarkf5f94542012-12-04 13:59:12 -0600501
502 DBG("%s", omap_crtc->name);
503
Laurent Pincharta42133a2015-01-17 19:09:26 +0200504 WARN_ON(omap_crtc->vblank_irq.registered);
Rob Clarkf5f94542012-12-04 13:59:12 -0600505 omap_irq_unregister(crtc->dev, &omap_crtc->error_irq);
506
Rob Clarkcd5351f2011-11-12 12:09:40 -0600507 drm_crtc_cleanup(crtc);
Rob Clarkf5f94542012-12-04 13:59:12 -0600508
Rob Clarkcd5351f2011-11-12 12:09:40 -0600509 kfree(omap_crtc);
510}
511
Rob Clarkcd5351f2011-11-12 12:09:40 -0600512static bool omap_crtc_mode_fixup(struct drm_crtc *crtc,
Laurent Pincharte811f5a2012-07-17 17:56:50 +0200513 const struct drm_display_mode *mode,
Rob Clarkbb5c2d92012-01-16 12:51:16 -0600514 struct drm_display_mode *adjusted_mode)
Rob Clarkcd5351f2011-11-12 12:09:40 -0600515{
Rob Clarkcd5351f2011-11-12 12:09:40 -0600516 return true;
517}
518
Laurent Pinchartf1d57fb2015-03-05 22:13:22 +0200519static void omap_crtc_enable(struct drm_crtc *crtc)
520{
521 struct omap_drm_private *priv = crtc->dev->dev_private;
522 struct omap_crtc *omap_crtc = to_omap_crtc(crtc);
523 unsigned int i;
524
525 DBG("%s", omap_crtc->name);
526
527 if (omap_crtc->enabled)
528 return;
529
530 /* Enable all planes associated with the CRTC. */
531 for (i = 0; i < priv->num_planes; i++) {
532 struct drm_plane *plane = priv->planes[i];
533
534 if (plane->crtc == crtc)
535 WARN_ON(omap_plane_set_enable(plane, true));
536 }
537
538 omap_crtc->enabled = true;
539
540 omap_crtc_setup(crtc);
541 omap_crtc_flush(crtc);
542
543 dispc_runtime_get();
544 drm_crtc_vblank_on(crtc);
545 dispc_runtime_put();
546}
547
548static void omap_crtc_disable(struct drm_crtc *crtc)
549{
550 struct omap_drm_private *priv = crtc->dev->dev_private;
551 struct omap_crtc *omap_crtc = to_omap_crtc(crtc);
552 unsigned int i;
553
554 DBG("%s", omap_crtc->name);
555
556 if (!omap_crtc->enabled)
557 return;
558
559 omap_crtc_wait_page_flip(crtc);
560 dispc_runtime_get();
561 drm_crtc_vblank_off(crtc);
562 dispc_runtime_put();
563
564 /* Disable all planes associated with the CRTC. */
565 for (i = 0; i < priv->num_planes; i++) {
566 struct drm_plane *plane = priv->planes[i];
567
568 if (plane->crtc == crtc)
569 WARN_ON(omap_plane_set_enable(plane, false));
570 }
571
572 omap_crtc->enabled = false;
573
574 omap_crtc_setup(crtc);
575 omap_crtc_flush(crtc);
576}
577
Rob Clarkcd5351f2011-11-12 12:09:40 -0600578static int omap_crtc_mode_set(struct drm_crtc *crtc,
Rob Clarkbb5c2d92012-01-16 12:51:16 -0600579 struct drm_display_mode *mode,
580 struct drm_display_mode *adjusted_mode,
581 int x, int y,
582 struct drm_framebuffer *old_fb)
Rob Clarkcd5351f2011-11-12 12:09:40 -0600583{
584 struct omap_crtc *omap_crtc = to_omap_crtc(crtc);
585
Rob Clarkf5f94542012-12-04 13:59:12 -0600586 mode = adjusted_mode;
587
588 DBG("%s: set mode: %d:\"%s\" %d %d %d %d %d %d %d %d %d %d 0x%x 0x%x",
589 omap_crtc->name, mode->base.id, mode->name,
590 mode->vrefresh, mode->clock,
591 mode->hdisplay, mode->hsync_start,
592 mode->hsync_end, mode->htotal,
593 mode->vdisplay, mode->vsync_start,
594 mode->vsync_end, mode->vtotal,
595 mode->type, mode->flags);
596
597 copy_timings_drm_to_omap(&omap_crtc->timings, mode);
Rob Clarkf5f94542012-12-04 13:59:12 -0600598
Laurent Pinchartef6b0e02015-01-11 00:11:18 +0200599 /*
600 * The primary plane CRTC can be reset if the plane is disabled directly
601 * through the universal plane API. Set it again here.
602 */
603 crtc->primary->crtc = crtc;
604
605 return omap_plane_mode_set(crtc->primary, crtc, crtc->primary->fb,
Laurent Pincharta350da82015-01-17 22:31:42 +0200606 0, 0, mode->hdisplay, mode->vdisplay,
Laurent Pincharta42133a2015-01-17 19:09:26 +0200607 x, y, mode->hdisplay, mode->vdisplay);
Rob Clarkcd5351f2011-11-12 12:09:40 -0600608}
609
Laurent Pinchartf1d57fb2015-03-05 22:13:22 +0200610static void omap_crtc_dpms(struct drm_crtc *crtc, int mode)
611{
612 struct omap_crtc *omap_crtc = to_omap_crtc(crtc);
613 bool enable = (mode == DRM_MODE_DPMS_ON);
614
615 DBG("%s: %d", omap_crtc->name, mode);
616
617 if (enable)
618 omap_crtc_enable(crtc);
619 else
620 omap_crtc_disable(crtc);
621}
622
Rob Clarkcd5351f2011-11-12 12:09:40 -0600623static void omap_crtc_prepare(struct drm_crtc *crtc)
624{
625 struct omap_crtc *omap_crtc = to_omap_crtc(crtc);
Rob Clarkbb5c2d92012-01-16 12:51:16 -0600626 DBG("%s", omap_crtc->name);
Rob Clarkcd5351f2011-11-12 12:09:40 -0600627 omap_crtc_dpms(crtc, DRM_MODE_DPMS_OFF);
628}
629
630static void omap_crtc_commit(struct drm_crtc *crtc)
631{
632 struct omap_crtc *omap_crtc = to_omap_crtc(crtc);
Rob Clarkbb5c2d92012-01-16 12:51:16 -0600633 DBG("%s", omap_crtc->name);
Rob Clarkcd5351f2011-11-12 12:09:40 -0600634 omap_crtc_dpms(crtc, DRM_MODE_DPMS_ON);
635}
636
637static int omap_crtc_mode_set_base(struct drm_crtc *crtc, int x, int y,
Rob Clarkbb5c2d92012-01-16 12:51:16 -0600638 struct drm_framebuffer *old_fb)
Rob Clarkcd5351f2011-11-12 12:09:40 -0600639{
Laurent Pinchartef6b0e02015-01-11 00:11:18 +0200640 struct drm_plane *plane = crtc->primary;
Rob Clarkbb5c2d92012-01-16 12:51:16 -0600641 struct drm_display_mode *mode = &crtc->mode;
Laurent Pincharta42133a2015-01-17 19:09:26 +0200642 int ret;
Rob Clarkcd5351f2011-11-12 12:09:40 -0600643
Laurent Pincharta42133a2015-01-17 19:09:26 +0200644 ret = omap_plane_mode_set(plane, crtc, crtc->primary->fb,
645 0, 0, mode->hdisplay, mode->vdisplay,
646 x, y, mode->hdisplay, mode->vdisplay);
647 if (ret < 0)
648 return ret;
Rob Clarkcd5351f2011-11-12 12:09:40 -0600649
Laurent Pincharta42133a2015-01-17 19:09:26 +0200650 return omap_crtc_flush(crtc);
Rob Clarkf5f94542012-12-04 13:59:12 -0600651}
652
653static void page_flip_worker(struct work_struct *work)
654{
655 struct omap_crtc *omap_crtc =
Laurent Pinchart42fb61c2015-01-26 02:58:51 +0200656 container_of(work, struct omap_crtc, flip_work);
Rob Clarkf5f94542012-12-04 13:59:12 -0600657 struct drm_crtc *crtc = &omap_crtc->base;
Rob Clarkf5f94542012-12-04 13:59:12 -0600658 struct drm_display_mode *mode = &crtc->mode;
Laurent Pinchart15d02e92015-01-25 22:42:30 +0200659 struct drm_device *dev = crtc->dev;
660 struct drm_framebuffer *fb;
Rob Clarkf5f94542012-12-04 13:59:12 -0600661 struct drm_gem_object *bo;
Laurent Pinchart15d02e92015-01-25 22:42:30 +0200662 unsigned long flags;
663 bool queue_flip;
Rob Clarkf5f94542012-12-04 13:59:12 -0600664
Rob Clark51fd3712013-11-19 12:10:12 -0500665 drm_modeset_lock(&crtc->mutex, NULL);
Laurent Pinchart15d02e92015-01-25 22:42:30 +0200666
667 spin_lock_irqsave(&dev->event_lock, flags);
Laurent Pinchart0c19ac92015-03-04 18:24:18 +0200668
Laurent Pinchart15d02e92015-01-25 22:42:30 +0200669 /*
670 * The page flip could have been cancelled while waiting for the GEM
671 * async operation to complete. Don't queue the flip in that case.
672 */
673 if (omap_crtc->flip_state == OMAP_PAGE_FLIP_WAIT) {
674 omap_crtc->flip_state = OMAP_PAGE_FLIP_QUEUED;
675 queue_flip = true;
676 } else {
677 omap_crtc->flip_state = OMAP_PAGE_FLIP_IDLE;
678 queue_flip = false;
679 }
Laurent Pinchart15d02e92015-01-25 22:42:30 +0200680
Laurent Pinchart0c19ac92015-03-04 18:24:18 +0200681 fb = omap_crtc->flip_fb;
682 omap_crtc->flip_fb = NULL;
683
684 spin_unlock_irqrestore(&dev->event_lock, flags);
Laurent Pinchart15d02e92015-01-25 22:42:30 +0200685
686 if (queue_flip) {
687 omap_plane_mode_set(crtc->primary, crtc, fb,
688 0, 0, mode->hdisplay, mode->vdisplay,
689 crtc->x, crtc->y, mode->hdisplay,
690 mode->vdisplay);
691 omap_crtc_flush(crtc);
692 }
693
Rob Clark51fd3712013-11-19 12:10:12 -0500694 drm_modeset_unlock(&crtc->mutex);
Rob Clarkf5f94542012-12-04 13:59:12 -0600695
Laurent Pinchart15d02e92015-01-25 22:42:30 +0200696 bo = omap_framebuffer_bo(fb, 0);
Rob Clarkf5f94542012-12-04 13:59:12 -0600697 drm_gem_object_unreference_unlocked(bo);
Laurent Pinchart0c19ac92015-03-04 18:24:18 +0200698 drm_framebuffer_unreference(fb);
Rob Clarkcd5351f2011-11-12 12:09:40 -0600699}
700
Rob Clark72d0c332012-03-11 21:11:21 -0500701static void page_flip_cb(void *arg)
702{
703 struct drm_crtc *crtc = arg;
704 struct omap_crtc *omap_crtc = to_omap_crtc(crtc);
Rob Clarkf5f94542012-12-04 13:59:12 -0600705 struct omap_drm_private *priv = crtc->dev->dev_private;
Rob Clark72d0c332012-03-11 21:11:21 -0500706
Rob Clarkf5f94542012-12-04 13:59:12 -0600707 /* avoid assumptions about what ctxt we are called from: */
Laurent Pinchart42fb61c2015-01-26 02:58:51 +0200708 queue_work(priv->wq, &omap_crtc->flip_work);
Rob Clark72d0c332012-03-11 21:11:21 -0500709}
710
Laurent Pinchart077db4d2015-01-18 16:36:19 +0200711static int omap_crtc_page_flip(struct drm_crtc *crtc,
712 struct drm_framebuffer *fb,
713 struct drm_pending_vblank_event *event,
714 uint32_t page_flip_flags)
Rob Clarkcd5351f2011-11-12 12:09:40 -0600715{
716 struct drm_device *dev = crtc->dev;
717 struct omap_crtc *omap_crtc = to_omap_crtc(crtc);
Matt Roperf4510a22014-04-01 15:22:40 -0700718 struct drm_plane *primary = crtc->primary;
Rob Clark119c0812012-09-04 17:46:22 -0500719 struct drm_gem_object *bo;
Archit Taneja38e55972014-04-11 12:53:35 +0530720 unsigned long flags;
Rob Clarkcd5351f2011-11-12 12:09:40 -0600721
Matt Roperf4510a22014-04-01 15:22:40 -0700722 DBG("%d -> %d (event=%p)", primary->fb ? primary->fb->base.id : -1,
Rob Clarkf5f94542012-12-04 13:59:12 -0600723 fb->base.id, event);
Rob Clarkcd5351f2011-11-12 12:09:40 -0600724
Archit Taneja38e55972014-04-11 12:53:35 +0530725 spin_lock_irqsave(&dev->event_lock, flags);
726
Laurent Pinchart15d02e92015-01-25 22:42:30 +0200727 if (omap_crtc->flip_state != OMAP_PAGE_FLIP_IDLE) {
Archit Taneja38e55972014-04-11 12:53:35 +0530728 spin_unlock_irqrestore(&dev->event_lock, flags);
Rob Clarkcd5351f2011-11-12 12:09:40 -0600729 dev_err(dev->dev, "already a pending flip\n");
Tomi Valkeinen549a7542014-09-03 19:25:50 +0000730 return -EBUSY;
Rob Clarkcd5351f2011-11-12 12:09:40 -0600731 }
732
Laurent Pinchart0c19ac92015-03-04 18:24:18 +0200733 /*
734 * Store a reference to the framebuffer queued for page flip in the CRTC
735 * private structure. We can't rely on crtc->primary->fb in the page
736 * flip worker, as a racing CRTC disable (due for instance to an
737 * explicit framebuffer deletion from userspace) would set that field to
738 * NULL before the worker gets a change to run.
739 */
740 drm_framebuffer_reference(fb);
741 omap_crtc->flip_fb = fb;
Laurent Pinchart42fb61c2015-01-26 02:58:51 +0200742 omap_crtc->flip_event = event;
Laurent Pinchart15d02e92015-01-25 22:42:30 +0200743 omap_crtc->flip_state = OMAP_PAGE_FLIP_WAIT;
Laurent Pinchart0c19ac92015-03-04 18:24:18 +0200744
Laurent Pinchart42fb61c2015-01-26 02:58:51 +0200745 primary->fb = fb;
Rob Clarkcd5351f2011-11-12 12:09:40 -0600746
Archit Taneja38e55972014-04-11 12:53:35 +0530747 spin_unlock_irqrestore(&dev->event_lock, flags);
748
Rob Clark119c0812012-09-04 17:46:22 -0500749 /*
750 * Hold a reference temporarily until the crtc is updated
751 * and takes the reference to the bo. This avoids it
752 * getting freed from under us:
753 */
754 bo = omap_framebuffer_bo(fb, 0);
755 drm_gem_object_reference(bo);
756
757 omap_gem_op_async(bo, OMAP_GEM_READ, page_flip_cb, crtc);
Rob Clarkcd5351f2011-11-12 12:09:40 -0600758
759 return 0;
760}
761
Rob Clark3c810c62012-08-15 15:18:01 -0500762static int omap_crtc_set_property(struct drm_crtc *crtc,
763 struct drm_property *property, uint64_t val)
764{
Laurent Pincharte2cd09b2015-03-06 17:16:43 +0200765 if (property == crtc->dev->mode_config.rotation_property) {
Rob Clark1e0fdfc2012-09-04 11:36:20 -0500766 crtc->invert_dimensions =
767 !!(val & ((1LL << DRM_ROTATE_90) | (1LL << DRM_ROTATE_270)));
768 }
769
Laurent Pinchartef6b0e02015-01-11 00:11:18 +0200770 return omap_plane_set_property(crtc->primary, property, val);
Rob Clark3c810c62012-08-15 15:18:01 -0500771}
772
Rob Clarkcd5351f2011-11-12 12:09:40 -0600773static const struct drm_crtc_funcs omap_crtc_funcs = {
Rob Clarkcd5351f2011-11-12 12:09:40 -0600774 .set_config = drm_crtc_helper_set_config,
775 .destroy = omap_crtc_destroy,
Laurent Pinchart077db4d2015-01-18 16:36:19 +0200776 .page_flip = omap_crtc_page_flip,
Rob Clark3c810c62012-08-15 15:18:01 -0500777 .set_property = omap_crtc_set_property,
Rob Clarkcd5351f2011-11-12 12:09:40 -0600778};
779
780static const struct drm_crtc_helper_funcs omap_crtc_helper_funcs = {
781 .dpms = omap_crtc_dpms,
782 .mode_fixup = omap_crtc_mode_fixup,
783 .mode_set = omap_crtc_mode_set,
784 .prepare = omap_crtc_prepare,
785 .commit = omap_crtc_commit,
786 .mode_set_base = omap_crtc_mode_set_base,
Laurent Pinchartf1d57fb2015-03-05 22:13:22 +0200787 .disable = omap_crtc_disable,
788 .enable = omap_crtc_enable,
Rob Clarkcd5351f2011-11-12 12:09:40 -0600789};
790
Laurent Pinchart971fb3e2015-01-18 01:12:59 +0200791/* -----------------------------------------------------------------------------
792 * Init and Cleanup
793 */
Tomi Valkeinene2f8fd72014-04-02 14:31:57 +0300794
Rob Clarkf5f94542012-12-04 13:59:12 -0600795static const char *channel_names[] = {
Laurent Pinchart222025e2015-01-11 00:02:07 +0200796 [OMAP_DSS_CHANNEL_LCD] = "lcd",
797 [OMAP_DSS_CHANNEL_DIGIT] = "tv",
798 [OMAP_DSS_CHANNEL_LCD2] = "lcd2",
799 [OMAP_DSS_CHANNEL_LCD3] = "lcd3",
Rob Clarkf5f94542012-12-04 13:59:12 -0600800};
801
Tomi Valkeinen04b1fc02013-05-14 10:55:19 +0300802void omap_crtc_pre_init(void)
803{
804 dss_install_mgr_ops(&mgr_ops);
805}
806
Archit Taneja3a01ab22014-01-02 14:49:51 +0530807void omap_crtc_pre_uninit(void)
808{
809 dss_uninstall_mgr_ops();
810}
811
Rob Clarkcd5351f2011-11-12 12:09:40 -0600812/* initialize crtc */
813struct drm_crtc *omap_crtc_init(struct drm_device *dev,
Rob Clarkf5f94542012-12-04 13:59:12 -0600814 struct drm_plane *plane, enum omap_channel channel, int id)
Rob Clarkcd5351f2011-11-12 12:09:40 -0600815{
816 struct drm_crtc *crtc = NULL;
Rob Clarkf5f94542012-12-04 13:59:12 -0600817 struct omap_crtc *omap_crtc;
818 struct omap_overlay_manager_info *info;
Laurent Pinchartef6b0e02015-01-11 00:11:18 +0200819 int ret;
Rob Clarkcd5351f2011-11-12 12:09:40 -0600820
Rob Clarkf5f94542012-12-04 13:59:12 -0600821 DBG("%s", channel_names[channel]);
822
823 omap_crtc = kzalloc(sizeof(*omap_crtc), GFP_KERNEL);
Joe Perches78110bb2013-02-11 09:41:29 -0800824 if (!omap_crtc)
Laurent Pinchartef6b0e02015-01-11 00:11:18 +0200825 return NULL;
Rob Clarkcd5351f2011-11-12 12:09:40 -0600826
Rob Clarkcd5351f2011-11-12 12:09:40 -0600827 crtc = &omap_crtc->base;
Rob Clarkbb5c2d92012-01-16 12:51:16 -0600828
Laurent Pinchart42fb61c2015-01-26 02:58:51 +0200829 INIT_WORK(&omap_crtc->flip_work, page_flip_worker);
Laurent Pinchartc397cfd2015-01-25 22:42:30 +0200830 init_waitqueue_head(&omap_crtc->flip_wait);
Rob Clarkf5f94542012-12-04 13:59:12 -0600831
Laurent Pincharta42133a2015-01-17 19:09:26 +0200832 INIT_LIST_HEAD(&omap_crtc->pending_unpins);
Rob Clarkf5f94542012-12-04 13:59:12 -0600833
Laurent Pincharta42133a2015-01-17 19:09:26 +0200834 init_completion(&omap_crtc->completion);
Rob Clarkf5f94542012-12-04 13:59:12 -0600835
Archit Taneja0d8f3712013-03-26 19:15:19 +0530836 omap_crtc->channel = channel;
Archit Taneja0d8f3712013-03-26 19:15:19 +0530837 omap_crtc->name = channel_names[channel];
838 omap_crtc->pipe = id;
839
Laurent Pincharta42133a2015-01-17 19:09:26 +0200840 omap_crtc->vblank_irq.irqmask = pipe2vbl(crtc);
841 omap_crtc->vblank_irq.irq = omap_crtc_vblank_irq;
Rob Clarkf5f94542012-12-04 13:59:12 -0600842
843 omap_crtc->error_irq.irqmask =
844 dispc_mgr_get_sync_lost_irq(channel);
845 omap_crtc->error_irq.irq = omap_crtc_error_irq;
846 omap_irq_register(dev, &omap_crtc->error_irq);
847
Rob Clarkf5f94542012-12-04 13:59:12 -0600848 /* temporary: */
Tomi Valkeinen04b1fc02013-05-14 10:55:19 +0300849 omap_crtc->mgr = omap_dss_get_overlay_manager(channel);
Rob Clarkf5f94542012-12-04 13:59:12 -0600850
851 /* TODO: fix hard-coded setup.. add properties! */
852 info = &omap_crtc->info;
853 info->default_color = 0x00000000;
854 info->trans_key = 0x00000000;
855 info->trans_key_type = OMAP_DSS_COLOR_KEY_GFX_DST;
856 info->trans_enabled = false;
Rob Clarkbb5c2d92012-01-16 12:51:16 -0600857
Laurent Pinchartef6b0e02015-01-11 00:11:18 +0200858 ret = drm_crtc_init_with_planes(dev, crtc, plane, NULL,
859 &omap_crtc_funcs);
860 if (ret < 0) {
861 kfree(omap_crtc);
862 return NULL;
863 }
864
Rob Clarkcd5351f2011-11-12 12:09:40 -0600865 drm_crtc_helper_add(crtc, &omap_crtc_helper_funcs);
866
Laurent Pinchartef6b0e02015-01-11 00:11:18 +0200867 omap_plane_install_properties(crtc->primary, &crtc->base);
Rob Clark3c810c62012-08-15 15:18:01 -0500868
Tomi Valkeinen04b1fc02013-05-14 10:55:19 +0300869 omap_crtcs[channel] = omap_crtc;
870
Rob Clarkcd5351f2011-11-12 12:09:40 -0600871 return crtc;
Rob Clarkcd5351f2011-11-12 12:09:40 -0600872}