commit 0f0f1b400ce3c4780b9d974bc69e8b558d99aba4
author Alan Cox <alan@lxorguk.ukuu.org.uk> Mon Sep 25 23:32:34 2006 -0700
committer Linus Torvalds <torvalds@g5.osdl.org> Tue Sep 26 08:48:56 2006 -0700
tree 9346ccc10c544c24b89b4432ad02487406c4c48c
parent a3bc0dbc81d36fd38991b4373f6de8e1a507605a

[PATCH] Voyager: tty locking

Voyager fiddles with current->signal.tty without locking.  It turns out
that the code in question has already cleared current->signal.tty correctly
because daemonize() does the right thing already.

The signal handling also appears to be incorrect as it does an unprotected
sigfillset that also appears unneccessary.  As I don't have a bowtie and am
therefore not a qualified voyager maintainer I leave that to James.

Signed-off-by: Alan Cox <alan@redhat.com>
Acked-by: James Bottomley <James.Bottomley@steeleye.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

arch/i386/mach-voyager/voyager_thread.c

diff --git a/arch/i386/mach-voyager/voyager_thread.c b/arch/i386/mach-voyager/voyager_thread.c
index 50f6de6..f398873 100644
--- a/arch/i386/mach-voyager/voyager_thread.c
+++ b/arch/i386/mach-voyager/voyager_thread.c
@@ -130,7 +130,6 @@
 	init_timer(&wakeup_timer);
 
 	sigfillset(&current->blocked);
-	current->signal->tty = NULL;
 
 	printk(KERN_NOTICE "Voyager starting monitor thread\n");