| commit | 3643b133f2cb8023e8cedcbef43215a99d7df561 | [log] [tgz] |
|---|---|---|
| author | Michael Witten <mfwitten@gmail.com> | Sat Apr 09 01:12:56 2011 +0000 |
| committer | Arnaldo Carvalho de Melo <acme@redhat.com> | Tue Apr 19 08:18:36 2011 -0300 |
| tree | 9f398308ee4f51801c2fdee40ec7ffd65f6f1642 | |
| parent | aeafcbaf4fcfeb74aeed65609ea5ead48dfc09f8 [diff] |
perf tools: Makefile: Clean up `python/perf.so' rule There is no need for a subshell or an explicit `export'; as per the POSIX Shell Command Language specification: http://pubs.opengroup.org/onlinepubs/009695399/utilities/xcu_chap02.html#tag_02_09_01 http://pubs.opengroup.org/onlinepubs/009695399/utilities/xcu_chap02.html#tag_02_10_02 It is only necessary to include the environment variable assignment just before the command to be run. Also, it is better to use single-quotes, because GNU make might expand `$(BASIC_CFLAGS)' into something that the shell could interpret within double-quotes. Acked-by: Raghavendra D Prabhu <rprabhu@wnohang.net> Link: http://lkml.kernel.org/n/tip-58n38o02ocuzrm9qh096hsf5@git.kernel.org Signed-off-by: Michael Witten <mfwitten@gmail.com> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>