tree d4fa5a124a95d33bf22276429a82822ec8d4810a
parent 721d5dfe7e516954c501d5e9d0dfab379cf4241a
author Eric Paris <eparis@redhat.com> 1225489200 -0400
committer James Morris <jmorris@namei.org> 1225492728 +1100

SELinux: properly handle empty tty_files list

SELinux has wrongly (since 2004) had an incorrect test for an empty
tty->tty_files list.  With an empty list selinux would be pointing to part
of the tty struct itself and would then proceed to dereference that value
and again dereference that result.  An F10 change to plymouth on a ppc64
system is actually currently triggering this bug.  This patch uses
list_empty() to handle empty lists rather than looking at a meaningless
location.

[note, this fixes the oops reported in
https://bugzilla.redhat.com/show_bug.cgi?id=469079]

Signed-off-by: Eric Paris <eparis@redhat.com>
Signed-off-by: James Morris <jmorris@namei.org>