V4L/DVB (12527): tw9910: do not lie about cropping abilities
The current tw9910 driver does not implement cropping correctly. Therefore, and
also because various rectangles in struct soc_camera_device are in user scale,
we cannot and shall not use rect_current as window location.
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
diff --git a/drivers/media/video/tw9910.c b/drivers/media/video/tw9910.c
index 83596cb..735d0bd 100644
--- a/drivers/media/video/tw9910.c
+++ b/drivers/media/video/tw9910.c
@@ -719,9 +719,10 @@
struct i2c_client *client = sd->priv;
struct soc_camera_device *icd = client->dev.platform_data;
struct v4l2_pix_format *pix = &f->fmt.pix;
+ /* See tw9910_set_crop() - no proper cropping support */
struct v4l2_rect rect = {
- .left = icd->rect_current.left,
- .top = icd->rect_current.top,
+ .left = 0,
+ .top = 0,
.width = pix->width,
.height = pix->height,
};
@@ -850,6 +851,7 @@
* i2c_driver function
*/
+/* This is called during probe, so, setting rect_max is Ok here: scale == 1 */
static void limit_to_scale(struct soc_camera_device *icd,
const struct tw9910_scale_ctrl *scale)
{