commit 58fb5cf5d1edb7e306574833ee55d732918c89e3
author Lothar Waßmann <LW@KARO-electronics.de> Mon Nov 28 15:38:37 2011 +0100
committer Mark Brown <broonie@opensource.wolfsonmicro.com> Mon Nov 28 14:44:38 2011 +0000
tree 56eeb31660956d2795ca068830c603d0d240c34b
parent d4d6373c1109b11c8118340be97ae31b8f94d66a

regulator: fix use after free bug

This is caused by dereferencing 'rdev' after device_unregister() in
the regulator_unregister() function.  'rdev' is freed by
device_unregister(), so it must not be dereferenced after this call.

[Edited commit message for legibility -- broonie]

Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

drivers/regulator/core.c

diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index 669d021..938398f 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -2799,8 +2799,8 @@
 	list_del(&rdev->list);
 	if (rdev->supply)
 		regulator_put(rdev->supply);
-	device_unregister(&rdev->dev);
 	kfree(rdev->constraints);
+	device_unregister(&rdev->dev);
 	mutex_unlock(&regulator_list_mutex);
 }
 EXPORT_SYMBOL_GPL(regulator_unregister);