msm: camera: don't cut to 8bits for validating enum variable
In msm_ispif_is_intf_valid(),
we convert a enum variable msm_ispif_vfe_intf,
to uint8_t type for validating.
This could cause potential issue,
if the value is crafted in such a way that lower 8bits pass the validation.
Don't use uint8_t as input parm to avoid such vulnerability.
Bug: 34624155
CRs-Fixed: 2008469
Change-Id: I4ee400ac0edd830decfbe5712966d968976a268a
Signed-off-by: Gaoxiang Chen <gaochen@codeaurora.org>
Signed-off-by: Siqi Lin <siqilin@google.com>
diff --git a/drivers/media/platform/msm/camera_v2/ispif/msm_ispif.c b/drivers/media/platform/msm/camera_v2/ispif/msm_ispif.c
index 2bfcff7..decea5d 100755
--- a/drivers/media/platform/msm/camera_v2/ispif/msm_ispif.c
+++ b/drivers/media/platform/msm/camera_v2/ispif/msm_ispif.c
@@ -289,7 +289,7 @@
}
static void msm_ispif_sel_csid_core(struct ispif_device *ispif,
- uint8_t intftype, uint8_t csid, uint8_t vfe_intf)
+ uint8_t intftype, uint8_t csid, enum msm_ispif_vfe_intf vfe_intf)
{
uint32_t data;
@@ -329,8 +329,8 @@
}
static void msm_ispif_enable_crop(struct ispif_device *ispif,
- uint8_t intftype, uint8_t vfe_intf, uint16_t start_pixel,
- uint16_t end_pixel)
+ uint8_t intftype, enum msm_ispif_vfe_intf vfe_intf,
+ uint16_t start_pixel, uint16_t end_pixel)
{
uint32_t data;
BUG_ON(!ispif);
@@ -361,7 +361,8 @@
}
static void msm_ispif_enable_intf_cids(struct ispif_device *ispif,
- uint8_t intftype, uint16_t cid_mask, uint8_t vfe_intf, uint8_t enable)
+ uint8_t intftype, uint16_t cid_mask, enum msm_ispif_vfe_intf vfe_intf,
+ uint8_t enable)
{
uint32_t intf_addr, data;
@@ -403,7 +404,7 @@
}
static int msm_ispif_validate_intf_status(struct ispif_device *ispif,
- uint8_t intftype, uint8_t vfe_intf)
+ uint8_t intftype, enum msm_ispif_vfe_intf vfe_intf)
{
int rc = 0;
uint32_t data = 0;
@@ -443,7 +444,7 @@
}
static void msm_ispif_select_clk_mux(struct ispif_device *ispif,
- uint8_t intftype, uint8_t csid, uint8_t vfe_intf)
+ uint8_t intftype, uint8_t csid, enum msm_ispif_vfe_intf vfe_intf)
{
uint32_t data = 0;