tree 08fec48e5218977d0d2db5b0a0a205c76b38f07e
parent 2d9217296bfa6fdc0d3707264076e5296faffdbd
author Tejun Heo <tj@kernel.org> 1291889922 +0100
committer Jens Axboe <jaxboe@fusionio.com> 1292518419 +0100

scsi: fix TUR error handling in sr_media_change()

sr_test_unit_ready() returns 0 iff TUR succeeded - IOW, when media is
present and the device is actually ready, so the return value wouldn't
be zero when TUR ends with sense data. sr_media_change() incorrectly
tests (retval || (scsi_sense_valid(sshdr)...)) when it tries to test
whether TUR failed without sense data or with sense data indicating
media-not-present.

Fix the test using scsi_status_is_good() and update comments.

- Fixed a comment typo spotted by Eike.

Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Rolf Eike Beer <eike-kernel@sf-tec.de>
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>