hwmon: qpnp-adc-voltage: Verify channel being read
Add channel verification to check for valid channel being
read from the voltage ADC configuration list.
Change-Id: I2e9fef065088bd4e5b9e3c6715c83c140b5b2555
Signed-off-by: Siddartha Mohanadoss <smohanad@codeaurora.org>
diff --git a/drivers/hwmon/qpnp-adc-voltage.c b/drivers/hwmon/qpnp-adc-voltage.c
index 2002895..c9620b3 100644
--- a/drivers/hwmon/qpnp-adc-voltage.c
+++ b/drivers/hwmon/qpnp-adc-voltage.c
@@ -580,11 +580,11 @@
vadc->adc->amux_prop->amux_channel = channel;
- while (vadc->adc->adc_channels[dt_index].channel_num
- != channel || dt_index > vadc->max_channels_available)
+ while ((vadc->adc->adc_channels[dt_index].channel_num
+ != channel) && (dt_index < vadc->max_channels_available))
dt_index++;
- if (dt_index > vadc->max_channels_available) {
+ if (dt_index >= vadc->max_channels_available) {
pr_err("not a valid VADC channel\n");
rc = -EINVAL;
goto fail_unlock;