msm: pil: Don't free dynamic allocations
We don't want to free the dynamic allocations for an image's
relocatable area because we can't guarantee there won't be
internal fragmentation. Reuse the region if it has already been
allocated and be sure to not free it when reinitializing the
memory map for an image.
Change-Id: Ibb7402a1a418d455572bfa6111336b3cfa312640
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
diff --git a/arch/arm/mach-msm/peripheral-loader.c b/arch/arm/mach-msm/peripheral-loader.c
index 958edaf..9703e54 100644
--- a/arch/arm/mach-msm/peripheral-loader.c
+++ b/arch/arm/mach-msm/peripheral-loader.c
@@ -323,6 +323,14 @@
unsigned int mask;
size_t size = max_addr - min_addr;
+ /* Don't reallocate due to fragmentation concerns, just sanity check */
+ if (priv->region) {
+ if (WARN(priv->region_end - priv->region_start < size,
+ "Can't reuse PIL memory, too small\n"))
+ return -ENOMEM;
+ return 0;
+ }
+
if (!ion) {
WARN_ON_ONCE("No ION client, can't support relocation\n");
return -ENOMEM;
@@ -459,9 +467,6 @@
writeq(0, &priv->info->start);
writel_relaxed(0, &priv->info->size);
- if (priv->region)
- ion_free(ion, priv->region);
- priv->region = NULL;
list_for_each_entry_safe(p, tmp, &priv->segs, list) {
list_del(&p->list);
kfree(p);
@@ -649,8 +654,13 @@
release_firmware(fw);
out:
up_read(&pil_pm_rwsem);
- if (ret)
+ if (ret) {
+ if (priv->region) {
+ ion_free(ion, priv->region);
+ priv->region = NULL;
+ }
pil_release_mmap(desc);
+ }
return ret;
}
EXPORT_SYMBOL(pil_boot);