| commit | a1104016ce8f7750ecd8ca6129786bc549aa5c38 | [log] [tgz] |
|---|---|---|
| author | Julia Lawall <julia@diku.dk> | Sat Oct 17 08:41:47 2009 +0200 |
| committer | Jeff Garzik <jgarzik@redhat.com> | Tue Nov 03 14:26:12 2009 -0500 |
| tree | 362350c913218858952d4c09b18bd3cd59969958 | |
| parent | e65cc194f7628ecaa02462f22f42fb09b50dcd49 [diff] |
drivers/ata/libata: Move dereference after NULL test In each case, if the NULL test on qc is needed, then the derefernce should be after the NULL test. A simplified version of the semantic match that detects this problem is as follows (http://coccinelle.lip6.fr/): // <smpl> @match exists@ expression x, E; identifier fld; @@ * x->fld ... when != \(x = E\|&x\) * x == NULL // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: Jeff Garzik <jgarzik@redhat.com>