commit dfad9441be82f1eadc3fa3f1bbc93f93d48d1bdf
author Pavel Emelyanov <xemul@openvz.org> Mon Oct 01 14:41:15 2007 -0700
committer J. Bruce Fields <bfields@citi.umich.edu> Tue Oct 09 18:32:46 2007 -0400
tree 059c9e1d075de6a800af3c95bbc837a2e0239819
parent fc5846e555177c2ae01bcded7fddf60cb10dcfd0

NFS: clean up explicit check for mandatory locks

The __mandatory_lock(inode) macro makes the same check, but makes the code
more readable.

Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Cc: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: "J. Bruce Fields" <bfields@fieldses.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

fs/nfs/file.c

diff --git a/fs/nfs/file.c b/fs/nfs/file.c
index 579cf8a..9c98ccb 100644
--- a/fs/nfs/file.c
+++ b/fs/nfs/file.c
@@ -522,8 +522,7 @@
 	nfs_inc_stats(inode, NFSIOS_VFSLOCK);
 
 	/* No mandatory locks over NFS */
-	if ((inode->i_mode & (S_ISGID | S_IXGRP)) == S_ISGID &&
-	    fl->fl_type != F_UNLCK)
+	if (__mandatory_lock(inode) && fl->fl_type != F_UNLCK)
 		return -ENOLCK;
 
 	if (IS_GETLK(cmd))