ASoC: msm: qdsp6v2: Unblock EOS on reset event callback
Issue: When SSR command is issued in the end of stream of
compress offload playback, ANR is seen in music app. Because
EOS is waiting indefinitely and will not return since ADSP is
dead in this case.
Fix is to unblock EOS on reset event callback from DSP.
Change-Id: Ifc379360b0ba7c589c3e2dddb7b2a3c712af7fb0
CRs-Fixed: 731606
Signed-off-by: Divya Narayanan Poojary <dnaray@codeaurora.org>
diff --git a/sound/soc/msm/qdsp6v2/msm-compress-q6-v2.c b/sound/soc/msm/qdsp6v2/msm-compress-q6-v2.c
index 4ca5764..ae5c42f 100644
--- a/sound/soc/msm/qdsp6v2/msm-compress-q6-v2.c
+++ b/sound/soc/msm/qdsp6v2/msm-compress-q6-v2.c
@@ -304,6 +304,7 @@
uint32_t sample_rate = 0;
int bytes_available, stream_id;
uint32_t stream_index;
+ unsigned long flags;
pr_debug("%s opcode =%08x\n", __func__, opcode);
switch (opcode) {
@@ -476,12 +477,17 @@
case RESET_EVENTS:
pr_err("%s: Received reset events CB, move to error state",
__func__);
- spin_lock(&prtd->lock);
+ spin_lock_irqsave(&prtd->lock, flags);
snd_compr_fragment_elapsed(cstream);
prtd->copied_total = prtd->bytes_received;
atomic_set(&prtd->error, 1);
wake_up(&prtd->drain_wait);
- spin_unlock(&prtd->lock);
+ if (atomic_read(&prtd->eos)) {
+ pr_debug("%s:unblock eos wait queues", __func__);
+ wake_up(&prtd->eos_wait);
+ atomic_set(&prtd->eos, 0);
+ }
+ spin_unlock_irqrestore(&prtd->lock, flags);
break;
default:
pr_debug("%s: Not Supported Event opcode[0x%x]\n",
@@ -1249,7 +1255,9 @@
/* Wait indefinitely for DRAIN. Flush can also signal this*/
rc = wait_event_interruptible(prtd->eos_wait,
- (prtd->cmd_ack || prtd->cmd_interrupt));
+ (prtd->cmd_ack ||
+ prtd->cmd_interrupt ||
+ atomic_read(&prtd->error)));
if (rc < 0)
pr_err("%s: EOS wait failed\n", __func__);
@@ -1260,6 +1268,11 @@
if (prtd->cmd_interrupt)
rc = -EINTR;
+ if (atomic_read(&prtd->error)) {
+ pr_err("%s: Got RESET EVENTS notification, return\n", __func__);
+ rc = -ENETRESET;
+ }
+
/*FIXME : what if a flush comes while PC is here */
if (rc == 0) {
/*