MN10300: Fix register-postinc addressing misalignment handling
Fix misalignment handling of operands with register postincrement addressing.
The flag to indicate that postincrement is required should not be interpreted
as an specification of a value to be added to the address.
Also add BUGs to catch unimplemented parameter markings in the opcodes table.
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
diff --git a/arch/mn10300/mm/misalignment.c b/arch/mn10300/mm/misalignment.c
index 614c32b..066ddc6 100644
--- a/arch/mn10300/mm/misalignment.c
+++ b/arch/mn10300/mm/misalignment.c
@@ -543,7 +543,7 @@
{
unsigned long *postinc = NULL, address = 0, tmp;
- params &= 0x7fffffff;
+ params &= 0x00ffffff;
do {
switch (params & 0xff) {
@@ -631,6 +631,7 @@
address += disp;
break;
default:
+ BUG();
return 0;
}
} while ((params >>= 8));
@@ -697,6 +698,7 @@
break;
default:
+ BUG();
return 0;
}