nfsd4: seq->status_flags may be used unitialized
Reported-by: Gopala Suryanarayana <gsuryanarayana@vmware.com>
Signed-off-by: Benny Halevy <bhalevy@tonian.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index b51ad43..1527aaf 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -1947,11 +1947,13 @@
atomic_inc(&clp->cl_refcount);
switch (clp->cl_cb_state) {
case NFSD4_CB_DOWN:
- seq->status_flags |= SEQ4_STATUS_CB_PATH_DOWN;
+ seq->status_flags = SEQ4_STATUS_CB_PATH_DOWN;
break;
case NFSD4_CB_FAULT:
- seq->status_flags |= SEQ4_STATUS_BACKCHANNEL_FAULT;
+ seq->status_flags = SEQ4_STATUS_BACKCHANNEL_FAULT;
break;
+ default:
+ seq->status_flags = 0;
}
}
kfree(conn);