Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 1 | /* |
| 2 | * HT handling |
| 3 | * |
| 4 | * Copyright 2003, Jouni Malinen <jkmaline@cc.hut.fi> |
| 5 | * Copyright 2002-2005, Instant802 Networks, Inc. |
| 6 | * Copyright 2005-2006, Devicescape Software, Inc. |
| 7 | * Copyright 2006-2007 Jiri Benc <jbenc@suse.cz> |
| 8 | * Copyright 2007, Michael Wu <flamingice@sourmilk.net> |
Johannes Berg | cfcdbde | 2010-06-10 10:21:48 +0200 | [diff] [blame] | 9 | * Copyright 2007-2010, Intel Corporation |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 10 | * |
| 11 | * This program is free software; you can redistribute it and/or modify |
| 12 | * it under the terms of the GNU General Public License version 2 as |
| 13 | * published by the Free Software Foundation. |
| 14 | */ |
| 15 | |
| 16 | #include <linux/ieee80211.h> |
Tejun Heo | 5a0e3ad | 2010-03-24 17:04:11 +0900 | [diff] [blame] | 17 | #include <linux/slab.h> |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 18 | #include <net/mac80211.h> |
| 19 | #include "ieee80211_i.h" |
Johannes Berg | 2448798 | 2009-04-23 18:52:52 +0200 | [diff] [blame] | 20 | #include "driver-ops.h" |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 21 | #include "wme.h" |
| 22 | |
Johannes Berg | 86ab6c5 | 2009-02-10 21:25:49 +0100 | [diff] [blame] | 23 | /** |
Johannes Berg | 73a72a8 | 2010-06-10 10:21:50 +0200 | [diff] [blame] | 24 | * DOC: TX A-MPDU aggregation |
Johannes Berg | 86ab6c5 | 2009-02-10 21:25:49 +0100 | [diff] [blame] | 25 | * |
| 26 | * Aggregation on the TX side requires setting the hardware flag |
Johannes Berg | 73a72a8 | 2010-06-10 10:21:50 +0200 | [diff] [blame] | 27 | * %IEEE80211_HW_AMPDU_AGGREGATION. The driver will then be handed |
| 28 | * packets with a flag indicating A-MPDU aggregation. The driver |
| 29 | * or device is responsible for actually aggregating the frames, |
| 30 | * as well as deciding how many and which to aggregate. |
Johannes Berg | 86ab6c5 | 2009-02-10 21:25:49 +0100 | [diff] [blame] | 31 | * |
Johannes Berg | 73a72a8 | 2010-06-10 10:21:50 +0200 | [diff] [blame] | 32 | * When TX aggregation is started by some subsystem (usually the rate |
| 33 | * control algorithm would be appropriate) by calling the |
| 34 | * ieee80211_start_tx_ba_session() function, the driver will be |
| 35 | * notified via its @ampdu_action function, with the |
| 36 | * %IEEE80211_AMPDU_TX_START action. |
Johannes Berg | 86ab6c5 | 2009-02-10 21:25:49 +0100 | [diff] [blame] | 37 | * |
| 38 | * In response to that, the driver is later required to call the |
Johannes Berg | 73a72a8 | 2010-06-10 10:21:50 +0200 | [diff] [blame] | 39 | * ieee80211_start_tx_ba_cb_irqsafe() function, which will really |
| 40 | * start the aggregation session after the peer has also responded. |
| 41 | * If the peer responds negatively, the session will be stopped |
| 42 | * again right away. Note that it is possible for the aggregation |
| 43 | * session to be stopped before the driver has indicated that it |
| 44 | * is done setting it up, in which case it must not indicate the |
| 45 | * setup completion. |
Johannes Berg | 86ab6c5 | 2009-02-10 21:25:49 +0100 | [diff] [blame] | 46 | * |
Johannes Berg | 73a72a8 | 2010-06-10 10:21:50 +0200 | [diff] [blame] | 47 | * Also note that, since we also need to wait for a response from |
| 48 | * the peer, the driver is notified of the completion of the |
| 49 | * handshake by the %IEEE80211_AMPDU_TX_OPERATIONAL action to the |
| 50 | * @ampdu_action callback. |
| 51 | * |
| 52 | * Similarly, when the aggregation session is stopped by the peer |
| 53 | * or something calling ieee80211_stop_tx_ba_session(), the driver's |
| 54 | * @ampdu_action function will be called with the action |
| 55 | * %IEEE80211_AMPDU_TX_STOP. In this case, the call must not fail, |
| 56 | * and the driver must later call ieee80211_stop_tx_ba_cb_irqsafe(). |
Johannes Berg | 86ab6c5 | 2009-02-10 21:25:49 +0100 | [diff] [blame] | 57 | */ |
| 58 | |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 59 | static void ieee80211_send_addba_request(struct ieee80211_sub_if_data *sdata, |
| 60 | const u8 *da, u16 tid, |
| 61 | u8 dialog_token, u16 start_seq_num, |
| 62 | u16 agg_size, u16 timeout) |
| 63 | { |
| 64 | struct ieee80211_local *local = sdata->local; |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 65 | struct sk_buff *skb; |
| 66 | struct ieee80211_mgmt *mgmt; |
| 67 | u16 capab; |
| 68 | |
| 69 | skb = dev_alloc_skb(sizeof(*mgmt) + local->hw.extra_tx_headroom); |
| 70 | |
| 71 | if (!skb) { |
| 72 | printk(KERN_ERR "%s: failed to allocate buffer " |
Johannes Berg | 47846c9 | 2009-11-25 17:46:19 +0100 | [diff] [blame] | 73 | "for addba request frame\n", sdata->name); |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 74 | return; |
| 75 | } |
| 76 | skb_reserve(skb, local->hw.extra_tx_headroom); |
| 77 | mgmt = (struct ieee80211_mgmt *) skb_put(skb, 24); |
| 78 | memset(mgmt, 0, 24); |
| 79 | memcpy(mgmt->da, da, ETH_ALEN); |
Johannes Berg | 47846c9 | 2009-11-25 17:46:19 +0100 | [diff] [blame] | 80 | memcpy(mgmt->sa, sdata->vif.addr, ETH_ALEN); |
Johannes Berg | 8abd3f9 | 2009-02-10 21:25:47 +0100 | [diff] [blame] | 81 | if (sdata->vif.type == NL80211_IFTYPE_AP || |
| 82 | sdata->vif.type == NL80211_IFTYPE_AP_VLAN) |
Johannes Berg | 47846c9 | 2009-11-25 17:46:19 +0100 | [diff] [blame] | 83 | memcpy(mgmt->bssid, sdata->vif.addr, ETH_ALEN); |
Johannes Berg | 4690029 | 2009-02-15 12:44:28 +0100 | [diff] [blame] | 84 | else if (sdata->vif.type == NL80211_IFTYPE_STATION) |
| 85 | memcpy(mgmt->bssid, sdata->u.mgd.bssid, ETH_ALEN); |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 86 | |
| 87 | mgmt->frame_control = cpu_to_le16(IEEE80211_FTYPE_MGMT | |
| 88 | IEEE80211_STYPE_ACTION); |
| 89 | |
| 90 | skb_put(skb, 1 + sizeof(mgmt->u.action.u.addba_req)); |
| 91 | |
| 92 | mgmt->u.action.category = WLAN_CATEGORY_BACK; |
| 93 | mgmt->u.action.u.addba_req.action_code = WLAN_ACTION_ADDBA_REQ; |
| 94 | |
| 95 | mgmt->u.action.u.addba_req.dialog_token = dialog_token; |
| 96 | capab = (u16)(1 << 1); /* bit 1 aggregation policy */ |
| 97 | capab |= (u16)(tid << 2); /* bit 5:2 TID number */ |
| 98 | capab |= (u16)(agg_size << 6); /* bit 15:6 max size of aggergation */ |
| 99 | |
| 100 | mgmt->u.action.u.addba_req.capab = cpu_to_le16(capab); |
| 101 | |
| 102 | mgmt->u.action.u.addba_req.timeout = cpu_to_le16(timeout); |
| 103 | mgmt->u.action.u.addba_req.start_seq_num = |
| 104 | cpu_to_le16(start_seq_num << 4); |
| 105 | |
Johannes Berg | 62ae67b | 2009-11-18 18:42:05 +0100 | [diff] [blame] | 106 | ieee80211_tx_skb(sdata, skb); |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 107 | } |
| 108 | |
| 109 | void ieee80211_send_bar(struct ieee80211_sub_if_data *sdata, u8 *ra, u16 tid, u16 ssn) |
| 110 | { |
| 111 | struct ieee80211_local *local = sdata->local; |
| 112 | struct sk_buff *skb; |
| 113 | struct ieee80211_bar *bar; |
| 114 | u16 bar_control = 0; |
| 115 | |
| 116 | skb = dev_alloc_skb(sizeof(*bar) + local->hw.extra_tx_headroom); |
| 117 | if (!skb) { |
| 118 | printk(KERN_ERR "%s: failed to allocate buffer for " |
Johannes Berg | 47846c9 | 2009-11-25 17:46:19 +0100 | [diff] [blame] | 119 | "bar frame\n", sdata->name); |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 120 | return; |
| 121 | } |
| 122 | skb_reserve(skb, local->hw.extra_tx_headroom); |
| 123 | bar = (struct ieee80211_bar *)skb_put(skb, sizeof(*bar)); |
| 124 | memset(bar, 0, sizeof(*bar)); |
| 125 | bar->frame_control = cpu_to_le16(IEEE80211_FTYPE_CTL | |
| 126 | IEEE80211_STYPE_BACK_REQ); |
| 127 | memcpy(bar->ra, ra, ETH_ALEN); |
Johannes Berg | 47846c9 | 2009-11-25 17:46:19 +0100 | [diff] [blame] | 128 | memcpy(bar->ta, sdata->vif.addr, ETH_ALEN); |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 129 | bar_control |= (u16)IEEE80211_BAR_CTRL_ACK_POLICY_NORMAL; |
| 130 | bar_control |= (u16)IEEE80211_BAR_CTRL_CBMTID_COMPRESSED_BA; |
| 131 | bar_control |= (u16)(tid << 12); |
| 132 | bar->control = cpu_to_le16(bar_control); |
| 133 | bar->start_seq_num = cpu_to_le16(ssn); |
| 134 | |
Johannes Berg | 62ae67b | 2009-11-18 18:42:05 +0100 | [diff] [blame] | 135 | IEEE80211_SKB_CB(skb)->flags |= IEEE80211_TX_INTFL_DONT_ENCRYPT; |
| 136 | ieee80211_tx_skb(sdata, skb); |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 137 | } |
| 138 | |
Johannes Berg | a622ab7 | 2010-06-10 10:21:39 +0200 | [diff] [blame] | 139 | static void kfree_tid_tx(struct rcu_head *rcu_head) |
| 140 | { |
| 141 | struct tid_ampdu_tx *tid_tx = |
| 142 | container_of(rcu_head, struct tid_ampdu_tx, rcu_head); |
| 143 | |
| 144 | kfree(tid_tx); |
| 145 | } |
| 146 | |
Johannes Berg | 67c282c | 2010-06-10 10:21:43 +0200 | [diff] [blame] | 147 | int ___ieee80211_stop_tx_ba_session(struct sta_info *sta, u16 tid, |
Johannes Berg | 53f73c0 | 2010-10-05 19:37:40 +0200 | [diff] [blame] | 148 | enum ieee80211_back_parties initiator, |
| 149 | bool tx) |
Johannes Berg | 23e6a7e | 2009-02-10 21:25:50 +0100 | [diff] [blame] | 150 | { |
Johannes Berg | 849b796 | 2009-02-10 21:25:54 +0100 | [diff] [blame] | 151 | struct ieee80211_local *local = sta->local; |
Johannes Berg | a622ab7 | 2010-06-10 10:21:39 +0200 | [diff] [blame] | 152 | struct tid_ampdu_tx *tid_tx = sta->ampdu_mlme.tid_tx[tid]; |
Johannes Berg | 23e6a7e | 2009-02-10 21:25:50 +0100 | [diff] [blame] | 153 | int ret; |
Johannes Berg | a622ab7 | 2010-06-10 10:21:39 +0200 | [diff] [blame] | 154 | |
Johannes Berg | cfcdbde | 2010-06-10 10:21:48 +0200 | [diff] [blame] | 155 | lockdep_assert_held(&sta->ampdu_mlme.mtx); |
Johannes Berg | a622ab7 | 2010-06-10 10:21:39 +0200 | [diff] [blame] | 156 | |
Johannes Berg | cfcdbde | 2010-06-10 10:21:48 +0200 | [diff] [blame] | 157 | if (!tid_tx) |
Johannes Berg | a622ab7 | 2010-06-10 10:21:39 +0200 | [diff] [blame] | 158 | return -ENOENT; |
Johannes Berg | 23e6a7e | 2009-02-10 21:25:50 +0100 | [diff] [blame] | 159 | |
Johannes Berg | cfcdbde | 2010-06-10 10:21:48 +0200 | [diff] [blame] | 160 | spin_lock_bh(&sta->lock); |
| 161 | |
Johannes Berg | 0ab3370 | 2010-06-10 10:21:42 +0200 | [diff] [blame] | 162 | if (test_bit(HT_AGG_STATE_WANT_START, &tid_tx->state)) { |
| 163 | /* not even started yet! */ |
| 164 | rcu_assign_pointer(sta->ampdu_mlme.tid_tx[tid], NULL); |
Johannes Berg | cfcdbde | 2010-06-10 10:21:48 +0200 | [diff] [blame] | 165 | spin_unlock_bh(&sta->lock); |
Johannes Berg | 0ab3370 | 2010-06-10 10:21:42 +0200 | [diff] [blame] | 166 | call_rcu(&tid_tx->rcu_head, kfree_tid_tx); |
| 167 | return 0; |
| 168 | } |
| 169 | |
Johannes Berg | cfcdbde | 2010-06-10 10:21:48 +0200 | [diff] [blame] | 170 | spin_unlock_bh(&sta->lock); |
| 171 | |
Johannes Berg | 827d42c | 2009-11-22 12:28:41 +0100 | [diff] [blame] | 172 | #ifdef CONFIG_MAC80211_HT_DEBUG |
| 173 | printk(KERN_DEBUG "Tx BA session stop requested for %pM tid %u\n", |
| 174 | sta->sta.addr, tid); |
| 175 | #endif /* CONFIG_MAC80211_HT_DEBUG */ |
| 176 | |
Johannes Berg | a622ab7 | 2010-06-10 10:21:39 +0200 | [diff] [blame] | 177 | set_bit(HT_AGG_STATE_STOPPING, &tid_tx->state); |
Johannes Berg | 23e6a7e | 2009-02-10 21:25:50 +0100 | [diff] [blame] | 178 | |
Johannes Berg | 4427148 | 2010-10-05 21:40:33 +0200 | [diff] [blame] | 179 | del_timer_sync(&tid_tx->addba_resp_timer); |
| 180 | |
Johannes Berg | a622ab7 | 2010-06-10 10:21:39 +0200 | [diff] [blame] | 181 | /* |
| 182 | * After this packets are no longer handed right through |
| 183 | * to the driver but are put onto tid_tx->pending instead, |
| 184 | * with locking to ensure proper access. |
| 185 | */ |
| 186 | clear_bit(HT_AGG_STATE_OPERATIONAL, &tid_tx->state); |
Vasanthakumar Thiagarajan | 736708b | 2009-06-09 14:11:46 +0530 | [diff] [blame] | 187 | |
Johannes Berg | a622ab7 | 2010-06-10 10:21:39 +0200 | [diff] [blame] | 188 | tid_tx->stop_initiator = initiator; |
Johannes Berg | 53f73c0 | 2010-10-05 19:37:40 +0200 | [diff] [blame] | 189 | tid_tx->tx_stop = tx; |
Johannes Berg | 23e6a7e | 2009-02-10 21:25:50 +0100 | [diff] [blame] | 190 | |
Johannes Berg | 12375ef | 2009-11-25 20:30:31 +0100 | [diff] [blame] | 191 | ret = drv_ampdu_action(local, sta->sdata, |
Johannes Berg | c951ad3 | 2009-11-16 12:00:38 +0100 | [diff] [blame] | 192 | IEEE80211_AMPDU_TX_STOP, |
Johannes Berg | 2448798 | 2009-04-23 18:52:52 +0200 | [diff] [blame] | 193 | &sta->sta, tid, NULL); |
Johannes Berg | 23e6a7e | 2009-02-10 21:25:50 +0100 | [diff] [blame] | 194 | |
| 195 | /* HW shall not deny going back to legacy */ |
| 196 | if (WARN_ON(ret)) { |
Johannes Berg | cd8ffc8 | 2009-03-23 17:28:41 +0100 | [diff] [blame] | 197 | /* |
| 198 | * We may have pending packets get stuck in this case... |
| 199 | * Not bothering with a workaround for now. |
| 200 | */ |
Johannes Berg | 23e6a7e | 2009-02-10 21:25:50 +0100 | [diff] [blame] | 201 | } |
| 202 | |
| 203 | return ret; |
| 204 | } |
| 205 | |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 206 | /* |
| 207 | * After sending add Block Ack request we activated a timer until |
| 208 | * add Block Ack response will arrive from the recipient. |
| 209 | * If this timer expires sta_addba_resp_timer_expired will be executed. |
| 210 | */ |
| 211 | static void sta_addba_resp_timer_expired(unsigned long data) |
| 212 | { |
| 213 | /* not an elegant detour, but there is no choice as the timer passes |
| 214 | * only one argument, and both sta_info and TID are needed, so init |
| 215 | * flow in sta_info_create gives the TID as data, while the timer_to_id |
| 216 | * array gives the sta through container_of */ |
| 217 | u16 tid = *(u8 *)data; |
Johannes Berg | 23e6a7e | 2009-02-10 21:25:50 +0100 | [diff] [blame] | 218 | struct sta_info *sta = container_of((void *)data, |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 219 | struct sta_info, timer_to_tid[tid]); |
Johannes Berg | a622ab7 | 2010-06-10 10:21:39 +0200 | [diff] [blame] | 220 | struct tid_ampdu_tx *tid_tx; |
Johannes Berg | 23e6a7e | 2009-02-10 21:25:50 +0100 | [diff] [blame] | 221 | |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 222 | /* check if the TID waits for addBA response */ |
Johannes Berg | 83a5cbf | 2010-06-10 10:21:47 +0200 | [diff] [blame] | 223 | rcu_read_lock(); |
| 224 | tid_tx = rcu_dereference(sta->ampdu_mlme.tid_tx[tid]); |
Johannes Berg | a622ab7 | 2010-06-10 10:21:39 +0200 | [diff] [blame] | 225 | if (!tid_tx || |
| 226 | test_bit(HT_AGG_STATE_RESPONSE_RECEIVED, &tid_tx->state)) { |
Johannes Berg | 83a5cbf | 2010-06-10 10:21:47 +0200 | [diff] [blame] | 227 | rcu_read_unlock(); |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 228 | #ifdef CONFIG_MAC80211_HT_DEBUG |
| 229 | printk(KERN_DEBUG "timer expired on tid %d but we are not " |
Johannes Berg | 67e0f39 | 2010-04-19 11:03:13 +0200 | [diff] [blame] | 230 | "(or no longer) expecting addBA response there\n", |
Johannes Berg | 8ade008 | 2009-11-18 17:15:06 +0100 | [diff] [blame] | 231 | tid); |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 232 | #endif |
Johannes Berg | 23e6a7e | 2009-02-10 21:25:50 +0100 | [diff] [blame] | 233 | return; |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 234 | } |
| 235 | |
| 236 | #ifdef CONFIG_MAC80211_HT_DEBUG |
| 237 | printk(KERN_DEBUG "addBA response timer expired on tid %d\n", tid); |
| 238 | #endif |
| 239 | |
Johannes Berg | 83a5cbf | 2010-06-10 10:21:47 +0200 | [diff] [blame] | 240 | ieee80211_stop_tx_ba_session(&sta->sta, tid); |
| 241 | rcu_read_unlock(); |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 242 | } |
| 243 | |
Johannes Berg | 96f5e66 | 2009-02-12 00:51:53 +0100 | [diff] [blame] | 244 | static inline int ieee80211_ac_from_tid(int tid) |
| 245 | { |
| 246 | return ieee802_1d_to_ac[tid & 7]; |
| 247 | } |
| 248 | |
Johannes Berg | a6a67db | 2010-06-10 10:21:41 +0200 | [diff] [blame] | 249 | /* |
| 250 | * When multiple aggregation sessions on multiple stations |
| 251 | * are being created/destroyed simultaneously, we need to |
| 252 | * refcount the global queue stop caused by that in order |
| 253 | * to not get into a situation where one of the aggregation |
| 254 | * setup or teardown re-enables queues before the other is |
| 255 | * ready to handle that. |
| 256 | * |
| 257 | * These two functions take care of this issue by keeping |
| 258 | * a global "agg_queue_stop" refcount. |
| 259 | */ |
| 260 | static void __acquires(agg_queue) |
| 261 | ieee80211_stop_queue_agg(struct ieee80211_local *local, int tid) |
| 262 | { |
| 263 | int queue = ieee80211_ac_from_tid(tid); |
| 264 | |
| 265 | if (atomic_inc_return(&local->agg_queue_stop[queue]) == 1) |
| 266 | ieee80211_stop_queue_by_reason( |
| 267 | &local->hw, queue, |
| 268 | IEEE80211_QUEUE_STOP_REASON_AGGREGATION); |
| 269 | __acquire(agg_queue); |
| 270 | } |
| 271 | |
| 272 | static void __releases(agg_queue) |
| 273 | ieee80211_wake_queue_agg(struct ieee80211_local *local, int tid) |
| 274 | { |
| 275 | int queue = ieee80211_ac_from_tid(tid); |
| 276 | |
| 277 | if (atomic_dec_return(&local->agg_queue_stop[queue]) == 0) |
| 278 | ieee80211_wake_queue_by_reason( |
| 279 | &local->hw, queue, |
| 280 | IEEE80211_QUEUE_STOP_REASON_AGGREGATION); |
| 281 | __release(agg_queue); |
| 282 | } |
| 283 | |
Johannes Berg | 67c282c | 2010-06-10 10:21:43 +0200 | [diff] [blame] | 284 | void ieee80211_tx_ba_session_handle_start(struct sta_info *sta, int tid) |
Johannes Berg | 0ab3370 | 2010-06-10 10:21:42 +0200 | [diff] [blame] | 285 | { |
| 286 | struct tid_ampdu_tx *tid_tx = sta->ampdu_mlme.tid_tx[tid]; |
| 287 | struct ieee80211_local *local = sta->local; |
| 288 | struct ieee80211_sub_if_data *sdata = sta->sdata; |
| 289 | u16 start_seq_num; |
| 290 | int ret; |
| 291 | |
Johannes Berg | cfcdbde | 2010-06-10 10:21:48 +0200 | [diff] [blame] | 292 | lockdep_assert_held(&sta->ampdu_mlme.mtx); |
| 293 | |
Johannes Berg | 0ab3370 | 2010-06-10 10:21:42 +0200 | [diff] [blame] | 294 | /* |
| 295 | * While we're asking the driver about the aggregation, |
| 296 | * stop the AC queue so that we don't have to worry |
| 297 | * about frames that came in while we were doing that, |
| 298 | * which would require us to put them to the AC pending |
| 299 | * afterwards which just makes the code more complex. |
| 300 | */ |
| 301 | ieee80211_stop_queue_agg(local, tid); |
| 302 | |
| 303 | clear_bit(HT_AGG_STATE_WANT_START, &tid_tx->state); |
| 304 | |
| 305 | /* |
Johannes Berg | cfcdbde | 2010-06-10 10:21:48 +0200 | [diff] [blame] | 306 | * make sure no packets are being processed to get |
| 307 | * valid starting sequence number |
Johannes Berg | 0ab3370 | 2010-06-10 10:21:42 +0200 | [diff] [blame] | 308 | */ |
Johannes Berg | cfcdbde | 2010-06-10 10:21:48 +0200 | [diff] [blame] | 309 | synchronize_net(); |
| 310 | |
Johannes Berg | 0ab3370 | 2010-06-10 10:21:42 +0200 | [diff] [blame] | 311 | start_seq_num = sta->tid_seq[tid] >> 4; |
| 312 | |
| 313 | ret = drv_ampdu_action(local, sdata, IEEE80211_AMPDU_TX_START, |
| 314 | &sta->sta, tid, &start_seq_num); |
| 315 | if (ret) { |
| 316 | #ifdef CONFIG_MAC80211_HT_DEBUG |
| 317 | printk(KERN_DEBUG "BA request denied - HW unavailable for" |
| 318 | " tid %d\n", tid); |
| 319 | #endif |
Johannes Berg | cfcdbde | 2010-06-10 10:21:48 +0200 | [diff] [blame] | 320 | spin_lock_bh(&sta->lock); |
Johannes Berg | 0ab3370 | 2010-06-10 10:21:42 +0200 | [diff] [blame] | 321 | rcu_assign_pointer(sta->ampdu_mlme.tid_tx[tid], NULL); |
Johannes Berg | cfcdbde | 2010-06-10 10:21:48 +0200 | [diff] [blame] | 322 | spin_unlock_bh(&sta->lock); |
| 323 | |
Johannes Berg | 0ab3370 | 2010-06-10 10:21:42 +0200 | [diff] [blame] | 324 | ieee80211_wake_queue_agg(local, tid); |
| 325 | call_rcu(&tid_tx->rcu_head, kfree_tid_tx); |
| 326 | return; |
| 327 | } |
| 328 | |
| 329 | /* we can take packets again now */ |
| 330 | ieee80211_wake_queue_agg(local, tid); |
| 331 | |
| 332 | /* activate the timer for the recipient's addBA response */ |
| 333 | mod_timer(&tid_tx->addba_resp_timer, jiffies + ADDBA_RESP_INTERVAL); |
| 334 | #ifdef CONFIG_MAC80211_HT_DEBUG |
| 335 | printk(KERN_DEBUG "activated addBA response timer on tid %d\n", tid); |
| 336 | #endif |
| 337 | |
Johannes Berg | cfcdbde | 2010-06-10 10:21:48 +0200 | [diff] [blame] | 338 | spin_lock_bh(&sta->lock); |
Johannes Berg | 0ab3370 | 2010-06-10 10:21:42 +0200 | [diff] [blame] | 339 | sta->ampdu_mlme.addba_req_num[tid]++; |
Johannes Berg | cfcdbde | 2010-06-10 10:21:48 +0200 | [diff] [blame] | 340 | spin_unlock_bh(&sta->lock); |
Johannes Berg | 0ab3370 | 2010-06-10 10:21:42 +0200 | [diff] [blame] | 341 | |
| 342 | /* send AddBA request */ |
| 343 | ieee80211_send_addba_request(sdata, sta->sta.addr, tid, |
| 344 | tid_tx->dialog_token, start_seq_num, |
Sujith Manoharan | bd2ce6e | 2010-12-15 07:47:10 +0530 | [diff] [blame] | 345 | 0x40, tid_tx->timeout); |
Johannes Berg | 0ab3370 | 2010-06-10 10:21:42 +0200 | [diff] [blame] | 346 | } |
| 347 | |
Sujith Manoharan | bd2ce6e | 2010-12-15 07:47:10 +0530 | [diff] [blame] | 348 | int ieee80211_start_tx_ba_session(struct ieee80211_sta *pubsta, u16 tid, |
| 349 | u16 timeout) |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 350 | { |
Johannes Berg | c951ad3 | 2009-11-16 12:00:38 +0100 | [diff] [blame] | 351 | struct sta_info *sta = container_of(pubsta, struct sta_info, sta); |
| 352 | struct ieee80211_sub_if_data *sdata = sta->sdata; |
| 353 | struct ieee80211_local *local = sdata->local; |
Johannes Berg | a622ab7 | 2010-06-10 10:21:39 +0200 | [diff] [blame] | 354 | struct tid_ampdu_tx *tid_tx; |
Johannes Berg | e4e72fb | 2009-03-23 17:28:42 +0100 | [diff] [blame] | 355 | int ret = 0; |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 356 | |
Johannes Berg | b5878a2 | 2010-04-07 16:48:40 +0200 | [diff] [blame] | 357 | trace_api_start_tx_ba_session(pubsta, tid); |
| 358 | |
Johannes Berg | 23e6a7e | 2009-02-10 21:25:50 +0100 | [diff] [blame] | 359 | if (WARN_ON(!local->ops->ampdu_action)) |
| 360 | return -EINVAL; |
| 361 | |
Johannes Berg | c951ad3 | 2009-11-16 12:00:38 +0100 | [diff] [blame] | 362 | if ((tid >= STA_TID_NUM) || |
| 363 | !(local->hw.flags & IEEE80211_HW_AMPDU_AGGREGATION)) |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 364 | return -EINVAL; |
| 365 | |
| 366 | #ifdef CONFIG_MAC80211_HT_DEBUG |
| 367 | printk(KERN_DEBUG "Open BA session requested for %pM tid %u\n", |
Johannes Berg | c951ad3 | 2009-11-16 12:00:38 +0100 | [diff] [blame] | 368 | pubsta->addr, tid); |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 369 | #endif /* CONFIG_MAC80211_HT_DEBUG */ |
| 370 | |
Johannes Berg | 8abd3f9 | 2009-02-10 21:25:47 +0100 | [diff] [blame] | 371 | /* |
| 372 | * The aggregation code is not prepared to handle |
| 373 | * anything but STA/AP due to the BSSID handling. |
| 374 | * IBSS could work in the code but isn't supported |
| 375 | * by drivers or the standard. |
| 376 | */ |
Johannes Berg | c951ad3 | 2009-11-16 12:00:38 +0100 | [diff] [blame] | 377 | if (sdata->vif.type != NL80211_IFTYPE_STATION && |
| 378 | sdata->vif.type != NL80211_IFTYPE_AP_VLAN && |
| 379 | sdata->vif.type != NL80211_IFTYPE_AP) |
| 380 | return -EINVAL; |
Johannes Berg | 8abd3f9 | 2009-02-10 21:25:47 +0100 | [diff] [blame] | 381 | |
Johannes Berg | 618f356 | 2010-04-06 11:18:46 +0200 | [diff] [blame] | 382 | if (test_sta_flags(sta, WLAN_STA_BLOCK_BA)) { |
Sujith | 722f069 | 2009-03-17 08:50:06 +0530 | [diff] [blame] | 383 | #ifdef CONFIG_MAC80211_HT_DEBUG |
Johannes Berg | 2a41905 | 2010-06-10 10:21:29 +0200 | [diff] [blame] | 384 | printk(KERN_DEBUG "BA sessions blocked. " |
Sujith | 722f069 | 2009-03-17 08:50:06 +0530 | [diff] [blame] | 385 | "Denying BA session request\n"); |
| 386 | #endif |
Johannes Berg | c951ad3 | 2009-11-16 12:00:38 +0100 | [diff] [blame] | 387 | return -EINVAL; |
Sujith | 722f069 | 2009-03-17 08:50:06 +0530 | [diff] [blame] | 388 | } |
| 389 | |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 390 | spin_lock_bh(&sta->lock); |
| 391 | |
| 392 | /* we have tried too many times, receiver does not want A-MPDU */ |
| 393 | if (sta->ampdu_mlme.addba_req_num[tid] > HT_AGG_MAX_RETRIES) { |
| 394 | ret = -EBUSY; |
| 395 | goto err_unlock_sta; |
| 396 | } |
| 397 | |
Johannes Berg | a622ab7 | 2010-06-10 10:21:39 +0200 | [diff] [blame] | 398 | tid_tx = sta->ampdu_mlme.tid_tx[tid]; |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 399 | /* check if the TID is not in aggregation flow already */ |
Johannes Berg | a622ab7 | 2010-06-10 10:21:39 +0200 | [diff] [blame] | 400 | if (tid_tx) { |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 401 | #ifdef CONFIG_MAC80211_HT_DEBUG |
| 402 | printk(KERN_DEBUG "BA request denied - session is not " |
| 403 | "idle on tid %u\n", tid); |
| 404 | #endif /* CONFIG_MAC80211_HT_DEBUG */ |
| 405 | ret = -EAGAIN; |
| 406 | goto err_unlock_sta; |
| 407 | } |
| 408 | |
| 409 | /* prepare A-MPDU MLME for Tx aggregation */ |
Johannes Berg | a622ab7 | 2010-06-10 10:21:39 +0200 | [diff] [blame] | 410 | tid_tx = kzalloc(sizeof(struct tid_ampdu_tx), GFP_ATOMIC); |
| 411 | if (!tid_tx) { |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 412 | #ifdef CONFIG_MAC80211_HT_DEBUG |
| 413 | if (net_ratelimit()) |
| 414 | printk(KERN_ERR "allocate tx mlme to tid %d failed\n", |
| 415 | tid); |
| 416 | #endif |
| 417 | ret = -ENOMEM; |
Johannes Berg | 0ab3370 | 2010-06-10 10:21:42 +0200 | [diff] [blame] | 418 | goto err_unlock_sta; |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 419 | } |
Johannes Berg | 96f5e66 | 2009-02-12 00:51:53 +0100 | [diff] [blame] | 420 | |
Johannes Berg | a622ab7 | 2010-06-10 10:21:39 +0200 | [diff] [blame] | 421 | skb_queue_head_init(&tid_tx->pending); |
Johannes Berg | 0ab3370 | 2010-06-10 10:21:42 +0200 | [diff] [blame] | 422 | __set_bit(HT_AGG_STATE_WANT_START, &tid_tx->state); |
Johannes Berg | cd8ffc8 | 2009-03-23 17:28:41 +0100 | [diff] [blame] | 423 | |
Sujith Manoharan | bd2ce6e | 2010-12-15 07:47:10 +0530 | [diff] [blame] | 424 | tid_tx->timeout = timeout; |
| 425 | |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 426 | /* Tx timer */ |
Johannes Berg | a622ab7 | 2010-06-10 10:21:39 +0200 | [diff] [blame] | 427 | tid_tx->addba_resp_timer.function = sta_addba_resp_timer_expired; |
| 428 | tid_tx->addba_resp_timer.data = (unsigned long)&sta->timer_to_tid[tid]; |
| 429 | init_timer(&tid_tx->addba_resp_timer); |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 430 | |
Johannes Berg | 0ab3370 | 2010-06-10 10:21:42 +0200 | [diff] [blame] | 431 | /* assign a dialog token */ |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 432 | sta->ampdu_mlme.dialog_token_allocator++; |
Johannes Berg | a622ab7 | 2010-06-10 10:21:39 +0200 | [diff] [blame] | 433 | tid_tx->dialog_token = sta->ampdu_mlme.dialog_token_allocator; |
Johannes Berg | a622ab7 | 2010-06-10 10:21:39 +0200 | [diff] [blame] | 434 | |
Johannes Berg | 0ab3370 | 2010-06-10 10:21:42 +0200 | [diff] [blame] | 435 | /* finally, assign it to the array */ |
| 436 | rcu_assign_pointer(sta->ampdu_mlme.tid_tx[tid], tid_tx); |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 437 | |
Johannes Berg | 0ab3370 | 2010-06-10 10:21:42 +0200 | [diff] [blame] | 438 | ieee80211_queue_work(&local->hw, &sta->ampdu_mlme.work); |
Johannes Berg | 51a0d38 | 2010-05-31 12:00:12 +0200 | [diff] [blame] | 439 | |
Johannes Berg | 0ab3370 | 2010-06-10 10:21:42 +0200 | [diff] [blame] | 440 | /* this flow continues off the work */ |
Johannes Berg | 96f5e66 | 2009-02-12 00:51:53 +0100 | [diff] [blame] | 441 | err_unlock_sta: |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 442 | spin_unlock_bh(&sta->lock); |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 443 | return ret; |
| 444 | } |
| 445 | EXPORT_SYMBOL(ieee80211_start_tx_ba_session); |
| 446 | |
Johannes Berg | cd8ffc8 | 2009-03-23 17:28:41 +0100 | [diff] [blame] | 447 | /* |
| 448 | * splice packets from the STA's pending to the local pending, |
Johannes Berg | a6a67db | 2010-06-10 10:21:41 +0200 | [diff] [blame] | 449 | * requires a call to ieee80211_agg_splice_finish later |
Johannes Berg | cd8ffc8 | 2009-03-23 17:28:41 +0100 | [diff] [blame] | 450 | */ |
Johannes Berg | a6a67db | 2010-06-10 10:21:41 +0200 | [diff] [blame] | 451 | static void __acquires(agg_queue) |
| 452 | ieee80211_agg_splice_packets(struct ieee80211_local *local, |
| 453 | struct tid_ampdu_tx *tid_tx, u16 tid) |
Johannes Berg | cd8ffc8 | 2009-03-23 17:28:41 +0100 | [diff] [blame] | 454 | { |
Johannes Berg | a6a67db | 2010-06-10 10:21:41 +0200 | [diff] [blame] | 455 | int queue = ieee80211_ac_from_tid(tid); |
Johannes Berg | cd8ffc8 | 2009-03-23 17:28:41 +0100 | [diff] [blame] | 456 | unsigned long flags; |
Johannes Berg | cd8ffc8 | 2009-03-23 17:28:41 +0100 | [diff] [blame] | 457 | |
Johannes Berg | a6a67db | 2010-06-10 10:21:41 +0200 | [diff] [blame] | 458 | ieee80211_stop_queue_agg(local, tid); |
Johannes Berg | cd8ffc8 | 2009-03-23 17:28:41 +0100 | [diff] [blame] | 459 | |
Johannes Berg | a622ab7 | 2010-06-10 10:21:39 +0200 | [diff] [blame] | 460 | if (WARN(!tid_tx, "TID %d gone but expected when splicing aggregates" |
| 461 | " from the pending queue\n", tid)) |
Luis R. Rodriguez | 416fbdf | 2009-08-11 13:10:33 -0700 | [diff] [blame] | 462 | return; |
| 463 | |
Johannes Berg | a622ab7 | 2010-06-10 10:21:39 +0200 | [diff] [blame] | 464 | if (!skb_queue_empty(&tid_tx->pending)) { |
Johannes Berg | cd8ffc8 | 2009-03-23 17:28:41 +0100 | [diff] [blame] | 465 | spin_lock_irqsave(&local->queue_stop_reason_lock, flags); |
Johannes Berg | cd8ffc8 | 2009-03-23 17:28:41 +0100 | [diff] [blame] | 466 | /* copy over remaining packets */ |
Johannes Berg | a622ab7 | 2010-06-10 10:21:39 +0200 | [diff] [blame] | 467 | skb_queue_splice_tail_init(&tid_tx->pending, |
| 468 | &local->pending[queue]); |
Johannes Berg | cd8ffc8 | 2009-03-23 17:28:41 +0100 | [diff] [blame] | 469 | spin_unlock_irqrestore(&local->queue_stop_reason_lock, flags); |
| 470 | } |
| 471 | } |
| 472 | |
Johannes Berg | a6a67db | 2010-06-10 10:21:41 +0200 | [diff] [blame] | 473 | static void __releases(agg_queue) |
| 474 | ieee80211_agg_splice_finish(struct ieee80211_local *local, u16 tid) |
Johannes Berg | cd8ffc8 | 2009-03-23 17:28:41 +0100 | [diff] [blame] | 475 | { |
Johannes Berg | a6a67db | 2010-06-10 10:21:41 +0200 | [diff] [blame] | 476 | ieee80211_wake_queue_agg(local, tid); |
Johannes Berg | cd8ffc8 | 2009-03-23 17:28:41 +0100 | [diff] [blame] | 477 | } |
| 478 | |
Johannes Berg | b172023 | 2009-03-23 17:28:39 +0100 | [diff] [blame] | 479 | static void ieee80211_agg_tx_operational(struct ieee80211_local *local, |
| 480 | struct sta_info *sta, u16 tid) |
| 481 | { |
Johannes Berg | cfcdbde | 2010-06-10 10:21:48 +0200 | [diff] [blame] | 482 | lockdep_assert_held(&sta->ampdu_mlme.mtx); |
Johannes Berg | a622ab7 | 2010-06-10 10:21:39 +0200 | [diff] [blame] | 483 | |
Johannes Berg | b172023 | 2009-03-23 17:28:39 +0100 | [diff] [blame] | 484 | #ifdef CONFIG_MAC80211_HT_DEBUG |
Frans Pop | 55f9893 | 2010-03-24 19:46:29 +0100 | [diff] [blame] | 485 | printk(KERN_DEBUG "Aggregation is on for tid %d\n", tid); |
Johannes Berg | b172023 | 2009-03-23 17:28:39 +0100 | [diff] [blame] | 486 | #endif |
| 487 | |
Johannes Berg | cfcdbde | 2010-06-10 10:21:48 +0200 | [diff] [blame] | 488 | drv_ampdu_action(local, sta->sdata, |
| 489 | IEEE80211_AMPDU_TX_OPERATIONAL, |
| 490 | &sta->sta, tid, NULL); |
| 491 | |
| 492 | /* |
| 493 | * synchronize with TX path, while splicing the TX path |
| 494 | * should block so it won't put more packets onto pending. |
| 495 | */ |
| 496 | spin_lock_bh(&sta->lock); |
| 497 | |
Johannes Berg | a622ab7 | 2010-06-10 10:21:39 +0200 | [diff] [blame] | 498 | ieee80211_agg_splice_packets(local, sta->ampdu_mlme.tid_tx[tid], tid); |
Johannes Berg | cd8ffc8 | 2009-03-23 17:28:41 +0100 | [diff] [blame] | 499 | /* |
Johannes Berg | a622ab7 | 2010-06-10 10:21:39 +0200 | [diff] [blame] | 500 | * Now mark as operational. This will be visible |
| 501 | * in the TX path, and lets it go lock-free in |
| 502 | * the common case. |
Johannes Berg | cd8ffc8 | 2009-03-23 17:28:41 +0100 | [diff] [blame] | 503 | */ |
Johannes Berg | a622ab7 | 2010-06-10 10:21:39 +0200 | [diff] [blame] | 504 | set_bit(HT_AGG_STATE_OPERATIONAL, &sta->ampdu_mlme.tid_tx[tid]->state); |
| 505 | ieee80211_agg_splice_finish(local, tid); |
Johannes Berg | b172023 | 2009-03-23 17:28:39 +0100 | [diff] [blame] | 506 | |
Johannes Berg | cfcdbde | 2010-06-10 10:21:48 +0200 | [diff] [blame] | 507 | spin_unlock_bh(&sta->lock); |
Johannes Berg | b172023 | 2009-03-23 17:28:39 +0100 | [diff] [blame] | 508 | } |
| 509 | |
Johannes Berg | c951ad3 | 2009-11-16 12:00:38 +0100 | [diff] [blame] | 510 | void ieee80211_start_tx_ba_cb(struct ieee80211_vif *vif, u8 *ra, u16 tid) |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 511 | { |
Johannes Berg | c951ad3 | 2009-11-16 12:00:38 +0100 | [diff] [blame] | 512 | struct ieee80211_sub_if_data *sdata = vif_to_sdata(vif); |
| 513 | struct ieee80211_local *local = sdata->local; |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 514 | struct sta_info *sta; |
Johannes Berg | a622ab7 | 2010-06-10 10:21:39 +0200 | [diff] [blame] | 515 | struct tid_ampdu_tx *tid_tx; |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 516 | |
Johannes Berg | b5878a2 | 2010-04-07 16:48:40 +0200 | [diff] [blame] | 517 | trace_api_start_tx_ba_cb(sdata, ra, tid); |
| 518 | |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 519 | if (tid >= STA_TID_NUM) { |
| 520 | #ifdef CONFIG_MAC80211_HT_DEBUG |
| 521 | printk(KERN_DEBUG "Bad TID value: tid = %d (>= %d)\n", |
| 522 | tid, STA_TID_NUM); |
| 523 | #endif |
| 524 | return; |
| 525 | } |
| 526 | |
Johannes Berg | cfcdbde | 2010-06-10 10:21:48 +0200 | [diff] [blame] | 527 | mutex_lock(&local->sta_mtx); |
Johannes Berg | abe6063 | 2009-11-25 17:46:18 +0100 | [diff] [blame] | 528 | sta = sta_info_get(sdata, ra); |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 529 | if (!sta) { |
Johannes Berg | cfcdbde | 2010-06-10 10:21:48 +0200 | [diff] [blame] | 530 | mutex_unlock(&local->sta_mtx); |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 531 | #ifdef CONFIG_MAC80211_HT_DEBUG |
| 532 | printk(KERN_DEBUG "Could not find station: %pM\n", ra); |
| 533 | #endif |
| 534 | return; |
| 535 | } |
| 536 | |
Johannes Berg | cfcdbde | 2010-06-10 10:21:48 +0200 | [diff] [blame] | 537 | mutex_lock(&sta->ampdu_mlme.mtx); |
Johannes Berg | a622ab7 | 2010-06-10 10:21:39 +0200 | [diff] [blame] | 538 | tid_tx = sta->ampdu_mlme.tid_tx[tid]; |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 539 | |
Johannes Berg | a622ab7 | 2010-06-10 10:21:39 +0200 | [diff] [blame] | 540 | if (WARN_ON(!tid_tx)) { |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 541 | #ifdef CONFIG_MAC80211_HT_DEBUG |
Johannes Berg | a622ab7 | 2010-06-10 10:21:39 +0200 | [diff] [blame] | 542 | printk(KERN_DEBUG "addBA was not requested!\n"); |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 543 | #endif |
Johannes Berg | cfcdbde | 2010-06-10 10:21:48 +0200 | [diff] [blame] | 544 | goto unlock; |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 545 | } |
| 546 | |
Johannes Berg | a622ab7 | 2010-06-10 10:21:39 +0200 | [diff] [blame] | 547 | if (WARN_ON(test_and_set_bit(HT_AGG_STATE_DRV_READY, &tid_tx->state))) |
Johannes Berg | cfcdbde | 2010-06-10 10:21:48 +0200 | [diff] [blame] | 548 | goto unlock; |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 549 | |
Johannes Berg | a622ab7 | 2010-06-10 10:21:39 +0200 | [diff] [blame] | 550 | if (test_bit(HT_AGG_STATE_RESPONSE_RECEIVED, &tid_tx->state)) |
Johannes Berg | b172023 | 2009-03-23 17:28:39 +0100 | [diff] [blame] | 551 | ieee80211_agg_tx_operational(local, sta, tid); |
Johannes Berg | 96f5e66 | 2009-02-12 00:51:53 +0100 | [diff] [blame] | 552 | |
Johannes Berg | cfcdbde | 2010-06-10 10:21:48 +0200 | [diff] [blame] | 553 | unlock: |
| 554 | mutex_unlock(&sta->ampdu_mlme.mtx); |
| 555 | mutex_unlock(&local->sta_mtx); |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 556 | } |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 557 | |
Johannes Berg | c951ad3 | 2009-11-16 12:00:38 +0100 | [diff] [blame] | 558 | void ieee80211_start_tx_ba_cb_irqsafe(struct ieee80211_vif *vif, |
Johannes Berg | 86ab6c5 | 2009-02-10 21:25:49 +0100 | [diff] [blame] | 559 | const u8 *ra, u16 tid) |
| 560 | { |
Johannes Berg | c951ad3 | 2009-11-16 12:00:38 +0100 | [diff] [blame] | 561 | struct ieee80211_sub_if_data *sdata = vif_to_sdata(vif); |
| 562 | struct ieee80211_local *local = sdata->local; |
Johannes Berg | 86ab6c5 | 2009-02-10 21:25:49 +0100 | [diff] [blame] | 563 | struct ieee80211_ra_tid *ra_tid; |
| 564 | struct sk_buff *skb = dev_alloc_skb(0); |
| 565 | |
| 566 | if (unlikely(!skb)) { |
| 567 | #ifdef CONFIG_MAC80211_HT_DEBUG |
| 568 | if (net_ratelimit()) |
| 569 | printk(KERN_WARNING "%s: Not enough memory, " |
Johannes Berg | 47846c9 | 2009-11-25 17:46:19 +0100 | [diff] [blame] | 570 | "dropping start BA session", sdata->name); |
Johannes Berg | 86ab6c5 | 2009-02-10 21:25:49 +0100 | [diff] [blame] | 571 | #endif |
| 572 | return; |
| 573 | } |
| 574 | ra_tid = (struct ieee80211_ra_tid *) &skb->cb; |
| 575 | memcpy(&ra_tid->ra, ra, ETH_ALEN); |
| 576 | ra_tid->tid = tid; |
| 577 | |
Johannes Berg | c1475ca | 2010-06-10 10:21:37 +0200 | [diff] [blame] | 578 | skb->pkt_type = IEEE80211_SDATA_QUEUE_AGG_START; |
| 579 | skb_queue_tail(&sdata->skb_queue, skb); |
| 580 | ieee80211_queue_work(&local->hw, &sdata->work); |
Johannes Berg | 86ab6c5 | 2009-02-10 21:25:49 +0100 | [diff] [blame] | 581 | } |
| 582 | EXPORT_SYMBOL(ieee80211_start_tx_ba_cb_irqsafe); |
| 583 | |
Johannes Berg | 849b796 | 2009-02-10 21:25:54 +0100 | [diff] [blame] | 584 | int __ieee80211_stop_tx_ba_session(struct sta_info *sta, u16 tid, |
Johannes Berg | 53f73c0 | 2010-10-05 19:37:40 +0200 | [diff] [blame] | 585 | enum ieee80211_back_parties initiator, |
| 586 | bool tx) |
Johannes Berg | 849b796 | 2009-02-10 21:25:54 +0100 | [diff] [blame] | 587 | { |
Johannes Berg | 849b796 | 2009-02-10 21:25:54 +0100 | [diff] [blame] | 588 | int ret; |
| 589 | |
Johannes Berg | cfcdbde | 2010-06-10 10:21:48 +0200 | [diff] [blame] | 590 | mutex_lock(&sta->ampdu_mlme.mtx); |
Johannes Berg | 849b796 | 2009-02-10 21:25:54 +0100 | [diff] [blame] | 591 | |
Johannes Berg | 53f73c0 | 2010-10-05 19:37:40 +0200 | [diff] [blame] | 592 | ret = ___ieee80211_stop_tx_ba_session(sta, tid, initiator, tx); |
Johannes Berg | 849b796 | 2009-02-10 21:25:54 +0100 | [diff] [blame] | 593 | |
Johannes Berg | cfcdbde | 2010-06-10 10:21:48 +0200 | [diff] [blame] | 594 | mutex_unlock(&sta->ampdu_mlme.mtx); |
| 595 | |
Johannes Berg | 849b796 | 2009-02-10 21:25:54 +0100 | [diff] [blame] | 596 | return ret; |
| 597 | } |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 598 | |
Johannes Berg | 6a8579d | 2010-05-27 14:41:07 +0200 | [diff] [blame] | 599 | int ieee80211_stop_tx_ba_session(struct ieee80211_sta *pubsta, u16 tid) |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 600 | { |
Johannes Berg | c951ad3 | 2009-11-16 12:00:38 +0100 | [diff] [blame] | 601 | struct sta_info *sta = container_of(pubsta, struct sta_info, sta); |
| 602 | struct ieee80211_sub_if_data *sdata = sta->sdata; |
| 603 | struct ieee80211_local *local = sdata->local; |
Johannes Berg | 0ab3370 | 2010-06-10 10:21:42 +0200 | [diff] [blame] | 604 | struct tid_ampdu_tx *tid_tx; |
| 605 | int ret = 0; |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 606 | |
Johannes Berg | 6a8579d | 2010-05-27 14:41:07 +0200 | [diff] [blame] | 607 | trace_api_stop_tx_ba_session(pubsta, tid); |
Johannes Berg | b5878a2 | 2010-04-07 16:48:40 +0200 | [diff] [blame] | 608 | |
Johannes Berg | 4253119 | 2009-11-20 09:15:51 +0100 | [diff] [blame] | 609 | if (!local->ops->ampdu_action) |
Johannes Berg | 23e6a7e | 2009-02-10 21:25:50 +0100 | [diff] [blame] | 610 | return -EINVAL; |
| 611 | |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 612 | if (tid >= STA_TID_NUM) |
| 613 | return -EINVAL; |
| 614 | |
Johannes Berg | 0ab3370 | 2010-06-10 10:21:42 +0200 | [diff] [blame] | 615 | spin_lock_bh(&sta->lock); |
| 616 | tid_tx = sta->ampdu_mlme.tid_tx[tid]; |
| 617 | |
| 618 | if (!tid_tx) { |
| 619 | ret = -ENOENT; |
| 620 | goto unlock; |
| 621 | } |
| 622 | |
| 623 | if (test_bit(HT_AGG_STATE_STOPPING, &tid_tx->state)) { |
| 624 | /* already in progress stopping it */ |
| 625 | ret = 0; |
| 626 | goto unlock; |
| 627 | } |
| 628 | |
| 629 | set_bit(HT_AGG_STATE_WANT_STOP, &tid_tx->state); |
| 630 | ieee80211_queue_work(&local->hw, &sta->ampdu_mlme.work); |
| 631 | |
| 632 | unlock: |
| 633 | spin_unlock_bh(&sta->lock); |
| 634 | return ret; |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 635 | } |
| 636 | EXPORT_SYMBOL(ieee80211_stop_tx_ba_session); |
| 637 | |
Johannes Berg | c951ad3 | 2009-11-16 12:00:38 +0100 | [diff] [blame] | 638 | void ieee80211_stop_tx_ba_cb(struct ieee80211_vif *vif, u8 *ra, u8 tid) |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 639 | { |
Johannes Berg | c951ad3 | 2009-11-16 12:00:38 +0100 | [diff] [blame] | 640 | struct ieee80211_sub_if_data *sdata = vif_to_sdata(vif); |
| 641 | struct ieee80211_local *local = sdata->local; |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 642 | struct sta_info *sta; |
Johannes Berg | a622ab7 | 2010-06-10 10:21:39 +0200 | [diff] [blame] | 643 | struct tid_ampdu_tx *tid_tx; |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 644 | |
Johannes Berg | b5878a2 | 2010-04-07 16:48:40 +0200 | [diff] [blame] | 645 | trace_api_stop_tx_ba_cb(sdata, ra, tid); |
| 646 | |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 647 | if (tid >= STA_TID_NUM) { |
| 648 | #ifdef CONFIG_MAC80211_HT_DEBUG |
| 649 | printk(KERN_DEBUG "Bad TID value: tid = %d (>= %d)\n", |
| 650 | tid, STA_TID_NUM); |
| 651 | #endif |
| 652 | return; |
| 653 | } |
| 654 | |
| 655 | #ifdef CONFIG_MAC80211_HT_DEBUG |
| 656 | printk(KERN_DEBUG "Stopping Tx BA session for %pM tid %d\n", |
| 657 | ra, tid); |
| 658 | #endif /* CONFIG_MAC80211_HT_DEBUG */ |
| 659 | |
Johannes Berg | cfcdbde | 2010-06-10 10:21:48 +0200 | [diff] [blame] | 660 | mutex_lock(&local->sta_mtx); |
| 661 | |
Johannes Berg | abe6063 | 2009-11-25 17:46:18 +0100 | [diff] [blame] | 662 | sta = sta_info_get(sdata, ra); |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 663 | if (!sta) { |
| 664 | #ifdef CONFIG_MAC80211_HT_DEBUG |
| 665 | printk(KERN_DEBUG "Could not find station: %pM\n", ra); |
| 666 | #endif |
Johannes Berg | cfcdbde | 2010-06-10 10:21:48 +0200 | [diff] [blame] | 667 | goto unlock; |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 668 | } |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 669 | |
Johannes Berg | cfcdbde | 2010-06-10 10:21:48 +0200 | [diff] [blame] | 670 | mutex_lock(&sta->ampdu_mlme.mtx); |
Johannes Berg | a622ab7 | 2010-06-10 10:21:39 +0200 | [diff] [blame] | 671 | spin_lock_bh(&sta->lock); |
| 672 | tid_tx = sta->ampdu_mlme.tid_tx[tid]; |
| 673 | |
| 674 | if (!tid_tx || !test_bit(HT_AGG_STATE_STOPPING, &tid_tx->state)) { |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 675 | #ifdef CONFIG_MAC80211_HT_DEBUG |
| 676 | printk(KERN_DEBUG "unexpected callback to A-MPDU stop\n"); |
| 677 | #endif |
Johannes Berg | cfcdbde | 2010-06-10 10:21:48 +0200 | [diff] [blame] | 678 | goto unlock_sta; |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 679 | } |
| 680 | |
Johannes Berg | 53f73c0 | 2010-10-05 19:37:40 +0200 | [diff] [blame] | 681 | if (tid_tx->stop_initiator == WLAN_BACK_INITIATOR && tid_tx->tx_stop) |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 682 | ieee80211_send_delba(sta->sdata, ra, tid, |
| 683 | WLAN_BACK_INITIATOR, WLAN_REASON_QSTA_NOT_USE); |
| 684 | |
Johannes Berg | a622ab7 | 2010-06-10 10:21:39 +0200 | [diff] [blame] | 685 | /* |
| 686 | * When we get here, the TX path will not be lockless any more wrt. |
| 687 | * aggregation, since the OPERATIONAL bit has long been cleared. |
| 688 | * Thus it will block on getting the lock, if it occurs. So if we |
| 689 | * stop the queue now, we will not get any more packets, and any |
| 690 | * that might be being processed will wait for us here, thereby |
| 691 | * guaranteeing that no packets go to the tid_tx pending queue any |
| 692 | * more. |
| 693 | */ |
| 694 | |
Johannes Berg | a622ab7 | 2010-06-10 10:21:39 +0200 | [diff] [blame] | 695 | ieee80211_agg_splice_packets(local, tid_tx, tid); |
Johannes Berg | 96f5e66 | 2009-02-12 00:51:53 +0100 | [diff] [blame] | 696 | |
Johannes Berg | a622ab7 | 2010-06-10 10:21:39 +0200 | [diff] [blame] | 697 | /* future packets must not find the tid_tx struct any more */ |
| 698 | rcu_assign_pointer(sta->ampdu_mlme.tid_tx[tid], NULL); |
Johannes Berg | 96f5e66 | 2009-02-12 00:51:53 +0100 | [diff] [blame] | 699 | |
Johannes Berg | a622ab7 | 2010-06-10 10:21:39 +0200 | [diff] [blame] | 700 | ieee80211_agg_splice_finish(local, tid); |
Johannes Berg | cd8ffc8 | 2009-03-23 17:28:41 +0100 | [diff] [blame] | 701 | |
Johannes Berg | a622ab7 | 2010-06-10 10:21:39 +0200 | [diff] [blame] | 702 | call_rcu(&tid_tx->rcu_head, kfree_tid_tx); |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 703 | |
Johannes Berg | cfcdbde | 2010-06-10 10:21:48 +0200 | [diff] [blame] | 704 | unlock_sta: |
Johannes Berg | a622ab7 | 2010-06-10 10:21:39 +0200 | [diff] [blame] | 705 | spin_unlock_bh(&sta->lock); |
Johannes Berg | cfcdbde | 2010-06-10 10:21:48 +0200 | [diff] [blame] | 706 | mutex_unlock(&sta->ampdu_mlme.mtx); |
| 707 | unlock: |
| 708 | mutex_unlock(&local->sta_mtx); |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 709 | } |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 710 | |
Johannes Berg | c951ad3 | 2009-11-16 12:00:38 +0100 | [diff] [blame] | 711 | void ieee80211_stop_tx_ba_cb_irqsafe(struct ieee80211_vif *vif, |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 712 | const u8 *ra, u16 tid) |
| 713 | { |
Johannes Berg | c951ad3 | 2009-11-16 12:00:38 +0100 | [diff] [blame] | 714 | struct ieee80211_sub_if_data *sdata = vif_to_sdata(vif); |
| 715 | struct ieee80211_local *local = sdata->local; |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 716 | struct ieee80211_ra_tid *ra_tid; |
| 717 | struct sk_buff *skb = dev_alloc_skb(0); |
| 718 | |
| 719 | if (unlikely(!skb)) { |
| 720 | #ifdef CONFIG_MAC80211_HT_DEBUG |
| 721 | if (net_ratelimit()) |
| 722 | printk(KERN_WARNING "%s: Not enough memory, " |
Johannes Berg | 47846c9 | 2009-11-25 17:46:19 +0100 | [diff] [blame] | 723 | "dropping stop BA session", sdata->name); |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 724 | #endif |
| 725 | return; |
| 726 | } |
| 727 | ra_tid = (struct ieee80211_ra_tid *) &skb->cb; |
| 728 | memcpy(&ra_tid->ra, ra, ETH_ALEN); |
| 729 | ra_tid->tid = tid; |
| 730 | |
Johannes Berg | c1475ca | 2010-06-10 10:21:37 +0200 | [diff] [blame] | 731 | skb->pkt_type = IEEE80211_SDATA_QUEUE_AGG_STOP; |
| 732 | skb_queue_tail(&sdata->skb_queue, skb); |
| 733 | ieee80211_queue_work(&local->hw, &sdata->work); |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 734 | } |
| 735 | EXPORT_SYMBOL(ieee80211_stop_tx_ba_cb_irqsafe); |
| 736 | |
Johannes Berg | 86ab6c5 | 2009-02-10 21:25:49 +0100 | [diff] [blame] | 737 | |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 738 | void ieee80211_process_addba_resp(struct ieee80211_local *local, |
| 739 | struct sta_info *sta, |
| 740 | struct ieee80211_mgmt *mgmt, |
| 741 | size_t len) |
| 742 | { |
Johannes Berg | a622ab7 | 2010-06-10 10:21:39 +0200 | [diff] [blame] | 743 | struct tid_ampdu_tx *tid_tx; |
Johannes Berg | b172023 | 2009-03-23 17:28:39 +0100 | [diff] [blame] | 744 | u16 capab, tid; |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 745 | |
| 746 | capab = le16_to_cpu(mgmt->u.action.u.addba_resp.capab); |
| 747 | tid = (capab & IEEE80211_ADDBA_PARAM_TID_MASK) >> 2; |
| 748 | |
Johannes Berg | cfcdbde | 2010-06-10 10:21:48 +0200 | [diff] [blame] | 749 | mutex_lock(&sta->ampdu_mlme.mtx); |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 750 | |
Johannes Berg | a622ab7 | 2010-06-10 10:21:39 +0200 | [diff] [blame] | 751 | tid_tx = sta->ampdu_mlme.tid_tx[tid]; |
Johannes Berg | a622ab7 | 2010-06-10 10:21:39 +0200 | [diff] [blame] | 752 | if (!tid_tx) |
Johannes Berg | 8ade008 | 2009-11-18 17:15:06 +0100 | [diff] [blame] | 753 | goto out; |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 754 | |
Johannes Berg | a622ab7 | 2010-06-10 10:21:39 +0200 | [diff] [blame] | 755 | if (mgmt->u.action.u.addba_resp.dialog_token != tid_tx->dialog_token) { |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 756 | #ifdef CONFIG_MAC80211_HT_DEBUG |
| 757 | printk(KERN_DEBUG "wrong addBA response token, tid %d\n", tid); |
Johannes Berg | a622ab7 | 2010-06-10 10:21:39 +0200 | [diff] [blame] | 758 | #endif |
Johannes Berg | 8ade008 | 2009-11-18 17:15:06 +0100 | [diff] [blame] | 759 | goto out; |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 760 | } |
| 761 | |
Johannes Berg | a622ab7 | 2010-06-10 10:21:39 +0200 | [diff] [blame] | 762 | del_timer(&tid_tx->addba_resp_timer); |
Johannes Berg | 8ade008 | 2009-11-18 17:15:06 +0100 | [diff] [blame] | 763 | |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 764 | #ifdef CONFIG_MAC80211_HT_DEBUG |
Frans Pop | 55f9893 | 2010-03-24 19:46:29 +0100 | [diff] [blame] | 765 | printk(KERN_DEBUG "switched off addBA timer for tid %d\n", tid); |
Johannes Berg | a622ab7 | 2010-06-10 10:21:39 +0200 | [diff] [blame] | 766 | #endif |
Johannes Berg | 2171abc | 2009-10-29 08:34:00 +0100 | [diff] [blame] | 767 | |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 768 | if (le16_to_cpu(mgmt->u.action.u.addba_resp.status) |
| 769 | == WLAN_STATUS_SUCCESS) { |
Johannes Berg | a622ab7 | 2010-06-10 10:21:39 +0200 | [diff] [blame] | 770 | if (test_and_set_bit(HT_AGG_STATE_RESPONSE_RECEIVED, |
| 771 | &tid_tx->state)) { |
| 772 | /* ignore duplicate response */ |
| 773 | goto out; |
| 774 | } |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 775 | |
Johannes Berg | a622ab7 | 2010-06-10 10:21:39 +0200 | [diff] [blame] | 776 | if (test_bit(HT_AGG_STATE_DRV_READY, &tid_tx->state)) |
Johannes Berg | b172023 | 2009-03-23 17:28:39 +0100 | [diff] [blame] | 777 | ieee80211_agg_tx_operational(local, sta, tid); |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 778 | |
Johannes Berg | b172023 | 2009-03-23 17:28:39 +0100 | [diff] [blame] | 779 | sta->ampdu_mlme.addba_req_num[tid] = 0; |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 780 | } else { |
Johannes Berg | 53f73c0 | 2010-10-05 19:37:40 +0200 | [diff] [blame] | 781 | ___ieee80211_stop_tx_ba_session(sta, tid, WLAN_BACK_INITIATOR, |
| 782 | true); |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 783 | } |
Johannes Berg | 2171abc | 2009-10-29 08:34:00 +0100 | [diff] [blame] | 784 | |
Johannes Berg | 2171abc | 2009-10-29 08:34:00 +0100 | [diff] [blame] | 785 | out: |
Johannes Berg | cfcdbde | 2010-06-10 10:21:48 +0200 | [diff] [blame] | 786 | mutex_unlock(&sta->ampdu_mlme.mtx); |
Johannes Berg | b8695a8 | 2009-02-10 21:25:46 +0100 | [diff] [blame] | 787 | } |