Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1 | #!/usr/bin/perl -w |
Dave Jones | dbf004d | 2010-01-12 16:59:52 -0500 | [diff] [blame] | 2 | # (c) 2001, Dave Jones. (the file handling bit) |
Andy Whitcroft | 00df344 | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 3 | # (c) 2005, Joel Schopp <jschopp@austin.ibm.com> (the ugly bit) |
Andy Whitcroft | 2a5a2c2 | 2009-01-06 14:41:23 -0800 | [diff] [blame] | 4 | # (c) 2007,2008, Andy Whitcroft <apw@uk.ibm.com> (new conditions, test suite) |
Andy Whitcroft | 131edb3 | 2009-10-26 16:50:14 -0700 | [diff] [blame] | 5 | # (c) 2008,2009, Andy Whitcroft <apw@canonical.com> |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 6 | # Licensed under the terms of the GNU GPL License version 2 |
| 7 | |
| 8 | use strict; |
| 9 | |
| 10 | my $P = $0; |
Andy Whitcroft | 00df344 | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 11 | $P =~ s@.*/@@g; |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 12 | |
Andy Whitcroft | 5e8d8f6 | 2009-10-26 16:50:17 -0700 | [diff] [blame] | 13 | my $V = '0.30'; |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 14 | |
| 15 | use Getopt::Long qw(:config no_auto_abbrev); |
| 16 | |
| 17 | my $quiet = 0; |
| 18 | my $tree = 1; |
| 19 | my $chk_signoff = 1; |
| 20 | my $chk_patch = 1; |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 21 | my $tst_only; |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 22 | my $emacs = 0; |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 23 | my $terse = 0; |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 24 | my $file = 0; |
| 25 | my $check = 0; |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 26 | my $summary = 1; |
| 27 | my $mailback = 0; |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 28 | my $summary_file = 0; |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 29 | my $root; |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 30 | my %debug; |
Hannes Eder | 77f5b10 | 2009-09-21 17:04:37 -0700 | [diff] [blame] | 31 | my $help = 0; |
| 32 | |
| 33 | sub help { |
| 34 | my ($exitcode) = @_; |
| 35 | |
| 36 | print << "EOM"; |
| 37 | Usage: $P [OPTION]... [FILE]... |
| 38 | Version: $V |
| 39 | |
| 40 | Options: |
| 41 | -q, --quiet quiet |
| 42 | --no-tree run without a kernel tree |
| 43 | --no-signoff do not check for 'Signed-off-by' line |
| 44 | --patch treat FILE as patchfile (default) |
| 45 | --emacs emacs compile window format |
| 46 | --terse one line per report |
| 47 | -f, --file treat FILE as regular source file |
| 48 | --subjective, --strict enable more subjective tests |
| 49 | --root=PATH PATH to the kernel tree root |
| 50 | --no-summary suppress the per-file summary |
| 51 | --mailback only produce a report in case of warnings/errors |
| 52 | --summary-file include the filename in summary |
| 53 | --debug KEY=[0|1] turn on/off debugging of KEY, where KEY is one of |
| 54 | 'values', 'possible', 'type', and 'attr' (default |
| 55 | is all off) |
| 56 | --test-only=WORD report only warnings/errors containing WORD |
| 57 | literally |
| 58 | -h, --help, --version display this help and exit |
| 59 | |
| 60 | When FILE is - read standard input. |
| 61 | EOM |
| 62 | |
| 63 | exit($exitcode); |
| 64 | } |
| 65 | |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 66 | GetOptions( |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 67 | 'q|quiet+' => \$quiet, |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 68 | 'tree!' => \$tree, |
| 69 | 'signoff!' => \$chk_signoff, |
| 70 | 'patch!' => \$chk_patch, |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 71 | 'emacs!' => \$emacs, |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 72 | 'terse!' => \$terse, |
Hannes Eder | 77f5b10 | 2009-09-21 17:04:37 -0700 | [diff] [blame] | 73 | 'f|file!' => \$file, |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 74 | 'subjective!' => \$check, |
| 75 | 'strict!' => \$check, |
| 76 | 'root=s' => \$root, |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 77 | 'summary!' => \$summary, |
| 78 | 'mailback!' => \$mailback, |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 79 | 'summary-file!' => \$summary_file, |
| 80 | |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 81 | 'debug=s' => \%debug, |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 82 | 'test-only=s' => \$tst_only, |
Hannes Eder | 77f5b10 | 2009-09-21 17:04:37 -0700 | [diff] [blame] | 83 | 'h|help' => \$help, |
| 84 | 'version' => \$help |
| 85 | ) or help(1); |
| 86 | |
| 87 | help(0) if ($help); |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 88 | |
| 89 | my $exit = 0; |
| 90 | |
| 91 | if ($#ARGV < 0) { |
Hannes Eder | 77f5b10 | 2009-09-21 17:04:37 -0700 | [diff] [blame] | 92 | print "$P: no input files\n"; |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 93 | exit(1); |
| 94 | } |
| 95 | |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 96 | my $dbg_values = 0; |
| 97 | my $dbg_possible = 0; |
Andy Whitcroft | 7429c69 | 2008-07-23 21:29:06 -0700 | [diff] [blame] | 98 | my $dbg_type = 0; |
Andy Whitcroft | a1ef277 | 2008-10-15 22:02:17 -0700 | [diff] [blame] | 99 | my $dbg_attr = 0; |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 100 | for my $key (keys %debug) { |
Andy Whitcroft | 21caa13 | 2009-01-06 14:41:30 -0800 | [diff] [blame] | 101 | ## no critic |
| 102 | eval "\${dbg_$key} = '$debug{$key}';"; |
| 103 | die "$@" if ($@); |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 104 | } |
| 105 | |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 106 | if ($terse) { |
| 107 | $emacs = 1; |
| 108 | $quiet++; |
| 109 | } |
| 110 | |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 111 | if ($tree) { |
| 112 | if (defined $root) { |
| 113 | if (!top_of_kernel_tree($root)) { |
| 114 | die "$P: $root: --root does not point at a valid tree\n"; |
| 115 | } |
| 116 | } else { |
| 117 | if (top_of_kernel_tree('.')) { |
| 118 | $root = '.'; |
| 119 | } elsif ($0 =~ m@(.*)/scripts/[^/]*$@ && |
| 120 | top_of_kernel_tree($1)) { |
| 121 | $root = $1; |
| 122 | } |
| 123 | } |
| 124 | |
| 125 | if (!defined $root) { |
| 126 | print "Must be run from the top-level dir. of a kernel tree\n"; |
| 127 | exit(2); |
| 128 | } |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 129 | } |
| 130 | |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 131 | my $emitted_corrupt = 0; |
| 132 | |
Andy Whitcroft | 2ceb532 | 2009-10-26 16:50:14 -0700 | [diff] [blame] | 133 | our $Ident = qr{ |
| 134 | [A-Za-z_][A-Za-z\d_]* |
| 135 | (?:\s*\#\#\s*[A-Za-z_][A-Za-z\d_]*)* |
| 136 | }x; |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 137 | our $Storage = qr{extern|static|asmlinkage}; |
| 138 | our $Sparse = qr{ |
| 139 | __user| |
| 140 | __kernel| |
| 141 | __force| |
| 142 | __iomem| |
| 143 | __must_check| |
| 144 | __init_refok| |
Andy Whitcroft | 417495e | 2009-02-27 14:03:08 -0800 | [diff] [blame] | 145 | __kprobes| |
| 146 | __ref |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 147 | }x; |
Wolfram Sang | 5213129 | 2010-03-05 13:43:51 -0800 | [diff] [blame] | 148 | |
| 149 | # Notes to $Attribute: |
| 150 | # We need \b after 'init' otherwise 'initconst' will cause a false positive in a check |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 151 | our $Attribute = qr{ |
| 152 | const| |
| 153 | __read_mostly| |
| 154 | __kprobes| |
Wolfram Sang | 5213129 | 2010-03-05 13:43:51 -0800 | [diff] [blame] | 155 | __(?:mem|cpu|dev|)(?:initdata|initconst|init\b)| |
Andy Whitcroft | 24e1d81 | 2008-10-15 22:02:18 -0700 | [diff] [blame] | 156 | ____cacheline_aligned| |
| 157 | ____cacheline_aligned_in_smp| |
Andy Whitcroft | 5fe3af1 | 2009-01-06 14:41:18 -0800 | [diff] [blame] | 158 | ____cacheline_internodealigned_in_smp| |
| 159 | __weak |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 160 | }x; |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 161 | our $Modifier; |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 162 | our $Inline = qr{inline|__always_inline|noinline}; |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 163 | our $Member = qr{->$Ident|\.$Ident|\[[^]]*\]}; |
| 164 | our $Lval = qr{$Ident(?:$Member)*}; |
| 165 | |
| 166 | our $Constant = qr{(?:[0-9]+|0x[0-9a-fA-F]+)[UL]*}; |
| 167 | our $Assignment = qr{(?:\*\=|/=|%=|\+=|-=|<<=|>>=|&=|\^=|\|=|=)}; |
Andy Whitcroft | 86f9d05 | 2009-01-06 14:41:24 -0800 | [diff] [blame] | 168 | our $Compare = qr{<=|>=|==|!=|<|>}; |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 169 | our $Operators = qr{ |
| 170 | <=|>=|==|!=| |
| 171 | =>|->|<<|>>|<|>|!|~| |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 172 | &&|\|\||,|\^|\+\+|--|&|\||\+|-|\*|\/|% |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 173 | }x; |
| 174 | |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 175 | our $NonptrType; |
| 176 | our $Type; |
| 177 | our $Declare; |
| 178 | |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 179 | our $UTF8 = qr { |
| 180 | [\x09\x0A\x0D\x20-\x7E] # ASCII |
| 181 | | [\xC2-\xDF][\x80-\xBF] # non-overlong 2-byte |
| 182 | | \xE0[\xA0-\xBF][\x80-\xBF] # excluding overlongs |
| 183 | | [\xE1-\xEC\xEE\xEF][\x80-\xBF]{2} # straight 3-byte |
| 184 | | \xED[\x80-\x9F][\x80-\xBF] # excluding surrogates |
| 185 | | \xF0[\x90-\xBF][\x80-\xBF]{2} # planes 1-3 |
| 186 | | [\xF1-\xF3][\x80-\xBF]{3} # planes 4-15 |
| 187 | | \xF4[\x80-\x8F][\x80-\xBF]{2} # plane 16 |
| 188 | }x; |
| 189 | |
Andy Whitcroft | 8ed22ca | 2008-10-15 22:02:32 -0700 | [diff] [blame] | 190 | our $typeTypedefs = qr{(?x: |
Andy Whitcroft | fb9e909 | 2009-09-21 17:04:38 -0700 | [diff] [blame] | 191 | (?:__)?(?:u|s|be|le)(?:8|16|32|64)| |
Andy Whitcroft | 8ed22ca | 2008-10-15 22:02:32 -0700 | [diff] [blame] | 192 | atomic_t |
| 193 | )}; |
| 194 | |
Joe Perches | 691e669 | 2010-03-05 13:43:51 -0800 | [diff] [blame] | 195 | our $logFunctions = qr{(?x: |
| 196 | printk| |
| 197 | pr_(debug|dbg|vdbg|devel|info|warning|err|notice|alert|crit|emerg|cont)| |
Joe Perches | 8bbea96 | 2010-08-09 17:21:01 -0700 | [diff] [blame] | 198 | (dev|netdev|netif)_(printk|dbg|vdbg|info|warn|err|notice|alert|crit|emerg|WARN)| |
Joe Perches | 691e669 | 2010-03-05 13:43:51 -0800 | [diff] [blame] | 199 | WARN| |
| 200 | panic |
| 201 | )}; |
| 202 | |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 203 | our @typeList = ( |
| 204 | qr{void}, |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 205 | qr{(?:unsigned\s+)?char}, |
| 206 | qr{(?:unsigned\s+)?short}, |
| 207 | qr{(?:unsigned\s+)?int}, |
| 208 | qr{(?:unsigned\s+)?long}, |
| 209 | qr{(?:unsigned\s+)?long\s+int}, |
| 210 | qr{(?:unsigned\s+)?long\s+long}, |
| 211 | qr{(?:unsigned\s+)?long\s+long\s+int}, |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 212 | qr{unsigned}, |
| 213 | qr{float}, |
| 214 | qr{double}, |
| 215 | qr{bool}, |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 216 | qr{struct\s+$Ident}, |
| 217 | qr{union\s+$Ident}, |
| 218 | qr{enum\s+$Ident}, |
| 219 | qr{${Ident}_t}, |
| 220 | qr{${Ident}_handler}, |
| 221 | qr{${Ident}_handler_fn}, |
| 222 | ); |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 223 | our @modifierList = ( |
| 224 | qr{fastcall}, |
| 225 | ); |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 226 | |
Wolfram Sang | 7840a94 | 2010-08-09 17:20:57 -0700 | [diff] [blame] | 227 | our $allowed_asm_includes = qr{(?x: |
| 228 | irq| |
| 229 | memory |
| 230 | )}; |
| 231 | # memory.h: ARM has a custom one |
| 232 | |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 233 | sub build_types { |
Andy Whitcroft | d2172eb | 2008-07-23 21:29:07 -0700 | [diff] [blame] | 234 | my $mods = "(?x: \n" . join("|\n ", @modifierList) . "\n)"; |
| 235 | my $all = "(?x: \n" . join("|\n ", @typeList) . "\n)"; |
Andy Whitcroft | c8cb2ca | 2008-07-23 21:28:57 -0700 | [diff] [blame] | 236 | $Modifier = qr{(?:$Attribute|$Sparse|$mods)}; |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 237 | $NonptrType = qr{ |
Andy Whitcroft | d2172eb | 2008-07-23 21:29:07 -0700 | [diff] [blame] | 238 | (?:$Modifier\s+|const\s+)* |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 239 | (?: |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 240 | (?:typeof|__typeof__)\s*\(\s*\**\s*$Ident\s*\)| |
Andy Whitcroft | 8ed22ca | 2008-10-15 22:02:32 -0700 | [diff] [blame] | 241 | (?:$typeTypedefs\b)| |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 242 | (?:${all}\b) |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 243 | ) |
Andy Whitcroft | c8cb2ca | 2008-07-23 21:28:57 -0700 | [diff] [blame] | 244 | (?:\s+$Modifier|\s+const)* |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 245 | }x; |
| 246 | $Type = qr{ |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 247 | $NonptrType |
Andy Whitcroft | 6586386 | 2009-01-06 14:41:21 -0800 | [diff] [blame] | 248 | (?:[\s\*]+\s*const|[\s\*]+|(?:\s*\[\s*\])+)? |
Andy Whitcroft | c8cb2ca | 2008-07-23 21:28:57 -0700 | [diff] [blame] | 249 | (?:\s+$Inline|\s+$Modifier)* |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 250 | }x; |
| 251 | $Declare = qr{(?:$Storage\s+)?$Type}; |
| 252 | } |
| 253 | build_types(); |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 254 | |
| 255 | $chk_signoff = 0 if ($file); |
| 256 | |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 257 | my @dep_includes = (); |
| 258 | my @dep_functions = (); |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 259 | my $removal = "Documentation/feature-removal-schedule.txt"; |
| 260 | if ($tree && -f "$root/$removal") { |
Andy Whitcroft | 21caa13 | 2009-01-06 14:41:30 -0800 | [diff] [blame] | 261 | open(my $REMOVE, '<', "$root/$removal") || |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 262 | die "$P: $removal: open failed - $!\n"; |
Andy Whitcroft | 21caa13 | 2009-01-06 14:41:30 -0800 | [diff] [blame] | 263 | while (<$REMOVE>) { |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 264 | if (/^Check:\s+(.*\S)/) { |
| 265 | for my $entry (split(/[, ]+/, $1)) { |
| 266 | if ($entry =~ m@include/(.*)@) { |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 267 | push(@dep_includes, $1); |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 268 | |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 269 | } elsif ($entry !~ m@/@) { |
| 270 | push(@dep_functions, $entry); |
| 271 | } |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 272 | } |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 273 | } |
| 274 | } |
Andy Whitcroft | 21caa13 | 2009-01-06 14:41:30 -0800 | [diff] [blame] | 275 | close($REMOVE); |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 276 | } |
| 277 | |
Andy Whitcroft | 00df344 | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 278 | my @rawlines = (); |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 279 | my @lines = (); |
| 280 | my $vname; |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 281 | for my $filename (@ARGV) { |
Andy Whitcroft | 21caa13 | 2009-01-06 14:41:30 -0800 | [diff] [blame] | 282 | my $FILE; |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 283 | if ($file) { |
Andy Whitcroft | 21caa13 | 2009-01-06 14:41:30 -0800 | [diff] [blame] | 284 | open($FILE, '-|', "diff -u /dev/null $filename") || |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 285 | die "$P: $filename: diff failed - $!\n"; |
Andy Whitcroft | 21caa13 | 2009-01-06 14:41:30 -0800 | [diff] [blame] | 286 | } elsif ($filename eq '-') { |
| 287 | open($FILE, '<&STDIN'); |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 288 | } else { |
Andy Whitcroft | 21caa13 | 2009-01-06 14:41:30 -0800 | [diff] [blame] | 289 | open($FILE, '<', "$filename") || |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 290 | die "$P: $filename: open failed - $!\n"; |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 291 | } |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 292 | if ($filename eq '-') { |
| 293 | $vname = 'Your patch'; |
| 294 | } else { |
| 295 | $vname = $filename; |
| 296 | } |
Andy Whitcroft | 21caa13 | 2009-01-06 14:41:30 -0800 | [diff] [blame] | 297 | while (<$FILE>) { |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 298 | chomp; |
| 299 | push(@rawlines, $_); |
| 300 | } |
Andy Whitcroft | 21caa13 | 2009-01-06 14:41:30 -0800 | [diff] [blame] | 301 | close($FILE); |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 302 | if (!process($filename)) { |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 303 | $exit = 1; |
| 304 | } |
| 305 | @rawlines = (); |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 306 | @lines = (); |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 307 | } |
| 308 | |
| 309 | exit($exit); |
| 310 | |
| 311 | sub top_of_kernel_tree { |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 312 | my ($root) = @_; |
| 313 | |
| 314 | my @tree_check = ( |
| 315 | "COPYING", "CREDITS", "Kbuild", "MAINTAINERS", "Makefile", |
| 316 | "README", "Documentation", "arch", "include", "drivers", |
| 317 | "fs", "init", "ipc", "kernel", "lib", "scripts", |
| 318 | ); |
| 319 | |
| 320 | foreach my $check (@tree_check) { |
| 321 | if (! -e $root . '/' . $check) { |
| 322 | return 0; |
| 323 | } |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 324 | } |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 325 | return 1; |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 326 | } |
| 327 | |
| 328 | sub expand_tabs { |
| 329 | my ($str) = @_; |
| 330 | |
| 331 | my $res = ''; |
| 332 | my $n = 0; |
| 333 | for my $c (split(//, $str)) { |
| 334 | if ($c eq "\t") { |
| 335 | $res .= ' '; |
| 336 | $n++; |
| 337 | for (; ($n % 8) != 0; $n++) { |
| 338 | $res .= ' '; |
| 339 | } |
| 340 | next; |
| 341 | } |
| 342 | $res .= $c; |
| 343 | $n++; |
| 344 | } |
| 345 | |
| 346 | return $res; |
| 347 | } |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 348 | sub copy_spacing { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 349 | (my $res = shift) =~ tr/\t/ /c; |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 350 | return $res; |
| 351 | } |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 352 | |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 353 | sub line_stats { |
| 354 | my ($line) = @_; |
| 355 | |
| 356 | # Drop the diff line leader and expand tabs |
| 357 | $line =~ s/^.//; |
| 358 | $line = expand_tabs($line); |
| 359 | |
| 360 | # Pick the indent from the front of the line. |
| 361 | my ($white) = ($line =~ /^(\s*)/); |
| 362 | |
| 363 | return (length($line), length($white)); |
| 364 | } |
| 365 | |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 366 | my $sanitise_quote = ''; |
| 367 | |
| 368 | sub sanitise_line_reset { |
| 369 | my ($in_comment) = @_; |
| 370 | |
| 371 | if ($in_comment) { |
| 372 | $sanitise_quote = '*/'; |
| 373 | } else { |
| 374 | $sanitise_quote = ''; |
| 375 | } |
| 376 | } |
Andy Whitcroft | 00df344 | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 377 | sub sanitise_line { |
| 378 | my ($line) = @_; |
| 379 | |
| 380 | my $res = ''; |
| 381 | my $l = ''; |
| 382 | |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 383 | my $qlen = 0; |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 384 | my $off = 0; |
| 385 | my $c; |
Andy Whitcroft | 00df344 | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 386 | |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 387 | # Always copy over the diff marker. |
| 388 | $res = substr($line, 0, 1); |
| 389 | |
| 390 | for ($off = 1; $off < length($line); $off++) { |
| 391 | $c = substr($line, $off, 1); |
| 392 | |
| 393 | # Comments we are wacking completly including the begin |
| 394 | # and end, all to $;. |
| 395 | if ($sanitise_quote eq '' && substr($line, $off, 2) eq '/*') { |
| 396 | $sanitise_quote = '*/'; |
| 397 | |
| 398 | substr($res, $off, 2, "$;$;"); |
| 399 | $off++; |
| 400 | next; |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 401 | } |
Andy Whitcroft | 81bc0e0 | 2008-10-15 22:02:26 -0700 | [diff] [blame] | 402 | if ($sanitise_quote eq '*/' && substr($line, $off, 2) eq '*/') { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 403 | $sanitise_quote = ''; |
| 404 | substr($res, $off, 2, "$;$;"); |
| 405 | $off++; |
| 406 | next; |
| 407 | } |
Daniel Walker | 113f04a | 2009-09-21 17:04:35 -0700 | [diff] [blame] | 408 | if ($sanitise_quote eq '' && substr($line, $off, 2) eq '//') { |
| 409 | $sanitise_quote = '//'; |
| 410 | |
| 411 | substr($res, $off, 2, $sanitise_quote); |
| 412 | $off++; |
| 413 | next; |
| 414 | } |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 415 | |
| 416 | # A \ in a string means ignore the next character. |
| 417 | if (($sanitise_quote eq "'" || $sanitise_quote eq '"') && |
| 418 | $c eq "\\") { |
| 419 | substr($res, $off, 2, 'XX'); |
| 420 | $off++; |
| 421 | next; |
| 422 | } |
| 423 | # Regular quotes. |
| 424 | if ($c eq "'" || $c eq '"') { |
| 425 | if ($sanitise_quote eq '') { |
| 426 | $sanitise_quote = $c; |
| 427 | |
| 428 | substr($res, $off, 1, $c); |
Andy Whitcroft | 00df344 | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 429 | next; |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 430 | } elsif ($sanitise_quote eq $c) { |
| 431 | $sanitise_quote = ''; |
Andy Whitcroft | 00df344 | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 432 | } |
| 433 | } |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 434 | |
Andy Whitcroft | fae17da | 2009-01-06 14:41:20 -0800 | [diff] [blame] | 435 | #print "c<$c> SQ<$sanitise_quote>\n"; |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 436 | if ($off != 0 && $sanitise_quote eq '*/' && $c ne "\t") { |
| 437 | substr($res, $off, 1, $;); |
Daniel Walker | 113f04a | 2009-09-21 17:04:35 -0700 | [diff] [blame] | 438 | } elsif ($off != 0 && $sanitise_quote eq '//' && $c ne "\t") { |
| 439 | substr($res, $off, 1, $;); |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 440 | } elsif ($off != 0 && $sanitise_quote && $c ne "\t") { |
| 441 | substr($res, $off, 1, 'X'); |
Andy Whitcroft | 00df344 | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 442 | } else { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 443 | substr($res, $off, 1, $c); |
Andy Whitcroft | 00df344 | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 444 | } |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 445 | } |
| 446 | |
Daniel Walker | 113f04a | 2009-09-21 17:04:35 -0700 | [diff] [blame] | 447 | if ($sanitise_quote eq '//') { |
| 448 | $sanitise_quote = ''; |
| 449 | } |
| 450 | |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 451 | # The pathname on a #include may be surrounded by '<' and '>'. |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 452 | if ($res =~ /^.\s*\#\s*include\s+\<(.*)\>/) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 453 | my $clean = 'X' x length($1); |
| 454 | $res =~ s@\<.*\>@<$clean>@; |
| 455 | |
| 456 | # The whole of a #error is a string. |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 457 | } elsif ($res =~ /^.\s*\#\s*(?:error|warning)\s+(.*)\b/) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 458 | my $clean = 'X' x length($1); |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 459 | $res =~ s@(\#\s*(?:error|warning)\s+).*@$1$clean@; |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 460 | } |
| 461 | |
Andy Whitcroft | 00df344 | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 462 | return $res; |
| 463 | } |
| 464 | |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 465 | sub ctx_statement_block { |
| 466 | my ($linenr, $remain, $off) = @_; |
| 467 | my $line = $linenr - 1; |
| 468 | my $blk = ''; |
| 469 | my $soff = $off; |
| 470 | my $coff = $off - 1; |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 471 | my $coff_set = 0; |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 472 | |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 473 | my $loff = 0; |
| 474 | |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 475 | my $type = ''; |
| 476 | my $level = 0; |
Andy Whitcroft | a275064 | 2009-01-15 13:51:04 -0800 | [diff] [blame] | 477 | my @stack = (); |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 478 | my $p; |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 479 | my $c; |
| 480 | my $len = 0; |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 481 | |
| 482 | my $remainder; |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 483 | while (1) { |
Andy Whitcroft | a275064 | 2009-01-15 13:51:04 -0800 | [diff] [blame] | 484 | @stack = (['', 0]) if ($#stack == -1); |
| 485 | |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 486 | #warn "CSB: blk<$blk> remain<$remain>\n"; |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 487 | # If we are about to drop off the end, pull in more |
| 488 | # context. |
| 489 | if ($off >= $len) { |
| 490 | for (; $remain > 0; $line++) { |
Andy Whitcroft | dea3349 | 2008-10-15 22:02:25 -0700 | [diff] [blame] | 491 | last if (!defined $lines[$line]); |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 492 | next if ($lines[$line] =~ /^-/); |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 493 | $remain--; |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 494 | $loff = $len; |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 495 | $blk .= $lines[$line] . "\n"; |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 496 | $len = length($blk); |
| 497 | $line++; |
| 498 | last; |
| 499 | } |
| 500 | # Bail if there is no further context. |
| 501 | #warn "CSB: blk<$blk> off<$off> len<$len>\n"; |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 502 | if ($off >= $len) { |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 503 | last; |
| 504 | } |
| 505 | } |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 506 | $p = $c; |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 507 | $c = substr($blk, $off, 1); |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 508 | $remainder = substr($blk, $off); |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 509 | |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 510 | #warn "CSB: c<$c> type<$type> level<$level> remainder<$remainder> coff_set<$coff_set>\n"; |
Andy Whitcroft | 4635f4f | 2009-01-06 14:41:27 -0800 | [diff] [blame] | 511 | |
| 512 | # Handle nested #if/#else. |
| 513 | if ($remainder =~ /^#\s*(?:ifndef|ifdef|if)\s/) { |
| 514 | push(@stack, [ $type, $level ]); |
| 515 | } elsif ($remainder =~ /^#\s*(?:else|elif)\b/) { |
| 516 | ($type, $level) = @{$stack[$#stack - 1]}; |
| 517 | } elsif ($remainder =~ /^#\s*endif\b/) { |
| 518 | ($type, $level) = @{pop(@stack)}; |
| 519 | } |
| 520 | |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 521 | # Statement ends at the ';' or a close '}' at the |
| 522 | # outermost level. |
| 523 | if ($level == 0 && $c eq ';') { |
| 524 | last; |
| 525 | } |
| 526 | |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 527 | # An else is really a conditional as long as its not else if |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 528 | if ($level == 0 && $coff_set == 0 && |
| 529 | (!defined($p) || $p =~ /(?:\s|\}|\+)/) && |
| 530 | $remainder =~ /^(else)(?:\s|{)/ && |
| 531 | $remainder !~ /^else\s+if\b/) { |
| 532 | $coff = $off + length($1) - 1; |
| 533 | $coff_set = 1; |
| 534 | #warn "CSB: mark coff<$coff> soff<$soff> 1<$1>\n"; |
| 535 | #warn "[" . substr($blk, $soff, $coff - $soff + 1) . "]\n"; |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 536 | } |
| 537 | |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 538 | if (($type eq '' || $type eq '(') && $c eq '(') { |
| 539 | $level++; |
| 540 | $type = '('; |
| 541 | } |
| 542 | if ($type eq '(' && $c eq ')') { |
| 543 | $level--; |
| 544 | $type = ($level != 0)? '(' : ''; |
| 545 | |
| 546 | if ($level == 0 && $coff < $soff) { |
| 547 | $coff = $off; |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 548 | $coff_set = 1; |
| 549 | #warn "CSB: mark coff<$coff>\n"; |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 550 | } |
| 551 | } |
| 552 | if (($type eq '' || $type eq '{') && $c eq '{') { |
| 553 | $level++; |
| 554 | $type = '{'; |
| 555 | } |
| 556 | if ($type eq '{' && $c eq '}') { |
| 557 | $level--; |
| 558 | $type = ($level != 0)? '{' : ''; |
| 559 | |
| 560 | if ($level == 0) { |
Patrick Pannuto | b998e00 | 2010-08-09 17:21:03 -0700 | [diff] [blame] | 561 | if (substr($blk, $off + 1, 1) eq ';') { |
| 562 | $off++; |
| 563 | } |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 564 | last; |
| 565 | } |
| 566 | } |
| 567 | $off++; |
| 568 | } |
Andy Whitcroft | a3bb97a | 2008-07-23 21:29:00 -0700 | [diff] [blame] | 569 | # We are truly at the end, so shuffle to the next line. |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 570 | if ($off == $len) { |
Andy Whitcroft | a3bb97a | 2008-07-23 21:29:00 -0700 | [diff] [blame] | 571 | $loff = $len + 1; |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 572 | $line++; |
| 573 | $remain--; |
| 574 | } |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 575 | |
| 576 | my $statement = substr($blk, $soff, $off - $soff + 1); |
| 577 | my $condition = substr($blk, $soff, $coff - $soff + 1); |
| 578 | |
| 579 | #warn "STATEMENT<$statement>\n"; |
| 580 | #warn "CONDITION<$condition>\n"; |
| 581 | |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 582 | #print "coff<$coff> soff<$off> loff<$loff>\n"; |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 583 | |
| 584 | return ($statement, $condition, |
| 585 | $line, $remain + 1, $off - $loff + 1, $level); |
| 586 | } |
| 587 | |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 588 | sub statement_lines { |
| 589 | my ($stmt) = @_; |
| 590 | |
| 591 | # Strip the diff line prefixes and rip blank lines at start and end. |
| 592 | $stmt =~ s/(^|\n)./$1/g; |
| 593 | $stmt =~ s/^\s*//; |
| 594 | $stmt =~ s/\s*$//; |
| 595 | |
| 596 | my @stmt_lines = ($stmt =~ /\n/g); |
| 597 | |
| 598 | return $#stmt_lines + 2; |
| 599 | } |
| 600 | |
| 601 | sub statement_rawlines { |
| 602 | my ($stmt) = @_; |
| 603 | |
| 604 | my @stmt_lines = ($stmt =~ /\n/g); |
| 605 | |
| 606 | return $#stmt_lines + 2; |
| 607 | } |
| 608 | |
| 609 | sub statement_block_size { |
| 610 | my ($stmt) = @_; |
| 611 | |
| 612 | $stmt =~ s/(^|\n)./$1/g; |
| 613 | $stmt =~ s/^\s*{//; |
| 614 | $stmt =~ s/}\s*$//; |
| 615 | $stmt =~ s/^\s*//; |
| 616 | $stmt =~ s/\s*$//; |
| 617 | |
| 618 | my @stmt_lines = ($stmt =~ /\n/g); |
| 619 | my @stmt_statements = ($stmt =~ /;/g); |
| 620 | |
| 621 | my $stmt_lines = $#stmt_lines + 2; |
| 622 | my $stmt_statements = $#stmt_statements + 1; |
| 623 | |
| 624 | if ($stmt_lines > $stmt_statements) { |
| 625 | return $stmt_lines; |
| 626 | } else { |
| 627 | return $stmt_statements; |
| 628 | } |
| 629 | } |
| 630 | |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 631 | sub ctx_statement_full { |
| 632 | my ($linenr, $remain, $off) = @_; |
| 633 | my ($statement, $condition, $level); |
| 634 | |
| 635 | my (@chunks); |
| 636 | |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 637 | # Grab the first conditional/block pair. |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 638 | ($statement, $condition, $linenr, $remain, $off, $level) = |
| 639 | ctx_statement_block($linenr, $remain, $off); |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 640 | #print "F: c<$condition> s<$statement> remain<$remain>\n"; |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 641 | push(@chunks, [ $condition, $statement ]); |
| 642 | if (!($remain > 0 && $condition =~ /^\s*(?:\n[+-])?\s*(?:if|else|do)\b/s)) { |
| 643 | return ($level, $linenr, @chunks); |
| 644 | } |
| 645 | |
| 646 | # Pull in the following conditional/block pairs and see if they |
| 647 | # could continue the statement. |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 648 | for (;;) { |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 649 | ($statement, $condition, $linenr, $remain, $off, $level) = |
| 650 | ctx_statement_block($linenr, $remain, $off); |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 651 | #print "C: c<$condition> s<$statement> remain<$remain>\n"; |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 652 | last if (!($remain > 0 && $condition =~ /^(?:\s*\n[+-])*\s*(?:else|do)\b/s)); |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 653 | #print "C: push\n"; |
| 654 | push(@chunks, [ $condition, $statement ]); |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 655 | } |
| 656 | |
| 657 | return ($level, $linenr, @chunks); |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 658 | } |
| 659 | |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 660 | sub ctx_block_get { |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 661 | my ($linenr, $remain, $outer, $open, $close, $off) = @_; |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 662 | my $line; |
| 663 | my $start = $linenr - 1; |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 664 | my $blk = ''; |
| 665 | my @o; |
| 666 | my @c; |
| 667 | my @res = (); |
| 668 | |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 669 | my $level = 0; |
Andy Whitcroft | 4635f4f | 2009-01-06 14:41:27 -0800 | [diff] [blame] | 670 | my @stack = ($level); |
Andy Whitcroft | 00df344 | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 671 | for ($line = $start; $remain > 0; $line++) { |
| 672 | next if ($rawlines[$line] =~ /^-/); |
| 673 | $remain--; |
| 674 | |
| 675 | $blk .= $rawlines[$line]; |
Andy Whitcroft | 4635f4f | 2009-01-06 14:41:27 -0800 | [diff] [blame] | 676 | |
| 677 | # Handle nested #if/#else. |
| 678 | if ($rawlines[$line] =~ /^.\s*#\s*(?:ifndef|ifdef|if)\s/) { |
| 679 | push(@stack, $level); |
| 680 | } elsif ($rawlines[$line] =~ /^.\s*#\s*(?:else|elif)\b/) { |
| 681 | $level = $stack[$#stack - 1]; |
| 682 | } elsif ($rawlines[$line] =~ /^.\s*#\s*endif\b/) { |
| 683 | $level = pop(@stack); |
| 684 | } |
| 685 | |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 686 | foreach my $c (split(//, $rawlines[$line])) { |
| 687 | ##print "C<$c>L<$level><$open$close>O<$off>\n"; |
| 688 | if ($off > 0) { |
| 689 | $off--; |
| 690 | next; |
| 691 | } |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 692 | |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 693 | if ($c eq $close && $level > 0) { |
| 694 | $level--; |
| 695 | last if ($level == 0); |
| 696 | } elsif ($c eq $open) { |
| 697 | $level++; |
| 698 | } |
| 699 | } |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 700 | |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 701 | if (!$outer || $level <= 1) { |
Andy Whitcroft | 00df344 | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 702 | push(@res, $rawlines[$line]); |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 703 | } |
| 704 | |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 705 | last if ($level == 0); |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 706 | } |
| 707 | |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 708 | return ($level, @res); |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 709 | } |
| 710 | sub ctx_block_outer { |
| 711 | my ($linenr, $remain) = @_; |
| 712 | |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 713 | my ($level, @r) = ctx_block_get($linenr, $remain, 1, '{', '}', 0); |
| 714 | return @r; |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 715 | } |
| 716 | sub ctx_block { |
| 717 | my ($linenr, $remain) = @_; |
| 718 | |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 719 | my ($level, @r) = ctx_block_get($linenr, $remain, 0, '{', '}', 0); |
| 720 | return @r; |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 721 | } |
| 722 | sub ctx_statement { |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 723 | my ($linenr, $remain, $off) = @_; |
| 724 | |
| 725 | my ($level, @r) = ctx_block_get($linenr, $remain, 0, '(', ')', $off); |
| 726 | return @r; |
| 727 | } |
| 728 | sub ctx_block_level { |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 729 | my ($linenr, $remain) = @_; |
| 730 | |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 731 | return ctx_block_get($linenr, $remain, 0, '{', '}', 0); |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 732 | } |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 733 | sub ctx_statement_level { |
| 734 | my ($linenr, $remain, $off) = @_; |
| 735 | |
| 736 | return ctx_block_get($linenr, $remain, 0, '(', ')', $off); |
| 737 | } |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 738 | |
| 739 | sub ctx_locate_comment { |
| 740 | my ($first_line, $end_line) = @_; |
| 741 | |
| 742 | # Catch a comment on the end of the line itself. |
Andy Whitcroft | beae633 | 2008-07-23 21:28:59 -0700 | [diff] [blame] | 743 | my ($current_comment) = ($rawlines[$end_line - 1] =~ m@.*(/\*.*\*/)\s*(?:\\\s*)?$@); |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 744 | return $current_comment if (defined $current_comment); |
| 745 | |
| 746 | # Look through the context and try and figure out if there is a |
| 747 | # comment. |
| 748 | my $in_comment = 0; |
| 749 | $current_comment = ''; |
| 750 | for (my $linenr = $first_line; $linenr < $end_line; $linenr++) { |
Andy Whitcroft | 00df344 | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 751 | my $line = $rawlines[$linenr - 1]; |
| 752 | #warn " $line\n"; |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 753 | if ($linenr == $first_line and $line =~ m@^.\s*\*@) { |
| 754 | $in_comment = 1; |
| 755 | } |
| 756 | if ($line =~ m@/\*@) { |
| 757 | $in_comment = 1; |
| 758 | } |
| 759 | if (!$in_comment && $current_comment ne '') { |
| 760 | $current_comment = ''; |
| 761 | } |
| 762 | $current_comment .= $line . "\n" if ($in_comment); |
| 763 | if ($line =~ m@\*/@) { |
| 764 | $in_comment = 0; |
| 765 | } |
| 766 | } |
| 767 | |
| 768 | chomp($current_comment); |
| 769 | return($current_comment); |
| 770 | } |
| 771 | sub ctx_has_comment { |
| 772 | my ($first_line, $end_line) = @_; |
| 773 | my $cmt = ctx_locate_comment($first_line, $end_line); |
| 774 | |
Andy Whitcroft | 00df344 | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 775 | ##print "LINE: $rawlines[$end_line - 1 ]\n"; |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 776 | ##print "CMMT: $cmt\n"; |
| 777 | |
| 778 | return ($cmt ne ''); |
| 779 | } |
| 780 | |
Andy Whitcroft | 4d001e4 | 2008-10-15 22:02:21 -0700 | [diff] [blame] | 781 | sub raw_line { |
| 782 | my ($linenr, $cnt) = @_; |
| 783 | |
| 784 | my $offset = $linenr - 1; |
| 785 | $cnt++; |
| 786 | |
| 787 | my $line; |
| 788 | while ($cnt) { |
| 789 | $line = $rawlines[$offset++]; |
| 790 | next if (defined($line) && $line =~ /^-/); |
| 791 | $cnt--; |
| 792 | } |
| 793 | |
| 794 | return $line; |
| 795 | } |
| 796 | |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 797 | sub cat_vet { |
| 798 | my ($vet) = @_; |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 799 | my ($res, $coded); |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 800 | |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 801 | $res = ''; |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 802 | while ($vet =~ /([^[:cntrl:]]*)([[:cntrl:]]|$)/g) { |
| 803 | $res .= $1; |
| 804 | if ($2 ne '') { |
| 805 | $coded = sprintf("^%c", unpack('C', $2) + 64); |
| 806 | $res .= $coded; |
| 807 | } |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 808 | } |
| 809 | $res =~ s/$/\$/; |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 810 | |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 811 | return $res; |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 812 | } |
| 813 | |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 814 | my $av_preprocessor = 0; |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 815 | my $av_pending; |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 816 | my @av_paren_type; |
Andy Whitcroft | 1f65f94 | 2008-07-23 21:29:10 -0700 | [diff] [blame] | 817 | my $av_pend_colon; |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 818 | |
| 819 | sub annotate_reset { |
| 820 | $av_preprocessor = 0; |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 821 | $av_pending = '_'; |
| 822 | @av_paren_type = ('E'); |
Andy Whitcroft | 1f65f94 | 2008-07-23 21:29:10 -0700 | [diff] [blame] | 823 | $av_pend_colon = 'O'; |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 824 | } |
| 825 | |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 826 | sub annotate_values { |
| 827 | my ($stream, $type) = @_; |
| 828 | |
| 829 | my $res; |
Andy Whitcroft | 1f65f94 | 2008-07-23 21:29:10 -0700 | [diff] [blame] | 830 | my $var = '_' x length($stream); |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 831 | my $cur = $stream; |
| 832 | |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 833 | print "$stream\n" if ($dbg_values > 1); |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 834 | |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 835 | while (length($cur)) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 836 | @av_paren_type = ('E') if ($#av_paren_type < 0); |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 837 | print " <" . join('', @av_paren_type) . |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 838 | "> <$type> <$av_pending>" if ($dbg_values > 1); |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 839 | if ($cur =~ /^(\s+)/o) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 840 | print "WS($1)\n" if ($dbg_values > 1); |
| 841 | if ($1 =~ /\n/ && $av_preprocessor) { |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 842 | $type = pop(@av_paren_type); |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 843 | $av_preprocessor = 0; |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 844 | } |
| 845 | |
Andy Whitcroft | e91b6e2 | 2010-10-26 14:23:11 -0700 | [diff] [blame^] | 846 | } elsif ($cur =~ /^($Type)\s*(?:$Ident|,|\)|\(|\s*$)/) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 847 | print "DECLARE($1)\n" if ($dbg_values > 1); |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 848 | $type = 'T'; |
| 849 | |
Andy Whitcroft | 389a2fe | 2008-07-23 21:29:05 -0700 | [diff] [blame] | 850 | } elsif ($cur =~ /^($Modifier)\s*/) { |
| 851 | print "MODIFIER($1)\n" if ($dbg_values > 1); |
| 852 | $type = 'T'; |
| 853 | |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 854 | } elsif ($cur =~ /^(\#\s*define\s*$Ident)(\(?)/o) { |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 855 | print "DEFINE($1,$2)\n" if ($dbg_values > 1); |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 856 | $av_preprocessor = 1; |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 857 | push(@av_paren_type, $type); |
| 858 | if ($2 ne '') { |
| 859 | $av_pending = 'N'; |
| 860 | } |
| 861 | $type = 'E'; |
| 862 | |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 863 | } elsif ($cur =~ /^(\#\s*(?:undef\s*$Ident|include\b))/o) { |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 864 | print "UNDEF($1)\n" if ($dbg_values > 1); |
| 865 | $av_preprocessor = 1; |
| 866 | push(@av_paren_type, $type); |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 867 | |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 868 | } elsif ($cur =~ /^(\#\s*(?:ifdef|ifndef|if))/o) { |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 869 | print "PRE_START($1)\n" if ($dbg_values > 1); |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 870 | $av_preprocessor = 1; |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 871 | |
| 872 | push(@av_paren_type, $type); |
| 873 | push(@av_paren_type, $type); |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 874 | $type = 'E'; |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 875 | |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 876 | } elsif ($cur =~ /^(\#\s*(?:else|elif))/o) { |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 877 | print "PRE_RESTART($1)\n" if ($dbg_values > 1); |
| 878 | $av_preprocessor = 1; |
| 879 | |
| 880 | push(@av_paren_type, $av_paren_type[$#av_paren_type]); |
| 881 | |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 882 | $type = 'E'; |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 883 | |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 884 | } elsif ($cur =~ /^(\#\s*(?:endif))/o) { |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 885 | print "PRE_END($1)\n" if ($dbg_values > 1); |
| 886 | |
| 887 | $av_preprocessor = 1; |
| 888 | |
| 889 | # Assume all arms of the conditional end as this |
| 890 | # one does, and continue as if the #endif was not here. |
| 891 | pop(@av_paren_type); |
| 892 | push(@av_paren_type, $type); |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 893 | $type = 'E'; |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 894 | |
| 895 | } elsif ($cur =~ /^(\\\n)/o) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 896 | print "PRECONT($1)\n" if ($dbg_values > 1); |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 897 | |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 898 | } elsif ($cur =~ /^(__attribute__)\s*\(?/o) { |
| 899 | print "ATTR($1)\n" if ($dbg_values > 1); |
| 900 | $av_pending = $type; |
| 901 | $type = 'N'; |
| 902 | |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 903 | } elsif ($cur =~ /^(sizeof)\s*(\()?/o) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 904 | print "SIZEOF($1)\n" if ($dbg_values > 1); |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 905 | if (defined $2) { |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 906 | $av_pending = 'V'; |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 907 | } |
| 908 | $type = 'N'; |
| 909 | |
Andy Whitcroft | 14b111c | 2008-10-15 22:02:16 -0700 | [diff] [blame] | 910 | } elsif ($cur =~ /^(if|while|for)\b/o) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 911 | print "COND($1)\n" if ($dbg_values > 1); |
Andy Whitcroft | 14b111c | 2008-10-15 22:02:16 -0700 | [diff] [blame] | 912 | $av_pending = 'E'; |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 913 | $type = 'N'; |
| 914 | |
Andy Whitcroft | 1f65f94 | 2008-07-23 21:29:10 -0700 | [diff] [blame] | 915 | } elsif ($cur =~/^(case)/o) { |
| 916 | print "CASE($1)\n" if ($dbg_values > 1); |
| 917 | $av_pend_colon = 'C'; |
| 918 | $type = 'N'; |
| 919 | |
Andy Whitcroft | 14b111c | 2008-10-15 22:02:16 -0700 | [diff] [blame] | 920 | } elsif ($cur =~/^(return|else|goto|typeof|__typeof__)\b/o) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 921 | print "KEYWORD($1)\n" if ($dbg_values > 1); |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 922 | $type = 'N'; |
| 923 | |
| 924 | } elsif ($cur =~ /^(\()/o) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 925 | print "PAREN('$1')\n" if ($dbg_values > 1); |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 926 | push(@av_paren_type, $av_pending); |
| 927 | $av_pending = '_'; |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 928 | $type = 'N'; |
| 929 | |
| 930 | } elsif ($cur =~ /^(\))/o) { |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 931 | my $new_type = pop(@av_paren_type); |
| 932 | if ($new_type ne '_') { |
| 933 | $type = $new_type; |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 934 | print "PAREN('$1') -> $type\n" |
| 935 | if ($dbg_values > 1); |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 936 | } else { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 937 | print "PAREN('$1')\n" if ($dbg_values > 1); |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 938 | } |
| 939 | |
Andy Whitcroft | c8cb2ca | 2008-07-23 21:28:57 -0700 | [diff] [blame] | 940 | } elsif ($cur =~ /^($Ident)\s*\(/o) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 941 | print "FUNC($1)\n" if ($dbg_values > 1); |
Andy Whitcroft | c8cb2ca | 2008-07-23 21:28:57 -0700 | [diff] [blame] | 942 | $type = 'V'; |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 943 | $av_pending = 'V'; |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 944 | |
Andy Whitcroft | 8e761b0 | 2009-01-06 14:41:19 -0800 | [diff] [blame] | 945 | } elsif ($cur =~ /^($Ident\s*):(?:\s*\d+\s*(,|=|;))?/) { |
| 946 | if (defined $2 && $type eq 'C' || $type eq 'T') { |
Andy Whitcroft | 1f65f94 | 2008-07-23 21:29:10 -0700 | [diff] [blame] | 947 | $av_pend_colon = 'B'; |
Andy Whitcroft | 8e761b0 | 2009-01-06 14:41:19 -0800 | [diff] [blame] | 948 | } elsif ($type eq 'E') { |
| 949 | $av_pend_colon = 'L'; |
Andy Whitcroft | 1f65f94 | 2008-07-23 21:29:10 -0700 | [diff] [blame] | 950 | } |
| 951 | print "IDENT_COLON($1,$type>$av_pend_colon)\n" if ($dbg_values > 1); |
| 952 | $type = 'V'; |
| 953 | |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 954 | } elsif ($cur =~ /^($Ident|$Constant)/o) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 955 | print "IDENT($1)\n" if ($dbg_values > 1); |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 956 | $type = 'V'; |
| 957 | |
| 958 | } elsif ($cur =~ /^($Assignment)/o) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 959 | print "ASSIGN($1)\n" if ($dbg_values > 1); |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 960 | $type = 'N'; |
| 961 | |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 962 | } elsif ($cur =~/^(;|{|})/) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 963 | print "END($1)\n" if ($dbg_values > 1); |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 964 | $type = 'E'; |
Andy Whitcroft | 1f65f94 | 2008-07-23 21:29:10 -0700 | [diff] [blame] | 965 | $av_pend_colon = 'O'; |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 966 | |
Andy Whitcroft | 8e761b0 | 2009-01-06 14:41:19 -0800 | [diff] [blame] | 967 | } elsif ($cur =~/^(,)/) { |
| 968 | print "COMMA($1)\n" if ($dbg_values > 1); |
| 969 | $type = 'C'; |
| 970 | |
Andy Whitcroft | 1f65f94 | 2008-07-23 21:29:10 -0700 | [diff] [blame] | 971 | } elsif ($cur =~ /^(\?)/o) { |
| 972 | print "QUESTION($1)\n" if ($dbg_values > 1); |
| 973 | $type = 'N'; |
| 974 | |
| 975 | } elsif ($cur =~ /^(:)/o) { |
| 976 | print "COLON($1,$av_pend_colon)\n" if ($dbg_values > 1); |
| 977 | |
| 978 | substr($var, length($res), 1, $av_pend_colon); |
| 979 | if ($av_pend_colon eq 'C' || $av_pend_colon eq 'L') { |
| 980 | $type = 'E'; |
| 981 | } else { |
| 982 | $type = 'N'; |
| 983 | } |
| 984 | $av_pend_colon = 'O'; |
| 985 | |
Andy Whitcroft | 8e761b0 | 2009-01-06 14:41:19 -0800 | [diff] [blame] | 986 | } elsif ($cur =~ /^(\[)/o) { |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 987 | print "CLOSE($1)\n" if ($dbg_values > 1); |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 988 | $type = 'N'; |
| 989 | |
Andy Whitcroft | 0d41386 | 2008-10-15 22:02:16 -0700 | [diff] [blame] | 990 | } elsif ($cur =~ /^(-(?![->])|\+(?!\+)|\*|\&\&|\&)/o) { |
Andy Whitcroft | 74048ed | 2008-07-23 21:29:10 -0700 | [diff] [blame] | 991 | my $variant; |
| 992 | |
| 993 | print "OPV($1)\n" if ($dbg_values > 1); |
| 994 | if ($type eq 'V') { |
| 995 | $variant = 'B'; |
| 996 | } else { |
| 997 | $variant = 'U'; |
| 998 | } |
| 999 | |
| 1000 | substr($var, length($res), 1, $variant); |
| 1001 | $type = 'N'; |
| 1002 | |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 1003 | } elsif ($cur =~ /^($Operators)/o) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1004 | print "OP($1)\n" if ($dbg_values > 1); |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 1005 | if ($1 ne '++' && $1 ne '--') { |
| 1006 | $type = 'N'; |
| 1007 | } |
| 1008 | |
| 1009 | } elsif ($cur =~ /(^.)/o) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1010 | print "C($1)\n" if ($dbg_values > 1); |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 1011 | } |
| 1012 | if (defined $1) { |
| 1013 | $cur = substr($cur, length($1)); |
| 1014 | $res .= $type x length($1); |
| 1015 | } |
| 1016 | } |
| 1017 | |
Andy Whitcroft | 1f65f94 | 2008-07-23 21:29:10 -0700 | [diff] [blame] | 1018 | return ($res, $var); |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 1019 | } |
| 1020 | |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 1021 | sub possible { |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 1022 | my ($possible, $line) = @_; |
Andy Whitcroft | 9a974fd | 2009-10-26 16:50:12 -0700 | [diff] [blame] | 1023 | my $notPermitted = qr{(?: |
Andy Whitcroft | 0776e59 | 2008-10-15 22:02:29 -0700 | [diff] [blame] | 1024 | ^(?: |
| 1025 | $Modifier| |
| 1026 | $Storage| |
| 1027 | $Type| |
Andy Whitcroft | 9a974fd | 2009-10-26 16:50:12 -0700 | [diff] [blame] | 1028 | DEFINE_\S+ |
| 1029 | )$| |
| 1030 | ^(?: |
Andy Whitcroft | 0776e59 | 2008-10-15 22:02:29 -0700 | [diff] [blame] | 1031 | goto| |
| 1032 | return| |
| 1033 | case| |
| 1034 | else| |
| 1035 | asm|__asm__| |
| 1036 | do |
Andy Whitcroft | 9a974fd | 2009-10-26 16:50:12 -0700 | [diff] [blame] | 1037 | )(?:\s|$)| |
Andy Whitcroft | 0776e59 | 2008-10-15 22:02:29 -0700 | [diff] [blame] | 1038 | ^(?:typedef|struct|enum)\b |
Andy Whitcroft | 9a974fd | 2009-10-26 16:50:12 -0700 | [diff] [blame] | 1039 | )}x; |
| 1040 | warn "CHECK<$possible> ($line)\n" if ($dbg_possible > 2); |
| 1041 | if ($possible !~ $notPermitted) { |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1042 | # Check for modifiers. |
| 1043 | $possible =~ s/\s*$Storage\s*//g; |
| 1044 | $possible =~ s/\s*$Sparse\s*//g; |
| 1045 | if ($possible =~ /^\s*$/) { |
| 1046 | |
| 1047 | } elsif ($possible =~ /\s/) { |
| 1048 | $possible =~ s/\s*$Type\s*//g; |
Andy Whitcroft | d250658 | 2008-07-23 21:29:09 -0700 | [diff] [blame] | 1049 | for my $modifier (split(' ', $possible)) { |
Andy Whitcroft | 9a974fd | 2009-10-26 16:50:12 -0700 | [diff] [blame] | 1050 | if ($modifier !~ $notPermitted) { |
| 1051 | warn "MODIFIER: $modifier ($possible) ($line)\n" if ($dbg_possible); |
| 1052 | push(@modifierList, $modifier); |
| 1053 | } |
Andy Whitcroft | d250658 | 2008-07-23 21:29:09 -0700 | [diff] [blame] | 1054 | } |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1055 | |
| 1056 | } else { |
| 1057 | warn "POSSIBLE: $possible ($line)\n" if ($dbg_possible); |
| 1058 | push(@typeList, $possible); |
| 1059 | } |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 1060 | build_types(); |
Andy Whitcroft | 0776e59 | 2008-10-15 22:02:29 -0700 | [diff] [blame] | 1061 | } else { |
| 1062 | warn "NOTPOSS: $possible ($line)\n" if ($dbg_possible > 1); |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 1063 | } |
| 1064 | } |
| 1065 | |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 1066 | my $prefix = ''; |
| 1067 | |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 1068 | sub report { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1069 | if (defined $tst_only && $_[0] !~ /\Q$tst_only\E/) { |
| 1070 | return 0; |
| 1071 | } |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 1072 | my $line = $prefix . $_[0]; |
| 1073 | |
| 1074 | $line = (split('\n', $line))[0] . "\n" if ($terse); |
| 1075 | |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 1076 | push(our @report, $line); |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1077 | |
| 1078 | return 1; |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 1079 | } |
| 1080 | sub report_dump { |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 1081 | our @report; |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 1082 | } |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1083 | sub ERROR { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1084 | if (report("ERROR: $_[0]\n")) { |
| 1085 | our $clean = 0; |
| 1086 | our $cnt_error++; |
| 1087 | } |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1088 | } |
| 1089 | sub WARN { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1090 | if (report("WARNING: $_[0]\n")) { |
| 1091 | our $clean = 0; |
| 1092 | our $cnt_warn++; |
| 1093 | } |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1094 | } |
| 1095 | sub CHK { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1096 | if ($check && report("CHECK: $_[0]\n")) { |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 1097 | our $clean = 0; |
| 1098 | our $cnt_chk++; |
| 1099 | } |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1100 | } |
| 1101 | |
Andy Whitcroft | 6ecd967 | 2008-10-15 22:02:21 -0700 | [diff] [blame] | 1102 | sub check_absolute_file { |
| 1103 | my ($absolute, $herecurr) = @_; |
| 1104 | my $file = $absolute; |
| 1105 | |
| 1106 | ##print "absolute<$absolute>\n"; |
| 1107 | |
| 1108 | # See if any suffix of this path is a path within the tree. |
| 1109 | while ($file =~ s@^[^/]*/@@) { |
| 1110 | if (-f "$root/$file") { |
| 1111 | ##print "file<$file>\n"; |
| 1112 | last; |
| 1113 | } |
| 1114 | } |
| 1115 | if (! -f _) { |
| 1116 | return 0; |
| 1117 | } |
| 1118 | |
| 1119 | # It is, so see if the prefix is acceptable. |
| 1120 | my $prefix = $absolute; |
| 1121 | substr($prefix, -length($file)) = ''; |
| 1122 | |
| 1123 | ##print "prefix<$prefix>\n"; |
| 1124 | if ($prefix ne ".../") { |
| 1125 | WARN("use relative pathname instead of absolute in changelog text\n" . $herecurr); |
| 1126 | } |
| 1127 | } |
| 1128 | |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1129 | sub process { |
| 1130 | my $filename = shift; |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1131 | |
| 1132 | my $linenr=0; |
| 1133 | my $prevline=""; |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1134 | my $prevrawline=""; |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1135 | my $stashline=""; |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1136 | my $stashrawline=""; |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1137 | |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 1138 | my $length; |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1139 | my $indent; |
| 1140 | my $previndent=0; |
| 1141 | my $stashindent=0; |
| 1142 | |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1143 | our $clean = 1; |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1144 | my $signoff = 0; |
| 1145 | my $is_patch = 0; |
| 1146 | |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 1147 | our @report = (); |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 1148 | our $cnt_lines = 0; |
| 1149 | our $cnt_error = 0; |
| 1150 | our $cnt_warn = 0; |
| 1151 | our $cnt_chk = 0; |
| 1152 | |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1153 | # Trace the real file/line as we go. |
| 1154 | my $realfile = ''; |
| 1155 | my $realline = 0; |
| 1156 | my $realcnt = 0; |
| 1157 | my $here = ''; |
| 1158 | my $in_comment = 0; |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1159 | my $comment_edge = 0; |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1160 | my $first_line = 0; |
Wolfram Sang | 1e85572 | 2009-01-06 14:41:24 -0800 | [diff] [blame] | 1161 | my $p1_prefix = ''; |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1162 | |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 1163 | my $prev_values = 'E'; |
| 1164 | |
| 1165 | # suppression flags |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1166 | my %suppress_ifbraces; |
Andy Whitcroft | 170d3a2 | 2008-10-15 22:02:30 -0700 | [diff] [blame] | 1167 | my %suppress_whiletrailers; |
Andy Whitcroft | 2b474a1 | 2009-10-26 16:50:16 -0700 | [diff] [blame] | 1168 | my %suppress_export; |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 1169 | |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1170 | # Pre-scan the patch sanitizing the lines. |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1171 | # Pre-scan the patch looking for any __setup documentation. |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1172 | # |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1173 | my @setup_docs = (); |
| 1174 | my $setup_docs = 0; |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1175 | |
| 1176 | sanitise_line_reset(); |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1177 | my $line; |
| 1178 | foreach my $rawline (@rawlines) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1179 | $linenr++; |
| 1180 | $line = $rawline; |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1181 | |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1182 | if ($rawline=~/^\+\+\+\s+(\S+)/) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1183 | $setup_docs = 0; |
| 1184 | if ($1 =~ m@Documentation/kernel-parameters.txt$@) { |
| 1185 | $setup_docs = 1; |
| 1186 | } |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1187 | #next; |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1188 | } |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1189 | if ($rawline=~/^\@\@ -\d+(?:,\d+)? \+(\d+)(,(\d+))? \@\@/) { |
| 1190 | $realline=$1-1; |
| 1191 | if (defined $2) { |
| 1192 | $realcnt=$3+1; |
| 1193 | } else { |
| 1194 | $realcnt=1+1; |
| 1195 | } |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1196 | $in_comment = 0; |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1197 | |
| 1198 | # Guestimate if this is a continuing comment. Run |
| 1199 | # the context looking for a comment "edge". If this |
| 1200 | # edge is a close comment then we must be in a comment |
| 1201 | # at context start. |
| 1202 | my $edge; |
Andy Whitcroft | 01fa914 | 2008-10-15 22:02:19 -0700 | [diff] [blame] | 1203 | my $cnt = $realcnt; |
| 1204 | for (my $ln = $linenr + 1; $cnt > 0; $ln++) { |
| 1205 | next if (defined $rawlines[$ln - 1] && |
| 1206 | $rawlines[$ln - 1] =~ /^-/); |
| 1207 | $cnt--; |
| 1208 | #print "RAW<$rawlines[$ln - 1]>\n"; |
Andy Whitcroft | 721c1cb | 2009-01-06 14:41:16 -0800 | [diff] [blame] | 1209 | last if (!defined $rawlines[$ln - 1]); |
Andy Whitcroft | fae17da | 2009-01-06 14:41:20 -0800 | [diff] [blame] | 1210 | if ($rawlines[$ln - 1] =~ m@(/\*|\*/)@ && |
| 1211 | $rawlines[$ln - 1] !~ m@"[^"]*(?:/\*|\*/)[^"]*"@) { |
| 1212 | ($edge) = $1; |
| 1213 | last; |
| 1214 | } |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1215 | } |
| 1216 | if (defined $edge && $edge eq '*/') { |
| 1217 | $in_comment = 1; |
| 1218 | } |
| 1219 | |
| 1220 | # Guestimate if this is a continuing comment. If this |
| 1221 | # is the start of a diff block and this line starts |
| 1222 | # ' *' then it is very likely a comment. |
| 1223 | if (!defined $edge && |
Andy Whitcroft | 83242e0 | 2009-01-06 14:41:17 -0800 | [diff] [blame] | 1224 | $rawlines[$linenr] =~ m@^.\s*(?:\*\*+| \*)(?:\s|$)@) |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1225 | { |
| 1226 | $in_comment = 1; |
| 1227 | } |
| 1228 | |
| 1229 | ##print "COMMENT:$in_comment edge<$edge> $rawline\n"; |
| 1230 | sanitise_line_reset($in_comment); |
| 1231 | |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 1232 | } elsif ($realcnt && $rawline =~ /^(?:\+| |$)/) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1233 | # Standardise the strings and chars within the input to |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 1234 | # simplify matching -- only bother with positive lines. |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1235 | $line = sanitise_line($rawline); |
| 1236 | } |
| 1237 | push(@lines, $line); |
| 1238 | |
| 1239 | if ($realcnt > 1) { |
| 1240 | $realcnt-- if ($line =~ /^(?:\+| |$)/); |
| 1241 | } else { |
| 1242 | $realcnt = 0; |
| 1243 | } |
| 1244 | |
| 1245 | #print "==>$rawline\n"; |
| 1246 | #print "-->$line\n"; |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1247 | |
| 1248 | if ($setup_docs && $line =~ /^\+/) { |
| 1249 | push(@setup_docs, $line); |
| 1250 | } |
| 1251 | } |
| 1252 | |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 1253 | $prefix = ''; |
| 1254 | |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1255 | $realcnt = 0; |
| 1256 | $linenr = 0; |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1257 | foreach my $line (@lines) { |
| 1258 | $linenr++; |
| 1259 | |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1260 | my $rawline = $rawlines[$linenr - 1]; |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 1261 | |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1262 | #extract the line range in the file after the patch is applied |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 1263 | if ($line=~/^\@\@ -\d+(?:,\d+)? \+(\d+)(,(\d+))? \@\@/) { |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1264 | $is_patch = 1; |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 1265 | $first_line = $linenr + 1; |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1266 | $realline=$1-1; |
| 1267 | if (defined $2) { |
| 1268 | $realcnt=$3+1; |
| 1269 | } else { |
| 1270 | $realcnt=1+1; |
| 1271 | } |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1272 | annotate_reset(); |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 1273 | $prev_values = 'E'; |
| 1274 | |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1275 | %suppress_ifbraces = (); |
Andy Whitcroft | 170d3a2 | 2008-10-15 22:02:30 -0700 | [diff] [blame] | 1276 | %suppress_whiletrailers = (); |
Andy Whitcroft | 2b474a1 | 2009-10-26 16:50:16 -0700 | [diff] [blame] | 1277 | %suppress_export = (); |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1278 | next; |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1279 | |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 1280 | # track the line number as we move through the hunk, note that |
| 1281 | # new versions of GNU diff omit the leading space on completely |
| 1282 | # blank context lines so we need to count that too. |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1283 | } elsif ($line =~ /^( |\+|$)/) { |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1284 | $realline++; |
Andy Whitcroft | d8aaf12 | 2007-06-23 17:16:44 -0700 | [diff] [blame] | 1285 | $realcnt-- if ($realcnt != 0); |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1286 | |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 1287 | # Measure the line length and indent. |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1288 | ($length, $indent) = line_stats($rawline); |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1289 | |
| 1290 | # Track the previous line. |
| 1291 | ($prevline, $stashline) = ($stashline, $line); |
| 1292 | ($previndent, $stashindent) = ($stashindent, $indent); |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1293 | ($prevrawline, $stashrawline) = ($stashrawline, $rawline); |
| 1294 | |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1295 | #warn "line<$line>\n"; |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 1296 | |
Andy Whitcroft | d8aaf12 | 2007-06-23 17:16:44 -0700 | [diff] [blame] | 1297 | } elsif ($realcnt == 1) { |
| 1298 | $realcnt--; |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1299 | } |
| 1300 | |
Andy Whitcroft | cc77cdc | 2009-10-26 16:50:13 -0700 | [diff] [blame] | 1301 | my $hunk_line = ($realcnt != 0); |
| 1302 | |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1303 | #make up the handle for any error we report on this line |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1304 | $prefix = "$filename:$realline: " if ($emacs && $file); |
| 1305 | $prefix = "$filename:$linenr: " if ($emacs && !$file); |
| 1306 | |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 1307 | $here = "#$linenr: " if (!$file); |
| 1308 | $here = "#$realline: " if ($file); |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1309 | |
| 1310 | # extract the filename as it passes |
| 1311 | if ($line=~/^\+\+\+\s+(\S+)/) { |
| 1312 | $realfile = $1; |
Wolfram Sang | 1e85572 | 2009-01-06 14:41:24 -0800 | [diff] [blame] | 1313 | $realfile =~ s@^([^/]*)/@@; |
| 1314 | |
| 1315 | $p1_prefix = $1; |
Andy Whitcroft | e2f7aa4 | 2009-02-27 14:03:06 -0800 | [diff] [blame] | 1316 | if (!$file && $tree && $p1_prefix ne '' && |
| 1317 | -e "$root/$p1_prefix") { |
Wolfram Sang | 1e85572 | 2009-01-06 14:41:24 -0800 | [diff] [blame] | 1318 | WARN("patch prefix '$p1_prefix' exists, appears to be a -p0 patch\n"); |
| 1319 | } |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1320 | |
Andy Whitcroft | c1ab332 | 2008-10-15 22:02:20 -0700 | [diff] [blame] | 1321 | if ($realfile =~ m@^include/asm/@) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1322 | ERROR("do not modify files in include/asm, change architecture specific files in include/asm-<architecture>\n" . "$here$rawline\n"); |
| 1323 | } |
| 1324 | next; |
| 1325 | } |
| 1326 | |
Randy Dunlap | 389834b | 2007-06-08 13:47:03 -0700 | [diff] [blame] | 1327 | $here .= "FILE: $realfile:$realline:" if ($realcnt != 0); |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1328 | |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1329 | my $hereline = "$here\n$rawline\n"; |
| 1330 | my $herecurr = "$here\n$rawline\n"; |
| 1331 | my $hereprev = "$here\n$prevrawline\n$rawline\n"; |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1332 | |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 1333 | $cnt_lines++ if ($realcnt != 0); |
| 1334 | |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1335 | #check the patch for a signoff: |
Andy Whitcroft | d8aaf12 | 2007-06-23 17:16:44 -0700 | [diff] [blame] | 1336 | if ($line =~ /^\s*signed-off-by:/i) { |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 1337 | # This is a signoff, if ugly, so do not double report. |
| 1338 | $signoff++; |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1339 | if (!($line =~ /^\s*Signed-off-by:/)) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1340 | WARN("Signed-off-by: is the preferred form\n" . |
| 1341 | $herecurr); |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1342 | } |
| 1343 | if ($line =~ /^\s*signed-off-by:\S/i) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1344 | WARN("space required after Signed-off-by:\n" . |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1345 | $herecurr); |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1346 | } |
| 1347 | } |
| 1348 | |
Andy Whitcroft | 00df344 | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 1349 | # Check for wrappage within a valid hunk of the file |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 1350 | if ($realcnt != 0 && $line !~ m{^(?:\+|-| |\\ No newline|$)}) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1351 | ERROR("patch seems to be corrupt (line wrapped?)\n" . |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 1352 | $herecurr) if (!$emitted_corrupt++); |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1353 | } |
| 1354 | |
Andy Whitcroft | 6ecd967 | 2008-10-15 22:02:21 -0700 | [diff] [blame] | 1355 | # Check for absolute kernel paths. |
| 1356 | if ($tree) { |
| 1357 | while ($line =~ m{(?:^|\s)(/\S*)}g) { |
| 1358 | my $file = $1; |
| 1359 | |
| 1360 | if ($file =~ m{^(.*?)(?::\d+)+:?$} && |
| 1361 | check_absolute_file($1, $herecurr)) { |
| 1362 | # |
| 1363 | } else { |
| 1364 | check_absolute_file($file, $herecurr); |
| 1365 | } |
| 1366 | } |
| 1367 | } |
| 1368 | |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1369 | # UTF-8 regex found at http://www.w3.org/International/questions/qa-forms-utf-8.en.php |
| 1370 | if (($realfile =~ /^$/ || $line =~ /^\+/) && |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 1371 | $rawline !~ m/^$UTF8*$/) { |
| 1372 | my ($utf8_prefix) = ($rawline =~ /^($UTF8*)/); |
| 1373 | |
| 1374 | my $blank = copy_spacing($rawline); |
| 1375 | my $ptr = substr($blank, 0, length($utf8_prefix)) . "^"; |
| 1376 | my $hereptr = "$hereline$ptr\n"; |
| 1377 | |
| 1378 | ERROR("Invalid UTF-8, patch and commit message should be encoded in UTF-8\n" . $hereptr); |
Andy Whitcroft | 00df344 | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 1379 | } |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1380 | |
Andy Whitcroft | 30670854 | 2008-10-15 22:02:28 -0700 | [diff] [blame] | 1381 | # ignore non-hunk lines and lines being removed |
| 1382 | next if (!$hunk_line || $line =~ /^-/); |
Andy Whitcroft | 00df344 | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 1383 | |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1384 | #trailing whitespace |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 1385 | if ($line =~ /^\+.*\015/) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1386 | my $herevet = "$here\n" . cat_vet($rawline) . "\n"; |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 1387 | ERROR("DOS line endings\n" . $herevet); |
| 1388 | |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1389 | } elsif ($rawline =~ /^\+.*\S\s+$/ || $rawline =~ /^\+\s+$/) { |
| 1390 | my $herevet = "$here\n" . cat_vet($rawline) . "\n"; |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1391 | ERROR("trailing whitespace\n" . $herevet); |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1392 | } |
Andy Whitcroft | 5368df2 | 2008-10-15 22:02:27 -0700 | [diff] [blame] | 1393 | |
Andi Kleen | 3354957 | 2010-05-24 14:33:29 -0700 | [diff] [blame] | 1394 | # check for Kconfig help text having a real description |
| 1395 | if ($realfile =~ /Kconfig/ && |
| 1396 | $line =~ /\+?\s*(---)?help(---)?$/) { |
| 1397 | my $length = 0; |
| 1398 | for (my $l = $linenr; defined($lines[$l]); $l++) { |
| 1399 | my $f = $lines[$l]; |
| 1400 | $f =~ s/#.*//; |
| 1401 | $f =~ s/^\s+//; |
| 1402 | next if ($f =~ /^$/); |
| 1403 | last if ($f =~ /^\s*config\s/); |
| 1404 | $length++; |
| 1405 | } |
| 1406 | WARN("please write a paragraph that describes the config symbol fully\n" . $herecurr) if ($length < 4); |
| 1407 | } |
| 1408 | |
Andy Whitcroft | 5368df2 | 2008-10-15 22:02:27 -0700 | [diff] [blame] | 1409 | # check we are in a valid source file if not then ignore this hunk |
| 1410 | next if ($realfile !~ /\.(h|c|s|S|pl|sh)$/); |
| 1411 | |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1412 | #80 column limit |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1413 | if ($line =~ /^\+/ && $prevrawline !~ /\/\*\*/ && |
Andy Whitcroft | f4c014c | 2008-07-23 21:29:01 -0700 | [diff] [blame] | 1414 | $rawline !~ /^.\s*\*\s*\@$Ident\s/ && |
Joe Perches | 8bbea96 | 2010-08-09 17:21:01 -0700 | [diff] [blame] | 1415 | !($line =~ /^\+\s*$logFunctions\s*\(\s*(?:(KERN_\S+\s*|[^"]*))?"[X\t]*"\s*(?:,|\)\s*;)\s*$/ || |
| 1416 | $line =~ /^\+\s*"[^"]*"\s*(?:\s*|,|\)\s*;)\s*$/) && |
Andy Whitcroft | f4c014c | 2008-07-23 21:29:01 -0700 | [diff] [blame] | 1417 | $length > 80) |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1418 | { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1419 | WARN("line over 80 characters\n" . $herecurr); |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1420 | } |
| 1421 | |
Joe Perches | 5e79d96 | 2010-03-05 13:43:55 -0800 | [diff] [blame] | 1422 | # check for spaces before a quoted newline |
| 1423 | if ($rawline =~ /^.*\".*\s\\n/) { |
| 1424 | WARN("unnecessary whitespace before a quoted newline\n" . $herecurr); |
| 1425 | } |
| 1426 | |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 1427 | # check for adding lines without a newline. |
| 1428 | if ($line =~ /^\+/ && defined $lines[$linenr] && $lines[$linenr] =~ /^\\ No newline at end of file/) { |
| 1429 | WARN("adding a line without newline at end of file\n" . $herecurr); |
| 1430 | } |
| 1431 | |
Mike Frysinger | 42e41c5 | 2009-09-21 17:04:40 -0700 | [diff] [blame] | 1432 | # Blackfin: use hi/lo macros |
| 1433 | if ($realfile =~ m@arch/blackfin/.*\.S$@) { |
| 1434 | if ($line =~ /\.[lL][[:space:]]*=.*&[[:space:]]*0x[fF][fF][fF][fF]/) { |
| 1435 | my $herevet = "$here\n" . cat_vet($line) . "\n"; |
| 1436 | ERROR("use the LO() macro, not (... & 0xFFFF)\n" . $herevet); |
| 1437 | } |
| 1438 | if ($line =~ /\.[hH][[:space:]]*=.*>>[[:space:]]*16/) { |
| 1439 | my $herevet = "$here\n" . cat_vet($line) . "\n"; |
| 1440 | ERROR("use the HI() macro, not (... >> 16)\n" . $herevet); |
| 1441 | } |
| 1442 | } |
| 1443 | |
Andy Whitcroft | b9ea10d | 2008-10-15 22:02:24 -0700 | [diff] [blame] | 1444 | # check we are in a valid source file C or perl if not then ignore this hunk |
| 1445 | next if ($realfile !~ /\.(h|c|pl)$/); |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1446 | |
| 1447 | # at the beginning of a line any tabs must come first and anything |
| 1448 | # more than 8 must use tabs. |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1449 | if ($rawline =~ /^\+\s* \t\s*\S/ || |
| 1450 | $rawline =~ /^\+\s* \s*/) { |
| 1451 | my $herevet = "$here\n" . cat_vet($rawline) . "\n"; |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 1452 | ERROR("code indent should use tabs where possible\n" . $herevet); |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1453 | } |
| 1454 | |
Alberto Panizzo | 08e4436 | 2010-03-05 13:43:54 -0800 | [diff] [blame] | 1455 | # check for space before tabs. |
| 1456 | if ($rawline =~ /^\+/ && $rawline =~ / \t/) { |
| 1457 | my $herevet = "$here\n" . cat_vet($rawline) . "\n"; |
| 1458 | WARN("please, no space before tabs\n" . $herevet); |
| 1459 | } |
| 1460 | |
Raffaele Recalcati | 5f7ddae | 2010-08-09 17:20:59 -0700 | [diff] [blame] | 1461 | # check for spaces at the beginning of a line. |
Andy Whitcroft | 6b4c5be | 2010-10-26 14:23:11 -0700 | [diff] [blame] | 1462 | # Exceptions: |
| 1463 | # 1) within comments |
| 1464 | # 2) indented preprocessor commands |
| 1465 | # 3) hanging labels |
| 1466 | if ($rawline =~ /^\+ / && $line !~ /\+ *(?:$;|#|$Ident:)/) { |
Raffaele Recalcati | 5f7ddae | 2010-08-09 17:20:59 -0700 | [diff] [blame] | 1467 | my $herevet = "$here\n" . cat_vet($rawline) . "\n"; |
Andy Whitcroft | 6b4c5be | 2010-10-26 14:23:11 -0700 | [diff] [blame] | 1468 | WARN("please, no spaces at the start of a line\n" . $herevet); |
Raffaele Recalcati | 5f7ddae | 2010-08-09 17:20:59 -0700 | [diff] [blame] | 1469 | } |
| 1470 | |
Andy Whitcroft | b9ea10d | 2008-10-15 22:02:24 -0700 | [diff] [blame] | 1471 | # check we are in a valid C source file if not then ignore this hunk |
| 1472 | next if ($realfile !~ /\.(h|c)$/); |
| 1473 | |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1474 | # check for RCS/CVS revision markers |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 1475 | if ($rawline =~ /^\+.*\$(Revision|Log|Id)(?:\$|)/) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1476 | WARN("CVS style keyword markers, these will _not_ be updated\n". $herecurr); |
| 1477 | } |
Andy Whitcroft | 22f2a2e | 2007-08-10 13:01:03 -0700 | [diff] [blame] | 1478 | |
Mike Frysinger | 42e41c5 | 2009-09-21 17:04:40 -0700 | [diff] [blame] | 1479 | # Blackfin: don't use __builtin_bfin_[cs]sync |
| 1480 | if ($line =~ /__builtin_bfin_csync/) { |
| 1481 | my $herevet = "$here\n" . cat_vet($line) . "\n"; |
| 1482 | ERROR("use the CSYNC() macro in asm/blackfin.h\n" . $herevet); |
| 1483 | } |
| 1484 | if ($line =~ /__builtin_bfin_ssync/) { |
| 1485 | my $herevet = "$here\n" . cat_vet($line) . "\n"; |
| 1486 | ERROR("use the SSYNC() macro in asm/blackfin.h\n" . $herevet); |
| 1487 | } |
| 1488 | |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 1489 | # Check for potential 'bare' types |
Andy Whitcroft | 2b474a1 | 2009-10-26 16:50:16 -0700 | [diff] [blame] | 1490 | my ($stat, $cond, $line_nr_next, $remain_next, $off_next, |
| 1491 | $realline_next); |
Andy Whitcroft | 9c9ba34 | 2008-04-29 00:59:33 -0700 | [diff] [blame] | 1492 | if ($realcnt && $line =~ /.\s*\S/) { |
Andy Whitcroft | 170d3a2 | 2008-10-15 22:02:30 -0700 | [diff] [blame] | 1493 | ($stat, $cond, $line_nr_next, $remain_next, $off_next) = |
Andy Whitcroft | f5fe35d | 2008-07-23 21:29:03 -0700 | [diff] [blame] | 1494 | ctx_statement_block($linenr, $realcnt, 0); |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 1495 | $stat =~ s/\n./\n /g; |
| 1496 | $cond =~ s/\n./\n /g; |
| 1497 | |
Andy Whitcroft | 2b474a1 | 2009-10-26 16:50:16 -0700 | [diff] [blame] | 1498 | # Find the real next line. |
| 1499 | $realline_next = $line_nr_next; |
| 1500 | if (defined $realline_next && |
| 1501 | (!defined $lines[$realline_next - 1] || |
| 1502 | substr($lines[$realline_next - 1], $off_next) =~ /^\s*$/)) { |
| 1503 | $realline_next++; |
| 1504 | } |
| 1505 | |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 1506 | my $s = $stat; |
| 1507 | $s =~ s/{.*$//s; |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 1508 | |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1509 | # Ignore goto labels. |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 1510 | if ($s =~ /$Ident:\*$/s) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1511 | |
| 1512 | # Ignore functions being called |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 1513 | } elsif ($s =~ /^.\s*$Ident\s*\(/s) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1514 | |
Andy Whitcroft | 463f286 | 2009-09-21 17:04:34 -0700 | [diff] [blame] | 1515 | } elsif ($s =~ /^.\s*else\b/s) { |
| 1516 | |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1517 | # declarations always start with types |
Andy Whitcroft | d250658 | 2008-07-23 21:29:09 -0700 | [diff] [blame] | 1518 | } elsif ($prev_values eq 'E' && $s =~ /^.\s*(?:$Storage\s+)?(?:$Inline\s+)?(?:const\s+)?((?:\s*$Ident)+?)\b(?:\s+$Sparse)?\s*\**\s*(?:$Ident|\(\*[^\)]*\))(?:\s*$Modifier)?\s*(?:;|=|,|\()/s) { |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1519 | my $type = $1; |
| 1520 | $type =~ s/\s+/ /g; |
| 1521 | possible($type, "A:" . $s); |
| 1522 | |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 1523 | # definitions in global scope can only start with types |
Andy Whitcroft | a6a8406 | 2008-10-15 22:02:30 -0700 | [diff] [blame] | 1524 | } elsif ($s =~ /^.(?:$Storage\s+)?(?:$Inline\s+)?(?:const\s+)?($Ident)\b\s*(?!:)/s) { |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1525 | possible($1, "B:" . $s); |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1526 | } |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 1527 | |
| 1528 | # any (foo ... *) is a pointer cast, and foo is a type |
Andy Whitcroft | 6586386 | 2009-01-06 14:41:21 -0800 | [diff] [blame] | 1529 | while ($s =~ /\(($Ident)(?:\s+$Sparse)*[\s\*]+\s*\)/sg) { |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1530 | possible($1, "C:" . $s); |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 1531 | } |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 1532 | |
| 1533 | # Check for any sort of function declaration. |
| 1534 | # int foo(something bar, other baz); |
| 1535 | # void (*store_gdt)(x86_descr_ptr *); |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 1536 | if ($prev_values eq 'E' && $s =~ /^(.(?:typedef\s*)?(?:(?:$Storage|$Inline)\s*)*\s*$Type\s*(?:\b$Ident|\(\*\s*$Ident\))\s*)\(/s) { |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 1537 | my ($name_len) = length($1); |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 1538 | |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 1539 | my $ctx = $s; |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1540 | substr($ctx, 0, $name_len + 1, ''); |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 1541 | $ctx =~ s/\)[^\)]*$//; |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 1542 | |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 1543 | for my $arg (split(/\s*,\s*/, $ctx)) { |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1544 | if ($arg =~ /^(?:const\s+)?($Ident)(?:\s+$Sparse)*\s*\**\s*(:?\b$Ident)?$/s || $arg =~ /^($Ident)$/s) { |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 1545 | |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1546 | possible($1, "D:" . $s); |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 1547 | } |
| 1548 | } |
| 1549 | } |
| 1550 | |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 1551 | } |
| 1552 | |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 1553 | # |
| 1554 | # Checks which may be anchored in the context. |
| 1555 | # |
| 1556 | |
| 1557 | # Check for switch () and associated case and default |
| 1558 | # statements should be at the same indent. |
Andy Whitcroft | 00df344 | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 1559 | if ($line=~/\bswitch\s*\(.*\)/) { |
| 1560 | my $err = ''; |
| 1561 | my $sep = ''; |
| 1562 | my @ctx = ctx_block_outer($linenr, $realcnt); |
| 1563 | shift(@ctx); |
| 1564 | for my $ctx (@ctx) { |
| 1565 | my ($clen, $cindent) = line_stats($ctx); |
| 1566 | if ($ctx =~ /^\+\s*(case\s+|default:)/ && |
| 1567 | $indent != $cindent) { |
| 1568 | $err .= "$sep$ctx\n"; |
| 1569 | $sep = ''; |
| 1570 | } else { |
| 1571 | $sep = "[...]\n"; |
| 1572 | } |
| 1573 | } |
| 1574 | if ($err ne '') { |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 1575 | ERROR("switch and case should be at the same indent\n$hereline$err"); |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1576 | } |
| 1577 | } |
| 1578 | |
| 1579 | # if/while/etc brace do not go on next line, unless defining a do while loop, |
| 1580 | # or if that brace on the next line is for something else |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1581 | if ($line =~ /(.*)\b((?:if|while|for|switch)\s*\(|do\b|else\b)/ && $line !~ /^.\s*\#/) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1582 | my $pre_ctx = "$1$2"; |
| 1583 | |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 1584 | my ($level, @ctx) = ctx_statement_level($linenr, $realcnt, 0); |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1585 | my $ctx_cnt = $realcnt - $#ctx - 1; |
| 1586 | my $ctx = join("\n", @ctx); |
| 1587 | |
Andy Whitcroft | 548596d | 2008-07-23 21:29:01 -0700 | [diff] [blame] | 1588 | my $ctx_ln = $linenr; |
| 1589 | my $ctx_skip = $realcnt; |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1590 | |
Andy Whitcroft | 548596d | 2008-07-23 21:29:01 -0700 | [diff] [blame] | 1591 | while ($ctx_skip > $ctx_cnt || ($ctx_skip == $ctx_cnt && |
| 1592 | defined $lines[$ctx_ln - 1] && |
| 1593 | $lines[$ctx_ln - 1] =~ /^-/)) { |
| 1594 | ##print "SKIP<$ctx_skip> CNT<$ctx_cnt>\n"; |
| 1595 | $ctx_skip-- if (!defined $lines[$ctx_ln - 1] || $lines[$ctx_ln - 1] !~ /^-/); |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1596 | $ctx_ln++; |
| 1597 | } |
Andy Whitcroft | 548596d | 2008-07-23 21:29:01 -0700 | [diff] [blame] | 1598 | |
Andy Whitcroft | 5321016 | 2008-07-23 21:29:03 -0700 | [diff] [blame] | 1599 | #print "realcnt<$realcnt> ctx_cnt<$ctx_cnt>\n"; |
| 1600 | #print "pre<$pre_ctx>\nline<$line>\nctx<$ctx>\nnext<$lines[$ctx_ln - 1]>\n"; |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1601 | |
| 1602 | if ($ctx !~ /{\s*/ && defined($lines[$ctx_ln -1]) && $lines[$ctx_ln - 1] =~ /^\+\s*{/) { |
| 1603 | ERROR("that open brace { should be on the previous line\n" . |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1604 | "$here\n$ctx\n$lines[$ctx_ln - 1]\n"); |
Andy Whitcroft | 00df344 | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 1605 | } |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1606 | if ($level == 0 && $pre_ctx !~ /}\s*while\s*\($/ && |
| 1607 | $ctx =~ /\)\s*\;\s*$/ && |
| 1608 | defined $lines[$ctx_ln - 1]) |
| 1609 | { |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 1610 | my ($nlength, $nindent) = line_stats($lines[$ctx_ln - 1]); |
| 1611 | if ($nindent > $indent) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1612 | WARN("trailing semicolon indicates no statements, indent implies otherwise\n" . |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1613 | "$here\n$ctx\n$lines[$ctx_ln - 1]\n"); |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 1614 | } |
| 1615 | } |
Andy Whitcroft | 00df344 | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 1616 | } |
| 1617 | |
Andy Whitcroft | 4d001e4 | 2008-10-15 22:02:21 -0700 | [diff] [blame] | 1618 | # Check relative indent for conditionals and blocks. |
| 1619 | if ($line =~ /\b(?:(?:if|while|for)\s*\(|do\b)/ && $line !~ /^.\s*#/ && $line !~ /\}\s*while\s*/) { |
| 1620 | my ($s, $c) = ($stat, $cond); |
| 1621 | |
| 1622 | substr($s, 0, length($c), ''); |
| 1623 | |
| 1624 | # Make sure we remove the line prefixes as we have |
| 1625 | # none on the first line, and are going to readd them |
| 1626 | # where necessary. |
| 1627 | $s =~ s/\n./\n/gs; |
| 1628 | |
| 1629 | # Find out how long the conditional actually is. |
Andy Whitcroft | 6f779c1 | 2008-10-15 22:02:27 -0700 | [diff] [blame] | 1630 | my @newlines = ($c =~ /\n/gs); |
| 1631 | my $cond_lines = 1 + $#newlines; |
Andy Whitcroft | 4d001e4 | 2008-10-15 22:02:21 -0700 | [diff] [blame] | 1632 | |
| 1633 | # We want to check the first line inside the block |
| 1634 | # starting at the end of the conditional, so remove: |
| 1635 | # 1) any blank line termination |
| 1636 | # 2) any opening brace { on end of the line |
| 1637 | # 3) any do (...) { |
| 1638 | my $continuation = 0; |
| 1639 | my $check = 0; |
| 1640 | $s =~ s/^.*\bdo\b//; |
| 1641 | $s =~ s/^\s*{//; |
| 1642 | if ($s =~ s/^\s*\\//) { |
| 1643 | $continuation = 1; |
| 1644 | } |
Andy Whitcroft | 9bd49ef | 2008-10-15 22:02:22 -0700 | [diff] [blame] | 1645 | if ($s =~ s/^\s*?\n//) { |
Andy Whitcroft | 4d001e4 | 2008-10-15 22:02:21 -0700 | [diff] [blame] | 1646 | $check = 1; |
| 1647 | $cond_lines++; |
| 1648 | } |
| 1649 | |
| 1650 | # Also ignore a loop construct at the end of a |
| 1651 | # preprocessor statement. |
| 1652 | if (($prevline =~ /^.\s*#\s*define\s/ || |
| 1653 | $prevline =~ /\\\s*$/) && $continuation == 0) { |
| 1654 | $check = 0; |
| 1655 | } |
| 1656 | |
Andy Whitcroft | 9bd49ef | 2008-10-15 22:02:22 -0700 | [diff] [blame] | 1657 | my $cond_ptr = -1; |
Andy Whitcroft | 740504c | 2008-10-15 22:02:35 -0700 | [diff] [blame] | 1658 | $continuation = 0; |
Andy Whitcroft | 9bd49ef | 2008-10-15 22:02:22 -0700 | [diff] [blame] | 1659 | while ($cond_ptr != $cond_lines) { |
| 1660 | $cond_ptr = $cond_lines; |
Andy Whitcroft | 4d001e4 | 2008-10-15 22:02:21 -0700 | [diff] [blame] | 1661 | |
Andy Whitcroft | f16fa28 | 2008-10-15 22:02:32 -0700 | [diff] [blame] | 1662 | # If we see an #else/#elif then the code |
| 1663 | # is not linear. |
| 1664 | if ($s =~ /^\s*\#\s*(?:else|elif)/) { |
| 1665 | $check = 0; |
| 1666 | } |
| 1667 | |
Andy Whitcroft | 9bd49ef | 2008-10-15 22:02:22 -0700 | [diff] [blame] | 1668 | # Ignore: |
| 1669 | # 1) blank lines, they should be at 0, |
| 1670 | # 2) preprocessor lines, and |
| 1671 | # 3) labels. |
Andy Whitcroft | 740504c | 2008-10-15 22:02:35 -0700 | [diff] [blame] | 1672 | if ($continuation || |
| 1673 | $s =~ /^\s*?\n/ || |
Andy Whitcroft | 9bd49ef | 2008-10-15 22:02:22 -0700 | [diff] [blame] | 1674 | $s =~ /^\s*#\s*?/ || |
| 1675 | $s =~ /^\s*$Ident\s*:/) { |
Andy Whitcroft | 740504c | 2008-10-15 22:02:35 -0700 | [diff] [blame] | 1676 | $continuation = ($s =~ /^.*?\\\n/) ? 1 : 0; |
Andy Whitcroft | 30dad6e | 2009-09-21 17:04:36 -0700 | [diff] [blame] | 1677 | if ($s =~ s/^.*?\n//) { |
| 1678 | $cond_lines++; |
| 1679 | } |
Andy Whitcroft | 9bd49ef | 2008-10-15 22:02:22 -0700 | [diff] [blame] | 1680 | } |
Andy Whitcroft | 4d001e4 | 2008-10-15 22:02:21 -0700 | [diff] [blame] | 1681 | } |
| 1682 | |
| 1683 | my (undef, $sindent) = line_stats("+" . $s); |
| 1684 | my $stat_real = raw_line($linenr, $cond_lines); |
| 1685 | |
| 1686 | # Check if either of these lines are modified, else |
| 1687 | # this is not this patch's fault. |
| 1688 | if (!defined($stat_real) || |
| 1689 | $stat !~ /^\+/ && $stat_real !~ /^\+/) { |
| 1690 | $check = 0; |
| 1691 | } |
| 1692 | if (defined($stat_real) && $cond_lines > 1) { |
| 1693 | $stat_real = "[...]\n$stat_real"; |
| 1694 | } |
| 1695 | |
Andy Whitcroft | 9bd49ef | 2008-10-15 22:02:22 -0700 | [diff] [blame] | 1696 | #print "line<$line> prevline<$prevline> indent<$indent> sindent<$sindent> check<$check> continuation<$continuation> s<$s> cond_lines<$cond_lines> stat_real<$stat_real> stat<$stat>\n"; |
Andy Whitcroft | 4d001e4 | 2008-10-15 22:02:21 -0700 | [diff] [blame] | 1697 | |
| 1698 | if ($check && (($sindent % 8) != 0 || |
| 1699 | ($sindent <= $indent && $s ne ''))) { |
| 1700 | WARN("suspect code indent for conditional statements ($indent, $sindent)\n" . $herecurr . "$stat_real\n"); |
| 1701 | } |
| 1702 | } |
| 1703 | |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 1704 | # Track the 'values' across context and added lines. |
| 1705 | my $opline = $line; $opline =~ s/^./ /; |
Andy Whitcroft | 1f65f94 | 2008-07-23 21:29:10 -0700 | [diff] [blame] | 1706 | my ($curr_values, $curr_vars) = |
| 1707 | annotate_values($opline . "\n", $prev_values); |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 1708 | $curr_values = $prev_values . $curr_values; |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1709 | if ($dbg_values) { |
| 1710 | my $outline = $opline; $outline =~ s/\t/ /g; |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 1711 | print "$linenr > .$outline\n"; |
| 1712 | print "$linenr > $curr_values\n"; |
Andy Whitcroft | 1f65f94 | 2008-07-23 21:29:10 -0700 | [diff] [blame] | 1713 | print "$linenr > $curr_vars\n"; |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1714 | } |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 1715 | $prev_values = substr($curr_values, -1); |
| 1716 | |
Andy Whitcroft | 00df344 | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 1717 | #ignore lines not being added |
| 1718 | if ($line=~/^[^\+]/) {next;} |
| 1719 | |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 1720 | # TEST: allow direct testing of the type matcher. |
Andy Whitcroft | 7429c69 | 2008-07-23 21:29:06 -0700 | [diff] [blame] | 1721 | if ($dbg_type) { |
| 1722 | if ($line =~ /^.\s*$Declare\s*$/) { |
| 1723 | ERROR("TEST: is type\n" . $herecurr); |
| 1724 | } elsif ($dbg_type > 1 && $line =~ /^.+($Declare)/) { |
| 1725 | ERROR("TEST: is not type ($1 is)\n". $herecurr); |
| 1726 | } |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 1727 | next; |
| 1728 | } |
Andy Whitcroft | a1ef277 | 2008-10-15 22:02:17 -0700 | [diff] [blame] | 1729 | # TEST: allow direct testing of the attribute matcher. |
| 1730 | if ($dbg_attr) { |
Andy Whitcroft | 9360b0e | 2009-02-27 14:03:08 -0800 | [diff] [blame] | 1731 | if ($line =~ /^.\s*$Modifier\s*$/) { |
Andy Whitcroft | a1ef277 | 2008-10-15 22:02:17 -0700 | [diff] [blame] | 1732 | ERROR("TEST: is attr\n" . $herecurr); |
Andy Whitcroft | 9360b0e | 2009-02-27 14:03:08 -0800 | [diff] [blame] | 1733 | } elsif ($dbg_attr > 1 && $line =~ /^.+($Modifier)/) { |
Andy Whitcroft | a1ef277 | 2008-10-15 22:02:17 -0700 | [diff] [blame] | 1734 | ERROR("TEST: is not attr ($1 is)\n". $herecurr); |
| 1735 | } |
| 1736 | next; |
| 1737 | } |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 1738 | |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 1739 | # check for initialisation to aggregates open brace on the next line |
Andy Whitcroft | 99423c2 | 2009-10-26 16:50:15 -0700 | [diff] [blame] | 1740 | if ($line =~ /^.\s*{/ && |
| 1741 | $prevline =~ /(?:^|[^=])=\s*$/) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1742 | ERROR("that open brace { should be on the previous line\n" . $hereprev); |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 1743 | } |
| 1744 | |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 1745 | # |
| 1746 | # Checks which are anchored on the added line. |
| 1747 | # |
| 1748 | |
| 1749 | # check for malformed paths in #include statements (uses RAW line) |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1750 | if ($rawline =~ m{^.\s*\#\s*include\s+[<"](.*)[">]}) { |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 1751 | my $path = $1; |
| 1752 | if ($path =~ m{//}) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1753 | ERROR("malformed #include filename\n" . |
| 1754 | $herecurr); |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 1755 | } |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 1756 | } |
Andy Whitcroft | 00df344 | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 1757 | |
| 1758 | # no C99 // comments |
| 1759 | if ($line =~ m{//}) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1760 | ERROR("do not use C99 // comments\n" . $herecurr); |
Andy Whitcroft | 00df344 | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 1761 | } |
| 1762 | # Remove C99 comments. |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1763 | $line =~ s@//.*@@; |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 1764 | $opline =~ s@//.*@@; |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1765 | |
Andy Whitcroft | 2b474a1 | 2009-10-26 16:50:16 -0700 | [diff] [blame] | 1766 | # EXPORT_SYMBOL should immediately follow the thing it is exporting, consider |
| 1767 | # the whole statement. |
| 1768 | #print "APW <$lines[$realline_next - 1]>\n"; |
| 1769 | if (defined $realline_next && |
| 1770 | exists $lines[$realline_next - 1] && |
| 1771 | !defined $suppress_export{$realline_next} && |
| 1772 | ($lines[$realline_next - 1] =~ /EXPORT_SYMBOL.*\((.*)\)/ || |
| 1773 | $lines[$realline_next - 1] =~ /EXPORT_UNUSED_SYMBOL.*\((.*)\)/)) { |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 1774 | my $name = $1; |
Andy Whitcroft | 2b474a1 | 2009-10-26 16:50:16 -0700 | [diff] [blame] | 1775 | if ($stat !~ /(?: |
| 1776 | \n.}\s*$| |
Andy Whitcroft | 4801205 | 2008-10-15 22:02:34 -0700 | [diff] [blame] | 1777 | ^.DEFINE_$Ident\(\Q$name\E\)| |
| 1778 | ^.DECLARE_$Ident\(\Q$name\E\)| |
| 1779 | ^.LIST_HEAD\(\Q$name\E\)| |
Andy Whitcroft | 2b474a1 | 2009-10-26 16:50:16 -0700 | [diff] [blame] | 1780 | ^.(?:$Storage\s+)?$Type\s*\(\s*\*\s*\Q$name\E\s*\)\s*\(| |
| 1781 | \b\Q$name\E(?:\s+$Attribute)*\s*(?:;|=|\[|\() |
Andy Whitcroft | 4801205 | 2008-10-15 22:02:34 -0700 | [diff] [blame] | 1782 | )/x) { |
Andy Whitcroft | 2b474a1 | 2009-10-26 16:50:16 -0700 | [diff] [blame] | 1783 | #print "FOO A<$lines[$realline_next - 1]> stat<$stat> name<$name>\n"; |
| 1784 | $suppress_export{$realline_next} = 2; |
| 1785 | } else { |
| 1786 | $suppress_export{$realline_next} = 1; |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1787 | } |
| 1788 | } |
Andy Whitcroft | 2b474a1 | 2009-10-26 16:50:16 -0700 | [diff] [blame] | 1789 | if (!defined $suppress_export{$linenr} && |
| 1790 | $prevline =~ /^.\s*$/ && |
| 1791 | ($line =~ /EXPORT_SYMBOL.*\((.*)\)/ || |
| 1792 | $line =~ /EXPORT_UNUSED_SYMBOL.*\((.*)\)/)) { |
| 1793 | #print "FOO B <$lines[$linenr - 1]>\n"; |
| 1794 | $suppress_export{$linenr} = 2; |
| 1795 | } |
| 1796 | if (defined $suppress_export{$linenr} && |
| 1797 | $suppress_export{$linenr} == 2) { |
| 1798 | WARN("EXPORT_SYMBOL(foo); should immediately follow its function/variable\n" . $herecurr); |
| 1799 | } |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1800 | |
Joe Eloff | 5150bda | 2010-08-09 17:21:00 -0700 | [diff] [blame] | 1801 | # check for global initialisers. |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1802 | if ($line =~ /^.$Type\s*$Ident\s*(?:\s+$Modifier)*\s*=\s*(0|NULL|false)\s*;/) { |
Joe Eloff | 5150bda | 2010-08-09 17:21:00 -0700 | [diff] [blame] | 1803 | ERROR("do not initialise globals to 0 or NULL\n" . |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 1804 | $herecurr); |
| 1805 | } |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 1806 | # check for static initialisers. |
Andy Whitcroft | 2d1bafd | 2009-01-06 14:41:28 -0800 | [diff] [blame] | 1807 | if ($line =~ /\bstatic\s.*=\s*(0|NULL|false)\s*;/) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1808 | ERROR("do not initialise statics to 0 or NULL\n" . |
| 1809 | $herecurr); |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1810 | } |
| 1811 | |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 1812 | # check for new typedefs, only function parameters and sparse annotations |
| 1813 | # make sense. |
| 1814 | if ($line =~ /\btypedef\s/ && |
Andy Whitcroft | 8054576 | 2009-01-06 14:41:26 -0800 | [diff] [blame] | 1815 | $line !~ /\btypedef\s+$Type\s*\(\s*\*?$Ident\s*\)\s*\(/ && |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1816 | $line !~ /\btypedef\s+$Type\s+$Ident\s*\(/ && |
Andy Whitcroft | 8ed22ca | 2008-10-15 22:02:32 -0700 | [diff] [blame] | 1817 | $line !~ /\b$typeTypedefs\b/ && |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 1818 | $line !~ /\b__bitwise(?:__|)\b/) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1819 | WARN("do not add new typedefs\n" . $herecurr); |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1820 | } |
| 1821 | |
| 1822 | # * goes on variable not on type |
Andy Whitcroft | 6586386 | 2009-01-06 14:41:21 -0800 | [diff] [blame] | 1823 | # (char*[ const]) |
Andy Whitcroft | 00ef4ec | 2009-02-27 14:03:07 -0800 | [diff] [blame] | 1824 | if ($line =~ m{\($NonptrType(\s*(?:$Modifier\b\s*|\*\s*)+)\)}) { |
Andy Whitcroft | 6586386 | 2009-01-06 14:41:21 -0800 | [diff] [blame] | 1825 | my ($from, $to) = ($1, $1); |
Andy Whitcroft | d8aaf12 | 2007-06-23 17:16:44 -0700 | [diff] [blame] | 1826 | |
Andy Whitcroft | 6586386 | 2009-01-06 14:41:21 -0800 | [diff] [blame] | 1827 | # Should start with a space. |
| 1828 | $to =~ s/^(\S)/ $1/; |
| 1829 | # Should not end with a space. |
| 1830 | $to =~ s/\s+$//; |
| 1831 | # '*'s should not have spaces between. |
Andy Whitcroft | f9a0b3d | 2009-01-15 13:51:05 -0800 | [diff] [blame] | 1832 | while ($to =~ s/\*\s+\*/\*\*/) { |
Andy Whitcroft | 6586386 | 2009-01-06 14:41:21 -0800 | [diff] [blame] | 1833 | } |
Andy Whitcroft | d8aaf12 | 2007-06-23 17:16:44 -0700 | [diff] [blame] | 1834 | |
Andy Whitcroft | 6586386 | 2009-01-06 14:41:21 -0800 | [diff] [blame] | 1835 | #print "from<$from> to<$to>\n"; |
| 1836 | if ($from ne $to) { |
| 1837 | ERROR("\"(foo$from)\" should be \"(foo$to)\"\n" . $herecurr); |
| 1838 | } |
Andy Whitcroft | 00ef4ec | 2009-02-27 14:03:07 -0800 | [diff] [blame] | 1839 | } elsif ($line =~ m{\b$NonptrType(\s*(?:$Modifier\b\s*|\*\s*)+)($Ident)}) { |
Andy Whitcroft | 6586386 | 2009-01-06 14:41:21 -0800 | [diff] [blame] | 1840 | my ($from, $to, $ident) = ($1, $1, $2); |
Andy Whitcroft | d8aaf12 | 2007-06-23 17:16:44 -0700 | [diff] [blame] | 1841 | |
Andy Whitcroft | 6586386 | 2009-01-06 14:41:21 -0800 | [diff] [blame] | 1842 | # Should start with a space. |
| 1843 | $to =~ s/^(\S)/ $1/; |
| 1844 | # Should not end with a space. |
| 1845 | $to =~ s/\s+$//; |
| 1846 | # '*'s should not have spaces between. |
Andy Whitcroft | f9a0b3d | 2009-01-15 13:51:05 -0800 | [diff] [blame] | 1847 | while ($to =~ s/\*\s+\*/\*\*/) { |
Andy Whitcroft | 6586386 | 2009-01-06 14:41:21 -0800 | [diff] [blame] | 1848 | } |
| 1849 | # Modifiers should have spaces. |
| 1850 | $to =~ s/(\b$Modifier$)/$1 /; |
| 1851 | |
Andy Whitcroft | 667026e | 2009-02-27 14:03:08 -0800 | [diff] [blame] | 1852 | #print "from<$from> to<$to> ident<$ident>\n"; |
| 1853 | if ($from ne $to && $ident !~ /^$Modifier$/) { |
Andy Whitcroft | 6586386 | 2009-01-06 14:41:21 -0800 | [diff] [blame] | 1854 | ERROR("\"foo${from}bar\" should be \"foo${to}bar\"\n" . $herecurr); |
| 1855 | } |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1856 | } |
| 1857 | |
| 1858 | # # no BUG() or BUG_ON() |
| 1859 | # if ($line =~ /\b(BUG|BUG_ON)\b/) { |
| 1860 | # print "Try to use WARN_ON & Recovery code rather than BUG() or BUG_ON()\n"; |
| 1861 | # print "$herecurr"; |
| 1862 | # $clean = 0; |
| 1863 | # } |
| 1864 | |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 1865 | if ($line =~ /\bLINUX_VERSION_CODE\b/) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1866 | WARN("LINUX_VERSION_CODE should be avoided, code should be for the version to which it is merged\n" . $herecurr); |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 1867 | } |
| 1868 | |
Andy Whitcroft | 00df344 | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 1869 | # printk should use KERN_* levels. Note that follow on printk's on the |
| 1870 | # same line do not need a level, so we use the current block context |
| 1871 | # to try and find and validate the current printk. In summary the current |
| 1872 | # printk includes all preceeding printk's which have no newline on the end. |
| 1873 | # we assume the first bad printk is the one to report. |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 1874 | if ($line =~ /\bprintk\((?!KERN_)\s*"/) { |
Andy Whitcroft | 00df344 | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 1875 | my $ok = 0; |
| 1876 | for (my $ln = $linenr - 1; $ln >= $first_line; $ln--) { |
| 1877 | #print "CHECK<$lines[$ln - 1]\n"; |
| 1878 | # we have a preceeding printk if it ends |
| 1879 | # with "\n" ignore it, else it is to blame |
| 1880 | if ($lines[$ln - 1] =~ m{\bprintk\(}) { |
| 1881 | if ($rawlines[$ln - 1] !~ m{\\n"}) { |
| 1882 | $ok = 1; |
| 1883 | } |
| 1884 | last; |
| 1885 | } |
| 1886 | } |
| 1887 | if ($ok == 0) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1888 | WARN("printk() should include KERN_ facility level\n" . $herecurr); |
Andy Whitcroft | 00df344 | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 1889 | } |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1890 | } |
| 1891 | |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 1892 | # function brace can't be on same line, except for #defines of do while, |
| 1893 | # or if closed on same line |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1894 | if (($line=~/$Type\s*$Ident\(.*\).*\s{/) and |
| 1895 | !($line=~/\#\s*define.*do\s{/) and !($line=~/}/)) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1896 | ERROR("open brace '{' following function declarations go on the next line\n" . $herecurr); |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1897 | } |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 1898 | |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 1899 | # open braces for enum, union and struct go on the same line. |
| 1900 | if ($line =~ /^.\s*{/ && |
| 1901 | $prevline =~ /^.\s*(?:typedef\s+)?(enum|union|struct)(?:\s+$Ident)?\s*$/) { |
| 1902 | ERROR("open brace '{' following $1 go on the same line\n" . $hereprev); |
| 1903 | } |
| 1904 | |
Andy Whitcroft | 8d31cfc | 2008-07-23 21:29:02 -0700 | [diff] [blame] | 1905 | # check for spacing round square brackets; allowed: |
| 1906 | # 1. with a type on the left -- int [] a; |
Andy Whitcroft | fe2a7db | 2008-10-15 22:02:15 -0700 | [diff] [blame] | 1907 | # 2. at the beginning of a line for slice initialisers -- [0...10] = 5, |
| 1908 | # 3. inside a curly brace -- = { [0...10] = 5 } |
Andy Whitcroft | 8d31cfc | 2008-07-23 21:29:02 -0700 | [diff] [blame] | 1909 | while ($line =~ /(.*?\s)\[/g) { |
| 1910 | my ($where, $prefix) = ($-[1], $1); |
| 1911 | if ($prefix !~ /$Type\s+$/ && |
Andy Whitcroft | fe2a7db | 2008-10-15 22:02:15 -0700 | [diff] [blame] | 1912 | ($where != 0 || $prefix !~ /^.\s+$/) && |
| 1913 | $prefix !~ /{\s+$/) { |
Andy Whitcroft | 8d31cfc | 2008-07-23 21:29:02 -0700 | [diff] [blame] | 1914 | ERROR("space prohibited before open square bracket '['\n" . $herecurr); |
| 1915 | } |
| 1916 | } |
| 1917 | |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 1918 | # check for spaces between functions and their parentheses. |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 1919 | while ($line =~ /($Ident)\s+\(/g) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1920 | my $name = $1; |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1921 | my $ctx_before = substr($line, 0, $-[1]); |
| 1922 | my $ctx = "$ctx_before$name"; |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1923 | |
| 1924 | # Ignore those directives where spaces _are_ permitted. |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1925 | if ($name =~ /^(?: |
| 1926 | if|for|while|switch|return|case| |
| 1927 | volatile|__volatile__| |
| 1928 | __attribute__|format|__extension__| |
| 1929 | asm|__asm__)$/x) |
| 1930 | { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1931 | |
| 1932 | # cpp #define statements have non-optional spaces, ie |
| 1933 | # if there is a space between the name and the open |
| 1934 | # parenthesis it is simply not a parameter group. |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1935 | } elsif ($ctx_before =~ /^.\s*\#\s*define\s*$/) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1936 | |
| 1937 | # cpp #elif statement condition may start with a ( |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1938 | } elsif ($ctx =~ /^.\s*\#\s*elif\s*$/) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1939 | |
| 1940 | # If this whole things ends with a type its most |
| 1941 | # likely a typedef for a function. |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1942 | } elsif ($ctx =~ /$Type$/) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1943 | |
| 1944 | } else { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1945 | WARN("space prohibited between function name and open parenthesis '('\n" . $herecurr); |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 1946 | } |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 1947 | } |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 1948 | # Check operator spacing. |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1949 | if (!($line=~/\#\s*include/)) { |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 1950 | my $ops = qr{ |
| 1951 | <<=|>>=|<=|>=|==|!=| |
| 1952 | \+=|-=|\*=|\/=|%=|\^=|\|=|&=| |
| 1953 | =>|->|<<|>>|<|>|=|!|~| |
Andy Whitcroft | 1f65f94 | 2008-07-23 21:29:10 -0700 | [diff] [blame] | 1954 | &&|\|\||,|\^|\+\+|--|&|\||\+|-|\*|\/|%| |
| 1955 | \?|: |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 1956 | }x; |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 1957 | my @elements = split(/($ops|;)/, $opline); |
Andy Whitcroft | 00df344 | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 1958 | my $off = 0; |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 1959 | |
| 1960 | my $blank = copy_spacing($opline); |
| 1961 | |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1962 | for (my $n = 0; $n < $#elements; $n += 2) { |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 1963 | $off += length($elements[$n]); |
| 1964 | |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1965 | # Pick up the preceeding and succeeding characters. |
| 1966 | my $ca = substr($opline, 0, $off); |
| 1967 | my $cc = ''; |
| 1968 | if (length($opline) >= ($off + length($elements[$n + 1]))) { |
| 1969 | $cc = substr($opline, $off + length($elements[$n + 1])); |
| 1970 | } |
| 1971 | my $cb = "$ca$;$cc"; |
| 1972 | |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 1973 | my $a = ''; |
| 1974 | $a = 'V' if ($elements[$n] ne ''); |
| 1975 | $a = 'W' if ($elements[$n] =~ /\s$/); |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 1976 | $a = 'C' if ($elements[$n] =~ /$;$/); |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 1977 | $a = 'B' if ($elements[$n] =~ /(\[|\()$/); |
| 1978 | $a = 'O' if ($elements[$n] eq ''); |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1979 | $a = 'E' if ($ca =~ /^\s*$/); |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 1980 | |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1981 | my $op = $elements[$n + 1]; |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 1982 | |
| 1983 | my $c = ''; |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1984 | if (defined $elements[$n + 2]) { |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 1985 | $c = 'V' if ($elements[$n + 2] ne ''); |
| 1986 | $c = 'W' if ($elements[$n + 2] =~ /^\s/); |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 1987 | $c = 'C' if ($elements[$n + 2] =~ /^$;/); |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 1988 | $c = 'B' if ($elements[$n + 2] =~ /^(\)|\]|;)/); |
| 1989 | $c = 'O' if ($elements[$n + 2] eq ''); |
Andy Whitcroft | 8b1b337 | 2009-01-06 14:41:27 -0800 | [diff] [blame] | 1990 | $c = 'E' if ($elements[$n + 2] =~ /^\s*\\$/); |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 1991 | } else { |
| 1992 | $c = 'E'; |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1993 | } |
| 1994 | |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 1995 | my $ctx = "${a}x${c}"; |
| 1996 | |
| 1997 | my $at = "(ctx:$ctx)"; |
| 1998 | |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 1999 | my $ptr = substr($blank, 0, $off) . "^"; |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 2000 | my $hereptr = "$hereline$ptr\n"; |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 2001 | |
Andy Whitcroft | 74048ed | 2008-07-23 21:29:10 -0700 | [diff] [blame] | 2002 | # Pull out the value of this operator. |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 2003 | my $op_type = substr($curr_values, $off + 1, 1); |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 2004 | |
Andy Whitcroft | 1f65f94 | 2008-07-23 21:29:10 -0700 | [diff] [blame] | 2005 | # Get the full operator variant. |
| 2006 | my $opv = $op . substr($curr_vars, $off, 1); |
| 2007 | |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 2008 | # Ignore operators passed as parameters. |
| 2009 | if ($op_type ne 'V' && |
| 2010 | $ca =~ /\s$/ && $cc =~ /^\s*,/) { |
| 2011 | |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 2012 | # # Ignore comments |
| 2013 | # } elsif ($op =~ /^$;+$/) { |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 2014 | |
Andy Whitcroft | d8aaf12 | 2007-06-23 17:16:44 -0700 | [diff] [blame] | 2015 | # ; should have either the end of line or a space or \ after it |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 2016 | } elsif ($op eq ';') { |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 2017 | if ($ctx !~ /.x[WEBC]/ && |
| 2018 | $cc !~ /^\\/ && $cc !~ /^;/) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 2019 | ERROR("space required after that '$op' $at\n" . $hereptr); |
Andy Whitcroft | d8aaf12 | 2007-06-23 17:16:44 -0700 | [diff] [blame] | 2020 | } |
| 2021 | |
| 2022 | # // is a comment |
| 2023 | } elsif ($op eq '//') { |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 2024 | |
Andy Whitcroft | 1f65f94 | 2008-07-23 21:29:10 -0700 | [diff] [blame] | 2025 | # No spaces for: |
| 2026 | # -> |
| 2027 | # : when part of a bitfield |
| 2028 | } elsif ($op eq '->' || $opv eq ':B') { |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 2029 | if ($ctx =~ /Wx.|.xW/) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 2030 | ERROR("spaces prohibited around that '$op' $at\n" . $hereptr); |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 2031 | } |
| 2032 | |
| 2033 | # , must have a space on the right. |
| 2034 | } elsif ($op eq ',') { |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 2035 | if ($ctx !~ /.x[WEC]/ && $cc !~ /^}/) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 2036 | ERROR("space required after that '$op' $at\n" . $hereptr); |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 2037 | } |
| 2038 | |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 2039 | # '*' as part of a type definition -- reported already. |
Andy Whitcroft | 74048ed | 2008-07-23 21:29:10 -0700 | [diff] [blame] | 2040 | } elsif ($opv eq '*_') { |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 2041 | #warn "'*' is part of type\n"; |
| 2042 | |
| 2043 | # unary operators should have a space before and |
| 2044 | # none after. May be left adjacent to another |
| 2045 | # unary operator, or a cast |
| 2046 | } elsif ($op eq '!' || $op eq '~' || |
Andy Whitcroft | 74048ed | 2008-07-23 21:29:10 -0700 | [diff] [blame] | 2047 | $opv eq '*U' || $opv eq '-U' || |
Andy Whitcroft | 0d41386 | 2008-10-15 22:02:16 -0700 | [diff] [blame] | 2048 | $opv eq '&U' || $opv eq '&&U') { |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 2049 | if ($ctx !~ /[WEBC]x./ && $ca !~ /(?:\)|!|~|\*|-|\&|\||\+\+|\-\-|\{)$/) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 2050 | ERROR("space required before that '$op' $at\n" . $hereptr); |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 2051 | } |
Andy Whitcroft | a3340b3 | 2009-02-27 14:03:07 -0800 | [diff] [blame] | 2052 | if ($op eq '*' && $cc =~/\s*$Modifier\b/) { |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 2053 | # A unary '*' may be const |
| 2054 | |
| 2055 | } elsif ($ctx =~ /.xW/) { |
Andy Whitcroft | fb9e909 | 2009-09-21 17:04:38 -0700 | [diff] [blame] | 2056 | ERROR("space prohibited after that '$op' $at\n" . $hereptr); |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 2057 | } |
| 2058 | |
| 2059 | # unary ++ and unary -- are allowed no space on one side. |
| 2060 | } elsif ($op eq '++' or $op eq '--') { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 2061 | if ($ctx !~ /[WEOBC]x[^W]/ && $ctx !~ /[^W]x[WOBEC]/) { |
| 2062 | ERROR("space required one side of that '$op' $at\n" . $hereptr); |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 2063 | } |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 2064 | if ($ctx =~ /Wx[BE]/ || |
| 2065 | ($ctx =~ /Wx./ && $cc =~ /^;/)) { |
| 2066 | ERROR("space prohibited before that '$op' $at\n" . $hereptr); |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 2067 | } |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 2068 | if ($ctx =~ /ExW/) { |
| 2069 | ERROR("space prohibited after that '$op' $at\n" . $hereptr); |
| 2070 | } |
| 2071 | |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 2072 | |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 2073 | # << and >> may either have or not have spaces both sides |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 2074 | } elsif ($op eq '<<' or $op eq '>>' or |
| 2075 | $op eq '&' or $op eq '^' or $op eq '|' or |
| 2076 | $op eq '+' or $op eq '-' or |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 2077 | $op eq '*' or $op eq '/' or |
| 2078 | $op eq '%') |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 2079 | { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 2080 | if ($ctx =~ /Wx[^WCE]|[^WCE]xW/) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 2081 | ERROR("need consistent spacing around '$op' $at\n" . |
| 2082 | $hereptr); |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 2083 | } |
| 2084 | |
Andy Whitcroft | 1f65f94 | 2008-07-23 21:29:10 -0700 | [diff] [blame] | 2085 | # A colon needs no spaces before when it is |
| 2086 | # terminating a case value or a label. |
| 2087 | } elsif ($opv eq ':C' || $opv eq ':L') { |
| 2088 | if ($ctx =~ /Wx./) { |
| 2089 | ERROR("space prohibited before that '$op' $at\n" . $hereptr); |
| 2090 | } |
| 2091 | |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 2092 | # All the others need spaces both sides. |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 2093 | } elsif ($ctx !~ /[EWC]x[CWE]/) { |
Andy Whitcroft | 1f65f94 | 2008-07-23 21:29:10 -0700 | [diff] [blame] | 2094 | my $ok = 0; |
| 2095 | |
Andy Whitcroft | 22f2a2e | 2007-08-10 13:01:03 -0700 | [diff] [blame] | 2096 | # Ignore email addresses <foo@bar> |
Andy Whitcroft | 1f65f94 | 2008-07-23 21:29:10 -0700 | [diff] [blame] | 2097 | if (($op eq '<' && |
| 2098 | $cc =~ /^\S+\@\S+>/) || |
| 2099 | ($op eq '>' && |
| 2100 | $ca =~ /<\S+\@\S+$/)) |
| 2101 | { |
| 2102 | $ok = 1; |
| 2103 | } |
| 2104 | |
| 2105 | # Ignore ?: |
| 2106 | if (($opv eq ':O' && $ca =~ /\?$/) || |
| 2107 | ($op eq '?' && $cc =~ /^:/)) { |
| 2108 | $ok = 1; |
| 2109 | } |
| 2110 | |
| 2111 | if ($ok == 0) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 2112 | ERROR("spaces required around that '$op' $at\n" . $hereptr); |
Andy Whitcroft | 22f2a2e | 2007-08-10 13:01:03 -0700 | [diff] [blame] | 2113 | } |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 2114 | } |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 2115 | $off += length($elements[$n + 1]); |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 2116 | } |
| 2117 | } |
| 2118 | |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 2119 | # check for multiple assignments |
| 2120 | if ($line =~ /^.\s*$Lval\s*=\s*$Lval\s*=(?!=)/) { |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 2121 | CHK("multiple assignments should be avoided\n" . $herecurr); |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 2122 | } |
| 2123 | |
Andy Whitcroft | 22f2a2e | 2007-08-10 13:01:03 -0700 | [diff] [blame] | 2124 | ## # check for multiple declarations, allowing for a function declaration |
| 2125 | ## # continuation. |
| 2126 | ## if ($line =~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Ident.*/ && |
| 2127 | ## $line !~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Type\s*$Ident.*/) { |
| 2128 | ## |
| 2129 | ## # Remove any bracketed sections to ensure we do not |
| 2130 | ## # falsly report the parameters of functions. |
| 2131 | ## my $ln = $line; |
| 2132 | ## while ($ln =~ s/\([^\(\)]*\)//g) { |
| 2133 | ## } |
| 2134 | ## if ($ln =~ /,/) { |
| 2135 | ## WARN("declaring multiple variables together should be avoided\n" . $herecurr); |
| 2136 | ## } |
| 2137 | ## } |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 2138 | |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 2139 | #need space before brace following if, while, etc |
Andy Whitcroft | 22f2a2e | 2007-08-10 13:01:03 -0700 | [diff] [blame] | 2140 | if (($line =~ /\(.*\){/ && $line !~ /\($Type\){/) || |
| 2141 | $line =~ /do{/) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 2142 | ERROR("space required before the open brace '{'\n" . $herecurr); |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 2143 | } |
| 2144 | |
| 2145 | # closing brace should have a space following it when it has anything |
| 2146 | # on the line |
| 2147 | if ($line =~ /}(?!(?:,|;|\)))\S/) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 2148 | ERROR("space required after that close brace '}'\n" . $herecurr); |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 2149 | } |
| 2150 | |
Andy Whitcroft | 22f2a2e | 2007-08-10 13:01:03 -0700 | [diff] [blame] | 2151 | # check spacing on square brackets |
| 2152 | if ($line =~ /\[\s/ && $line !~ /\[\s*$/) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 2153 | ERROR("space prohibited after that open square bracket '['\n" . $herecurr); |
Andy Whitcroft | 22f2a2e | 2007-08-10 13:01:03 -0700 | [diff] [blame] | 2154 | } |
| 2155 | if ($line =~ /\s\]/) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 2156 | ERROR("space prohibited before that close square bracket ']'\n" . $herecurr); |
Andy Whitcroft | 22f2a2e | 2007-08-10 13:01:03 -0700 | [diff] [blame] | 2157 | } |
| 2158 | |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 2159 | # check spacing on parentheses |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 2160 | if ($line =~ /\(\s/ && $line !~ /\(\s*(?:\\)?$/ && |
| 2161 | $line !~ /for\s*\(\s+;/) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 2162 | ERROR("space prohibited after that open parenthesis '('\n" . $herecurr); |
Andy Whitcroft | 22f2a2e | 2007-08-10 13:01:03 -0700 | [diff] [blame] | 2163 | } |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 2164 | if ($line =~ /(\s+)\)/ && $line !~ /^.\s*\)/ && |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 2165 | $line !~ /for\s*\(.*;\s+\)/ && |
| 2166 | $line !~ /:\s+\)/) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 2167 | ERROR("space prohibited before that close parenthesis ')'\n" . $herecurr); |
Andy Whitcroft | 22f2a2e | 2007-08-10 13:01:03 -0700 | [diff] [blame] | 2168 | } |
| 2169 | |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 2170 | #goto labels aren't indented, allow a single space however |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 2171 | if ($line=~/^.\s+[A-Za-z\d_]+:(?![0-9]+)/ and |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 2172 | !($line=~/^. [A-Za-z\d_]+:/) and !($line=~/^.\s+default:/)) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 2173 | WARN("labels should not be indented\n" . $herecurr); |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 2174 | } |
| 2175 | |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 2176 | # Return is not a function. |
| 2177 | if (defined($stat) && $stat =~ /^.\s*return(\s*)(\(.*);/s) { |
| 2178 | my $spacing = $1; |
| 2179 | my $value = $2; |
| 2180 | |
Andy Whitcroft | 86f9d05 | 2009-01-06 14:41:24 -0800 | [diff] [blame] | 2181 | # Flatten any parentheses |
Andy Whitcroft | fee61c4 | 2008-07-23 21:28:56 -0700 | [diff] [blame] | 2182 | $value =~ s/\)\(/\) \(/g; |
Andy Whitcroft | 63f17f8 | 2009-01-15 13:51:06 -0800 | [diff] [blame] | 2183 | while ($value =~ s/\[[^\{\}]*\]/1/ || |
| 2184 | $value !~ /(?:$Ident|-?$Constant)\s* |
| 2185 | $Compare\s* |
| 2186 | (?:$Ident|-?$Constant)/x && |
| 2187 | $value =~ s/\([^\(\)]*\)/1/) { |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 2188 | } |
| 2189 | |
| 2190 | if ($value =~ /^(?:$Ident|-?$Constant)$/) { |
| 2191 | ERROR("return is not a function, parentheses are not required\n" . $herecurr); |
| 2192 | |
| 2193 | } elsif ($spacing !~ /\s+/) { |
| 2194 | ERROR("space required before the open parenthesis '('\n" . $herecurr); |
| 2195 | } |
| 2196 | } |
| 2197 | |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 2198 | # Need a space before open parenthesis after if, while etc |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 2199 | if ($line=~/\b(if|while|for|switch)\(/) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 2200 | ERROR("space required before the open parenthesis '('\n" . $herecurr); |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 2201 | } |
| 2202 | |
Andy Whitcroft | f5fe35d | 2008-07-23 21:29:03 -0700 | [diff] [blame] | 2203 | # Check for illegal assignment in if conditional -- and check for trailing |
| 2204 | # statements after the conditional. |
Andy Whitcroft | 170d3a2 | 2008-10-15 22:02:30 -0700 | [diff] [blame] | 2205 | if ($line =~ /do\s*(?!{)/) { |
| 2206 | my ($stat_next) = ctx_statement_block($line_nr_next, |
| 2207 | $remain_next, $off_next); |
| 2208 | $stat_next =~ s/\n./\n /g; |
| 2209 | ##print "stat<$stat> stat_next<$stat_next>\n"; |
| 2210 | |
| 2211 | if ($stat_next =~ /^\s*while\b/) { |
| 2212 | # If the statement carries leading newlines, |
| 2213 | # then count those as offsets. |
| 2214 | my ($whitespace) = |
| 2215 | ($stat_next =~ /^((?:\s*\n[+-])*\s*)/s); |
| 2216 | my $offset = |
| 2217 | statement_rawlines($whitespace) - 1; |
| 2218 | |
| 2219 | $suppress_whiletrailers{$line_nr_next + |
| 2220 | $offset} = 1; |
| 2221 | } |
| 2222 | } |
| 2223 | if (!defined $suppress_whiletrailers{$linenr} && |
| 2224 | $line =~ /\b(?:if|while|for)\s*\(/ && $line !~ /^.\s*#/) { |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 2225 | my ($s, $c) = ($stat, $cond); |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 2226 | |
Andy Whitcroft | b53c8e1 | 2009-01-06 14:41:29 -0800 | [diff] [blame] | 2227 | if ($c =~ /\bif\s*\(.*[^<>!=]=[^=].*/s) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 2228 | ERROR("do not use assignment in if condition\n" . $herecurr); |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 2229 | } |
| 2230 | |
| 2231 | # Find out what is on the end of the line after the |
| 2232 | # conditional. |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 2233 | substr($s, 0, length($c), ''); |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 2234 | $s =~ s/\n.*//g; |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 2235 | $s =~ s/$;//g; # Remove any comments |
Andy Whitcroft | 5321016 | 2008-07-23 21:29:03 -0700 | [diff] [blame] | 2236 | if (length($c) && $s !~ /^\s*{?\s*\\*\s*$/ && |
| 2237 | $c !~ /}\s*while\s*/) |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 2238 | { |
Andy Whitcroft | bb44ad3 | 2008-10-15 22:02:34 -0700 | [diff] [blame] | 2239 | # Find out how long the conditional actually is. |
| 2240 | my @newlines = ($c =~ /\n/gs); |
| 2241 | my $cond_lines = 1 + $#newlines; |
Hidetoshi Seto | 42bdf74 | 2010-03-05 13:43:50 -0800 | [diff] [blame] | 2242 | my $stat_real = ''; |
Andy Whitcroft | bb44ad3 | 2008-10-15 22:02:34 -0700 | [diff] [blame] | 2243 | |
Hidetoshi Seto | 42bdf74 | 2010-03-05 13:43:50 -0800 | [diff] [blame] | 2244 | $stat_real = raw_line($linenr, $cond_lines) |
| 2245 | . "\n" if ($cond_lines); |
Andy Whitcroft | bb44ad3 | 2008-10-15 22:02:34 -0700 | [diff] [blame] | 2246 | if (defined($stat_real) && $cond_lines > 1) { |
| 2247 | $stat_real = "[...]\n$stat_real"; |
| 2248 | } |
| 2249 | |
| 2250 | ERROR("trailing statements should be on next line\n" . $herecurr . $stat_real); |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 2251 | } |
| 2252 | } |
| 2253 | |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 2254 | # Check for bitwise tests written as boolean |
| 2255 | if ($line =~ / |
| 2256 | (?: |
| 2257 | (?:\[|\(|\&\&|\|\|) |
| 2258 | \s*0[xX][0-9]+\s* |
| 2259 | (?:\&\&|\|\|) |
| 2260 | | |
| 2261 | (?:\&\&|\|\|) |
| 2262 | \s*0[xX][0-9]+\s* |
| 2263 | (?:\&\&|\|\||\)|\]) |
| 2264 | )/x) |
| 2265 | { |
| 2266 | WARN("boolean test with hexadecimal, perhaps just 1 \& or \|?\n" . $herecurr); |
| 2267 | } |
| 2268 | |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 2269 | # if and else should not have general statements after it |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 2270 | if ($line =~ /^.\s*(?:}\s*)?else\b(.*)/) { |
| 2271 | my $s = $1; |
| 2272 | $s =~ s/$;//g; # Remove any comments |
| 2273 | if ($s !~ /^\s*(?:\sif|(?:{|)\s*\\?\s*$)/) { |
| 2274 | ERROR("trailing statements should be on next line\n" . $herecurr); |
| 2275 | } |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 2276 | } |
Andy Whitcroft | 3966778 | 2009-01-15 13:51:06 -0800 | [diff] [blame] | 2277 | # if should not continue a brace |
| 2278 | if ($line =~ /}\s*if\b/) { |
| 2279 | ERROR("trailing statements should be on next line\n" . |
| 2280 | $herecurr); |
| 2281 | } |
Andy Whitcroft | a1080bf | 2008-10-15 22:02:25 -0700 | [diff] [blame] | 2282 | # case and default should not have general statements after them |
| 2283 | if ($line =~ /^.\s*(?:case\s*.*|default\s*):/g && |
| 2284 | $line !~ /\G(?: |
Andy Whitcroft | 3fef12d | 2008-10-15 22:02:36 -0700 | [diff] [blame] | 2285 | (?:\s*$;*)(?:\s*{)?(?:\s*$;*)(?:\s*\\)?\s*$| |
Andy Whitcroft | a1080bf | 2008-10-15 22:02:25 -0700 | [diff] [blame] | 2286 | \s*return\s+ |
| 2287 | )/xg) |
| 2288 | { |
| 2289 | ERROR("trailing statements should be on next line\n" . $herecurr); |
| 2290 | } |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 2291 | |
| 2292 | # Check for }<nl>else {, these must be at the same |
| 2293 | # indent level to be relevant to each other. |
| 2294 | if ($prevline=~/}\s*$/ and $line=~/^.\s*else\s*/ and |
| 2295 | $previndent == $indent) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 2296 | ERROR("else should follow close brace '}'\n" . $hereprev); |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 2297 | } |
| 2298 | |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 2299 | if ($prevline=~/}\s*$/ and $line=~/^.\s*while\s*/ and |
| 2300 | $previndent == $indent) { |
| 2301 | my ($s, $c) = ctx_statement_block($linenr, $realcnt, 0); |
| 2302 | |
| 2303 | # Find out what is on the end of the line after the |
| 2304 | # conditional. |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 2305 | substr($s, 0, length($c), ''); |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 2306 | $s =~ s/\n.*//g; |
| 2307 | |
| 2308 | if ($s =~ /^\s*;/) { |
| 2309 | ERROR("while should follow close brace '}'\n" . $hereprev); |
| 2310 | } |
| 2311 | } |
| 2312 | |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 2313 | #studly caps, commented out until figure out how to distinguish between use of existing and adding new |
| 2314 | # if (($line=~/[\w_][a-z\d]+[A-Z]/) and !($line=~/print/)) { |
| 2315 | # print "No studly caps, use _\n"; |
| 2316 | # print "$herecurr"; |
| 2317 | # $clean = 0; |
| 2318 | # } |
| 2319 | |
| 2320 | #no spaces allowed after \ in define |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 2321 | if ($line=~/\#\s*define.*\\\s$/) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 2322 | WARN("Whitepspace after \\ makes next lines useless\n" . $herecurr); |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 2323 | } |
| 2324 | |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 2325 | #warn if <asm/foo.h> is #included and <linux/foo.h> is available (uses RAW line) |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 2326 | if ($tree && $rawline =~ m{^.\s*\#\s*include\s*\<asm\/(.*)\.h\>}) { |
Andy Whitcroft | e09dec4 | 2008-10-15 22:02:20 -0700 | [diff] [blame] | 2327 | my $file = "$1.h"; |
| 2328 | my $checkfile = "include/linux/$file"; |
| 2329 | if (-f "$root/$checkfile" && |
| 2330 | $realfile ne $checkfile && |
Wolfram Sang | 7840a94 | 2010-08-09 17:20:57 -0700 | [diff] [blame] | 2331 | $1 !~ /$allowed_asm_includes/) |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 2332 | { |
Andy Whitcroft | e09dec4 | 2008-10-15 22:02:20 -0700 | [diff] [blame] | 2333 | if ($realfile =~ m{^arch/}) { |
| 2334 | CHK("Consider using #include <linux/$file> instead of <asm/$file>\n" . $herecurr); |
| 2335 | } else { |
| 2336 | WARN("Use #include <linux/$file> instead of <asm/$file>\n" . $herecurr); |
| 2337 | } |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 2338 | } |
| 2339 | } |
| 2340 | |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 2341 | # multi-statement macros should be enclosed in a do while loop, grab the |
| 2342 | # first statement and ensure its the whole macro if its not enclosed |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 2343 | # in a known good container |
Andy Whitcroft | b8f96a3 | 2008-07-23 21:29:07 -0700 | [diff] [blame] | 2344 | if ($realfile !~ m@/vmlinux.lds.h$@ && |
| 2345 | $line =~ /^.\s*\#\s*define\s*$Ident(\()?/) { |
Andy Whitcroft | d8aaf12 | 2007-06-23 17:16:44 -0700 | [diff] [blame] | 2346 | my $ln = $linenr; |
| 2347 | my $cnt = $realcnt; |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 2348 | my ($off, $dstat, $dcond, $rest); |
| 2349 | my $ctx = ''; |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 2350 | |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 2351 | my $args = defined($1); |
| 2352 | |
| 2353 | # Find the end of the macro and limit our statement |
| 2354 | # search to that. |
| 2355 | while ($cnt > 0 && defined $lines[$ln - 1] && |
| 2356 | $lines[$ln - 1] =~ /^(?:-|..*\\$)/) |
| 2357 | { |
| 2358 | $ctx .= $rawlines[$ln - 1] . "\n"; |
Andy Whitcroft | a3bb97a | 2008-07-23 21:29:00 -0700 | [diff] [blame] | 2359 | $cnt-- if ($lines[$ln - 1] !~ /^-/); |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 2360 | $ln++; |
Andy Whitcroft | d8aaf12 | 2007-06-23 17:16:44 -0700 | [diff] [blame] | 2361 | } |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 2362 | $ctx .= $rawlines[$ln - 1]; |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 2363 | |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 2364 | ($dstat, $dcond, $ln, $cnt, $off) = |
| 2365 | ctx_statement_block($linenr, $ln - $linenr + 1, 0); |
| 2366 | #print "dstat<$dstat> dcond<$dcond> cnt<$cnt> off<$off>\n"; |
Andy Whitcroft | a3bb97a | 2008-07-23 21:29:00 -0700 | [diff] [blame] | 2367 | #print "LINE<$lines[$ln-1]> len<" . length($lines[$ln-1]) . "\n"; |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 2368 | |
| 2369 | # Extract the remainder of the define (if any) and |
| 2370 | # rip off surrounding spaces, and trailing \'s. |
| 2371 | $rest = ''; |
Andy Whitcroft | 636d140 | 2008-10-15 22:02:18 -0700 | [diff] [blame] | 2372 | while ($off != 0 || ($cnt > 0 && $rest =~ /\\\s*$/)) { |
| 2373 | #print "ADDING cnt<$cnt> $off <" . substr($lines[$ln - 1], $off) . "> rest<$rest>\n"; |
Andy Whitcroft | a3bb97a | 2008-07-23 21:29:00 -0700 | [diff] [blame] | 2374 | if ($off != 0 || $lines[$ln - 1] !~ /^-/) { |
| 2375 | $rest .= substr($lines[$ln - 1], $off) . "\n"; |
| 2376 | $cnt--; |
| 2377 | } |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 2378 | $ln++; |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 2379 | $off = 0; |
| 2380 | } |
| 2381 | $rest =~ s/\\\n.//g; |
| 2382 | $rest =~ s/^\s*//s; |
| 2383 | $rest =~ s/\s*$//s; |
| 2384 | |
| 2385 | # Clean up the original statement. |
| 2386 | if ($args) { |
| 2387 | substr($dstat, 0, length($dcond), ''); |
| 2388 | } else { |
| 2389 | $dstat =~ s/^.\s*\#\s*define\s+$Ident\s*//; |
| 2390 | } |
Andy Whitcroft | 292f1a9 | 2008-07-23 21:29:11 -0700 | [diff] [blame] | 2391 | $dstat =~ s/$;//g; |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 2392 | $dstat =~ s/\\\n.//g; |
| 2393 | $dstat =~ s/^\s*//s; |
| 2394 | $dstat =~ s/\s*$//s; |
| 2395 | |
| 2396 | # Flatten any parentheses and braces |
Andy Whitcroft | bf30d6e | 2008-10-15 22:02:33 -0700 | [diff] [blame] | 2397 | while ($dstat =~ s/\([^\(\)]*\)/1/ || |
| 2398 | $dstat =~ s/\{[^\{\}]*\}/1/ || |
| 2399 | $dstat =~ s/\[[^\{\}]*\]/1/) |
| 2400 | { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 2401 | } |
Andy Whitcroft | d8aaf12 | 2007-06-23 17:16:44 -0700 | [diff] [blame] | 2402 | |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 2403 | my $exceptions = qr{ |
| 2404 | $Declare| |
| 2405 | module_param_named| |
| 2406 | MODULE_PARAM_DESC| |
| 2407 | DECLARE_PER_CPU| |
| 2408 | DEFINE_PER_CPU| |
Andy Whitcroft | 383099f | 2009-01-06 14:41:18 -0800 | [diff] [blame] | 2409 | __typeof__\(| |
Stefani Seibold | 22fd2d3 | 2010-03-05 13:43:52 -0800 | [diff] [blame] | 2410 | union| |
| 2411 | struct| |
Andy Whitcroft | ea71a0a | 2009-09-21 17:04:38 -0700 | [diff] [blame] | 2412 | \.$Ident\s*=\s*| |
| 2413 | ^\"|\"$ |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 2414 | }x; |
Andy Whitcroft | 383099f | 2009-01-06 14:41:18 -0800 | [diff] [blame] | 2415 | #print "REST<$rest> dstat<$dstat>\n"; |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 2416 | if ($rest ne '') { |
| 2417 | if ($rest !~ /while\s*\(/ && |
| 2418 | $dstat !~ /$exceptions/) |
| 2419 | { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 2420 | ERROR("Macros with multiple statements should be enclosed in a do - while loop\n" . "$here\n$ctx\n"); |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 2421 | } |
| 2422 | |
| 2423 | } elsif ($ctx !~ /;/) { |
| 2424 | if ($dstat ne '' && |
| 2425 | $dstat !~ /^(?:$Ident|-?$Constant)$/ && |
| 2426 | $dstat !~ /$exceptions/ && |
Andy Whitcroft | b132e5d | 2008-10-15 22:02:31 -0700 | [diff] [blame] | 2427 | $dstat !~ /^\.$Ident\s*=/ && |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 2428 | $dstat =~ /$Operators/) |
| 2429 | { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 2430 | ERROR("Macros with complex values should be enclosed in parenthesis\n" . "$here\n$ctx\n"); |
Andy Whitcroft | d8aaf12 | 2007-06-23 17:16:44 -0700 | [diff] [blame] | 2431 | } |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 2432 | } |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 2433 | } |
| 2434 | |
Mike Frysinger | 080ba92 | 2009-01-06 14:41:25 -0800 | [diff] [blame] | 2435 | # make sure symbols are always wrapped with VMLINUX_SYMBOL() ... |
| 2436 | # all assignments may have only one of the following with an assignment: |
| 2437 | # . |
| 2438 | # ALIGN(...) |
| 2439 | # VMLINUX_SYMBOL(...) |
| 2440 | if ($realfile eq 'vmlinux.lds.h' && $line =~ /(?:(?:^|\s)$Ident\s*=|=\s*$Ident(?:\s|$))/) { |
| 2441 | WARN("vmlinux.lds.h needs VMLINUX_SYMBOL() around C-visible symbols\n" . $herecurr); |
| 2442 | } |
| 2443 | |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 2444 | # check for redundant bracing round if etc |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 2445 | if ($line =~ /(^.*)\bif\b/ && $1 !~ /else\s*$/) { |
| 2446 | my ($level, $endln, @chunks) = |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 2447 | ctx_statement_full($linenr, $realcnt, 1); |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 2448 | #print "chunks<$#chunks> linenr<$linenr> endln<$endln> level<$level>\n"; |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 2449 | #print "APW: <<$chunks[1][0]>><<$chunks[1][1]>>\n"; |
| 2450 | if ($#chunks > 0 && $level == 0) { |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 2451 | my $allowed = 0; |
| 2452 | my $seen = 0; |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 2453 | my $herectx = $here . "\n"; |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 2454 | my $ln = $linenr - 1; |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 2455 | for my $chunk (@chunks) { |
| 2456 | my ($cond, $block) = @{$chunk}; |
| 2457 | |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 2458 | # If the condition carries leading newlines, then count those as offsets. |
| 2459 | my ($whitespace) = ($cond =~ /^((?:\s*\n[+-])*\s*)/s); |
| 2460 | my $offset = statement_rawlines($whitespace) - 1; |
| 2461 | |
| 2462 | #print "COND<$cond> whitespace<$whitespace> offset<$offset>\n"; |
| 2463 | |
| 2464 | # We have looked at and allowed this specific line. |
| 2465 | $suppress_ifbraces{$ln + $offset} = 1; |
| 2466 | |
| 2467 | $herectx .= "$rawlines[$ln + $offset]\n[...]\n"; |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 2468 | $ln += statement_rawlines($block) - 1; |
| 2469 | |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 2470 | substr($block, 0, length($cond), ''); |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 2471 | |
| 2472 | $seen++ if ($block =~ /^\s*{/); |
| 2473 | |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 2474 | #print "cond<$cond> block<$block> allowed<$allowed>\n"; |
| 2475 | if (statement_lines($cond) > 1) { |
| 2476 | #print "APW: ALLOWED: cond<$cond>\n"; |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 2477 | $allowed = 1; |
| 2478 | } |
| 2479 | if ($block =~/\b(?:if|for|while)\b/) { |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 2480 | #print "APW: ALLOWED: block<$block>\n"; |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 2481 | $allowed = 1; |
| 2482 | } |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 2483 | if (statement_block_size($block) > 1) { |
| 2484 | #print "APW: ALLOWED: lines block<$block>\n"; |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 2485 | $allowed = 1; |
| 2486 | } |
| 2487 | } |
| 2488 | if ($seen && !$allowed) { |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 2489 | WARN("braces {} are not necessary for any arm of this statement\n" . $herectx); |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 2490 | } |
| 2491 | } |
| 2492 | } |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 2493 | if (!defined $suppress_ifbraces{$linenr - 1} && |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 2494 | $line =~ /\b(if|while|for|else)\b/) { |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 2495 | my $allowed = 0; |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 2496 | |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 2497 | # Check the pre-context. |
| 2498 | if (substr($line, 0, $-[0]) =~ /(\}\s*)$/) { |
| 2499 | #print "APW: ALLOWED: pre<$1>\n"; |
| 2500 | $allowed = 1; |
| 2501 | } |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 2502 | |
| 2503 | my ($level, $endln, @chunks) = |
| 2504 | ctx_statement_full($linenr, $realcnt, $-[0]); |
| 2505 | |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 2506 | # Check the condition. |
| 2507 | my ($cond, $block) = @{$chunks[0]}; |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 2508 | #print "CHECKING<$linenr> cond<$cond> block<$block>\n"; |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 2509 | if (defined $cond) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 2510 | substr($block, 0, length($cond), ''); |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 2511 | } |
| 2512 | if (statement_lines($cond) > 1) { |
| 2513 | #print "APW: ALLOWED: cond<$cond>\n"; |
| 2514 | $allowed = 1; |
| 2515 | } |
| 2516 | if ($block =~/\b(?:if|for|while)\b/) { |
| 2517 | #print "APW: ALLOWED: block<$block>\n"; |
| 2518 | $allowed = 1; |
| 2519 | } |
| 2520 | if (statement_block_size($block) > 1) { |
| 2521 | #print "APW: ALLOWED: lines block<$block>\n"; |
| 2522 | $allowed = 1; |
| 2523 | } |
| 2524 | # Check the post-context. |
| 2525 | if (defined $chunks[1]) { |
| 2526 | my ($cond, $block) = @{$chunks[1]}; |
| 2527 | if (defined $cond) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 2528 | substr($block, 0, length($cond), ''); |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 2529 | } |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 2530 | if ($block =~ /^\s*\{/) { |
| 2531 | #print "APW: ALLOWED: chunk-1 block<$block>\n"; |
| 2532 | $allowed = 1; |
| 2533 | } |
| 2534 | } |
| 2535 | if ($level == 0 && $block =~ /^\s*\{/ && !$allowed) { |
| 2536 | my $herectx = $here . "\n";; |
Andy Whitcroft | f055663 | 2008-10-15 22:02:23 -0700 | [diff] [blame] | 2537 | my $cnt = statement_rawlines($block); |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 2538 | |
Andy Whitcroft | f055663 | 2008-10-15 22:02:23 -0700 | [diff] [blame] | 2539 | for (my $n = 0; $n < $cnt; $n++) { |
| 2540 | $herectx .= raw_line($linenr, $n) . "\n";; |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 2541 | } |
| 2542 | |
| 2543 | WARN("braces {} are not necessary for single statement blocks\n" . $herectx); |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 2544 | } |
| 2545 | } |
| 2546 | |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 2547 | # don't include deprecated include files (uses RAW line) |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 2548 | for my $inc (@dep_includes) { |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 2549 | if ($rawline =~ m@^.\s*\#\s*include\s*\<$inc>@) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 2550 | ERROR("Don't use <$inc>: see Documentation/feature-removal-schedule.txt\n" . $herecurr); |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 2551 | } |
| 2552 | } |
| 2553 | |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 2554 | # don't use deprecated functions |
| 2555 | for my $func (@dep_functions) { |
Andy Whitcroft | 00df344 | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 2556 | if ($line =~ /\b$func\b/) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 2557 | ERROR("Don't use $func(): see Documentation/feature-removal-schedule.txt\n" . $herecurr); |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 2558 | } |
| 2559 | } |
| 2560 | |
| 2561 | # no volatiles please |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 2562 | my $asm_volatile = qr{\b(__asm__|asm)\s+(__volatile__|volatile)\b}; |
| 2563 | if ($line =~ /\bvolatile\b/ && $line !~ /$asm_volatile/) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 2564 | WARN("Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt\n" . $herecurr); |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 2565 | } |
| 2566 | |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 2567 | # SPIN_LOCK_UNLOCKED & RW_LOCK_UNLOCKED are deprecated |
| 2568 | if ($line =~ /\b(SPIN_LOCK_UNLOCKED|RW_LOCK_UNLOCKED)/) { |
| 2569 | ERROR("Use of $1 is deprecated: see Documentation/spinlocks.txt\n" . $herecurr); |
| 2570 | } |
| 2571 | |
Andy Whitcroft | 00df344 | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 2572 | # warn about #if 0 |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 2573 | if ($line =~ /^.\s*\#\s*if\s+0\b/) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 2574 | CHK("if this code is redundant consider removing it\n" . |
| 2575 | $herecurr); |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 2576 | } |
| 2577 | |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 2578 | # check for needless kfree() checks |
| 2579 | if ($prevline =~ /\bif\s*\(([^\)]*)\)/) { |
| 2580 | my $expr = $1; |
| 2581 | if ($line =~ /\bkfree\(\Q$expr\E\);/) { |
Wolfram Sang | 3c23214 | 2008-07-23 21:29:05 -0700 | [diff] [blame] | 2582 | WARN("kfree(NULL) is safe this check is probably not required\n" . $hereprev); |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 2583 | } |
| 2584 | } |
Greg Kroah-Hartman | 4c432a8 | 2008-07-23 21:29:04 -0700 | [diff] [blame] | 2585 | # check for needless usb_free_urb() checks |
| 2586 | if ($prevline =~ /\bif\s*\(([^\)]*)\)/) { |
| 2587 | my $expr = $1; |
| 2588 | if ($line =~ /\busb_free_urb\(\Q$expr\E\);/) { |
| 2589 | WARN("usb_free_urb(NULL) is safe this check is probably not required\n" . $hereprev); |
| 2590 | } |
| 2591 | } |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 2592 | |
Patrick Pannuto | 1a15a25 | 2010-08-09 17:21:01 -0700 | [diff] [blame] | 2593 | # prefer usleep_range over udelay |
| 2594 | if ($line =~ /\budelay\s*\(\s*(\w+)\s*\)/) { |
| 2595 | # ignore udelay's < 10, however |
| 2596 | if (! (($1 =~ /(\d+)/) && ($1 < 10)) ) { |
| 2597 | CHK("usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt\n" . $line); |
| 2598 | } |
| 2599 | } |
| 2600 | |
Patrick Pannuto | 09ef872 | 2010-08-09 17:21:02 -0700 | [diff] [blame] | 2601 | # warn about unexpectedly long msleep's |
| 2602 | if ($line =~ /\bmsleep\s*\((\d+)\);/) { |
| 2603 | if ($1 < 20) { |
| 2604 | WARN("msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt\n" . $line); |
| 2605 | } |
| 2606 | } |
| 2607 | |
Andy Whitcroft | 00df344 | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 2608 | # warn about #ifdefs in C files |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 2609 | # if ($line =~ /^.\s*\#\s*if(|n)def/ && ($realfile =~ /\.c$/)) { |
Andy Whitcroft | 00df344 | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 2610 | # print "#ifdef in C files should be avoided\n"; |
| 2611 | # print "$herecurr"; |
| 2612 | # $clean = 0; |
| 2613 | # } |
| 2614 | |
Andy Whitcroft | 22f2a2e | 2007-08-10 13:01:03 -0700 | [diff] [blame] | 2615 | # warn about spacing in #ifdefs |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 2616 | if ($line =~ /^.\s*\#\s*(ifdef|ifndef|elif)\s\s+/) { |
Andy Whitcroft | 22f2a2e | 2007-08-10 13:01:03 -0700 | [diff] [blame] | 2617 | ERROR("exactly one space required after that #$1\n" . $herecurr); |
| 2618 | } |
| 2619 | |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 2620 | # check for spinlock_t definitions without a comment. |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 2621 | if ($line =~ /^.\s*(struct\s+mutex|spinlock_t)\s+\S+;/ || |
| 2622 | $line =~ /^.\s*(DEFINE_MUTEX)\s*\(/) { |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 2623 | my $which = $1; |
| 2624 | if (!ctx_has_comment($first_line, $linenr)) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 2625 | CHK("$1 definition without comment\n" . $herecurr); |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 2626 | } |
| 2627 | } |
| 2628 | # check for memory barriers without a comment. |
| 2629 | if ($line =~ /\b(mb|rmb|wmb|read_barrier_depends|smp_mb|smp_rmb|smp_wmb|smp_read_barrier_depends)\(/) { |
| 2630 | if (!ctx_has_comment($first_line, $linenr)) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 2631 | CHK("memory barrier without comment\n" . $herecurr); |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 2632 | } |
| 2633 | } |
| 2634 | # check of hardware specific defines |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 2635 | if ($line =~ m@^.\s*\#\s*if.*\b(__i386__|__powerpc64__|__sun__|__s390x__)\b@ && $realfile !~ m@include/asm-@) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 2636 | CHK("architecture specific defines should be avoided\n" . $herecurr); |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 2637 | } |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 2638 | |
Tobias Klauser | d4977c7 | 2010-05-24 14:33:30 -0700 | [diff] [blame] | 2639 | # Check that the storage class is at the beginning of a declaration |
| 2640 | if ($line =~ /\b$Storage\b/ && $line !~ /^.\s*$Storage\b/) { |
| 2641 | WARN("storage class should be at the beginning of the declaration\n" . $herecurr) |
| 2642 | } |
| 2643 | |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 2644 | # check the location of the inline attribute, that it is between |
| 2645 | # storage class and type. |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 2646 | if ($line =~ /\b$Type\s+$Inline\b/ || |
| 2647 | $line =~ /\b$Inline\s+$Storage\b/) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 2648 | ERROR("inline keyword should sit between storage class and type\n" . $herecurr); |
| 2649 | } |
| 2650 | |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 2651 | # Check for __inline__ and __inline, prefer inline |
| 2652 | if ($line =~ /\b(__inline__|__inline)\b/) { |
| 2653 | WARN("plain inline is preferred over $1\n" . $herecurr); |
| 2654 | } |
| 2655 | |
Joe Perches | 8f53a9b | 2010-03-05 13:43:48 -0800 | [diff] [blame] | 2656 | # check for sizeof(&) |
| 2657 | if ($line =~ /\bsizeof\s*\(\s*\&/) { |
| 2658 | WARN("sizeof(& should be avoided\n" . $herecurr); |
| 2659 | } |
| 2660 | |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 2661 | # check for new externs in .c files. |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 2662 | if ($realfile =~ /\.c$/ && defined $stat && |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 2663 | $stat =~ /^.\s*(?:extern\s+)?$Type\s+($Ident)(\s*)\(/s) |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 2664 | { |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 2665 | my $function_name = $1; |
| 2666 | my $paren_space = $2; |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 2667 | |
| 2668 | my $s = $stat; |
| 2669 | if (defined $cond) { |
| 2670 | substr($s, 0, length($cond), ''); |
| 2671 | } |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 2672 | if ($s =~ /^\s*;/ && |
| 2673 | $function_name ne 'uninitialized_var') |
| 2674 | { |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 2675 | WARN("externs should be avoided in .c files\n" . $herecurr); |
| 2676 | } |
| 2677 | |
| 2678 | if ($paren_space =~ /\n/) { |
| 2679 | WARN("arguments for function declarations should follow identifier\n" . $herecurr); |
| 2680 | } |
Andy Whitcroft | 9c9ba34 | 2008-04-29 00:59:33 -0700 | [diff] [blame] | 2681 | |
| 2682 | } elsif ($realfile =~ /\.c$/ && defined $stat && |
| 2683 | $stat =~ /^.\s*extern\s+/) |
| 2684 | { |
| 2685 | WARN("externs should be avoided in .c files\n" . $herecurr); |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 2686 | } |
| 2687 | |
| 2688 | # checks for new __setup's |
| 2689 | if ($rawline =~ /\b__setup\("([^"]*)"/) { |
| 2690 | my $name = $1; |
| 2691 | |
| 2692 | if (!grep(/$name/, @setup_docs)) { |
| 2693 | CHK("__setup appears un-documented -- check Documentation/kernel-parameters.txt\n" . $herecurr); |
| 2694 | } |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 2695 | } |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 2696 | |
| 2697 | # check for pointless casting of kmalloc return |
| 2698 | if ($line =~ /\*\s*\)\s*k[czm]alloc\b/) { |
| 2699 | WARN("unnecessary cast may hide bugs, see http://c-faq.com/malloc/mallocnocast.html\n" . $herecurr); |
| 2700 | } |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 2701 | |
| 2702 | # check for gcc specific __FUNCTION__ |
| 2703 | if ($line =~ /__FUNCTION__/) { |
| 2704 | WARN("__func__ should be used instead of gcc specific __FUNCTION__\n" . $herecurr); |
| 2705 | } |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 2706 | |
| 2707 | # check for semaphores used as mutexes |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 2708 | if ($line =~ /^.\s*(DECLARE_MUTEX|init_MUTEX)\s*\(/) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 2709 | WARN("mutexes are preferred for single holder semaphores\n" . $herecurr); |
| 2710 | } |
| 2711 | # check for semaphores used as mutexes |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 2712 | if ($line =~ /^.\s*init_MUTEX_LOCKED\s*\(/) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 2713 | WARN("consider using a completion\n" . $herecurr); |
Peter Zijlstra | 1704f47 | 2010-03-19 01:37:42 +0100 | [diff] [blame] | 2714 | |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 2715 | } |
| 2716 | # recommend strict_strto* over simple_strto* |
| 2717 | if ($line =~ /\bsimple_(strto.*?)\s*\(/) { |
| 2718 | WARN("consider using strict_$1 in preference to simple_$1\n" . $herecurr); |
| 2719 | } |
Michael Ellerman | f3db663 | 2008-07-23 21:28:57 -0700 | [diff] [blame] | 2720 | # check for __initcall(), use device_initcall() explicitly please |
| 2721 | if ($line =~ /^.\s*__initcall\s*\(/) { |
| 2722 | WARN("please use device_initcall() instead of __initcall()\n" . $herecurr); |
| 2723 | } |
Emese Revfy | 7940484 | 2010-03-05 13:43:53 -0800 | [diff] [blame] | 2724 | # check for various ops structs, ensure they are const. |
| 2725 | my $struct_ops = qr{acpi_dock_ops| |
| 2726 | address_space_operations| |
| 2727 | backlight_ops| |
| 2728 | block_device_operations| |
| 2729 | dentry_operations| |
| 2730 | dev_pm_ops| |
| 2731 | dma_map_ops| |
| 2732 | extent_io_ops| |
| 2733 | file_lock_operations| |
| 2734 | file_operations| |
| 2735 | hv_ops| |
| 2736 | ide_dma_ops| |
| 2737 | intel_dvo_dev_ops| |
| 2738 | item_operations| |
| 2739 | iwl_ops| |
| 2740 | kgdb_arch| |
| 2741 | kgdb_io| |
| 2742 | kset_uevent_ops| |
| 2743 | lock_manager_operations| |
| 2744 | microcode_ops| |
| 2745 | mtrr_ops| |
| 2746 | neigh_ops| |
| 2747 | nlmsvc_binding| |
| 2748 | pci_raw_ops| |
| 2749 | pipe_buf_operations| |
| 2750 | platform_hibernation_ops| |
| 2751 | platform_suspend_ops| |
| 2752 | proto_ops| |
| 2753 | rpc_pipe_ops| |
| 2754 | seq_operations| |
| 2755 | snd_ac97_build_ops| |
| 2756 | soc_pcmcia_socket_ops| |
| 2757 | stacktrace_ops| |
| 2758 | sysfs_ops| |
| 2759 | tty_operations| |
| 2760 | usb_mon_operations| |
| 2761 | wd_ops}x; |
Andy Whitcroft | 6903ffb | 2009-01-15 13:51:07 -0800 | [diff] [blame] | 2762 | if ($line !~ /\bconst\b/ && |
Emese Revfy | 7940484 | 2010-03-05 13:43:53 -0800 | [diff] [blame] | 2763 | $line =~ /\bstruct\s+($struct_ops)\b/) { |
Andy Whitcroft | 6903ffb | 2009-01-15 13:51:07 -0800 | [diff] [blame] | 2764 | WARN("struct $1 should normally be const\n" . |
| 2765 | $herecurr); |
Andy Whitcroft | 2b6db5c | 2009-01-06 14:41:29 -0800 | [diff] [blame] | 2766 | } |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 2767 | |
| 2768 | # use of NR_CPUS is usually wrong |
| 2769 | # ignore definitions of NR_CPUS and usage to define arrays as likely right |
| 2770 | if ($line =~ /\bNR_CPUS\b/ && |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 2771 | $line !~ /^.\s*\s*#\s*if\b.*\bNR_CPUS\b/ && |
| 2772 | $line !~ /^.\s*\s*#\s*define\b.*\bNR_CPUS\b/ && |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 2773 | $line !~ /^.\s*$Declare\s.*\[[^\]]*NR_CPUS[^\]]*\]/ && |
| 2774 | $line !~ /\[[^\]]*\.\.\.[^\]]*NR_CPUS[^\]]*\]/ && |
| 2775 | $line !~ /\[[^\]]*NR_CPUS[^\]]*\.\.\.[^\]]*\]/) |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 2776 | { |
| 2777 | WARN("usage of NR_CPUS is often wrong - consider using cpu_possible(), num_possible_cpus(), for_each_possible_cpu(), etc\n" . $herecurr); |
| 2778 | } |
Andy Whitcroft | 9c9ba34 | 2008-04-29 00:59:33 -0700 | [diff] [blame] | 2779 | |
| 2780 | # check for %L{u,d,i} in strings |
| 2781 | my $string; |
| 2782 | while ($line =~ /(?:^|")([X\t]*)(?:"|$)/g) { |
| 2783 | $string = substr($rawline, $-[1], $+[1] - $-[1]); |
Andy Whitcroft | 2a1bc5d | 2008-10-15 22:02:23 -0700 | [diff] [blame] | 2784 | $string =~ s/%%/__/g; |
Andy Whitcroft | 9c9ba34 | 2008-04-29 00:59:33 -0700 | [diff] [blame] | 2785 | if ($string =~ /(?<!%)%L[udi]/) { |
| 2786 | WARN("\%Ld/%Lu are not-standard C, use %lld/%llu\n" . $herecurr); |
| 2787 | last; |
| 2788 | } |
| 2789 | } |
Andy Whitcroft | 691d77b | 2009-01-06 14:41:16 -0800 | [diff] [blame] | 2790 | |
| 2791 | # whine mightly about in_atomic |
| 2792 | if ($line =~ /\bin_atomic\s*\(/) { |
| 2793 | if ($realfile =~ m@^drivers/@) { |
| 2794 | ERROR("do not use in_atomic in drivers\n" . $herecurr); |
Andy Whitcroft | f4a8773 | 2009-02-27 14:03:05 -0800 | [diff] [blame] | 2795 | } elsif ($realfile !~ m@^kernel/@) { |
Andy Whitcroft | 691d77b | 2009-01-06 14:41:16 -0800 | [diff] [blame] | 2796 | WARN("use of in_atomic() is incorrect outside core kernel code\n" . $herecurr); |
| 2797 | } |
| 2798 | } |
Peter Zijlstra | 1704f47 | 2010-03-19 01:37:42 +0100 | [diff] [blame] | 2799 | |
| 2800 | # check for lockdep_set_novalidate_class |
| 2801 | if ($line =~ /^.\s*lockdep_set_novalidate_class\s*\(/ || |
| 2802 | $line =~ /__lockdep_no_validate__\s*\)/ ) { |
| 2803 | if ($realfile !~ m@^kernel/lockdep@ && |
| 2804 | $realfile !~ m@^include/linux/lockdep@ && |
| 2805 | $realfile !~ m@^drivers/base/core@) { |
| 2806 | ERROR("lockdep_no_validate class is reserved for device->mutex.\n" . $herecurr); |
| 2807 | } |
| 2808 | } |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 2809 | } |
| 2810 | |
| 2811 | # If we have no input at all, then there is nothing to report on |
| 2812 | # so just keep quiet. |
| 2813 | if ($#rawlines == -1) { |
| 2814 | exit(0); |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 2815 | } |
| 2816 | |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 2817 | # In mailback mode only produce a report in the negative, for |
| 2818 | # things that appear to be patches. |
| 2819 | if ($mailback && ($clean == 1 || !$is_patch)) { |
| 2820 | exit(0); |
| 2821 | } |
| 2822 | |
| 2823 | # This is not a patch, and we are are in 'no-patch' mode so |
| 2824 | # just keep quiet. |
| 2825 | if (!$chk_patch && !$is_patch) { |
| 2826 | exit(0); |
| 2827 | } |
| 2828 | |
| 2829 | if (!$is_patch) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 2830 | ERROR("Does not appear to be a unified-diff format patch\n"); |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 2831 | } |
| 2832 | if ($is_patch && $chk_signoff && $signoff == 0) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 2833 | ERROR("Missing Signed-off-by: line(s)\n"); |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 2834 | } |
| 2835 | |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 2836 | print report_dump(); |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 2837 | if ($summary && !($clean == 1 && $quiet == 1)) { |
| 2838 | print "$filename " if ($summary_file); |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 2839 | print "total: $cnt_error errors, $cnt_warn warnings, " . |
| 2840 | (($check)? "$cnt_chk checks, " : "") . |
| 2841 | "$cnt_lines lines checked\n"; |
| 2842 | print "\n" if ($quiet == 0); |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 2843 | } |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 2844 | |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 2845 | if ($clean == 1 && $quiet == 0) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 2846 | print "$vname has no obvious style problems and is ready for submission.\n" |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 2847 | } |
| 2848 | if ($clean == 0 && $quiet == 0) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 2849 | print "$vname has style problems, please review. If any of these errors\n"; |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 2850 | print "are false positives report them to the maintainer, see\n"; |
| 2851 | print "CHECKPATCH in MAINTAINERS.\n"; |
| 2852 | } |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 2853 | |
Andy Whitcroft | 0a920b5 | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 2854 | return $clean; |
| 2855 | } |