commit 0571d357843c53e042f370f5f2c2e9aa3fe803a9
author Ian Rogers <irogers@google.com> Thu Nov 03 19:51:38 2011 -0700
committer Ian Rogers <irogers@google.com> Sun Nov 13 11:57:18 2011 -0800
tree 197e5b1c0b1bf0ee8cc0e1960470d0a8d203b4af
parent 33dc7717cd16592bcc825350bea6305be9eb2ea1

Refactor the use of Method by the compiler.

Remove the dependence on the Method object in dex2oat, allowing lazier
resolution.
Introduce new find and iterators in DexFile to simplify common
operations and avoid misuse of class data items.

Change-Id: I39fb8252190f543d89d8b233076355cec310fe08

src/runtime_support.cc

diff --git a/src/runtime_support.cc b/src/runtime_support.cc
index 7ae5da5..e6011da 100644
--- a/src/runtime_support.cc
+++ b/src/runtime_support.cc
@@ -49,7 +49,7 @@
   /*
    * NOTE: once debugger/profiler support is added, we'll need to check
    * here and branch to actual compiled object.<init> to handle any
-   * breakpoint/logging activites if either is active.
+   * breakpoint/logging activities if either is active.
    */
   return self->IsExceptionPending() ? -1 : 0;
 }
@@ -163,7 +163,7 @@
     CHECK(false) << static_cast<int>(ref_type);
   }
 
-  std::string class_name(PrettyDescriptor(dex_file.dexStringByTypeIdx(type_idx)));
+  std::string class_name(PrettyDescriptor(dex_file.StringByTypeIdx(type_idx)));
   if (!access) {
     return class_name;
   }
@@ -185,7 +185,7 @@
 
   const DexFile::FieldId& id = dex_file.GetFieldId(ref);
   std::string class_name(PrettyDescriptor(dex_file.GetFieldDeclaringClassDescriptor(id)));
-  const char* field_name = dex_file.dexStringById(id.name_idx_);
+  const char* field_name = dex_file.StringDataByIdx(id.name_idx_);
   if (!access) {
     return class_name + "." + field_name;
   }
@@ -207,7 +207,7 @@
 
   const DexFile::MethodId& id = dex_file.GetMethodId(ref);
   std::string class_name(PrettyDescriptor(dex_file.GetMethodDeclaringClassDescriptor(id)));
-  const char* method_name = dex_file.dexStringById(id.name_idx_);
+  const char* method_name = dex_file.StringDataByIdx(id.name_idx_);
   if (!access) {
     return class_name + "." + method_name;
   }
@@ -215,7 +215,7 @@
   std::string result;
   result += "tried to access method ";
   result += class_name + "." + method_name + ":" +
-            dex_file.CreateMethodDescriptor(id.proto_idx_, NULL);
+      dex_file.CreateMethodSignature(id.proto_idx_, NULL);
   result += " from class ";
   result += PrettyDescriptor(method->GetDeclaringClass()->GetDescriptor());
   return result;