Merge "Special case dex files that have hidden API data."
diff --git a/libdexfile/dex/dex_file.h b/libdexfile/dex/dex_file.h
index c7fbe78..8ea3c09 100644
--- a/libdexfile/dex/dex_file.h
+++ b/libdexfile/dex/dex_file.h
@@ -618,6 +618,10 @@
return hiddenapi_class_data_;
}
+ ALWAYS_INLINE bool HasHiddenapiClassData() const {
+ return hiddenapi_class_data_ != nullptr;
+ }
+
const dex::AnnotationItem* GetAnnotationItem(const dex::AnnotationSetItem* set_item,
uint32_t index) const {
DCHECK_LE(index, set_item->size_);
diff --git a/libdexfile/dex/standard_dex_file.h b/libdexfile/dex/standard_dex_file.h
index 838d4e3..48671c9 100644
--- a/libdexfile/dex/standard_dex_file.h
+++ b/libdexfile/dex/standard_dex_file.h
@@ -84,7 +84,10 @@
uint32_t GetCodeItemSize(const dex::CodeItem& item) const override;
size_t GetDequickenedSize() const override {
- return Size();
+ // JVMTI will run dex layout on standard dex files that have hidden API data,
+ // in order to remove that data. As dexlayout may increase the size of the dex file,
+ // be (very) conservative and add one MB to the size.
+ return Size() + (HasHiddenapiClassData() ? 1 * MB : 0);
}
private:
diff --git a/openjdkjvmti/fixed_up_dex_file.cc b/openjdkjvmti/fixed_up_dex_file.cc
index 079cd98..da7eef9 100644
--- a/openjdkjvmti/fixed_up_dex_file.cc
+++ b/openjdkjvmti/fixed_up_dex_file.cc
@@ -87,8 +87,7 @@
}
}
-std::unique_ptr<FixedUpDexFile> FixedUpDexFile::Create(jobject class_loader,
- const art::DexFile& original,
+std::unique_ptr<FixedUpDexFile> FixedUpDexFile::Create(const art::DexFile& original,
const char* descriptor) {
// Copy the data into mutable memory.
std::vector<unsigned char> data;
@@ -101,11 +100,11 @@
// property from `original` to `new_dex_file`.
const art::DexFileLoader dex_file_loader;
- if (original.IsCompactDexFile() || class_loader == nullptr) {
+ if (original.IsCompactDexFile() || original.HasHiddenapiClassData()) {
// Since we are supposed to return a standard dex, convert back using dexlayout. It's OK to do
// this before unquickening.
- // We also do dex layout for boot classpath dex files, as they contain hidden API flags which
- // we want to remove.
+ // We also do dex layout for dex files that have hidden API data, as we want to remove that
+ // data.
art::Options options;
options.compact_dex_level_ = art::CompactDexLevel::kCompactDexLevelNone;
// Add a filter to only include the class that has the matching descriptor.
diff --git a/openjdkjvmti/fixed_up_dex_file.h b/openjdkjvmti/fixed_up_dex_file.h
index e09d70b..594e8a7 100644
--- a/openjdkjvmti/fixed_up_dex_file.h
+++ b/openjdkjvmti/fixed_up_dex_file.h
@@ -49,8 +49,7 @@
// are running on.
class FixedUpDexFile {
public:
- static std::unique_ptr<FixedUpDexFile> Create(jobject class_loader,
- const art::DexFile& original,
+ static std::unique_ptr<FixedUpDexFile> Create(const art::DexFile& original,
const char* descriptor);
const art::DexFile& GetDexFile() {
diff --git a/openjdkjvmti/ti_class_definition.cc b/openjdkjvmti/ti_class_definition.cc
index 2345a0a..20feb78 100644
--- a/openjdkjvmti/ti_class_definition.cc
+++ b/openjdkjvmti/ti_class_definition.cc
@@ -57,7 +57,7 @@
std::string desc = std::string("L") + name_ + ";";
std::unique_ptr<FixedUpDexFile>
- fixed_dex_file(FixedUpDexFile::Create(loader_, *initial_dex_file_unquickened_, desc.c_str()));
+ fixed_dex_file(FixedUpDexFile::Create(*initial_dex_file_unquickened_, desc.c_str()));
CHECK(fixed_dex_file.get() != nullptr);
CHECK_LE(fixed_dex_file->Size(), temp_mmap_.Size());
CHECK_EQ(temp_mmap_.Size(), dex_data_mmap_.Size());
@@ -132,20 +132,18 @@
return OK;
}
-static void DequickenDexFile(jobject class_loader,
- const art::DexFile* dex_file,
+static void DequickenDexFile(const art::DexFile* dex_file,
const char* descriptor,
/*out*/std::vector<unsigned char>* dex_data)
REQUIRES_SHARED(art::Locks::mutator_lock_) {
std::unique_ptr<FixedUpDexFile> fixed_dex_file(
- FixedUpDexFile::Create(class_loader, *dex_file, descriptor));
+ FixedUpDexFile::Create(*dex_file, descriptor));
dex_data->resize(fixed_dex_file->Size());
memcpy(dex_data->data(), fixed_dex_file->Begin(), fixed_dex_file->Size());
}
// Gets the data surrounding the given class.
-static void GetDexDataForRetransformation(art::ScopedObjectAccess& soa,
- art::Handle<art::mirror::Class> klass,
+static void GetDexDataForRetransformation(art::Handle<art::mirror::Class> klass,
/*out*/std::vector<unsigned char>* dex_data)
REQUIRES_SHARED(art::Locks::mutator_lock_) {
art::StackHandleScope<3> hs(art::Thread::Current());
@@ -182,8 +180,7 @@
dex_file = &klass->GetDexFile();
}
std::string storage;
- jobject loader = soa.AddLocalReference<jobject>(klass->GetClassLoader());
- DequickenDexFile(loader, dex_file, klass->GetDescriptor(&storage), dex_data);
+ DequickenDexFile(dex_file, klass->GetDescriptor(&storage), dex_data);
}
static bool DexNeedsDequickening(art::Handle<art::mirror::Class> klass,
@@ -336,7 +333,7 @@
const art::DexFile* quick_dex = GetQuickenedDexFile(m_klass);
auto get_original = [&](/*out*/std::vector<unsigned char>* dex_data)
REQUIRES_SHARED(art::Locks::mutator_lock_) {
- GetDexDataForRetransformation(soa, m_klass, dex_data);
+ GetDexDataForRetransformation(m_klass, dex_data);
};
InitWithDex(get_original, quick_dex);
return OK;
@@ -369,7 +366,7 @@
protection_domain_ = nullptr;
auto get_original = [&](/*out*/std::vector<unsigned char>* dex_data)
REQUIRES_SHARED(art::Locks::mutator_lock_) {
- DequickenDexFile(loader_, &dex_file, descriptor, dex_data);
+ DequickenDexFile(&dex_file, descriptor, dex_data);
};
InitWithDex(get_original, &dex_file);
}