Disallow JNI NewObjectArray of primitive types.
Also, make jni_internal_test execute via the interpreter rather than compile
methods. Add tests for passing negative array sizes to JNI routines new
functions. Re-enable the tests NewStringNullCharsNonzeroLength and
NewDirectBuffer_GetDirectBufferAddress_GetDirectBufferCapacity. Test and
explicitly fail if the initial value argument to NewObjectArray isn't
assignable to that type of array.
Use unchecked ObjectArray::Set with NewObjectArray with an initial value.
Change-Id: If3491cb5f974b42cf70c1b850819265f9963ee48
diff --git a/runtime/jni_internal_test.cc b/runtime/jni_internal_test.cc
index 2240447..9b278f8 100644
--- a/runtime/jni_internal_test.cc
+++ b/runtime/jni_internal_test.cc
@@ -78,10 +78,17 @@
CommonTest::TearDown();
}
- void DoCompile(mirror::ArtMethod*& method,
- mirror::Object*& receiver,
- bool is_static, const char* method_name,
- const char* method_signature)
+ jclass GetPrimitiveClass(char descriptor) {
+ ScopedObjectAccess soa(env_);
+ mirror::Class* c = class_linker_->FindPrimitiveClass(descriptor);
+ CHECK(c != nullptr);
+ return soa.AddLocalReference<jclass>(c);
+ }
+
+ void JniInternalTestMakeExecutable(mirror::ArtMethod** method,
+ mirror::Object** receiver,
+ bool is_static, const char* method_name,
+ const char* method_signature)
SHARED_LOCKS_REQUIRED(Locks::mutator_lock_) {
const char* class_name = is_static ? "StaticLeafMethods" : "NonStaticLeafMethods";
jobject jclass_loader(LoadDex(class_name));
@@ -91,21 +98,23 @@
class_loader(self,
ScopedObjectAccessUnchecked(self).Decode<mirror::ClassLoader*>(jclass_loader));
if (is_static) {
- CompileDirectMethod(class_loader, class_name, method_name, method_signature);
+ MakeExecutable(ScopedObjectAccessUnchecked(self).Decode<mirror::ClassLoader*>(jclass_loader),
+ class_name);
} else {
- CompileVirtualMethod(null_class_loader, "java.lang.Class", "isFinalizable", "()Z");
- CompileDirectMethod(null_class_loader, "java.lang.Object", "<init>", "()V");
- CompileVirtualMethod(class_loader, class_name, method_name, method_signature);
+ MakeExecutable(nullptr, "java.lang.Class");
+ MakeExecutable(nullptr, "java.lang.Object");
+ MakeExecutable(ScopedObjectAccessUnchecked(self).Decode<mirror::ClassLoader*>(jclass_loader),
+ class_name);
}
mirror::Class* c = class_linker_->FindClass(DotToDescriptor(class_name).c_str(), class_loader);
CHECK(c != NULL);
- method = is_static ? c->FindDirectMethod(method_name, method_signature)
- : c->FindVirtualMethod(method_name, method_signature);
- CHECK(method != NULL);
+ *method = is_static ? c->FindDirectMethod(method_name, method_signature)
+ : c->FindVirtualMethod(method_name, method_signature);
+ CHECK(method != nullptr);
- receiver = (is_static ? NULL : c->AllocObject(self));
+ *receiver = (is_static ? nullptr : c->AllocObject(self));
// Start runtime.
bool started = runtime_->Start();
@@ -116,7 +125,7 @@
void InvokeNopMethod(bool is_static) SHARED_LOCKS_REQUIRED(Locks::mutator_lock_) {
mirror::ArtMethod* method;
mirror::Object* receiver;
- DoCompile(method, receiver, is_static, "nop", "()V");
+ JniInternalTestMakeExecutable(&method, &receiver, is_static, "nop", "()V");
ArgArray arg_array(NULL, 0);
JValue result;
@@ -132,7 +141,7 @@
SHARED_LOCKS_REQUIRED(Locks::mutator_lock_) {
mirror::ArtMethod* method;
mirror::Object* receiver;
- DoCompile(method, receiver, is_static, "identity", "(I)I");
+ JniInternalTestMakeExecutable(&method, &receiver, is_static, "identity", "(I)I");
ArgArray arg_array(NULL, 0);
uint32_t* args = arg_array.GetArray();
@@ -168,7 +177,7 @@
SHARED_LOCKS_REQUIRED(Locks::mutator_lock_) {
mirror::ArtMethod* method;
mirror::Object* receiver;
- DoCompile(method, receiver, is_static, "identity", "(I)I");
+ JniInternalTestMakeExecutable(&method, &receiver, is_static, "identity", "(I)I");
ArgArray arg_array(NULL, 0);
uint32_t* args = arg_array.GetArray();
@@ -204,7 +213,7 @@
SHARED_LOCKS_REQUIRED(Locks::mutator_lock_) {
mirror::ArtMethod* method;
mirror::Object* receiver;
- DoCompile(method, receiver, is_static, "identity", "(D)D");
+ JniInternalTestMakeExecutable(&method, &receiver, is_static, "identity", "(D)D");
ArgArray arg_array(NULL, 0);
uint32_t* args = arg_array.GetArray();
@@ -248,7 +257,7 @@
SHARED_LOCKS_REQUIRED(Locks::mutator_lock_) {
mirror::ArtMethod* method;
mirror::Object* receiver;
- DoCompile(method, receiver, is_static, "sum", "(II)I");
+ JniInternalTestMakeExecutable(&method, &receiver, is_static, "sum", "(II)I");
ArgArray arg_array(NULL, 0);
uint32_t* args = arg_array.GetArray();
@@ -294,7 +303,7 @@
SHARED_LOCKS_REQUIRED(Locks::mutator_lock_) {
mirror::ArtMethod* method;
mirror::Object* receiver;
- DoCompile(method, receiver, is_static, "sum", "(III)I");
+ JniInternalTestMakeExecutable(&method, &receiver, is_static, "sum", "(III)I");
ArgArray arg_array(NULL, 0);
uint32_t* args = arg_array.GetArray();
@@ -345,7 +354,7 @@
SHARED_LOCKS_REQUIRED(Locks::mutator_lock_) {
mirror::ArtMethod* method;
mirror::Object* receiver;
- DoCompile(method, receiver, is_static, "sum", "(IIII)I");
+ JniInternalTestMakeExecutable(&method, &receiver, is_static, "sum", "(IIII)I");
ArgArray arg_array(NULL, 0);
uint32_t* args = arg_array.GetArray();
@@ -401,7 +410,7 @@
SHARED_LOCKS_REQUIRED(Locks::mutator_lock_) {
mirror::ArtMethod* method;
mirror::Object* receiver;
- DoCompile(method, receiver, is_static, "sum", "(IIIII)I");
+ JniInternalTestMakeExecutable(&method, &receiver, is_static, "sum", "(IIIII)I");
ArgArray arg_array(NULL, 0);
uint32_t* args = arg_array.GetArray();
@@ -462,7 +471,7 @@
SHARED_LOCKS_REQUIRED(Locks::mutator_lock_) {
mirror::ArtMethod* method;
mirror::Object* receiver;
- DoCompile(method, receiver, is_static, "sum", "(DD)D");
+ JniInternalTestMakeExecutable(&method, &receiver, is_static, "sum", "(DD)D");
ArgArray arg_array(NULL, 0);
uint32_t* args = arg_array.GetArray();
@@ -528,7 +537,7 @@
SHARED_LOCKS_REQUIRED(Locks::mutator_lock_) {
mirror::ArtMethod* method;
mirror::Object* receiver;
- DoCompile(method, receiver, is_static, "sum", "(DDD)D");
+ JniInternalTestMakeExecutable(&method, &receiver, is_static, "sum", "(DDD)D");
ArgArray arg_array(NULL, 0);
uint32_t* args = arg_array.GetArray();
@@ -583,7 +592,7 @@
SHARED_LOCKS_REQUIRED(Locks::mutator_lock_) {
mirror::ArtMethod* method;
mirror::Object* receiver;
- DoCompile(method, receiver, is_static, "sum", "(DDDD)D");
+ JniInternalTestMakeExecutable(&method, &receiver, is_static, "sum", "(DDDD)D");
ArgArray arg_array(NULL, 0);
uint32_t* args = arg_array.GetArray();
@@ -647,7 +656,7 @@
SHARED_LOCKS_REQUIRED(Locks::mutator_lock_) {
mirror::ArtMethod* method;
mirror::Object* receiver;
- DoCompile(method, receiver, is_static, "sum", "(DDDDD)D");
+ JniInternalTestMakeExecutable(&method, &receiver, is_static, "sum", "(DDDDD)D");
ArgArray arg_array(NULL, 0);
uint32_t* args = arg_array.GetArray();
@@ -1011,6 +1020,14 @@
release_elements_fn, \
scalar_type, \
expected_class_descriptor) \
+ { \
+ CheckJniAbortCatcher jni_abort_catcher; \
+ /* Allocate an negative sized array and check it has the right failure type. */ \
+ env_->new_fn(-1); \
+ jni_abort_catcher.Check("negative array length: -1"); \
+ env_->new_fn(std::numeric_limits<jint>::min()); \
+ jni_abort_catcher.Check("negative array length: -2147483648"); \
+ } \
jsize size = 4; \
\
/* Allocate an array and check it has the right type and length. */ \
@@ -1116,35 +1133,72 @@
}
TEST_F(JniInternalTest, NewObjectArray) {
- // TODO: death tests for negative array sizes.
-
- // TODO: check non-NULL initial elements.
-
jclass element_class = env_->FindClass("java/lang/String");
- ASSERT_TRUE(element_class != NULL);
+ ASSERT_TRUE(element_class != nullptr);
jclass array_class = env_->FindClass("[Ljava/lang/String;");
- ASSERT_TRUE(array_class != NULL);
+ ASSERT_TRUE(array_class != nullptr);
- jobjectArray a;
-
- a = env_->NewObjectArray(0, element_class, NULL);
- EXPECT_TRUE(a != NULL);
+ jobjectArray a = env_->NewObjectArray(0, element_class, nullptr);
+ EXPECT_TRUE(a != nullptr);
EXPECT_TRUE(env_->IsInstanceOf(a, array_class));
EXPECT_EQ(0, env_->GetArrayLength(a));
- a = env_->NewObjectArray(1, element_class, NULL);
- EXPECT_TRUE(a != NULL);
+ a = env_->NewObjectArray(1, element_class, nullptr);
+ EXPECT_TRUE(a != nullptr);
EXPECT_TRUE(env_->IsInstanceOf(a, array_class));
EXPECT_EQ(1, env_->GetArrayLength(a));
- EXPECT_TRUE(env_->IsSameObject(env_->GetObjectArrayElement(a, 0), NULL));
+ EXPECT_TRUE(env_->IsSameObject(env_->GetObjectArrayElement(a, 0), nullptr));
+}
+
+TEST_F(JniInternalTest, NewObjectArrayWithNegativeLength) {
+ jclass element_class = env_->FindClass("java/lang/String");
+ ASSERT_TRUE(element_class != nullptr);
+ jclass array_class = env_->FindClass("[Ljava/lang/String;");
+ ASSERT_TRUE(array_class != nullptr);
+ CheckJniAbortCatcher jni_abort_catcher;
+
+ env_->NewObjectArray(-1, element_class, nullptr);
+ jni_abort_catcher.Check("negative array length: -1");
+
+ env_->NewObjectArray(std::numeric_limits<jint>::min(), element_class, nullptr);
+ jni_abort_catcher.Check("negative array length: -2147483648");
+}
+
+TEST_F(JniInternalTest, NewObjectArrayWithPrimitiveClasses) {
+ const char* primitive_descriptors = "VZBSCIJFD";
+ const char* primitive_names[] = {
+ "void", "boolean", "byte", "short", "char", "int", "long", "float", "double"
+ };
+ ASSERT_EQ(strlen(primitive_descriptors), arraysize(primitive_names));
+
+ CheckJniAbortCatcher jni_abort_catcher;
+ for (size_t i = 0; i < strlen(primitive_descriptors); ++i) {
+ jclass primitive_class = GetPrimitiveClass(primitive_descriptors[i]);
+ env_->NewObjectArray(1, primitive_class, nullptr);
+ std::string error_msg(StringPrintf("not an object type: %s", primitive_names[i]));
+ jni_abort_catcher.Check(error_msg.c_str());
+ }
+}
+
+TEST_F(JniInternalTest, NewObjectArrayWithInitialValue) {
+ jclass element_class = env_->FindClass("java/lang/String");
+ ASSERT_TRUE(element_class != nullptr);
+ jclass array_class = env_->FindClass("[Ljava/lang/String;");
+ ASSERT_TRUE(array_class != nullptr);
jstring s = env_->NewStringUTF("poop");
- a = env_->NewObjectArray(2, element_class, s);
- EXPECT_TRUE(a != NULL);
+ jobjectArray a = env_->NewObjectArray(2, element_class, s);
+ EXPECT_TRUE(a != nullptr);
EXPECT_TRUE(env_->IsInstanceOf(a, array_class));
EXPECT_EQ(2, env_->GetArrayLength(a));
EXPECT_TRUE(env_->IsSameObject(env_->GetObjectArrayElement(a, 0), s));
EXPECT_TRUE(env_->IsSameObject(env_->GetObjectArrayElement(a, 1), s));
+
+ // Attempt to incorrect create an array of strings with initial value of string arrays.
+ CheckJniAbortCatcher jni_abort_catcher;
+ env_->NewObjectArray(2, element_class, a);
+ jni_abort_catcher.Check("cannot assign object of type 'java.lang.String[]' to array with element "
+ "type of 'java.lang.String'");
}
TEST_F(JniInternalTest, GetArrayLength) {
@@ -1251,14 +1305,23 @@
}
TEST_F(JniInternalTest, NewStringNullCharsZeroLength) {
- jstring s = env_->NewString(NULL, 0);
- EXPECT_TRUE(s != NULL);
+ jstring s = env_->NewString(nullptr, 0);
+ EXPECT_TRUE(s != nullptr);
EXPECT_EQ(0, env_->GetStringLength(s));
}
-// TODO: fix gtest death tests on host http://b/5690440 (and target)
-TEST_F(JniInternalTest, DISABLED_NewStringNullCharsNonzeroLength) {
- ASSERT_DEATH(env_->NewString(NULL, 1), "");
+TEST_F(JniInternalTest, NewStringNullCharsNonzeroLength) {
+ CheckJniAbortCatcher jni_abort_catcher;
+ env_->NewString(nullptr, 1);
+ jni_abort_catcher.Check("chars == null && char_count > 0");
+}
+
+TEST_F(JniInternalTest, NewStringNegativeLength) {
+ CheckJniAbortCatcher jni_abort_catcher;
+ env_->NewString(nullptr, -1);
+ jni_abort_catcher.Check("char_count < 0: -1");
+ env_->NewString(nullptr, std::numeric_limits<jint>::min());
+ jni_abort_catcher.Check("char_count < 0: -2147483648");
}
TEST_F(JniInternalTest, GetStringLength_GetStringUTFLength) {
@@ -1884,8 +1947,24 @@
EXPECT_TRUE(env_->IsInstanceOf(thrown_exception, exception_class));
}
-// TODO: this test is DISABLED until we can actually run java.nio.Buffer's <init>.
-TEST_F(JniInternalTest, DISABLED_NewDirectBuffer_GetDirectBufferAddress_GetDirectBufferCapacity) {
+TEST_F(JniInternalTest, NewDirectBuffer_GetDirectBufferAddress_GetDirectBufferCapacity) {
+ // Start runtime.
+ Thread* self = Thread::Current();
+ self->TransitionFromSuspendedToRunnable();
+ MakeExecutable(nullptr, "java.lang.Class");
+ MakeExecutable(nullptr, "java.lang.Object");
+ MakeExecutable(nullptr, "java.nio.DirectByteBuffer");
+ MakeExecutable(nullptr, "java.nio.MemoryBlock");
+ MakeExecutable(nullptr, "java.nio.MemoryBlock$UnmanagedBlock");
+ MakeExecutable(nullptr, "java.nio.MappedByteBuffer");
+ MakeExecutable(nullptr, "java.nio.ByteBuffer");
+ MakeExecutable(nullptr, "java.nio.Buffer");
+ // TODO: we only load a dex file here as starting the runtime relies upon it.
+ const char* class_name = "StaticLeafMethods";
+ LoadDex(class_name);
+ bool started = runtime_->Start();
+ ASSERT_TRUE(started);
+
jclass buffer_class = env_->FindClass("java/nio/Buffer");
ASSERT_TRUE(buffer_class != NULL);