commit 530fa005e2944d3b12712f80d974f0e753f568ef
author Elliott Hughes <enh@google.com> Mon Mar 12 11:44:49 2012 -0700
committer Elliott Hughes <enh@google.com> Mon Mar 12 11:44:49 2012 -0700
tree 0a98404cd017ee5dc1c717039d5caad02fd38f18
parent 4d26534f6a65d7af89cc32da8fbc32beed693201

Give WalkStack's callback a way to terminate early.

Also combine WalkStack and WalkStackUntilUpcall.

Change-Id: Ida25665de72e5fd8e17946886a387b27cf841457

test/ReferenceMap/stack_walk_refmap_jni.cc

diff --git a/test/ReferenceMap/stack_walk_refmap_jni.cc b/test/ReferenceMap/stack_walk_refmap_jni.cc
index b3f82db..f6d4ac3 100644
--- a/test/ReferenceMap/stack_walk_refmap_jni.cc
+++ b/test/ReferenceMap/stack_walk_refmap_jni.cc
@@ -43,10 +43,10 @@
   ReferenceMap2Visitor() {
   }
 
-  void VisitFrame(const Frame& frame, uintptr_t pc) {
+  bool VisitFrame(const Frame& frame, uintptr_t pc) {
     Method* m = frame.GetMethod();
     if (!m || m->IsNative()) {
-      return;
+      return true;
     }
     LOG(INFO) << "At " << PrettyMethod(m, false);
 
@@ -54,11 +54,11 @@
 
     if (!pc) {
       // pc == NULL: m is either a native method or a phony method
-      return;
+      return true;
     }
     if (m->IsCalleeSaveMethod()) {
       LOG(WARNING) << "no PC for " << PrettyMethod(m);
-      return;
+      return true;
     }
 
     // Enable this to dump reference map to LOG(INFO)
@@ -156,6 +156,8 @@
       CHECK(ref_bitmap);
       CHECK_REGS_CONTAIN_REFS(8, 3, 2, 1, 0);  // v8: this, v3: y, v2: y, v1: x, v0: ex
     }
+
+    return true;
   }
 };