commit 5a4acce7dfe168b06d041f1faaa0bb279808700d
author jeffhao <jeffhao@google.com> Wed Feb 01 11:48:12 2012 -0800
committer Android (Google) Code Review <android-gerrit@google.com> Wed Feb 01 11:48:12 2012 -0800
tree 372f7cdcf6c2df77e2fc9cdea085ab8d3cfeeb35
parent 1c5eb704b61511cdc649cad032d29940857c9fe9
parent 54c1ceb8f67ee60b22771a76e947c504934ab937

Merge "Fix to return null if dex file fails verification." into dalvik-dev

src/dex_file.cc

diff --git a/src/dex_file.cc b/src/dex_file.cc
index 974f6e5..cb90e15 100644
--- a/src/dex_file.cc
+++ b/src/dex_file.cc
@@ -135,9 +135,16 @@
   }
   close(fd);
   const DexFile* dex_file = OpenMemory(location, map.release());
-  if (dex_file != NULL) {
-    DexFileVerifier::Verify(dex_file, dex_file->Begin(), dex_file->Size());
+  if (dex_file == NULL) {
+    LOG(ERROR) << "Failed to open dex file '" << location << "' from memory";
+    return NULL;
   }
+
+  if (!DexFileVerifier::Verify(dex_file, dex_file->Begin(), dex_file->Size())) {
+    LOG(ERROR) << "Failed to verify dex file '" << location << "'";
+    return NULL;
+  }
+
   return dex_file;
 }
 
@@ -183,9 +190,16 @@
   }
 
   const DexFile* dex_file = OpenMemory(location, map.release());
-  if (dex_file != NULL) {
-    DexFileVerifier::Verify(dex_file, dex_file->Begin(), dex_file->Size());
+  if (dex_file == NULL) {
+    LOG(ERROR) << "Failed to open dex file '" << location << "' from memory";
+    return NULL;
   }
+
+  if (!DexFileVerifier::Verify(dex_file, dex_file->Begin(), dex_file->Size())) {
+    LOG(ERROR) << "Failed to verify dex file '" << location << "'";
+    return NULL;
+  }
+
   return dex_file;
 }