commit 641a473912b3bcaaff2c71070611490b7c547cfc
author Andreas Gampe <agampe@google.com> Thu Aug 24 13:21:35 2017 -0700
committer Andreas Gampe <agampe@google.com> Fri Aug 25 08:59:29 2017 -0700
tree 67bf5b2eaaeaf19c6cebac29984b49c19f172f9b
parent 5555dd1df3c7f3aaea548c3b657b9325538e9780

ART: Fix reference-related warnings

Make some parameters and locals references to avoid unnecessary
copies.

Bug: 32619234
Test: m test-art-host
Change-Id: Idfed600c7c5492a80f72f51424253bcbea824a94

dexlayout/dexlayout_test.cc

diff --git a/dexlayout/dexlayout_test.cc b/dexlayout/dexlayout_test.cc
index 1658967..336eb5f 100644
--- a/dexlayout/dexlayout_test.cc
+++ b/dexlayout/dexlayout_test.cc
@@ -380,7 +380,7 @@
   // Runs DexFileLayout test.
   bool DexFileLayoutExec(std::string* error_msg) {
     ScratchFile tmp_file;
-    std::string tmp_name = tmp_file.GetFilename();
+    const std::string& tmp_name = tmp_file.GetFilename();
     size_t tmp_last_slash = tmp_name.rfind('/');
     std::string tmp_dir = tmp_name.substr(0, tmp_last_slash + 1);
 
@@ -415,7 +415,7 @@
   // for behavior consistency.
   bool DexFileLayoutFixedPointExec(std::string* error_msg) {
     ScratchFile tmp_file;
-    std::string tmp_name = tmp_file.GetFilename();
+    const std::string& tmp_name = tmp_file.GetFilename();
     size_t tmp_last_slash = tmp_name.rfind('/');
     std::string tmp_dir = tmp_name.substr(0, tmp_last_slash + 1);
 
@@ -481,7 +481,7 @@
   // Runs UnreferencedCatchHandlerTest & Unreferenced0SizeCatchHandlerTest.
   bool UnreferencedCatchHandlerExec(std::string* error_msg, const char* filename) {
     ScratchFile tmp_file;
-    std::string tmp_name = tmp_file.GetFilename();
+    const std::string& tmp_name = tmp_file.GetFilename();
     size_t tmp_last_slash = tmp_name.rfind('/');
     std::string tmp_dir = tmp_name.substr(0, tmp_last_slash + 1);