commit 6ce017304099d1df97ffa016ce0efce79c67f344
author Nicolas Geoffray <ngeoffray@google.com> Wed Dec 30 14:10:13 2015 +0000
committer Nicolas Geoffray <ngeoffray@google.com> Wed Dec 30 14:22:11 2015 +0000
tree 6c8265acb94f17e78371191809fe67d8101c2c4e
parent e38e4b467bdcca1bf5f8b80adc66d3064fa9cf45

On x64, cmpl can never take a int64 immediate.

Fix a wrong type widening in x64 code generator and add
CHECKs in the assembler.

Change-Id: Id35f5d47c6cf78ed07e73ab783db09712d3c437f

compiler/optimizing/code_generator_x86_64.cc

diff --git a/compiler/optimizing/code_generator_x86_64.cc b/compiler/optimizing/code_generator_x86_64.cc
index ffd8c42..216d887 100644
--- a/compiler/optimizing/code_generator_x86_64.cc
+++ b/compiler/optimizing/code_generator_x86_64.cc
@@ -6385,7 +6385,7 @@
     if (index != num_entries) {
       // There are an odd number of entries. Handle the last one.
       DCHECK_EQ(index + 1, num_entries);
-      __ cmpl(value_reg_in, Immediate(lower_bound + index));
+      __ cmpl(value_reg_in, Immediate(static_cast<int32_t>(lower_bound + index)));
       __ j(kEqual, codegen_->GetLabelOf(successors[index]));
     }