commit 7cfb93e40e30710e184c1a41f2419d497a759677
author Ian Rogers <irogers@google.com> Tue Jan 17 19:46:36 2012 -0800
committer Ian Rogers <irogers@google.com> Tue Jan 17 19:46:36 2012 -0800
tree 649c87da08489ae5e1cde446d6f3f576dc408fe5
parent b4807ec95e8ba663b47c13da3e065874b1b586e6

Disallow DexFile::Open on directories

Change-Id: I003c883a586c12d243cb4fa3c0618ad4f239319f

src/dex_file.cc

diff --git a/src/dex_file.cc b/src/dex_file.cc
index 31a7d10..381f7e0 100644
--- a/src/dex_file.cc
+++ b/src/dex_file.cc
@@ -107,6 +107,10 @@
     close(fd);
     return NULL;
   }
+  if (S_ISDIR(sbuf.st_mode)) {
+    LOG(ERROR) << "attempt to mmap directory \"" << filename << "\"";
+    return NULL;
+  }
   size_t length = sbuf.st_size;
   UniquePtr<MemMap> map(MemMap::MapFile(length, PROT_READ, MAP_PRIVATE, fd, 0));
   if (map.get() == NULL) {