commit 8d8de0c92c45a25ac71375c689af29e168bc2ec1
author Mathieu Chartier <mathieuc@google.com> Wed Oct 04 09:35:30 2017 -0700
committer Mathieu Chartier <mathieuc@google.com> Wed Oct 04 09:43:31 2017 -0700
tree f60102a6d4493207ed3f8a4df86a004c4f5a046b
parent 1602bf67be5d9e377c1afde175b65634f4b8b0b5

Use CheckedCall for mprotects

Aims to prevent silent failures causing SIGSEGV in random places.

Bug: 66910552
Test: test-art-host

Change-Id: I91742b0b0059b5125ac663c3c3422ac5562df0fa

runtime/thread_pool.cc

diff --git a/runtime/thread_pool.cc b/runtime/thread_pool.cc
index fb77b84..cffaffc 100644
--- a/runtime/thread_pool.cc
+++ b/runtime/thread_pool.cc
@@ -31,6 +31,7 @@
 #include "base/time_utils.h"
 #include "runtime.h"
 #include "thread-current-inl.h"
+#include "utils.h"
 
 namespace art {
 
@@ -49,8 +50,11 @@
                                     false, false, &error_msg));
   CHECK(stack_.get() != nullptr) << error_msg;
   CHECK_ALIGNED(stack_->Begin(), kPageSize);
-  int mprotect_result = mprotect(stack_->Begin(), kPageSize, PROT_NONE);
-  CHECK_EQ(mprotect_result, 0) << "Failed to mprotect() bottom page of thread pool worker stack.";
+  CheckedCall(mprotect,
+              "mprotect bottom page of thread pool worker stack",
+              stack_->Begin(),
+              kPageSize,
+              PROT_NONE);
   const char* reason = "new thread pool worker thread";
   pthread_attr_t attr;
   CHECK_PTHREAD_CALL(pthread_attr_init, (&attr), reason);