commit 8e524ad3c690c183b1a71f6114796974a107c5dd
author Vladimir Marko <vmarko@google.com> Fri Jul 13 10:27:43 2018 +0100
committer Vladimir Marko <vmarko@google.com> Mon Jul 16 10:12:51 2018 +0100
tree 6ee124814e8f33fd4706eb15fcad2cae0019546b
parent 5991b184a40e4ce181d67d683ced46caa6143b53

Always produce PIC code for AOT compilation.

Change sharpening to use PIC load kinds for AOT compilation
and add "Jit" to the direct addressing load kind names. Use
PIC code also for the Integer.valueOf() intrinsic codegen.
Remove all support for non-PIC linker patches.

The dex2oat --compile-pic option is retained for now but
ignored by the compiler.

Test: m test-art-host-gtest
Test: testrunner.py --host --optimizing
Test: Pixel 2 XL boots.
Test: testrunner.py --target --optimizing
Bug: 77856493
Change-Id: I54d666f6522f160a1b6ece4045a15d19363acbb6

compiler/driver/compiler_driver.cc

diff --git a/compiler/driver/compiler_driver.cc b/compiler/driver/compiler_driver.cc
index b24b036..6eca304 100644
--- a/compiler/driver/compiler_driver.cc
+++ b/compiler/driver/compiler_driver.cc
@@ -255,7 +255,6 @@
       compiler_(Compiler::Create(this, compiler_kind)),
       compiler_kind_(compiler_kind),
       requires_constructor_barrier_lock_("constructor barrier lock"),
-      non_relative_linker_patch_count_(0u),
       image_classes_(std::move(image_classes)),
       number_of_soft_verifier_failures_(0),
       had_hard_verifier_failure_(false),
@@ -463,18 +462,7 @@
   }
 
   if (compiled_method != nullptr) {
-    // Count non-relative linker patches.
-    size_t non_relative_linker_patch_count = 0u;
-    for (const linker::LinkerPatch& patch : compiled_method->GetPatches()) {
-      if (!patch.IsPcRelative()) {
-        ++non_relative_linker_patch_count;
-      }
-    }
-    bool compile_pic = driver->GetCompilerOptions().GetCompilePic();  // Off by default
-    // When compiling with PIC, there should be zero non-relative linker patches
-    CHECK(!compile_pic || non_relative_linker_patch_count == 0u);
-
-    driver->AddCompiledMethod(method_ref, compiled_method, non_relative_linker_patch_count);
+    driver->AddCompiledMethod(method_ref, compiled_method);
   }
 
   if (self->IsExceptionPending()) {
@@ -2697,15 +2685,12 @@
 }
 
 void CompilerDriver::AddCompiledMethod(const MethodReference& method_ref,
-                                       CompiledMethod* const compiled_method,
-                                       size_t non_relative_linker_patch_count) {
+                                       CompiledMethod* const compiled_method) {
   DCHECK(GetCompiledMethod(method_ref) == nullptr) << method_ref.PrettyMethod();
   MethodTable::InsertResult result = compiled_methods_.Insert(method_ref,
                                                               /*expected*/ nullptr,
                                                               compiled_method);
   CHECK(result == MethodTable::kInsertResultSuccess);
-  non_relative_linker_patch_count_.fetch_add(non_relative_linker_patch_count,
-                                             std::memory_order_relaxed);
   DCHECK(GetCompiledMethod(method_ref) != nullptr) << method_ref.PrettyMethod();
 }
 
@@ -2815,10 +2800,6 @@
   return is_system_class;
 }
 
-size_t CompilerDriver::GetNonRelativeLinkerPatchCount() const {
-  return non_relative_linker_patch_count_.load(std::memory_order_relaxed);
-}
-
 void CompilerDriver::SetRequiresConstructorBarrier(Thread* self,
                                                    const DexFile* dex_file,
                                                    uint16_t class_def_index,