commit b45ccbf0e3c8f576de2f8608e12dc8c6ad002e0b
author Brian Carlstrom <bdc@google.com> Wed Mar 13 15:14:24 2013 -0700
committer Brian Carlstrom <bdc@google.com> Wed Mar 13 15:14:24 2013 -0700
tree 9f6821ef6fab98425bbbc38850845938f9c1d9ca
parent 8692215f793cbf8be9c3d25a705074ca877e09b8

Add some checks for bad inputs when opening files

Change-Id: I1cf9a3a0d5ca61c5e3bc375d28bd81a788a9fac5

src/base/unix_file/fd_file.cc

diff --git a/src/base/unix_file/fd_file.cc b/src/base/unix_file/fd_file.cc
index 7bb28a1..36f8ba7 100644
--- a/src/base/unix_file/fd_file.cc
+++ b/src/base/unix_file/fd_file.cc
@@ -30,6 +30,7 @@
 }
 
 FdFile::FdFile(int fd, const std::string& path) : fd_(fd), file_path_(path), auto_close_(true) {
+  CHECK_NE(0U, path.size());
 }
 
 FdFile::~FdFile() {

src/os_linux.cc

diff --git a/src/os_linux.cc b/src/os_linux.cc
index ceda7dd..d3a1ccb 100644
--- a/src/os_linux.cc
+++ b/src/os_linux.cc
@@ -21,12 +21,14 @@
 #include <sys/stat.h>
 #include <fcntl.h>
 
+#include "base/logging.h"
 #include "base/unix_file/fd_file.h"
 #include "UniquePtr.h"
 
 namespace art {
 
 File* OS::OpenFile(const char* name, bool writable, bool create) {
+  CHECK(name != NULL);
   int flags = 0;
   if (writable) {
     flags |= O_RDWR;