commit fd678beb171a4686a4f2d53ca4188a4ade8fa54e
author Mathieu Chartier <mathieuc@google.com> Thu Aug 30 14:50:54 2012 -0700
committer Mathieu Chartier <mathieuc@google.com> Tue Sep 04 14:58:14 2012 -0700
tree ab932e92d683d8033241bb2248da98e76249d3eb
parent 5bfa60ffcc953340feb711ed05cf576ac821905e

Additional heap verification for the Gc

There are now two verification booleans which can be enabled. When these get enabled, it verifies that each live object only references other live objects.

Changed SetClass to use SetFieldPtr to avoid having an extra card mark. This is safe since all classes are held live by the class linker.

Change-Id: I005bb59e5cc8153a79d3ccb3d7b5cabd29fb4051

src/mod_union_table.cc

diff --git a/src/mod_union_table.cc b/src/mod_union_table.cc
index 51fe70a..eb8c598 100644
--- a/src/mod_union_table.cc
+++ b/src/mod_union_table.cc
@@ -252,7 +252,10 @@
   }
 
   // Extra parameters are required since we use this same visitor signature for checking objects.
-  void operator ()(const Object* obj, const Object* ref, const MemberOffset& /* offset */, bool /* is_static */) const {
+  void operator ()(const Object* obj, const Object* ref, const MemberOffset& /* offset */,
+                     bool /* is_static */) const
+      SHARED_LOCKS_REQUIRED(GlobalSynchronization::heap_bitmap_lock_,
+                            GlobalSynchronization::mutator_lock_) {
     Heap* heap = mod_union_table_->GetMarkSweep()->GetHeap();
     if (mod_union_table_->AddReference(obj, ref) && references_.find(ref) == references_.end()) {
       Space* from_space = heap->FindSpaceFromObject(obj);
@@ -283,7 +286,9 @@
       references_(references) {
   }
 
-  void operator ()(Object* obj, void* /* finger */) const {
+  void operator ()(Object* obj) const
+      SHARED_LOCKS_REQUIRED(GlobalSynchronization::heap_bitmap_lock_,
+                            GlobalSynchronization::mutator_lock_) {
     DCHECK(obj != NULL);
     MarkSweep* mark_sweep = mod_union_table_->GetMarkSweep();
     CheckReferenceVisitor visitor(mod_union_table_, references_);
@@ -296,7 +301,6 @@
 };
 
 void ModUnionTableReferenceCache::Verify() {
-#if VERIFY_MOD_UNION
   // Start by checking that everything in the mod union table is marked.
   Heap* heap = GetMarkSweep()->GetHeap();
   for (ReferenceMap::const_iterator it = references_.begin(); it != references_.end(); ++it) {
@@ -319,10 +323,9 @@
       uintptr_t end = start + GC_CARD_SIZE;
       SpaceBitmap* live_bitmap =
               heap->FindSpaceFromObject(reinterpret_cast<Object*>(start))->GetLiveBitmap();
-      live_bitmap->VisitMarkedRange(start, end, visitor);
+      live_bitmap->VisitMarkedRange(start, end, visitor, IdentityFunctor());
     }
   }
-#endif
 }
 
 void ModUnionTableReferenceCache::Update() {