Elliott Hughes | 2faa5f1 | 2012-01-30 14:42:07 -0800 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (C) 2011 The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
Shih-wei Liao | 2fb9753 | 2011-08-11 16:17:23 -0700 | [diff] [blame] | 16 | |
Shih-wei Liao | 2fb9753 | 2011-08-11 16:17:23 -0700 | [diff] [blame] | 17 | #include "class_linker.h" |
| 18 | #include "common_test.h" |
| 19 | #include "dex_file.h" |
Elliott Hughes | 90a3369 | 2011-08-30 13:27:07 -0700 | [diff] [blame] | 20 | #include "gtest/gtest.h" |
Shih-wei Liao | 2fb9753 | 2011-08-11 16:17:23 -0700 | [diff] [blame] | 21 | #include "runtime.h" |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 22 | #include "scoped_thread_state_change.h" |
Ian Rogers | 1f53934 | 2012-10-03 21:09:42 -0700 | [diff] [blame] | 23 | #include "sirt_ref.h" |
Shih-wei Liao | 2fb9753 | 2011-08-11 16:17:23 -0700 | [diff] [blame] | 24 | #include "thread.h" |
Elliott Hughes | a168c83 | 2012-06-12 15:34:20 -0700 | [diff] [blame] | 25 | #include "UniquePtr.h" |
Shih-wei Liao | 2fb9753 | 2011-08-11 16:17:23 -0700 | [diff] [blame] | 26 | |
| 27 | namespace art { |
| 28 | |
Brian Carlstrom | f734cf5 | 2011-08-17 16:28:14 -0700 | [diff] [blame] | 29 | class ExceptionTest : public CommonTest { |
Shih-wei Liao | 1a18c8c | 2011-08-14 17:47:36 -0700 | [diff] [blame] | 30 | protected: |
| 31 | virtual void SetUp() { |
| 32 | CommonTest::SetUp(); |
| 33 | |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 34 | ScopedObjectAccess soa(Thread::Current()); |
Ian Rogers | 1f53934 | 2012-10-03 21:09:42 -0700 | [diff] [blame] | 35 | SirtRef<ClassLoader> class_loader(soa.Self(), |
| 36 | soa.Decode<ClassLoader*>(LoadDex("ExceptionHandle"))); |
Brian Carlstrom | 40381fb | 2011-10-19 14:13:40 -0700 | [diff] [blame] | 37 | my_klass_ = class_linker_->FindClass("LExceptionHandle;", class_loader.get()); |
Shih-wei Liao | 1a18c8c | 2011-08-14 17:47:36 -0700 | [diff] [blame] | 38 | ASSERT_TRUE(my_klass_ != NULL); |
Mathieu Chartier | 342a262 | 2012-06-28 12:04:52 -0700 | [diff] [blame] | 39 | class_linker_->EnsureInitialized(my_klass_, false, true); |
Brian Carlstrom | 33f741e | 2011-10-03 11:24:05 -0700 | [diff] [blame] | 40 | |
Ian Rogers | 4445a7e | 2012-10-05 17:19:13 -0700 | [diff] [blame] | 41 | dex_ = my_klass_->GetDexCache()->GetDexFile(); |
Brian Carlstrom | 33f741e | 2011-10-03 11:24:05 -0700 | [diff] [blame] | 42 | |
Brian Carlstrom | f8bbb84 | 2012-03-14 03:01:42 -0700 | [diff] [blame] | 43 | uint32_t code_size = 12; |
| 44 | fake_code_.push_back((code_size >> 24) & 0xFF); |
| 45 | fake_code_.push_back((code_size >> 16) & 0xFF); |
| 46 | fake_code_.push_back((code_size >> 8) & 0xFF); |
| 47 | fake_code_.push_back((code_size >> 0) & 0xFF); |
| 48 | for (size_t i = 0 ; i < code_size; i++) { |
| 49 | fake_code_.push_back(0x70 | i); |
Brian Carlstrom | 3320cf4 | 2011-10-04 14:58:28 -0700 | [diff] [blame] | 50 | } |
| 51 | |
Bill Buzbee | a5b3024 | 2012-09-28 07:19:44 -0700 | [diff] [blame] | 52 | fake_mapping_data_.push_back(4); // first element is count |
| 53 | fake_mapping_data_.push_back(4); // total (non-length) elements |
| 54 | fake_mapping_data_.push_back(2); // count of pc to dex elements |
| 55 | // --- pc to dex table |
| 56 | fake_mapping_data_.push_back(3); // offset 3 |
| 57 | fake_mapping_data_.push_back(3); // maps to dex offset 3 |
| 58 | // --- dex to pc table |
Brian Carlstrom | 3320cf4 | 2011-10-04 14:58:28 -0700 | [diff] [blame] | 59 | fake_mapping_data_.push_back(3); // offset 3 |
| 60 | fake_mapping_data_.push_back(3); // maps to dex offset 3 |
Brian Carlstrom | 33f741e | 2011-10-03 11:24:05 -0700 | [diff] [blame] | 61 | |
Mathieu Chartier | 342a262 | 2012-06-28 12:04:52 -0700 | [diff] [blame] | 62 | fake_vmap_table_data_.push_back(0); |
| 63 | |
Ian Rogers | 5a6220c | 2012-09-24 10:52:10 -0700 | [diff] [blame] | 64 | fake_gc_map_.push_back(0); // 0 bytes to encode references and native pc offsets. |
| 65 | fake_gc_map_.push_back(0); |
| 66 | fake_gc_map_.push_back(0); // 0 entries. |
| 67 | fake_gc_map_.push_back(0); |
| 68 | |
Shih-wei Liao | 1a18c8c | 2011-08-14 17:47:36 -0700 | [diff] [blame] | 69 | method_f_ = my_klass_->FindVirtualMethod("f", "()I"); |
| 70 | ASSERT_TRUE(method_f_ != NULL); |
Ian Rogers | 0cfe1fb | 2011-08-26 03:29:44 -0700 | [diff] [blame] | 71 | method_f_->SetFrameSizeInBytes(kStackAlignment); |
Brian Carlstrom | f8bbb84 | 2012-03-14 03:01:42 -0700 | [diff] [blame] | 72 | method_f_->SetCode(CompiledMethod::CodePointer(&fake_code_[sizeof(code_size)], kThumb2)); |
Brian Carlstrom | 3320cf4 | 2011-10-04 14:58:28 -0700 | [diff] [blame] | 73 | method_f_->SetMappingTable(&fake_mapping_data_[0]); |
Mathieu Chartier | 342a262 | 2012-06-28 12:04:52 -0700 | [diff] [blame] | 74 | method_f_->SetVmapTable(&fake_vmap_table_data_[0]); |
Ian Rogers | 5a6220c | 2012-09-24 10:52:10 -0700 | [diff] [blame] | 75 | method_f_->SetNativeGcMap(&fake_gc_map_[0]); |
Brian Carlstrom | 33f741e | 2011-10-03 11:24:05 -0700 | [diff] [blame] | 76 | |
Shih-wei Liao | 1a18c8c | 2011-08-14 17:47:36 -0700 | [diff] [blame] | 77 | method_g_ = my_klass_->FindVirtualMethod("g", "(I)V"); |
| 78 | ASSERT_TRUE(method_g_ != NULL); |
Ian Rogers | 0cfe1fb | 2011-08-26 03:29:44 -0700 | [diff] [blame] | 79 | method_g_->SetFrameSizeInBytes(kStackAlignment); |
Brian Carlstrom | f8bbb84 | 2012-03-14 03:01:42 -0700 | [diff] [blame] | 80 | method_g_->SetCode(CompiledMethod::CodePointer(&fake_code_[sizeof(code_size)], kThumb2)); |
Brian Carlstrom | 3320cf4 | 2011-10-04 14:58:28 -0700 | [diff] [blame] | 81 | method_g_->SetMappingTable(&fake_mapping_data_[0]); |
Mathieu Chartier | 342a262 | 2012-06-28 12:04:52 -0700 | [diff] [blame] | 82 | method_g_->SetVmapTable(&fake_vmap_table_data_[0]); |
Ian Rogers | 5a6220c | 2012-09-24 10:52:10 -0700 | [diff] [blame] | 83 | method_g_->SetNativeGcMap(&fake_gc_map_[0]); |
Shih-wei Liao | 1a18c8c | 2011-08-14 17:47:36 -0700 | [diff] [blame] | 84 | } |
| 85 | |
Brian Carlstrom | 33f741e | 2011-10-03 11:24:05 -0700 | [diff] [blame] | 86 | const DexFile* dex_; |
Shih-wei Liao | 1a18c8c | 2011-08-14 17:47:36 -0700 | [diff] [blame] | 87 | |
Brian Carlstrom | 3320cf4 | 2011-10-04 14:58:28 -0700 | [diff] [blame] | 88 | std::vector<uint8_t> fake_code_; |
| 89 | std::vector<uint32_t> fake_mapping_data_; |
Mathieu Chartier | 342a262 | 2012-06-28 12:04:52 -0700 | [diff] [blame] | 90 | std::vector<uint16_t> fake_vmap_table_data_; |
Ian Rogers | 5a6220c | 2012-09-24 10:52:10 -0700 | [diff] [blame] | 91 | std::vector<uint8_t> fake_gc_map_; |
Brian Carlstrom | 3320cf4 | 2011-10-04 14:58:28 -0700 | [diff] [blame] | 92 | |
Mathieu Chartier | 66f1925 | 2012-09-18 08:57:04 -0700 | [diff] [blame] | 93 | AbstractMethod* method_f_; |
| 94 | AbstractMethod* method_g_; |
Shih-wei Liao | 1a18c8c | 2011-08-14 17:47:36 -0700 | [diff] [blame] | 95 | |
| 96 | private: |
| 97 | Class* my_klass_; |
Shih-wei Liao | 2fb9753 | 2011-08-11 16:17:23 -0700 | [diff] [blame] | 98 | }; |
| 99 | |
Shih-wei Liao | 1a18c8c | 2011-08-14 17:47:36 -0700 | [diff] [blame] | 100 | TEST_F(ExceptionTest, FindCatchHandler) { |
Brian Carlstrom | 33f741e | 2011-10-03 11:24:05 -0700 | [diff] [blame] | 101 | const DexFile::CodeItem* code_item = dex_->GetCodeItem(method_f_->GetCodeItemOffset()); |
Shih-wei Liao | 2fb9753 | 2011-08-11 16:17:23 -0700 | [diff] [blame] | 102 | |
| 103 | ASSERT_TRUE(code_item != NULL); |
| 104 | |
| 105 | ASSERT_EQ(2u, code_item->tries_size_); |
Ian Rogers | d81871c | 2011-10-03 13:57:23 -0700 | [diff] [blame] | 106 | ASSERT_NE(0u, code_item->insns_size_in_code_units_); |
Shih-wei Liao | 2fb9753 | 2011-08-11 16:17:23 -0700 | [diff] [blame] | 107 | |
Elliott Hughes | 7b9d996 | 2012-04-20 18:48:18 -0700 | [diff] [blame] | 108 | const DexFile::TryItem *t0, *t1; |
Ian Rogers | 0571d35 | 2011-11-03 19:51:38 -0700 | [diff] [blame] | 109 | t0 = dex_->GetTryItems(*code_item, 0); |
| 110 | t1 = dex_->GetTryItems(*code_item, 1); |
Shih-wei Liao | 2fb9753 | 2011-08-11 16:17:23 -0700 | [diff] [blame] | 111 | EXPECT_LE(t0->start_addr_, t1->start_addr_); |
Ian Rogers | 0571d35 | 2011-11-03 19:51:38 -0700 | [diff] [blame] | 112 | { |
| 113 | CatchHandlerIterator iter(*code_item, 4 /* Dex PC in the first try block */); |
| 114 | EXPECT_STREQ("Ljava/io/IOException;", dex_->StringByTypeIdx(iter.GetHandlerTypeIndex())); |
| 115 | ASSERT_TRUE(iter.HasNext()); |
| 116 | iter.Next(); |
| 117 | EXPECT_STREQ("Ljava/lang/Exception;", dex_->StringByTypeIdx(iter.GetHandlerTypeIndex())); |
| 118 | ASSERT_TRUE(iter.HasNext()); |
| 119 | iter.Next(); |
| 120 | EXPECT_FALSE(iter.HasNext()); |
| 121 | } |
| 122 | { |
| 123 | CatchHandlerIterator iter(*code_item, 8 /* Dex PC in the second try block */); |
| 124 | EXPECT_STREQ("Ljava/io/IOException;", dex_->StringByTypeIdx(iter.GetHandlerTypeIndex())); |
| 125 | ASSERT_TRUE(iter.HasNext()); |
| 126 | iter.Next(); |
| 127 | EXPECT_FALSE(iter.HasNext()); |
| 128 | } |
| 129 | { |
| 130 | CatchHandlerIterator iter(*code_item, 11 /* Dex PC not in any try block */); |
| 131 | EXPECT_FALSE(iter.HasNext()); |
| 132 | } |
Shih-wei Liao | 2fb9753 | 2011-08-11 16:17:23 -0700 | [diff] [blame] | 133 | } |
| 134 | |
Shih-wei Liao | 55df06b | 2011-08-26 14:39:27 -0700 | [diff] [blame] | 135 | TEST_F(ExceptionTest, StackTraceElement) { |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 136 | Thread* thread = Thread::Current(); |
Ian Rogers | 0fb6bb5 | 2012-08-14 15:10:19 -0700 | [diff] [blame] | 137 | thread->TransitionFromSuspendedToRunnable(); |
| 138 | runtime_->Start(); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 139 | JNIEnv* env = thread->GetJniEnv(); |
| 140 | ScopedObjectAccess soa(env); |
Brian Carlstrom | 25c3325 | 2011-09-18 15:58:35 -0700 | [diff] [blame] | 141 | |
Elliott Hughes | 3b6baaa | 2011-10-14 19:13:56 -0700 | [diff] [blame] | 142 | std::vector<uintptr_t> fake_stack; |
Ian Rogers | 0cfe1fb | 2011-08-26 03:29:44 -0700 | [diff] [blame] | 143 | ASSERT_EQ(kStackAlignment, 16); |
| 144 | ASSERT_EQ(sizeof(uintptr_t), sizeof(uint32_t)); |
| 145 | |
Shih-wei Liao | 02f01fe | 2012-03-26 12:58:11 -0700 | [diff] [blame] | 146 | #if !defined(ART_USE_LLVM_COMPILER) |
Ian Rogers | f57c47c | 2011-10-06 00:06:17 -0700 | [diff] [blame] | 147 | // Create two fake stack frames with mapping data created in SetUp. We map offset 3 in the code |
Mathieu Chartier | 342a262 | 2012-06-28 12:04:52 -0700 | [diff] [blame] | 148 | // to dex pc 3. |
| 149 | const uint32_t dex_pc = 3; |
Ian Rogers | f57c47c | 2011-10-06 00:06:17 -0700 | [diff] [blame] | 150 | |
Ian Rogers | 0cfe1fb | 2011-08-26 03:29:44 -0700 | [diff] [blame] | 151 | // Create/push fake 16byte stack frame for method g |
Elliott Hughes | 3b6baaa | 2011-10-14 19:13:56 -0700 | [diff] [blame] | 152 | fake_stack.push_back(reinterpret_cast<uintptr_t>(method_g_)); |
| 153 | fake_stack.push_back(0); |
| 154 | fake_stack.push_back(0); |
Ian Rogers | 0c7abda | 2012-09-19 13:33:42 -0700 | [diff] [blame] | 155 | fake_stack.push_back(method_f_->ToNativePc(dex_pc)); // return pc |
Ian Rogers | 0cfe1fb | 2011-08-26 03:29:44 -0700 | [diff] [blame] | 156 | |
| 157 | // Create/push fake 16byte stack frame for method f |
Elliott Hughes | 3b6baaa | 2011-10-14 19:13:56 -0700 | [diff] [blame] | 158 | fake_stack.push_back(reinterpret_cast<uintptr_t>(method_f_)); |
| 159 | fake_stack.push_back(0); |
| 160 | fake_stack.push_back(0); |
| 161 | fake_stack.push_back(0xEBAD6070); // return pc |
Ian Rogers | 0cfe1fb | 2011-08-26 03:29:44 -0700 | [diff] [blame] | 162 | |
| 163 | // Pull Method* of NULL to terminate the trace |
Brian Carlstrom | 2e3d1b2 | 2012-01-09 18:01:56 -0800 | [diff] [blame] | 164 | fake_stack.push_back(0); |
Shih-wei Liao | 55df06b | 2011-08-26 14:39:27 -0700 | [diff] [blame] | 165 | |
Mathieu Chartier | 342a262 | 2012-06-28 12:04:52 -0700 | [diff] [blame] | 166 | // Push null values which will become null incoming arguments. |
| 167 | fake_stack.push_back(0); |
| 168 | fake_stack.push_back(0); |
| 169 | fake_stack.push_back(0); |
| 170 | |
| 171 | // Set up thread to appear as if we called out of method_g_ at pc dex 3 |
Ian Rogers | 0c7abda | 2012-09-19 13:33:42 -0700 | [diff] [blame] | 172 | thread->SetTopOfStack(&fake_stack[0], method_g_->ToNativePc(dex_pc)); // return pc |
Shih-wei Liao | 02f01fe | 2012-03-26 12:58:11 -0700 | [diff] [blame] | 173 | #else |
| 174 | // Create/push fake 20-byte shadow frame for method g |
| 175 | fake_stack.push_back(0); |
| 176 | fake_stack.push_back(0); |
| 177 | fake_stack.push_back(reinterpret_cast<uintptr_t>(method_g_)); |
TDYa127 | c8dc101 | 2012-04-19 07:03:33 -0700 | [diff] [blame] | 178 | fake_stack.push_back(3); |
Shih-wei Liao | 02f01fe | 2012-03-26 12:58:11 -0700 | [diff] [blame] | 179 | fake_stack.push_back(0); |
| 180 | |
| 181 | // Create/push fake 20-byte shadow frame for method f |
| 182 | fake_stack.push_back(0); |
| 183 | fake_stack.push_back(0); |
| 184 | fake_stack.push_back(reinterpret_cast<uintptr_t>(method_f_)); |
TDYa127 | c8dc101 | 2012-04-19 07:03:33 -0700 | [diff] [blame] | 185 | fake_stack.push_back(3); |
Shih-wei Liao | 02f01fe | 2012-03-26 12:58:11 -0700 | [diff] [blame] | 186 | fake_stack.push_back(0); |
| 187 | |
Shih-wei Liao | 02f01fe | 2012-03-26 12:58:11 -0700 | [diff] [blame] | 188 | thread->PushShadowFrame(reinterpret_cast<ShadowFrame*>(&fake_stack[5])); |
| 189 | thread->PushShadowFrame(reinterpret_cast<ShadowFrame*>(&fake_stack[0])); |
| 190 | #endif |
Shih-wei Liao | 55df06b | 2011-08-26 14:39:27 -0700 | [diff] [blame] | 191 | |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 192 | jobject internal = thread->CreateInternalStackTrace(soa); |
Brian Carlstrom | 2673644 | 2012-02-16 18:24:26 -0800 | [diff] [blame] | 193 | ASSERT_TRUE(internal != NULL); |
Elliott Hughes | 01158d7 | 2011-09-19 19:47:10 -0700 | [diff] [blame] | 194 | jobjectArray ste_array = Thread::InternalStackTraceToStackTraceElementArray(env, internal); |
Brian Carlstrom | 2673644 | 2012-02-16 18:24:26 -0800 | [diff] [blame] | 195 | ASSERT_TRUE(ste_array != NULL); |
Ian Rogers | aaa2080 | 2011-09-11 21:47:37 -0700 | [diff] [blame] | 196 | ObjectArray<StackTraceElement>* trace_array = |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 197 | soa.Decode<ObjectArray<StackTraceElement>*>(ste_array); |
Shih-wei Liao | 55df06b | 2011-08-26 14:39:27 -0700 | [diff] [blame] | 198 | |
Brian Carlstrom | 2673644 | 2012-02-16 18:24:26 -0800 | [diff] [blame] | 199 | ASSERT_TRUE(trace_array != NULL); |
Shih-wei Liao | 55df06b | 2011-08-26 14:39:27 -0700 | [diff] [blame] | 200 | ASSERT_TRUE(trace_array->Get(0) != NULL); |
Brian Carlstrom | 33f741e | 2011-10-03 11:24:05 -0700 | [diff] [blame] | 201 | EXPECT_STREQ("ExceptionHandle", |
Shih-wei Liao | 4417536 | 2011-08-28 16:59:17 -0700 | [diff] [blame] | 202 | trace_array->Get(0)->GetDeclaringClass()->ToModifiedUtf8().c_str()); |
Brian Carlstrom | 33f741e | 2011-10-03 11:24:05 -0700 | [diff] [blame] | 203 | EXPECT_STREQ("ExceptionHandle.java", trace_array->Get(0)->GetFileName()->ToModifiedUtf8().c_str()); |
Shih-wei Liao | 55df06b | 2011-08-26 14:39:27 -0700 | [diff] [blame] | 204 | EXPECT_STREQ("g", trace_array->Get(0)->GetMethodName()->ToModifiedUtf8().c_str()); |
Brian Carlstrom | 06ed739 | 2012-01-31 01:25:48 -0800 | [diff] [blame] | 205 | EXPECT_EQ(37, trace_array->Get(0)->GetLineNumber()); |
Shih-wei Liao | 55df06b | 2011-08-26 14:39:27 -0700 | [diff] [blame] | 206 | |
| 207 | ASSERT_TRUE(trace_array->Get(1) != NULL); |
Brian Carlstrom | 33f741e | 2011-10-03 11:24:05 -0700 | [diff] [blame] | 208 | EXPECT_STREQ("ExceptionHandle", |
Shih-wei Liao | 4417536 | 2011-08-28 16:59:17 -0700 | [diff] [blame] | 209 | trace_array->Get(1)->GetDeclaringClass()->ToModifiedUtf8().c_str()); |
Brian Carlstrom | 33f741e | 2011-10-03 11:24:05 -0700 | [diff] [blame] | 210 | EXPECT_STREQ("ExceptionHandle.java", trace_array->Get(1)->GetFileName()->ToModifiedUtf8().c_str()); |
Shih-wei Liao | 55df06b | 2011-08-26 14:39:27 -0700 | [diff] [blame] | 211 | EXPECT_STREQ("f", trace_array->Get(1)->GetMethodName()->ToModifiedUtf8().c_str()); |
Brian Carlstrom | 06ed739 | 2012-01-31 01:25:48 -0800 | [diff] [blame] | 212 | EXPECT_EQ(22, trace_array->Get(1)->GetLineNumber()); |
Elliott Hughes | a43e093 | 2012-03-27 18:35:33 -0700 | [diff] [blame] | 213 | |
| 214 | #if !defined(ART_USE_LLVM_COMPILER) |
| 215 | thread->SetTopOfStack(NULL, 0); // Disarm the assertion that no code is running when we detach. |
Ian Rogers | 0399dde | 2012-06-06 17:09:28 -0700 | [diff] [blame] | 216 | #else |
| 217 | thread->PopShadowFrame(); |
| 218 | thread->PopShadowFrame(); |
Elliott Hughes | a43e093 | 2012-03-27 18:35:33 -0700 | [diff] [blame] | 219 | #endif |
Shih-wei Liao | 55df06b | 2011-08-26 14:39:27 -0700 | [diff] [blame] | 220 | } |
| 221 | |
Shih-wei Liao | 2fb9753 | 2011-08-11 16:17:23 -0700 | [diff] [blame] | 222 | } // namespace art |