Nicolas Geoffray | 818f210 | 2014-02-18 16:43:35 +0000 | [diff] [blame] | 1 | /* |
Nicolas Geoffray | 818f210 | 2014-02-18 16:43:35 +0000 | [diff] [blame] | 2 | * Copyright (C) 2014 The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
Nicolas Geoffray | e503832 | 2014-07-04 09:41:32 +0100 | [diff] [blame] | 17 | #include "builder.h" |
| 18 | |
Mathieu Chartier | c785344 | 2015-03-27 14:35:38 -0700 | [diff] [blame] | 19 | #include "art_field-inl.h" |
Andreas Gampe | d881df5 | 2014-11-24 23:28:39 -0800 | [diff] [blame] | 20 | #include "base/logging.h" |
Nicolas Geoffray | e503832 | 2014-07-04 09:41:32 +0100 | [diff] [blame] | 21 | #include "class_linker.h" |
Jeff Hao | 848f70a | 2014-01-15 13:49:50 -0800 | [diff] [blame] | 22 | #include "dex/verified_method.h" |
Nicolas Geoffray | 8ccc3f5 | 2014-03-19 10:34:11 +0000 | [diff] [blame] | 23 | #include "dex_file-inl.h" |
Nicolas Geoffray | 3ff386a | 2014-03-04 14:46:47 +0000 | [diff] [blame] | 24 | #include "dex_instruction-inl.h" |
Roland Levillain | 4c0eb42 | 2015-04-24 16:43:49 +0100 | [diff] [blame] | 25 | #include "dex/verified_method.h" |
Nicolas Geoffray | e503832 | 2014-07-04 09:41:32 +0100 | [diff] [blame] | 26 | #include "driver/compiler_driver-inl.h" |
Vladimir Marko | 20f8559 | 2015-03-19 10:07:02 +0000 | [diff] [blame] | 27 | #include "driver/compiler_options.h" |
Nicolas Geoffray | e503832 | 2014-07-04 09:41:32 +0100 | [diff] [blame] | 28 | #include "mirror/class_loader.h" |
| 29 | #include "mirror/dex_cache.h" |
Nicolas Geoffray | 818f210 | 2014-02-18 16:43:35 +0000 | [diff] [blame] | 30 | #include "nodes.h" |
Nicolas Geoffray | 8ccc3f5 | 2014-03-19 10:34:11 +0000 | [diff] [blame] | 31 | #include "primitive.h" |
Nicolas Geoffray | e503832 | 2014-07-04 09:41:32 +0100 | [diff] [blame] | 32 | #include "scoped_thread_state_change.h" |
| 33 | #include "thread.h" |
Nicolas Geoffray | 818f210 | 2014-02-18 16:43:35 +0000 | [diff] [blame] | 34 | |
| 35 | namespace art { |
| 36 | |
Nicolas Geoffray | f12feb8 | 2014-07-17 18:32:41 +0100 | [diff] [blame] | 37 | /** |
| 38 | * Helper class to add HTemporary instructions. This class is used when |
| 39 | * converting a DEX instruction to multiple HInstruction, and where those |
| 40 | * instructions do not die at the following instruction, but instead spans |
| 41 | * multiple instructions. |
| 42 | */ |
| 43 | class Temporaries : public ValueObject { |
| 44 | public: |
Calin Juravle | f97f9fb | 2014-11-11 15:38:19 +0000 | [diff] [blame] | 45 | explicit Temporaries(HGraph* graph) : graph_(graph), index_(0) {} |
Nicolas Geoffray | f12feb8 | 2014-07-17 18:32:41 +0100 | [diff] [blame] | 46 | |
| 47 | void Add(HInstruction* instruction) { |
Calin Juravle | f97f9fb | 2014-11-11 15:38:19 +0000 | [diff] [blame] | 48 | HInstruction* temp = new (graph_->GetArena()) HTemporary(index_); |
Nicolas Geoffray | f12feb8 | 2014-07-17 18:32:41 +0100 | [diff] [blame] | 49 | instruction->GetBlock()->AddInstruction(temp); |
Calin Juravle | f97f9fb | 2014-11-11 15:38:19 +0000 | [diff] [blame] | 50 | |
Nicolas Geoffray | f12feb8 | 2014-07-17 18:32:41 +0100 | [diff] [blame] | 51 | DCHECK(temp->GetPrevious() == instruction); |
Calin Juravle | f97f9fb | 2014-11-11 15:38:19 +0000 | [diff] [blame] | 52 | |
| 53 | size_t offset; |
| 54 | if (instruction->GetType() == Primitive::kPrimLong |
| 55 | || instruction->GetType() == Primitive::kPrimDouble) { |
| 56 | offset = 2; |
| 57 | } else { |
| 58 | offset = 1; |
| 59 | } |
| 60 | index_ += offset; |
| 61 | |
| 62 | graph_->UpdateTemporariesVRegSlots(index_); |
Nicolas Geoffray | f12feb8 | 2014-07-17 18:32:41 +0100 | [diff] [blame] | 63 | } |
| 64 | |
| 65 | private: |
| 66 | HGraph* const graph_; |
| 67 | |
Nicolas Geoffray | f12feb8 | 2014-07-17 18:32:41 +0100 | [diff] [blame] | 68 | // Current index in the temporary stack, updated by `Add`. |
| 69 | size_t index_; |
| 70 | }; |
| 71 | |
Andreas Gampe | d881df5 | 2014-11-24 23:28:39 -0800 | [diff] [blame] | 72 | class SwitchTable : public ValueObject { |
| 73 | public: |
| 74 | SwitchTable(const Instruction& instruction, uint32_t dex_pc, bool sparse) |
| 75 | : instruction_(instruction), dex_pc_(dex_pc), sparse_(sparse) { |
| 76 | int32_t table_offset = instruction.VRegB_31t(); |
| 77 | const uint16_t* table = reinterpret_cast<const uint16_t*>(&instruction) + table_offset; |
| 78 | if (sparse) { |
| 79 | CHECK_EQ(table[0], static_cast<uint16_t>(Instruction::kSparseSwitchSignature)); |
| 80 | } else { |
| 81 | CHECK_EQ(table[0], static_cast<uint16_t>(Instruction::kPackedSwitchSignature)); |
| 82 | } |
| 83 | num_entries_ = table[1]; |
| 84 | values_ = reinterpret_cast<const int32_t*>(&table[2]); |
| 85 | } |
| 86 | |
| 87 | uint16_t GetNumEntries() const { |
| 88 | return num_entries_; |
| 89 | } |
| 90 | |
Andreas Gampe | e4d4d32 | 2014-12-04 09:09:57 -0800 | [diff] [blame] | 91 | void CheckIndex(size_t index) const { |
| 92 | if (sparse_) { |
| 93 | // In a sparse table, we have num_entries_ keys and num_entries_ values, in that order. |
| 94 | DCHECK_LT(index, 2 * static_cast<size_t>(num_entries_)); |
| 95 | } else { |
| 96 | // In a packed table, we have the starting key and num_entries_ values. |
| 97 | DCHECK_LT(index, 1 + static_cast<size_t>(num_entries_)); |
| 98 | } |
| 99 | } |
| 100 | |
Andreas Gampe | d881df5 | 2014-11-24 23:28:39 -0800 | [diff] [blame] | 101 | int32_t GetEntryAt(size_t index) const { |
Andreas Gampe | e4d4d32 | 2014-12-04 09:09:57 -0800 | [diff] [blame] | 102 | CheckIndex(index); |
Andreas Gampe | d881df5 | 2014-11-24 23:28:39 -0800 | [diff] [blame] | 103 | return values_[index]; |
| 104 | } |
| 105 | |
| 106 | uint32_t GetDexPcForIndex(size_t index) const { |
Andreas Gampe | e4d4d32 | 2014-12-04 09:09:57 -0800 | [diff] [blame] | 107 | CheckIndex(index); |
Andreas Gampe | d881df5 | 2014-11-24 23:28:39 -0800 | [diff] [blame] | 108 | return dex_pc_ + |
| 109 | (reinterpret_cast<const int16_t*>(values_ + index) - |
| 110 | reinterpret_cast<const int16_t*>(&instruction_)); |
| 111 | } |
| 112 | |
Andreas Gampe | e4d4d32 | 2014-12-04 09:09:57 -0800 | [diff] [blame] | 113 | // Index of the first value in the table. |
| 114 | size_t GetFirstValueIndex() const { |
| 115 | if (sparse_) { |
| 116 | // In a sparse table, we have num_entries_ keys and num_entries_ values, in that order. |
| 117 | return num_entries_; |
| 118 | } else { |
| 119 | // In a packed table, we have the starting key and num_entries_ values. |
| 120 | return 1; |
| 121 | } |
| 122 | } |
| 123 | |
Andreas Gampe | d881df5 | 2014-11-24 23:28:39 -0800 | [diff] [blame] | 124 | private: |
| 125 | const Instruction& instruction_; |
| 126 | const uint32_t dex_pc_; |
| 127 | |
| 128 | // Whether this is a sparse-switch table (or a packed-switch one). |
| 129 | const bool sparse_; |
| 130 | |
| 131 | // This can't be const as it needs to be computed off of the given instruction, and complicated |
| 132 | // expressions in the initializer list seemed very ugly. |
| 133 | uint16_t num_entries_; |
| 134 | |
| 135 | const int32_t* values_; |
| 136 | |
| 137 | DISALLOW_COPY_AND_ASSIGN(SwitchTable); |
| 138 | }; |
| 139 | |
Nicolas Geoffray | f583e59 | 2014-04-07 13:20:42 +0100 | [diff] [blame] | 140 | void HGraphBuilder::InitializeLocals(uint16_t count) { |
| 141 | graph_->SetNumberOfVRegs(count); |
Nicolas Geoffray | 3ff386a | 2014-03-04 14:46:47 +0000 | [diff] [blame] | 142 | locals_.SetSize(count); |
| 143 | for (int i = 0; i < count; i++) { |
| 144 | HLocal* local = new (arena_) HLocal(i); |
| 145 | entry_block_->AddInstruction(local); |
Nicolas Geoffray | bab4ed7 | 2014-03-11 17:53:17 +0000 | [diff] [blame] | 146 | locals_.Put(i, local); |
Nicolas Geoffray | 3ff386a | 2014-03-04 14:46:47 +0000 | [diff] [blame] | 147 | } |
| 148 | } |
| 149 | |
Nicolas Geoffray | 52e832b | 2014-11-06 15:15:31 +0000 | [diff] [blame] | 150 | void HGraphBuilder::InitializeParameters(uint16_t number_of_parameters) { |
Nicolas Geoffray | f583e59 | 2014-04-07 13:20:42 +0100 | [diff] [blame] | 151 | // dex_compilation_unit_ is null only when unit testing. |
| 152 | if (dex_compilation_unit_ == nullptr) { |
Nicolas Geoffray | 52e832b | 2014-11-06 15:15:31 +0000 | [diff] [blame] | 153 | return; |
Nicolas Geoffray | f583e59 | 2014-04-07 13:20:42 +0100 | [diff] [blame] | 154 | } |
| 155 | |
| 156 | graph_->SetNumberOfInVRegs(number_of_parameters); |
| 157 | const char* shorty = dex_compilation_unit_->GetShorty(); |
| 158 | int locals_index = locals_.Size() - number_of_parameters; |
Nicolas Geoffray | f583e59 | 2014-04-07 13:20:42 +0100 | [diff] [blame] | 159 | int parameter_index = 0; |
| 160 | |
| 161 | if (!dex_compilation_unit_->IsStatic()) { |
| 162 | // Add the implicit 'this' argument, not expressed in the signature. |
Nicolas Geoffray | 01bc96d | 2014-04-11 17:43:50 +0100 | [diff] [blame] | 163 | HParameterValue* parameter = |
Calin Juravle | 10e244f | 2015-01-26 18:54:32 +0000 | [diff] [blame] | 164 | new (arena_) HParameterValue(parameter_index++, Primitive::kPrimNot, true); |
Nicolas Geoffray | b55f835 | 2014-04-07 15:26:35 +0100 | [diff] [blame] | 165 | entry_block_->AddInstruction(parameter); |
Nicolas Geoffray | f583e59 | 2014-04-07 13:20:42 +0100 | [diff] [blame] | 166 | HLocal* local = GetLocalAt(locals_index++); |
Nicolas Geoffray | b55f835 | 2014-04-07 15:26:35 +0100 | [diff] [blame] | 167 | entry_block_->AddInstruction(new (arena_) HStoreLocal(local, parameter)); |
Nicolas Geoffray | f583e59 | 2014-04-07 13:20:42 +0100 | [diff] [blame] | 168 | number_of_parameters--; |
| 169 | } |
| 170 | |
| 171 | uint32_t pos = 1; |
| 172 | for (int i = 0; i < number_of_parameters; i++) { |
Nicolas Geoffray | 7fb49da | 2014-10-06 09:12:41 +0100 | [diff] [blame] | 173 | HParameterValue* parameter = |
| 174 | new (arena_) HParameterValue(parameter_index++, Primitive::GetType(shorty[pos++])); |
| 175 | entry_block_->AddInstruction(parameter); |
| 176 | HLocal* local = GetLocalAt(locals_index++); |
| 177 | // Store the parameter value in the local that the dex code will use |
| 178 | // to reference that parameter. |
| 179 | entry_block_->AddInstruction(new (arena_) HStoreLocal(local, parameter)); |
| 180 | bool is_wide = (parameter->GetType() == Primitive::kPrimLong) |
| 181 | || (parameter->GetType() == Primitive::kPrimDouble); |
| 182 | if (is_wide) { |
| 183 | i++; |
| 184 | locals_index++; |
| 185 | parameter_index++; |
Nicolas Geoffray | f583e59 | 2014-04-07 13:20:42 +0100 | [diff] [blame] | 186 | } |
| 187 | } |
Nicolas Geoffray | f583e59 | 2014-04-07 13:20:42 +0100 | [diff] [blame] | 188 | } |
| 189 | |
Nicolas Geoffray | b55f835 | 2014-04-07 15:26:35 +0100 | [diff] [blame] | 190 | template<typename T> |
Calin Juravle | 225ff81 | 2014-11-13 16:46:39 +0000 | [diff] [blame] | 191 | void HGraphBuilder::If_22t(const Instruction& instruction, uint32_t dex_pc) { |
Nicolas Geoffray | fbc695f | 2014-09-15 15:33:30 +0000 | [diff] [blame] | 192 | int32_t target_offset = instruction.GetTargetOffset(); |
David Brazdil | 852eaff | 2015-02-02 15:23:05 +0000 | [diff] [blame] | 193 | HBasicBlock* branch_target = FindBlockStartingAt(dex_pc + target_offset); |
| 194 | HBasicBlock* fallthrough_target = FindBlockStartingAt(dex_pc + instruction.SizeInCodeUnits()); |
| 195 | DCHECK(branch_target != nullptr); |
| 196 | DCHECK(fallthrough_target != nullptr); |
| 197 | PotentiallyAddSuspendCheck(branch_target, dex_pc); |
Nicolas Geoffray | 01bc96d | 2014-04-11 17:43:50 +0100 | [diff] [blame] | 198 | HInstruction* first = LoadLocal(instruction.VRegA(), Primitive::kPrimInt); |
| 199 | HInstruction* second = LoadLocal(instruction.VRegB(), Primitive::kPrimInt); |
Dave Allison | 20dfc79 | 2014-06-16 20:44:29 -0700 | [diff] [blame] | 200 | T* comparison = new (arena_) T(first, second); |
| 201 | current_block_->AddInstruction(comparison); |
| 202 | HInstruction* ifinst = new (arena_) HIf(comparison); |
| 203 | current_block_->AddInstruction(ifinst); |
David Brazdil | 852eaff | 2015-02-02 15:23:05 +0000 | [diff] [blame] | 204 | current_block_->AddSuccessor(branch_target); |
| 205 | current_block_->AddSuccessor(fallthrough_target); |
Dave Allison | 20dfc79 | 2014-06-16 20:44:29 -0700 | [diff] [blame] | 206 | current_block_ = nullptr; |
| 207 | } |
| 208 | |
| 209 | template<typename T> |
Calin Juravle | 225ff81 | 2014-11-13 16:46:39 +0000 | [diff] [blame] | 210 | void HGraphBuilder::If_21t(const Instruction& instruction, uint32_t dex_pc) { |
Nicolas Geoffray | fbc695f | 2014-09-15 15:33:30 +0000 | [diff] [blame] | 211 | int32_t target_offset = instruction.GetTargetOffset(); |
David Brazdil | 852eaff | 2015-02-02 15:23:05 +0000 | [diff] [blame] | 212 | HBasicBlock* branch_target = FindBlockStartingAt(dex_pc + target_offset); |
| 213 | HBasicBlock* fallthrough_target = FindBlockStartingAt(dex_pc + instruction.SizeInCodeUnits()); |
| 214 | DCHECK(branch_target != nullptr); |
| 215 | DCHECK(fallthrough_target != nullptr); |
| 216 | PotentiallyAddSuspendCheck(branch_target, dex_pc); |
Dave Allison | 20dfc79 | 2014-06-16 20:44:29 -0700 | [diff] [blame] | 217 | HInstruction* value = LoadLocal(instruction.VRegA(), Primitive::kPrimInt); |
David Brazdil | 8d5b8b2 | 2015-03-24 10:51:52 +0000 | [diff] [blame] | 218 | T* comparison = new (arena_) T(value, graph_->GetIntConstant(0)); |
Dave Allison | 20dfc79 | 2014-06-16 20:44:29 -0700 | [diff] [blame] | 219 | current_block_->AddInstruction(comparison); |
| 220 | HInstruction* ifinst = new (arena_) HIf(comparison); |
| 221 | current_block_->AddInstruction(ifinst); |
David Brazdil | 852eaff | 2015-02-02 15:23:05 +0000 | [diff] [blame] | 222 | current_block_->AddSuccessor(branch_target); |
| 223 | current_block_->AddSuccessor(fallthrough_target); |
Nicolas Geoffray | b55f835 | 2014-04-07 15:26:35 +0100 | [diff] [blame] | 224 | current_block_ = nullptr; |
| 225 | } |
| 226 | |
Calin Juravle | 48c2b03 | 2014-12-09 18:11:36 +0000 | [diff] [blame] | 227 | void HGraphBuilder::MaybeRecordStat(MethodCompilationStat compilation_stat) { |
| 228 | if (compilation_stats_ != nullptr) { |
| 229 | compilation_stats_->RecordStat(compilation_stat); |
| 230 | } |
| 231 | } |
| 232 | |
David Brazdil | 1b49872 | 2015-03-31 11:37:18 +0100 | [diff] [blame] | 233 | bool HGraphBuilder::SkipCompilation(const DexFile::CodeItem& code_item, |
Calin Juravle | 48c2b03 | 2014-12-09 18:11:36 +0000 | [diff] [blame] | 234 | size_t number_of_branches) { |
| 235 | const CompilerOptions& compiler_options = compiler_driver_->GetCompilerOptions(); |
Nicolas Geoffray | 43a539f | 2014-12-02 10:19:51 +0000 | [diff] [blame] | 236 | CompilerOptions::CompilerFilter compiler_filter = compiler_options.GetCompilerFilter(); |
| 237 | if (compiler_filter == CompilerOptions::kEverything) { |
| 238 | return false; |
| 239 | } |
| 240 | |
David Brazdil | 1b49872 | 2015-03-31 11:37:18 +0100 | [diff] [blame] | 241 | if (compiler_options.IsHugeMethod(code_item.insns_size_in_code_units_)) { |
Calin Juravle | 48c2b03 | 2014-12-09 18:11:36 +0000 | [diff] [blame] | 242 | VLOG(compiler) << "Skip compilation of huge method " |
| 243 | << PrettyMethod(dex_compilation_unit_->GetDexMethodIndex(), *dex_file_) |
David Brazdil | 1b49872 | 2015-03-31 11:37:18 +0100 | [diff] [blame] | 244 | << ": " << code_item.insns_size_in_code_units_ << " code units"; |
Calin Juravle | 48c2b03 | 2014-12-09 18:11:36 +0000 | [diff] [blame] | 245 | MaybeRecordStat(MethodCompilationStat::kNotCompiledHugeMethod); |
Nicolas Geoffray | 43a539f | 2014-12-02 10:19:51 +0000 | [diff] [blame] | 246 | return true; |
| 247 | } |
| 248 | |
| 249 | // If it's large and contains no branches, it's likely to be machine generated initialization. |
David Brazdil | 1b49872 | 2015-03-31 11:37:18 +0100 | [diff] [blame] | 250 | if (compiler_options.IsLargeMethod(code_item.insns_size_in_code_units_) |
| 251 | && (number_of_branches == 0)) { |
Calin Juravle | 48c2b03 | 2014-12-09 18:11:36 +0000 | [diff] [blame] | 252 | VLOG(compiler) << "Skip compilation of large method with no branch " |
| 253 | << PrettyMethod(dex_compilation_unit_->GetDexMethodIndex(), *dex_file_) |
David Brazdil | 1b49872 | 2015-03-31 11:37:18 +0100 | [diff] [blame] | 254 | << ": " << code_item.insns_size_in_code_units_ << " code units"; |
Calin Juravle | 48c2b03 | 2014-12-09 18:11:36 +0000 | [diff] [blame] | 255 | MaybeRecordStat(MethodCompilationStat::kNotCompiledLargeMethodNoBranches); |
Nicolas Geoffray | 43a539f | 2014-12-02 10:19:51 +0000 | [diff] [blame] | 256 | return true; |
| 257 | } |
| 258 | |
| 259 | return false; |
| 260 | } |
| 261 | |
David Brazdil | fc6a86a | 2015-06-26 10:33:45 +0000 | [diff] [blame] | 262 | bool HGraphBuilder::IsBlockInPcRange(HBasicBlock* block, |
| 263 | uint32_t dex_pc_start, |
| 264 | uint32_t dex_pc_end) { |
| 265 | uint32_t dex_pc = block->GetDexPc(); |
| 266 | return block != entry_block_ |
| 267 | && block != exit_block_ |
| 268 | && dex_pc >= dex_pc_start |
| 269 | && dex_pc < dex_pc_end; |
| 270 | } |
| 271 | |
| 272 | void HGraphBuilder::CreateBlocksForTryCatch(const DexFile::CodeItem& code_item) { |
| 273 | if (code_item.tries_size_ == 0) { |
| 274 | return; |
| 275 | } |
| 276 | |
| 277 | // Create branch targets at the start/end of the TryItem range. These are |
| 278 | // places where the program might fall through into/out of the a block and |
| 279 | // where TryBoundary instructions will be inserted later. Other edges which |
| 280 | // enter/exit the try blocks are a result of branches/switches. |
| 281 | for (size_t idx = 0; idx < code_item.tries_size_; ++idx) { |
| 282 | const DexFile::TryItem* try_item = DexFile::GetTryItems(code_item, idx); |
| 283 | uint32_t dex_pc_start = try_item->start_addr_; |
| 284 | uint32_t dex_pc_end = dex_pc_start + try_item->insn_count_; |
| 285 | FindOrCreateBlockStartingAt(dex_pc_start); |
| 286 | if (dex_pc_end < code_item.insns_size_in_code_units_) { |
| 287 | // TODO: Do not create block if the last instruction cannot fall through. |
| 288 | FindOrCreateBlockStartingAt(dex_pc_end); |
| 289 | } else { |
| 290 | // The TryItem spans until the very end of the CodeItem (or beyond if |
| 291 | // invalid) and therefore cannot have any code afterwards. |
| 292 | } |
| 293 | } |
| 294 | |
| 295 | // Create branch targets for exception handlers. |
| 296 | const uint8_t* handlers_ptr = DexFile::GetCatchHandlerData(code_item, 0); |
| 297 | uint32_t handlers_size = DecodeUnsignedLeb128(&handlers_ptr); |
| 298 | for (uint32_t idx = 0; idx < handlers_size; ++idx) { |
| 299 | CatchHandlerIterator iterator(handlers_ptr); |
| 300 | for (; iterator.HasNext(); iterator.Next()) { |
| 301 | uint32_t address = iterator.GetHandlerAddress(); |
| 302 | HBasicBlock* block = FindOrCreateBlockStartingAt(address); |
| 303 | block->SetIsCatchBlock(); |
| 304 | } |
| 305 | handlers_ptr = iterator.EndDataPointer(); |
| 306 | } |
| 307 | } |
| 308 | |
David Brazdil | 56e1acc | 2015-06-30 15:41:36 +0100 | [diff] [blame] | 309 | void HGraphBuilder::SplitTryBoundaryEdge(HBasicBlock* predecessor, |
| 310 | HBasicBlock* successor, |
| 311 | HTryBoundary::BoundaryKind kind, |
| 312 | const DexFile::CodeItem& code_item, |
| 313 | const DexFile::TryItem& try_item) { |
| 314 | // Split the edge with a single TryBoundary instruction. |
| 315 | HTryBoundary* try_boundary = new (arena_) HTryBoundary(kind); |
| 316 | HBasicBlock* try_entry_block = graph_->SplitEdge(predecessor, successor); |
| 317 | try_entry_block->AddInstruction(try_boundary); |
| 318 | |
| 319 | // Link the TryBoundary to the handlers of `try_item`. |
| 320 | for (CatchHandlerIterator it(code_item, try_item); it.HasNext(); it.Next()) { |
| 321 | try_boundary->AddExceptionHandler(FindBlockStartingAt(it.GetHandlerAddress())); |
| 322 | } |
| 323 | } |
| 324 | |
David Brazdil | fc6a86a | 2015-06-26 10:33:45 +0000 | [diff] [blame] | 325 | void HGraphBuilder::InsertTryBoundaryBlocks(const DexFile::CodeItem& code_item) { |
| 326 | if (code_item.tries_size_ == 0) { |
| 327 | return; |
| 328 | } |
| 329 | |
| 330 | for (size_t idx = 0; idx < code_item.tries_size_; ++idx) { |
| 331 | const DexFile::TryItem* try_item = DexFile::GetTryItems(code_item, idx); |
| 332 | uint32_t try_start = try_item->start_addr_; |
| 333 | uint32_t try_end = try_start + try_item->insn_count_; |
| 334 | |
| 335 | // Iterate over all blocks in the dex pc range of the TryItem and: |
| 336 | // (a) split edges which enter/exit the try range, |
| 337 | // (b) create TryBoundary instructions in the new blocks, |
| 338 | // (c) link the new blocks to corresponding exception handlers. |
| 339 | for (uint32_t inner_pc = try_start; inner_pc < try_end; ++inner_pc) { |
| 340 | HBasicBlock* try_block = FindBlockStartingAt(inner_pc); |
| 341 | if (try_block == nullptr) { |
| 342 | continue; |
| 343 | } |
| 344 | |
David Brazdil | 56e1acc | 2015-06-30 15:41:36 +0100 | [diff] [blame] | 345 | if (try_block->IsCatchBlock()) { |
| 346 | // Catch blocks are always considered an entry point into the TryItem in |
| 347 | // order to avoid splitting exceptional edges (they might not have been |
| 348 | // created yet). We separate the move-exception (if present) from the |
David Brazdil | 49bace1 | 2015-07-01 15:28:26 +0100 | [diff] [blame] | 349 | // rest of the block and insert a TryBoundary after it, creating a |
| 350 | // landing pad for the exceptional edges. |
| 351 | HInstruction* first_insn = try_block->GetFirstInstruction(); |
| 352 | HInstruction* split_position = nullptr; |
| 353 | if (first_insn->IsLoadException()) { |
| 354 | // Catch block starts with a LoadException. Split the block after the |
| 355 | // StoreLocal that must come after the load. |
| 356 | DCHECK(first_insn->GetNext()->IsStoreLocal()); |
| 357 | split_position = first_insn->GetNext()->GetNext(); |
| 358 | } else { |
| 359 | // Catch block does not obtain the exception. Split at the beginning |
| 360 | // to create an empty catch block. |
| 361 | split_position = first_insn; |
David Brazdil | 56e1acc | 2015-06-30 15:41:36 +0100 | [diff] [blame] | 362 | } |
| 363 | DCHECK(split_position != nullptr); |
| 364 | HBasicBlock* catch_block = try_block; |
| 365 | try_block = catch_block->SplitBefore(split_position); |
| 366 | SplitTryBoundaryEdge(catch_block, try_block, HTryBoundary::kEntry, code_item, *try_item); |
| 367 | } else { |
| 368 | // For non-catch blocks, find predecessors which are not covered by the |
| 369 | // same TryItem range. Such edges enter the try block and will have |
| 370 | // a TryBoundary inserted. |
| 371 | for (size_t i = 0; i < try_block->GetPredecessors().Size(); ++i) { |
| 372 | HBasicBlock* predecessor = try_block->GetPredecessors().Get(i); |
| 373 | if (predecessor->IsSingleTryBoundary()) { |
David Brazdil | fc6a86a | 2015-06-26 10:33:45 +0000 | [diff] [blame] | 374 | // The edge was already split because of an exit from a neighbouring |
David Brazdil | 56e1acc | 2015-06-30 15:41:36 +0100 | [diff] [blame] | 375 | // TryItem. We split it again and insert an entry point. |
| 376 | if (kIsDebugBuild) { |
| 377 | HTryBoundary* last_insn = predecessor->GetLastInstruction()->AsTryBoundary(); |
| 378 | DCHECK(!last_insn->IsEntry()); |
| 379 | DCHECK_EQ(last_insn->GetNormalFlowSuccessor(), try_block); |
| 380 | DCHECK(try_block->IsFirstIndexOfPredecessor(predecessor, i)); |
| 381 | DCHECK(!IsBlockInPcRange(predecessor->GetSinglePredecessor(), try_start, try_end)); |
| 382 | } |
| 383 | } else if (!IsBlockInPcRange(predecessor, try_start, try_end)) { |
| 384 | // This is an entry point into the TryItem and the edge has not been |
| 385 | // split yet. That means that `predecessor` is not in a TryItem, or |
| 386 | // it is in a different TryItem and we happened to iterate over this |
| 387 | // block first. We split the edge and insert an entry point. |
David Brazdil | fc6a86a | 2015-06-26 10:33:45 +0000 | [diff] [blame] | 388 | } else { |
David Brazdil | 56e1acc | 2015-06-30 15:41:36 +0100 | [diff] [blame] | 389 | // Not an edge on the boundary of the try block. |
David Brazdil | fc6a86a | 2015-06-26 10:33:45 +0000 | [diff] [blame] | 390 | continue; |
| 391 | } |
David Brazdil | 56e1acc | 2015-06-30 15:41:36 +0100 | [diff] [blame] | 392 | SplitTryBoundaryEdge(predecessor, try_block, HTryBoundary::kEntry, code_item, *try_item); |
David Brazdil | fc6a86a | 2015-06-26 10:33:45 +0000 | [diff] [blame] | 393 | } |
| 394 | } |
| 395 | |
| 396 | // Find successors which are not covered by the same TryItem range. Such |
| 397 | // edges exit the try block and will have a TryBoundary inserted. |
| 398 | for (size_t i = 0; i < try_block->GetSuccessors().Size(); ++i) { |
| 399 | HBasicBlock* successor = try_block->GetSuccessors().Get(i); |
David Brazdil | 56e1acc | 2015-06-30 15:41:36 +0100 | [diff] [blame] | 400 | if (successor->IsCatchBlock()) { |
| 401 | // A catch block is always considered an entry point into its TryItem. |
| 402 | // We therefore assume this is an exit point, regardless of whether |
| 403 | // the catch block is in a different TryItem or not. |
| 404 | } else if (successor->IsSingleTryBoundary()) { |
David Brazdil | fc6a86a | 2015-06-26 10:33:45 +0000 | [diff] [blame] | 405 | // The edge was already split because of an entry into a neighbouring |
David Brazdil | 56e1acc | 2015-06-30 15:41:36 +0100 | [diff] [blame] | 406 | // TryItem. We split it again and insert an exit. |
| 407 | if (kIsDebugBuild) { |
| 408 | HTryBoundary* last_insn = successor->GetLastInstruction()->AsTryBoundary(); |
| 409 | DCHECK_EQ(try_block, successor->GetSinglePredecessor()); |
| 410 | DCHECK(last_insn->IsEntry()); |
| 411 | DCHECK(!IsBlockInPcRange(last_insn->GetNormalFlowSuccessor(), try_start, try_end)); |
| 412 | } |
David Brazdil | fc6a86a | 2015-06-26 10:33:45 +0000 | [diff] [blame] | 413 | } else if (!IsBlockInPcRange(successor, try_start, try_end)) { |
| 414 | // This is an exit out of the TryItem and the edge has not been split |
| 415 | // yet. That means that either `successor` is not in a TryItem, or it |
| 416 | // is in a different TryItem and we happened to iterate over this |
David Brazdil | 56e1acc | 2015-06-30 15:41:36 +0100 | [diff] [blame] | 417 | // block first. We split the edge and insert an exit. |
David Brazdil | fc6a86a | 2015-06-26 10:33:45 +0000 | [diff] [blame] | 418 | HInstruction* last_instruction = try_block->GetLastInstruction(); |
| 419 | if (last_instruction->IsReturn() || last_instruction->IsReturnVoid()) { |
| 420 | DCHECK_EQ(successor, exit_block_); |
| 421 | // Control flow exits the try block with a Return(Void). Because |
| 422 | // splitting the edge would invalidate the invariant that Return |
| 423 | // always jumps to Exit, we move the Return outside the try block. |
David Brazdil | 56e1acc | 2015-06-30 15:41:36 +0100 | [diff] [blame] | 424 | successor = try_block->SplitBefore(last_instruction); |
David Brazdil | fc6a86a | 2015-06-26 10:33:45 +0000 | [diff] [blame] | 425 | } |
David Brazdil | fc6a86a | 2015-06-26 10:33:45 +0000 | [diff] [blame] | 426 | } else { |
| 427 | // Not an edge on the boundary of the try block. |
| 428 | continue; |
| 429 | } |
David Brazdil | 56e1acc | 2015-06-30 15:41:36 +0100 | [diff] [blame] | 430 | SplitTryBoundaryEdge(try_block, successor, HTryBoundary::kExit, code_item, *try_item); |
David Brazdil | fc6a86a | 2015-06-26 10:33:45 +0000 | [diff] [blame] | 431 | } |
| 432 | } |
| 433 | } |
| 434 | } |
| 435 | |
David Brazdil | 5e8b137 | 2015-01-23 14:39:08 +0000 | [diff] [blame] | 436 | bool HGraphBuilder::BuildGraph(const DexFile::CodeItem& code_item) { |
| 437 | DCHECK(graph_->GetBlocks().IsEmpty()); |
| 438 | |
Nicolas Geoffray | 3ff386a | 2014-03-04 14:46:47 +0000 | [diff] [blame] | 439 | const uint16_t* code_ptr = code_item.insns_; |
| 440 | const uint16_t* code_end = code_item.insns_ + code_item.insns_size_in_code_units_; |
Nicolas Geoffray | a3d05a4 | 2014-10-20 17:41:32 +0100 | [diff] [blame] | 441 | code_start_ = code_ptr; |
Nicolas Geoffray | 3ff386a | 2014-03-04 14:46:47 +0000 | [diff] [blame] | 442 | |
Nicolas Geoffray | be9a92a | 2014-02-25 14:22:56 +0000 | [diff] [blame] | 443 | // Setup the graph with the entry block and exit block. |
Nicolas Geoffray | 3c04974 | 2014-09-24 18:10:46 +0100 | [diff] [blame] | 444 | entry_block_ = new (arena_) HBasicBlock(graph_, 0); |
Nicolas Geoffray | 818f210 | 2014-02-18 16:43:35 +0000 | [diff] [blame] | 445 | graph_->AddBlock(entry_block_); |
Nicolas Geoffray | 3c04974 | 2014-09-24 18:10:46 +0100 | [diff] [blame] | 446 | exit_block_ = new (arena_) HBasicBlock(graph_, kNoDexPc); |
Nicolas Geoffray | 787c307 | 2014-03-17 10:20:19 +0000 | [diff] [blame] | 447 | graph_->SetEntryBlock(entry_block_); |
| 448 | graph_->SetExitBlock(exit_block_); |
Nicolas Geoffray | 818f210 | 2014-02-18 16:43:35 +0000 | [diff] [blame] | 449 | |
Nicolas Geoffray | 3ff386a | 2014-03-04 14:46:47 +0000 | [diff] [blame] | 450 | InitializeLocals(code_item.registers_size_); |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 451 | graph_->SetMaximumNumberOfOutVRegs(code_item.outs_size_); |
Nicolas Geoffray | 3ff386a | 2014-03-04 14:46:47 +0000 | [diff] [blame] | 452 | |
Nicolas Geoffray | 43a539f | 2014-12-02 10:19:51 +0000 | [diff] [blame] | 453 | // Compute the number of dex instructions, blocks, and branches. We will |
| 454 | // check these values against limits given to the compiler. |
Nicolas Geoffray | 43a539f | 2014-12-02 10:19:51 +0000 | [diff] [blame] | 455 | size_t number_of_branches = 0; |
| 456 | |
Nicolas Geoffray | be9a92a | 2014-02-25 14:22:56 +0000 | [diff] [blame] | 457 | // To avoid splitting blocks, we compute ahead of time the instructions that |
| 458 | // start a new block, and create these blocks. |
Calin Juravle | 702d260 | 2015-04-30 19:28:21 +0100 | [diff] [blame] | 459 | if (!ComputeBranchTargets(code_ptr, code_end, &number_of_branches)) { |
| 460 | MaybeRecordStat(MethodCompilationStat::kNotCompiledBranchOutsideMethodCode); |
| 461 | return false; |
| 462 | } |
Nicolas Geoffray | 43a539f | 2014-12-02 10:19:51 +0000 | [diff] [blame] | 463 | |
| 464 | // Note that the compiler driver is null when unit testing. |
David Brazdil | 1b49872 | 2015-03-31 11:37:18 +0100 | [diff] [blame] | 465 | if ((compiler_driver_ != nullptr) && SkipCompilation(code_item, number_of_branches)) { |
David Brazdil | 5e8b137 | 2015-01-23 14:39:08 +0000 | [diff] [blame] | 466 | return false; |
Nicolas Geoffray | 43a539f | 2014-12-02 10:19:51 +0000 | [diff] [blame] | 467 | } |
Nicolas Geoffray | 818f210 | 2014-02-18 16:43:35 +0000 | [diff] [blame] | 468 | |
David Brazdil | fc6a86a | 2015-06-26 10:33:45 +0000 | [diff] [blame] | 469 | CreateBlocksForTryCatch(code_item); |
Nicolas Geoffray | de58ab2 | 2014-11-05 12:46:03 +0000 | [diff] [blame] | 470 | |
Nicolas Geoffray | 52e832b | 2014-11-06 15:15:31 +0000 | [diff] [blame] | 471 | InitializeParameters(code_item.ins_size_); |
Nicolas Geoffray | f583e59 | 2014-04-07 13:20:42 +0100 | [diff] [blame] | 472 | |
Calin Juravle | 225ff81 | 2014-11-13 16:46:39 +0000 | [diff] [blame] | 473 | size_t dex_pc = 0; |
Nicolas Geoffray | 818f210 | 2014-02-18 16:43:35 +0000 | [diff] [blame] | 474 | while (code_ptr < code_end) { |
Calin Juravle | 225ff81 | 2014-11-13 16:46:39 +0000 | [diff] [blame] | 475 | // Update the current block if dex_pc starts a new block. |
| 476 | MaybeUpdateCurrentBlock(dex_pc); |
Nicolas Geoffray | 818f210 | 2014-02-18 16:43:35 +0000 | [diff] [blame] | 477 | const Instruction& instruction = *Instruction::At(code_ptr); |
Calin Juravle | 48c2b03 | 2014-12-09 18:11:36 +0000 | [diff] [blame] | 478 | if (!AnalyzeDexInstruction(instruction, dex_pc)) { |
David Brazdil | 5e8b137 | 2015-01-23 14:39:08 +0000 | [diff] [blame] | 479 | return false; |
Calin Juravle | 48c2b03 | 2014-12-09 18:11:36 +0000 | [diff] [blame] | 480 | } |
Calin Juravle | 225ff81 | 2014-11-13 16:46:39 +0000 | [diff] [blame] | 481 | dex_pc += instruction.SizeInCodeUnits(); |
Nicolas Geoffray | 818f210 | 2014-02-18 16:43:35 +0000 | [diff] [blame] | 482 | code_ptr += instruction.SizeInCodeUnits(); |
| 483 | } |
| 484 | |
David Brazdil | fc6a86a | 2015-06-26 10:33:45 +0000 | [diff] [blame] | 485 | // Add Exit to the exit block. |
David Brazdil | 3e18738 | 2015-06-26 09:59:52 +0000 | [diff] [blame] | 486 | exit_block_->AddInstruction(new (arena_) HExit()); |
Nicolas Geoffray | fbc695f | 2014-09-15 15:33:30 +0000 | [diff] [blame] | 487 | // Add the suspend check to the entry block. |
| 488 | entry_block_->AddInstruction(new (arena_) HSuspendCheck(0)); |
Nicolas Geoffray | 3ff386a | 2014-03-04 14:46:47 +0000 | [diff] [blame] | 489 | entry_block_->AddInstruction(new (arena_) HGoto()); |
David Brazdil | 5e8b137 | 2015-01-23 14:39:08 +0000 | [diff] [blame] | 490 | |
David Brazdil | fc6a86a | 2015-06-26 10:33:45 +0000 | [diff] [blame] | 491 | // Iterate over blocks covered by TryItems and insert TryBoundaries at entry |
| 492 | // and exit points. This requires all control-flow instructions and |
| 493 | // non-exceptional edges to have been created. |
| 494 | InsertTryBoundaryBlocks(code_item); |
| 495 | |
| 496 | // Add the exit block at the end to give it the highest id. |
| 497 | graph_->AddBlock(exit_block_); |
David Brazdil | 5e8b137 | 2015-01-23 14:39:08 +0000 | [diff] [blame] | 498 | return true; |
Nicolas Geoffray | 818f210 | 2014-02-18 16:43:35 +0000 | [diff] [blame] | 499 | } |
| 500 | |
David Brazdil | fc6a86a | 2015-06-26 10:33:45 +0000 | [diff] [blame] | 501 | void HGraphBuilder::MaybeUpdateCurrentBlock(size_t dex_pc) { |
| 502 | HBasicBlock* block = FindBlockStartingAt(dex_pc); |
Nicolas Geoffray | bab4ed7 | 2014-03-11 17:53:17 +0000 | [diff] [blame] | 503 | if (block == nullptr) { |
| 504 | return; |
| 505 | } |
Nicolas Geoffray | be9a92a | 2014-02-25 14:22:56 +0000 | [diff] [blame] | 506 | |
| 507 | if (current_block_ != nullptr) { |
| 508 | // Branching instructions clear current_block, so we know |
| 509 | // the last instruction of the current block is not a branching |
| 510 | // instruction. We add an unconditional goto to the found block. |
| 511 | current_block_->AddInstruction(new (arena_) HGoto()); |
| 512 | current_block_->AddSuccessor(block); |
| 513 | } |
| 514 | graph_->AddBlock(block); |
| 515 | current_block_ = block; |
| 516 | } |
| 517 | |
Calin Juravle | 702d260 | 2015-04-30 19:28:21 +0100 | [diff] [blame] | 518 | bool HGraphBuilder::ComputeBranchTargets(const uint16_t* code_ptr, |
Nicolas Geoffray | 43a539f | 2014-12-02 10:19:51 +0000 | [diff] [blame] | 519 | const uint16_t* code_end, |
Nicolas Geoffray | 43a539f | 2014-12-02 10:19:51 +0000 | [diff] [blame] | 520 | size_t* number_of_branches) { |
Nicolas Geoffray | be9a92a | 2014-02-25 14:22:56 +0000 | [diff] [blame] | 521 | branch_targets_.SetSize(code_end - code_ptr); |
| 522 | |
| 523 | // Create the first block for the dex instructions, single successor of the entry block. |
Nicolas Geoffray | 3c04974 | 2014-09-24 18:10:46 +0100 | [diff] [blame] | 524 | HBasicBlock* block = new (arena_) HBasicBlock(graph_, 0); |
Nicolas Geoffray | be9a92a | 2014-02-25 14:22:56 +0000 | [diff] [blame] | 525 | branch_targets_.Put(0, block); |
| 526 | entry_block_->AddSuccessor(block); |
| 527 | |
| 528 | // Iterate over all instructions and find branching instructions. Create blocks for |
| 529 | // the locations these instructions branch to. |
Andreas Gampe | d881df5 | 2014-11-24 23:28:39 -0800 | [diff] [blame] | 530 | uint32_t dex_pc = 0; |
Nicolas Geoffray | be9a92a | 2014-02-25 14:22:56 +0000 | [diff] [blame] | 531 | while (code_ptr < code_end) { |
| 532 | const Instruction& instruction = *Instruction::At(code_ptr); |
| 533 | if (instruction.IsBranch()) { |
Nicolas Geoffray | 43a539f | 2014-12-02 10:19:51 +0000 | [diff] [blame] | 534 | (*number_of_branches)++; |
Calin Juravle | 225ff81 | 2014-11-13 16:46:39 +0000 | [diff] [blame] | 535 | int32_t target = instruction.GetTargetOffset() + dex_pc; |
Nicolas Geoffray | be9a92a | 2014-02-25 14:22:56 +0000 | [diff] [blame] | 536 | // Create a block for the target instruction. |
David Brazdil | fc6a86a | 2015-06-26 10:33:45 +0000 | [diff] [blame] | 537 | FindOrCreateBlockStartingAt(target); |
| 538 | |
Calin Juravle | 225ff81 | 2014-11-13 16:46:39 +0000 | [diff] [blame] | 539 | dex_pc += instruction.SizeInCodeUnits(); |
Nicolas Geoffray | be9a92a | 2014-02-25 14:22:56 +0000 | [diff] [blame] | 540 | code_ptr += instruction.SizeInCodeUnits(); |
Calin Juravle | 702d260 | 2015-04-30 19:28:21 +0100 | [diff] [blame] | 541 | |
David Brazdil | fe65946 | 2015-06-24 14:23:56 +0100 | [diff] [blame] | 542 | if (instruction.CanFlowThrough()) { |
| 543 | if (code_ptr >= code_end) { |
Calin Juravle | 702d260 | 2015-04-30 19:28:21 +0100 | [diff] [blame] | 544 | // In the normal case we should never hit this but someone can artificially forge a dex |
| 545 | // file to fall-through out the method code. In this case we bail out compilation. |
| 546 | return false; |
David Brazdil | fc6a86a | 2015-06-26 10:33:45 +0000 | [diff] [blame] | 547 | } else { |
| 548 | FindOrCreateBlockStartingAt(dex_pc); |
Calin Juravle | 702d260 | 2015-04-30 19:28:21 +0100 | [diff] [blame] | 549 | } |
Nicolas Geoffray | be9a92a | 2014-02-25 14:22:56 +0000 | [diff] [blame] | 550 | } |
Andreas Gampe | e4d4d32 | 2014-12-04 09:09:57 -0800 | [diff] [blame] | 551 | } else if (instruction.IsSwitch()) { |
| 552 | SwitchTable table(instruction, dex_pc, instruction.Opcode() == Instruction::SPARSE_SWITCH); |
Andreas Gampe | d881df5 | 2014-11-24 23:28:39 -0800 | [diff] [blame] | 553 | |
| 554 | uint16_t num_entries = table.GetNumEntries(); |
| 555 | |
Andreas Gampe | e4d4d32 | 2014-12-04 09:09:57 -0800 | [diff] [blame] | 556 | // In a packed-switch, the entry at index 0 is the starting key. In a sparse-switch, the |
| 557 | // entry at index 0 is the first key, and values are after *all* keys. |
| 558 | size_t offset = table.GetFirstValueIndex(); |
| 559 | |
| 560 | // Use a larger loop counter type to avoid overflow issues. |
| 561 | for (size_t i = 0; i < num_entries; ++i) { |
Andreas Gampe | d881df5 | 2014-11-24 23:28:39 -0800 | [diff] [blame] | 562 | // The target of the case. |
Andreas Gampe | e4d4d32 | 2014-12-04 09:09:57 -0800 | [diff] [blame] | 563 | uint32_t target = dex_pc + table.GetEntryAt(i + offset); |
David Brazdil | fc6a86a | 2015-06-26 10:33:45 +0000 | [diff] [blame] | 564 | FindOrCreateBlockStartingAt(target); |
Andreas Gampe | d881df5 | 2014-11-24 23:28:39 -0800 | [diff] [blame] | 565 | |
| 566 | // The next case gets its own block. |
| 567 | if (i < num_entries) { |
| 568 | block = new (arena_) HBasicBlock(graph_, target); |
| 569 | branch_targets_.Put(table.GetDexPcForIndex(i), block); |
Andreas Gampe | d881df5 | 2014-11-24 23:28:39 -0800 | [diff] [blame] | 570 | } |
| 571 | } |
| 572 | |
| 573 | // Fall-through. Add a block if there is more code afterwards. |
| 574 | dex_pc += instruction.SizeInCodeUnits(); |
| 575 | code_ptr += instruction.SizeInCodeUnits(); |
Calin Juravle | 702d260 | 2015-04-30 19:28:21 +0100 | [diff] [blame] | 576 | if (code_ptr >= code_end) { |
| 577 | // In the normal case we should never hit this but someone can artificially forge a dex |
| 578 | // file to fall-through out the method code. In this case we bail out compilation. |
| 579 | // (A switch can fall-through so we don't need to check CanFlowThrough().) |
| 580 | return false; |
David Brazdil | fc6a86a | 2015-06-26 10:33:45 +0000 | [diff] [blame] | 581 | } else { |
| 582 | FindOrCreateBlockStartingAt(dex_pc); |
Andreas Gampe | d881df5 | 2014-11-24 23:28:39 -0800 | [diff] [blame] | 583 | } |
Nicolas Geoffray | be9a92a | 2014-02-25 14:22:56 +0000 | [diff] [blame] | 584 | } else { |
| 585 | code_ptr += instruction.SizeInCodeUnits(); |
Calin Juravle | 225ff81 | 2014-11-13 16:46:39 +0000 | [diff] [blame] | 586 | dex_pc += instruction.SizeInCodeUnits(); |
Nicolas Geoffray | be9a92a | 2014-02-25 14:22:56 +0000 | [diff] [blame] | 587 | } |
| 588 | } |
Calin Juravle | 702d260 | 2015-04-30 19:28:21 +0100 | [diff] [blame] | 589 | return true; |
Nicolas Geoffray | be9a92a | 2014-02-25 14:22:56 +0000 | [diff] [blame] | 590 | } |
| 591 | |
David Brazdil | fc6a86a | 2015-06-26 10:33:45 +0000 | [diff] [blame] | 592 | HBasicBlock* HGraphBuilder::FindBlockStartingAt(int32_t dex_pc) const { |
| 593 | DCHECK_GE(dex_pc, 0); |
| 594 | DCHECK_LT(static_cast<size_t>(dex_pc), branch_targets_.Size()); |
| 595 | return branch_targets_.Get(dex_pc); |
| 596 | } |
| 597 | |
| 598 | HBasicBlock* HGraphBuilder::FindOrCreateBlockStartingAt(int32_t dex_pc) { |
| 599 | HBasicBlock* block = FindBlockStartingAt(dex_pc); |
| 600 | if (block == nullptr) { |
| 601 | block = new (arena_) HBasicBlock(graph_, dex_pc); |
| 602 | branch_targets_.Put(dex_pc, block); |
| 603 | } |
| 604 | return block; |
Nicolas Geoffray | be9a92a | 2014-02-25 14:22:56 +0000 | [diff] [blame] | 605 | } |
| 606 | |
Nicolas Geoffray | f583e59 | 2014-04-07 13:20:42 +0100 | [diff] [blame] | 607 | template<typename T> |
Roland Levillain | 88cb175 | 2014-10-20 16:36:47 +0100 | [diff] [blame] | 608 | void HGraphBuilder::Unop_12x(const Instruction& instruction, Primitive::Type type) { |
| 609 | HInstruction* first = LoadLocal(instruction.VRegB(), type); |
| 610 | current_block_->AddInstruction(new (arena_) T(type, first)); |
| 611 | UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction()); |
| 612 | } |
| 613 | |
Roland Levillain | dff1f28 | 2014-11-05 14:15:05 +0000 | [diff] [blame] | 614 | void HGraphBuilder::Conversion_12x(const Instruction& instruction, |
| 615 | Primitive::Type input_type, |
Roland Levillain | 624279f | 2014-12-04 11:54:28 +0000 | [diff] [blame] | 616 | Primitive::Type result_type, |
| 617 | uint32_t dex_pc) { |
Roland Levillain | dff1f28 | 2014-11-05 14:15:05 +0000 | [diff] [blame] | 618 | HInstruction* first = LoadLocal(instruction.VRegB(), input_type); |
Roland Levillain | 624279f | 2014-12-04 11:54:28 +0000 | [diff] [blame] | 619 | current_block_->AddInstruction(new (arena_) HTypeConversion(result_type, first, dex_pc)); |
Roland Levillain | dff1f28 | 2014-11-05 14:15:05 +0000 | [diff] [blame] | 620 | UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction()); |
| 621 | } |
| 622 | |
Roland Levillain | 88cb175 | 2014-10-20 16:36:47 +0100 | [diff] [blame] | 623 | template<typename T> |
Nicolas Geoffray | 412f10c | 2014-06-19 10:00:34 +0100 | [diff] [blame] | 624 | void HGraphBuilder::Binop_23x(const Instruction& instruction, Primitive::Type type) { |
Nicolas Geoffray | 01bc96d | 2014-04-11 17:43:50 +0100 | [diff] [blame] | 625 | HInstruction* first = LoadLocal(instruction.VRegB(), type); |
| 626 | HInstruction* second = LoadLocal(instruction.VRegC(), type); |
| 627 | current_block_->AddInstruction(new (arena_) T(type, first, second)); |
Nicolas Geoffray | f583e59 | 2014-04-07 13:20:42 +0100 | [diff] [blame] | 628 | UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction()); |
| 629 | } |
| 630 | |
| 631 | template<typename T> |
Calin Juravle | d6fb6cf | 2014-11-11 19:07:44 +0000 | [diff] [blame] | 632 | void HGraphBuilder::Binop_23x(const Instruction& instruction, |
| 633 | Primitive::Type type, |
| 634 | uint32_t dex_pc) { |
| 635 | HInstruction* first = LoadLocal(instruction.VRegB(), type); |
| 636 | HInstruction* second = LoadLocal(instruction.VRegC(), type); |
| 637 | current_block_->AddInstruction(new (arena_) T(type, first, second, dex_pc)); |
| 638 | UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction()); |
| 639 | } |
| 640 | |
| 641 | template<typename T> |
Calin Juravle | 9aec02f | 2014-11-18 23:06:35 +0000 | [diff] [blame] | 642 | void HGraphBuilder::Binop_23x_shift(const Instruction& instruction, |
| 643 | Primitive::Type type) { |
| 644 | HInstruction* first = LoadLocal(instruction.VRegB(), type); |
| 645 | HInstruction* second = LoadLocal(instruction.VRegC(), Primitive::kPrimInt); |
| 646 | current_block_->AddInstruction(new (arena_) T(type, first, second)); |
| 647 | UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction()); |
| 648 | } |
| 649 | |
Calin Juravle | ddb7df2 | 2014-11-25 20:56:51 +0000 | [diff] [blame] | 650 | void HGraphBuilder::Binop_23x_cmp(const Instruction& instruction, |
| 651 | Primitive::Type type, |
Alexey Frunze | 4dda337 | 2015-06-01 18:31:49 -0700 | [diff] [blame] | 652 | HCompare::Bias bias, |
| 653 | uint32_t dex_pc) { |
Calin Juravle | ddb7df2 | 2014-11-25 20:56:51 +0000 | [diff] [blame] | 654 | HInstruction* first = LoadLocal(instruction.VRegB(), type); |
| 655 | HInstruction* second = LoadLocal(instruction.VRegC(), type); |
Alexey Frunze | 4dda337 | 2015-06-01 18:31:49 -0700 | [diff] [blame] | 656 | current_block_->AddInstruction(new (arena_) HCompare(type, first, second, bias, dex_pc)); |
Calin Juravle | ddb7df2 | 2014-11-25 20:56:51 +0000 | [diff] [blame] | 657 | UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction()); |
| 658 | } |
| 659 | |
Calin Juravle | 9aec02f | 2014-11-18 23:06:35 +0000 | [diff] [blame] | 660 | template<typename T> |
Nicolas Geoffray | 01bc96d | 2014-04-11 17:43:50 +0100 | [diff] [blame] | 661 | void HGraphBuilder::Binop_12x(const Instruction& instruction, Primitive::Type type) { |
| 662 | HInstruction* first = LoadLocal(instruction.VRegA(), type); |
| 663 | HInstruction* second = LoadLocal(instruction.VRegB(), type); |
| 664 | current_block_->AddInstruction(new (arena_) T(type, first, second)); |
Nicolas Geoffray | f583e59 | 2014-04-07 13:20:42 +0100 | [diff] [blame] | 665 | UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction()); |
| 666 | } |
| 667 | |
| 668 | template<typename T> |
Calin Juravle | 9aec02f | 2014-11-18 23:06:35 +0000 | [diff] [blame] | 669 | void HGraphBuilder::Binop_12x_shift(const Instruction& instruction, Primitive::Type type) { |
| 670 | HInstruction* first = LoadLocal(instruction.VRegA(), type); |
| 671 | HInstruction* second = LoadLocal(instruction.VRegB(), Primitive::kPrimInt); |
| 672 | current_block_->AddInstruction(new (arena_) T(type, first, second)); |
| 673 | UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction()); |
| 674 | } |
| 675 | |
| 676 | template<typename T> |
Calin Juravle | d6fb6cf | 2014-11-11 19:07:44 +0000 | [diff] [blame] | 677 | void HGraphBuilder::Binop_12x(const Instruction& instruction, |
| 678 | Primitive::Type type, |
| 679 | uint32_t dex_pc) { |
| 680 | HInstruction* first = LoadLocal(instruction.VRegA(), type); |
| 681 | HInstruction* second = LoadLocal(instruction.VRegB(), type); |
| 682 | current_block_->AddInstruction(new (arena_) T(type, first, second, dex_pc)); |
| 683 | UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction()); |
| 684 | } |
| 685 | |
| 686 | template<typename T> |
Nicolas Geoffray | f583e59 | 2014-04-07 13:20:42 +0100 | [diff] [blame] | 687 | void HGraphBuilder::Binop_22s(const Instruction& instruction, bool reverse) { |
Nicolas Geoffray | 01bc96d | 2014-04-11 17:43:50 +0100 | [diff] [blame] | 688 | HInstruction* first = LoadLocal(instruction.VRegB(), Primitive::kPrimInt); |
David Brazdil | 8d5b8b2 | 2015-03-24 10:51:52 +0000 | [diff] [blame] | 689 | HInstruction* second = graph_->GetIntConstant(instruction.VRegC_22s()); |
Nicolas Geoffray | f583e59 | 2014-04-07 13:20:42 +0100 | [diff] [blame] | 690 | if (reverse) { |
| 691 | std::swap(first, second); |
| 692 | } |
| 693 | current_block_->AddInstruction(new (arena_) T(Primitive::kPrimInt, first, second)); |
| 694 | UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction()); |
| 695 | } |
| 696 | |
| 697 | template<typename T> |
| 698 | void HGraphBuilder::Binop_22b(const Instruction& instruction, bool reverse) { |
Nicolas Geoffray | 01bc96d | 2014-04-11 17:43:50 +0100 | [diff] [blame] | 699 | HInstruction* first = LoadLocal(instruction.VRegB(), Primitive::kPrimInt); |
David Brazdil | 8d5b8b2 | 2015-03-24 10:51:52 +0000 | [diff] [blame] | 700 | HInstruction* second = graph_->GetIntConstant(instruction.VRegC_22b()); |
Nicolas Geoffray | f583e59 | 2014-04-07 13:20:42 +0100 | [diff] [blame] | 701 | if (reverse) { |
| 702 | std::swap(first, second); |
| 703 | } |
| 704 | current_block_->AddInstruction(new (arena_) T(Primitive::kPrimInt, first, second)); |
| 705 | UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction()); |
| 706 | } |
| 707 | |
Calin Juravle | 0c25d10 | 2015-04-20 14:49:09 +0100 | [diff] [blame] | 708 | static bool RequiresConstructorBarrier(const DexCompilationUnit* cu, const CompilerDriver& driver) { |
Calin Juravle | 27df758 | 2015-04-17 19:12:31 +0100 | [diff] [blame] | 709 | Thread* self = Thread::Current(); |
Calin Juravle | 0c25d10 | 2015-04-20 14:49:09 +0100 | [diff] [blame] | 710 | return cu->IsConstructor() |
| 711 | && driver.RequiresConstructorBarrier(self, cu->GetDexFile(), cu->GetClassDefIndex()); |
Calin Juravle | 27df758 | 2015-04-17 19:12:31 +0100 | [diff] [blame] | 712 | } |
| 713 | |
Nicolas Geoffray | 01bc96d | 2014-04-11 17:43:50 +0100 | [diff] [blame] | 714 | void HGraphBuilder::BuildReturn(const Instruction& instruction, Primitive::Type type) { |
| 715 | if (type == Primitive::kPrimVoid) { |
Calin Juravle | 3cd4fc8 | 2015-05-14 15:15:42 +0100 | [diff] [blame] | 716 | if (graph_->ShouldGenerateConstructorBarrier()) { |
| 717 | // The compilation unit is null during testing. |
| 718 | if (dex_compilation_unit_ != nullptr) { |
| 719 | DCHECK(RequiresConstructorBarrier(dex_compilation_unit_, *compiler_driver_)) |
| 720 | << "Inconsistent use of ShouldGenerateConstructorBarrier. Should not generate a barrier."; |
| 721 | } |
Calin Juravle | 27df758 | 2015-04-17 19:12:31 +0100 | [diff] [blame] | 722 | current_block_->AddInstruction(new (arena_) HMemoryBarrier(kStoreStore)); |
| 723 | } |
Nicolas Geoffray | 01bc96d | 2014-04-11 17:43:50 +0100 | [diff] [blame] | 724 | current_block_->AddInstruction(new (arena_) HReturnVoid()); |
| 725 | } else { |
| 726 | HInstruction* value = LoadLocal(instruction.VRegA(), type); |
| 727 | current_block_->AddInstruction(new (arena_) HReturn(value)); |
| 728 | } |
| 729 | current_block_->AddSuccessor(exit_block_); |
| 730 | current_block_ = nullptr; |
| 731 | } |
| 732 | |
| 733 | bool HGraphBuilder::BuildInvoke(const Instruction& instruction, |
Calin Juravle | 225ff81 | 2014-11-13 16:46:39 +0000 | [diff] [blame] | 734 | uint32_t dex_pc, |
Nicolas Geoffray | 01bc96d | 2014-04-11 17:43:50 +0100 | [diff] [blame] | 735 | uint32_t method_idx, |
| 736 | uint32_t number_of_vreg_arguments, |
| 737 | bool is_range, |
| 738 | uint32_t* args, |
| 739 | uint32_t register_index) { |
Nicolas Geoffray | e982f0b | 2014-08-13 02:11:24 +0100 | [diff] [blame] | 740 | Instruction::Code opcode = instruction.Opcode(); |
| 741 | InvokeType invoke_type; |
| 742 | switch (opcode) { |
| 743 | case Instruction::INVOKE_STATIC: |
| 744 | case Instruction::INVOKE_STATIC_RANGE: |
| 745 | invoke_type = kStatic; |
| 746 | break; |
| 747 | case Instruction::INVOKE_DIRECT: |
| 748 | case Instruction::INVOKE_DIRECT_RANGE: |
| 749 | invoke_type = kDirect; |
| 750 | break; |
| 751 | case Instruction::INVOKE_VIRTUAL: |
| 752 | case Instruction::INVOKE_VIRTUAL_RANGE: |
| 753 | invoke_type = kVirtual; |
| 754 | break; |
| 755 | case Instruction::INVOKE_INTERFACE: |
| 756 | case Instruction::INVOKE_INTERFACE_RANGE: |
| 757 | invoke_type = kInterface; |
| 758 | break; |
| 759 | case Instruction::INVOKE_SUPER_RANGE: |
| 760 | case Instruction::INVOKE_SUPER: |
| 761 | invoke_type = kSuper; |
| 762 | break; |
| 763 | default: |
| 764 | LOG(FATAL) << "Unexpected invoke op: " << opcode; |
| 765 | return false; |
| 766 | } |
| 767 | |
Nicolas Geoffray | 01bc96d | 2014-04-11 17:43:50 +0100 | [diff] [blame] | 768 | const DexFile::MethodId& method_id = dex_file_->GetMethodId(method_idx); |
| 769 | const DexFile::ProtoId& proto_id = dex_file_->GetProtoId(method_id.proto_idx_); |
| 770 | const char* descriptor = dex_file_->StringDataByIdx(proto_id.shorty_idx_); |
| 771 | Primitive::Type return_type = Primitive::GetType(descriptor[0]); |
Nicolas Geoffray | e982f0b | 2014-08-13 02:11:24 +0100 | [diff] [blame] | 772 | bool is_instance_call = invoke_type != kStatic; |
Nicolas Geoffray | 2e33525 | 2015-06-18 11:11:27 +0100 | [diff] [blame] | 773 | // Remove the return type from the 'proto'. |
| 774 | size_t number_of_arguments = strlen(descriptor) - 1; |
| 775 | if (is_instance_call) { |
| 776 | // One extra argument for 'this'. |
| 777 | ++number_of_arguments; |
| 778 | } |
Nicolas Geoffray | 01bc96d | 2014-04-11 17:43:50 +0100 | [diff] [blame] | 779 | |
Calin Juravle | c7c8fe2 | 2014-12-02 11:42:34 +0000 | [diff] [blame] | 780 | MethodReference target_method(dex_file_, method_idx); |
| 781 | uintptr_t direct_code; |
| 782 | uintptr_t direct_method; |
| 783 | int table_index; |
| 784 | InvokeType optimized_invoke_type = invoke_type; |
Nicolas Geoffray | 52839d1 | 2014-11-07 17:47:25 +0000 | [diff] [blame] | 785 | |
Calin Juravle | c7c8fe2 | 2014-12-02 11:42:34 +0000 | [diff] [blame] | 786 | if (!compiler_driver_->ComputeInvokeInfo(dex_compilation_unit_, dex_pc, true, true, |
| 787 | &optimized_invoke_type, &target_method, &table_index, |
| 788 | &direct_code, &direct_method)) { |
Nicolas Geoffray | 2e33525 | 2015-06-18 11:11:27 +0100 | [diff] [blame] | 789 | VLOG(compiler) << "Did not compile " |
| 790 | << PrettyMethod(dex_compilation_unit_->GetDexMethodIndex(), *dex_file_) |
Calin Juravle | 48c2b03 | 2014-12-09 18:11:36 +0000 | [diff] [blame] | 791 | << " because a method call could not be resolved"; |
| 792 | MaybeRecordStat(MethodCompilationStat::kNotCompiledUnresolvedMethod); |
Calin Juravle | c7c8fe2 | 2014-12-02 11:42:34 +0000 | [diff] [blame] | 793 | return false; |
| 794 | } |
| 795 | DCHECK(optimized_invoke_type != kSuper); |
| 796 | |
Roland Levillain | 4c0eb42 | 2015-04-24 16:43:49 +0100 | [diff] [blame] | 797 | // By default, consider that the called method implicitly requires |
| 798 | // an initialization check of its declaring method. |
| 799 | HInvokeStaticOrDirect::ClinitCheckRequirement clinit_check_requirement = |
| 800 | HInvokeStaticOrDirect::ClinitCheckRequirement::kImplicit; |
| 801 | // Potential class initialization check, in the case of a static method call. |
| 802 | HClinitCheck* clinit_check = nullptr; |
Jeff Hao | 848f70a | 2014-01-15 13:49:50 -0800 | [diff] [blame] | 803 | // Replace calls to String.<init> with StringFactory. |
| 804 | int32_t string_init_offset = 0; |
| 805 | bool is_string_init = compiler_driver_->IsStringInit(method_idx, dex_file_, &string_init_offset); |
| 806 | if (is_string_init) { |
| 807 | return_type = Primitive::kPrimNot; |
| 808 | is_instance_call = false; |
| 809 | number_of_arguments--; |
| 810 | invoke_type = kStatic; |
| 811 | optimized_invoke_type = kStatic; |
| 812 | } |
Roland Levillain | 4c0eb42 | 2015-04-24 16:43:49 +0100 | [diff] [blame] | 813 | |
Calin Juravle | c7c8fe2 | 2014-12-02 11:42:34 +0000 | [diff] [blame] | 814 | HInvoke* invoke = nullptr; |
Roland Levillain | 4c0eb42 | 2015-04-24 16:43:49 +0100 | [diff] [blame] | 815 | |
Calin Juravle | c7c8fe2 | 2014-12-02 11:42:34 +0000 | [diff] [blame] | 816 | if (optimized_invoke_type == kVirtual) { |
| 817 | invoke = new (arena_) HInvokeVirtual( |
Andreas Gampe | 71fb52f | 2014-12-29 17:43:08 -0800 | [diff] [blame] | 818 | arena_, number_of_arguments, return_type, dex_pc, method_idx, table_index); |
Calin Juravle | c7c8fe2 | 2014-12-02 11:42:34 +0000 | [diff] [blame] | 819 | } else if (optimized_invoke_type == kInterface) { |
| 820 | invoke = new (arena_) HInvokeInterface( |
| 821 | arena_, number_of_arguments, return_type, dex_pc, method_idx, table_index); |
Nicolas Geoffray | e982f0b | 2014-08-13 02:11:24 +0100 | [diff] [blame] | 822 | } else { |
Calin Juravle | c7c8fe2 | 2014-12-02 11:42:34 +0000 | [diff] [blame] | 823 | DCHECK(optimized_invoke_type == kDirect || optimized_invoke_type == kStatic); |
| 824 | // Sharpening to kDirect only works if we compile PIC. |
| 825 | DCHECK((optimized_invoke_type == invoke_type) || (optimized_invoke_type != kDirect) |
| 826 | || compiler_driver_->GetCompilerOptions().GetCompilePic()); |
Nicolas Geoffray | 1cf9528 | 2014-12-12 19:22:03 +0000 | [diff] [blame] | 827 | bool is_recursive = |
Nicolas Geoffray | d23eeef | 2015-05-18 22:31:29 +0100 | [diff] [blame] | 828 | (target_method.dex_method_index == outer_compilation_unit_->GetDexMethodIndex()) |
| 829 | && (target_method.dex_file == outer_compilation_unit_->GetDexFile()); |
Roland Levillain | 4c0eb42 | 2015-04-24 16:43:49 +0100 | [diff] [blame] | 830 | |
Jeff Hao | cad6542 | 2015-06-18 21:16:08 -0700 | [diff] [blame] | 831 | if (optimized_invoke_type == kStatic && !is_string_init) { |
Roland Levillain | 4c0eb42 | 2015-04-24 16:43:49 +0100 | [diff] [blame] | 832 | ScopedObjectAccess soa(Thread::Current()); |
| 833 | StackHandleScope<4> hs(soa.Self()); |
| 834 | Handle<mirror::DexCache> dex_cache(hs.NewHandle( |
| 835 | dex_compilation_unit_->GetClassLinker()->FindDexCache( |
| 836 | *dex_compilation_unit_->GetDexFile()))); |
| 837 | Handle<mirror::ClassLoader> class_loader(hs.NewHandle( |
| 838 | soa.Decode<mirror::ClassLoader*>(dex_compilation_unit_->GetClassLoader()))); |
Mathieu Chartier | e401d14 | 2015-04-22 13:56:20 -0700 | [diff] [blame] | 839 | ArtMethod* resolved_method = compiler_driver_->ResolveMethod( |
| 840 | soa, dex_cache, class_loader, dex_compilation_unit_, method_idx, optimized_invoke_type); |
Roland Levillain | 4c0eb42 | 2015-04-24 16:43:49 +0100 | [diff] [blame] | 841 | |
| 842 | if (resolved_method == nullptr) { |
| 843 | MaybeRecordStat(MethodCompilationStat::kNotCompiledUnresolvedMethod); |
| 844 | return false; |
| 845 | } |
| 846 | |
| 847 | const DexFile& outer_dex_file = *outer_compilation_unit_->GetDexFile(); |
| 848 | Handle<mirror::DexCache> outer_dex_cache(hs.NewHandle( |
| 849 | outer_compilation_unit_->GetClassLinker()->FindDexCache(outer_dex_file))); |
Nicolas Geoffray | afd0641 | 2015-06-20 22:44:47 +0100 | [diff] [blame] | 850 | Handle<mirror::Class> outer_class(hs.NewHandle(GetOutermostCompilingClass())); |
Roland Levillain | 4c0eb42 | 2015-04-24 16:43:49 +0100 | [diff] [blame] | 851 | |
| 852 | // The index at which the method's class is stored in the DexCache's type array. |
| 853 | uint32_t storage_index = DexFile::kDexNoIndex; |
Nicolas Geoffray | afd0641 | 2015-06-20 22:44:47 +0100 | [diff] [blame] | 854 | bool is_outer_class = (resolved_method->GetDeclaringClass() == outer_class.Get()); |
| 855 | if (is_outer_class) { |
| 856 | storage_index = outer_class->GetDexTypeIndex(); |
Roland Levillain | 4c0eb42 | 2015-04-24 16:43:49 +0100 | [diff] [blame] | 857 | } else if (outer_dex_cache.Get() == dex_cache.Get()) { |
| 858 | // Get `storage_index` from IsClassOfStaticMethodAvailableToReferrer. |
| 859 | compiler_driver_->IsClassOfStaticMethodAvailableToReferrer(outer_dex_cache.Get(), |
Nicolas Geoffray | afd0641 | 2015-06-20 22:44:47 +0100 | [diff] [blame] | 860 | GetCompilingClass(), |
Roland Levillain | 4c0eb42 | 2015-04-24 16:43:49 +0100 | [diff] [blame] | 861 | resolved_method, |
| 862 | method_idx, |
| 863 | &storage_index); |
| 864 | } |
| 865 | |
Nicolas Geoffray | b783b40 | 2015-06-22 11:06:43 +0100 | [diff] [blame] | 866 | if (!outer_class->IsInterface() |
| 867 | && outer_class->IsSubClass(resolved_method->GetDeclaringClass())) { |
Nicolas Geoffray | afd0641 | 2015-06-20 22:44:47 +0100 | [diff] [blame] | 868 | // If the outer class is the declaring class or a subclass |
Roland Levillain | 5f02c6c | 2015-04-24 19:14:22 +0100 | [diff] [blame] | 869 | // of the declaring class, no class initialization is needed |
| 870 | // before the static method call. |
Nicolas Geoffray | afd0641 | 2015-06-20 22:44:47 +0100 | [diff] [blame] | 871 | // Note that in case of inlining, we do not need to add clinit checks |
| 872 | // to calls that satisfy this subclass check with any inlined methods. This |
| 873 | // will be detected by the optimization passes. |
Roland Levillain | 4c0eb42 | 2015-04-24 16:43:49 +0100 | [diff] [blame] | 874 | clinit_check_requirement = HInvokeStaticOrDirect::ClinitCheckRequirement::kNone; |
| 875 | } else if (storage_index != DexFile::kDexNoIndex) { |
| 876 | // If the method's class type index is available, check |
| 877 | // whether we should add an explicit class initialization |
| 878 | // check for its declaring class before the static method call. |
| 879 | |
| 880 | // TODO: find out why this check is needed. |
| 881 | bool is_in_dex_cache = compiler_driver_->CanAssumeTypeIsPresentInDexCache( |
| 882 | *outer_compilation_unit_->GetDexFile(), storage_index); |
| 883 | bool is_initialized = |
| 884 | resolved_method->GetDeclaringClass()->IsInitialized() && is_in_dex_cache; |
| 885 | |
| 886 | if (is_initialized) { |
| 887 | clinit_check_requirement = HInvokeStaticOrDirect::ClinitCheckRequirement::kNone; |
| 888 | } else { |
| 889 | clinit_check_requirement = HInvokeStaticOrDirect::ClinitCheckRequirement::kExplicit; |
Nicolas Geoffray | d5111bf | 2015-05-22 15:37:09 +0100 | [diff] [blame] | 890 | HLoadClass* load_class = new (arena_) HLoadClass( |
Nicolas Geoffray | 76b1e17 | 2015-05-27 17:18:33 +0100 | [diff] [blame] | 891 | graph_->GetCurrentMethod(), |
| 892 | storage_index, |
| 893 | *dex_compilation_unit_->GetDexFile(), |
Nicolas Geoffray | afd0641 | 2015-06-20 22:44:47 +0100 | [diff] [blame] | 894 | is_outer_class, |
Nicolas Geoffray | 76b1e17 | 2015-05-27 17:18:33 +0100 | [diff] [blame] | 895 | dex_pc); |
Roland Levillain | 4c0eb42 | 2015-04-24 16:43:49 +0100 | [diff] [blame] | 896 | current_block_->AddInstruction(load_class); |
| 897 | clinit_check = new (arena_) HClinitCheck(load_class, dex_pc); |
| 898 | current_block_->AddInstruction(clinit_check); |
Roland Levillain | 4c0eb42 | 2015-04-24 16:43:49 +0100 | [diff] [blame] | 899 | } |
| 900 | } |
| 901 | } |
| 902 | |
Guillaume "Vermeille" Sanchez | ae09d2d | 2015-05-29 10:52:55 +0100 | [diff] [blame] | 903 | invoke = new (arena_) HInvokeStaticOrDirect(arena_, |
| 904 | number_of_arguments, |
| 905 | return_type, |
| 906 | dex_pc, |
| 907 | target_method.dex_method_index, |
| 908 | is_recursive, |
| 909 | string_init_offset, |
| 910 | invoke_type, |
| 911 | optimized_invoke_type, |
| 912 | clinit_check_requirement); |
Nicolas Geoffray | e982f0b | 2014-08-13 02:11:24 +0100 | [diff] [blame] | 913 | } |
Nicolas Geoffray | 01bc96d | 2014-04-11 17:43:50 +0100 | [diff] [blame] | 914 | |
| 915 | size_t start_index = 0; |
Calin Juravle | f97f9fb | 2014-11-11 15:38:19 +0000 | [diff] [blame] | 916 | Temporaries temps(graph_); |
Nicolas Geoffray | 01bc96d | 2014-04-11 17:43:50 +0100 | [diff] [blame] | 917 | if (is_instance_call) { |
| 918 | HInstruction* arg = LoadLocal(is_range ? register_index : args[0], Primitive::kPrimNot); |
Calin Juravle | 225ff81 | 2014-11-13 16:46:39 +0000 | [diff] [blame] | 919 | HNullCheck* null_check = new (arena_) HNullCheck(arg, dex_pc); |
Nicolas Geoffray | f12feb8 | 2014-07-17 18:32:41 +0100 | [diff] [blame] | 920 | current_block_->AddInstruction(null_check); |
| 921 | temps.Add(null_check); |
| 922 | invoke->SetArgumentAt(0, null_check); |
Nicolas Geoffray | 01bc96d | 2014-04-11 17:43:50 +0100 | [diff] [blame] | 923 | start_index = 1; |
| 924 | } |
| 925 | |
Nicolas Geoffray | 2e33525 | 2015-06-18 11:11:27 +0100 | [diff] [blame] | 926 | uint32_t descriptor_index = 1; // Skip the return type. |
Nicolas Geoffray | 01bc96d | 2014-04-11 17:43:50 +0100 | [diff] [blame] | 927 | uint32_t argument_index = start_index; |
Jeff Hao | 848f70a | 2014-01-15 13:49:50 -0800 | [diff] [blame] | 928 | if (is_string_init) { |
| 929 | start_index = 1; |
| 930 | } |
Nicolas Geoffray | 2e33525 | 2015-06-18 11:11:27 +0100 | [diff] [blame] | 931 | for (size_t i = start_index; |
| 932 | // Make sure we don't go over the expected arguments or over the number of |
| 933 | // dex registers given. If the instruction was seen as dead by the verifier, |
| 934 | // it hasn't been properly checked. |
| 935 | (i < number_of_vreg_arguments) && (argument_index < number_of_arguments); |
| 936 | i++, argument_index++) { |
Nicolas Geoffray | 01bc96d | 2014-04-11 17:43:50 +0100 | [diff] [blame] | 937 | Primitive::Type type = Primitive::GetType(descriptor[descriptor_index++]); |
Nicolas Geoffray | 7fb49da | 2014-10-06 09:12:41 +0100 | [diff] [blame] | 938 | bool is_wide = (type == Primitive::kPrimLong) || (type == Primitive::kPrimDouble); |
Nicolas Geoffray | 2e33525 | 2015-06-18 11:11:27 +0100 | [diff] [blame] | 939 | if (!is_range |
| 940 | && is_wide |
| 941 | && ((i + 1 == number_of_vreg_arguments) || (args[i] + 1 != args[i + 1]))) { |
| 942 | // Longs and doubles should be in pairs, that is, sequential registers. The verifier should |
| 943 | // reject any class where this is violated. However, the verifier only does these checks |
| 944 | // on non trivially dead instructions, so we just bailout the compilation. |
| 945 | VLOG(compiler) << "Did not compile " |
| 946 | << PrettyMethod(dex_compilation_unit_->GetDexMethodIndex(), *dex_file_) |
| 947 | << " because of non-sequential dex register pair in wide argument"; |
| 948 | MaybeRecordStat(MethodCompilationStat::kNotCompiledMalformedOpcode); |
| 949 | return false; |
| 950 | } |
Nicolas Geoffray | abed4d0 | 2014-07-14 15:24:11 +0100 | [diff] [blame] | 951 | HInstruction* arg = LoadLocal(is_range ? register_index + i : args[i], type); |
| 952 | invoke->SetArgumentAt(argument_index, arg); |
Nicolas Geoffray | 7fb49da | 2014-10-06 09:12:41 +0100 | [diff] [blame] | 953 | if (is_wide) { |
Nicolas Geoffray | abed4d0 | 2014-07-14 15:24:11 +0100 | [diff] [blame] | 954 | i++; |
Nicolas Geoffray | 01bc96d | 2014-04-11 17:43:50 +0100 | [diff] [blame] | 955 | } |
| 956 | } |
Nicolas Geoffray | 2e33525 | 2015-06-18 11:11:27 +0100 | [diff] [blame] | 957 | |
| 958 | if (argument_index != number_of_arguments) { |
| 959 | VLOG(compiler) << "Did not compile " |
| 960 | << PrettyMethod(dex_compilation_unit_->GetDexMethodIndex(), *dex_file_) |
| 961 | << " because of wrong number of arguments in invoke instruction"; |
| 962 | MaybeRecordStat(MethodCompilationStat::kNotCompiledMalformedOpcode); |
| 963 | return false; |
| 964 | } |
Nicolas Geoffray | 01bc96d | 2014-04-11 17:43:50 +0100 | [diff] [blame] | 965 | |
Nicolas Geoffray | 38207af | 2015-06-01 15:46:22 +0100 | [diff] [blame] | 966 | if (invoke->IsInvokeStaticOrDirect()) { |
| 967 | invoke->SetArgumentAt(argument_index, graph_->GetCurrentMethod()); |
| 968 | argument_index++; |
| 969 | } |
| 970 | |
Roland Levillain | 4c0eb42 | 2015-04-24 16:43:49 +0100 | [diff] [blame] | 971 | if (clinit_check_requirement == HInvokeStaticOrDirect::ClinitCheckRequirement::kExplicit) { |
| 972 | // Add the class initialization check as last input of `invoke`. |
| 973 | DCHECK(clinit_check != nullptr); |
Roland Levillain | 3e3d733 | 2015-04-28 11:00:54 +0100 | [diff] [blame] | 974 | invoke->SetArgumentAt(argument_index, clinit_check); |
Roland Levillain | 4c0eb42 | 2015-04-24 16:43:49 +0100 | [diff] [blame] | 975 | } |
| 976 | |
Nicolas Geoffray | 01bc96d | 2014-04-11 17:43:50 +0100 | [diff] [blame] | 977 | current_block_->AddInstruction(invoke); |
Nicolas Geoffray | a3d05a4 | 2014-10-20 17:41:32 +0100 | [diff] [blame] | 978 | latest_result_ = invoke; |
Jeff Hao | 848f70a | 2014-01-15 13:49:50 -0800 | [diff] [blame] | 979 | |
| 980 | // Add move-result for StringFactory method. |
| 981 | if (is_string_init) { |
| 982 | uint32_t orig_this_reg = is_range ? register_index : args[0]; |
Nicolas Geoffray | aa91920 | 2015-06-21 18:57:02 +0100 | [diff] [blame] | 983 | UpdateLocal(orig_this_reg, invoke); |
Jeff Hao | 848f70a | 2014-01-15 13:49:50 -0800 | [diff] [blame] | 984 | const VerifiedMethod* verified_method = |
| 985 | compiler_driver_->GetVerifiedMethod(dex_file_, dex_compilation_unit_->GetDexMethodIndex()); |
| 986 | if (verified_method == nullptr) { |
| 987 | LOG(WARNING) << "No verified method for method calling String.<init>: " |
| 988 | << PrettyMethod(dex_compilation_unit_->GetDexMethodIndex(), *dex_file_); |
| 989 | return false; |
| 990 | } |
| 991 | const SafeMap<uint32_t, std::set<uint32_t>>& string_init_map = |
| 992 | verified_method->GetStringInitPcRegMap(); |
| 993 | auto map_it = string_init_map.find(dex_pc); |
| 994 | if (map_it != string_init_map.end()) { |
| 995 | std::set<uint32_t> reg_set = map_it->second; |
| 996 | for (auto set_it = reg_set.begin(); set_it != reg_set.end(); ++set_it) { |
Nicolas Geoffray | aa91920 | 2015-06-21 18:57:02 +0100 | [diff] [blame] | 997 | HInstruction* load_local = LoadLocal(orig_this_reg, Primitive::kPrimNot); |
| 998 | UpdateLocal(*set_it, load_local); |
Jeff Hao | 848f70a | 2014-01-15 13:49:50 -0800 | [diff] [blame] | 999 | } |
| 1000 | } |
Jeff Hao | 848f70a | 2014-01-15 13:49:50 -0800 | [diff] [blame] | 1001 | } |
Nicolas Geoffray | 01bc96d | 2014-04-11 17:43:50 +0100 | [diff] [blame] | 1002 | return true; |
| 1003 | } |
| 1004 | |
Nicolas Geoffray | 19a19cf | 2014-10-22 16:07:05 +0100 | [diff] [blame] | 1005 | bool HGraphBuilder::BuildInstanceFieldAccess(const Instruction& instruction, |
Calin Juravle | 225ff81 | 2014-11-13 16:46:39 +0000 | [diff] [blame] | 1006 | uint32_t dex_pc, |
Nicolas Geoffray | 19a19cf | 2014-10-22 16:07:05 +0100 | [diff] [blame] | 1007 | bool is_put) { |
Nicolas Geoffray | e503832 | 2014-07-04 09:41:32 +0100 | [diff] [blame] | 1008 | uint32_t source_or_dest_reg = instruction.VRegA_22c(); |
| 1009 | uint32_t obj_reg = instruction.VRegB_22c(); |
| 1010 | uint16_t field_index = instruction.VRegC_22c(); |
| 1011 | |
| 1012 | ScopedObjectAccess soa(Thread::Current()); |
Mathieu Chartier | c785344 | 2015-03-27 14:35:38 -0700 | [diff] [blame] | 1013 | ArtField* resolved_field = |
| 1014 | compiler_driver_->ComputeInstanceFieldInfo(field_index, dex_compilation_unit_, is_put, soa); |
Nicolas Geoffray | e503832 | 2014-07-04 09:41:32 +0100 | [diff] [blame] | 1015 | |
Mathieu Chartier | c785344 | 2015-03-27 14:35:38 -0700 | [diff] [blame] | 1016 | if (resolved_field == nullptr) { |
Calin Juravle | 48c2b03 | 2014-12-09 18:11:36 +0000 | [diff] [blame] | 1017 | MaybeRecordStat(MethodCompilationStat::kNotCompiledUnresolvedField); |
Nicolas Geoffray | e503832 | 2014-07-04 09:41:32 +0100 | [diff] [blame] | 1018 | return false; |
| 1019 | } |
Calin Juravle | 52c4896 | 2014-12-16 17:02:57 +0000 | [diff] [blame] | 1020 | |
Nicolas Geoffray | abed4d0 | 2014-07-14 15:24:11 +0100 | [diff] [blame] | 1021 | Primitive::Type field_type = resolved_field->GetTypeAsPrimitiveType(); |
Nicolas Geoffray | abed4d0 | 2014-07-14 15:24:11 +0100 | [diff] [blame] | 1022 | |
Nicolas Geoffray | e503832 | 2014-07-04 09:41:32 +0100 | [diff] [blame] | 1023 | HInstruction* object = LoadLocal(obj_reg, Primitive::kPrimNot); |
Calin Juravle | 225ff81 | 2014-11-13 16:46:39 +0000 | [diff] [blame] | 1024 | current_block_->AddInstruction(new (arena_) HNullCheck(object, dex_pc)); |
Nicolas Geoffray | e503832 | 2014-07-04 09:41:32 +0100 | [diff] [blame] | 1025 | if (is_put) { |
Calin Juravle | f97f9fb | 2014-11-11 15:38:19 +0000 | [diff] [blame] | 1026 | Temporaries temps(graph_); |
Nicolas Geoffray | e503832 | 2014-07-04 09:41:32 +0100 | [diff] [blame] | 1027 | HInstruction* null_check = current_block_->GetLastInstruction(); |
| 1028 | // We need one temporary for the null check. |
| 1029 | temps.Add(null_check); |
Nicolas Geoffray | abed4d0 | 2014-07-14 15:24:11 +0100 | [diff] [blame] | 1030 | HInstruction* value = LoadLocal(source_or_dest_reg, field_type); |
Nicolas Geoffray | e503832 | 2014-07-04 09:41:32 +0100 | [diff] [blame] | 1031 | current_block_->AddInstruction(new (arena_) HInstanceFieldSet( |
| 1032 | null_check, |
| 1033 | value, |
Nicolas Geoffray | 3946844 | 2014-09-02 15:17:15 +0100 | [diff] [blame] | 1034 | field_type, |
Calin Juravle | 52c4896 | 2014-12-16 17:02:57 +0000 | [diff] [blame] | 1035 | resolved_field->GetOffset(), |
Guillaume "Vermeille" Sanchez | 104fd8a | 2015-05-20 17:52:13 +0100 | [diff] [blame] | 1036 | resolved_field->IsVolatile(), |
| 1037 | field_index, |
| 1038 | *dex_file_)); |
Nicolas Geoffray | e503832 | 2014-07-04 09:41:32 +0100 | [diff] [blame] | 1039 | } else { |
| 1040 | current_block_->AddInstruction(new (arena_) HInstanceFieldGet( |
| 1041 | current_block_->GetLastInstruction(), |
Nicolas Geoffray | abed4d0 | 2014-07-14 15:24:11 +0100 | [diff] [blame] | 1042 | field_type, |
Calin Juravle | 52c4896 | 2014-12-16 17:02:57 +0000 | [diff] [blame] | 1043 | resolved_field->GetOffset(), |
Guillaume "Vermeille" Sanchez | 104fd8a | 2015-05-20 17:52:13 +0100 | [diff] [blame] | 1044 | resolved_field->IsVolatile(), |
| 1045 | field_index, |
| 1046 | *dex_file_)); |
Nicolas Geoffray | e503832 | 2014-07-04 09:41:32 +0100 | [diff] [blame] | 1047 | |
| 1048 | UpdateLocal(source_or_dest_reg, current_block_->GetLastInstruction()); |
| 1049 | } |
| 1050 | return true; |
| 1051 | } |
| 1052 | |
Nicolas Geoffray | 3045174 | 2015-06-19 13:32:41 +0100 | [diff] [blame] | 1053 | static mirror::Class* GetClassFrom(CompilerDriver* driver, |
| 1054 | const DexCompilationUnit& compilation_unit) { |
Nicolas Geoffray | 9437b78 | 2015-03-25 10:08:51 +0000 | [diff] [blame] | 1055 | ScopedObjectAccess soa(Thread::Current()); |
| 1056 | StackHandleScope<2> hs(soa.Self()); |
Nicolas Geoffray | 3045174 | 2015-06-19 13:32:41 +0100 | [diff] [blame] | 1057 | const DexFile& dex_file = *compilation_unit.GetDexFile(); |
Nicolas Geoffray | 9437b78 | 2015-03-25 10:08:51 +0000 | [diff] [blame] | 1058 | Handle<mirror::ClassLoader> class_loader(hs.NewHandle( |
Nicolas Geoffray | 3045174 | 2015-06-19 13:32:41 +0100 | [diff] [blame] | 1059 | soa.Decode<mirror::ClassLoader*>(compilation_unit.GetClassLoader()))); |
| 1060 | Handle<mirror::DexCache> dex_cache(hs.NewHandle( |
| 1061 | compilation_unit.GetClassLinker()->FindDexCache(dex_file))); |
Nicolas Geoffray | 9437b78 | 2015-03-25 10:08:51 +0000 | [diff] [blame] | 1062 | |
Nicolas Geoffray | 3045174 | 2015-06-19 13:32:41 +0100 | [diff] [blame] | 1063 | return driver->ResolveCompilingMethodsClass(soa, dex_cache, class_loader, &compilation_unit); |
| 1064 | } |
| 1065 | |
| 1066 | mirror::Class* HGraphBuilder::GetOutermostCompilingClass() const { |
| 1067 | return GetClassFrom(compiler_driver_, *outer_compilation_unit_); |
| 1068 | } |
| 1069 | |
| 1070 | mirror::Class* HGraphBuilder::GetCompilingClass() const { |
| 1071 | return GetClassFrom(compiler_driver_, *dex_compilation_unit_); |
Nicolas Geoffray | 9437b78 | 2015-03-25 10:08:51 +0000 | [diff] [blame] | 1072 | } |
| 1073 | |
| 1074 | bool HGraphBuilder::IsOutermostCompilingClass(uint16_t type_index) const { |
| 1075 | ScopedObjectAccess soa(Thread::Current()); |
| 1076 | StackHandleScope<4> hs(soa.Self()); |
| 1077 | Handle<mirror::DexCache> dex_cache(hs.NewHandle( |
| 1078 | dex_compilation_unit_->GetClassLinker()->FindDexCache(*dex_compilation_unit_->GetDexFile()))); |
| 1079 | Handle<mirror::ClassLoader> class_loader(hs.NewHandle( |
| 1080 | soa.Decode<mirror::ClassLoader*>(dex_compilation_unit_->GetClassLoader()))); |
| 1081 | Handle<mirror::Class> cls(hs.NewHandle(compiler_driver_->ResolveClass( |
| 1082 | soa, dex_cache, class_loader, type_index, dex_compilation_unit_))); |
Nicolas Geoffray | afd0641 | 2015-06-20 22:44:47 +0100 | [diff] [blame] | 1083 | Handle<mirror::Class> outer_class(hs.NewHandle(GetOutermostCompilingClass())); |
Nicolas Geoffray | 9437b78 | 2015-03-25 10:08:51 +0000 | [diff] [blame] | 1084 | |
Nicolas Geoffray | afd0641 | 2015-06-20 22:44:47 +0100 | [diff] [blame] | 1085 | return outer_class.Get() == cls.Get(); |
Nicolas Geoffray | 9437b78 | 2015-03-25 10:08:51 +0000 | [diff] [blame] | 1086 | } |
| 1087 | |
Nicolas Geoffray | 19a19cf | 2014-10-22 16:07:05 +0100 | [diff] [blame] | 1088 | bool HGraphBuilder::BuildStaticFieldAccess(const Instruction& instruction, |
Calin Juravle | 225ff81 | 2014-11-13 16:46:39 +0000 | [diff] [blame] | 1089 | uint32_t dex_pc, |
Nicolas Geoffray | 19a19cf | 2014-10-22 16:07:05 +0100 | [diff] [blame] | 1090 | bool is_put) { |
| 1091 | uint32_t source_or_dest_reg = instruction.VRegA_21c(); |
| 1092 | uint16_t field_index = instruction.VRegB_21c(); |
| 1093 | |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 1094 | ScopedObjectAccess soa(Thread::Current()); |
Mathieu Chartier | c785344 | 2015-03-27 14:35:38 -0700 | [diff] [blame] | 1095 | StackHandleScope<4> hs(soa.Self()); |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 1096 | Handle<mirror::DexCache> dex_cache(hs.NewHandle( |
| 1097 | dex_compilation_unit_->GetClassLinker()->FindDexCache(*dex_compilation_unit_->GetDexFile()))); |
| 1098 | Handle<mirror::ClassLoader> class_loader(hs.NewHandle( |
| 1099 | soa.Decode<mirror::ClassLoader*>(dex_compilation_unit_->GetClassLoader()))); |
Mathieu Chartier | c785344 | 2015-03-27 14:35:38 -0700 | [diff] [blame] | 1100 | ArtField* resolved_field = compiler_driver_->ResolveField( |
| 1101 | soa, dex_cache, class_loader, dex_compilation_unit_, field_index, true); |
Nicolas Geoffray | 19a19cf | 2014-10-22 16:07:05 +0100 | [diff] [blame] | 1102 | |
Mathieu Chartier | c785344 | 2015-03-27 14:35:38 -0700 | [diff] [blame] | 1103 | if (resolved_field == nullptr) { |
Calin Juravle | 48c2b03 | 2014-12-09 18:11:36 +0000 | [diff] [blame] | 1104 | MaybeRecordStat(MethodCompilationStat::kNotCompiledUnresolvedField); |
Nicolas Geoffray | 19a19cf | 2014-10-22 16:07:05 +0100 | [diff] [blame] | 1105 | return false; |
| 1106 | } |
| 1107 | |
Nicolas Geoffray | 9437b78 | 2015-03-25 10:08:51 +0000 | [diff] [blame] | 1108 | const DexFile& outer_dex_file = *outer_compilation_unit_->GetDexFile(); |
| 1109 | Handle<mirror::DexCache> outer_dex_cache(hs.NewHandle( |
| 1110 | outer_compilation_unit_->GetClassLinker()->FindDexCache(outer_dex_file))); |
Nicolas Geoffray | 3045174 | 2015-06-19 13:32:41 +0100 | [diff] [blame] | 1111 | Handle<mirror::Class> outer_class(hs.NewHandle(GetOutermostCompilingClass())); |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 1112 | |
| 1113 | // The index at which the field's class is stored in the DexCache's type array. |
| 1114 | uint32_t storage_index; |
Nicolas Geoffray | 3045174 | 2015-06-19 13:32:41 +0100 | [diff] [blame] | 1115 | bool is_outer_class = (outer_class.Get() == resolved_field->GetDeclaringClass()); |
| 1116 | if (is_outer_class) { |
| 1117 | storage_index = outer_class->GetDexTypeIndex(); |
Nicolas Geoffray | 9437b78 | 2015-03-25 10:08:51 +0000 | [diff] [blame] | 1118 | } else if (outer_dex_cache.Get() != dex_cache.Get()) { |
Roland Levillain | 4c0eb42 | 2015-04-24 16:43:49 +0100 | [diff] [blame] | 1119 | // The compiler driver cannot currently understand multiple dex caches involved. Just bailout. |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 1120 | return false; |
Nicolas Geoffray | 9437b78 | 2015-03-25 10:08:51 +0000 | [diff] [blame] | 1121 | } else { |
| 1122 | std::pair<bool, bool> pair = compiler_driver_->IsFastStaticField( |
| 1123 | outer_dex_cache.Get(), |
Nicolas Geoffray | 3045174 | 2015-06-19 13:32:41 +0100 | [diff] [blame] | 1124 | GetCompilingClass(), |
Mathieu Chartier | c785344 | 2015-03-27 14:35:38 -0700 | [diff] [blame] | 1125 | resolved_field, |
Nicolas Geoffray | 9437b78 | 2015-03-25 10:08:51 +0000 | [diff] [blame] | 1126 | field_index, |
| 1127 | &storage_index); |
| 1128 | bool can_easily_access = is_put ? pair.second : pair.first; |
| 1129 | if (!can_easily_access) { |
| 1130 | return false; |
| 1131 | } |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 1132 | } |
| 1133 | |
| 1134 | // TODO: find out why this check is needed. |
| 1135 | bool is_in_dex_cache = compiler_driver_->CanAssumeTypeIsPresentInDexCache( |
Nicolas Geoffray | 6a816cf | 2015-03-24 16:17:56 +0000 | [diff] [blame] | 1136 | *outer_compilation_unit_->GetDexFile(), storage_index); |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 1137 | bool is_initialized = resolved_field->GetDeclaringClass()->IsInitialized() && is_in_dex_cache; |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 1138 | |
Nicolas Geoffray | 76b1e17 | 2015-05-27 17:18:33 +0100 | [diff] [blame] | 1139 | HLoadClass* constant = new (arena_) HLoadClass(graph_->GetCurrentMethod(), |
| 1140 | storage_index, |
| 1141 | *dex_compilation_unit_->GetDexFile(), |
Nicolas Geoffray | 3045174 | 2015-06-19 13:32:41 +0100 | [diff] [blame] | 1142 | is_outer_class, |
Nicolas Geoffray | 76b1e17 | 2015-05-27 17:18:33 +0100 | [diff] [blame] | 1143 | dex_pc); |
Nicolas Geoffray | 19a19cf | 2014-10-22 16:07:05 +0100 | [diff] [blame] | 1144 | current_block_->AddInstruction(constant); |
| 1145 | |
| 1146 | HInstruction* cls = constant; |
Nicolas Geoffray | 3045174 | 2015-06-19 13:32:41 +0100 | [diff] [blame] | 1147 | if (!is_initialized && !is_outer_class) { |
Calin Juravle | 225ff81 | 2014-11-13 16:46:39 +0000 | [diff] [blame] | 1148 | cls = new (arena_) HClinitCheck(constant, dex_pc); |
Nicolas Geoffray | 19a19cf | 2014-10-22 16:07:05 +0100 | [diff] [blame] | 1149 | current_block_->AddInstruction(cls); |
| 1150 | } |
| 1151 | |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 1152 | Primitive::Type field_type = resolved_field->GetTypeAsPrimitiveType(); |
Nicolas Geoffray | 19a19cf | 2014-10-22 16:07:05 +0100 | [diff] [blame] | 1153 | if (is_put) { |
| 1154 | // We need to keep the class alive before loading the value. |
Calin Juravle | f97f9fb | 2014-11-11 15:38:19 +0000 | [diff] [blame] | 1155 | Temporaries temps(graph_); |
Nicolas Geoffray | 19a19cf | 2014-10-22 16:07:05 +0100 | [diff] [blame] | 1156 | temps.Add(cls); |
| 1157 | HInstruction* value = LoadLocal(source_or_dest_reg, field_type); |
| 1158 | DCHECK_EQ(value->GetType(), field_type); |
Guillaume "Vermeille" Sanchez | 104fd8a | 2015-05-20 17:52:13 +0100 | [diff] [blame] | 1159 | current_block_->AddInstruction(new (arena_) HStaticFieldSet(cls, |
| 1160 | value, |
| 1161 | field_type, |
| 1162 | resolved_field->GetOffset(), |
| 1163 | resolved_field->IsVolatile(), |
| 1164 | field_index, |
| 1165 | *dex_file_)); |
Nicolas Geoffray | 19a19cf | 2014-10-22 16:07:05 +0100 | [diff] [blame] | 1166 | } else { |
Guillaume "Vermeille" Sanchez | 104fd8a | 2015-05-20 17:52:13 +0100 | [diff] [blame] | 1167 | current_block_->AddInstruction(new (arena_) HStaticFieldGet(cls, |
| 1168 | field_type, |
| 1169 | resolved_field->GetOffset(), |
| 1170 | resolved_field->IsVolatile(), |
| 1171 | field_index, |
| 1172 | *dex_file_)); |
Nicolas Geoffray | 19a19cf | 2014-10-22 16:07:05 +0100 | [diff] [blame] | 1173 | UpdateLocal(source_or_dest_reg, current_block_->GetLastInstruction()); |
| 1174 | } |
| 1175 | return true; |
| 1176 | } |
| 1177 | |
Calin Juravle | bacfec3 | 2014-11-14 15:54:36 +0000 | [diff] [blame] | 1178 | void HGraphBuilder::BuildCheckedDivRem(uint16_t out_vreg, |
| 1179 | uint16_t first_vreg, |
| 1180 | int64_t second_vreg_or_constant, |
| 1181 | uint32_t dex_pc, |
| 1182 | Primitive::Type type, |
| 1183 | bool second_is_constant, |
| 1184 | bool isDiv) { |
Calin Juravle | d6fb6cf | 2014-11-11 19:07:44 +0000 | [diff] [blame] | 1185 | DCHECK(type == Primitive::kPrimInt || type == Primitive::kPrimLong); |
Calin Juravle | d0d4852 | 2014-11-04 16:40:20 +0000 | [diff] [blame] | 1186 | |
Calin Juravle | d6fb6cf | 2014-11-11 19:07:44 +0000 | [diff] [blame] | 1187 | HInstruction* first = LoadLocal(first_vreg, type); |
| 1188 | HInstruction* second = nullptr; |
| 1189 | if (second_is_constant) { |
| 1190 | if (type == Primitive::kPrimInt) { |
David Brazdil | 8d5b8b2 | 2015-03-24 10:51:52 +0000 | [diff] [blame] | 1191 | second = graph_->GetIntConstant(second_vreg_or_constant); |
Calin Juravle | d6fb6cf | 2014-11-11 19:07:44 +0000 | [diff] [blame] | 1192 | } else { |
David Brazdil | 8d5b8b2 | 2015-03-24 10:51:52 +0000 | [diff] [blame] | 1193 | second = graph_->GetLongConstant(second_vreg_or_constant); |
Calin Juravle | d6fb6cf | 2014-11-11 19:07:44 +0000 | [diff] [blame] | 1194 | } |
| 1195 | } else { |
| 1196 | second = LoadLocal(second_vreg_or_constant, type); |
| 1197 | } |
| 1198 | |
| 1199 | if (!second_is_constant |
| 1200 | || (type == Primitive::kPrimInt && second->AsIntConstant()->GetValue() == 0) |
| 1201 | || (type == Primitive::kPrimLong && second->AsLongConstant()->GetValue() == 0)) { |
| 1202 | second = new (arena_) HDivZeroCheck(second, dex_pc); |
Calin Juravle | f97f9fb | 2014-11-11 15:38:19 +0000 | [diff] [blame] | 1203 | Temporaries temps(graph_); |
Calin Juravle | d0d4852 | 2014-11-04 16:40:20 +0000 | [diff] [blame] | 1204 | current_block_->AddInstruction(second); |
| 1205 | temps.Add(current_block_->GetLastInstruction()); |
| 1206 | } |
| 1207 | |
Calin Juravle | bacfec3 | 2014-11-14 15:54:36 +0000 | [diff] [blame] | 1208 | if (isDiv) { |
| 1209 | current_block_->AddInstruction(new (arena_) HDiv(type, first, second, dex_pc)); |
| 1210 | } else { |
| 1211 | current_block_->AddInstruction(new (arena_) HRem(type, first, second, dex_pc)); |
| 1212 | } |
Calin Juravle | d6fb6cf | 2014-11-11 19:07:44 +0000 | [diff] [blame] | 1213 | UpdateLocal(out_vreg, current_block_->GetLastInstruction()); |
Calin Juravle | d0d4852 | 2014-11-04 16:40:20 +0000 | [diff] [blame] | 1214 | } |
| 1215 | |
Nicolas Geoffray | 3c7bb98 | 2014-07-23 16:04:16 +0100 | [diff] [blame] | 1216 | void HGraphBuilder::BuildArrayAccess(const Instruction& instruction, |
Calin Juravle | 225ff81 | 2014-11-13 16:46:39 +0000 | [diff] [blame] | 1217 | uint32_t dex_pc, |
Nicolas Geoffray | 3c7bb98 | 2014-07-23 16:04:16 +0100 | [diff] [blame] | 1218 | bool is_put, |
| 1219 | Primitive::Type anticipated_type) { |
| 1220 | uint8_t source_or_dest_reg = instruction.VRegA_23x(); |
| 1221 | uint8_t array_reg = instruction.VRegB_23x(); |
| 1222 | uint8_t index_reg = instruction.VRegC_23x(); |
| 1223 | |
Nicolas Geoffray | 3c7bb98 | 2014-07-23 16:04:16 +0100 | [diff] [blame] | 1224 | // We need one temporary for the null check, one for the index, and one for the length. |
Calin Juravle | f97f9fb | 2014-11-11 15:38:19 +0000 | [diff] [blame] | 1225 | Temporaries temps(graph_); |
Nicolas Geoffray | 3c7bb98 | 2014-07-23 16:04:16 +0100 | [diff] [blame] | 1226 | |
| 1227 | HInstruction* object = LoadLocal(array_reg, Primitive::kPrimNot); |
Calin Juravle | 225ff81 | 2014-11-13 16:46:39 +0000 | [diff] [blame] | 1228 | object = new (arena_) HNullCheck(object, dex_pc); |
Nicolas Geoffray | 3c7bb98 | 2014-07-23 16:04:16 +0100 | [diff] [blame] | 1229 | current_block_->AddInstruction(object); |
| 1230 | temps.Add(object); |
| 1231 | |
| 1232 | HInstruction* length = new (arena_) HArrayLength(object); |
| 1233 | current_block_->AddInstruction(length); |
| 1234 | temps.Add(length); |
| 1235 | HInstruction* index = LoadLocal(index_reg, Primitive::kPrimInt); |
Calin Juravle | 225ff81 | 2014-11-13 16:46:39 +0000 | [diff] [blame] | 1236 | index = new (arena_) HBoundsCheck(index, length, dex_pc); |
Nicolas Geoffray | 3c7bb98 | 2014-07-23 16:04:16 +0100 | [diff] [blame] | 1237 | current_block_->AddInstruction(index); |
| 1238 | temps.Add(index); |
| 1239 | if (is_put) { |
| 1240 | HInstruction* value = LoadLocal(source_or_dest_reg, anticipated_type); |
| 1241 | // TODO: Insert a type check node if the type is Object. |
Nicolas Geoffray | 3946844 | 2014-09-02 15:17:15 +0100 | [diff] [blame] | 1242 | current_block_->AddInstruction(new (arena_) HArraySet( |
Calin Juravle | 225ff81 | 2014-11-13 16:46:39 +0000 | [diff] [blame] | 1243 | object, index, value, anticipated_type, dex_pc)); |
Nicolas Geoffray | 3c7bb98 | 2014-07-23 16:04:16 +0100 | [diff] [blame] | 1244 | } else { |
| 1245 | current_block_->AddInstruction(new (arena_) HArrayGet(object, index, anticipated_type)); |
| 1246 | UpdateLocal(source_or_dest_reg, current_block_->GetLastInstruction()); |
| 1247 | } |
Mark Mendell | 1152c92 | 2015-04-24 17:06:35 -0400 | [diff] [blame] | 1248 | graph_->SetHasBoundsChecks(true); |
Nicolas Geoffray | 3c7bb98 | 2014-07-23 16:04:16 +0100 | [diff] [blame] | 1249 | } |
| 1250 | |
Calin Juravle | 225ff81 | 2014-11-13 16:46:39 +0000 | [diff] [blame] | 1251 | void HGraphBuilder::BuildFilledNewArray(uint32_t dex_pc, |
Nicolas Geoffray | a3d05a4 | 2014-10-20 17:41:32 +0100 | [diff] [blame] | 1252 | uint32_t type_index, |
| 1253 | uint32_t number_of_vreg_arguments, |
| 1254 | bool is_range, |
| 1255 | uint32_t* args, |
| 1256 | uint32_t register_index) { |
David Brazdil | 8d5b8b2 | 2015-03-24 10:51:52 +0000 | [diff] [blame] | 1257 | HInstruction* length = graph_->GetIntConstant(number_of_vreg_arguments); |
Nicolas Geoffray | cb1b00a | 2015-01-28 14:50:01 +0000 | [diff] [blame] | 1258 | QuickEntrypointEnum entrypoint = NeedsAccessCheck(type_index) |
| 1259 | ? kQuickAllocArrayWithAccessCheck |
| 1260 | : kQuickAllocArray; |
Guillaume "Vermeille" Sanchez | 81d804a | 2015-05-20 12:42:25 +0100 | [diff] [blame] | 1261 | HInstruction* object = new (arena_) HNewArray(length, |
Nicolas Geoffray | 69aa601 | 2015-06-09 10:34:25 +0100 | [diff] [blame] | 1262 | graph_->GetCurrentMethod(), |
Guillaume "Vermeille" Sanchez | 81d804a | 2015-05-20 12:42:25 +0100 | [diff] [blame] | 1263 | dex_pc, |
| 1264 | type_index, |
| 1265 | *dex_compilation_unit_->GetDexFile(), |
| 1266 | entrypoint); |
Nicolas Geoffray | a3d05a4 | 2014-10-20 17:41:32 +0100 | [diff] [blame] | 1267 | current_block_->AddInstruction(object); |
| 1268 | |
| 1269 | const char* descriptor = dex_file_->StringByTypeIdx(type_index); |
| 1270 | DCHECK_EQ(descriptor[0], '[') << descriptor; |
| 1271 | char primitive = descriptor[1]; |
| 1272 | DCHECK(primitive == 'I' |
| 1273 | || primitive == 'L' |
| 1274 | || primitive == '[') << descriptor; |
| 1275 | bool is_reference_array = (primitive == 'L') || (primitive == '['); |
| 1276 | Primitive::Type type = is_reference_array ? Primitive::kPrimNot : Primitive::kPrimInt; |
| 1277 | |
Calin Juravle | f97f9fb | 2014-11-11 15:38:19 +0000 | [diff] [blame] | 1278 | Temporaries temps(graph_); |
Nicolas Geoffray | a3d05a4 | 2014-10-20 17:41:32 +0100 | [diff] [blame] | 1279 | temps.Add(object); |
| 1280 | for (size_t i = 0; i < number_of_vreg_arguments; ++i) { |
| 1281 | HInstruction* value = LoadLocal(is_range ? register_index + i : args[i], type); |
David Brazdil | 8d5b8b2 | 2015-03-24 10:51:52 +0000 | [diff] [blame] | 1282 | HInstruction* index = graph_->GetIntConstant(i); |
Nicolas Geoffray | a3d05a4 | 2014-10-20 17:41:32 +0100 | [diff] [blame] | 1283 | current_block_->AddInstruction( |
Calin Juravle | 225ff81 | 2014-11-13 16:46:39 +0000 | [diff] [blame] | 1284 | new (arena_) HArraySet(object, index, value, type, dex_pc)); |
Nicolas Geoffray | a3d05a4 | 2014-10-20 17:41:32 +0100 | [diff] [blame] | 1285 | } |
| 1286 | latest_result_ = object; |
| 1287 | } |
| 1288 | |
| 1289 | template <typename T> |
| 1290 | void HGraphBuilder::BuildFillArrayData(HInstruction* object, |
| 1291 | const T* data, |
| 1292 | uint32_t element_count, |
| 1293 | Primitive::Type anticipated_type, |
Calin Juravle | 225ff81 | 2014-11-13 16:46:39 +0000 | [diff] [blame] | 1294 | uint32_t dex_pc) { |
Nicolas Geoffray | a3d05a4 | 2014-10-20 17:41:32 +0100 | [diff] [blame] | 1295 | for (uint32_t i = 0; i < element_count; ++i) { |
David Brazdil | 8d5b8b2 | 2015-03-24 10:51:52 +0000 | [diff] [blame] | 1296 | HInstruction* index = graph_->GetIntConstant(i); |
| 1297 | HInstruction* value = graph_->GetIntConstant(data[i]); |
Nicolas Geoffray | a3d05a4 | 2014-10-20 17:41:32 +0100 | [diff] [blame] | 1298 | current_block_->AddInstruction(new (arena_) HArraySet( |
Calin Juravle | 225ff81 | 2014-11-13 16:46:39 +0000 | [diff] [blame] | 1299 | object, index, value, anticipated_type, dex_pc)); |
Nicolas Geoffray | a3d05a4 | 2014-10-20 17:41:32 +0100 | [diff] [blame] | 1300 | } |
| 1301 | } |
| 1302 | |
Calin Juravle | 225ff81 | 2014-11-13 16:46:39 +0000 | [diff] [blame] | 1303 | void HGraphBuilder::BuildFillArrayData(const Instruction& instruction, uint32_t dex_pc) { |
Calin Juravle | f97f9fb | 2014-11-11 15:38:19 +0000 | [diff] [blame] | 1304 | Temporaries temps(graph_); |
Calin Juravle | d0d4852 | 2014-11-04 16:40:20 +0000 | [diff] [blame] | 1305 | HInstruction* array = LoadLocal(instruction.VRegA_31t(), Primitive::kPrimNot); |
Calin Juravle | 225ff81 | 2014-11-13 16:46:39 +0000 | [diff] [blame] | 1306 | HNullCheck* null_check = new (arena_) HNullCheck(array, dex_pc); |
Calin Juravle | d0d4852 | 2014-11-04 16:40:20 +0000 | [diff] [blame] | 1307 | current_block_->AddInstruction(null_check); |
| 1308 | temps.Add(null_check); |
| 1309 | |
| 1310 | HInstruction* length = new (arena_) HArrayLength(null_check); |
| 1311 | current_block_->AddInstruction(length); |
| 1312 | |
Calin Juravle | 225ff81 | 2014-11-13 16:46:39 +0000 | [diff] [blame] | 1313 | int32_t payload_offset = instruction.VRegB_31t() + dex_pc; |
Calin Juravle | d0d4852 | 2014-11-04 16:40:20 +0000 | [diff] [blame] | 1314 | const Instruction::ArrayDataPayload* payload = |
| 1315 | reinterpret_cast<const Instruction::ArrayDataPayload*>(code_start_ + payload_offset); |
| 1316 | const uint8_t* data = payload->data; |
| 1317 | uint32_t element_count = payload->element_count; |
| 1318 | |
| 1319 | // Implementation of this DEX instruction seems to be that the bounds check is |
| 1320 | // done before doing any stores. |
David Brazdil | 8d5b8b2 | 2015-03-24 10:51:52 +0000 | [diff] [blame] | 1321 | HInstruction* last_index = graph_->GetIntConstant(payload->element_count - 1); |
Calin Juravle | 225ff81 | 2014-11-13 16:46:39 +0000 | [diff] [blame] | 1322 | current_block_->AddInstruction(new (arena_) HBoundsCheck(last_index, length, dex_pc)); |
Calin Juravle | d0d4852 | 2014-11-04 16:40:20 +0000 | [diff] [blame] | 1323 | |
| 1324 | switch (payload->element_width) { |
| 1325 | case 1: |
| 1326 | BuildFillArrayData(null_check, |
| 1327 | reinterpret_cast<const int8_t*>(data), |
| 1328 | element_count, |
| 1329 | Primitive::kPrimByte, |
Calin Juravle | 225ff81 | 2014-11-13 16:46:39 +0000 | [diff] [blame] | 1330 | dex_pc); |
Calin Juravle | d0d4852 | 2014-11-04 16:40:20 +0000 | [diff] [blame] | 1331 | break; |
| 1332 | case 2: |
| 1333 | BuildFillArrayData(null_check, |
| 1334 | reinterpret_cast<const int16_t*>(data), |
| 1335 | element_count, |
| 1336 | Primitive::kPrimShort, |
Calin Juravle | 225ff81 | 2014-11-13 16:46:39 +0000 | [diff] [blame] | 1337 | dex_pc); |
Calin Juravle | d0d4852 | 2014-11-04 16:40:20 +0000 | [diff] [blame] | 1338 | break; |
| 1339 | case 4: |
| 1340 | BuildFillArrayData(null_check, |
| 1341 | reinterpret_cast<const int32_t*>(data), |
| 1342 | element_count, |
| 1343 | Primitive::kPrimInt, |
Calin Juravle | 225ff81 | 2014-11-13 16:46:39 +0000 | [diff] [blame] | 1344 | dex_pc); |
Calin Juravle | d0d4852 | 2014-11-04 16:40:20 +0000 | [diff] [blame] | 1345 | break; |
| 1346 | case 8: |
| 1347 | BuildFillWideArrayData(null_check, |
| 1348 | reinterpret_cast<const int64_t*>(data), |
| 1349 | element_count, |
Calin Juravle | 225ff81 | 2014-11-13 16:46:39 +0000 | [diff] [blame] | 1350 | dex_pc); |
Calin Juravle | d0d4852 | 2014-11-04 16:40:20 +0000 | [diff] [blame] | 1351 | break; |
| 1352 | default: |
| 1353 | LOG(FATAL) << "Unknown element width for " << payload->element_width; |
| 1354 | } |
Mark Mendell | 1152c92 | 2015-04-24 17:06:35 -0400 | [diff] [blame] | 1355 | graph_->SetHasBoundsChecks(true); |
Calin Juravle | d0d4852 | 2014-11-04 16:40:20 +0000 | [diff] [blame] | 1356 | } |
| 1357 | |
Nicolas Geoffray | a3d05a4 | 2014-10-20 17:41:32 +0100 | [diff] [blame] | 1358 | void HGraphBuilder::BuildFillWideArrayData(HInstruction* object, |
Nicolas Geoffray | 8d6ae52 | 2014-10-23 18:32:13 +0100 | [diff] [blame] | 1359 | const int64_t* data, |
Nicolas Geoffray | a3d05a4 | 2014-10-20 17:41:32 +0100 | [diff] [blame] | 1360 | uint32_t element_count, |
Calin Juravle | 225ff81 | 2014-11-13 16:46:39 +0000 | [diff] [blame] | 1361 | uint32_t dex_pc) { |
Nicolas Geoffray | a3d05a4 | 2014-10-20 17:41:32 +0100 | [diff] [blame] | 1362 | for (uint32_t i = 0; i < element_count; ++i) { |
David Brazdil | 8d5b8b2 | 2015-03-24 10:51:52 +0000 | [diff] [blame] | 1363 | HInstruction* index = graph_->GetIntConstant(i); |
| 1364 | HInstruction* value = graph_->GetLongConstant(data[i]); |
Nicolas Geoffray | a3d05a4 | 2014-10-20 17:41:32 +0100 | [diff] [blame] | 1365 | current_block_->AddInstruction(new (arena_) HArraySet( |
Calin Juravle | 225ff81 | 2014-11-13 16:46:39 +0000 | [diff] [blame] | 1366 | object, index, value, Primitive::kPrimLong, dex_pc)); |
Nicolas Geoffray | a3d05a4 | 2014-10-20 17:41:32 +0100 | [diff] [blame] | 1367 | } |
| 1368 | } |
| 1369 | |
Nicolas Geoffray | 57a88d4 | 2014-11-10 15:09:21 +0000 | [diff] [blame] | 1370 | bool HGraphBuilder::BuildTypeCheck(const Instruction& instruction, |
| 1371 | uint8_t destination, |
| 1372 | uint8_t reference, |
| 1373 | uint16_t type_index, |
Calin Juravle | 225ff81 | 2014-11-13 16:46:39 +0000 | [diff] [blame] | 1374 | uint32_t dex_pc) { |
Nicolas Geoffray | 57a88d4 | 2014-11-10 15:09:21 +0000 | [diff] [blame] | 1375 | bool type_known_final; |
| 1376 | bool type_known_abstract; |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 1377 | // `CanAccessTypeWithoutChecks` will tell whether the method being |
| 1378 | // built is trying to access its own class, so that the generated |
| 1379 | // code can optimize for this case. However, the optimization does not |
Nicolas Geoffray | 9437b78 | 2015-03-25 10:08:51 +0000 | [diff] [blame] | 1380 | // work for inlining, so we use `IsOutermostCompilingClass` instead. |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 1381 | bool dont_use_is_referrers_class; |
Nicolas Geoffray | 57a88d4 | 2014-11-10 15:09:21 +0000 | [diff] [blame] | 1382 | bool can_access = compiler_driver_->CanAccessTypeWithoutChecks( |
| 1383 | dex_compilation_unit_->GetDexMethodIndex(), *dex_file_, type_index, |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 1384 | &type_known_final, &type_known_abstract, &dont_use_is_referrers_class); |
Nicolas Geoffray | 57a88d4 | 2014-11-10 15:09:21 +0000 | [diff] [blame] | 1385 | if (!can_access) { |
Calin Juravle | 48c2b03 | 2014-12-09 18:11:36 +0000 | [diff] [blame] | 1386 | MaybeRecordStat(MethodCompilationStat::kNotCompiledCantAccesType); |
Nicolas Geoffray | 57a88d4 | 2014-11-10 15:09:21 +0000 | [diff] [blame] | 1387 | return false; |
| 1388 | } |
| 1389 | HInstruction* object = LoadLocal(reference, Primitive::kPrimNot); |
Nicolas Geoffray | 9437b78 | 2015-03-25 10:08:51 +0000 | [diff] [blame] | 1390 | HLoadClass* cls = new (arena_) HLoadClass( |
Nicolas Geoffray | 76b1e17 | 2015-05-27 17:18:33 +0100 | [diff] [blame] | 1391 | graph_->GetCurrentMethod(), |
Nicolas Geoffray | d5111bf | 2015-05-22 15:37:09 +0100 | [diff] [blame] | 1392 | type_index, |
| 1393 | *dex_compilation_unit_->GetDexFile(), |
| 1394 | IsOutermostCompilingClass(type_index), |
| 1395 | dex_pc); |
Nicolas Geoffray | 57a88d4 | 2014-11-10 15:09:21 +0000 | [diff] [blame] | 1396 | current_block_->AddInstruction(cls); |
| 1397 | // The class needs a temporary before being used by the type check. |
Calin Juravle | f97f9fb | 2014-11-11 15:38:19 +0000 | [diff] [blame] | 1398 | Temporaries temps(graph_); |
Nicolas Geoffray | 57a88d4 | 2014-11-10 15:09:21 +0000 | [diff] [blame] | 1399 | temps.Add(cls); |
| 1400 | if (instruction.Opcode() == Instruction::INSTANCE_OF) { |
| 1401 | current_block_->AddInstruction( |
Calin Juravle | 225ff81 | 2014-11-13 16:46:39 +0000 | [diff] [blame] | 1402 | new (arena_) HInstanceOf(object, cls, type_known_final, dex_pc)); |
Nicolas Geoffray | 57a88d4 | 2014-11-10 15:09:21 +0000 | [diff] [blame] | 1403 | UpdateLocal(destination, current_block_->GetLastInstruction()); |
| 1404 | } else { |
| 1405 | DCHECK_EQ(instruction.Opcode(), Instruction::CHECK_CAST); |
| 1406 | current_block_->AddInstruction( |
Calin Juravle | 225ff81 | 2014-11-13 16:46:39 +0000 | [diff] [blame] | 1407 | new (arena_) HCheckCast(object, cls, type_known_final, dex_pc)); |
Nicolas Geoffray | 57a88d4 | 2014-11-10 15:09:21 +0000 | [diff] [blame] | 1408 | } |
| 1409 | return true; |
| 1410 | } |
| 1411 | |
Nicolas Geoffray | cb1b00a | 2015-01-28 14:50:01 +0000 | [diff] [blame] | 1412 | bool HGraphBuilder::NeedsAccessCheck(uint32_t type_index) const { |
| 1413 | return !compiler_driver_->CanAccessInstantiableTypeWithoutChecks( |
| 1414 | dex_compilation_unit_->GetDexMethodIndex(), *dex_file_, type_index); |
| 1415 | } |
| 1416 | |
Calin Juravle | 48c2b03 | 2014-12-09 18:11:36 +0000 | [diff] [blame] | 1417 | void HGraphBuilder::BuildPackedSwitch(const Instruction& instruction, uint32_t dex_pc) { |
David Brazdil | 2ef645b | 2015-06-17 18:20:52 +0100 | [diff] [blame] | 1418 | // Verifier guarantees that the payload for PackedSwitch contains: |
| 1419 | // (a) number of entries (may be zero) |
| 1420 | // (b) first and lowest switch case value (entry 0, always present) |
| 1421 | // (c) list of target pcs (entries 1 <= i <= N) |
Andreas Gampe | d881df5 | 2014-11-24 23:28:39 -0800 | [diff] [blame] | 1422 | SwitchTable table(instruction, dex_pc, false); |
| 1423 | |
| 1424 | // Value to test against. |
| 1425 | HInstruction* value = LoadLocal(instruction.VRegA(), Primitive::kPrimInt); |
| 1426 | |
David Brazdil | 2ef645b | 2015-06-17 18:20:52 +0100 | [diff] [blame] | 1427 | // Retrieve number of entries. |
Andreas Gampe | e4d4d32 | 2014-12-04 09:09:57 -0800 | [diff] [blame] | 1428 | uint16_t num_entries = table.GetNumEntries(); |
David Brazdil | 2ef645b | 2015-06-17 18:20:52 +0100 | [diff] [blame] | 1429 | if (num_entries == 0) { |
| 1430 | return; |
| 1431 | } |
Andreas Gampe | e4d4d32 | 2014-12-04 09:09:57 -0800 | [diff] [blame] | 1432 | |
Andreas Gampe | d881df5 | 2014-11-24 23:28:39 -0800 | [diff] [blame] | 1433 | // Chained cmp-and-branch, starting from starting_key. |
| 1434 | int32_t starting_key = table.GetEntryAt(0); |
| 1435 | |
Andreas Gampe | d881df5 | 2014-11-24 23:28:39 -0800 | [diff] [blame] | 1436 | for (size_t i = 1; i <= num_entries; i++) { |
Andreas Gampe | e4d4d32 | 2014-12-04 09:09:57 -0800 | [diff] [blame] | 1437 | BuildSwitchCaseHelper(instruction, i, i == num_entries, table, value, starting_key + i - 1, |
| 1438 | table.GetEntryAt(i), dex_pc); |
Andreas Gampe | d881df5 | 2014-11-24 23:28:39 -0800 | [diff] [blame] | 1439 | } |
Andreas Gampe | d881df5 | 2014-11-24 23:28:39 -0800 | [diff] [blame] | 1440 | } |
| 1441 | |
Calin Juravle | 48c2b03 | 2014-12-09 18:11:36 +0000 | [diff] [blame] | 1442 | void HGraphBuilder::BuildSparseSwitch(const Instruction& instruction, uint32_t dex_pc) { |
David Brazdil | 2ef645b | 2015-06-17 18:20:52 +0100 | [diff] [blame] | 1443 | // Verifier guarantees that the payload for SparseSwitch contains: |
| 1444 | // (a) number of entries (may be zero) |
| 1445 | // (b) sorted key values (entries 0 <= i < N) |
| 1446 | // (c) target pcs corresponding to the switch values (entries N <= i < 2*N) |
Andreas Gampe | e4d4d32 | 2014-12-04 09:09:57 -0800 | [diff] [blame] | 1447 | SwitchTable table(instruction, dex_pc, true); |
| 1448 | |
| 1449 | // Value to test against. |
| 1450 | HInstruction* value = LoadLocal(instruction.VRegA(), Primitive::kPrimInt); |
| 1451 | |
| 1452 | uint16_t num_entries = table.GetNumEntries(); |
Andreas Gampe | e4d4d32 | 2014-12-04 09:09:57 -0800 | [diff] [blame] | 1453 | |
| 1454 | for (size_t i = 0; i < num_entries; i++) { |
| 1455 | BuildSwitchCaseHelper(instruction, i, i == static_cast<size_t>(num_entries) - 1, table, value, |
| 1456 | table.GetEntryAt(i), table.GetEntryAt(i + num_entries), dex_pc); |
| 1457 | } |
Andreas Gampe | e4d4d32 | 2014-12-04 09:09:57 -0800 | [diff] [blame] | 1458 | } |
| 1459 | |
| 1460 | void HGraphBuilder::BuildSwitchCaseHelper(const Instruction& instruction, size_t index, |
| 1461 | bool is_last_case, const SwitchTable& table, |
| 1462 | HInstruction* value, int32_t case_value_int, |
| 1463 | int32_t target_offset, uint32_t dex_pc) { |
David Brazdil | 852eaff | 2015-02-02 15:23:05 +0000 | [diff] [blame] | 1464 | HBasicBlock* case_target = FindBlockStartingAt(dex_pc + target_offset); |
| 1465 | DCHECK(case_target != nullptr); |
| 1466 | PotentiallyAddSuspendCheck(case_target, dex_pc); |
Andreas Gampe | e4d4d32 | 2014-12-04 09:09:57 -0800 | [diff] [blame] | 1467 | |
| 1468 | // The current case's value. |
David Brazdil | 8d5b8b2 | 2015-03-24 10:51:52 +0000 | [diff] [blame] | 1469 | HInstruction* this_case_value = graph_->GetIntConstant(case_value_int); |
Andreas Gampe | e4d4d32 | 2014-12-04 09:09:57 -0800 | [diff] [blame] | 1470 | |
| 1471 | // Compare value and this_case_value. |
| 1472 | HEqual* comparison = new (arena_) HEqual(value, this_case_value); |
| 1473 | current_block_->AddInstruction(comparison); |
| 1474 | HInstruction* ifinst = new (arena_) HIf(comparison); |
| 1475 | current_block_->AddInstruction(ifinst); |
| 1476 | |
| 1477 | // Case hit: use the target offset to determine where to go. |
Andreas Gampe | e4d4d32 | 2014-12-04 09:09:57 -0800 | [diff] [blame] | 1478 | current_block_->AddSuccessor(case_target); |
| 1479 | |
| 1480 | // Case miss: go to the next case (or default fall-through). |
| 1481 | // When there is a next case, we use the block stored with the table offset representing this |
| 1482 | // case (that is where we registered them in ComputeBranchTargets). |
| 1483 | // When there is no next case, we use the following instruction. |
| 1484 | // TODO: Find a good way to peel the last iteration to avoid conditional, but still have re-use. |
| 1485 | if (!is_last_case) { |
| 1486 | HBasicBlock* next_case_target = FindBlockStartingAt(table.GetDexPcForIndex(index)); |
| 1487 | DCHECK(next_case_target != nullptr); |
| 1488 | current_block_->AddSuccessor(next_case_target); |
| 1489 | |
| 1490 | // Need to manually add the block, as there is no dex-pc transition for the cases. |
| 1491 | graph_->AddBlock(next_case_target); |
| 1492 | |
| 1493 | current_block_ = next_case_target; |
| 1494 | } else { |
| 1495 | HBasicBlock* default_target = FindBlockStartingAt(dex_pc + instruction.SizeInCodeUnits()); |
| 1496 | DCHECK(default_target != nullptr); |
| 1497 | current_block_->AddSuccessor(default_target); |
| 1498 | current_block_ = nullptr; |
| 1499 | } |
| 1500 | } |
| 1501 | |
David Brazdil | 852eaff | 2015-02-02 15:23:05 +0000 | [diff] [blame] | 1502 | void HGraphBuilder::PotentiallyAddSuspendCheck(HBasicBlock* target, uint32_t dex_pc) { |
| 1503 | int32_t target_offset = target->GetDexPc() - dex_pc; |
Nicolas Geoffray | fbc695f | 2014-09-15 15:33:30 +0000 | [diff] [blame] | 1504 | if (target_offset <= 0) { |
David Brazdil | 852eaff | 2015-02-02 15:23:05 +0000 | [diff] [blame] | 1505 | // DX generates back edges to the first encountered return. We can save |
| 1506 | // time of later passes by not adding redundant suspend checks. |
David Brazdil | 2fd6aa5 | 2015-02-02 18:58:27 +0000 | [diff] [blame] | 1507 | HInstruction* last_in_target = target->GetLastInstruction(); |
| 1508 | if (last_in_target != nullptr && |
| 1509 | (last_in_target->IsReturn() || last_in_target->IsReturnVoid())) { |
| 1510 | return; |
David Brazdil | 852eaff | 2015-02-02 15:23:05 +0000 | [diff] [blame] | 1511 | } |
| 1512 | |
| 1513 | // Add a suspend check to backward branches which may potentially loop. We |
| 1514 | // can remove them after we recognize loops in the graph. |
Calin Juravle | 225ff81 | 2014-11-13 16:46:39 +0000 | [diff] [blame] | 1515 | current_block_->AddInstruction(new (arena_) HSuspendCheck(dex_pc)); |
Nicolas Geoffray | fbc695f | 2014-09-15 15:33:30 +0000 | [diff] [blame] | 1516 | } |
| 1517 | } |
| 1518 | |
Calin Juravle | 225ff81 | 2014-11-13 16:46:39 +0000 | [diff] [blame] | 1519 | bool HGraphBuilder::AnalyzeDexInstruction(const Instruction& instruction, uint32_t dex_pc) { |
Nicolas Geoffray | bab4ed7 | 2014-03-11 17:53:17 +0000 | [diff] [blame] | 1520 | if (current_block_ == nullptr) { |
| 1521 | return true; // Dead code |
| 1522 | } |
Nicolas Geoffray | be9a92a | 2014-02-25 14:22:56 +0000 | [diff] [blame] | 1523 | |
Nicolas Geoffray | 818f210 | 2014-02-18 16:43:35 +0000 | [diff] [blame] | 1524 | switch (instruction.Opcode()) { |
Nicolas Geoffray | 3ff386a | 2014-03-04 14:46:47 +0000 | [diff] [blame] | 1525 | case Instruction::CONST_4: { |
| 1526 | int32_t register_index = instruction.VRegA(); |
David Brazdil | 8d5b8b2 | 2015-03-24 10:51:52 +0000 | [diff] [blame] | 1527 | HIntConstant* constant = graph_->GetIntConstant(instruction.VRegB_11n()); |
Nicolas Geoffray | 3ff386a | 2014-03-04 14:46:47 +0000 | [diff] [blame] | 1528 | UpdateLocal(register_index, constant); |
| 1529 | break; |
| 1530 | } |
Nicolas Geoffray | bab4ed7 | 2014-03-11 17:53:17 +0000 | [diff] [blame] | 1531 | |
Nicolas Geoffray | b55f835 | 2014-04-07 15:26:35 +0100 | [diff] [blame] | 1532 | case Instruction::CONST_16: { |
| 1533 | int32_t register_index = instruction.VRegA(); |
David Brazdil | 8d5b8b2 | 2015-03-24 10:51:52 +0000 | [diff] [blame] | 1534 | HIntConstant* constant = graph_->GetIntConstant(instruction.VRegB_21s()); |
Nicolas Geoffray | 01bc96d | 2014-04-11 17:43:50 +0100 | [diff] [blame] | 1535 | UpdateLocal(register_index, constant); |
| 1536 | break; |
| 1537 | } |
| 1538 | |
Dave Allison | 20dfc79 | 2014-06-16 20:44:29 -0700 | [diff] [blame] | 1539 | case Instruction::CONST: { |
| 1540 | int32_t register_index = instruction.VRegA(); |
David Brazdil | 8d5b8b2 | 2015-03-24 10:51:52 +0000 | [diff] [blame] | 1541 | HIntConstant* constant = graph_->GetIntConstant(instruction.VRegB_31i()); |
Dave Allison | 20dfc79 | 2014-06-16 20:44:29 -0700 | [diff] [blame] | 1542 | UpdateLocal(register_index, constant); |
| 1543 | break; |
| 1544 | } |
| 1545 | |
| 1546 | case Instruction::CONST_HIGH16: { |
| 1547 | int32_t register_index = instruction.VRegA(); |
David Brazdil | 8d5b8b2 | 2015-03-24 10:51:52 +0000 | [diff] [blame] | 1548 | HIntConstant* constant = graph_->GetIntConstant(instruction.VRegB_21h() << 16); |
Dave Allison | 20dfc79 | 2014-06-16 20:44:29 -0700 | [diff] [blame] | 1549 | UpdateLocal(register_index, constant); |
| 1550 | break; |
| 1551 | } |
| 1552 | |
Nicolas Geoffray | 01bc96d | 2014-04-11 17:43:50 +0100 | [diff] [blame] | 1553 | case Instruction::CONST_WIDE_16: { |
| 1554 | int32_t register_index = instruction.VRegA(); |
Dave Allison | 20dfc79 | 2014-06-16 20:44:29 -0700 | [diff] [blame] | 1555 | // Get 16 bits of constant value, sign extended to 64 bits. |
| 1556 | int64_t value = instruction.VRegB_21s(); |
| 1557 | value <<= 48; |
| 1558 | value >>= 48; |
David Brazdil | 8d5b8b2 | 2015-03-24 10:51:52 +0000 | [diff] [blame] | 1559 | HLongConstant* constant = graph_->GetLongConstant(value); |
Nicolas Geoffray | 01bc96d | 2014-04-11 17:43:50 +0100 | [diff] [blame] | 1560 | UpdateLocal(register_index, constant); |
| 1561 | break; |
| 1562 | } |
| 1563 | |
| 1564 | case Instruction::CONST_WIDE_32: { |
| 1565 | int32_t register_index = instruction.VRegA(); |
Dave Allison | 20dfc79 | 2014-06-16 20:44:29 -0700 | [diff] [blame] | 1566 | // Get 32 bits of constant value, sign extended to 64 bits. |
| 1567 | int64_t value = instruction.VRegB_31i(); |
| 1568 | value <<= 32; |
| 1569 | value >>= 32; |
David Brazdil | 8d5b8b2 | 2015-03-24 10:51:52 +0000 | [diff] [blame] | 1570 | HLongConstant* constant = graph_->GetLongConstant(value); |
Nicolas Geoffray | 01bc96d | 2014-04-11 17:43:50 +0100 | [diff] [blame] | 1571 | UpdateLocal(register_index, constant); |
| 1572 | break; |
| 1573 | } |
| 1574 | |
| 1575 | case Instruction::CONST_WIDE: { |
| 1576 | int32_t register_index = instruction.VRegA(); |
David Brazdil | 8d5b8b2 | 2015-03-24 10:51:52 +0000 | [diff] [blame] | 1577 | HLongConstant* constant = graph_->GetLongConstant(instruction.VRegB_51l()); |
Nicolas Geoffray | b55f835 | 2014-04-07 15:26:35 +0100 | [diff] [blame] | 1578 | UpdateLocal(register_index, constant); |
| 1579 | break; |
| 1580 | } |
| 1581 | |
Dave Allison | 20dfc79 | 2014-06-16 20:44:29 -0700 | [diff] [blame] | 1582 | case Instruction::CONST_WIDE_HIGH16: { |
| 1583 | int32_t register_index = instruction.VRegA(); |
| 1584 | int64_t value = static_cast<int64_t>(instruction.VRegB_21h()) << 48; |
David Brazdil | 8d5b8b2 | 2015-03-24 10:51:52 +0000 | [diff] [blame] | 1585 | HLongConstant* constant = graph_->GetLongConstant(value); |
Dave Allison | 20dfc79 | 2014-06-16 20:44:29 -0700 | [diff] [blame] | 1586 | UpdateLocal(register_index, constant); |
| 1587 | break; |
| 1588 | } |
| 1589 | |
Nicolas Geoffray | dadf317 | 2014-11-07 16:36:02 +0000 | [diff] [blame] | 1590 | // Note that the SSA building will refine the types. |
Dave Allison | 20dfc79 | 2014-06-16 20:44:29 -0700 | [diff] [blame] | 1591 | case Instruction::MOVE: |
| 1592 | case Instruction::MOVE_FROM16: |
| 1593 | case Instruction::MOVE_16: { |
Nicolas Geoffray | 01bc96d | 2014-04-11 17:43:50 +0100 | [diff] [blame] | 1594 | HInstruction* value = LoadLocal(instruction.VRegB(), Primitive::kPrimInt); |
Nicolas Geoffray | b55f835 | 2014-04-07 15:26:35 +0100 | [diff] [blame] | 1595 | UpdateLocal(instruction.VRegA(), value); |
| 1596 | break; |
| 1597 | } |
| 1598 | |
Nicolas Geoffray | dadf317 | 2014-11-07 16:36:02 +0000 | [diff] [blame] | 1599 | // Note that the SSA building will refine the types. |
Dave Allison | 20dfc79 | 2014-06-16 20:44:29 -0700 | [diff] [blame] | 1600 | case Instruction::MOVE_WIDE: |
| 1601 | case Instruction::MOVE_WIDE_FROM16: |
| 1602 | case Instruction::MOVE_WIDE_16: { |
| 1603 | HInstruction* value = LoadLocal(instruction.VRegB(), Primitive::kPrimLong); |
| 1604 | UpdateLocal(instruction.VRegA(), value); |
| 1605 | break; |
| 1606 | } |
| 1607 | |
| 1608 | case Instruction::MOVE_OBJECT: |
| 1609 | case Instruction::MOVE_OBJECT_16: |
| 1610 | case Instruction::MOVE_OBJECT_FROM16: { |
| 1611 | HInstruction* value = LoadLocal(instruction.VRegB(), Primitive::kPrimNot); |
| 1612 | UpdateLocal(instruction.VRegA(), value); |
| 1613 | break; |
| 1614 | } |
| 1615 | |
Nicolas Geoffray | bab4ed7 | 2014-03-11 17:53:17 +0000 | [diff] [blame] | 1616 | case Instruction::RETURN_VOID: { |
Nicolas Geoffray | 01bc96d | 2014-04-11 17:43:50 +0100 | [diff] [blame] | 1617 | BuildReturn(instruction, Primitive::kPrimVoid); |
Nicolas Geoffray | 818f210 | 2014-02-18 16:43:35 +0000 | [diff] [blame] | 1618 | break; |
Nicolas Geoffray | bab4ed7 | 2014-03-11 17:53:17 +0000 | [diff] [blame] | 1619 | } |
| 1620 | |
Dave Allison | 20dfc79 | 2014-06-16 20:44:29 -0700 | [diff] [blame] | 1621 | #define IF_XX(comparison, cond) \ |
Calin Juravle | 225ff81 | 2014-11-13 16:46:39 +0000 | [diff] [blame] | 1622 | case Instruction::IF_##cond: If_22t<comparison>(instruction, dex_pc); break; \ |
| 1623 | case Instruction::IF_##cond##Z: If_21t<comparison>(instruction, dex_pc); break |
Nicolas Geoffray | b55f835 | 2014-04-07 15:26:35 +0100 | [diff] [blame] | 1624 | |
Dave Allison | 20dfc79 | 2014-06-16 20:44:29 -0700 | [diff] [blame] | 1625 | IF_XX(HEqual, EQ); |
| 1626 | IF_XX(HNotEqual, NE); |
| 1627 | IF_XX(HLessThan, LT); |
| 1628 | IF_XX(HLessThanOrEqual, LE); |
| 1629 | IF_XX(HGreaterThan, GT); |
| 1630 | IF_XX(HGreaterThanOrEqual, GE); |
Nicolas Geoffray | bab4ed7 | 2014-03-11 17:53:17 +0000 | [diff] [blame] | 1631 | |
Nicolas Geoffray | be9a92a | 2014-02-25 14:22:56 +0000 | [diff] [blame] | 1632 | case Instruction::GOTO: |
| 1633 | case Instruction::GOTO_16: |
| 1634 | case Instruction::GOTO_32: { |
Nicolas Geoffray | fbc695f | 2014-09-15 15:33:30 +0000 | [diff] [blame] | 1635 | int32_t offset = instruction.GetTargetOffset(); |
Calin Juravle | 225ff81 | 2014-11-13 16:46:39 +0000 | [diff] [blame] | 1636 | HBasicBlock* target = FindBlockStartingAt(offset + dex_pc); |
Nicolas Geoffray | be9a92a | 2014-02-25 14:22:56 +0000 | [diff] [blame] | 1637 | DCHECK(target != nullptr); |
David Brazdil | 852eaff | 2015-02-02 15:23:05 +0000 | [diff] [blame] | 1638 | PotentiallyAddSuspendCheck(target, dex_pc); |
Nicolas Geoffray | be9a92a | 2014-02-25 14:22:56 +0000 | [diff] [blame] | 1639 | current_block_->AddInstruction(new (arena_) HGoto()); |
| 1640 | current_block_->AddSuccessor(target); |
| 1641 | current_block_ = nullptr; |
| 1642 | break; |
| 1643 | } |
Nicolas Geoffray | bab4ed7 | 2014-03-11 17:53:17 +0000 | [diff] [blame] | 1644 | |
Nicolas Geoffray | 01bc96d | 2014-04-11 17:43:50 +0100 | [diff] [blame] | 1645 | case Instruction::RETURN: { |
Nicolas Geoffray | 7fb49da | 2014-10-06 09:12:41 +0100 | [diff] [blame] | 1646 | BuildReturn(instruction, return_type_); |
Nicolas Geoffray | 01bc96d | 2014-04-11 17:43:50 +0100 | [diff] [blame] | 1647 | break; |
| 1648 | } |
| 1649 | |
Nicolas Geoffray | f583e59 | 2014-04-07 13:20:42 +0100 | [diff] [blame] | 1650 | case Instruction::RETURN_OBJECT: { |
Nicolas Geoffray | 7fb49da | 2014-10-06 09:12:41 +0100 | [diff] [blame] | 1651 | BuildReturn(instruction, return_type_); |
Nicolas Geoffray | 01bc96d | 2014-04-11 17:43:50 +0100 | [diff] [blame] | 1652 | break; |
| 1653 | } |
| 1654 | |
| 1655 | case Instruction::RETURN_WIDE: { |
Nicolas Geoffray | 7fb49da | 2014-10-06 09:12:41 +0100 | [diff] [blame] | 1656 | BuildReturn(instruction, return_type_); |
Nicolas Geoffray | bab4ed7 | 2014-03-11 17:53:17 +0000 | [diff] [blame] | 1657 | break; |
| 1658 | } |
| 1659 | |
Nicolas Geoffray | e982f0b | 2014-08-13 02:11:24 +0100 | [diff] [blame] | 1660 | case Instruction::INVOKE_DIRECT: |
Nicolas Geoffray | 0d8db99 | 2014-11-11 14:40:10 +0000 | [diff] [blame] | 1661 | case Instruction::INVOKE_INTERFACE: |
| 1662 | case Instruction::INVOKE_STATIC: |
| 1663 | case Instruction::INVOKE_SUPER: |
| 1664 | case Instruction::INVOKE_VIRTUAL: { |
Nicolas Geoffray | 8ccc3f5 | 2014-03-19 10:34:11 +0000 | [diff] [blame] | 1665 | uint32_t method_idx = instruction.VRegB_35c(); |
Nicolas Geoffray | 01bc96d | 2014-04-11 17:43:50 +0100 | [diff] [blame] | 1666 | uint32_t number_of_vreg_arguments = instruction.VRegA_35c(); |
Nicolas Geoffray | 4a34a42 | 2014-04-03 10:38:37 +0100 | [diff] [blame] | 1667 | uint32_t args[5]; |
Ian Rogers | 29a2648 | 2014-05-02 15:27:29 -0700 | [diff] [blame] | 1668 | instruction.GetVarArgs(args); |
Calin Juravle | 225ff81 | 2014-11-13 16:46:39 +0000 | [diff] [blame] | 1669 | if (!BuildInvoke(instruction, dex_pc, method_idx, |
Nicolas Geoffray | dadf317 | 2014-11-07 16:36:02 +0000 | [diff] [blame] | 1670 | number_of_vreg_arguments, false, args, -1)) { |
Nicolas Geoffray | 01bc96d | 2014-04-11 17:43:50 +0100 | [diff] [blame] | 1671 | return false; |
Nicolas Geoffray | 4a34a42 | 2014-04-03 10:38:37 +0100 | [diff] [blame] | 1672 | } |
Nicolas Geoffray | 4a34a42 | 2014-04-03 10:38:37 +0100 | [diff] [blame] | 1673 | break; |
| 1674 | } |
| 1675 | |
Nicolas Geoffray | e982f0b | 2014-08-13 02:11:24 +0100 | [diff] [blame] | 1676 | case Instruction::INVOKE_DIRECT_RANGE: |
Nicolas Geoffray | 0d8db99 | 2014-11-11 14:40:10 +0000 | [diff] [blame] | 1677 | case Instruction::INVOKE_INTERFACE_RANGE: |
| 1678 | case Instruction::INVOKE_STATIC_RANGE: |
| 1679 | case Instruction::INVOKE_SUPER_RANGE: |
| 1680 | case Instruction::INVOKE_VIRTUAL_RANGE: { |
Nicolas Geoffray | 4a34a42 | 2014-04-03 10:38:37 +0100 | [diff] [blame] | 1681 | uint32_t method_idx = instruction.VRegB_3rc(); |
Nicolas Geoffray | 01bc96d | 2014-04-11 17:43:50 +0100 | [diff] [blame] | 1682 | uint32_t number_of_vreg_arguments = instruction.VRegA_3rc(); |
| 1683 | uint32_t register_index = instruction.VRegC(); |
Calin Juravle | 225ff81 | 2014-11-13 16:46:39 +0000 | [diff] [blame] | 1684 | if (!BuildInvoke(instruction, dex_pc, method_idx, |
Nicolas Geoffray | 01bc96d | 2014-04-11 17:43:50 +0100 | [diff] [blame] | 1685 | number_of_vreg_arguments, true, nullptr, register_index)) { |
Nicolas Geoffray | 4a34a42 | 2014-04-03 10:38:37 +0100 | [diff] [blame] | 1686 | return false; |
| 1687 | } |
Nicolas Geoffray | 8ccc3f5 | 2014-03-19 10:34:11 +0000 | [diff] [blame] | 1688 | break; |
| 1689 | } |
| 1690 | |
Roland Levillain | 88cb175 | 2014-10-20 16:36:47 +0100 | [diff] [blame] | 1691 | case Instruction::NEG_INT: { |
| 1692 | Unop_12x<HNeg>(instruction, Primitive::kPrimInt); |
| 1693 | break; |
| 1694 | } |
| 1695 | |
Roland Levillain | 2e07b4f | 2014-10-23 18:12:09 +0100 | [diff] [blame] | 1696 | case Instruction::NEG_LONG: { |
| 1697 | Unop_12x<HNeg>(instruction, Primitive::kPrimLong); |
| 1698 | break; |
| 1699 | } |
| 1700 | |
Roland Levillain | 3dbcb38 | 2014-10-28 17:30:07 +0000 | [diff] [blame] | 1701 | case Instruction::NEG_FLOAT: { |
| 1702 | Unop_12x<HNeg>(instruction, Primitive::kPrimFloat); |
| 1703 | break; |
| 1704 | } |
| 1705 | |
| 1706 | case Instruction::NEG_DOUBLE: { |
| 1707 | Unop_12x<HNeg>(instruction, Primitive::kPrimDouble); |
| 1708 | break; |
| 1709 | } |
| 1710 | |
Roland Levillain | 1cc5f251 | 2014-10-22 18:06:21 +0100 | [diff] [blame] | 1711 | case Instruction::NOT_INT: { |
| 1712 | Unop_12x<HNot>(instruction, Primitive::kPrimInt); |
| 1713 | break; |
| 1714 | } |
| 1715 | |
Roland Levillain | 7056643 | 2014-10-24 16:20:17 +0100 | [diff] [blame] | 1716 | case Instruction::NOT_LONG: { |
| 1717 | Unop_12x<HNot>(instruction, Primitive::kPrimLong); |
| 1718 | break; |
| 1719 | } |
| 1720 | |
Roland Levillain | dff1f28 | 2014-11-05 14:15:05 +0000 | [diff] [blame] | 1721 | case Instruction::INT_TO_LONG: { |
Roland Levillain | 624279f | 2014-12-04 11:54:28 +0000 | [diff] [blame] | 1722 | Conversion_12x(instruction, Primitive::kPrimInt, Primitive::kPrimLong, dex_pc); |
Roland Levillain | dff1f28 | 2014-11-05 14:15:05 +0000 | [diff] [blame] | 1723 | break; |
| 1724 | } |
| 1725 | |
Roland Levillain | cff1374 | 2014-11-17 14:32:17 +0000 | [diff] [blame] | 1726 | case Instruction::INT_TO_FLOAT: { |
Roland Levillain | 624279f | 2014-12-04 11:54:28 +0000 | [diff] [blame] | 1727 | Conversion_12x(instruction, Primitive::kPrimInt, Primitive::kPrimFloat, dex_pc); |
Roland Levillain | cff1374 | 2014-11-17 14:32:17 +0000 | [diff] [blame] | 1728 | break; |
| 1729 | } |
| 1730 | |
| 1731 | case Instruction::INT_TO_DOUBLE: { |
Roland Levillain | 624279f | 2014-12-04 11:54:28 +0000 | [diff] [blame] | 1732 | Conversion_12x(instruction, Primitive::kPrimInt, Primitive::kPrimDouble, dex_pc); |
Roland Levillain | cff1374 | 2014-11-17 14:32:17 +0000 | [diff] [blame] | 1733 | break; |
| 1734 | } |
| 1735 | |
Roland Levillain | 946e143 | 2014-11-11 17:35:19 +0000 | [diff] [blame] | 1736 | case Instruction::LONG_TO_INT: { |
Roland Levillain | 624279f | 2014-12-04 11:54:28 +0000 | [diff] [blame] | 1737 | Conversion_12x(instruction, Primitive::kPrimLong, Primitive::kPrimInt, dex_pc); |
Roland Levillain | 946e143 | 2014-11-11 17:35:19 +0000 | [diff] [blame] | 1738 | break; |
| 1739 | } |
| 1740 | |
Roland Levillain | 6d0e483 | 2014-11-27 18:31:21 +0000 | [diff] [blame] | 1741 | case Instruction::LONG_TO_FLOAT: { |
Roland Levillain | 624279f | 2014-12-04 11:54:28 +0000 | [diff] [blame] | 1742 | Conversion_12x(instruction, Primitive::kPrimLong, Primitive::kPrimFloat, dex_pc); |
Roland Levillain | 6d0e483 | 2014-11-27 18:31:21 +0000 | [diff] [blame] | 1743 | break; |
| 1744 | } |
| 1745 | |
Roland Levillain | 647b9ed | 2014-11-27 12:06:00 +0000 | [diff] [blame] | 1746 | case Instruction::LONG_TO_DOUBLE: { |
Roland Levillain | 624279f | 2014-12-04 11:54:28 +0000 | [diff] [blame] | 1747 | Conversion_12x(instruction, Primitive::kPrimLong, Primitive::kPrimDouble, dex_pc); |
Roland Levillain | 647b9ed | 2014-11-27 12:06:00 +0000 | [diff] [blame] | 1748 | break; |
| 1749 | } |
| 1750 | |
Roland Levillain | 3f8f936 | 2014-12-02 17:45:01 +0000 | [diff] [blame] | 1751 | case Instruction::FLOAT_TO_INT: { |
Roland Levillain | 624279f | 2014-12-04 11:54:28 +0000 | [diff] [blame] | 1752 | Conversion_12x(instruction, Primitive::kPrimFloat, Primitive::kPrimInt, dex_pc); |
| 1753 | break; |
| 1754 | } |
| 1755 | |
| 1756 | case Instruction::FLOAT_TO_LONG: { |
| 1757 | Conversion_12x(instruction, Primitive::kPrimFloat, Primitive::kPrimLong, dex_pc); |
Roland Levillain | 3f8f936 | 2014-12-02 17:45:01 +0000 | [diff] [blame] | 1758 | break; |
| 1759 | } |
| 1760 | |
Roland Levillain | 8964e2b | 2014-12-04 12:10:50 +0000 | [diff] [blame] | 1761 | case Instruction::FLOAT_TO_DOUBLE: { |
| 1762 | Conversion_12x(instruction, Primitive::kPrimFloat, Primitive::kPrimDouble, dex_pc); |
| 1763 | break; |
| 1764 | } |
| 1765 | |
Roland Levillain | 4c0b61f | 2014-12-05 12:06:01 +0000 | [diff] [blame] | 1766 | case Instruction::DOUBLE_TO_INT: { |
| 1767 | Conversion_12x(instruction, Primitive::kPrimDouble, Primitive::kPrimInt, dex_pc); |
| 1768 | break; |
| 1769 | } |
| 1770 | |
| 1771 | case Instruction::DOUBLE_TO_LONG: { |
| 1772 | Conversion_12x(instruction, Primitive::kPrimDouble, Primitive::kPrimLong, dex_pc); |
| 1773 | break; |
| 1774 | } |
| 1775 | |
Roland Levillain | 8964e2b | 2014-12-04 12:10:50 +0000 | [diff] [blame] | 1776 | case Instruction::DOUBLE_TO_FLOAT: { |
| 1777 | Conversion_12x(instruction, Primitive::kPrimDouble, Primitive::kPrimFloat, dex_pc); |
| 1778 | break; |
| 1779 | } |
| 1780 | |
Roland Levillain | 51d3fc4 | 2014-11-13 14:11:42 +0000 | [diff] [blame] | 1781 | case Instruction::INT_TO_BYTE: { |
Roland Levillain | 624279f | 2014-12-04 11:54:28 +0000 | [diff] [blame] | 1782 | Conversion_12x(instruction, Primitive::kPrimInt, Primitive::kPrimByte, dex_pc); |
Roland Levillain | 51d3fc4 | 2014-11-13 14:11:42 +0000 | [diff] [blame] | 1783 | break; |
| 1784 | } |
| 1785 | |
Roland Levillain | 01a8d71 | 2014-11-14 16:27:39 +0000 | [diff] [blame] | 1786 | case Instruction::INT_TO_SHORT: { |
Roland Levillain | 624279f | 2014-12-04 11:54:28 +0000 | [diff] [blame] | 1787 | Conversion_12x(instruction, Primitive::kPrimInt, Primitive::kPrimShort, dex_pc); |
Roland Levillain | 01a8d71 | 2014-11-14 16:27:39 +0000 | [diff] [blame] | 1788 | break; |
| 1789 | } |
| 1790 | |
Roland Levillain | 981e454 | 2014-11-14 11:47:14 +0000 | [diff] [blame] | 1791 | case Instruction::INT_TO_CHAR: { |
Roland Levillain | 624279f | 2014-12-04 11:54:28 +0000 | [diff] [blame] | 1792 | Conversion_12x(instruction, Primitive::kPrimInt, Primitive::kPrimChar, dex_pc); |
Roland Levillain | 981e454 | 2014-11-14 11:47:14 +0000 | [diff] [blame] | 1793 | break; |
| 1794 | } |
| 1795 | |
Nicolas Geoffray | d8ee737 | 2014-03-28 15:43:40 +0000 | [diff] [blame] | 1796 | case Instruction::ADD_INT: { |
Nicolas Geoffray | 412f10c | 2014-06-19 10:00:34 +0100 | [diff] [blame] | 1797 | Binop_23x<HAdd>(instruction, Primitive::kPrimInt); |
Nicolas Geoffray | 01bc96d | 2014-04-11 17:43:50 +0100 | [diff] [blame] | 1798 | break; |
| 1799 | } |
| 1800 | |
| 1801 | case Instruction::ADD_LONG: { |
Nicolas Geoffray | 412f10c | 2014-06-19 10:00:34 +0100 | [diff] [blame] | 1802 | Binop_23x<HAdd>(instruction, Primitive::kPrimLong); |
Nicolas Geoffray | f583e59 | 2014-04-07 13:20:42 +0100 | [diff] [blame] | 1803 | break; |
| 1804 | } |
| 1805 | |
Nicolas Geoffray | 7fb49da | 2014-10-06 09:12:41 +0100 | [diff] [blame] | 1806 | case Instruction::ADD_DOUBLE: { |
| 1807 | Binop_23x<HAdd>(instruction, Primitive::kPrimDouble); |
| 1808 | break; |
| 1809 | } |
| 1810 | |
| 1811 | case Instruction::ADD_FLOAT: { |
| 1812 | Binop_23x<HAdd>(instruction, Primitive::kPrimFloat); |
| 1813 | break; |
| 1814 | } |
| 1815 | |
Nicolas Geoffray | f583e59 | 2014-04-07 13:20:42 +0100 | [diff] [blame] | 1816 | case Instruction::SUB_INT: { |
Nicolas Geoffray | 412f10c | 2014-06-19 10:00:34 +0100 | [diff] [blame] | 1817 | Binop_23x<HSub>(instruction, Primitive::kPrimInt); |
Nicolas Geoffray | 01bc96d | 2014-04-11 17:43:50 +0100 | [diff] [blame] | 1818 | break; |
| 1819 | } |
| 1820 | |
| 1821 | case Instruction::SUB_LONG: { |
Nicolas Geoffray | 412f10c | 2014-06-19 10:00:34 +0100 | [diff] [blame] | 1822 | Binop_23x<HSub>(instruction, Primitive::kPrimLong); |
Nicolas Geoffray | d8ee737 | 2014-03-28 15:43:40 +0000 | [diff] [blame] | 1823 | break; |
| 1824 | } |
| 1825 | |
Calin Juravle | 096cc02 | 2014-10-23 17:01:13 +0100 | [diff] [blame] | 1826 | case Instruction::SUB_FLOAT: { |
| 1827 | Binop_23x<HSub>(instruction, Primitive::kPrimFloat); |
| 1828 | break; |
| 1829 | } |
| 1830 | |
| 1831 | case Instruction::SUB_DOUBLE: { |
| 1832 | Binop_23x<HSub>(instruction, Primitive::kPrimDouble); |
| 1833 | break; |
| 1834 | } |
| 1835 | |
Nicolas Geoffray | d8ee737 | 2014-03-28 15:43:40 +0000 | [diff] [blame] | 1836 | case Instruction::ADD_INT_2ADDR: { |
Nicolas Geoffray | 01bc96d | 2014-04-11 17:43:50 +0100 | [diff] [blame] | 1837 | Binop_12x<HAdd>(instruction, Primitive::kPrimInt); |
| 1838 | break; |
| 1839 | } |
| 1840 | |
Calin Juravle | 34bacdf | 2014-10-07 20:23:36 +0100 | [diff] [blame] | 1841 | case Instruction::MUL_INT: { |
| 1842 | Binop_23x<HMul>(instruction, Primitive::kPrimInt); |
| 1843 | break; |
| 1844 | } |
| 1845 | |
| 1846 | case Instruction::MUL_LONG: { |
| 1847 | Binop_23x<HMul>(instruction, Primitive::kPrimLong); |
| 1848 | break; |
| 1849 | } |
| 1850 | |
Calin Juravle | b5bfa96 | 2014-10-21 18:02:24 +0100 | [diff] [blame] | 1851 | case Instruction::MUL_FLOAT: { |
| 1852 | Binop_23x<HMul>(instruction, Primitive::kPrimFloat); |
| 1853 | break; |
| 1854 | } |
| 1855 | |
| 1856 | case Instruction::MUL_DOUBLE: { |
| 1857 | Binop_23x<HMul>(instruction, Primitive::kPrimDouble); |
| 1858 | break; |
| 1859 | } |
| 1860 | |
Calin Juravle | d0d4852 | 2014-11-04 16:40:20 +0000 | [diff] [blame] | 1861 | case Instruction::DIV_INT: { |
Calin Juravle | bacfec3 | 2014-11-14 15:54:36 +0000 | [diff] [blame] | 1862 | BuildCheckedDivRem(instruction.VRegA(), instruction.VRegB(), instruction.VRegC(), |
| 1863 | dex_pc, Primitive::kPrimInt, false, true); |
Calin Juravle | d0d4852 | 2014-11-04 16:40:20 +0000 | [diff] [blame] | 1864 | break; |
| 1865 | } |
| 1866 | |
Calin Juravle | d6fb6cf | 2014-11-11 19:07:44 +0000 | [diff] [blame] | 1867 | case Instruction::DIV_LONG: { |
Calin Juravle | bacfec3 | 2014-11-14 15:54:36 +0000 | [diff] [blame] | 1868 | BuildCheckedDivRem(instruction.VRegA(), instruction.VRegB(), instruction.VRegC(), |
| 1869 | dex_pc, Primitive::kPrimLong, false, true); |
Calin Juravle | d6fb6cf | 2014-11-11 19:07:44 +0000 | [diff] [blame] | 1870 | break; |
| 1871 | } |
| 1872 | |
Calin Juravle | 7c4954d | 2014-10-28 16:57:40 +0000 | [diff] [blame] | 1873 | case Instruction::DIV_FLOAT: { |
Calin Juravle | 225ff81 | 2014-11-13 16:46:39 +0000 | [diff] [blame] | 1874 | Binop_23x<HDiv>(instruction, Primitive::kPrimFloat, dex_pc); |
Calin Juravle | 7c4954d | 2014-10-28 16:57:40 +0000 | [diff] [blame] | 1875 | break; |
| 1876 | } |
| 1877 | |
| 1878 | case Instruction::DIV_DOUBLE: { |
Calin Juravle | 225ff81 | 2014-11-13 16:46:39 +0000 | [diff] [blame] | 1879 | Binop_23x<HDiv>(instruction, Primitive::kPrimDouble, dex_pc); |
Calin Juravle | 7c4954d | 2014-10-28 16:57:40 +0000 | [diff] [blame] | 1880 | break; |
| 1881 | } |
| 1882 | |
Calin Juravle | bacfec3 | 2014-11-14 15:54:36 +0000 | [diff] [blame] | 1883 | case Instruction::REM_INT: { |
| 1884 | BuildCheckedDivRem(instruction.VRegA(), instruction.VRegB(), instruction.VRegC(), |
| 1885 | dex_pc, Primitive::kPrimInt, false, false); |
| 1886 | break; |
| 1887 | } |
| 1888 | |
| 1889 | case Instruction::REM_LONG: { |
| 1890 | BuildCheckedDivRem(instruction.VRegA(), instruction.VRegB(), instruction.VRegC(), |
| 1891 | dex_pc, Primitive::kPrimLong, false, false); |
| 1892 | break; |
| 1893 | } |
| 1894 | |
Calin Juravle | d2ec87d | 2014-12-08 14:24:46 +0000 | [diff] [blame] | 1895 | case Instruction::REM_FLOAT: { |
| 1896 | Binop_23x<HRem>(instruction, Primitive::kPrimFloat, dex_pc); |
| 1897 | break; |
| 1898 | } |
| 1899 | |
| 1900 | case Instruction::REM_DOUBLE: { |
| 1901 | Binop_23x<HRem>(instruction, Primitive::kPrimDouble, dex_pc); |
| 1902 | break; |
| 1903 | } |
| 1904 | |
Nicolas Geoffray | 9574c4b | 2014-11-12 13:19:37 +0000 | [diff] [blame] | 1905 | case Instruction::AND_INT: { |
| 1906 | Binop_23x<HAnd>(instruction, Primitive::kPrimInt); |
| 1907 | break; |
| 1908 | } |
| 1909 | |
| 1910 | case Instruction::AND_LONG: { |
| 1911 | Binop_23x<HAnd>(instruction, Primitive::kPrimLong); |
| 1912 | break; |
| 1913 | } |
| 1914 | |
Calin Juravle | 9aec02f | 2014-11-18 23:06:35 +0000 | [diff] [blame] | 1915 | case Instruction::SHL_INT: { |
| 1916 | Binop_23x_shift<HShl>(instruction, Primitive::kPrimInt); |
| 1917 | break; |
| 1918 | } |
| 1919 | |
| 1920 | case Instruction::SHL_LONG: { |
| 1921 | Binop_23x_shift<HShl>(instruction, Primitive::kPrimLong); |
| 1922 | break; |
| 1923 | } |
| 1924 | |
| 1925 | case Instruction::SHR_INT: { |
| 1926 | Binop_23x_shift<HShr>(instruction, Primitive::kPrimInt); |
| 1927 | break; |
| 1928 | } |
| 1929 | |
| 1930 | case Instruction::SHR_LONG: { |
| 1931 | Binop_23x_shift<HShr>(instruction, Primitive::kPrimLong); |
| 1932 | break; |
| 1933 | } |
| 1934 | |
| 1935 | case Instruction::USHR_INT: { |
| 1936 | Binop_23x_shift<HUShr>(instruction, Primitive::kPrimInt); |
| 1937 | break; |
| 1938 | } |
| 1939 | |
| 1940 | case Instruction::USHR_LONG: { |
| 1941 | Binop_23x_shift<HUShr>(instruction, Primitive::kPrimLong); |
| 1942 | break; |
| 1943 | } |
| 1944 | |
Nicolas Geoffray | 9574c4b | 2014-11-12 13:19:37 +0000 | [diff] [blame] | 1945 | case Instruction::OR_INT: { |
| 1946 | Binop_23x<HOr>(instruction, Primitive::kPrimInt); |
| 1947 | break; |
| 1948 | } |
| 1949 | |
| 1950 | case Instruction::OR_LONG: { |
| 1951 | Binop_23x<HOr>(instruction, Primitive::kPrimLong); |
| 1952 | break; |
| 1953 | } |
| 1954 | |
| 1955 | case Instruction::XOR_INT: { |
| 1956 | Binop_23x<HXor>(instruction, Primitive::kPrimInt); |
| 1957 | break; |
| 1958 | } |
| 1959 | |
| 1960 | case Instruction::XOR_LONG: { |
| 1961 | Binop_23x<HXor>(instruction, Primitive::kPrimLong); |
| 1962 | break; |
| 1963 | } |
| 1964 | |
Nicolas Geoffray | 01bc96d | 2014-04-11 17:43:50 +0100 | [diff] [blame] | 1965 | case Instruction::ADD_LONG_2ADDR: { |
| 1966 | Binop_12x<HAdd>(instruction, Primitive::kPrimLong); |
Nicolas Geoffray | f583e59 | 2014-04-07 13:20:42 +0100 | [diff] [blame] | 1967 | break; |
| 1968 | } |
| 1969 | |
Nicolas Geoffray | 7fb49da | 2014-10-06 09:12:41 +0100 | [diff] [blame] | 1970 | case Instruction::ADD_DOUBLE_2ADDR: { |
| 1971 | Binop_12x<HAdd>(instruction, Primitive::kPrimDouble); |
| 1972 | break; |
| 1973 | } |
| 1974 | |
| 1975 | case Instruction::ADD_FLOAT_2ADDR: { |
| 1976 | Binop_12x<HAdd>(instruction, Primitive::kPrimFloat); |
| 1977 | break; |
| 1978 | } |
| 1979 | |
Nicolas Geoffray | f583e59 | 2014-04-07 13:20:42 +0100 | [diff] [blame] | 1980 | case Instruction::SUB_INT_2ADDR: { |
Nicolas Geoffray | 01bc96d | 2014-04-11 17:43:50 +0100 | [diff] [blame] | 1981 | Binop_12x<HSub>(instruction, Primitive::kPrimInt); |
| 1982 | break; |
| 1983 | } |
| 1984 | |
| 1985 | case Instruction::SUB_LONG_2ADDR: { |
| 1986 | Binop_12x<HSub>(instruction, Primitive::kPrimLong); |
Nicolas Geoffray | d8ee737 | 2014-03-28 15:43:40 +0000 | [diff] [blame] | 1987 | break; |
| 1988 | } |
| 1989 | |
Calin Juravle | 096cc02 | 2014-10-23 17:01:13 +0100 | [diff] [blame] | 1990 | case Instruction::SUB_FLOAT_2ADDR: { |
| 1991 | Binop_12x<HSub>(instruction, Primitive::kPrimFloat); |
| 1992 | break; |
| 1993 | } |
| 1994 | |
| 1995 | case Instruction::SUB_DOUBLE_2ADDR: { |
| 1996 | Binop_12x<HSub>(instruction, Primitive::kPrimDouble); |
| 1997 | break; |
| 1998 | } |
| 1999 | |
Calin Juravle | 34bacdf | 2014-10-07 20:23:36 +0100 | [diff] [blame] | 2000 | case Instruction::MUL_INT_2ADDR: { |
| 2001 | Binop_12x<HMul>(instruction, Primitive::kPrimInt); |
| 2002 | break; |
| 2003 | } |
| 2004 | |
| 2005 | case Instruction::MUL_LONG_2ADDR: { |
| 2006 | Binop_12x<HMul>(instruction, Primitive::kPrimLong); |
| 2007 | break; |
| 2008 | } |
| 2009 | |
Calin Juravle | b5bfa96 | 2014-10-21 18:02:24 +0100 | [diff] [blame] | 2010 | case Instruction::MUL_FLOAT_2ADDR: { |
| 2011 | Binop_12x<HMul>(instruction, Primitive::kPrimFloat); |
| 2012 | break; |
| 2013 | } |
| 2014 | |
| 2015 | case Instruction::MUL_DOUBLE_2ADDR: { |
| 2016 | Binop_12x<HMul>(instruction, Primitive::kPrimDouble); |
| 2017 | break; |
| 2018 | } |
| 2019 | |
Calin Juravle | 865fc88 | 2014-11-06 17:09:03 +0000 | [diff] [blame] | 2020 | case Instruction::DIV_INT_2ADDR: { |
Calin Juravle | bacfec3 | 2014-11-14 15:54:36 +0000 | [diff] [blame] | 2021 | BuildCheckedDivRem(instruction.VRegA(), instruction.VRegA(), instruction.VRegB(), |
| 2022 | dex_pc, Primitive::kPrimInt, false, true); |
Calin Juravle | 865fc88 | 2014-11-06 17:09:03 +0000 | [diff] [blame] | 2023 | break; |
| 2024 | } |
| 2025 | |
Calin Juravle | d6fb6cf | 2014-11-11 19:07:44 +0000 | [diff] [blame] | 2026 | case Instruction::DIV_LONG_2ADDR: { |
Calin Juravle | bacfec3 | 2014-11-14 15:54:36 +0000 | [diff] [blame] | 2027 | BuildCheckedDivRem(instruction.VRegA(), instruction.VRegA(), instruction.VRegB(), |
| 2028 | dex_pc, Primitive::kPrimLong, false, true); |
| 2029 | break; |
| 2030 | } |
| 2031 | |
| 2032 | case Instruction::REM_INT_2ADDR: { |
| 2033 | BuildCheckedDivRem(instruction.VRegA(), instruction.VRegA(), instruction.VRegB(), |
| 2034 | dex_pc, Primitive::kPrimInt, false, false); |
| 2035 | break; |
| 2036 | } |
| 2037 | |
| 2038 | case Instruction::REM_LONG_2ADDR: { |
| 2039 | BuildCheckedDivRem(instruction.VRegA(), instruction.VRegA(), instruction.VRegB(), |
| 2040 | dex_pc, Primitive::kPrimLong, false, false); |
Calin Juravle | d6fb6cf | 2014-11-11 19:07:44 +0000 | [diff] [blame] | 2041 | break; |
| 2042 | } |
| 2043 | |
Calin Juravle | d2ec87d | 2014-12-08 14:24:46 +0000 | [diff] [blame] | 2044 | case Instruction::REM_FLOAT_2ADDR: { |
| 2045 | Binop_12x<HRem>(instruction, Primitive::kPrimFloat, dex_pc); |
| 2046 | break; |
| 2047 | } |
| 2048 | |
| 2049 | case Instruction::REM_DOUBLE_2ADDR: { |
| 2050 | Binop_12x<HRem>(instruction, Primitive::kPrimDouble, dex_pc); |
| 2051 | break; |
| 2052 | } |
| 2053 | |
Calin Juravle | 9aec02f | 2014-11-18 23:06:35 +0000 | [diff] [blame] | 2054 | case Instruction::SHL_INT_2ADDR: { |
| 2055 | Binop_12x_shift<HShl>(instruction, Primitive::kPrimInt); |
| 2056 | break; |
| 2057 | } |
| 2058 | |
| 2059 | case Instruction::SHL_LONG_2ADDR: { |
| 2060 | Binop_12x_shift<HShl>(instruction, Primitive::kPrimLong); |
| 2061 | break; |
| 2062 | } |
| 2063 | |
| 2064 | case Instruction::SHR_INT_2ADDR: { |
| 2065 | Binop_12x_shift<HShr>(instruction, Primitive::kPrimInt); |
| 2066 | break; |
| 2067 | } |
| 2068 | |
| 2069 | case Instruction::SHR_LONG_2ADDR: { |
| 2070 | Binop_12x_shift<HShr>(instruction, Primitive::kPrimLong); |
| 2071 | break; |
| 2072 | } |
| 2073 | |
| 2074 | case Instruction::USHR_INT_2ADDR: { |
| 2075 | Binop_12x_shift<HUShr>(instruction, Primitive::kPrimInt); |
| 2076 | break; |
| 2077 | } |
| 2078 | |
| 2079 | case Instruction::USHR_LONG_2ADDR: { |
| 2080 | Binop_12x_shift<HUShr>(instruction, Primitive::kPrimLong); |
| 2081 | break; |
| 2082 | } |
| 2083 | |
Calin Juravle | 7c4954d | 2014-10-28 16:57:40 +0000 | [diff] [blame] | 2084 | case Instruction::DIV_FLOAT_2ADDR: { |
Calin Juravle | 225ff81 | 2014-11-13 16:46:39 +0000 | [diff] [blame] | 2085 | Binop_12x<HDiv>(instruction, Primitive::kPrimFloat, dex_pc); |
Calin Juravle | 7c4954d | 2014-10-28 16:57:40 +0000 | [diff] [blame] | 2086 | break; |
| 2087 | } |
| 2088 | |
| 2089 | case Instruction::DIV_DOUBLE_2ADDR: { |
Calin Juravle | 225ff81 | 2014-11-13 16:46:39 +0000 | [diff] [blame] | 2090 | Binop_12x<HDiv>(instruction, Primitive::kPrimDouble, dex_pc); |
Calin Juravle | 7c4954d | 2014-10-28 16:57:40 +0000 | [diff] [blame] | 2091 | break; |
| 2092 | } |
| 2093 | |
Nicolas Geoffray | 9574c4b | 2014-11-12 13:19:37 +0000 | [diff] [blame] | 2094 | case Instruction::AND_INT_2ADDR: { |
| 2095 | Binop_12x<HAnd>(instruction, Primitive::kPrimInt); |
| 2096 | break; |
| 2097 | } |
| 2098 | |
| 2099 | case Instruction::AND_LONG_2ADDR: { |
| 2100 | Binop_12x<HAnd>(instruction, Primitive::kPrimLong); |
| 2101 | break; |
| 2102 | } |
| 2103 | |
| 2104 | case Instruction::OR_INT_2ADDR: { |
| 2105 | Binop_12x<HOr>(instruction, Primitive::kPrimInt); |
| 2106 | break; |
| 2107 | } |
| 2108 | |
| 2109 | case Instruction::OR_LONG_2ADDR: { |
| 2110 | Binop_12x<HOr>(instruction, Primitive::kPrimLong); |
| 2111 | break; |
| 2112 | } |
| 2113 | |
| 2114 | case Instruction::XOR_INT_2ADDR: { |
| 2115 | Binop_12x<HXor>(instruction, Primitive::kPrimInt); |
| 2116 | break; |
| 2117 | } |
| 2118 | |
| 2119 | case Instruction::XOR_LONG_2ADDR: { |
| 2120 | Binop_12x<HXor>(instruction, Primitive::kPrimLong); |
| 2121 | break; |
| 2122 | } |
| 2123 | |
Nicolas Geoffray | d8ee737 | 2014-03-28 15:43:40 +0000 | [diff] [blame] | 2124 | case Instruction::ADD_INT_LIT16: { |
Nicolas Geoffray | f583e59 | 2014-04-07 13:20:42 +0100 | [diff] [blame] | 2125 | Binop_22s<HAdd>(instruction, false); |
| 2126 | break; |
| 2127 | } |
| 2128 | |
Nicolas Geoffray | 9574c4b | 2014-11-12 13:19:37 +0000 | [diff] [blame] | 2129 | case Instruction::AND_INT_LIT16: { |
| 2130 | Binop_22s<HAnd>(instruction, false); |
| 2131 | break; |
| 2132 | } |
| 2133 | |
| 2134 | case Instruction::OR_INT_LIT16: { |
| 2135 | Binop_22s<HOr>(instruction, false); |
| 2136 | break; |
| 2137 | } |
| 2138 | |
| 2139 | case Instruction::XOR_INT_LIT16: { |
| 2140 | Binop_22s<HXor>(instruction, false); |
| 2141 | break; |
| 2142 | } |
| 2143 | |
Nicolas Geoffray | f583e59 | 2014-04-07 13:20:42 +0100 | [diff] [blame] | 2144 | case Instruction::RSUB_INT: { |
| 2145 | Binop_22s<HSub>(instruction, true); |
Nicolas Geoffray | d8ee737 | 2014-03-28 15:43:40 +0000 | [diff] [blame] | 2146 | break; |
| 2147 | } |
| 2148 | |
Calin Juravle | 34bacdf | 2014-10-07 20:23:36 +0100 | [diff] [blame] | 2149 | case Instruction::MUL_INT_LIT16: { |
| 2150 | Binop_22s<HMul>(instruction, false); |
| 2151 | break; |
| 2152 | } |
| 2153 | |
Nicolas Geoffray | d8ee737 | 2014-03-28 15:43:40 +0000 | [diff] [blame] | 2154 | case Instruction::ADD_INT_LIT8: { |
Nicolas Geoffray | f583e59 | 2014-04-07 13:20:42 +0100 | [diff] [blame] | 2155 | Binop_22b<HAdd>(instruction, false); |
| 2156 | break; |
| 2157 | } |
| 2158 | |
Nicolas Geoffray | 9574c4b | 2014-11-12 13:19:37 +0000 | [diff] [blame] | 2159 | case Instruction::AND_INT_LIT8: { |
| 2160 | Binop_22b<HAnd>(instruction, false); |
| 2161 | break; |
| 2162 | } |
| 2163 | |
| 2164 | case Instruction::OR_INT_LIT8: { |
| 2165 | Binop_22b<HOr>(instruction, false); |
| 2166 | break; |
| 2167 | } |
| 2168 | |
| 2169 | case Instruction::XOR_INT_LIT8: { |
| 2170 | Binop_22b<HXor>(instruction, false); |
| 2171 | break; |
| 2172 | } |
| 2173 | |
Nicolas Geoffray | f583e59 | 2014-04-07 13:20:42 +0100 | [diff] [blame] | 2174 | case Instruction::RSUB_INT_LIT8: { |
| 2175 | Binop_22b<HSub>(instruction, true); |
Nicolas Geoffray | d8ee737 | 2014-03-28 15:43:40 +0000 | [diff] [blame] | 2176 | break; |
| 2177 | } |
| 2178 | |
Calin Juravle | 34bacdf | 2014-10-07 20:23:36 +0100 | [diff] [blame] | 2179 | case Instruction::MUL_INT_LIT8: { |
| 2180 | Binop_22b<HMul>(instruction, false); |
| 2181 | break; |
| 2182 | } |
| 2183 | |
Calin Juravle | d0d4852 | 2014-11-04 16:40:20 +0000 | [diff] [blame] | 2184 | case Instruction::DIV_INT_LIT16: |
| 2185 | case Instruction::DIV_INT_LIT8: { |
Calin Juravle | bacfec3 | 2014-11-14 15:54:36 +0000 | [diff] [blame] | 2186 | BuildCheckedDivRem(instruction.VRegA(), instruction.VRegB(), instruction.VRegC(), |
| 2187 | dex_pc, Primitive::kPrimInt, true, true); |
| 2188 | break; |
| 2189 | } |
| 2190 | |
| 2191 | case Instruction::REM_INT_LIT16: |
| 2192 | case Instruction::REM_INT_LIT8: { |
| 2193 | BuildCheckedDivRem(instruction.VRegA(), instruction.VRegB(), instruction.VRegC(), |
| 2194 | dex_pc, Primitive::kPrimInt, true, false); |
Calin Juravle | d0d4852 | 2014-11-04 16:40:20 +0000 | [diff] [blame] | 2195 | break; |
| 2196 | } |
| 2197 | |
Calin Juravle | 9aec02f | 2014-11-18 23:06:35 +0000 | [diff] [blame] | 2198 | case Instruction::SHL_INT_LIT8: { |
| 2199 | Binop_22b<HShl>(instruction, false); |
| 2200 | break; |
| 2201 | } |
| 2202 | |
| 2203 | case Instruction::SHR_INT_LIT8: { |
| 2204 | Binop_22b<HShr>(instruction, false); |
| 2205 | break; |
| 2206 | } |
| 2207 | |
| 2208 | case Instruction::USHR_INT_LIT8: { |
| 2209 | Binop_22b<HUShr>(instruction, false); |
| 2210 | break; |
| 2211 | } |
| 2212 | |
Nicolas Geoffray | 2e7038a | 2014-04-03 18:49:58 +0100 | [diff] [blame] | 2213 | case Instruction::NEW_INSTANCE: { |
Nicolas Geoffray | cb1b00a | 2015-01-28 14:50:01 +0000 | [diff] [blame] | 2214 | uint16_t type_index = instruction.VRegB_21c(); |
Jeff Hao | 848f70a | 2014-01-15 13:49:50 -0800 | [diff] [blame] | 2215 | if (compiler_driver_->IsStringTypeIndex(type_index, dex_file_)) { |
| 2216 | // Turn new-instance of string into a const 0. |
| 2217 | int32_t register_index = instruction.VRegA(); |
| 2218 | HNullConstant* constant = graph_->GetNullConstant(); |
| 2219 | UpdateLocal(register_index, constant); |
| 2220 | } else { |
| 2221 | QuickEntrypointEnum entrypoint = NeedsAccessCheck(type_index) |
| 2222 | ? kQuickAllocObjectWithAccessCheck |
| 2223 | : kQuickAllocObject; |
Nicolas Geoffray | cb1b00a | 2015-01-28 14:50:01 +0000 | [diff] [blame] | 2224 | |
Nicolas Geoffray | d5111bf | 2015-05-22 15:37:09 +0100 | [diff] [blame] | 2225 | current_block_->AddInstruction(new (arena_) HNewInstance( |
Nicolas Geoffray | 69aa601 | 2015-06-09 10:34:25 +0100 | [diff] [blame] | 2226 | graph_->GetCurrentMethod(), |
| 2227 | dex_pc, |
| 2228 | type_index, |
| 2229 | *dex_compilation_unit_->GetDexFile(), |
| 2230 | entrypoint)); |
Jeff Hao | 848f70a | 2014-01-15 13:49:50 -0800 | [diff] [blame] | 2231 | UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction()); |
| 2232 | } |
Nicolas Geoffray | 2e7038a | 2014-04-03 18:49:58 +0100 | [diff] [blame] | 2233 | break; |
| 2234 | } |
| 2235 | |
Nicolas Geoffray | a3d05a4 | 2014-10-20 17:41:32 +0100 | [diff] [blame] | 2236 | case Instruction::NEW_ARRAY: { |
Nicolas Geoffray | cb1b00a | 2015-01-28 14:50:01 +0000 | [diff] [blame] | 2237 | uint16_t type_index = instruction.VRegC_22c(); |
Nicolas Geoffray | a3d05a4 | 2014-10-20 17:41:32 +0100 | [diff] [blame] | 2238 | HInstruction* length = LoadLocal(instruction.VRegB_22c(), Primitive::kPrimInt); |
Nicolas Geoffray | cb1b00a | 2015-01-28 14:50:01 +0000 | [diff] [blame] | 2239 | QuickEntrypointEnum entrypoint = NeedsAccessCheck(type_index) |
| 2240 | ? kQuickAllocArrayWithAccessCheck |
| 2241 | : kQuickAllocArray; |
Nicolas Geoffray | 69aa601 | 2015-06-09 10:34:25 +0100 | [diff] [blame] | 2242 | current_block_->AddInstruction(new (arena_) HNewArray(length, |
| 2243 | graph_->GetCurrentMethod(), |
| 2244 | dex_pc, |
| 2245 | type_index, |
| 2246 | *dex_compilation_unit_->GetDexFile(), |
| 2247 | entrypoint)); |
Nicolas Geoffray | a3d05a4 | 2014-10-20 17:41:32 +0100 | [diff] [blame] | 2248 | UpdateLocal(instruction.VRegA_22c(), current_block_->GetLastInstruction()); |
| 2249 | break; |
| 2250 | } |
| 2251 | |
| 2252 | case Instruction::FILLED_NEW_ARRAY: { |
| 2253 | uint32_t number_of_vreg_arguments = instruction.VRegA_35c(); |
| 2254 | uint32_t type_index = instruction.VRegB_35c(); |
| 2255 | uint32_t args[5]; |
| 2256 | instruction.GetVarArgs(args); |
Calin Juravle | 225ff81 | 2014-11-13 16:46:39 +0000 | [diff] [blame] | 2257 | BuildFilledNewArray(dex_pc, type_index, number_of_vreg_arguments, false, args, 0); |
Nicolas Geoffray | a3d05a4 | 2014-10-20 17:41:32 +0100 | [diff] [blame] | 2258 | break; |
| 2259 | } |
| 2260 | |
| 2261 | case Instruction::FILLED_NEW_ARRAY_RANGE: { |
| 2262 | uint32_t number_of_vreg_arguments = instruction.VRegA_3rc(); |
| 2263 | uint32_t type_index = instruction.VRegB_3rc(); |
| 2264 | uint32_t register_index = instruction.VRegC_3rc(); |
| 2265 | BuildFilledNewArray( |
Calin Juravle | 225ff81 | 2014-11-13 16:46:39 +0000 | [diff] [blame] | 2266 | dex_pc, type_index, number_of_vreg_arguments, true, nullptr, register_index); |
Nicolas Geoffray | a3d05a4 | 2014-10-20 17:41:32 +0100 | [diff] [blame] | 2267 | break; |
| 2268 | } |
| 2269 | |
| 2270 | case Instruction::FILL_ARRAY_DATA: { |
Calin Juravle | 225ff81 | 2014-11-13 16:46:39 +0000 | [diff] [blame] | 2271 | BuildFillArrayData(instruction, dex_pc); |
Nicolas Geoffray | a3d05a4 | 2014-10-20 17:41:32 +0100 | [diff] [blame] | 2272 | break; |
| 2273 | } |
| 2274 | |
Nicolas Geoffray | ddb311f | 2014-05-16 09:28:54 +0100 | [diff] [blame] | 2275 | case Instruction::MOVE_RESULT: |
Dave Allison | 20dfc79 | 2014-06-16 20:44:29 -0700 | [diff] [blame] | 2276 | case Instruction::MOVE_RESULT_WIDE: |
David Brazdil | fc6a86a | 2015-06-26 10:33:45 +0000 | [diff] [blame] | 2277 | case Instruction::MOVE_RESULT_OBJECT: { |
Nicolas Geoffray | 1efcc22 | 2015-06-24 12:41:20 +0100 | [diff] [blame] | 2278 | if (latest_result_ == nullptr) { |
| 2279 | // Only dead code can lead to this situation, where the verifier |
| 2280 | // does not reject the method. |
| 2281 | } else { |
David Brazdil | fc6a86a | 2015-06-26 10:33:45 +0000 | [diff] [blame] | 2282 | // An Invoke/FilledNewArray and its MoveResult could have landed in |
| 2283 | // different blocks if there was a try/catch block boundary between |
| 2284 | // them. For Invoke, we insert a StoreLocal after the instruction. For |
| 2285 | // FilledNewArray, the local needs to be updated after the array was |
| 2286 | // filled, otherwise we might overwrite an input vreg. |
| 2287 | HStoreLocal* update_local = |
| 2288 | new (arena_) HStoreLocal(GetLocalAt(instruction.VRegA()), latest_result_); |
| 2289 | HBasicBlock* block = latest_result_->GetBlock(); |
| 2290 | if (block == current_block_) { |
| 2291 | // MoveResult and the previous instruction are in the same block. |
| 2292 | current_block_->AddInstruction(update_local); |
| 2293 | } else { |
| 2294 | // The two instructions are in different blocks. Insert the MoveResult |
| 2295 | // before the final control-flow instruction of the previous block. |
| 2296 | DCHECK(block->EndsWithControlFlowInstruction()); |
| 2297 | DCHECK(current_block_->GetInstructions().IsEmpty()); |
| 2298 | block->InsertInstructionBefore(update_local, block->GetLastInstruction()); |
| 2299 | } |
Nicolas Geoffray | 1efcc22 | 2015-06-24 12:41:20 +0100 | [diff] [blame] | 2300 | latest_result_ = nullptr; |
| 2301 | } |
Nicolas Geoffray | 01bc96d | 2014-04-11 17:43:50 +0100 | [diff] [blame] | 2302 | break; |
David Brazdil | fc6a86a | 2015-06-26 10:33:45 +0000 | [diff] [blame] | 2303 | } |
Nicolas Geoffray | 01bc96d | 2014-04-11 17:43:50 +0100 | [diff] [blame] | 2304 | |
Nicolas Geoffray | 412f10c | 2014-06-19 10:00:34 +0100 | [diff] [blame] | 2305 | case Instruction::CMP_LONG: { |
Alexey Frunze | 4dda337 | 2015-06-01 18:31:49 -0700 | [diff] [blame] | 2306 | Binop_23x_cmp(instruction, Primitive::kPrimLong, HCompare::kNoBias, dex_pc); |
Calin Juravle | ddb7df2 | 2014-11-25 20:56:51 +0000 | [diff] [blame] | 2307 | break; |
| 2308 | } |
| 2309 | |
| 2310 | case Instruction::CMPG_FLOAT: { |
Alexey Frunze | 4dda337 | 2015-06-01 18:31:49 -0700 | [diff] [blame] | 2311 | Binop_23x_cmp(instruction, Primitive::kPrimFloat, HCompare::kGtBias, dex_pc); |
Calin Juravle | ddb7df2 | 2014-11-25 20:56:51 +0000 | [diff] [blame] | 2312 | break; |
| 2313 | } |
| 2314 | |
| 2315 | case Instruction::CMPG_DOUBLE: { |
Alexey Frunze | 4dda337 | 2015-06-01 18:31:49 -0700 | [diff] [blame] | 2316 | Binop_23x_cmp(instruction, Primitive::kPrimDouble, HCompare::kGtBias, dex_pc); |
Calin Juravle | ddb7df2 | 2014-11-25 20:56:51 +0000 | [diff] [blame] | 2317 | break; |
| 2318 | } |
| 2319 | |
| 2320 | case Instruction::CMPL_FLOAT: { |
Alexey Frunze | 4dda337 | 2015-06-01 18:31:49 -0700 | [diff] [blame] | 2321 | Binop_23x_cmp(instruction, Primitive::kPrimFloat, HCompare::kLtBias, dex_pc); |
Calin Juravle | ddb7df2 | 2014-11-25 20:56:51 +0000 | [diff] [blame] | 2322 | break; |
| 2323 | } |
| 2324 | |
| 2325 | case Instruction::CMPL_DOUBLE: { |
Alexey Frunze | 4dda337 | 2015-06-01 18:31:49 -0700 | [diff] [blame] | 2326 | Binop_23x_cmp(instruction, Primitive::kPrimDouble, HCompare::kLtBias, dex_pc); |
Nicolas Geoffray | 412f10c | 2014-06-19 10:00:34 +0100 | [diff] [blame] | 2327 | break; |
| 2328 | } |
| 2329 | |
Nicolas Geoffray | be9a92a | 2014-02-25 14:22:56 +0000 | [diff] [blame] | 2330 | case Instruction::NOP: |
| 2331 | break; |
Nicolas Geoffray | bab4ed7 | 2014-03-11 17:53:17 +0000 | [diff] [blame] | 2332 | |
Nicolas Geoffray | e503832 | 2014-07-04 09:41:32 +0100 | [diff] [blame] | 2333 | case Instruction::IGET: |
| 2334 | case Instruction::IGET_WIDE: |
| 2335 | case Instruction::IGET_OBJECT: |
| 2336 | case Instruction::IGET_BOOLEAN: |
| 2337 | case Instruction::IGET_BYTE: |
| 2338 | case Instruction::IGET_CHAR: |
| 2339 | case Instruction::IGET_SHORT: { |
Calin Juravle | 225ff81 | 2014-11-13 16:46:39 +0000 | [diff] [blame] | 2340 | if (!BuildInstanceFieldAccess(instruction, dex_pc, false)) { |
Nicolas Geoffray | e503832 | 2014-07-04 09:41:32 +0100 | [diff] [blame] | 2341 | return false; |
| 2342 | } |
| 2343 | break; |
| 2344 | } |
| 2345 | |
| 2346 | case Instruction::IPUT: |
| 2347 | case Instruction::IPUT_WIDE: |
| 2348 | case Instruction::IPUT_OBJECT: |
| 2349 | case Instruction::IPUT_BOOLEAN: |
| 2350 | case Instruction::IPUT_BYTE: |
| 2351 | case Instruction::IPUT_CHAR: |
| 2352 | case Instruction::IPUT_SHORT: { |
Calin Juravle | 225ff81 | 2014-11-13 16:46:39 +0000 | [diff] [blame] | 2353 | if (!BuildInstanceFieldAccess(instruction, dex_pc, true)) { |
Nicolas Geoffray | 19a19cf | 2014-10-22 16:07:05 +0100 | [diff] [blame] | 2354 | return false; |
| 2355 | } |
| 2356 | break; |
| 2357 | } |
| 2358 | |
| 2359 | case Instruction::SGET: |
| 2360 | case Instruction::SGET_WIDE: |
| 2361 | case Instruction::SGET_OBJECT: |
| 2362 | case Instruction::SGET_BOOLEAN: |
| 2363 | case Instruction::SGET_BYTE: |
| 2364 | case Instruction::SGET_CHAR: |
| 2365 | case Instruction::SGET_SHORT: { |
Calin Juravle | 225ff81 | 2014-11-13 16:46:39 +0000 | [diff] [blame] | 2366 | if (!BuildStaticFieldAccess(instruction, dex_pc, false)) { |
Nicolas Geoffray | 19a19cf | 2014-10-22 16:07:05 +0100 | [diff] [blame] | 2367 | return false; |
| 2368 | } |
| 2369 | break; |
| 2370 | } |
| 2371 | |
| 2372 | case Instruction::SPUT: |
| 2373 | case Instruction::SPUT_WIDE: |
| 2374 | case Instruction::SPUT_OBJECT: |
| 2375 | case Instruction::SPUT_BOOLEAN: |
| 2376 | case Instruction::SPUT_BYTE: |
| 2377 | case Instruction::SPUT_CHAR: |
| 2378 | case Instruction::SPUT_SHORT: { |
Calin Juravle | 225ff81 | 2014-11-13 16:46:39 +0000 | [diff] [blame] | 2379 | if (!BuildStaticFieldAccess(instruction, dex_pc, true)) { |
Nicolas Geoffray | e503832 | 2014-07-04 09:41:32 +0100 | [diff] [blame] | 2380 | return false; |
| 2381 | } |
| 2382 | break; |
| 2383 | } |
| 2384 | |
Nicolas Geoffray | 3c7bb98 | 2014-07-23 16:04:16 +0100 | [diff] [blame] | 2385 | #define ARRAY_XX(kind, anticipated_type) \ |
| 2386 | case Instruction::AGET##kind: { \ |
Calin Juravle | 225ff81 | 2014-11-13 16:46:39 +0000 | [diff] [blame] | 2387 | BuildArrayAccess(instruction, dex_pc, false, anticipated_type); \ |
Nicolas Geoffray | 3c7bb98 | 2014-07-23 16:04:16 +0100 | [diff] [blame] | 2388 | break; \ |
| 2389 | } \ |
| 2390 | case Instruction::APUT##kind: { \ |
Calin Juravle | 225ff81 | 2014-11-13 16:46:39 +0000 | [diff] [blame] | 2391 | BuildArrayAccess(instruction, dex_pc, true, anticipated_type); \ |
Nicolas Geoffray | 3c7bb98 | 2014-07-23 16:04:16 +0100 | [diff] [blame] | 2392 | break; \ |
| 2393 | } |
| 2394 | |
| 2395 | ARRAY_XX(, Primitive::kPrimInt); |
| 2396 | ARRAY_XX(_WIDE, Primitive::kPrimLong); |
| 2397 | ARRAY_XX(_OBJECT, Primitive::kPrimNot); |
| 2398 | ARRAY_XX(_BOOLEAN, Primitive::kPrimBoolean); |
| 2399 | ARRAY_XX(_BYTE, Primitive::kPrimByte); |
| 2400 | ARRAY_XX(_CHAR, Primitive::kPrimChar); |
| 2401 | ARRAY_XX(_SHORT, Primitive::kPrimShort); |
| 2402 | |
Nicolas Geoffray | 3946844 | 2014-09-02 15:17:15 +0100 | [diff] [blame] | 2403 | case Instruction::ARRAY_LENGTH: { |
| 2404 | HInstruction* object = LoadLocal(instruction.VRegB_12x(), Primitive::kPrimNot); |
Nicolas Geoffray | de58ab2 | 2014-11-05 12:46:03 +0000 | [diff] [blame] | 2405 | // No need for a temporary for the null check, it is the only input of the following |
| 2406 | // instruction. |
Calin Juravle | 225ff81 | 2014-11-13 16:46:39 +0000 | [diff] [blame] | 2407 | object = new (arena_) HNullCheck(object, dex_pc); |
Nicolas Geoffray | de58ab2 | 2014-11-05 12:46:03 +0000 | [diff] [blame] | 2408 | current_block_->AddInstruction(object); |
Nicolas Geoffray | 3946844 | 2014-09-02 15:17:15 +0100 | [diff] [blame] | 2409 | current_block_->AddInstruction(new (arena_) HArrayLength(object)); |
| 2410 | UpdateLocal(instruction.VRegA_12x(), current_block_->GetLastInstruction()); |
| 2411 | break; |
| 2412 | } |
| 2413 | |
Nicolas Geoffray | b5f62b3 | 2014-10-30 10:58:41 +0000 | [diff] [blame] | 2414 | case Instruction::CONST_STRING: { |
Nicolas Geoffray | fbdaa30 | 2015-05-29 12:06:56 +0100 | [diff] [blame] | 2415 | current_block_->AddInstruction( |
| 2416 | new (arena_) HLoadString(graph_->GetCurrentMethod(), instruction.VRegB_21c(), dex_pc)); |
Nicolas Geoffray | b5f62b3 | 2014-10-30 10:58:41 +0000 | [diff] [blame] | 2417 | UpdateLocal(instruction.VRegA_21c(), current_block_->GetLastInstruction()); |
| 2418 | break; |
| 2419 | } |
| 2420 | |
| 2421 | case Instruction::CONST_STRING_JUMBO: { |
Nicolas Geoffray | fbdaa30 | 2015-05-29 12:06:56 +0100 | [diff] [blame] | 2422 | current_block_->AddInstruction( |
| 2423 | new (arena_) HLoadString(graph_->GetCurrentMethod(), instruction.VRegB_31c(), dex_pc)); |
Nicolas Geoffray | b5f62b3 | 2014-10-30 10:58:41 +0000 | [diff] [blame] | 2424 | UpdateLocal(instruction.VRegA_31c(), current_block_->GetLastInstruction()); |
| 2425 | break; |
| 2426 | } |
| 2427 | |
Nicolas Geoffray | 424f676 | 2014-11-03 14:51:25 +0000 | [diff] [blame] | 2428 | case Instruction::CONST_CLASS: { |
| 2429 | uint16_t type_index = instruction.VRegB_21c(); |
| 2430 | bool type_known_final; |
| 2431 | bool type_known_abstract; |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 2432 | bool dont_use_is_referrers_class; |
| 2433 | // `CanAccessTypeWithoutChecks` will tell whether the method being |
| 2434 | // built is trying to access its own class, so that the generated |
| 2435 | // code can optimize for this case. However, the optimization does not |
Nicolas Geoffray | 9437b78 | 2015-03-25 10:08:51 +0000 | [diff] [blame] | 2436 | // work for inlining, so we use `IsOutermostCompilingClass` instead. |
Nicolas Geoffray | 424f676 | 2014-11-03 14:51:25 +0000 | [diff] [blame] | 2437 | bool can_access = compiler_driver_->CanAccessTypeWithoutChecks( |
| 2438 | dex_compilation_unit_->GetDexMethodIndex(), *dex_file_, type_index, |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 2439 | &type_known_final, &type_known_abstract, &dont_use_is_referrers_class); |
Nicolas Geoffray | 424f676 | 2014-11-03 14:51:25 +0000 | [diff] [blame] | 2440 | if (!can_access) { |
Calin Juravle | 48c2b03 | 2014-12-09 18:11:36 +0000 | [diff] [blame] | 2441 | MaybeRecordStat(MethodCompilationStat::kNotCompiledCantAccesType); |
Nicolas Geoffray | 424f676 | 2014-11-03 14:51:25 +0000 | [diff] [blame] | 2442 | return false; |
| 2443 | } |
Nicolas Geoffray | d5111bf | 2015-05-22 15:37:09 +0100 | [diff] [blame] | 2444 | current_block_->AddInstruction(new (arena_) HLoadClass( |
Nicolas Geoffray | 76b1e17 | 2015-05-27 17:18:33 +0100 | [diff] [blame] | 2445 | graph_->GetCurrentMethod(), |
Nicolas Geoffray | d5111bf | 2015-05-22 15:37:09 +0100 | [diff] [blame] | 2446 | type_index, |
| 2447 | *dex_compilation_unit_->GetDexFile(), |
| 2448 | IsOutermostCompilingClass(type_index), |
| 2449 | dex_pc)); |
Nicolas Geoffray | 424f676 | 2014-11-03 14:51:25 +0000 | [diff] [blame] | 2450 | UpdateLocal(instruction.VRegA_21c(), current_block_->GetLastInstruction()); |
| 2451 | break; |
| 2452 | } |
| 2453 | |
Nicolas Geoffray | de58ab2 | 2014-11-05 12:46:03 +0000 | [diff] [blame] | 2454 | case Instruction::MOVE_EXCEPTION: { |
| 2455 | current_block_->AddInstruction(new (arena_) HLoadException()); |
| 2456 | UpdateLocal(instruction.VRegA_11x(), current_block_->GetLastInstruction()); |
| 2457 | break; |
| 2458 | } |
| 2459 | |
| 2460 | case Instruction::THROW: { |
| 2461 | HInstruction* exception = LoadLocal(instruction.VRegA_11x(), Primitive::kPrimNot); |
Calin Juravle | 225ff81 | 2014-11-13 16:46:39 +0000 | [diff] [blame] | 2462 | current_block_->AddInstruction(new (arena_) HThrow(exception, dex_pc)); |
Nicolas Geoffray | de58ab2 | 2014-11-05 12:46:03 +0000 | [diff] [blame] | 2463 | // A throw instruction must branch to the exit block. |
| 2464 | current_block_->AddSuccessor(exit_block_); |
| 2465 | // We finished building this block. Set the current block to null to avoid |
| 2466 | // adding dead instructions to it. |
| 2467 | current_block_ = nullptr; |
| 2468 | break; |
| 2469 | } |
| 2470 | |
Nicolas Geoffray | 6f5c41f | 2014-11-06 08:59:20 +0000 | [diff] [blame] | 2471 | case Instruction::INSTANCE_OF: { |
Nicolas Geoffray | 57a88d4 | 2014-11-10 15:09:21 +0000 | [diff] [blame] | 2472 | uint8_t destination = instruction.VRegA_22c(); |
| 2473 | uint8_t reference = instruction.VRegB_22c(); |
Nicolas Geoffray | 6f5c41f | 2014-11-06 08:59:20 +0000 | [diff] [blame] | 2474 | uint16_t type_index = instruction.VRegC_22c(); |
Calin Juravle | 225ff81 | 2014-11-13 16:46:39 +0000 | [diff] [blame] | 2475 | if (!BuildTypeCheck(instruction, destination, reference, type_index, dex_pc)) { |
Nicolas Geoffray | 6f5c41f | 2014-11-06 08:59:20 +0000 | [diff] [blame] | 2476 | return false; |
| 2477 | } |
Nicolas Geoffray | 57a88d4 | 2014-11-10 15:09:21 +0000 | [diff] [blame] | 2478 | break; |
| 2479 | } |
| 2480 | |
| 2481 | case Instruction::CHECK_CAST: { |
| 2482 | uint8_t reference = instruction.VRegA_21c(); |
| 2483 | uint16_t type_index = instruction.VRegB_21c(); |
Calin Juravle | 225ff81 | 2014-11-13 16:46:39 +0000 | [diff] [blame] | 2484 | if (!BuildTypeCheck(instruction, -1, reference, type_index, dex_pc)) { |
Nicolas Geoffray | 57a88d4 | 2014-11-10 15:09:21 +0000 | [diff] [blame] | 2485 | return false; |
| 2486 | } |
Nicolas Geoffray | 6f5c41f | 2014-11-06 08:59:20 +0000 | [diff] [blame] | 2487 | break; |
| 2488 | } |
| 2489 | |
Nicolas Geoffray | b7baf5c | 2014-11-11 16:29:44 +0000 | [diff] [blame] | 2490 | case Instruction::MONITOR_ENTER: { |
| 2491 | current_block_->AddInstruction(new (arena_) HMonitorOperation( |
| 2492 | LoadLocal(instruction.VRegA_11x(), Primitive::kPrimNot), |
| 2493 | HMonitorOperation::kEnter, |
Calin Juravle | 225ff81 | 2014-11-13 16:46:39 +0000 | [diff] [blame] | 2494 | dex_pc)); |
Nicolas Geoffray | b7baf5c | 2014-11-11 16:29:44 +0000 | [diff] [blame] | 2495 | break; |
| 2496 | } |
| 2497 | |
| 2498 | case Instruction::MONITOR_EXIT: { |
| 2499 | current_block_->AddInstruction(new (arena_) HMonitorOperation( |
| 2500 | LoadLocal(instruction.VRegA_11x(), Primitive::kPrimNot), |
| 2501 | HMonitorOperation::kExit, |
Calin Juravle | 225ff81 | 2014-11-13 16:46:39 +0000 | [diff] [blame] | 2502 | dex_pc)); |
Nicolas Geoffray | b7baf5c | 2014-11-11 16:29:44 +0000 | [diff] [blame] | 2503 | break; |
| 2504 | } |
| 2505 | |
Andreas Gampe | d881df5 | 2014-11-24 23:28:39 -0800 | [diff] [blame] | 2506 | case Instruction::PACKED_SWITCH: { |
Calin Juravle | 48c2b03 | 2014-12-09 18:11:36 +0000 | [diff] [blame] | 2507 | BuildPackedSwitch(instruction, dex_pc); |
Andreas Gampe | d881df5 | 2014-11-24 23:28:39 -0800 | [diff] [blame] | 2508 | break; |
| 2509 | } |
| 2510 | |
Andreas Gampe | e4d4d32 | 2014-12-04 09:09:57 -0800 | [diff] [blame] | 2511 | case Instruction::SPARSE_SWITCH: { |
Calin Juravle | 48c2b03 | 2014-12-09 18:11:36 +0000 | [diff] [blame] | 2512 | BuildSparseSwitch(instruction, dex_pc); |
Andreas Gampe | e4d4d32 | 2014-12-04 09:09:57 -0800 | [diff] [blame] | 2513 | break; |
| 2514 | } |
| 2515 | |
Nicolas Geoffray | 818f210 | 2014-02-18 16:43:35 +0000 | [diff] [blame] | 2516 | default: |
Calin Juravle | 48c2b03 | 2014-12-09 18:11:36 +0000 | [diff] [blame] | 2517 | VLOG(compiler) << "Did not compile " |
| 2518 | << PrettyMethod(dex_compilation_unit_->GetDexMethodIndex(), *dex_file_) |
| 2519 | << " because of unhandled instruction " |
| 2520 | << instruction.Name(); |
| 2521 | MaybeRecordStat(MethodCompilationStat::kNotCompiledUnhandledInstruction); |
Nicolas Geoffray | 818f210 | 2014-02-18 16:43:35 +0000 | [diff] [blame] | 2522 | return false; |
| 2523 | } |
| 2524 | return true; |
Nicolas Geoffray | dadf317 | 2014-11-07 16:36:02 +0000 | [diff] [blame] | 2525 | } // NOLINT(readability/fn_size) |
Nicolas Geoffray | 818f210 | 2014-02-18 16:43:35 +0000 | [diff] [blame] | 2526 | |
Nicolas Geoffray | 3ff386a | 2014-03-04 14:46:47 +0000 | [diff] [blame] | 2527 | HLocal* HGraphBuilder::GetLocalAt(int register_index) const { |
| 2528 | return locals_.Get(register_index); |
| 2529 | } |
| 2530 | |
| 2531 | void HGraphBuilder::UpdateLocal(int register_index, HInstruction* instruction) const { |
| 2532 | HLocal* local = GetLocalAt(register_index); |
| 2533 | current_block_->AddInstruction(new (arena_) HStoreLocal(local, instruction)); |
| 2534 | } |
| 2535 | |
Nicolas Geoffray | 01bc96d | 2014-04-11 17:43:50 +0100 | [diff] [blame] | 2536 | HInstruction* HGraphBuilder::LoadLocal(int register_index, Primitive::Type type) const { |
Nicolas Geoffray | 3ff386a | 2014-03-04 14:46:47 +0000 | [diff] [blame] | 2537 | HLocal* local = GetLocalAt(register_index); |
Nicolas Geoffray | 01bc96d | 2014-04-11 17:43:50 +0100 | [diff] [blame] | 2538 | current_block_->AddInstruction(new (arena_) HLoadLocal(local, type)); |
Nicolas Geoffray | 787c307 | 2014-03-17 10:20:19 +0000 | [diff] [blame] | 2539 | return current_block_->GetLastInstruction(); |
Nicolas Geoffray | 3ff386a | 2014-03-04 14:46:47 +0000 | [diff] [blame] | 2540 | } |
| 2541 | |
Nicolas Geoffray | 818f210 | 2014-02-18 16:43:35 +0000 | [diff] [blame] | 2542 | } // namespace art |