Ian Rogers | 776ac1f | 2012-04-13 23:36:36 -0700 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (C) 2011 The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
| 17 | #ifndef ART_SRC_VERIFIER_METHOD_VERIFIER_H_ |
| 18 | #define ART_SRC_VERIFIER_METHOD_VERIFIER_H_ |
| 19 | |
| 20 | #include <deque> |
| 21 | #include <limits> |
| 22 | #include <set> |
| 23 | #include <vector> |
| 24 | |
| 25 | #include "casts.h" |
| 26 | #include "compiler.h" |
| 27 | #include "dex_file.h" |
| 28 | #include "dex_instruction.h" |
| 29 | #include "macros.h" |
| 30 | #include "object.h" |
| 31 | #include "reg_type.h" |
| 32 | #include "reg_type_cache.h" |
| 33 | #include "register_line.h" |
| 34 | #include "safe_map.h" |
| 35 | #include "stl_util.h" |
| 36 | #include "UniquePtr.h" |
| 37 | |
| 38 | namespace art { |
| 39 | |
| 40 | struct ReferenceMap2Visitor; |
| 41 | |
| 42 | #if defined(ART_USE_LLVM_COMPILER) |
| 43 | namespace compiler_llvm { |
| 44 | class InferredRegCategoryMap; |
| 45 | } // namespace compiler_llvm |
| 46 | #endif |
| 47 | |
Shih-wei Liao | e94d9b2 | 2012-05-22 09:01:24 -0700 | [diff] [blame] | 48 | #if defined(ART_USE_GREENLAND_COMPILER) |
| 49 | namespace greenland { |
| 50 | class InferredRegCategoryMap; |
| 51 | } // namespace greenland |
| 52 | #endif |
| 53 | |
Ian Rogers | 776ac1f | 2012-04-13 23:36:36 -0700 | [diff] [blame] | 54 | namespace verifier { |
| 55 | |
| 56 | class MethodVerifier; |
| 57 | class InsnFlags; |
| 58 | class PcToReferenceMap; |
| 59 | |
| 60 | /* |
Ian Rogers | 776ac1f | 2012-04-13 23:36:36 -0700 | [diff] [blame] | 61 | * "Direct" and "virtual" methods are stored independently. The type of call used to invoke the |
| 62 | * method determines which list we search, and whether we travel up into superclasses. |
| 63 | * |
| 64 | * (<clinit>, <init>, and methods declared "private" or "static" are stored in the "direct" list. |
| 65 | * All others are stored in the "virtual" list.) |
| 66 | */ |
| 67 | enum MethodType { |
| 68 | METHOD_UNKNOWN = 0, |
| 69 | METHOD_DIRECT, // <init>, private |
| 70 | METHOD_STATIC, // static |
| 71 | METHOD_VIRTUAL, // virtual, super |
| 72 | METHOD_INTERFACE // interface |
| 73 | }; |
| 74 | |
| 75 | /* |
| 76 | * An enumeration of problems that can turn up during verification. |
| 77 | * Both VERIFY_ERROR_BAD_CLASS_SOFT and VERIFY_ERROR_BAD_CLASS_HARD denote failures that cause |
| 78 | * the entire class to be rejected. However, VERIFY_ERROR_BAD_CLASS_SOFT denotes a soft failure |
| 79 | * that can potentially be corrected, and the verifier will try again at runtime. |
| 80 | * VERIFY_ERROR_BAD_CLASS_HARD denotes a hard failure that can't be corrected, and will cause |
| 81 | * the class to remain uncompiled. Other errors denote verification errors that cause bytecode |
| 82 | * to be rewritten to fail at runtime. |
| 83 | */ |
| 84 | enum VerifyError { |
Ian Rogers | 776ac1f | 2012-04-13 23:36:36 -0700 | [diff] [blame] | 85 | VERIFY_ERROR_BAD_CLASS_HARD, // VerifyError; hard error that skips compilation. |
| 86 | VERIFY_ERROR_BAD_CLASS_SOFT, // VerifyError; soft error that verifies again at runtime. |
| 87 | |
| 88 | VERIFY_ERROR_NO_CLASS, // NoClassDefFoundError. |
| 89 | VERIFY_ERROR_NO_FIELD, // NoSuchFieldError. |
| 90 | VERIFY_ERROR_NO_METHOD, // NoSuchMethodError. |
| 91 | VERIFY_ERROR_ACCESS_CLASS, // IllegalAccessError. |
| 92 | VERIFY_ERROR_ACCESS_FIELD, // IllegalAccessError. |
| 93 | VERIFY_ERROR_ACCESS_METHOD, // IllegalAccessError. |
| 94 | VERIFY_ERROR_CLASS_CHANGE, // IncompatibleClassChangeError. |
| 95 | VERIFY_ERROR_INSTANTIATION, // InstantiationError. |
| 96 | }; |
| 97 | std::ostream& operator<<(std::ostream& os, const VerifyError& rhs); |
| 98 | |
| 99 | /* |
| 100 | * Identifies the type of reference in the instruction that generated the verify error |
| 101 | * (e.g. VERIFY_ERROR_ACCESS_CLASS could come from a method, field, or class reference). |
| 102 | * |
| 103 | * This must fit in two bits. |
| 104 | */ |
| 105 | enum VerifyErrorRefType { |
| 106 | VERIFY_ERROR_REF_CLASS = 0, |
| 107 | VERIFY_ERROR_REF_FIELD = 1, |
| 108 | VERIFY_ERROR_REF_METHOD = 2, |
| 109 | }; |
| 110 | const int kVerifyErrorRefTypeShift = 6; |
| 111 | |
| 112 | // We don't need to store the register data for many instructions, because we either only need |
| 113 | // it at branch points (for verification) or GC points and branches (for verification + |
| 114 | // type-precise register analysis). |
| 115 | enum RegisterTrackingMode { |
| 116 | kTrackRegsBranches, |
| 117 | kTrackRegsGcPoints, |
| 118 | kTrackRegsAll, |
| 119 | }; |
| 120 | |
| 121 | class PcToRegisterLineTable { |
| 122 | public: |
| 123 | PcToRegisterLineTable() {} |
| 124 | ~PcToRegisterLineTable() { |
| 125 | STLDeleteValues(&pc_to_register_line_); |
| 126 | } |
| 127 | |
| 128 | // Initialize the RegisterTable. Every instruction address can have a different set of information |
| 129 | // about what's in which register, but for verification purposes we only need to store it at |
| 130 | // branch target addresses (because we merge into that). |
| 131 | void Init(RegisterTrackingMode mode, InsnFlags* flags, uint32_t insns_size, |
| 132 | uint16_t registers_size, MethodVerifier* verifier); |
| 133 | |
| 134 | RegisterLine* GetLine(size_t idx) { |
| 135 | Table::iterator result = pc_to_register_line_.find(idx); // TODO: C++0x auto |
| 136 | if (result == pc_to_register_line_.end()) { |
| 137 | return NULL; |
| 138 | } else { |
| 139 | return result->second; |
| 140 | } |
| 141 | } |
| 142 | |
| 143 | private: |
| 144 | typedef SafeMap<int32_t, RegisterLine*> Table; |
| 145 | // Map from a dex pc to the register status associated with it |
| 146 | Table pc_to_register_line_; |
| 147 | }; |
| 148 | |
| 149 | // The verifier |
| 150 | class MethodVerifier { |
Shih-wei Liao | e94d9b2 | 2012-05-22 09:01:24 -0700 | [diff] [blame] | 151 | #if defined(ART_USE_LLVM_COMPILER) |
| 152 | typedef compiler_llvm::InferredRegCategoryMap InferredRegCategoryMap; |
| 153 | #elif defined(ART_USE_GREENLAND_COMPILER) |
| 154 | typedef greenland::InferredRegCategoryMap InferredRegCategoryMap; |
| 155 | #endif |
Elliott Hughes | a21039c | 2012-06-21 12:09:25 -0700 | [diff] [blame] | 156 | |
Ian Rogers | 776ac1f | 2012-04-13 23:36:36 -0700 | [diff] [blame] | 157 | public: |
jeffhao | f1e6b7c | 2012-06-05 18:33:30 -0700 | [diff] [blame] | 158 | enum FailureKind { |
| 159 | kNoFailure, |
| 160 | kSoftFailure, |
| 161 | kHardFailure, |
| 162 | }; |
| 163 | |
| 164 | /* Verify a class. Returns "kNoFailure" on success. */ |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 165 | static FailureKind VerifyClass(const Class* klass, std::string& error) |
| 166 | SHARED_LOCKS_REQUIRED(GlobalSynchronization::mutator_lock_); |
jeffhao | f1e6b7c | 2012-06-05 18:33:30 -0700 | [diff] [blame] | 167 | static FailureKind VerifyClass(const DexFile* dex_file, DexCache* dex_cache, |
Ian Rogers | 365c102 | 2012-06-22 15:05:28 -0700 | [diff] [blame] | 168 | ClassLoader* class_loader, uint32_t class_def_idx, |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 169 | std::string& error) |
| 170 | SHARED_LOCKS_REQUIRED(GlobalSynchronization::mutator_lock_); |
Ian Rogers | 776ac1f | 2012-04-13 23:36:36 -0700 | [diff] [blame] | 171 | |
| 172 | uint8_t EncodePcToReferenceMapData() const; |
| 173 | |
| 174 | uint32_t DexFileVersion() const { |
| 175 | return dex_file_->GetVersion(); |
| 176 | } |
| 177 | |
| 178 | RegTypeCache* GetRegTypeCache() { |
| 179 | return ®_types_; |
| 180 | } |
| 181 | |
Ian Rogers | ad0b3a3 | 2012-04-16 14:50:24 -0700 | [diff] [blame] | 182 | // Log a verification failure. |
Ian Rogers | 776ac1f | 2012-04-13 23:36:36 -0700 | [diff] [blame] | 183 | std::ostream& Fail(VerifyError error); |
| 184 | |
Ian Rogers | ad0b3a3 | 2012-04-16 14:50:24 -0700 | [diff] [blame] | 185 | // Log for verification information. |
Ian Rogers | 776ac1f | 2012-04-13 23:36:36 -0700 | [diff] [blame] | 186 | std::ostream& LogVerifyInfo() { |
Ian Rogers | ad0b3a3 | 2012-04-16 14:50:24 -0700 | [diff] [blame] | 187 | return info_messages_ << "VFY: " << PrettyMethod(method_idx_, *dex_file_) |
Ian Rogers | 776ac1f | 2012-04-13 23:36:36 -0700 | [diff] [blame] | 188 | << '[' << reinterpret_cast<void*>(work_insn_idx_) << "] : "; |
| 189 | } |
| 190 | |
Ian Rogers | ad0b3a3 | 2012-04-16 14:50:24 -0700 | [diff] [blame] | 191 | // Dump the failures encountered by the verifier. |
| 192 | std::ostream& DumpFailures(std::ostream& os); |
| 193 | |
Ian Rogers | 776ac1f | 2012-04-13 23:36:36 -0700 | [diff] [blame] | 194 | // Dump the state of the verifier, namely each instruction, what flags are set on it, register |
| 195 | // information |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 196 | void Dump(std::ostream& os) SHARED_LOCKS_REQUIRED(GlobalSynchronization::mutator_lock_); |
Ian Rogers | 776ac1f | 2012-04-13 23:36:36 -0700 | [diff] [blame] | 197 | |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 198 | static const std::vector<uint8_t>* GetGcMap(Compiler::MethodReference ref) |
| 199 | LOCKS_EXCLUDED(gc_maps_lock_); |
Elliott Hughes | 0a1038b | 2012-06-14 16:24:17 -0700 | [diff] [blame] | 200 | |
Elliott Hughes | 08fc03a | 2012-06-26 17:34:00 -0700 | [diff] [blame] | 201 | // Fills 'monitor_enter_dex_pcs' with the dex pcs of the monitor-enter instructions corresponding |
| 202 | // to the locks held at 'dex_pc' in 'm'. |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 203 | static void FindLocksAtDexPc(Method* m, uint32_t dex_pc, |
| 204 | std::vector<uint32_t>& monitor_enter_dex_pcs) |
| 205 | SHARED_LOCKS_REQUIRED(GlobalSynchronization::mutator_lock_); |
Elliott Hughes | 08fc03a | 2012-06-26 17:34:00 -0700 | [diff] [blame] | 206 | |
Elliott Hughes | 0a1038b | 2012-06-14 16:24:17 -0700 | [diff] [blame] | 207 | static void Init(); |
| 208 | static void Shutdown(); |
Ian Rogers | 776ac1f | 2012-04-13 23:36:36 -0700 | [diff] [blame] | 209 | |
Shih-wei Liao | e94d9b2 | 2012-05-22 09:01:24 -0700 | [diff] [blame] | 210 | #if defined(ART_USE_LLVM_COMPILER) || defined(ART_USE_GREENLAND_COMPILER) |
Shih-wei Liao | cd05a62 | 2012-08-15 00:02:05 -0700 | [diff] [blame] | 211 | static const InferredRegCategoryMap* GetInferredRegCategoryMap(Compiler::MethodReference ref) |
| 212 | LOCKS_EXCLUDED(inferred_reg_category_maps_lock_); |
Ian Rogers | 776ac1f | 2012-04-13 23:36:36 -0700 | [diff] [blame] | 213 | #endif |
| 214 | |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 215 | static bool IsClassRejected(Compiler::ClassReference ref) |
| 216 | LOCKS_EXCLUDED(rejected_classes_lock_); |
Ian Rogers | 776ac1f | 2012-04-13 23:36:36 -0700 | [diff] [blame] | 217 | |
| 218 | private: |
Ian Rogers | 776ac1f | 2012-04-13 23:36:36 -0700 | [diff] [blame] | 219 | explicit MethodVerifier(const DexFile* dex_file, DexCache* dex_cache, |
Ian Rogers | 365c102 | 2012-06-22 15:05:28 -0700 | [diff] [blame] | 220 | ClassLoader* class_loader, uint32_t class_def_idx, const DexFile::CodeItem* code_item, |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 221 | uint32_t method_idx, Method* method, uint32_t access_flags) |
| 222 | SHARED_LOCKS_REQUIRED(GlobalSynchronization::mutator_lock_); |
Ian Rogers | ad0b3a3 | 2012-04-16 14:50:24 -0700 | [diff] [blame] | 223 | |
| 224 | // Adds the given string to the beginning of the last failure message. |
| 225 | void PrependToLastFailMessage(std::string); |
| 226 | |
| 227 | // Adds the given string to the end of the last failure message. |
| 228 | void AppendToLastFailMessage(std::string); |
Ian Rogers | 776ac1f | 2012-04-13 23:36:36 -0700 | [diff] [blame] | 229 | |
| 230 | /* |
| 231 | * Perform verification on a single method. |
| 232 | * |
| 233 | * We do this in three passes: |
| 234 | * (1) Walk through all code units, determining instruction locations, |
| 235 | * widths, and other characteristics. |
| 236 | * (2) Walk through all code units, performing static checks on |
| 237 | * operands. |
| 238 | * (3) Iterate through the method, checking type safety and looking |
| 239 | * for code flow problems. |
Ian Rogers | e1758fe | 2012-04-19 11:31:15 -0700 | [diff] [blame] | 240 | */ |
jeffhao | f1e6b7c | 2012-06-05 18:33:30 -0700 | [diff] [blame] | 241 | static FailureKind VerifyMethod(uint32_t method_idx, const DexFile* dex_file, DexCache* dex_cache, |
Ian Rogers | 365c102 | 2012-06-22 15:05:28 -0700 | [diff] [blame] | 242 | ClassLoader* class_loader, uint32_t class_def_idx, const DexFile::CodeItem* code_item, |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 243 | Method* method, uint32_t method_access_flags) |
| 244 | SHARED_LOCKS_REQUIRED(GlobalSynchronization::mutator_lock_); |
| 245 | static void VerifyMethodAndDump(Method* method) |
| 246 | SHARED_LOCKS_REQUIRED(GlobalSynchronization::mutator_lock_); |
Ian Rogers | e1758fe | 2012-04-19 11:31:15 -0700 | [diff] [blame] | 247 | |
Ian Rogers | ad0b3a3 | 2012-04-16 14:50:24 -0700 | [diff] [blame] | 248 | // Run verification on the method. Returns true if verification completes and false if the input |
| 249 | // has an irrecoverable corruption. |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 250 | bool Verify() SHARED_LOCKS_REQUIRED(GlobalSynchronization::mutator_lock_); |
Ian Rogers | 776ac1f | 2012-04-13 23:36:36 -0700 | [diff] [blame] | 251 | |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 252 | void FindLocksAtDexPc() SHARED_LOCKS_REQUIRED(GlobalSynchronization::mutator_lock_); |
Elliott Hughes | 08fc03a | 2012-06-26 17:34:00 -0700 | [diff] [blame] | 253 | |
Ian Rogers | 776ac1f | 2012-04-13 23:36:36 -0700 | [diff] [blame] | 254 | /* |
| 255 | * Compute the width of the instruction at each address in the instruction stream, and store it in |
| 256 | * insn_flags_. Addresses that are in the middle of an instruction, or that are part of switch |
| 257 | * table data, are not touched (so the caller should probably initialize "insn_flags" to zero). |
| 258 | * |
| 259 | * The "new_instance_count_" and "monitor_enter_count_" fields in vdata are also set. |
| 260 | * |
| 261 | * Performs some static checks, notably: |
| 262 | * - opcode of first instruction begins at index 0 |
| 263 | * - only documented instructions may appear |
| 264 | * - each instruction follows the last |
| 265 | * - last byte of last instruction is at (code_length-1) |
| 266 | * |
| 267 | * Logs an error and returns "false" on failure. |
| 268 | */ |
| 269 | bool ComputeWidthsAndCountOps(); |
| 270 | |
| 271 | /* |
| 272 | * Set the "in try" flags for all instructions protected by "try" statements. Also sets the |
| 273 | * "branch target" flags for exception handlers. |
| 274 | * |
| 275 | * Call this after widths have been set in "insn_flags". |
| 276 | * |
| 277 | * Returns "false" if something in the exception table looks fishy, but we're expecting the |
| 278 | * exception table to be somewhat sane. |
| 279 | */ |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 280 | bool ScanTryCatchBlocks() SHARED_LOCKS_REQUIRED(GlobalSynchronization::mutator_lock_); |
Ian Rogers | 776ac1f | 2012-04-13 23:36:36 -0700 | [diff] [blame] | 281 | |
| 282 | /* |
| 283 | * Perform static verification on all instructions in a method. |
| 284 | * |
| 285 | * Walks through instructions in a method calling VerifyInstruction on each. |
| 286 | */ |
| 287 | bool VerifyInstructions(); |
| 288 | |
| 289 | /* |
| 290 | * Perform static verification on an instruction. |
| 291 | * |
| 292 | * As a side effect, this sets the "branch target" flags in InsnFlags. |
| 293 | * |
| 294 | * "(CF)" items are handled during code-flow analysis. |
| 295 | * |
| 296 | * v3 4.10.1 |
| 297 | * - target of each jump and branch instruction must be valid |
| 298 | * - targets of switch statements must be valid |
| 299 | * - operands referencing constant pool entries must be valid |
| 300 | * - (CF) operands of getfield, putfield, getstatic, putstatic must be valid |
| 301 | * - (CF) operands of method invocation instructions must be valid |
| 302 | * - (CF) only invoke-direct can call a method starting with '<' |
| 303 | * - (CF) <clinit> must never be called explicitly |
| 304 | * - operands of instanceof, checkcast, new (and variants) must be valid |
| 305 | * - new-array[-type] limited to 255 dimensions |
| 306 | * - can't use "new" on an array class |
| 307 | * - (?) limit dimensions in multi-array creation |
| 308 | * - local variable load/store register values must be in valid range |
| 309 | * |
| 310 | * v3 4.11.1.2 |
| 311 | * - branches must be within the bounds of the code array |
| 312 | * - targets of all control-flow instructions are the start of an instruction |
| 313 | * - register accesses fall within range of allocated registers |
| 314 | * - (N/A) access to constant pool must be of appropriate type |
| 315 | * - code does not end in the middle of an instruction |
| 316 | * - execution cannot fall off the end of the code |
| 317 | * - (earlier) for each exception handler, the "try" area must begin and |
| 318 | * end at the start of an instruction (end can be at the end of the code) |
| 319 | * - (earlier) for each exception handler, the handler must start at a valid |
| 320 | * instruction |
| 321 | */ |
| 322 | bool VerifyInstruction(const Instruction* inst, uint32_t code_offset); |
| 323 | |
| 324 | /* Ensure that the register index is valid for this code item. */ |
| 325 | bool CheckRegisterIndex(uint32_t idx); |
| 326 | |
| 327 | /* Ensure that the wide register index is valid for this code item. */ |
| 328 | bool CheckWideRegisterIndex(uint32_t idx); |
| 329 | |
| 330 | // Perform static checks on a field get or set instruction. All we do here is ensure that the |
| 331 | // field index is in the valid range. |
| 332 | bool CheckFieldIndex(uint32_t idx); |
| 333 | |
| 334 | // Perform static checks on a method invocation instruction. All we do here is ensure that the |
| 335 | // method index is in the valid range. |
| 336 | bool CheckMethodIndex(uint32_t idx); |
| 337 | |
| 338 | // Perform static checks on a "new-instance" instruction. Specifically, make sure the class |
| 339 | // reference isn't for an array class. |
| 340 | bool CheckNewInstance(uint32_t idx); |
| 341 | |
| 342 | /* Ensure that the string index is in the valid range. */ |
| 343 | bool CheckStringIndex(uint32_t idx); |
| 344 | |
| 345 | // Perform static checks on an instruction that takes a class constant. Ensure that the class |
| 346 | // index is in the valid range. |
| 347 | bool CheckTypeIndex(uint32_t idx); |
| 348 | |
| 349 | // Perform static checks on a "new-array" instruction. Specifically, make sure they aren't |
| 350 | // creating an array of arrays that causes the number of dimensions to exceed 255. |
| 351 | bool CheckNewArray(uint32_t idx); |
| 352 | |
| 353 | // Verify an array data table. "cur_offset" is the offset of the fill-array-data instruction. |
| 354 | bool CheckArrayData(uint32_t cur_offset); |
| 355 | |
| 356 | // Verify that the target of a branch instruction is valid. We don't expect code to jump directly |
| 357 | // into an exception handler, but it's valid to do so as long as the target isn't a |
| 358 | // "move-exception" instruction. We verify that in a later stage. |
| 359 | // The dex format forbids certain instructions from branching to themselves. |
Elliott Hughes | 24edeb5 | 2012-06-18 15:29:46 -0700 | [diff] [blame] | 360 | // Updates "insn_flags_", setting the "branch target" flag. |
Ian Rogers | 776ac1f | 2012-04-13 23:36:36 -0700 | [diff] [blame] | 361 | bool CheckBranchTarget(uint32_t cur_offset); |
| 362 | |
| 363 | // Verify a switch table. "cur_offset" is the offset of the switch instruction. |
Elliott Hughes | 24edeb5 | 2012-06-18 15:29:46 -0700 | [diff] [blame] | 364 | // Updates "insn_flags_", setting the "branch target" flag. |
Ian Rogers | 776ac1f | 2012-04-13 23:36:36 -0700 | [diff] [blame] | 365 | bool CheckSwitchTargets(uint32_t cur_offset); |
| 366 | |
| 367 | // Check the register indices used in a "vararg" instruction, such as invoke-virtual or |
| 368 | // filled-new-array. |
| 369 | // - vA holds word count (0-5), args[] have values. |
| 370 | // There are some tests we don't do here, e.g. we don't try to verify that invoking a method that |
| 371 | // takes a double is done with consecutive registers. This requires parsing the target method |
| 372 | // signature, which we will be doing later on during the code flow analysis. |
| 373 | bool CheckVarArgRegs(uint32_t vA, uint32_t arg[]); |
| 374 | |
| 375 | // Check the register indices used in a "vararg/range" instruction, such as invoke-virtual/range |
| 376 | // or filled-new-array/range. |
| 377 | // - vA holds word count, vC holds index of first reg. |
| 378 | bool CheckVarArgRangeRegs(uint32_t vA, uint32_t vC); |
| 379 | |
| 380 | // Extract the relative offset from a branch instruction. |
| 381 | // Returns "false" on failure (e.g. this isn't a branch instruction). |
| 382 | bool GetBranchOffset(uint32_t cur_offset, int32_t* pOffset, bool* pConditional, |
| 383 | bool* selfOkay); |
| 384 | |
| 385 | /* Perform detailed code-flow analysis on a single method. */ |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 386 | bool VerifyCodeFlow() SHARED_LOCKS_REQUIRED(GlobalSynchronization::mutator_lock_); |
Ian Rogers | 776ac1f | 2012-04-13 23:36:36 -0700 | [diff] [blame] | 387 | |
| 388 | // Set the register types for the first instruction in the method based on the method signature. |
| 389 | // This has the side-effect of validating the signature. |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 390 | bool SetTypesFromSignature() SHARED_LOCKS_REQUIRED(GlobalSynchronization::mutator_lock_); |
Ian Rogers | 776ac1f | 2012-04-13 23:36:36 -0700 | [diff] [blame] | 391 | |
| 392 | /* |
| 393 | * Perform code flow on a method. |
| 394 | * |
| 395 | * The basic strategy is as outlined in v3 4.11.1.2: set the "changed" bit on the first |
| 396 | * instruction, process it (setting additional "changed" bits), and repeat until there are no |
| 397 | * more. |
| 398 | * |
| 399 | * v3 4.11.1.1 |
| 400 | * - (N/A) operand stack is always the same size |
| 401 | * - operand stack [registers] contain the correct types of values |
| 402 | * - local variables [registers] contain the correct types of values |
| 403 | * - methods are invoked with the appropriate arguments |
| 404 | * - fields are assigned using values of appropriate types |
| 405 | * - opcodes have the correct type values in operand registers |
| 406 | * - there is never an uninitialized class instance in a local variable in code protected by an |
| 407 | * exception handler (operand stack is okay, because the operand stack is discarded when an |
| 408 | * exception is thrown) [can't know what's a local var w/o the debug info -- should fall out of |
| 409 | * register typing] |
| 410 | * |
| 411 | * v3 4.11.1.2 |
| 412 | * - execution cannot fall off the end of the code |
| 413 | * |
| 414 | * (We also do many of the items described in the "static checks" sections, because it's easier to |
| 415 | * do them here.) |
| 416 | * |
| 417 | * We need an array of RegType values, one per register, for every instruction. If the method uses |
| 418 | * monitor-enter, we need extra data for every register, and a stack for every "interesting" |
| 419 | * instruction. In theory this could become quite large -- up to several megabytes for a monster |
| 420 | * function. |
| 421 | * |
| 422 | * NOTE: |
| 423 | * The spec forbids backward branches when there's an uninitialized reference in a register. The |
| 424 | * idea is to prevent something like this: |
| 425 | * loop: |
| 426 | * move r1, r0 |
| 427 | * new-instance r0, MyClass |
| 428 | * ... |
| 429 | * if-eq rN, loop // once |
| 430 | * initialize r0 |
| 431 | * |
| 432 | * This leaves us with two different instances, both allocated by the same instruction, but only |
| 433 | * one is initialized. The scheme outlined in v3 4.11.1.4 wouldn't catch this, so they work around |
| 434 | * it by preventing backward branches. We achieve identical results without restricting code |
| 435 | * reordering by specifying that you can't execute the new-instance instruction if a register |
| 436 | * contains an uninitialized instance created by that same instruction. |
| 437 | */ |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 438 | bool CodeFlowVerifyMethod() SHARED_LOCKS_REQUIRED(GlobalSynchronization::mutator_lock_); |
Ian Rogers | 776ac1f | 2012-04-13 23:36:36 -0700 | [diff] [blame] | 439 | |
| 440 | /* |
| 441 | * Perform verification for a single instruction. |
| 442 | * |
| 443 | * This requires fully decoding the instruction to determine the effect it has on registers. |
| 444 | * |
| 445 | * Finds zero or more following instructions and sets the "changed" flag if execution at that |
| 446 | * point needs to be (re-)evaluated. Register changes are merged into "reg_types_" at the target |
| 447 | * addresses. Does not set or clear any other flags in "insn_flags_". |
| 448 | */ |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 449 | bool CodeFlowVerifyInstruction(uint32_t* start_guess) |
| 450 | SHARED_LOCKS_REQUIRED(GlobalSynchronization::mutator_lock_); |
Ian Rogers | 776ac1f | 2012-04-13 23:36:36 -0700 | [diff] [blame] | 451 | |
| 452 | // Perform verification of a new array instruction |
| 453 | void VerifyNewArray(const DecodedInstruction& dec_insn, bool is_filled, |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 454 | bool is_range) |
| 455 | SHARED_LOCKS_REQUIRED(GlobalSynchronization::mutator_lock_); |
Ian Rogers | 776ac1f | 2012-04-13 23:36:36 -0700 | [diff] [blame] | 456 | |
| 457 | // Perform verification of an aget instruction. The destination register's type will be set to |
| 458 | // be that of component type of the array unless the array type is unknown, in which case a |
| 459 | // bottom type inferred from the type of instruction is used. is_primitive is false for an |
| 460 | // aget-object. |
| 461 | void VerifyAGet(const DecodedInstruction& insn, const RegType& insn_type, |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 462 | bool is_primitive) SHARED_LOCKS_REQUIRED(GlobalSynchronization::mutator_lock_); |
Ian Rogers | 776ac1f | 2012-04-13 23:36:36 -0700 | [diff] [blame] | 463 | |
| 464 | // Perform verification of an aput instruction. |
| 465 | void VerifyAPut(const DecodedInstruction& insn, const RegType& insn_type, |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 466 | bool is_primitive) SHARED_LOCKS_REQUIRED(GlobalSynchronization::mutator_lock_); |
Ian Rogers | 776ac1f | 2012-04-13 23:36:36 -0700 | [diff] [blame] | 467 | |
| 468 | // Lookup instance field and fail for resolution violations |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 469 | Field* GetInstanceField(const RegType& obj_type, int field_idx) |
| 470 | SHARED_LOCKS_REQUIRED(GlobalSynchronization::mutator_lock_); |
Ian Rogers | 776ac1f | 2012-04-13 23:36:36 -0700 | [diff] [blame] | 471 | |
| 472 | // Lookup static field and fail for resolution violations |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 473 | Field* GetStaticField(int field_idx) SHARED_LOCKS_REQUIRED(GlobalSynchronization::mutator_lock_); |
Ian Rogers | 776ac1f | 2012-04-13 23:36:36 -0700 | [diff] [blame] | 474 | |
| 475 | // Perform verification of an iget or sget instruction. |
| 476 | void VerifyISGet(const DecodedInstruction& insn, const RegType& insn_type, |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 477 | bool is_primitive, bool is_static) |
| 478 | SHARED_LOCKS_REQUIRED(GlobalSynchronization::mutator_lock_); |
Ian Rogers | 776ac1f | 2012-04-13 23:36:36 -0700 | [diff] [blame] | 479 | |
| 480 | // Perform verification of an iput or sput instruction. |
| 481 | void VerifyISPut(const DecodedInstruction& insn, const RegType& insn_type, |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 482 | bool is_primitive, bool is_static) |
| 483 | SHARED_LOCKS_REQUIRED(GlobalSynchronization::mutator_lock_); |
Ian Rogers | 776ac1f | 2012-04-13 23:36:36 -0700 | [diff] [blame] | 484 | |
| 485 | // Resolves a class based on an index and performs access checks to ensure the referrer can |
| 486 | // access the resolved class. |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 487 | const RegType& ResolveClassAndCheckAccess(uint32_t class_idx) |
| 488 | SHARED_LOCKS_REQUIRED(GlobalSynchronization::mutator_lock_); |
Ian Rogers | 776ac1f | 2012-04-13 23:36:36 -0700 | [diff] [blame] | 489 | |
| 490 | /* |
| 491 | * For the "move-exception" instruction at "work_insn_idx_", which must be at an exception handler |
| 492 | * address, determine the Join of all exceptions that can land here. Fails if no matching |
| 493 | * exception handler can be found or if the Join of exception types fails. |
| 494 | */ |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 495 | const RegType& GetCaughtExceptionType() |
| 496 | SHARED_LOCKS_REQUIRED(GlobalSynchronization::mutator_lock_); |
Ian Rogers | 776ac1f | 2012-04-13 23:36:36 -0700 | [diff] [blame] | 497 | |
| 498 | /* |
| 499 | * Resolves a method based on an index and performs access checks to ensure |
| 500 | * the referrer can access the resolved method. |
| 501 | * Does not throw exceptions. |
| 502 | */ |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 503 | Method* ResolveMethodAndCheckAccess(uint32_t method_idx, MethodType method_type) |
| 504 | SHARED_LOCKS_REQUIRED(GlobalSynchronization::mutator_lock_); |
Ian Rogers | 776ac1f | 2012-04-13 23:36:36 -0700 | [diff] [blame] | 505 | |
| 506 | /* |
| 507 | * Verify the arguments to a method. We're executing in "method", making |
| 508 | * a call to the method reference in vB. |
| 509 | * |
| 510 | * If this is a "direct" invoke, we allow calls to <init>. For calls to |
| 511 | * <init>, the first argument may be an uninitialized reference. Otherwise, |
| 512 | * calls to anything starting with '<' will be rejected, as will any |
| 513 | * uninitialized reference arguments. |
| 514 | * |
| 515 | * For non-static method calls, this will verify that the method call is |
| 516 | * appropriate for the "this" argument. |
| 517 | * |
| 518 | * The method reference is in vBBBB. The "is_range" parameter determines |
| 519 | * whether we use 0-4 "args" values or a range of registers defined by |
| 520 | * vAA and vCCCC. |
| 521 | * |
| 522 | * Widening conversions on integers and references are allowed, but |
| 523 | * narrowing conversions are not. |
| 524 | * |
| 525 | * Returns the resolved method on success, NULL on failure (with *failure |
| 526 | * set appropriately). |
| 527 | */ |
| 528 | Method* VerifyInvocationArgs(const DecodedInstruction& dec_insn, |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 529 | MethodType method_type, bool is_range, bool is_super) |
| 530 | SHARED_LOCKS_REQUIRED(GlobalSynchronization::mutator_lock_); |
Ian Rogers | 776ac1f | 2012-04-13 23:36:36 -0700 | [diff] [blame] | 531 | |
| 532 | /* |
Ian Rogers | 776ac1f | 2012-04-13 23:36:36 -0700 | [diff] [blame] | 533 | * Verify that the target instruction is not "move-exception". It's important that the only way |
| 534 | * to execute a move-exception is as the first instruction of an exception handler. |
| 535 | * Returns "true" if all is well, "false" if the target instruction is move-exception. |
| 536 | */ |
| 537 | bool CheckNotMoveException(const uint16_t* insns, int insn_idx); |
| 538 | |
| 539 | /* |
Ian Rogers | 776ac1f | 2012-04-13 23:36:36 -0700 | [diff] [blame] | 540 | * Control can transfer to "next_insn". Merge the registers from merge_line into the table at |
| 541 | * next_insn, and set the changed flag on the target address if any of the registers were changed. |
| 542 | * Returns "false" if an error is encountered. |
| 543 | */ |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 544 | bool UpdateRegisters(uint32_t next_insn, const RegisterLine* merge_line) |
| 545 | SHARED_LOCKS_REQUIRED(GlobalSynchronization::mutator_lock_); |
Ian Rogers | 776ac1f | 2012-04-13 23:36:36 -0700 | [diff] [blame] | 546 | |
Ian Rogers | ad0b3a3 | 2012-04-16 14:50:24 -0700 | [diff] [blame] | 547 | // Is the method being verified a constructor? |
| 548 | bool IsConstructor() const { |
| 549 | return (method_access_flags_ & kAccConstructor) != 0; |
| 550 | } |
| 551 | |
| 552 | // Is the method verified static? |
| 553 | bool IsStatic() const { |
| 554 | return (method_access_flags_ & kAccStatic) != 0; |
| 555 | } |
| 556 | |
| 557 | // Return the register type for the method. |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 558 | const RegType& GetMethodReturnType() SHARED_LOCKS_REQUIRED(GlobalSynchronization::mutator_lock_); |
Ian Rogers | ad0b3a3 | 2012-04-16 14:50:24 -0700 | [diff] [blame] | 559 | |
| 560 | // Get a type representing the declaring class of the method. |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 561 | const RegType& GetDeclaringClass() SHARED_LOCKS_REQUIRED(GlobalSynchronization::mutator_lock_); |
Ian Rogers | ad0b3a3 | 2012-04-16 14:50:24 -0700 | [diff] [blame] | 562 | |
Shih-wei Liao | e94d9b2 | 2012-05-22 09:01:24 -0700 | [diff] [blame] | 563 | #if defined(ART_USE_LLVM_COMPILER) || defined(ART_USE_GREENLAND_COMPILER) |
Ian Rogers | 776ac1f | 2012-04-13 23:36:36 -0700 | [diff] [blame] | 564 | /* |
| 565 | * Generate the inferred register category for LLVM-based code generator. |
| 566 | * Returns a pointer to a two-dimension Class array, or NULL on failure. |
| 567 | */ |
Shih-wei Liao | e94d9b2 | 2012-05-22 09:01:24 -0700 | [diff] [blame] | 568 | const InferredRegCategoryMap* GenerateInferredRegCategoryMap(); |
Ian Rogers | 776ac1f | 2012-04-13 23:36:36 -0700 | [diff] [blame] | 569 | #endif |
| 570 | |
| 571 | /* |
| 572 | * Generate the GC map for a method that has just been verified (i.e. we're doing this as part of |
| 573 | * verification). For type-precise determination we have all the data we need, so we just need to |
| 574 | * encode it in some clever fashion. |
| 575 | * Returns a pointer to a newly-allocated RegisterMap, or NULL on failure. |
| 576 | */ |
| 577 | const std::vector<uint8_t>* GenerateGcMap(); |
| 578 | |
| 579 | // Verify that the GC map associated with method_ is well formed |
| 580 | void VerifyGcMap(const std::vector<uint8_t>& data); |
| 581 | |
| 582 | // Compute sizes for GC map data |
| 583 | void ComputeGcMapSizes(size_t* gc_points, size_t* ref_bitmap_bits, size_t* log2_max_gc_pc); |
| 584 | |
| 585 | InsnFlags* CurrentInsnFlags(); |
| 586 | |
| 587 | // All the GC maps that the verifier has created |
| 588 | typedef SafeMap<const Compiler::MethodReference, const std::vector<uint8_t>*> GcMapTable; |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 589 | static Mutex* gc_maps_lock_ DEFAULT_MUTEX_ACQUIRED_AFTER; |
| 590 | static GcMapTable* gc_maps_ GUARDED_BY(gc_maps_lock_); |
| 591 | static void SetGcMap(Compiler::MethodReference ref, const std::vector<uint8_t>& gc_map) |
| 592 | LOCKS_EXCLUDED(gc_maps_lock_); |
Ian Rogers | 776ac1f | 2012-04-13 23:36:36 -0700 | [diff] [blame] | 593 | |
Elliott Hughes | 0a1038b | 2012-06-14 16:24:17 -0700 | [diff] [blame] | 594 | typedef std::set<Compiler::ClassReference> RejectedClassesTable; |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 595 | static Mutex* rejected_classes_lock_ DEFAULT_MUTEX_ACQUIRED_AFTER; |
Elliott Hughes | 0a1038b | 2012-06-14 16:24:17 -0700 | [diff] [blame] | 596 | static RejectedClassesTable* rejected_classes_; |
| 597 | |
Shih-wei Liao | e94d9b2 | 2012-05-22 09:01:24 -0700 | [diff] [blame] | 598 | #if defined(ART_USE_LLVM_COMPILER) || defined(ART_USE_GREENLAND_COMPILER) |
Elliott Hughes | 0a1038b | 2012-06-14 16:24:17 -0700 | [diff] [blame] | 599 | // All the inferred register category maps that the verifier has created. |
Ian Rogers | 776ac1f | 2012-04-13 23:36:36 -0700 | [diff] [blame] | 600 | typedef SafeMap<const Compiler::MethodReference, |
Shih-wei Liao | e94d9b2 | 2012-05-22 09:01:24 -0700 | [diff] [blame] | 601 | const InferredRegCategoryMap*> InferredRegCategoryMapTable; |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 602 | static Mutex* inferred_reg_category_maps_lock_ DEFAULT_MUTEX_ACQUIRED_AFTER; |
Shih-wei Liao | cd05a62 | 2012-08-15 00:02:05 -0700 | [diff] [blame] | 603 | static InferredRegCategoryMapTable* inferred_reg_category_maps_ GUARDED_BY(inferred_reg_category_maps_lock_); |
Ian Rogers | 776ac1f | 2012-04-13 23:36:36 -0700 | [diff] [blame] | 604 | static void SetInferredRegCategoryMap(Compiler::MethodReference ref, |
Shih-wei Liao | cd05a62 | 2012-08-15 00:02:05 -0700 | [diff] [blame] | 605 | const InferredRegCategoryMap& m) |
| 606 | LOCKS_EXCLUDED(inferred_reg_category_maps_lock_); |
Ian Rogers | 776ac1f | 2012-04-13 23:36:36 -0700 | [diff] [blame] | 607 | #endif |
| 608 | |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 609 | static void AddRejectedClass(Compiler::ClassReference ref) |
| 610 | LOCKS_EXCLUDED(rejected_classes_lock_); |
Ian Rogers | 776ac1f | 2012-04-13 23:36:36 -0700 | [diff] [blame] | 611 | |
| 612 | RegTypeCache reg_types_; |
| 613 | |
| 614 | PcToRegisterLineTable reg_table_; |
| 615 | |
| 616 | // Storage for the register status we're currently working on. |
| 617 | UniquePtr<RegisterLine> work_line_; |
| 618 | |
| 619 | // The address of the instruction we're currently working on, note that this is in 2 byte |
| 620 | // quantities |
| 621 | uint32_t work_insn_idx_; |
| 622 | |
| 623 | // Storage for the register status we're saving for later. |
| 624 | UniquePtr<RegisterLine> saved_line_; |
| 625 | |
Ian Rogers | ad0b3a3 | 2012-04-16 14:50:24 -0700 | [diff] [blame] | 626 | uint32_t method_idx_; // The method we're working on. |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 627 | // Its object representation if known. |
| 628 | Method* foo_method_ GUARDED_BY(GlobalSynchronization::mutator_lock_); |
Ian Rogers | ad0b3a3 | 2012-04-16 14:50:24 -0700 | [diff] [blame] | 629 | uint32_t method_access_flags_; // Method's access flags. |
Ian Rogers | 776ac1f | 2012-04-13 23:36:36 -0700 | [diff] [blame] | 630 | const DexFile* dex_file_; // The dex file containing the method. |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 631 | // The dex_cache for the declaring class of the method. |
| 632 | DexCache* dex_cache_ GUARDED_BY(GlobalSynchronization::mutator_lock_); |
| 633 | // The class loader for the declaring class of the method. |
| 634 | ClassLoader* class_loader_ GUARDED_BY(GlobalSynchronization::mutator_lock_); |
Ian Rogers | 776ac1f | 2012-04-13 23:36:36 -0700 | [diff] [blame] | 635 | uint32_t class_def_idx_; // The class def index of the declaring class of the method. |
| 636 | const DexFile::CodeItem* code_item_; // The code item containing the code for the method. |
| 637 | UniquePtr<InsnFlags[]> insn_flags_; // Instruction widths and flags, one entry per code unit. |
| 638 | |
Elliott Hughes | 08fc03a | 2012-06-26 17:34:00 -0700 | [diff] [blame] | 639 | // The dex PC of a FindLocksAtDexPc request, -1 otherwise. |
| 640 | uint32_t interesting_dex_pc_; |
| 641 | // The container into which FindLocksAtDexPc should write the registers containing held locks, |
| 642 | // NULL if we're not doing FindLocksAtDexPc. |
| 643 | std::vector<uint32_t>* monitor_enter_dex_pcs_; |
| 644 | |
Ian Rogers | ad0b3a3 | 2012-04-16 14:50:24 -0700 | [diff] [blame] | 645 | // The types of any error that occurs. |
| 646 | std::vector<VerifyError> failures_; |
| 647 | // Error messages associated with failures. |
| 648 | std::vector<std::ostringstream*> failure_messages_; |
| 649 | // Is there a pending hard failure? |
| 650 | bool have_pending_hard_failure_; |
Ian Rogers | 776ac1f | 2012-04-13 23:36:36 -0700 | [diff] [blame] | 651 | |
Ian Rogers | ad0b3a3 | 2012-04-16 14:50:24 -0700 | [diff] [blame] | 652 | // Info message log use primarily for verifier diagnostics. |
Ian Rogers | 776ac1f | 2012-04-13 23:36:36 -0700 | [diff] [blame] | 653 | std::ostringstream info_messages_; |
| 654 | |
| 655 | // The number of occurrences of specific opcodes. |
| 656 | size_t new_instance_count_; |
| 657 | size_t monitor_enter_count_; |
| 658 | |
| 659 | friend struct art::ReferenceMap2Visitor; // for VerifyMethodAndDump |
| 660 | }; |
| 661 | |
| 662 | } // namespace verifier |
| 663 | } // namespace art |
| 664 | |
| 665 | #endif // ART_SRC_VERIFIER_METHOD_VERIFIER_H_ |