blob: a78c2c005b8efe1520b151d5ee5a36e57902c099 [file] [log] [blame]
Shih-wei Liao2d831012011-09-28 22:06:53 -07001/*
Elliott Hughes0f3c5532012-03-30 14:51:51 -07002 * Copyright (C) 2012 The Android Open Source Project
Shih-wei Liao2d831012011-09-28 22:06:53 -07003 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Ian Rogers7655f292013-07-29 11:07:13 -070017#include "entrypoints/entrypoint_utils.h"
Shih-wei Liao2d831012011-09-28 22:06:53 -070018
Mingyao Yang98d1cc82014-05-15 17:02:16 -070019#include "base/mutex.h"
Ian Rogers2dd0e2c2013-01-24 12:42:14 -080020#include "class_linker-inl.h"
Ian Rogers4f6ad8a2013-03-18 15:27:28 -070021#include "dex_file-inl.h"
Ian Rogers1d54e732013-05-02 21:10:01 -070022#include "gc/accounting/card_table-inl.h"
Ian Rogerse5877a12014-07-16 12:06:35 -070023#include "method_helper-inl.h"
Brian Carlstromea46f952013-07-30 01:26:50 -070024#include "mirror/art_field-inl.h"
25#include "mirror/art_method-inl.h"
Ian Rogers2dd0e2c2013-01-24 12:42:14 -080026#include "mirror/class-inl.h"
Ian Rogers2dd0e2c2013-01-24 12:42:14 -080027#include "mirror/object-inl.h"
28#include "mirror/object_array-inl.h"
Ian Rogersaf6e67a2013-01-16 08:38:37 -080029#include "reflection.h"
30#include "scoped_thread_state_change.h"
TDYa1275bb86012012-04-11 05:57:28 -070031#include "ScopedLocalRef.h"
Elliott Hugheseac76672012-05-24 21:56:51 -070032#include "well_known_classes.h"
TDYa1275bb86012012-04-11 05:57:28 -070033
jeffhao41005dd2012-05-09 17:58:52 -070034namespace art {
35
Brian Carlstrom34375312014-09-10 23:10:47 -070036static inline mirror::Class* CheckFilledNewArrayAlloc(uint32_t type_idx,
37 mirror::ArtMethod* referrer,
38 int32_t component_count,
39 Thread* self,
Mathieu Chartiercbb2d202013-11-14 17:45:16 -080040 bool access_check)
Hiroshi Yamauchi3b4c1892013-09-12 21:33:12 -070041 SHARED_LOCKS_REQUIRED(Locks::mutator_lock_) {
Ian Rogers57b86d42012-03-27 16:05:41 -070042 if (UNLIKELY(component_count < 0)) {
Ian Rogers62d6c772013-02-27 08:32:07 -080043 ThrowNegativeArraySizeException(component_count);
Mathieu Chartiercbb2d202013-11-14 17:45:16 -080044 return nullptr; // Failure
Elliott Hughes6c8867d2011-10-03 16:34:05 -070045 }
Andreas Gampe58a5af82014-07-31 16:23:49 -070046 mirror::Class* klass = referrer->GetDexCacheResolvedType<false>(type_idx);
Ian Rogers57b86d42012-03-27 16:05:41 -070047 if (UNLIKELY(klass == NULL)) { // Not in dex cache so try to resolve
Ian Rogers62d6c772013-02-27 08:32:07 -080048 klass = Runtime::Current()->GetClassLinker()->ResolveType(type_idx, referrer);
Ian Rogers57b86d42012-03-27 16:05:41 -070049 if (klass == NULL) { // Error
Ian Rogers50b35e22012-10-04 10:09:15 -070050 DCHECK(self->IsExceptionPending());
Mathieu Chartiercbb2d202013-11-14 17:45:16 -080051 return nullptr; // Failure
Ian Rogers19846512012-02-24 11:42:47 -080052 }
Ian Rogersea2a11d2011-10-11 16:48:51 -070053 }
Ian Rogers57b86d42012-03-27 16:05:41 -070054 if (UNLIKELY(klass->IsPrimitive() && !klass->IsPrimitiveInt())) {
55 if (klass->IsPrimitiveLong() || klass->IsPrimitiveDouble()) {
Ian Rogers62d6c772013-02-27 08:32:07 -080056 ThrowRuntimeException("Bad filled array request for type %s",
57 PrettyDescriptor(klass).c_str());
Ian Rogers573db4a2011-12-13 15:30:50 -080058 } else {
Ian Rogers62d6c772013-02-27 08:32:07 -080059 ThrowLocation throw_location = self->GetCurrentLocationForThrow();
60 DCHECK(throw_location.GetMethod() == referrer);
Brian Carlstrom34375312014-09-10 23:10:47 -070061 self->ThrowNewExceptionF(
62 throw_location, "Ljava/lang/InternalError;",
63 "Found type %s; filled-new-array not implemented for anything but 'int'",
64 PrettyDescriptor(klass).c_str());
Ian Rogers573db4a2011-12-13 15:30:50 -080065 }
Mathieu Chartiercbb2d202013-11-14 17:45:16 -080066 return nullptr; // Failure
Ian Rogers57b86d42012-03-27 16:05:41 -070067 }
Hiroshi Yamauchi3b4c1892013-09-12 21:33:12 -070068 if (access_check) {
69 mirror::Class* referrer_klass = referrer->GetDeclaringClass();
70 if (UNLIKELY(!referrer_klass->CanAccess(klass))) {
71 ThrowIllegalAccessErrorClass(referrer_klass, klass);
Mathieu Chartiercbb2d202013-11-14 17:45:16 -080072 return nullptr; // Failure
Hiroshi Yamauchi3b4c1892013-09-12 21:33:12 -070073 }
74 }
75 DCHECK(klass->IsArrayClass()) << PrettyClass(klass);
Mathieu Chartiercbb2d202013-11-14 17:45:16 -080076 return klass;
Hiroshi Yamauchi3b4c1892013-09-12 21:33:12 -070077}
78
79// Helper function to allocate array for FILLED_NEW_ARRAY.
80mirror::Array* CheckAndAllocArrayFromCode(uint32_t type_idx, mirror::ArtMethod* referrer,
81 int32_t component_count, Thread* self,
Mathieu Chartiercbb2d202013-11-14 17:45:16 -080082 bool access_check,
Mathieu Chartiere6da9af2013-12-16 11:54:42 -080083 gc::AllocatorType /* allocator_type */) {
Mathieu Chartiercbb2d202013-11-14 17:45:16 -080084 mirror::Class* klass = CheckFilledNewArrayAlloc(type_idx, referrer, component_count, self,
85 access_check);
86 if (UNLIKELY(klass == nullptr)) {
87 return nullptr;
Hiroshi Yamauchi3b4c1892013-09-12 21:33:12 -070088 }
Mathieu Chartiere6da9af2013-12-16 11:54:42 -080089 // Always go slow path for now, filled new array is not common.
90 gc::Heap* heap = Runtime::Current()->GetHeap();
91 // Use the current allocator type in case CheckFilledNewArrayAlloc caused us to suspend and then
92 // the heap switched the allocator type while we were suspended.
Ian Rogers6fac4472014-02-25 17:01:10 -080093 return mirror::Array::Alloc<false>(self, klass, component_count, klass->GetComponentSize(),
94 heap->GetCurrentAllocator());
Hiroshi Yamauchi3b4c1892013-09-12 21:33:12 -070095}
96
97// Helper function to allocate array for FILLED_NEW_ARRAY.
Brian Carlstrom34375312014-09-10 23:10:47 -070098mirror::Array* CheckAndAllocArrayFromCodeInstrumented(uint32_t type_idx,
99 mirror::ArtMethod* referrer,
100 int32_t component_count,
101 Thread* self,
Mathieu Chartiercbb2d202013-11-14 17:45:16 -0800102 bool access_check,
Mathieu Chartiere6da9af2013-12-16 11:54:42 -0800103 gc::AllocatorType /* allocator_type */) {
Mathieu Chartiercbb2d202013-11-14 17:45:16 -0800104 mirror::Class* klass = CheckFilledNewArrayAlloc(type_idx, referrer, component_count, self,
105 access_check);
106 if (UNLIKELY(klass == nullptr)) {
107 return nullptr;
Hiroshi Yamauchi3b4c1892013-09-12 21:33:12 -0700108 }
Mathieu Chartiere6da9af2013-12-16 11:54:42 -0800109 gc::Heap* heap = Runtime::Current()->GetHeap();
110 // Use the current allocator type in case CheckFilledNewArrayAlloc caused us to suspend and then
111 // the heap switched the allocator type while we were suspended.
Ian Rogers6fac4472014-02-25 17:01:10 -0800112 return mirror::Array::Alloc<true>(self, klass, component_count, klass->GetComponentSize(),
113 heap->GetCurrentAllocator());
Ian Rogers57b86d42012-03-27 16:05:41 -0700114}
115
jeffhaod7521322012-11-21 15:38:24 -0800116void ThrowStackOverflowError(Thread* self) {
Brian Carlstrom7571e8b2013-08-12 17:04:14 -0700117 if (self->IsHandlingStackOverflow()) {
Andreas Gampe7ea6f792014-07-14 16:21:44 -0700118 LOG(ERROR) << "Recursive stack overflow.";
119 // We don't fail here because SetStackEndForStackOverflow will print better diagnostics.
Brian Carlstrom7571e8b2013-08-12 17:04:14 -0700120 }
Ian Rogers62d6c772013-02-27 08:32:07 -0800121
jeffhaod7521322012-11-21 15:38:24 -0800122 self->SetStackEndForStackOverflow(); // Allow space on the stack for constructor to execute.
123 JNIEnvExt* env = self->GetJniEnv();
124 std::string msg("stack size ");
125 msg += PrettySize(self->GetStackSize());
Andreas Gampe7ea6f792014-07-14 16:21:44 -0700126
127 // Avoid running Java code for exception initialization.
128 // TODO: Checks to make this a bit less brittle.
129
130 std::string error_msg;
131
132 // Allocate an uninitialized object.
133 ScopedLocalRef<jobject> exc(env,
134 env->AllocObject(WellKnownClasses::java_lang_StackOverflowError));
135 if (exc.get() != nullptr) {
136 // "Initialize".
137 // StackOverflowError -> VirtualMachineError -> Error -> Throwable -> Object.
138 // Only Throwable has "custom" fields:
139 // String detailMessage.
140 // Throwable cause (= this).
141 // List<Throwable> suppressedExceptions (= Collections.emptyList()).
142 // Object stackState;
143 // StackTraceElement[] stackTrace;
144 // Only Throwable has a non-empty constructor:
145 // this.stackTrace = EmptyArray.STACK_TRACE_ELEMENT;
146 // fillInStackTrace();
147
148 // detailMessage.
149 // TODO: Use String::FromModifiedUTF...?
150 ScopedLocalRef<jstring> s(env, env->NewStringUTF(msg.c_str()));
151 if (s.get() != nullptr) {
Brian Carlstrom34375312014-09-10 23:10:47 -0700152 env->SetObjectField(exc.get(), WellKnownClasses::java_lang_Throwable_detailMessage, s.get());
Andreas Gampe7ea6f792014-07-14 16:21:44 -0700153
154 // cause.
Brian Carlstrom34375312014-09-10 23:10:47 -0700155 env->SetObjectField(exc.get(), WellKnownClasses::java_lang_Throwable_cause, exc.get());
Andreas Gampe7ea6f792014-07-14 16:21:44 -0700156
157 // suppressedExceptions.
Andreas Gampe7ea6f792014-07-14 16:21:44 -0700158 ScopedLocalRef<jobject> emptylist(env, env->GetStaticObjectField(
Brian Carlstrom34375312014-09-10 23:10:47 -0700159 WellKnownClasses::java_util_Collections,
160 WellKnownClasses::java_util_Collections_EMPTY_LIST));
Andreas Gampe7ea6f792014-07-14 16:21:44 -0700161 CHECK(emptylist.get() != nullptr);
Brian Carlstrom34375312014-09-10 23:10:47 -0700162 env->SetObjectField(exc.get(),
163 WellKnownClasses::java_lang_Throwable_suppressedExceptions,
164 emptylist.get());
Andreas Gampe7ea6f792014-07-14 16:21:44 -0700165
166 // stackState is set as result of fillInStackTrace. fillInStackTrace calls
167 // nativeFillInStackTrace.
168 ScopedLocalRef<jobject> stack_state_val(env, nullptr);
169 {
170 ScopedObjectAccessUnchecked soa(env);
171 stack_state_val.reset(soa.Self()->CreateInternalStackTrace<false>(soa));
172 }
173 if (stack_state_val.get() != nullptr) {
Brian Carlstrom34375312014-09-10 23:10:47 -0700174 env->SetObjectField(exc.get(),
175 WellKnownClasses::java_lang_Throwable_stackState,
176 stack_state_val.get());
Andreas Gampe7ea6f792014-07-14 16:21:44 -0700177
178 // stackTrace.
Andreas Gampe7ea6f792014-07-14 16:21:44 -0700179 ScopedLocalRef<jobject> stack_trace_elem(env, env->GetStaticObjectField(
Brian Carlstrom34375312014-09-10 23:10:47 -0700180 WellKnownClasses::libcore_util_EmptyArray,
181 WellKnownClasses::libcore_util_EmptyArray_STACK_TRACE_ELEMENT));
182 env->SetObjectField(exc.get(),
183 WellKnownClasses::java_lang_Throwable_stackTrace,
184 stack_trace_elem.get());
Andreas Gampe7ea6f792014-07-14 16:21:44 -0700185
186 // Throw the exception.
187 ThrowLocation throw_location = self->GetCurrentLocationForThrow();
188 self->SetException(throw_location,
189 reinterpret_cast<mirror::Throwable*>(self->DecodeJObject(exc.get())));
190 } else {
191 error_msg = "Could not create stack trace.";
192 }
193 } else {
194 // Could not allocate a string object.
195 error_msg = "Couldn't throw new StackOverflowError because JNI NewStringUTF failed.";
196 }
197 } else {
198 error_msg = "Could not allocate StackOverflowError object.";
199 }
200
201 if (!error_msg.empty()) {
202 LOG(ERROR) << error_msg;
jeffhaod7521322012-11-21 15:38:24 -0800203 CHECK(self->IsExceptionPending());
204 }
Dave Allisonf9439142014-03-27 15:10:22 -0700205
206 bool explicit_overflow_check = Runtime::Current()->ExplicitStackOverflowChecks();
Dave Allisonb090a182014-08-14 17:02:48 +0000207 self->ResetDefaultStackEnd(); // Return to default stack size.
Dave Allison648d7112014-07-25 16:15:27 -0700208
209 // And restore protection if implicit checks are on.
210 if (!explicit_overflow_check) {
211 self->ProtectStack();
212 }
jeffhaod7521322012-11-21 15:38:24 -0800213}
214
Ian Rogerse5877a12014-07-16 12:06:35 -0700215void CheckReferenceResult(mirror::Object* o, Thread* self) {
Ian Rogersc0542af2014-09-03 16:16:56 -0700216 if (o == nullptr) {
Ian Rogerse5877a12014-07-16 12:06:35 -0700217 return;
218 }
Ian Rogersc0542af2014-09-03 16:16:56 -0700219 mirror::ArtMethod* m = self->GetCurrentMethod(nullptr);
Ian Rogerse5877a12014-07-16 12:06:35 -0700220 // Make sure that the result is an instance of the type this method was expected to return.
221 StackHandleScope<1> hs(self);
222 Handle<mirror::ArtMethod> h_m(hs.NewHandle(m));
223 mirror::Class* return_type = MethodHelper(h_m).GetReturnType();
224
225 if (!o->InstanceOf(return_type)) {
Ian Rogersc0542af2014-09-03 16:16:56 -0700226 Runtime::Current()->GetJavaVM()->JniAbortF(nullptr,
227 "attempt to return an instance of %s from %s",
Ian Rogers68d8b422014-07-17 11:09:10 -0700228 PrettyTypeOf(o).c_str(),
229 PrettyMethod(h_m.Get()).c_str());
Ian Rogerse5877a12014-07-16 12:06:35 -0700230 }
231}
232
Mathieu Chartier2b7c4d12014-05-19 10:52:16 -0700233JValue InvokeProxyInvocationHandler(ScopedObjectAccessAlreadyRunnable& soa, const char* shorty,
Ian Rogersaf6e67a2013-01-16 08:38:37 -0800234 jobject rcvr_jobj, jobject interface_method_jobj,
235 std::vector<jvalue>& args) {
236 DCHECK(soa.Env()->IsInstanceOf(rcvr_jobj, WellKnownClasses::java_lang_reflect_Proxy));
237
238 // Build argument array possibly triggering GC.
239 soa.Self()->AssertThreadSuspensionIsAllowable();
240 jobjectArray args_jobj = NULL;
241 const JValue zero;
Jeff Haof00571c2014-05-29 17:29:47 -0700242 int32_t target_sdk_version = Runtime::Current()->GetTargetSdkVersion();
243 // Do not create empty arrays unless needed to maintain Dalvik bug compatibility.
244 if (args.size() > 0 || (target_sdk_version > 0 && target_sdk_version <= 21)) {
Ian Rogersaf6e67a2013-01-16 08:38:37 -0800245 args_jobj = soa.Env()->NewObjectArray(args.size(), WellKnownClasses::java_lang_Object, NULL);
246 if (args_jobj == NULL) {
247 CHECK(soa.Self()->IsExceptionPending());
248 return zero;
249 }
250 for (size_t i = 0; i < args.size(); ++i) {
251 if (shorty[i + 1] == 'L') {
252 jobject val = args.at(i).l;
253 soa.Env()->SetObjectArrayElement(args_jobj, i, val);
254 } else {
255 JValue jv;
256 jv.SetJ(args.at(i).j);
Ian Rogers2dd0e2c2013-01-24 12:42:14 -0800257 mirror::Object* val = BoxPrimitive(Primitive::GetType(shorty[i + 1]), jv);
Ian Rogersaf6e67a2013-01-16 08:38:37 -0800258 if (val == NULL) {
259 CHECK(soa.Self()->IsExceptionPending());
260 return zero;
261 }
Sebastien Hertzd2fe10a2014-01-15 10:20:56 +0100262 soa.Decode<mirror::ObjectArray<mirror::Object>* >(args_jobj)->Set<false>(i, val);
Ian Rogersaf6e67a2013-01-16 08:38:37 -0800263 }
264 }
265 }
266
Brian Carlstromea46f952013-07-30 01:26:50 -0700267 // Call Proxy.invoke(Proxy proxy, ArtMethod method, Object[] args).
Ian Rogersaf6e67a2013-01-16 08:38:37 -0800268 jvalue invocation_args[3];
269 invocation_args[0].l = rcvr_jobj;
270 invocation_args[1].l = interface_method_jobj;
271 invocation_args[2].l = args_jobj;
272 jobject result =
Brian Carlstromea46f952013-07-30 01:26:50 -0700273 soa.Env()->CallStaticObjectMethodA(WellKnownClasses::java_lang_reflect_Proxy,
274 WellKnownClasses::java_lang_reflect_Proxy_invoke,
275 invocation_args);
Ian Rogersaf6e67a2013-01-16 08:38:37 -0800276
277 // Unbox result and handle error conditions.
Ian Rogers62d6c772013-02-27 08:32:07 -0800278 if (LIKELY(!soa.Self()->IsExceptionPending())) {
279 if (shorty[0] == 'V' || (shorty[0] == 'L' && result == NULL)) {
Ian Rogersaf6e67a2013-01-16 08:38:37 -0800280 // Do nothing.
281 return zero;
282 } else {
Mathieu Chartierbfd9a432014-05-21 17:43:44 -0700283 StackHandleScope<1> hs(soa.Self());
284 MethodHelper mh_interface_method(
285 hs.NewHandle(soa.Decode<mirror::ArtMethod*>(interface_method_jobj)));
286 // This can cause thread suspension.
287 mirror::Class* result_type = mh_interface_method.GetReturnType();
Ian Rogers2dd0e2c2013-01-24 12:42:14 -0800288 mirror::Object* result_ref = soa.Decode<mirror::Object*>(result);
Ian Rogers62d6c772013-02-27 08:32:07 -0800289 mirror::Object* rcvr = soa.Decode<mirror::Object*>(rcvr_jobj);
Brian Carlstromea46f952013-07-30 01:26:50 -0700290 mirror::ArtMethod* proxy_method;
Mathieu Chartierbfd9a432014-05-21 17:43:44 -0700291 if (mh_interface_method.GetMethod()->GetDeclaringClass()->IsInterface()) {
292 proxy_method = rcvr->GetClass()->FindVirtualMethodForInterface(
293 mh_interface_method.GetMethod());
Ian Rogers62d6c772013-02-27 08:32:07 -0800294 } else {
295 // Proxy dispatch to a method defined in Object.
Mathieu Chartierbfd9a432014-05-21 17:43:44 -0700296 DCHECK(mh_interface_method.GetMethod()->GetDeclaringClass()->IsObjectClass());
297 proxy_method = mh_interface_method.GetMethod();
Ian Rogers62d6c772013-02-27 08:32:07 -0800298 }
299 ThrowLocation throw_location(rcvr, proxy_method, -1);
300 JValue result_unboxed;
Ian Rogers84956ff2014-03-26 23:52:41 -0700301 if (!UnboxPrimitiveForResult(throw_location, result_ref, result_type, &result_unboxed)) {
Ian Rogers530f71c2013-02-22 23:29:00 -0800302 DCHECK(soa.Self()->IsExceptionPending());
Ian Rogers62d6c772013-02-27 08:32:07 -0800303 return zero;
Ian Rogersaf6e67a2013-01-16 08:38:37 -0800304 }
305 return result_unboxed;
306 }
307 } else {
308 // In the case of checked exceptions that aren't declared, the exception must be wrapped by
309 // a UndeclaredThrowableException.
Ian Rogers62d6c772013-02-27 08:32:07 -0800310 mirror::Throwable* exception = soa.Self()->GetException(NULL);
Ian Rogersaf6e67a2013-01-16 08:38:37 -0800311 if (exception->IsCheckedException()) {
Ian Rogers2dd0e2c2013-01-24 12:42:14 -0800312 mirror::Object* rcvr = soa.Decode<mirror::Object*>(rcvr_jobj);
Mingyao Yang98d1cc82014-05-15 17:02:16 -0700313 mirror::Class* proxy_class = rcvr->GetClass();
Brian Carlstromea46f952013-07-30 01:26:50 -0700314 mirror::ArtMethod* interface_method =
315 soa.Decode<mirror::ArtMethod*>(interface_method_jobj);
316 mirror::ArtMethod* proxy_method =
Ian Rogersaf6e67a2013-01-16 08:38:37 -0800317 rcvr->GetClass()->FindVirtualMethodForInterface(interface_method);
318 int throws_index = -1;
319 size_t num_virt_methods = proxy_class->NumVirtualMethods();
320 for (size_t i = 0; i < num_virt_methods; i++) {
321 if (proxy_class->GetVirtualMethod(i) == proxy_method) {
322 throws_index = i;
323 break;
324 }
325 }
326 CHECK_NE(throws_index, -1);
Brian Carlstrom34375312014-09-10 23:10:47 -0700327 mirror::ObjectArray<mirror::Class>* declared_exceptions =
328 proxy_class->GetThrows()->Get(throws_index);
Ian Rogers2dd0e2c2013-01-24 12:42:14 -0800329 mirror::Class* exception_class = exception->GetClass();
Ian Rogersaf6e67a2013-01-16 08:38:37 -0800330 bool declares_exception = false;
331 for (int i = 0; i < declared_exceptions->GetLength() && !declares_exception; i++) {
Ian Rogers2dd0e2c2013-01-24 12:42:14 -0800332 mirror::Class* declared_exception = declared_exceptions->Get(i);
Ian Rogersaf6e67a2013-01-16 08:38:37 -0800333 declares_exception = declared_exception->IsAssignableFrom(exception_class);
334 }
335 if (!declares_exception) {
Ian Rogers62d6c772013-02-27 08:32:07 -0800336 ThrowLocation throw_location(rcvr, proxy_method, -1);
337 soa.Self()->ThrowNewWrappedException(throw_location,
338 "Ljava/lang/reflect/UndeclaredThrowableException;",
Ian Rogersaf6e67a2013-01-16 08:38:37 -0800339 NULL);
340 }
341 }
342 return zero;
343 }
344}
Shih-wei Liao2d831012011-09-28 22:06:53 -0700345} // namespace art