Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (C) 2012 The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
Brian Carlstrom | fc0e321 | 2013-07-17 14:40:12 -0700 | [diff] [blame] | 17 | #ifndef ART_RUNTIME_SCOPED_THREAD_STATE_CHANGE_H_ |
| 18 | #define ART_RUNTIME_SCOPED_THREAD_STATE_CHANGE_H_ |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 19 | |
Elliott Hughes | 1aa246d | 2012-12-13 09:29:36 -0800 | [diff] [blame] | 20 | #include "base/casts.h" |
Ian Rogers | 693ff61 | 2013-02-01 10:56:12 -0800 | [diff] [blame] | 21 | #include "thread-inl.h" |
Mathieu Chartier | 4e30541 | 2014-02-19 10:54:44 -0800 | [diff] [blame^] | 22 | #include "verify_object.h" |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 23 | |
| 24 | namespace art { |
| 25 | |
| 26 | // Scoped change into and out of a particular state. Handles Runnable transitions that require |
| 27 | // more complicated suspension checking. The subclasses ScopedObjectAccessUnchecked and |
| 28 | // ScopedObjectAccess are used to handle the change into Runnable to get direct access to objects, |
| 29 | // the unchecked variant doesn't aid annotalysis. |
| 30 | class ScopedThreadStateChange { |
| 31 | public: |
| 32 | ScopedThreadStateChange(Thread* self, ThreadState new_thread_state) |
Ian Rogers | 1ffa32f | 2013-02-05 18:29:08 -0800 | [diff] [blame] | 33 | LOCKS_EXCLUDED(Locks::thread_suspend_count_lock_) ALWAYS_INLINE |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 34 | : self_(self), thread_state_(new_thread_state), expected_has_no_thread_(false) { |
Ian Rogers | c0fa3ad | 2013-02-05 00:11:55 -0800 | [diff] [blame] | 35 | if (UNLIKELY(self_ == NULL)) { |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 36 | // Value chosen arbitrarily and won't be used in the destructor since thread_ == NULL. |
| 37 | old_thread_state_ = kTerminated; |
Ian Rogers | 120f1c7 | 2012-09-28 17:17:10 -0700 | [diff] [blame] | 38 | Runtime* runtime = Runtime::Current(); |
Mathieu Chartier | 590fee9 | 2013-09-13 13:46:47 -0700 | [diff] [blame] | 39 | CHECK(runtime == NULL || !runtime->IsStarted() || runtime->IsShuttingDown(self_)); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 40 | } else { |
| 41 | bool runnable_transition; |
Ian Rogers | 22f454c | 2012-09-08 11:06:29 -0700 | [diff] [blame] | 42 | DCHECK_EQ(self, Thread::Current()); |
| 43 | // Read state without locks, ok as state is effectively thread local and we're not interested |
| 44 | // in the suspend count (this will be handled in the runnable transitions). |
Ian Rogers | 474b6da | 2012-09-25 00:20:38 -0700 | [diff] [blame] | 45 | old_thread_state_ = self->GetState(); |
Ian Rogers | 22f454c | 2012-09-08 11:06:29 -0700 | [diff] [blame] | 46 | runnable_transition = old_thread_state_ == kRunnable || new_thread_state == kRunnable; |
| 47 | if (!runnable_transition) { |
| 48 | // A suspended transition to another effectively suspended transition, ok to use Unsafe. |
Ian Rogers | 474b6da | 2012-09-25 00:20:38 -0700 | [diff] [blame] | 49 | self_->SetState(new_thread_state); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 50 | } |
Mathieu Chartier | 858f1c5 | 2012-10-17 17:45:55 -0700 | [diff] [blame] | 51 | |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 52 | if (runnable_transition && old_thread_state_ != new_thread_state) { |
| 53 | if (new_thread_state == kRunnable) { |
| 54 | self_->TransitionFromSuspendedToRunnable(); |
| 55 | } else { |
| 56 | DCHECK_EQ(old_thread_state_, kRunnable); |
| 57 | self_->TransitionFromRunnableToSuspended(new_thread_state); |
| 58 | } |
| 59 | } |
| 60 | } |
| 61 | } |
| 62 | |
Ian Rogers | 1ffa32f | 2013-02-05 18:29:08 -0800 | [diff] [blame] | 63 | ~ScopedThreadStateChange() LOCKS_EXCLUDED(Locks::thread_suspend_count_lock_) ALWAYS_INLINE { |
Ian Rogers | c0fa3ad | 2013-02-05 00:11:55 -0800 | [diff] [blame] | 64 | if (UNLIKELY(self_ == NULL)) { |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 65 | if (!expected_has_no_thread_) { |
Ian Rogers | 120f1c7 | 2012-09-28 17:17:10 -0700 | [diff] [blame] | 66 | Runtime* runtime = Runtime::Current(); |
Mathieu Chartier | 590fee9 | 2013-09-13 13:46:47 -0700 | [diff] [blame] | 67 | bool shutting_down = (runtime == NULL) || runtime->IsShuttingDown(nullptr); |
Ian Rogers | 120f1c7 | 2012-09-28 17:17:10 -0700 | [diff] [blame] | 68 | CHECK(shutting_down); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 69 | } |
| 70 | } else { |
| 71 | if (old_thread_state_ != thread_state_) { |
| 72 | if (old_thread_state_ == kRunnable) { |
| 73 | self_->TransitionFromSuspendedToRunnable(); |
| 74 | } else if (thread_state_ == kRunnable) { |
| 75 | self_->TransitionFromRunnableToSuspended(old_thread_state_); |
| 76 | } else { |
Ian Rogers | 22f454c | 2012-09-08 11:06:29 -0700 | [diff] [blame] | 77 | // A suspended transition to another effectively suspended transition, ok to use Unsafe. |
Ian Rogers | 474b6da | 2012-09-25 00:20:38 -0700 | [diff] [blame] | 78 | self_->SetState(old_thread_state_); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 79 | } |
| 80 | } |
| 81 | } |
| 82 | } |
| 83 | |
| 84 | Thread* Self() const { |
| 85 | return self_; |
| 86 | } |
| 87 | |
| 88 | protected: |
| 89 | // Constructor used by ScopedJniThreadState for an unattached thread that has access to the VM*. |
| 90 | ScopedThreadStateChange() |
| 91 | : self_(NULL), thread_state_(kTerminated), old_thread_state_(kTerminated), |
| 92 | expected_has_no_thread_(true) {} |
| 93 | |
| 94 | Thread* const self_; |
| 95 | const ThreadState thread_state_; |
| 96 | |
| 97 | private: |
| 98 | ThreadState old_thread_state_; |
| 99 | const bool expected_has_no_thread_; |
| 100 | |
| 101 | DISALLOW_COPY_AND_ASSIGN(ScopedThreadStateChange); |
| 102 | }; |
| 103 | |
| 104 | // Entry/exit processing for transitions from Native to Runnable (ie within JNI functions). |
| 105 | // |
| 106 | // This class performs the necessary thread state switching to and from Runnable and lets us |
| 107 | // amortize the cost of working out the current thread. Additionally it lets us check (and repair) |
| 108 | // apps that are using a JNIEnv on the wrong thread. The class also decodes and encodes Objects |
| 109 | // into jobjects via methods of this class. Performing this here enforces the Runnable thread state |
| 110 | // for use of Object, thereby inhibiting the Object being modified by GC whilst native or VM code |
| 111 | // is also manipulating the Object. |
| 112 | // |
| 113 | // The destructor transitions back to the previous thread state, typically Native. In this state |
| 114 | // GC and thread suspension may occur. |
| 115 | // |
| 116 | // For annotalysis the subclass ScopedObjectAccess (below) makes it explicit that a shared of |
| 117 | // the mutator_lock_ will be acquired on construction. |
| 118 | class ScopedObjectAccessUnchecked : public ScopedThreadStateChange { |
| 119 | public: |
| 120 | explicit ScopedObjectAccessUnchecked(JNIEnv* env) |
Ian Rogers | 1ffa32f | 2013-02-05 18:29:08 -0800 | [diff] [blame] | 121 | LOCKS_EXCLUDED(Locks::thread_suspend_count_lock_) ALWAYS_INLINE |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 122 | : ScopedThreadStateChange(ThreadForEnv(env), kRunnable), |
Ian Rogers | 1eb512d | 2013-10-18 15:42:20 -0700 | [diff] [blame] | 123 | env_(down_cast<JNIEnvExt*>(env)), vm_(env_->vm) { |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 124 | self_->VerifyStack(); |
| 125 | } |
| 126 | |
| 127 | explicit ScopedObjectAccessUnchecked(Thread* self) |
Ian Rogers | b726dcb | 2012-09-05 08:57:23 -0700 | [diff] [blame] | 128 | LOCKS_EXCLUDED(Locks::thread_suspend_count_lock_) |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 129 | : ScopedThreadStateChange(self, kRunnable), |
Ian Rogers | 1eb512d | 2013-10-18 15:42:20 -0700 | [diff] [blame] | 130 | env_(down_cast<JNIEnvExt*>(self->GetJniEnv())), |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 131 | vm_(env_ != NULL ? env_->vm : NULL) { |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 132 | self_->VerifyStack(); |
| 133 | } |
| 134 | |
| 135 | // Used when we want a scoped JNI thread state but have no thread/JNIEnv. Consequently doesn't |
| 136 | // change into Runnable or acquire a share on the mutator_lock_. |
| 137 | explicit ScopedObjectAccessUnchecked(JavaVM* vm) |
Ian Rogers | 1eb512d | 2013-10-18 15:42:20 -0700 | [diff] [blame] | 138 | : ScopedThreadStateChange(), env_(NULL), vm_(down_cast<JavaVMExt*>(vm)) {} |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 139 | |
Ian Rogers | 1ffa32f | 2013-02-05 18:29:08 -0800 | [diff] [blame] | 140 | // Here purely to force inlining. |
| 141 | ~ScopedObjectAccessUnchecked() ALWAYS_INLINE { |
Ian Rogers | c0fa3ad | 2013-02-05 00:11:55 -0800 | [diff] [blame] | 142 | } |
| 143 | |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 144 | JNIEnvExt* Env() const { |
| 145 | return env_; |
| 146 | } |
| 147 | |
| 148 | JavaVMExt* Vm() const { |
| 149 | return vm_; |
| 150 | } |
| 151 | |
| 152 | /* |
| 153 | * Add a local reference for an object to the indirect reference table associated with the |
| 154 | * current stack frame. When the native function returns, the reference will be discarded. |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 155 | * |
Elliott Hughes | 9dcd45c | 2013-07-29 14:40:52 -0700 | [diff] [blame] | 156 | * We need to allow the same reference to be added multiple times, and cope with NULL. |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 157 | * |
Elliott Hughes | 9dcd45c | 2013-07-29 14:40:52 -0700 | [diff] [blame] | 158 | * This will be called on otherwise unreferenced objects. We cannot do GC allocations here, and |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 159 | * it's best if we don't grab a mutex. |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 160 | */ |
| 161 | template<typename T> |
Ian Rogers | 2dd0e2c | 2013-01-24 12:42:14 -0800 | [diff] [blame] | 162 | T AddLocalReference(mirror::Object* obj) const SHARED_LOCKS_REQUIRED(Locks::mutator_lock_) { |
Ian Rogers | 1eb512d | 2013-10-18 15:42:20 -0700 | [diff] [blame] | 163 | Locks::mutator_lock_->AssertSharedHeld(Self()); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 164 | DCHECK_EQ(thread_state_, kRunnable); // Don't work with raw objects in non-runnable states. |
| 165 | if (obj == NULL) { |
| 166 | return NULL; |
| 167 | } |
| 168 | |
Mathieu Chartier | 4e30541 | 2014-02-19 10:54:44 -0800 | [diff] [blame^] | 169 | VerifyObject(obj); |
Mathieu Chartier | 590fee9 | 2013-09-13 13:46:47 -0700 | [diff] [blame] | 170 | |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 171 | DCHECK_NE((reinterpret_cast<uintptr_t>(obj) & 0xffff0000), 0xebad0000); |
| 172 | |
| 173 | IndirectReferenceTable& locals = Env()->locals; |
| 174 | |
| 175 | uint32_t cookie = Env()->local_ref_cookie; |
| 176 | IndirectRef ref = locals.Add(cookie, obj); |
| 177 | |
Brian Carlstrom | 7934ac2 | 2013-07-26 10:54:15 -0700 | [diff] [blame] | 178 | #if 0 // TODO: fix this to understand PushLocalFrame, so we can turn it on. |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 179 | if (Env()->check_jni) { |
| 180 | size_t entry_count = locals.Capacity(); |
| 181 | if (entry_count > 16) { |
| 182 | LOG(WARNING) << "Warning: more than 16 JNI local references: " |
| 183 | << entry_count << " (most recent was a " << PrettyTypeOf(obj) << ")\n" |
| 184 | << Dumpable<IndirectReferenceTable>(locals); |
| 185 | // TODO: LOG(FATAL) in a later release? |
| 186 | } |
| 187 | } |
| 188 | #endif |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 189 | if (Vm()->work_around_app_jni_bugs) { |
| 190 | // Hand out direct pointers to support broken old apps. |
| 191 | return reinterpret_cast<T>(obj); |
| 192 | } |
| 193 | |
| 194 | return reinterpret_cast<T>(ref); |
| 195 | } |
| 196 | |
| 197 | template<typename T> |
| 198 | T Decode(jobject obj) const |
Ian Rogers | b726dcb | 2012-09-05 08:57:23 -0700 | [diff] [blame] | 199 | SHARED_LOCKS_REQUIRED(Locks::mutator_lock_) { |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 200 | Locks::mutator_lock_->AssertSharedHeld(Self()); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 201 | DCHECK_EQ(thread_state_, kRunnable); // Don't work with raw objects in non-runnable states. |
| 202 | return down_cast<T>(Self()->DecodeJObject(obj)); |
| 203 | } |
| 204 | |
Brian Carlstrom | ea46f95 | 2013-07-30 01:26:50 -0700 | [diff] [blame] | 205 | mirror::ArtField* DecodeField(jfieldID fid) const |
Ian Rogers | b726dcb | 2012-09-05 08:57:23 -0700 | [diff] [blame] | 206 | SHARED_LOCKS_REQUIRED(Locks::mutator_lock_) { |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 207 | Locks::mutator_lock_->AssertSharedHeld(Self()); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 208 | DCHECK_EQ(thread_state_, kRunnable); // Don't work with raw objects in non-runnable states. |
Mathieu Chartier | 590fee9 | 2013-09-13 13:46:47 -0700 | [diff] [blame] | 209 | CHECK(!kMovingFields); |
Brian Carlstrom | ea46f95 | 2013-07-30 01:26:50 -0700 | [diff] [blame] | 210 | return reinterpret_cast<mirror::ArtField*>(fid); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 211 | } |
| 212 | |
Brian Carlstrom | ea46f95 | 2013-07-30 01:26:50 -0700 | [diff] [blame] | 213 | jfieldID EncodeField(mirror::ArtField* field) const |
Ian Rogers | b726dcb | 2012-09-05 08:57:23 -0700 | [diff] [blame] | 214 | SHARED_LOCKS_REQUIRED(Locks::mutator_lock_) { |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 215 | Locks::mutator_lock_->AssertSharedHeld(Self()); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 216 | DCHECK_EQ(thread_state_, kRunnable); // Don't work with raw objects in non-runnable states. |
Mathieu Chartier | 590fee9 | 2013-09-13 13:46:47 -0700 | [diff] [blame] | 217 | CHECK(!kMovingFields); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 218 | return reinterpret_cast<jfieldID>(field); |
| 219 | } |
| 220 | |
Brian Carlstrom | ea46f95 | 2013-07-30 01:26:50 -0700 | [diff] [blame] | 221 | mirror::ArtMethod* DecodeMethod(jmethodID mid) const |
Ian Rogers | b726dcb | 2012-09-05 08:57:23 -0700 | [diff] [blame] | 222 | SHARED_LOCKS_REQUIRED(Locks::mutator_lock_) { |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 223 | Locks::mutator_lock_->AssertSharedHeld(Self()); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 224 | DCHECK_EQ(thread_state_, kRunnable); // Don't work with raw objects in non-runnable states. |
Mathieu Chartier | 590fee9 | 2013-09-13 13:46:47 -0700 | [diff] [blame] | 225 | CHECK(!kMovingMethods); |
Brian Carlstrom | ea46f95 | 2013-07-30 01:26:50 -0700 | [diff] [blame] | 226 | return reinterpret_cast<mirror::ArtMethod*>(mid); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 227 | } |
| 228 | |
Brian Carlstrom | ea46f95 | 2013-07-30 01:26:50 -0700 | [diff] [blame] | 229 | jmethodID EncodeMethod(mirror::ArtMethod* method) const |
Ian Rogers | b726dcb | 2012-09-05 08:57:23 -0700 | [diff] [blame] | 230 | SHARED_LOCKS_REQUIRED(Locks::mutator_lock_) { |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 231 | Locks::mutator_lock_->AssertSharedHeld(Self()); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 232 | DCHECK_EQ(thread_state_, kRunnable); // Don't work with raw objects in non-runnable states. |
Mathieu Chartier | 590fee9 | 2013-09-13 13:46:47 -0700 | [diff] [blame] | 233 | CHECK(!kMovingMethods); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 234 | return reinterpret_cast<jmethodID>(method); |
| 235 | } |
| 236 | |
| 237 | private: |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 238 | // The full JNIEnv. |
| 239 | JNIEnvExt* const env_; |
| 240 | // The full JavaVM. |
| 241 | JavaVMExt* const vm_; |
| 242 | |
| 243 | DISALLOW_COPY_AND_ASSIGN(ScopedObjectAccessUnchecked); |
| 244 | }; |
| 245 | |
| 246 | // Annotalysis helping variant of the above. |
| 247 | class ScopedObjectAccess : public ScopedObjectAccessUnchecked { |
| 248 | public: |
| 249 | explicit ScopedObjectAccess(JNIEnv* env) |
Ian Rogers | b726dcb | 2012-09-05 08:57:23 -0700 | [diff] [blame] | 250 | LOCKS_EXCLUDED(Locks::thread_suspend_count_lock_) |
Ian Rogers | 1ffa32f | 2013-02-05 18:29:08 -0800 | [diff] [blame] | 251 | SHARED_LOCK_FUNCTION(Locks::mutator_lock_) ALWAYS_INLINE |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 252 | : ScopedObjectAccessUnchecked(env) { |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 253 | Locks::mutator_lock_->AssertSharedHeld(Self()); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 254 | } |
| 255 | |
| 256 | explicit ScopedObjectAccess(Thread* self) |
Ian Rogers | b726dcb | 2012-09-05 08:57:23 -0700 | [diff] [blame] | 257 | LOCKS_EXCLUDED(Locks::thread_suspend_count_lock_) |
| 258 | SHARED_LOCK_FUNCTION(Locks::mutator_lock_) |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 259 | : ScopedObjectAccessUnchecked(self) { |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 260 | Locks::mutator_lock_->AssertSharedHeld(Self()); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 261 | } |
| 262 | |
Ian Rogers | 1ffa32f | 2013-02-05 18:29:08 -0800 | [diff] [blame] | 263 | ~ScopedObjectAccess() UNLOCK_FUNCTION(Locks::mutator_lock_) ALWAYS_INLINE { |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 264 | // Base class will release share of lock. Invoked after this destructor. |
| 265 | } |
| 266 | |
| 267 | private: |
| 268 | // TODO: remove this constructor. It is used by check JNI's ScopedCheck to make it believe that |
| 269 | // routines operating with just a VM are sound, they are not, but when you have just a VM |
| 270 | // you cannot call the unsound routines. |
| 271 | explicit ScopedObjectAccess(JavaVM* vm) |
Ian Rogers | b726dcb | 2012-09-05 08:57:23 -0700 | [diff] [blame] | 272 | SHARED_LOCK_FUNCTION(Locks::mutator_lock_) |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 273 | : ScopedObjectAccessUnchecked(vm) {} |
| 274 | |
| 275 | friend class ScopedCheck; |
| 276 | DISALLOW_COPY_AND_ASSIGN(ScopedObjectAccess); |
| 277 | }; |
| 278 | |
| 279 | } // namespace art |
| 280 | |
Brian Carlstrom | fc0e321 | 2013-07-17 14:40:12 -0700 | [diff] [blame] | 281 | #endif // ART_RUNTIME_SCOPED_THREAD_STATE_CHANGE_H_ |