Elliott Hughes | 8daa092 | 2011-09-11 13:46:25 -0700 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (C) 2011 The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
| 17 | #include "thread_list.h" |
| 18 | |
Elliott Hughes | abbe07d | 2012-06-05 17:42:23 -0700 | [diff] [blame] | 19 | #include <dirent.h> |
Ian Rogers | d9c4fc9 | 2013-10-01 19:45:43 -0700 | [diff] [blame] | 20 | #include <ScopedLocalRef.h> |
| 21 | #include <ScopedUtfChars.h> |
Elliott Hughes | abbe07d | 2012-06-05 17:42:23 -0700 | [diff] [blame] | 22 | #include <sys/types.h> |
Elliott Hughes | 038a806 | 2011-09-18 14:12:41 -0700 | [diff] [blame] | 23 | #include <unistd.h> |
| 24 | |
Elliott Hughes | 76b6167 | 2012-12-12 17:47:30 -0800 | [diff] [blame] | 25 | #include "base/mutex.h" |
Hiroshi Yamauchi | 967a0ad | 2013-09-10 16:24:21 -0700 | [diff] [blame] | 26 | #include "base/mutex-inl.h" |
Sameer Abu Asal | a843954 | 2013-02-14 16:06:42 -0800 | [diff] [blame] | 27 | #include "base/timing_logger.h" |
Elliott Hughes | 475fc23 | 2011-10-25 15:00:35 -0700 | [diff] [blame] | 28 | #include "debugger.h" |
Ian Rogers | d9c4fc9 | 2013-10-01 19:45:43 -0700 | [diff] [blame] | 29 | #include "jni_internal.h" |
| 30 | #include "lock_word.h" |
| 31 | #include "monitor.h" |
| 32 | #include "scoped_thread_state_change.h" |
Ian Rogers | 2dd0e2c | 2013-01-24 12:42:14 -0800 | [diff] [blame] | 33 | #include "thread.h" |
Elliott Hughes | abbe07d | 2012-06-05 17:42:23 -0700 | [diff] [blame] | 34 | #include "utils.h" |
Ian Rogers | d9c4fc9 | 2013-10-01 19:45:43 -0700 | [diff] [blame] | 35 | #include "well_known_classes.h" |
Elliott Hughes | 475fc23 | 2011-10-25 15:00:35 -0700 | [diff] [blame] | 36 | |
Elliott Hughes | 8daa092 | 2011-09-11 13:46:25 -0700 | [diff] [blame] | 37 | namespace art { |
| 38 | |
Elliott Hughes | 4dd9b4d | 2011-12-12 18:29:24 -0800 | [diff] [blame] | 39 | ThreadList::ThreadList() |
Elliott Hughes | e52e49b | 2012-04-02 16:05:44 -0700 | [diff] [blame] | 40 | : allocated_ids_lock_("allocated thread ids lock"), |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 41 | suspend_all_count_(0), debug_suspend_all_count_(0), |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 42 | thread_exit_cond_("thread exit condition variable", *Locks::thread_list_lock_) { |
Ian Rogers | d9c4fc9 | 2013-10-01 19:45:43 -0700 | [diff] [blame] | 43 | CHECK(Monitor::IsValidLockWord(LockWord::FromThinLockId(kMaxThreadId, 1))); |
Elliott Hughes | 8daa092 | 2011-09-11 13:46:25 -0700 | [diff] [blame] | 44 | } |
| 45 | |
| 46 | ThreadList::~ThreadList() { |
Elliott Hughes | e52e49b | 2012-04-02 16:05:44 -0700 | [diff] [blame] | 47 | // Detach the current thread if necessary. If we failed to start, there might not be any threads. |
Elliott Hughes | 6a14433 | 2012-04-03 13:07:11 -0700 | [diff] [blame] | 48 | // We need to detach the current thread here in case there's another thread waiting to join with |
| 49 | // us. |
Elliott Hughes | 8daa092 | 2011-09-11 13:46:25 -0700 | [diff] [blame] | 50 | if (Contains(Thread::Current())) { |
| 51 | Runtime::Current()->DetachCurrentThread(); |
| 52 | } |
Elliott Hughes | 6a14433 | 2012-04-03 13:07:11 -0700 | [diff] [blame] | 53 | |
| 54 | WaitForOtherNonDaemonThreadsToExit(); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 55 | // TODO: there's an unaddressed race here where a thread may attach during shutdown, see |
| 56 | // Thread::Init. |
Elliott Hughes | 6a14433 | 2012-04-03 13:07:11 -0700 | [diff] [blame] | 57 | SuspendAllDaemonThreads(); |
Elliott Hughes | 8daa092 | 2011-09-11 13:46:25 -0700 | [diff] [blame] | 58 | } |
| 59 | |
| 60 | bool ThreadList::Contains(Thread* thread) { |
| 61 | return find(list_.begin(), list_.end(), thread) != list_.end(); |
| 62 | } |
| 63 | |
Elliott Hughes | abbe07d | 2012-06-05 17:42:23 -0700 | [diff] [blame] | 64 | bool ThreadList::Contains(pid_t tid) { |
Mathieu Chartier | 02e2511 | 2013-08-14 16:14:24 -0700 | [diff] [blame] | 65 | for (const auto& thread : list_) { |
| 66 | if (thread->tid_ == tid) { |
Elliott Hughes | abbe07d | 2012-06-05 17:42:23 -0700 | [diff] [blame] | 67 | return true; |
| 68 | } |
| 69 | } |
| 70 | return false; |
| 71 | } |
| 72 | |
Brian Carlstrom | 24a3c2e | 2011-10-17 18:07:52 -0700 | [diff] [blame] | 73 | pid_t ThreadList::GetLockOwner() { |
Ian Rogers | b726dcb | 2012-09-05 08:57:23 -0700 | [diff] [blame] | 74 | return Locks::thread_list_lock_->GetExclusiveOwnerTid(); |
Elliott Hughes | accd83d | 2011-10-17 14:25:58 -0700 | [diff] [blame] | 75 | } |
| 76 | |
Mathieu Chartier | 590fee9 | 2013-09-13 13:46:47 -0700 | [diff] [blame] | 77 | void ThreadList::DumpNativeStacks(std::ostream& os) { |
| 78 | MutexLock mu(Thread::Current(), *Locks::thread_list_lock_); |
| 79 | for (const auto& thread : list_) { |
| 80 | os << "DUMPING THREAD " << thread->tid_ << "\n"; |
| 81 | DumpNativeStack(os, thread->tid_, "\t", true); |
| 82 | os << "\n"; |
| 83 | } |
| 84 | } |
| 85 | |
Elliott Hughes | c967f78 | 2012-04-16 10:23:15 -0700 | [diff] [blame] | 86 | void ThreadList::DumpForSigQuit(std::ostream& os) { |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 87 | { |
Ian Rogers | 50b35e2 | 2012-10-04 10:09:15 -0700 | [diff] [blame] | 88 | MutexLock mu(Thread::Current(), *Locks::thread_list_lock_); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 89 | DumpLocked(os); |
| 90 | } |
Elliott Hughes | abbe07d | 2012-06-05 17:42:23 -0700 | [diff] [blame] | 91 | DumpUnattachedThreads(os); |
| 92 | } |
| 93 | |
Ian Rogers | cfaa455 | 2012-11-26 21:00:08 -0800 | [diff] [blame] | 94 | static void DumpUnattachedThread(std::ostream& os, pid_t tid) NO_THREAD_SAFETY_ANALYSIS { |
| 95 | // TODO: No thread safety analysis as DumpState with a NULL thread won't access fields, should |
| 96 | // refactor DumpState to avoid skipping analysis. |
Elliott Hughes | abbe07d | 2012-06-05 17:42:23 -0700 | [diff] [blame] | 97 | Thread::DumpState(os, NULL, tid); |
| 98 | DumpKernelStack(os, tid, " kernel: ", false); |
Brian Carlstrom | ed8b723 | 2012-06-27 17:54:47 -0700 | [diff] [blame] | 99 | // TODO: Reenable this when the native code in system_server can handle it. |
| 100 | // Currently "adb shell kill -3 `pid system_server`" will cause it to exit. |
| 101 | if (false) { |
| 102 | DumpNativeStack(os, tid, " native: ", false); |
| 103 | } |
Elliott Hughes | abbe07d | 2012-06-05 17:42:23 -0700 | [diff] [blame] | 104 | os << "\n"; |
| 105 | } |
| 106 | |
| 107 | void ThreadList::DumpUnattachedThreads(std::ostream& os) { |
| 108 | DIR* d = opendir("/proc/self/task"); |
| 109 | if (!d) { |
| 110 | return; |
| 111 | } |
| 112 | |
Ian Rogers | 50b35e2 | 2012-10-04 10:09:15 -0700 | [diff] [blame] | 113 | Thread* self = Thread::Current(); |
Elliott Hughes | 4696b5b | 2012-10-30 10:35:10 -0700 | [diff] [blame] | 114 | dirent* e; |
| 115 | while ((e = readdir(d)) != NULL) { |
Elliott Hughes | abbe07d | 2012-06-05 17:42:23 -0700 | [diff] [blame] | 116 | char* end; |
Elliott Hughes | 4696b5b | 2012-10-30 10:35:10 -0700 | [diff] [blame] | 117 | pid_t tid = strtol(e->d_name, &end, 10); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 118 | if (!*end) { |
| 119 | bool contains; |
| 120 | { |
Ian Rogers | 50b35e2 | 2012-10-04 10:09:15 -0700 | [diff] [blame] | 121 | MutexLock mu(self, *Locks::thread_list_lock_); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 122 | contains = Contains(tid); |
| 123 | } |
| 124 | if (!contains) { |
| 125 | DumpUnattachedThread(os, tid); |
| 126 | } |
Elliott Hughes | abbe07d | 2012-06-05 17:42:23 -0700 | [diff] [blame] | 127 | } |
| 128 | } |
| 129 | closedir(d); |
Elliott Hughes | ff73806 | 2012-02-03 15:00:42 -0800 | [diff] [blame] | 130 | } |
| 131 | |
| 132 | void ThreadList::DumpLocked(std::ostream& os) { |
Elliott Hughes | 8daa092 | 2011-09-11 13:46:25 -0700 | [diff] [blame] | 133 | os << "DALVIK THREADS (" << list_.size() << "):\n"; |
Mathieu Chartier | 02e2511 | 2013-08-14 16:14:24 -0700 | [diff] [blame] | 134 | for (const auto& thread : list_) { |
| 135 | thread->Dump(os); |
Elliott Hughes | 8daa092 | 2011-09-11 13:46:25 -0700 | [diff] [blame] | 136 | os << "\n"; |
| 137 | } |
| 138 | } |
| 139 | |
Ian Rogers | 50b35e2 | 2012-10-04 10:09:15 -0700 | [diff] [blame] | 140 | void ThreadList::AssertThreadsAreSuspended(Thread* self, Thread* ignore1, Thread* ignore2) { |
| 141 | MutexLock mu(self, *Locks::thread_list_lock_); |
| 142 | MutexLock mu2(self, *Locks::thread_suspend_count_lock_); |
Mathieu Chartier | 02e2511 | 2013-08-14 16:14:24 -0700 | [diff] [blame] | 143 | for (const auto& thread : list_) { |
jeffhao | 725a957 | 2012-11-13 18:20:12 -0800 | [diff] [blame] | 144 | if (thread != ignore1 && thread != ignore2) { |
Ian Rogers | 01ae580 | 2012-09-28 16:14:01 -0700 | [diff] [blame] | 145 | CHECK(thread->IsSuspended()) |
| 146 | << "\nUnsuspended thread: <<" << *thread << "\n" |
| 147 | << "self: <<" << *Thread::Current(); |
| 148 | } |
Elliott Hughes | 8d768a9 | 2011-09-14 16:35:25 -0700 | [diff] [blame] | 149 | } |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 150 | } |
| 151 | |
Ian Rogers | 66aee5c | 2012-08-15 17:17:47 -0700 | [diff] [blame] | 152 | #if HAVE_TIMED_RWLOCK |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 153 | // Attempt to rectify locks so that we dump thread list with required locks before exiting. |
Ian Rogers | 719d1a3 | 2014-03-06 12:13:39 -0800 | [diff] [blame] | 154 | static void UnsafeLogFatalForThreadSuspendAllTimeout(Thread* self) NO_THREAD_SAFETY_ANALYSIS __attribute__((noreturn)); |
| 155 | static void UnsafeLogFatalForThreadSuspendAllTimeout(Thread* self) { |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 156 | Runtime* runtime = Runtime::Current(); |
| 157 | std::ostringstream ss; |
| 158 | ss << "Thread suspend timeout\n"; |
| 159 | runtime->DumpLockHolders(ss); |
| 160 | ss << "\n"; |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 161 | runtime->GetThreadList()->DumpLocked(ss); |
| 162 | LOG(FATAL) << ss.str(); |
Ian Rogers | 719d1a3 | 2014-03-06 12:13:39 -0800 | [diff] [blame] | 163 | exit(0); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 164 | } |
Ian Rogers | 66aee5c | 2012-08-15 17:17:47 -0700 | [diff] [blame] | 165 | #endif |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 166 | |
Mathieu Chartier | 5f51d4b | 2013-12-03 14:24:05 -0800 | [diff] [blame] | 167 | // Unlike suspending all threads where we can wait to acquire the mutator_lock_, suspending an |
| 168 | // individual thread requires polling. delay_us is the requested sleep and total_delay_us |
| 169 | // accumulates the total time spent sleeping for timeouts. The first sleep is just a yield, |
| 170 | // subsequently sleeps increase delay_us from 1ms to 500ms by doubling. |
| 171 | static void ThreadSuspendSleep(Thread* self, useconds_t* delay_us, useconds_t* total_delay_us, |
| 172 | bool holding_locks) { |
| 173 | if (!holding_locks) { |
| 174 | for (int i = kLockLevelCount - 1; i >= 0; --i) { |
| 175 | BaseMutex* held_mutex = self->GetHeldMutex(static_cast<LockLevel>(i)); |
| 176 | if (held_mutex != NULL) { |
| 177 | LOG(FATAL) << "Holding " << held_mutex->GetName() << " while sleeping for thread suspension"; |
| 178 | } |
| 179 | } |
| 180 | } |
| 181 | useconds_t new_delay_us = (*delay_us) * 2; |
| 182 | CHECK_GE(new_delay_us, *delay_us); |
| 183 | if (new_delay_us < 500000) { // Don't allow sleeping to be more than 0.5s. |
| 184 | *delay_us = new_delay_us; |
| 185 | } |
| 186 | if (*delay_us == 0) { |
| 187 | sched_yield(); |
| 188 | // Default to 1 milliseconds (note that this gets multiplied by 2 before the first sleep). |
| 189 | *delay_us = 500; |
| 190 | } else { |
| 191 | usleep(*delay_us); |
| 192 | *total_delay_us += *delay_us; |
| 193 | } |
| 194 | } |
| 195 | |
Mathieu Chartier | 0e4627e | 2012-10-23 16:13:36 -0700 | [diff] [blame] | 196 | size_t ThreadList::RunCheckpoint(Closure* checkpoint_function) { |
Mathieu Chartier | 858f1c5 | 2012-10-17 17:45:55 -0700 | [diff] [blame] | 197 | Thread* self = Thread::Current(); |
Mathieu Chartier | 6dda898 | 2014-03-06 11:11:48 -0800 | [diff] [blame] | 198 | Locks::mutator_lock_->AssertNotExclusiveHeld(self); |
| 199 | Locks::thread_list_lock_->AssertNotHeld(self); |
| 200 | Locks::thread_suspend_count_lock_->AssertNotHeld(self); |
| 201 | if (kDebugLocking) { |
Mathieu Chartier | 858f1c5 | 2012-10-17 17:45:55 -0700 | [diff] [blame] | 202 | CHECK_NE(self->GetState(), kRunnable); |
| 203 | } |
| 204 | |
| 205 | std::vector<Thread*> suspended_count_modified_threads; |
| 206 | size_t count = 0; |
| 207 | { |
| 208 | // Call a checkpoint function for each thread, threads which are suspend get their checkpoint |
| 209 | // manually called. |
| 210 | MutexLock mu(self, *Locks::thread_list_lock_); |
Ian Rogers | d9c4fc9 | 2013-10-01 19:45:43 -0700 | [diff] [blame] | 211 | MutexLock mu2(self, *Locks::thread_suspend_count_lock_); |
Mathieu Chartier | 02e2511 | 2013-08-14 16:14:24 -0700 | [diff] [blame] | 212 | for (const auto& thread : list_) { |
Mathieu Chartier | 858f1c5 | 2012-10-17 17:45:55 -0700 | [diff] [blame] | 213 | if (thread != self) { |
Ian Rogers | d9c4fc9 | 2013-10-01 19:45:43 -0700 | [diff] [blame] | 214 | while (true) { |
Mathieu Chartier | 858f1c5 | 2012-10-17 17:45:55 -0700 | [diff] [blame] | 215 | if (thread->RequestCheckpoint(checkpoint_function)) { |
Dave Allison | 0aded08 | 2013-11-07 13:15:11 -0800 | [diff] [blame] | 216 | // This thread will run its checkpoint some time in the near future. |
Mathieu Chartier | 858f1c5 | 2012-10-17 17:45:55 -0700 | [diff] [blame] | 217 | count++; |
| 218 | break; |
| 219 | } else { |
| 220 | // We are probably suspended, try to make sure that we stay suspended. |
Mathieu Chartier | 858f1c5 | 2012-10-17 17:45:55 -0700 | [diff] [blame] | 221 | // The thread switched back to runnable. |
| 222 | if (thread->GetState() == kRunnable) { |
Ian Rogers | d9c4fc9 | 2013-10-01 19:45:43 -0700 | [diff] [blame] | 223 | // Spurious fail, try again. |
Mathieu Chartier | 858f1c5 | 2012-10-17 17:45:55 -0700 | [diff] [blame] | 224 | continue; |
| 225 | } |
| 226 | thread->ModifySuspendCount(self, +1, false); |
| 227 | suspended_count_modified_threads.push_back(thread); |
| 228 | break; |
| 229 | } |
| 230 | } |
| 231 | } |
| 232 | } |
| 233 | } |
| 234 | |
| 235 | // Run the checkpoint on ourself while we wait for threads to suspend. |
| 236 | checkpoint_function->Run(self); |
| 237 | |
| 238 | // Run the checkpoint on the suspended threads. |
Mathieu Chartier | 02e2511 | 2013-08-14 16:14:24 -0700 | [diff] [blame] | 239 | for (const auto& thread : suspended_count_modified_threads) { |
Mathieu Chartier | 858f1c5 | 2012-10-17 17:45:55 -0700 | [diff] [blame] | 240 | if (!thread->IsSuspended()) { |
| 241 | // Wait until the thread is suspended. |
Mathieu Chartier | 5f51d4b | 2013-12-03 14:24:05 -0800 | [diff] [blame] | 242 | useconds_t total_delay_us = 0; |
Mathieu Chartier | 858f1c5 | 2012-10-17 17:45:55 -0700 | [diff] [blame] | 243 | do { |
Mathieu Chartier | 5f51d4b | 2013-12-03 14:24:05 -0800 | [diff] [blame] | 244 | useconds_t delay_us = 100; |
| 245 | ThreadSuspendSleep(self, &delay_us, &total_delay_us, true); |
Mathieu Chartier | 858f1c5 | 2012-10-17 17:45:55 -0700 | [diff] [blame] | 246 | } while (!thread->IsSuspended()); |
Mathieu Chartier | 5f51d4b | 2013-12-03 14:24:05 -0800 | [diff] [blame] | 247 | // Shouldn't need to wait for longer than 1000 microseconds. |
| 248 | constexpr useconds_t kLongWaitThresholdUS = 1000; |
| 249 | if (UNLIKELY(total_delay_us > kLongWaitThresholdUS)) { |
| 250 | LOG(WARNING) << "Waited " << total_delay_us << " us for thread suspend!"; |
Mathieu Chartier | 858f1c5 | 2012-10-17 17:45:55 -0700 | [diff] [blame] | 251 | } |
| 252 | } |
| 253 | // We know for sure that the thread is suspended at this point. |
Ian Rogers | d9c4fc9 | 2013-10-01 19:45:43 -0700 | [diff] [blame] | 254 | checkpoint_function->Run(thread); |
Mathieu Chartier | 858f1c5 | 2012-10-17 17:45:55 -0700 | [diff] [blame] | 255 | { |
| 256 | MutexLock mu2(self, *Locks::thread_suspend_count_lock_); |
| 257 | thread->ModifySuspendCount(self, -1, false); |
| 258 | } |
| 259 | } |
| 260 | |
Mathieu Chartier | 664bebf | 2012-11-12 16:54:11 -0800 | [diff] [blame] | 261 | { |
| 262 | // Imitate ResumeAll, threads may be waiting on Thread::resume_cond_ since we raised their |
| 263 | // suspend count. Now the suspend_count_ is lowered so we must do the broadcast. |
| 264 | MutexLock mu2(self, *Locks::thread_suspend_count_lock_); |
| 265 | Thread::resume_cond_->Broadcast(self); |
| 266 | } |
| 267 | |
Mathieu Chartier | 858f1c5 | 2012-10-17 17:45:55 -0700 | [diff] [blame] | 268 | // Add one for self. |
| 269 | return count + suspended_count_modified_threads.size() + 1; |
| 270 | } |
| 271 | |
Dave Allison | 39c3bfb | 2014-01-28 18:33:52 -0800 | [diff] [blame] | 272 | // Request that a checkpoint function be run on all active (non-suspended) |
| 273 | // threads. Returns the number of successful requests. |
| 274 | size_t ThreadList::RunCheckpointOnRunnableThreads(Closure* checkpoint_function) { |
| 275 | Thread* self = Thread::Current(); |
| 276 | if (kIsDebugBuild) { |
| 277 | Locks::mutator_lock_->AssertNotExclusiveHeld(self); |
| 278 | Locks::thread_list_lock_->AssertNotHeld(self); |
| 279 | Locks::thread_suspend_count_lock_->AssertNotHeld(self); |
| 280 | CHECK_NE(self->GetState(), kRunnable); |
| 281 | } |
| 282 | |
| 283 | size_t count = 0; |
| 284 | { |
| 285 | // Call a checkpoint function for each non-suspended thread. |
| 286 | MutexLock mu(self, *Locks::thread_list_lock_); |
| 287 | MutexLock mu2(self, *Locks::thread_suspend_count_lock_); |
| 288 | for (const auto& thread : list_) { |
| 289 | if (thread != self) { |
| 290 | if (thread->RequestCheckpoint(checkpoint_function)) { |
| 291 | // This thread will run its checkpoint some time in the near future. |
| 292 | count++; |
| 293 | } |
| 294 | } |
| 295 | } |
| 296 | } |
| 297 | |
| 298 | // Return the number of threads that will run the checkpoint function. |
| 299 | return count; |
| 300 | } |
| 301 | |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 302 | void ThreadList::SuspendAll() { |
| 303 | Thread* self = Thread::Current(); |
Brian Carlstrom | 6449c62 | 2014-02-10 23:48:36 -0800 | [diff] [blame] | 304 | DCHECK(self != nullptr); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 305 | |
| 306 | VLOG(threads) << *self << " SuspendAll starting..."; |
| 307 | |
Mathieu Chartier | 6dda898 | 2014-03-06 11:11:48 -0800 | [diff] [blame] | 308 | Locks::mutator_lock_->AssertNotHeld(self); |
| 309 | Locks::thread_list_lock_->AssertNotHeld(self); |
| 310 | Locks::thread_suspend_count_lock_->AssertNotHeld(self); |
| 311 | if (kDebugLocking) { |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 312 | CHECK_NE(self->GetState(), kRunnable); |
| 313 | } |
| 314 | { |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 315 | MutexLock mu(self, *Locks::thread_list_lock_); |
Mathieu Chartier | 6dda898 | 2014-03-06 11:11:48 -0800 | [diff] [blame] | 316 | MutexLock mu2(self, *Locks::thread_suspend_count_lock_); |
| 317 | // Update global suspend all state for attaching threads. |
| 318 | ++suspend_all_count_; |
| 319 | // Increment everybody's suspend count (except our own). |
| 320 | for (const auto& thread : list_) { |
| 321 | if (thread == self) { |
| 322 | continue; |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 323 | } |
Mathieu Chartier | 6dda898 | 2014-03-06 11:11:48 -0800 | [diff] [blame] | 324 | VLOG(threads) << "requesting thread suspend: " << *thread; |
| 325 | thread->ModifySuspendCount(self, +1, false); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 326 | } |
| 327 | } |
| 328 | |
Ian Rogers | 66aee5c | 2012-08-15 17:17:47 -0700 | [diff] [blame] | 329 | // Block on the mutator lock until all Runnable threads release their share of access. |
| 330 | #if HAVE_TIMED_RWLOCK |
| 331 | // Timeout if we wait more than 30 seconds. |
Ian Rogers | 719d1a3 | 2014-03-06 12:13:39 -0800 | [diff] [blame] | 332 | if (!Locks::mutator_lock_->ExclusiveLockWithTimeout(self, 30 * 1000, 0)) { |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 333 | UnsafeLogFatalForThreadSuspendAllTimeout(self); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 334 | } |
Ian Rogers | 66aee5c | 2012-08-15 17:17:47 -0700 | [diff] [blame] | 335 | #else |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 336 | Locks::mutator_lock_->ExclusiveLock(self); |
Ian Rogers | 66aee5c | 2012-08-15 17:17:47 -0700 | [diff] [blame] | 337 | #endif |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 338 | |
Mathieu Chartier | 6dda898 | 2014-03-06 11:11:48 -0800 | [diff] [blame] | 339 | if (kDebugLocking) { |
| 340 | // Debug check that all threads are suspended. |
| 341 | AssertThreadsAreSuspended(self, self); |
| 342 | } |
Elliott Hughes | 8d768a9 | 2011-09-14 16:35:25 -0700 | [diff] [blame] | 343 | |
Elliott Hughes | 4dd9b4d | 2011-12-12 18:29:24 -0800 | [diff] [blame] | 344 | VLOG(threads) << *self << " SuspendAll complete"; |
Elliott Hughes | 8d768a9 | 2011-09-14 16:35:25 -0700 | [diff] [blame] | 345 | } |
| 346 | |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 347 | void ThreadList::ResumeAll() { |
| 348 | Thread* self = Thread::Current(); |
| 349 | |
| 350 | VLOG(threads) << *self << " ResumeAll starting"; |
Ian Rogers | 01ae580 | 2012-09-28 16:14:01 -0700 | [diff] [blame] | 351 | |
Mathieu Chartier | 6dda898 | 2014-03-06 11:11:48 -0800 | [diff] [blame] | 352 | if (kDebugLocking) { |
| 353 | // Debug check that all threads are suspended. |
| 354 | AssertThreadsAreSuspended(self, self); |
| 355 | } |
Ian Rogers | 01ae580 | 2012-09-28 16:14:01 -0700 | [diff] [blame] | 356 | |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 357 | Locks::mutator_lock_->ExclusiveUnlock(self); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 358 | { |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 359 | MutexLock mu(self, *Locks::thread_list_lock_); |
| 360 | MutexLock mu2(self, *Locks::thread_suspend_count_lock_); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 361 | // Update global suspend all state for attaching threads. |
| 362 | --suspend_all_count_; |
| 363 | // Decrement the suspend counts for all threads. |
Mathieu Chartier | 02e2511 | 2013-08-14 16:14:24 -0700 | [diff] [blame] | 364 | for (const auto& thread : list_) { |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 365 | if (thread == self) { |
| 366 | continue; |
| 367 | } |
Ian Rogers | 01ae580 | 2012-09-28 16:14:01 -0700 | [diff] [blame] | 368 | thread->ModifySuspendCount(self, -1, false); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 369 | } |
| 370 | |
| 371 | // Broadcast a notification to all suspended threads, some or all of |
| 372 | // which may choose to wake up. No need to wait for them. |
| 373 | VLOG(threads) << *self << " ResumeAll waking others"; |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 374 | Thread::resume_cond_->Broadcast(self); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 375 | } |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 376 | VLOG(threads) << *self << " ResumeAll complete"; |
| 377 | } |
| 378 | |
| 379 | void ThreadList::Resume(Thread* thread, bool for_debugger) { |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 380 | Thread* self = Thread::Current(); |
| 381 | DCHECK_NE(thread, self); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 382 | VLOG(threads) << "Resume(" << *thread << ") starting..." << (for_debugger ? " (debugger)" : ""); |
Elliott Hughes | 01158d7 | 2011-09-19 19:47:10 -0700 | [diff] [blame] | 383 | |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 384 | { |
| 385 | // To check Contains. |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 386 | MutexLock mu(self, *Locks::thread_list_lock_); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 387 | // To check IsSuspended. |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 388 | MutexLock mu2(self, *Locks::thread_suspend_count_lock_); |
| 389 | DCHECK(thread->IsSuspended()); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 390 | if (!Contains(thread)) { |
| 391 | return; |
| 392 | } |
Ian Rogers | 01ae580 | 2012-09-28 16:14:01 -0700 | [diff] [blame] | 393 | thread->ModifySuspendCount(self, -1, for_debugger); |
Elliott Hughes | 01158d7 | 2011-09-19 19:47:10 -0700 | [diff] [blame] | 394 | } |
| 395 | |
| 396 | { |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 397 | VLOG(threads) << "Resume(" << *thread << ") waking others"; |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 398 | MutexLock mu(self, *Locks::thread_suspend_count_lock_); |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 399 | Thread::resume_cond_->Broadcast(self); |
Elliott Hughes | 01158d7 | 2011-09-19 19:47:10 -0700 | [diff] [blame] | 400 | } |
| 401 | |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 402 | VLOG(threads) << "Resume(" << *thread << ") complete"; |
| 403 | } |
Elliott Hughes | 01158d7 | 2011-09-19 19:47:10 -0700 | [diff] [blame] | 404 | |
Ian Rogers | d9c4fc9 | 2013-10-01 19:45:43 -0700 | [diff] [blame] | 405 | static void ThreadSuspendByPeerWarning(Thread* self, int level, const char* message, jobject peer) { |
| 406 | JNIEnvExt* env = self->GetJniEnv(); |
| 407 | ScopedLocalRef<jstring> |
| 408 | scoped_name_string(env, (jstring)env->GetObjectField(peer, |
| 409 | WellKnownClasses::java_lang_Thread_name)); |
| 410 | ScopedUtfChars scoped_name_chars(env, scoped_name_string.get()); |
| 411 | if (scoped_name_chars.c_str() == NULL) { |
| 412 | LOG(level) << message << ": " << peer; |
| 413 | env->ExceptionClear(); |
| 414 | } else { |
| 415 | LOG(level) << message << ": " << peer << ":" << scoped_name_chars.c_str(); |
| 416 | } |
| 417 | } |
| 418 | |
Ian Rogers | d9c4fc9 | 2013-10-01 19:45:43 -0700 | [diff] [blame] | 419 | Thread* ThreadList::SuspendThreadByPeer(jobject peer, bool request_suspension, |
| 420 | bool debug_suspension, bool* timed_out) { |
| 421 | static const useconds_t kTimeoutUs = 30 * 1000000; // 30s. |
| 422 | useconds_t total_delay_us = 0; |
| 423 | useconds_t delay_us = 0; |
| 424 | bool did_suspend_request = false; |
| 425 | *timed_out = false; |
| 426 | Thread* self = Thread::Current(); |
| 427 | while (true) { |
| 428 | Thread* thread; |
| 429 | { |
| 430 | ScopedObjectAccess soa(self); |
| 431 | MutexLock mu(self, *Locks::thread_list_lock_); |
| 432 | thread = Thread::FromManagedThread(soa, peer); |
| 433 | if (thread == NULL) { |
| 434 | ThreadSuspendByPeerWarning(self, WARNING, "No such thread for suspend", peer); |
| 435 | return NULL; |
| 436 | } |
| 437 | { |
| 438 | MutexLock mu(self, *Locks::thread_suspend_count_lock_); |
| 439 | if (request_suspension) { |
| 440 | thread->ModifySuspendCount(self, +1, debug_suspension); |
| 441 | request_suspension = false; |
| 442 | did_suspend_request = true; |
| 443 | } else { |
| 444 | // If the caller isn't requesting suspension, a suspension should have already occurred. |
| 445 | CHECK_GT(thread->GetSuspendCount(), 0); |
| 446 | } |
| 447 | // IsSuspended on the current thread will fail as the current thread is changed into |
| 448 | // Runnable above. As the suspend count is now raised if this is the current thread |
| 449 | // it will self suspend on transition to Runnable, making it hard to work with. It's simpler |
| 450 | // to just explicitly handle the current thread in the callers to this code. |
| 451 | CHECK_NE(thread, self) << "Attempt to suspend the current thread for the debugger"; |
| 452 | // If thread is suspended (perhaps it was already not Runnable but didn't have a suspend |
| 453 | // count, or else we've waited and it has self suspended) or is the current thread, we're |
| 454 | // done. |
| 455 | if (thread->IsSuspended()) { |
| 456 | return thread; |
| 457 | } |
| 458 | if (total_delay_us >= kTimeoutUs) { |
Mathieu Chartier | 590fee9 | 2013-09-13 13:46:47 -0700 | [diff] [blame] | 459 | ThreadSuspendByPeerWarning(self, FATAL, "Thread suspension timed out", peer); |
Ian Rogers | d9c4fc9 | 2013-10-01 19:45:43 -0700 | [diff] [blame] | 460 | if (did_suspend_request) { |
| 461 | thread->ModifySuspendCount(soa.Self(), -1, debug_suspension); |
| 462 | } |
| 463 | *timed_out = true; |
| 464 | return NULL; |
| 465 | } |
| 466 | } |
| 467 | // Release locks and come out of runnable state. |
| 468 | } |
Mathieu Chartier | 5f51d4b | 2013-12-03 14:24:05 -0800 | [diff] [blame] | 469 | ThreadSuspendSleep(self, &delay_us, &total_delay_us, false); |
Ian Rogers | d9c4fc9 | 2013-10-01 19:45:43 -0700 | [diff] [blame] | 470 | } |
| 471 | } |
| 472 | |
| 473 | static void ThreadSuspendByThreadIdWarning(int level, const char* message, uint32_t thread_id) { |
| 474 | LOG(level) << StringPrintf("%s: %d", message, thread_id); |
| 475 | } |
| 476 | |
| 477 | Thread* ThreadList::SuspendThreadByThreadId(uint32_t thread_id, bool debug_suspension, |
| 478 | bool* timed_out) { |
| 479 | static const useconds_t kTimeoutUs = 30 * 1000000; // 30s. |
| 480 | useconds_t total_delay_us = 0; |
| 481 | useconds_t delay_us = 0; |
Ian Rogers | d9c4fc9 | 2013-10-01 19:45:43 -0700 | [diff] [blame] | 482 | *timed_out = false; |
Mathieu Chartier | 5f51d4b | 2013-12-03 14:24:05 -0800 | [diff] [blame] | 483 | Thread* suspended_thread = nullptr; |
Ian Rogers | d9c4fc9 | 2013-10-01 19:45:43 -0700 | [diff] [blame] | 484 | Thread* self = Thread::Current(); |
| 485 | CHECK_NE(thread_id, kInvalidThreadId); |
| 486 | while (true) { |
Ian Rogers | d9c4fc9 | 2013-10-01 19:45:43 -0700 | [diff] [blame] | 487 | { |
Mathieu Chartier | 5f51d4b | 2013-12-03 14:24:05 -0800 | [diff] [blame] | 488 | Thread* thread = NULL; |
Ian Rogers | d9c4fc9 | 2013-10-01 19:45:43 -0700 | [diff] [blame] | 489 | ScopedObjectAccess soa(self); |
| 490 | MutexLock mu(self, *Locks::thread_list_lock_); |
| 491 | for (const auto& it : list_) { |
| 492 | if (it->GetThreadId() == thread_id) { |
| 493 | thread = it; |
| 494 | break; |
| 495 | } |
| 496 | } |
Mathieu Chartier | 5f51d4b | 2013-12-03 14:24:05 -0800 | [diff] [blame] | 497 | if (thread == nullptr) { |
| 498 | CHECK(suspended_thread == nullptr) << "Suspended thread " << suspended_thread |
| 499 | << " no longer in thread list"; |
Ian Rogers | d9c4fc9 | 2013-10-01 19:45:43 -0700 | [diff] [blame] | 500 | // There's a race in inflating a lock and the owner giving up ownership and then dying. |
| 501 | ThreadSuspendByThreadIdWarning(WARNING, "No such thread id for suspend", thread_id); |
| 502 | return NULL; |
| 503 | } |
| 504 | { |
| 505 | MutexLock mu(self, *Locks::thread_suspend_count_lock_); |
Mathieu Chartier | 5f51d4b | 2013-12-03 14:24:05 -0800 | [diff] [blame] | 506 | if (suspended_thread == nullptr) { |
Ian Rogers | d9c4fc9 | 2013-10-01 19:45:43 -0700 | [diff] [blame] | 507 | thread->ModifySuspendCount(self, +1, debug_suspension); |
Mathieu Chartier | 5f51d4b | 2013-12-03 14:24:05 -0800 | [diff] [blame] | 508 | suspended_thread = thread; |
Ian Rogers | d9c4fc9 | 2013-10-01 19:45:43 -0700 | [diff] [blame] | 509 | } else { |
Mathieu Chartier | 5f51d4b | 2013-12-03 14:24:05 -0800 | [diff] [blame] | 510 | CHECK_EQ(suspended_thread, thread); |
Ian Rogers | d9c4fc9 | 2013-10-01 19:45:43 -0700 | [diff] [blame] | 511 | // If the caller isn't requesting suspension, a suspension should have already occurred. |
| 512 | CHECK_GT(thread->GetSuspendCount(), 0); |
| 513 | } |
| 514 | // IsSuspended on the current thread will fail as the current thread is changed into |
| 515 | // Runnable above. As the suspend count is now raised if this is the current thread |
| 516 | // it will self suspend on transition to Runnable, making it hard to work with. It's simpler |
| 517 | // to just explicitly handle the current thread in the callers to this code. |
| 518 | CHECK_NE(thread, self) << "Attempt to suspend the current thread for the debugger"; |
| 519 | // If thread is suspended (perhaps it was already not Runnable but didn't have a suspend |
| 520 | // count, or else we've waited and it has self suspended) or is the current thread, we're |
| 521 | // done. |
| 522 | if (thread->IsSuspended()) { |
| 523 | return thread; |
| 524 | } |
| 525 | if (total_delay_us >= kTimeoutUs) { |
Mathieu Chartier | 590fee9 | 2013-09-13 13:46:47 -0700 | [diff] [blame] | 526 | ThreadSuspendByThreadIdWarning(WARNING, "Thread suspension timed out", thread_id); |
Mathieu Chartier | 5f51d4b | 2013-12-03 14:24:05 -0800 | [diff] [blame] | 527 | if (suspended_thread != nullptr) { |
Ian Rogers | d9c4fc9 | 2013-10-01 19:45:43 -0700 | [diff] [blame] | 528 | thread->ModifySuspendCount(soa.Self(), -1, debug_suspension); |
| 529 | } |
| 530 | *timed_out = true; |
| 531 | return NULL; |
| 532 | } |
| 533 | } |
| 534 | // Release locks and come out of runnable state. |
| 535 | } |
Mathieu Chartier | 5f51d4b | 2013-12-03 14:24:05 -0800 | [diff] [blame] | 536 | ThreadSuspendSleep(self, &delay_us, &total_delay_us, false); |
Ian Rogers | d9c4fc9 | 2013-10-01 19:45:43 -0700 | [diff] [blame] | 537 | } |
| 538 | } |
| 539 | |
| 540 | Thread* ThreadList::FindThreadByThreadId(uint32_t thin_lock_id) { |
| 541 | Thread* self = Thread::Current(); |
| 542 | MutexLock mu(self, *Locks::thread_list_lock_); |
| 543 | for (const auto& thread : list_) { |
| 544 | if (thread->GetThreadId() == thin_lock_id) { |
| 545 | CHECK(thread == self || thread->IsSuspended()); |
| 546 | return thread; |
| 547 | } |
| 548 | } |
| 549 | return NULL; |
| 550 | } |
| 551 | |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 552 | void ThreadList::SuspendAllForDebugger() { |
| 553 | Thread* self = Thread::Current(); |
| 554 | Thread* debug_thread = Dbg::GetDebugThread(); |
| 555 | |
| 556 | VLOG(threads) << *self << " SuspendAllForDebugger starting..."; |
| 557 | |
| 558 | { |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 559 | MutexLock mu(self, *Locks::thread_list_lock_); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 560 | { |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 561 | MutexLock mu(self, *Locks::thread_suspend_count_lock_); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 562 | // Update global suspend all state for attaching threads. |
| 563 | ++suspend_all_count_; |
| 564 | ++debug_suspend_all_count_; |
| 565 | // Increment everybody's suspend count (except our own). |
Mathieu Chartier | 02e2511 | 2013-08-14 16:14:24 -0700 | [diff] [blame] | 566 | for (const auto& thread : list_) { |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 567 | if (thread == self || thread == debug_thread) { |
| 568 | continue; |
| 569 | } |
| 570 | VLOG(threads) << "requesting thread suspend: " << *thread; |
Ian Rogers | 01ae580 | 2012-09-28 16:14:01 -0700 | [diff] [blame] | 571 | thread->ModifySuspendCount(self, +1, true); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 572 | } |
| 573 | } |
| 574 | } |
| 575 | |
Ian Rogers | 66aee5c | 2012-08-15 17:17:47 -0700 | [diff] [blame] | 576 | // Block on the mutator lock until all Runnable threads release their share of access then |
| 577 | // immediately unlock again. |
| 578 | #if HAVE_TIMED_RWLOCK |
| 579 | // Timeout if we wait more than 30 seconds. |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 580 | if (!Locks::mutator_lock_->ExclusiveLockWithTimeout(self, 30 * 1000, 0)) { |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 581 | UnsafeLogFatalForThreadSuspendAllTimeout(self); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 582 | } else { |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 583 | Locks::mutator_lock_->ExclusiveUnlock(self); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 584 | } |
Ian Rogers | 66aee5c | 2012-08-15 17:17:47 -0700 | [diff] [blame] | 585 | #else |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 586 | Locks::mutator_lock_->ExclusiveLock(self); |
| 587 | Locks::mutator_lock_->ExclusiveUnlock(self); |
Ian Rogers | 66aee5c | 2012-08-15 17:17:47 -0700 | [diff] [blame] | 588 | #endif |
Ian Rogers | 50b35e2 | 2012-10-04 10:09:15 -0700 | [diff] [blame] | 589 | AssertThreadsAreSuspended(self, self, debug_thread); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 590 | |
| 591 | VLOG(threads) << *self << " SuspendAll complete"; |
Elliott Hughes | 01158d7 | 2011-09-19 19:47:10 -0700 | [diff] [blame] | 592 | } |
| 593 | |
Elliott Hughes | 475fc23 | 2011-10-25 15:00:35 -0700 | [diff] [blame] | 594 | void ThreadList::SuspendSelfForDebugger() { |
| 595 | Thread* self = Thread::Current(); |
Elliott Hughes | 01158d7 | 2011-09-19 19:47:10 -0700 | [diff] [blame] | 596 | |
Elliott Hughes | 475fc23 | 2011-10-25 15:00:35 -0700 | [diff] [blame] | 597 | // The debugger thread must not suspend itself due to debugger activity! |
| 598 | Thread* debug_thread = Dbg::GetDebugThread(); |
| 599 | CHECK(debug_thread != NULL); |
| 600 | CHECK(self != debug_thread); |
jeffhao | a77f0f6 | 2012-12-05 17:19:31 -0800 | [diff] [blame] | 601 | CHECK_NE(self->GetState(), kRunnable); |
| 602 | Locks::mutator_lock_->AssertNotHeld(self); |
Elliott Hughes | 475fc23 | 2011-10-25 15:00:35 -0700 | [diff] [blame] | 603 | |
jeffhao | a77f0f6 | 2012-12-05 17:19:31 -0800 | [diff] [blame] | 604 | { |
| 605 | // Collisions with other suspends aren't really interesting. We want |
| 606 | // to ensure that we're the only one fiddling with the suspend count |
| 607 | // though. |
| 608 | MutexLock mu(self, *Locks::thread_suspend_count_lock_); |
| 609 | self->ModifySuspendCount(self, +1, true); |
| 610 | CHECK_GT(self->suspend_count_, 0); |
| 611 | } |
Elliott Hughes | 475fc23 | 2011-10-25 15:00:35 -0700 | [diff] [blame] | 612 | |
Elliott Hughes | 1f729aa | 2012-03-02 13:55:41 -0800 | [diff] [blame] | 613 | VLOG(threads) << *self << " self-suspending (debugger)"; |
Elliott Hughes | 475fc23 | 2011-10-25 15:00:35 -0700 | [diff] [blame] | 614 | |
Sebastien Hertz | 21e729c | 2014-02-18 14:16:00 +0100 | [diff] [blame] | 615 | // Tell JDWP we've completed invocation and are ready to suspend. |
| 616 | DebugInvokeReq* pReq = self->GetInvokeReq(); |
| 617 | DCHECK(pReq != NULL); |
| 618 | if (pReq->invoke_needed) { |
| 619 | // Clear this before signaling. |
| 620 | pReq->invoke_needed = false; |
| 621 | |
| 622 | VLOG(jdwp) << "invoke complete, signaling"; |
| 623 | MutexLock mu(self, pReq->lock); |
| 624 | pReq->cond.Signal(self); |
| 625 | } |
| 626 | |
Elliott Hughes | 475fc23 | 2011-10-25 15:00:35 -0700 | [diff] [blame] | 627 | // Tell JDWP that we've completed suspension. The JDWP thread can't |
| 628 | // tell us to resume before we're fully asleep because we hold the |
| 629 | // suspend count lock. |
| 630 | Dbg::ClearWaitForEventThread(); |
| 631 | |
jeffhao | a77f0f6 | 2012-12-05 17:19:31 -0800 | [diff] [blame] | 632 | { |
| 633 | MutexLock mu(self, *Locks::thread_suspend_count_lock_); |
| 634 | while (self->suspend_count_ != 0) { |
| 635 | Thread::resume_cond_->Wait(self); |
| 636 | if (self->suspend_count_ != 0) { |
| 637 | // The condition was signaled but we're still suspended. This |
| 638 | // can happen if the debugger lets go while a SIGQUIT thread |
| 639 | // dump event is pending (assuming SignalCatcher was resumed for |
| 640 | // just long enough to try to grab the thread-suspend lock). |
| 641 | LOG(DEBUG) << *self << " still suspended after undo " |
| 642 | << "(suspend count=" << self->suspend_count_ << ")"; |
| 643 | } |
Elliott Hughes | 475fc23 | 2011-10-25 15:00:35 -0700 | [diff] [blame] | 644 | } |
jeffhao | a77f0f6 | 2012-12-05 17:19:31 -0800 | [diff] [blame] | 645 | CHECK_EQ(self->suspend_count_, 0); |
Elliott Hughes | 475fc23 | 2011-10-25 15:00:35 -0700 | [diff] [blame] | 646 | } |
jeffhao | a77f0f6 | 2012-12-05 17:19:31 -0800 | [diff] [blame] | 647 | |
Elliott Hughes | 1f729aa | 2012-03-02 13:55:41 -0800 | [diff] [blame] | 648 | VLOG(threads) << *self << " self-reviving (debugger)"; |
Elliott Hughes | 475fc23 | 2011-10-25 15:00:35 -0700 | [diff] [blame] | 649 | } |
| 650 | |
Elliott Hughes | 234ab15 | 2011-10-26 14:02:26 -0700 | [diff] [blame] | 651 | void ThreadList::UndoDebuggerSuspensions() { |
| 652 | Thread* self = Thread::Current(); |
| 653 | |
Elliott Hughes | 4dd9b4d | 2011-12-12 18:29:24 -0800 | [diff] [blame] | 654 | VLOG(threads) << *self << " UndoDebuggerSuspensions starting"; |
Elliott Hughes | 234ab15 | 2011-10-26 14:02:26 -0700 | [diff] [blame] | 655 | |
| 656 | { |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 657 | MutexLock mu(self, *Locks::thread_list_lock_); |
| 658 | MutexLock mu2(self, *Locks::thread_suspend_count_lock_); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 659 | // Update global suspend all state for attaching threads. |
| 660 | suspend_all_count_ -= debug_suspend_all_count_; |
| 661 | debug_suspend_all_count_ = 0; |
| 662 | // Update running threads. |
Mathieu Chartier | 02e2511 | 2013-08-14 16:14:24 -0700 | [diff] [blame] | 663 | for (const auto& thread : list_) { |
Elliott Hughes | 234ab15 | 2011-10-26 14:02:26 -0700 | [diff] [blame] | 664 | if (thread == self || thread->debug_suspend_count_ == 0) { |
| 665 | continue; |
| 666 | } |
Ian Rogers | 01ae580 | 2012-09-28 16:14:01 -0700 | [diff] [blame] | 667 | thread->ModifySuspendCount(self, -thread->debug_suspend_count_, true); |
Elliott Hughes | 234ab15 | 2011-10-26 14:02:26 -0700 | [diff] [blame] | 668 | } |
| 669 | } |
| 670 | |
| 671 | { |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 672 | MutexLock mu(self, *Locks::thread_suspend_count_lock_); |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 673 | Thread::resume_cond_->Broadcast(self); |
Elliott Hughes | 234ab15 | 2011-10-26 14:02:26 -0700 | [diff] [blame] | 674 | } |
| 675 | |
Elliott Hughes | 4dd9b4d | 2011-12-12 18:29:24 -0800 | [diff] [blame] | 676 | VLOG(threads) << "UndoDebuggerSuspensions(" << *self << ") complete"; |
Elliott Hughes | 234ab15 | 2011-10-26 14:02:26 -0700 | [diff] [blame] | 677 | } |
| 678 | |
Elliott Hughes | e52e49b | 2012-04-02 16:05:44 -0700 | [diff] [blame] | 679 | void ThreadList::WaitForOtherNonDaemonThreadsToExit() { |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 680 | Thread* self = Thread::Current(); |
| 681 | Locks::mutator_lock_->AssertNotHeld(self); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 682 | bool all_threads_are_daemons; |
| 683 | do { |
Ian Rogers | 120f1c7 | 2012-09-28 17:17:10 -0700 | [diff] [blame] | 684 | { |
| 685 | // No more threads can be born after we start to shutdown. |
| 686 | MutexLock mu(self, *Locks::runtime_shutdown_lock_); |
Mathieu Chartier | 590fee9 | 2013-09-13 13:46:47 -0700 | [diff] [blame] | 687 | CHECK(Runtime::Current()->IsShuttingDownLocked()); |
Ian Rogers | 120f1c7 | 2012-09-28 17:17:10 -0700 | [diff] [blame] | 688 | CHECK_EQ(Runtime::Current()->NumberOfThreadsBeingBorn(), 0U); |
| 689 | } |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 690 | all_threads_are_daemons = true; |
Ian Rogers | 120f1c7 | 2012-09-28 17:17:10 -0700 | [diff] [blame] | 691 | MutexLock mu(self, *Locks::thread_list_lock_); |
Mathieu Chartier | 02e2511 | 2013-08-14 16:14:24 -0700 | [diff] [blame] | 692 | for (const auto& thread : list_) { |
Anwar Ghuloum | 9754368 | 2013-06-14 12:58:16 -0700 | [diff] [blame] | 693 | if (thread != self && !thread->IsDaemon()) { |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 694 | all_threads_are_daemons = false; |
| 695 | break; |
| 696 | } |
| 697 | } |
| 698 | if (!all_threads_are_daemons) { |
| 699 | // Wait for another thread to exit before re-checking. |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 700 | thread_exit_cond_.Wait(self); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 701 | } |
Brian Carlstrom | df62950 | 2013-07-17 22:39:56 -0700 | [diff] [blame] | 702 | } while (!all_threads_are_daemons); |
Elliott Hughes | 038a806 | 2011-09-18 14:12:41 -0700 | [diff] [blame] | 703 | } |
| 704 | |
| 705 | void ThreadList::SuspendAllDaemonThreads() { |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 706 | Thread* self = Thread::Current(); |
| 707 | MutexLock mu(self, *Locks::thread_list_lock_); |
Brian Carlstrom | 7934ac2 | 2013-07-26 10:54:15 -0700 | [diff] [blame] | 708 | { // Tell all the daemons it's time to suspend. |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 709 | MutexLock mu2(self, *Locks::thread_suspend_count_lock_); |
Mathieu Chartier | 02e2511 | 2013-08-14 16:14:24 -0700 | [diff] [blame] | 710 | for (const auto& thread : list_) { |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 711 | // This is only run after all non-daemon threads have exited, so the remainder should all be |
| 712 | // daemons. |
Ian Rogers | 7e76286 | 2012-10-22 15:45:08 -0700 | [diff] [blame] | 713 | CHECK(thread->IsDaemon()) << *thread; |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 714 | if (thread != self) { |
Ian Rogers | 01ae580 | 2012-09-28 16:14:01 -0700 | [diff] [blame] | 715 | thread->ModifySuspendCount(self, +1, false); |
Elliott Hughes | e52e49b | 2012-04-02 16:05:44 -0700 | [diff] [blame] | 716 | } |
Elliott Hughes | 038a806 | 2011-09-18 14:12:41 -0700 | [diff] [blame] | 717 | } |
| 718 | } |
Elliott Hughes | 038a806 | 2011-09-18 14:12:41 -0700 | [diff] [blame] | 719 | // Give the threads a chance to suspend, complaining if they're slow. |
| 720 | bool have_complained = false; |
| 721 | for (int i = 0; i < 10; ++i) { |
| 722 | usleep(200 * 1000); |
| 723 | bool all_suspended = true; |
Mathieu Chartier | 02e2511 | 2013-08-14 16:14:24 -0700 | [diff] [blame] | 724 | for (const auto& thread : list_) { |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 725 | if (thread != self && thread->GetState() == kRunnable) { |
Elliott Hughes | 038a806 | 2011-09-18 14:12:41 -0700 | [diff] [blame] | 726 | if (!have_complained) { |
| 727 | LOG(WARNING) << "daemon thread not yet suspended: " << *thread; |
| 728 | have_complained = true; |
| 729 | } |
| 730 | all_suspended = false; |
| 731 | } |
| 732 | } |
| 733 | if (all_suspended) { |
| 734 | return; |
| 735 | } |
| 736 | } |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 737 | LOG(ERROR) << "suspend all daemons failed"; |
| 738 | } |
| 739 | void ThreadList::Register(Thread* self) { |
| 740 | DCHECK_EQ(self, Thread::Current()); |
| 741 | |
| 742 | if (VLOG_IS_ON(threads)) { |
| 743 | std::ostringstream oss; |
| 744 | self->ShortDump(oss); // We don't hold the mutator_lock_ yet and so cannot call Dump. |
| 745 | LOG(INFO) << "ThreadList::Register() " << *self << "\n" << oss; |
| 746 | } |
| 747 | |
| 748 | // Atomically add self to the thread list and make its thread_suspend_count_ reflect ongoing |
| 749 | // SuspendAll requests. |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 750 | MutexLock mu(self, *Locks::thread_list_lock_); |
| 751 | MutexLock mu2(self, *Locks::thread_suspend_count_lock_); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 752 | self->suspend_count_ = suspend_all_count_; |
| 753 | self->debug_suspend_count_ = debug_suspend_all_count_; |
Ian Rogers | 01ae580 | 2012-09-28 16:14:01 -0700 | [diff] [blame] | 754 | if (self->suspend_count_ > 0) { |
| 755 | self->AtomicSetFlag(kSuspendRequest); |
Dave Allison | b373e09 | 2014-02-20 16:06:36 -0800 | [diff] [blame] | 756 | self->TriggerSuspend(); |
Ian Rogers | 01ae580 | 2012-09-28 16:14:01 -0700 | [diff] [blame] | 757 | } |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 758 | CHECK(!Contains(self)); |
| 759 | list_.push_back(self); |
| 760 | } |
| 761 | |
| 762 | void ThreadList::Unregister(Thread* self) { |
| 763 | DCHECK_EQ(self, Thread::Current()); |
| 764 | |
| 765 | VLOG(threads) << "ThreadList::Unregister() " << *self; |
| 766 | |
| 767 | // Any time-consuming destruction, plus anything that can call back into managed code or |
| 768 | // suspend and so on, must happen at this point, and not in ~Thread. |
| 769 | self->Destroy(); |
| 770 | |
Ian Rogers | d9c4fc9 | 2013-10-01 19:45:43 -0700 | [diff] [blame] | 771 | uint32_t thin_lock_id = self->thin_lock_thread_id_; |
Mathieu Chartier | 5f51d4b | 2013-12-03 14:24:05 -0800 | [diff] [blame] | 772 | while (self != nullptr) { |
Ian Rogers | cfaa455 | 2012-11-26 21:00:08 -0800 | [diff] [blame] | 773 | // Remove and delete the Thread* while holding the thread_list_lock_ and |
| 774 | // thread_suspend_count_lock_ so that the unregistering thread cannot be suspended. |
Ian Rogers | 0878d65 | 2013-04-18 17:38:35 -0700 | [diff] [blame] | 775 | // Note: deliberately not using MutexLock that could hold a stale self pointer. |
| 776 | Locks::thread_list_lock_->ExclusiveLock(self); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 777 | CHECK(Contains(self)); |
Ian Rogers | cfaa455 | 2012-11-26 21:00:08 -0800 | [diff] [blame] | 778 | // Note: we don't take the thread_suspend_count_lock_ here as to be suspending a thread other |
| 779 | // than yourself you need to hold the thread_list_lock_ (see Thread::ModifySuspendCount). |
| 780 | if (!self->IsSuspended()) { |
| 781 | list_.remove(self); |
| 782 | delete self; |
Mathieu Chartier | 5f51d4b | 2013-12-03 14:24:05 -0800 | [diff] [blame] | 783 | self = nullptr; |
Ian Rogers | cfaa455 | 2012-11-26 21:00:08 -0800 | [diff] [blame] | 784 | } |
Ian Rogers | 0878d65 | 2013-04-18 17:38:35 -0700 | [diff] [blame] | 785 | Locks::thread_list_lock_->ExclusiveUnlock(self); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 786 | } |
Mathieu Chartier | 5f51d4b | 2013-12-03 14:24:05 -0800 | [diff] [blame] | 787 | // Release the thread ID after the thread is finished and deleted to avoid cases where we can |
| 788 | // temporarily have multiple threads with the same thread id. When this occurs, it causes |
| 789 | // problems in FindThreadByThreadId / SuspendThreadByThreadId. |
| 790 | ReleaseThreadId(nullptr, thin_lock_id); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 791 | |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 792 | // Clear the TLS data, so that the underlying native thread is recognizably detached. |
| 793 | // (It may wish to reattach later.) |
| 794 | CHECK_PTHREAD_CALL(pthread_setspecific, (Thread::pthread_key_self_, NULL), "detach self"); |
| 795 | |
| 796 | // Signal that a thread just detached. |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 797 | MutexLock mu(NULL, *Locks::thread_list_lock_); |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 798 | thread_exit_cond_.Signal(NULL); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 799 | } |
| 800 | |
| 801 | void ThreadList::ForEach(void (*callback)(Thread*, void*), void* context) { |
Mathieu Chartier | 02e2511 | 2013-08-14 16:14:24 -0700 | [diff] [blame] | 802 | for (const auto& thread : list_) { |
| 803 | callback(thread, context); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 804 | } |
| 805 | } |
| 806 | |
Mathieu Chartier | 83c8ee0 | 2014-01-28 14:50:23 -0800 | [diff] [blame] | 807 | void ThreadList::VisitRoots(RootCallback* callback, void* arg) const { |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 808 | MutexLock mu(Thread::Current(), *Locks::thread_list_lock_); |
Mathieu Chartier | 02e2511 | 2013-08-14 16:14:24 -0700 | [diff] [blame] | 809 | for (const auto& thread : list_) { |
Mathieu Chartier | 83c8ee0 | 2014-01-28 14:50:23 -0800 | [diff] [blame] | 810 | thread->VisitRoots(callback, arg); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 811 | } |
Elliott Hughes | 038a806 | 2011-09-18 14:12:41 -0700 | [diff] [blame] | 812 | } |
| 813 | |
Mathieu Chartier | 83c8ee0 | 2014-01-28 14:50:23 -0800 | [diff] [blame] | 814 | class VerifyRootWrapperArg { |
| 815 | public: |
| 816 | VerifyRootWrapperArg(VerifyRootCallback* callback, void* arg) : callback_(callback), arg_(arg) { |
| 817 | } |
| 818 | VerifyRootCallback* const callback_; |
| 819 | void* const arg_; |
Mathieu Chartier | 423d2a3 | 2013-09-12 17:33:56 -0700 | [diff] [blame] | 820 | }; |
| 821 | |
Mathieu Chartier | 815873e | 2014-02-13 18:02:13 -0800 | [diff] [blame] | 822 | static void VerifyRootWrapperCallback(mirror::Object** root, void* arg, uint32_t /*thread_id*/, |
| 823 | RootType /*root_type*/) { |
Mathieu Chartier | 423d2a3 | 2013-09-12 17:33:56 -0700 | [diff] [blame] | 824 | VerifyRootWrapperArg* wrapperArg = reinterpret_cast<VerifyRootWrapperArg*>(arg); |
Mathieu Chartier | 815873e | 2014-02-13 18:02:13 -0800 | [diff] [blame] | 825 | wrapperArg->callback_(*root, wrapperArg->arg_, 0, NULL); |
Mathieu Chartier | 423d2a3 | 2013-09-12 17:33:56 -0700 | [diff] [blame] | 826 | } |
| 827 | |
Mathieu Chartier | 83c8ee0 | 2014-01-28 14:50:23 -0800 | [diff] [blame] | 828 | void ThreadList::VerifyRoots(VerifyRootCallback* callback, void* arg) const { |
| 829 | VerifyRootWrapperArg wrapper(callback, arg); |
Mathieu Chartier | 6f1c949 | 2012-10-15 12:08:41 -0700 | [diff] [blame] | 830 | MutexLock mu(Thread::Current(), *Locks::thread_list_lock_); |
Mathieu Chartier | 02e2511 | 2013-08-14 16:14:24 -0700 | [diff] [blame] | 831 | for (const auto& thread : list_) { |
Mathieu Chartier | 423d2a3 | 2013-09-12 17:33:56 -0700 | [diff] [blame] | 832 | thread->VisitRoots(VerifyRootWrapperCallback, &wrapper); |
Mathieu Chartier | 6f1c949 | 2012-10-15 12:08:41 -0700 | [diff] [blame] | 833 | } |
| 834 | } |
| 835 | |
Ian Rogers | cfaa455 | 2012-11-26 21:00:08 -0800 | [diff] [blame] | 836 | uint32_t ThreadList::AllocThreadId(Thread* self) { |
| 837 | MutexLock mu(self, allocated_ids_lock_); |
Elliott Hughes | 8daa092 | 2011-09-11 13:46:25 -0700 | [diff] [blame] | 838 | for (size_t i = 0; i < allocated_ids_.size(); ++i) { |
| 839 | if (!allocated_ids_[i]) { |
| 840 | allocated_ids_.set(i); |
Brian Carlstrom | 7934ac2 | 2013-07-26 10:54:15 -0700 | [diff] [blame] | 841 | return i + 1; // Zero is reserved to mean "invalid". |
Elliott Hughes | 8daa092 | 2011-09-11 13:46:25 -0700 | [diff] [blame] | 842 | } |
| 843 | } |
| 844 | LOG(FATAL) << "Out of internal thread ids"; |
| 845 | return 0; |
| 846 | } |
| 847 | |
Ian Rogers | cfaa455 | 2012-11-26 21:00:08 -0800 | [diff] [blame] | 848 | void ThreadList::ReleaseThreadId(Thread* self, uint32_t id) { |
| 849 | MutexLock mu(self, allocated_ids_lock_); |
Brian Carlstrom | 7934ac2 | 2013-07-26 10:54:15 -0700 | [diff] [blame] | 850 | --id; // Zero is reserved to mean "invalid". |
Elliott Hughes | 8daa092 | 2011-09-11 13:46:25 -0700 | [diff] [blame] | 851 | DCHECK(allocated_ids_[id]) << id; |
| 852 | allocated_ids_.reset(id); |
| 853 | } |
| 854 | |
Elliott Hughes | 8daa092 | 2011-09-11 13:46:25 -0700 | [diff] [blame] | 855 | } // namespace art |