blob: 930795b4f6d31667a759dc6a8a72542ae0ac89e9 [file] [log] [blame]
Roland Levillain72bceff2014-09-15 18:29:00 +01001/*
2 * Copyright (C) 2014 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Mark Mendellfb8d2792015-03-31 22:16:59 -040017#include "arch/x86/instruction_set_features_x86.h"
Roland Levillain75be2832014-10-17 17:02:00 +010018#include "code_generator_x86.h"
Roland Levillain72bceff2014-09-15 18:29:00 +010019#include "dead_code_elimination.h"
Calin Juravlecd6dffe2015-01-08 17:35:35 +000020#include "driver/compiler_options.h"
Roland Levillain72bceff2014-09-15 18:29:00 +010021#include "graph_checker.h"
22#include "optimizing_unit_test.h"
Roland Levillain75be2832014-10-17 17:02:00 +010023#include "pretty_printer.h"
Roland Levillain72bceff2014-09-15 18:29:00 +010024
25#include "gtest/gtest.h"
26
27namespace art {
28
David Brazdil4833f5a2015-12-16 10:37:39 +000029class DeadCodeEliminationTest : public CommonCompilerTest {};
30
Roland Levillain72bceff2014-09-15 18:29:00 +010031static void TestCode(const uint16_t* data,
32 const std::string& expected_before,
33 const std::string& expected_after) {
34 ArenaPool pool;
35 ArenaAllocator allocator(&pool);
36 HGraph* graph = CreateCFG(&allocator, data);
37 ASSERT_NE(graph, nullptr);
38
Roland Levillain72bceff2014-09-15 18:29:00 +010039 StringPrettyPrinter printer_before(graph);
40 printer_before.VisitInsertionOrder();
41 std::string actual_before = printer_before.str();
42 ASSERT_EQ(actual_before, expected_before);
43
Mark Mendellfb8d2792015-03-31 22:16:59 -040044 std::unique_ptr<const X86InstructionSetFeatures> features_x86(
45 X86InstructionSetFeatures::FromCppDefines());
46 x86::CodeGeneratorX86 codegenX86(graph, *features_x86.get(), CompilerOptions());
Calin Juravle862aaef2015-04-22 13:31:47 +010047 HDeadCodeElimination(graph).Run();
David Brazdilbadd8262016-02-02 16:28:56 +000048 GraphChecker graph_checker(graph);
49 graph_checker.Run();
50 ASSERT_TRUE(graph_checker.IsValid());
Roland Levillain72bceff2014-09-15 18:29:00 +010051
52 StringPrettyPrinter printer_after(graph);
53 printer_after.VisitInsertionOrder();
54 std::string actual_after = printer_after.str();
55 ASSERT_EQ(actual_after, expected_after);
Roland Levillain72bceff2014-09-15 18:29:00 +010056}
57
Roland Levillain72bceff2014-09-15 18:29:00 +010058/**
59 * Small three-register program.
60 *
61 * 16-bit
62 * offset
63 * ------
64 * v1 <- 1 0. const/4 v1, #+1
65 * v0 <- 0 1. const/4 v0, #+0
66 * if v1 >= 0 goto L1 2. if-gez v1, +3
67 * v0 <- v1 4. move v0, v1
68 * L1: v2 <- v0 + v1 5. add-int v2, v0, v1
69 * return-void 7. return
70 */
David Brazdil4833f5a2015-12-16 10:37:39 +000071TEST_F(DeadCodeEliminationTest, AdditionAndConditionalJump) {
Roland Levillain72bceff2014-09-15 18:29:00 +010072 const uint16_t data[] = THREE_REGISTERS_CODE_ITEM(
73 Instruction::CONST_4 | 1 << 8 | 1 << 12,
74 Instruction::CONST_4 | 0 << 8 | 0 << 12,
75 Instruction::IF_GEZ | 1 << 8, 3,
76 Instruction::MOVE | 0 << 8 | 1 << 12,
77 Instruction::ADD_INT | 2 << 8, 0 | 1 << 8,
78 Instruction::RETURN_VOID);
79
80 std::string expected_before =
81 "BasicBlock 0, succ: 1\n"
82 " 3: IntConstant [15, 22, 8]\n"
83 " 5: IntConstant [22, 8]\n"
84 " 19: SuspendCheck\n"
85 " 20: Goto 1\n"
86 "BasicBlock 1, pred: 0, succ: 5, 2\n"
87 " 8: GreaterThanOrEqual(3, 5) [9]\n"
88 " 9: If(8)\n"
89 "BasicBlock 2, pred: 1, succ: 3\n"
90 " 12: Goto 3\n"
Nicolas Geoffray8b20f882015-06-19 16:17:05 +010091 "BasicBlock 3, pred: 5, 2, succ: 4\n"
92 " 22: Phi(5, 3) [15]\n"
Roland Levillain72bceff2014-09-15 18:29:00 +010093 " 15: Add(22, 3)\n"
94 " 17: ReturnVoid\n"
95 "BasicBlock 4, pred: 3\n"
96 " 18: Exit\n"
97 "BasicBlock 5, pred: 1, succ: 3\n"
98 " 21: Goto 3\n";
99
Roland Levillain75be2832014-10-17 17:02:00 +0100100 // Expected difference after dead code elimination.
Roland Levillain72bceff2014-09-15 18:29:00 +0100101 diff_t expected_diff = {
102 { " 3: IntConstant [15, 22, 8]\n", " 3: IntConstant [22, 8]\n" },
Nicolas Geoffray8b20f882015-06-19 16:17:05 +0100103 { " 22: Phi(5, 3) [15]\n", " 22: Phi(5, 3)\n" },
Roland Levillain72bceff2014-09-15 18:29:00 +0100104 { " 15: Add(22, 3)\n", removed }
105 };
106 std::string expected_after = Patch(expected_before, expected_diff);
107
108 TestCode(data, expected_before, expected_after);
109}
110
111/**
112 * Three-register program with jumps leading to the creation of many
113 * blocks.
114 *
115 * The intent of this test is to ensure that all dead instructions are
116 * actually pruned at compile-time, thanks to the (backward)
117 * post-order traversal of the the dominator tree.
118 *
119 * 16-bit
120 * offset
121 * ------
122 * v0 <- 0 0. const/4 v0, #+0
123 * v1 <- 1 1. const/4 v1, #+1
124 * v2 <- v0 + v1 2. add-int v2, v0, v1
125 * goto L2 4. goto +4
126 * L1: v1 <- v0 + 3 5. add-int/lit16 v1, v0, #+3
127 * goto L3 7. goto +4
128 * L2: v0 <- v2 + 2 8. add-int/lit16 v0, v2, #+2
129 * goto L1 10. goto +(-5)
130 * L3: v2 <- v1 + 4 11. add-int/lit16 v2, v1, #+4
131 * return 13. return-void
132 */
David Brazdil4833f5a2015-12-16 10:37:39 +0000133TEST_F(DeadCodeEliminationTest, AdditionsAndInconditionalJumps) {
Roland Levillain72bceff2014-09-15 18:29:00 +0100134 const uint16_t data[] = THREE_REGISTERS_CODE_ITEM(
135 Instruction::CONST_4 | 0 << 8 | 0 << 12,
136 Instruction::CONST_4 | 1 << 8 | 1 << 12,
137 Instruction::ADD_INT | 2 << 8, 0 | 1 << 8,
138 Instruction::GOTO | 4 << 8,
139 Instruction::ADD_INT_LIT16 | 1 << 8 | 0 << 12, 3,
140 Instruction::GOTO | 4 << 8,
141 Instruction::ADD_INT_LIT16 | 0 << 8 | 2 << 12, 2,
Andreas Gampe58554b72015-10-20 21:08:52 -0700142 static_cast<uint16_t>(Instruction::GOTO | 0xFFFFFFFB << 8),
Roland Levillain72bceff2014-09-15 18:29:00 +0100143 Instruction::ADD_INT_LIT16 | 2 << 8 | 1 << 12, 4,
144 Instruction::RETURN_VOID);
145
146 std::string expected_before =
147 "BasicBlock 0, succ: 1\n"
148 " 3: IntConstant [9]\n"
149 " 5: IntConstant [9]\n"
150 " 13: IntConstant [14]\n"
151 " 18: IntConstant [19]\n"
152 " 24: IntConstant [25]\n"
153 " 29: SuspendCheck\n"
154 " 30: Goto 1\n"
155 "BasicBlock 1, pred: 0, succ: 3\n"
156 " 9: Add(3, 5) [19]\n"
157 " 11: Goto 3\n"
158 "BasicBlock 2, pred: 3, succ: 4\n"
159 " 14: Add(19, 13) [25]\n"
160 " 16: Goto 4\n"
161 "BasicBlock 3, pred: 1, succ: 2\n"
162 " 19: Add(9, 18) [14]\n"
163 " 21: SuspendCheck\n"
164 " 22: Goto 2\n"
165 "BasicBlock 4, pred: 2, succ: 5\n"
166 " 25: Add(14, 24)\n"
167 " 27: ReturnVoid\n"
168 "BasicBlock 5, pred: 4\n"
169 " 28: Exit\n";
170
David Brazdil1c533c12015-04-24 17:04:38 +0100171 // The SuspendCheck instruction following this Add instruction
172 // inserts the latter in an environment, thus making it "used" and
173 // therefore non removable. It ensures that some other Add and
174 // IntConstant instructions cannot be removed, as they are direct
175 // or indirect inputs of the initial Add instruction.
176 std::string expected_after =
177 "BasicBlock 0, succ: 1\n"
178 " 3: IntConstant [9]\n"
179 " 5: IntConstant [9]\n"
180 " 18: IntConstant [19]\n"
181 " 29: SuspendCheck\n"
182 " 30: Goto 1\n"
183 "BasicBlock 1, pred: 0, succ: 5\n"
184 " 9: Add(3, 5) [19]\n"
185 " 19: Add(9, 18) []\n"
186 " 21: SuspendCheck\n"
187 " 27: ReturnVoid\n"
188 "BasicBlock 5, pred: 1\n"
189 " 28: Exit\n";
Roland Levillain72bceff2014-09-15 18:29:00 +0100190
191 TestCode(data, expected_before, expected_after);
192}
193
194} // namespace art