blob: ca5e150b894caf7e6d379d1346bafee76229d7b9 [file] [log] [blame]
Elliott Hughes2faa5f12012-01-30 14:42:07 -08001/*
2 * Copyright (C) 2011 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
jeffhaoe343b762011-12-05 16:36:44 -080016
17#include "trace.h"
18
jeffhaoa9ef3fd2011-12-13 18:33:43 -080019#include <sys/uio.h>
20
Jeff Hao0abc72e2013-08-13 13:45:14 -070021#include "base/stl_util.h"
Elliott Hughes76160052012-12-12 16:31:20 -080022#include "base/unix_file/fd_file.h"
jeffhaoe343b762011-12-05 16:36:44 -080023#include "class_linker.h"
Ian Rogers62d6c772013-02-27 08:32:07 -080024#include "common_throws.h"
jeffhaoa9ef3fd2011-12-13 18:33:43 -080025#include "debugger.h"
Ian Rogers4f6ad8a2013-03-18 15:27:28 -070026#include "dex_file-inl.h"
jeffhao725a9572012-11-13 18:20:12 -080027#include "instrumentation.h"
Brian Carlstromea46f952013-07-30 01:26:50 -070028#include "mirror/art_method-inl.h"
Ian Rogers4f6ad8a2013-03-18 15:27:28 -070029#include "mirror/class-inl.h"
Ian Rogers2dd0e2c2013-01-24 12:42:14 -080030#include "mirror/dex_cache.h"
31#include "mirror/object_array-inl.h"
Ian Rogers4f6ad8a2013-03-18 15:27:28 -070032#include "mirror/object-inl.h"
jeffhaoa9ef3fd2011-12-13 18:33:43 -080033#include "os.h"
Ian Rogers00f7d0e2012-07-19 15:28:27 -070034#include "scoped_thread_state_change.h"
Jeff Hao0abc72e2013-08-13 13:45:14 -070035#include "ScopedLocalRef.h"
jeffhaoe343b762011-12-05 16:36:44 -080036#include "thread.h"
Ian Rogers57b86d42012-03-27 16:05:41 -070037#include "thread_list.h"
Ian Rogers166db042013-07-26 12:05:57 -070038#if !defined(ART_USE_PORTABLE_COMPILER)
39#include "entrypoints/quick/quick_entrypoints.h"
40#endif
jeffhao2692b572011-12-16 15:42:28 -080041
42namespace art {
43
Elliott Hughese119a362012-05-22 17:37:06 -070044// File format:
45// header
46// record 0
47// record 1
48// ...
49//
50// Header format:
51// u4 magic ('SLOW')
52// u2 version
53// u2 offset to data
54// u8 start date/time in usec
55// u2 record size in bytes (version >= 2 only)
56// ... padding to 32 bytes
57//
58// Record format v1:
59// u1 thread ID
60// u4 method ID | method action
61// u4 time delta since start, in usec
62//
63// Record format v2:
64// u2 thread ID
65// u4 method ID | method action
66// u4 time delta since start, in usec
67//
68// Record format v3:
69// u2 thread ID
70// u4 method ID | method action
71// u4 time delta since start, in usec
72// u4 wall time since start, in usec (when clock == "dual" only)
73//
74// 32 bits of microseconds is 70 minutes.
75//
76// All values are stored in little-endian order.
77
Ian Rogers62d6c772013-02-27 08:32:07 -080078enum TraceAction {
Brian Carlstrom7934ac22013-07-26 10:54:15 -070079 kTraceMethodEnter = 0x00, // method entry
80 kTraceMethodExit = 0x01, // method exit
81 kTraceUnroll = 0x02, // method exited by exception unrolling
Ian Rogers62d6c772013-02-27 08:32:07 -080082 // 0x03 currently unused
Brian Carlstrom7934ac22013-07-26 10:54:15 -070083 kTraceMethodActionMask = 0x03, // two bits
Ian Rogers62d6c772013-02-27 08:32:07 -080084};
85
Jeff Hao0abc72e2013-08-13 13:45:14 -070086class BuildStackTraceVisitor : public StackVisitor {
87 public:
88 explicit BuildStackTraceVisitor(Thread* thread) : StackVisitor(thread, NULL),
Jeff Hao5ce4b172013-08-16 16:27:18 -070089 method_trace_(Trace::AllocStackTrace()) {}
Jeff Hao0abc72e2013-08-13 13:45:14 -070090
Ian Rogersef7d42f2014-01-06 12:55:46 -080091 bool VisitFrame() SHARED_LOCKS_REQUIRED(Locks::mutator_lock_) {
Ian Rogerse2f77e72013-08-13 19:19:40 -070092 mirror::ArtMethod* m = GetMethod();
Jeff Hao0abc72e2013-08-13 13:45:14 -070093 // Ignore runtime frames (in particular callee save).
94 if (!m->IsRuntimeMethod()) {
95 method_trace_->push_back(m);
96 }
97 return true;
98 }
99
100 // Returns a stack trace where the topmost frame corresponds with the first element of the vector.
Ian Rogerse2f77e72013-08-13 19:19:40 -0700101 std::vector<mirror::ArtMethod*>* GetStackTrace() const {
Jeff Hao0abc72e2013-08-13 13:45:14 -0700102 return method_trace_;
103 }
104
105 private:
Ian Rogerse2f77e72013-08-13 19:19:40 -0700106 std::vector<mirror::ArtMethod*>* const method_trace_;
Jeff Hao0abc72e2013-08-13 13:45:14 -0700107};
108
jeffhaoa9ef3fd2011-12-13 18:33:43 -0800109static const char kTraceTokenChar = '*';
110static const uint16_t kTraceHeaderLength = 32;
111static const uint32_t kTraceMagicValue = 0x574f4c53;
112static const uint16_t kTraceVersionSingleClock = 2;
113static const uint16_t kTraceVersionDualClock = 3;
Brian Carlstrom7934ac22013-07-26 10:54:15 -0700114static const uint16_t kTraceRecordSizeSingleClock = 10; // using v2
115static const uint16_t kTraceRecordSizeDualClock = 14; // using v3 with two timestamps
jeffhaoa9ef3fd2011-12-13 18:33:43 -0800116
Ian Rogerse63db272014-07-15 15:36:11 -0700117TraceClockSource Trace::default_clock_source_ = kDefaultTraceClockSource;
Elliott Hughese119a362012-05-22 17:37:06 -0700118
Jeff Hao0abc72e2013-08-13 13:45:14 -0700119Trace* volatile Trace::the_trace_ = NULL;
Jeff Hao0abc72e2013-08-13 13:45:14 -0700120pthread_t Trace::sampling_pthread_ = 0U;
Ian Rogers700a4022014-05-19 16:49:03 -0700121std::unique_ptr<std::vector<mirror::ArtMethod*>> Trace::temp_stack_trace_;
Ian Rogers62d6c772013-02-27 08:32:07 -0800122
Brian Carlstromea46f952013-07-30 01:26:50 -0700123static mirror::ArtMethod* DecodeTraceMethodId(uint32_t tmid) {
124 return reinterpret_cast<mirror::ArtMethod*>(tmid & ~kTraceMethodActionMask);
jeffhaoa9ef3fd2011-12-13 18:33:43 -0800125}
Elliott Hughese119a362012-05-22 17:37:06 -0700126
Ian Rogers62d6c772013-02-27 08:32:07 -0800127static TraceAction DecodeTraceAction(uint32_t tmid) {
128 return static_cast<TraceAction>(tmid & kTraceMethodActionMask);
129}
130
Ian Rogersef7d42f2014-01-06 12:55:46 -0800131static uint32_t EncodeTraceMethodAndAction(mirror::ArtMethod* method,
Ian Rogers62d6c772013-02-27 08:32:07 -0800132 TraceAction action) {
Ian Rogersef7d42f2014-01-06 12:55:46 -0800133 uint32_t tmid = PointerToLowMemUInt32(method) | action;
Ian Rogers62d6c772013-02-27 08:32:07 -0800134 DCHECK_EQ(method, DecodeTraceMethodId(tmid));
135 return tmid;
jeffhaoa9ef3fd2011-12-13 18:33:43 -0800136}
137
Jeff Hao5ce4b172013-08-16 16:27:18 -0700138std::vector<mirror::ArtMethod*>* Trace::AllocStackTrace() {
139 if (temp_stack_trace_.get() != NULL) {
140 return temp_stack_trace_.release();
141 } else {
142 return new std::vector<mirror::ArtMethod*>();
143 }
144}
145
146void Trace::FreeStackTrace(std::vector<mirror::ArtMethod*>* stack_trace) {
147 stack_trace->clear();
148 temp_stack_trace_.reset(stack_trace);
149}
150
Ian Rogerse63db272014-07-15 15:36:11 -0700151void Trace::SetDefaultClockSource(TraceClockSource clock_source) {
Ian Rogers62d6c772013-02-27 08:32:07 -0800152#if defined(HAVE_POSIX_CLOCKS)
153 default_clock_source_ = clock_source;
154#else
Ian Rogerse63db272014-07-15 15:36:11 -0700155 if (clock_source != kTraceClockSourceWall) {
Jeff Hao5ce4b172013-08-16 16:27:18 -0700156 LOG(WARNING) << "Ignoring tracing request to use CPU time.";
Ian Rogers62d6c772013-02-27 08:32:07 -0800157 }
158#endif
159}
160
Ian Rogerse63db272014-07-15 15:36:11 -0700161static uint16_t GetTraceVersion(TraceClockSource clock_source) {
162 return (clock_source == kTraceClockSourceDual) ? kTraceVersionDualClock
Ian Rogers62d6c772013-02-27 08:32:07 -0800163 : kTraceVersionSingleClock;
164}
165
Ian Rogerse63db272014-07-15 15:36:11 -0700166static uint16_t GetRecordSize(TraceClockSource clock_source) {
167 return (clock_source == kTraceClockSourceDual) ? kTraceRecordSizeDualClock
Ian Rogers62d6c772013-02-27 08:32:07 -0800168 : kTraceRecordSizeSingleClock;
jeffhaoa9ef3fd2011-12-13 18:33:43 -0800169}
170
Elliott Hughese119a362012-05-22 17:37:06 -0700171bool Trace::UseThreadCpuClock() {
Ian Rogerse63db272014-07-15 15:36:11 -0700172 return (clock_source_ == kTraceClockSourceThreadCpu) ||
173 (clock_source_ == kTraceClockSourceDual);
jeffhaoa9ef3fd2011-12-13 18:33:43 -0800174}
175
Elliott Hughese119a362012-05-22 17:37:06 -0700176bool Trace::UseWallClock() {
Ian Rogerse63db272014-07-15 15:36:11 -0700177 return (clock_source_ == kTraceClockSourceWall) ||
178 (clock_source_ == kTraceClockSourceDual);
Elliott Hughese119a362012-05-22 17:37:06 -0700179}
180
Jeff Haoc5d824a2014-07-28 18:35:38 -0700181void Trace::MeasureClockOverhead() {
182 if (UseThreadCpuClock()) {
Jeff Hao57dac6e2013-08-15 16:36:24 -0700183 Thread::Current()->GetCpuMicroTime();
jeffhaoa9ef3fd2011-12-13 18:33:43 -0800184 }
Jeff Haoc5d824a2014-07-28 18:35:38 -0700185 if (UseWallClock()) {
jeffhaoa9ef3fd2011-12-13 18:33:43 -0800186 MicroTime();
187 }
188}
189
Jeff Hao5ce4b172013-08-16 16:27:18 -0700190// Compute an average time taken to measure clocks.
Jeff Haoc5d824a2014-07-28 18:35:38 -0700191uint32_t Trace::GetClockOverheadNanoSeconds() {
Jeff Hao57dac6e2013-08-15 16:36:24 -0700192 Thread* self = Thread::Current();
193 uint64_t start = self->GetCpuMicroTime();
jeffhaoa9ef3fd2011-12-13 18:33:43 -0800194
195 for (int i = 4000; i > 0; i--) {
Jeff Haoc5d824a2014-07-28 18:35:38 -0700196 MeasureClockOverhead();
197 MeasureClockOverhead();
198 MeasureClockOverhead();
199 MeasureClockOverhead();
200 MeasureClockOverhead();
201 MeasureClockOverhead();
202 MeasureClockOverhead();
203 MeasureClockOverhead();
jeffhaoa9ef3fd2011-12-13 18:33:43 -0800204 }
205
Jeff Hao5ce4b172013-08-16 16:27:18 -0700206 uint64_t elapsed_us = self->GetCpuMicroTime() - start;
207 return static_cast<uint32_t>(elapsed_us / 32);
jeffhaoa9ef3fd2011-12-13 18:33:43 -0800208}
209
Elliott Hughesffb465f2012-03-01 18:46:05 -0800210// TODO: put this somewhere with the big-endian equivalent used by JDWP.
211static void Append2LE(uint8_t* buf, uint16_t val) {
Jeff Hao5ce4b172013-08-16 16:27:18 -0700212 *buf++ = static_cast<uint8_t>(val);
213 *buf++ = static_cast<uint8_t>(val >> 8);
jeffhaoa9ef3fd2011-12-13 18:33:43 -0800214}
215
Elliott Hughesffb465f2012-03-01 18:46:05 -0800216// TODO: put this somewhere with the big-endian equivalent used by JDWP.
217static void Append4LE(uint8_t* buf, uint32_t val) {
Jeff Hao5ce4b172013-08-16 16:27:18 -0700218 *buf++ = static_cast<uint8_t>(val);
219 *buf++ = static_cast<uint8_t>(val >> 8);
220 *buf++ = static_cast<uint8_t>(val >> 16);
221 *buf++ = static_cast<uint8_t>(val >> 24);
jeffhaoa9ef3fd2011-12-13 18:33:43 -0800222}
223
Elliott Hughesffb465f2012-03-01 18:46:05 -0800224// TODO: put this somewhere with the big-endian equivalent used by JDWP.
225static void Append8LE(uint8_t* buf, uint64_t val) {
Jeff Hao5ce4b172013-08-16 16:27:18 -0700226 *buf++ = static_cast<uint8_t>(val);
227 *buf++ = static_cast<uint8_t>(val >> 8);
228 *buf++ = static_cast<uint8_t>(val >> 16);
229 *buf++ = static_cast<uint8_t>(val >> 24);
230 *buf++ = static_cast<uint8_t>(val >> 32);
231 *buf++ = static_cast<uint8_t>(val >> 40);
232 *buf++ = static_cast<uint8_t>(val >> 48);
233 *buf++ = static_cast<uint8_t>(val >> 56);
jeffhaoa9ef3fd2011-12-13 18:33:43 -0800234}
235
Jeff Hao0abc72e2013-08-13 13:45:14 -0700236static void GetSample(Thread* thread, void* arg) SHARED_LOCKS_REQUIRED(Locks::mutator_lock_) {
237 BuildStackTraceVisitor build_trace_visitor(thread);
238 build_trace_visitor.WalkStack();
Ian Rogerse2f77e72013-08-13 19:19:40 -0700239 std::vector<mirror::ArtMethod*>* stack_trace = build_trace_visitor.GetStackTrace();
Jeff Hao0abc72e2013-08-13 13:45:14 -0700240 Trace* the_trace = reinterpret_cast<Trace*>(arg);
241 the_trace->CompareAndUpdateStackTrace(thread, stack_trace);
242}
243
Jeff Hao5ce4b172013-08-16 16:27:18 -0700244static void ClearThreadStackTraceAndClockBase(Thread* thread, void* arg) {
245 thread->SetTraceClockBase(0);
246 std::vector<mirror::ArtMethod*>* stack_trace = thread->GetStackTraceSample();
247 thread->SetStackTraceSample(NULL);
248 delete stack_trace;
249}
250
Jeff Hao0abc72e2013-08-13 13:45:14 -0700251void Trace::CompareAndUpdateStackTrace(Thread* thread,
Ian Rogerse2f77e72013-08-13 19:19:40 -0700252 std::vector<mirror::ArtMethod*>* stack_trace) {
Jeff Hao0abc72e2013-08-13 13:45:14 -0700253 CHECK_EQ(pthread_self(), sampling_pthread_);
Jeff Hao5ce4b172013-08-16 16:27:18 -0700254 std::vector<mirror::ArtMethod*>* old_stack_trace = thread->GetStackTraceSample();
255 // Update the thread's stack trace sample.
256 thread->SetStackTraceSample(stack_trace);
Jeff Haoc1ff4b72013-08-19 11:33:10 -0700257 // Read timer clocks to use for all events in this trace.
258 uint32_t thread_clock_diff = 0;
259 uint32_t wall_clock_diff = 0;
260 ReadClocks(thread, &thread_clock_diff, &wall_clock_diff);
Jeff Hao5ce4b172013-08-16 16:27:18 -0700261 if (old_stack_trace == NULL) {
262 // If there's no previous stack trace sample for this thread, log an entry event for all
Jeff Hao0abc72e2013-08-13 13:45:14 -0700263 // methods in the trace.
Ian Rogerse2f77e72013-08-13 19:19:40 -0700264 for (std::vector<mirror::ArtMethod*>::reverse_iterator rit = stack_trace->rbegin();
Jeff Hao0abc72e2013-08-13 13:45:14 -0700265 rit != stack_trace->rend(); ++rit) {
Jeff Haoc1ff4b72013-08-19 11:33:10 -0700266 LogMethodTraceEvent(thread, *rit, instrumentation::Instrumentation::kMethodEntered,
267 thread_clock_diff, wall_clock_diff);
Jeff Hao0abc72e2013-08-13 13:45:14 -0700268 }
269 } else {
270 // If there's a previous stack trace for this thread, diff the traces and emit entry and exit
271 // events accordingly.
Ian Rogerse2f77e72013-08-13 19:19:40 -0700272 std::vector<mirror::ArtMethod*>::reverse_iterator old_rit = old_stack_trace->rbegin();
273 std::vector<mirror::ArtMethod*>::reverse_iterator rit = stack_trace->rbegin();
Jeff Hao0abc72e2013-08-13 13:45:14 -0700274 // Iterate bottom-up over both traces until there's a difference between them.
275 while (old_rit != old_stack_trace->rend() && rit != stack_trace->rend() && *old_rit == *rit) {
276 old_rit++;
277 rit++;
278 }
279 // Iterate top-down over the old trace until the point where they differ, emitting exit events.
Ian Rogerse2f77e72013-08-13 19:19:40 -0700280 for (std::vector<mirror::ArtMethod*>::iterator old_it = old_stack_trace->begin();
Jeff Hao0abc72e2013-08-13 13:45:14 -0700281 old_it != old_rit.base(); ++old_it) {
Jeff Haoc1ff4b72013-08-19 11:33:10 -0700282 LogMethodTraceEvent(thread, *old_it, instrumentation::Instrumentation::kMethodExited,
283 thread_clock_diff, wall_clock_diff);
Jeff Hao0abc72e2013-08-13 13:45:14 -0700284 }
285 // Iterate bottom-up over the new trace from the point where they differ, emitting entry events.
286 for (; rit != stack_trace->rend(); ++rit) {
Jeff Haoc1ff4b72013-08-19 11:33:10 -0700287 LogMethodTraceEvent(thread, *rit, instrumentation::Instrumentation::kMethodEntered,
288 thread_clock_diff, wall_clock_diff);
Jeff Hao0abc72e2013-08-13 13:45:14 -0700289 }
Jeff Hao5ce4b172013-08-16 16:27:18 -0700290 FreeStackTrace(old_stack_trace);
Jeff Hao0abc72e2013-08-13 13:45:14 -0700291 }
292}
293
294void* Trace::RunSamplingThread(void* arg) {
295 Runtime* runtime = Runtime::Current();
Ian Rogersef7d42f2014-01-06 12:55:46 -0800296 intptr_t interval_us = reinterpret_cast<intptr_t>(arg);
Jeff Hao4044bda2014-01-06 15:50:45 -0800297 CHECK_GE(interval_us, 0);
Jeff Hao0abc72e2013-08-13 13:45:14 -0700298 CHECK(runtime->AttachCurrentThread("Sampling Profiler", true, runtime->GetSystemThreadGroup(),
299 !runtime->IsCompiler()));
300
301 while (true) {
Jeff Hao23009dc2013-08-22 15:36:42 -0700302 usleep(interval_us);
Jeff Hao5ce4b172013-08-16 16:27:18 -0700303 ATRACE_BEGIN("Profile sampling");
Jeff Hao0abc72e2013-08-13 13:45:14 -0700304 Thread* self = Thread::Current();
305 Trace* the_trace;
306 {
307 MutexLock mu(self, *Locks::trace_lock_);
308 the_trace = the_trace_;
309 if (the_trace == NULL) {
310 break;
311 }
312 }
313
314 runtime->GetThreadList()->SuspendAll();
315 {
316 MutexLock mu(self, *Locks::thread_list_lock_);
317 runtime->GetThreadList()->ForEach(GetSample, the_trace);
318 }
319 runtime->GetThreadList()->ResumeAll();
Jeff Hao5ce4b172013-08-16 16:27:18 -0700320 ATRACE_END();
Jeff Hao0abc72e2013-08-13 13:45:14 -0700321 }
322
323 runtime->DetachCurrentThread();
324 return NULL;
325}
326
Ian Rogers62d6c772013-02-27 08:32:07 -0800327void Trace::Start(const char* trace_filename, int trace_fd, int buffer_size, int flags,
Jeff Hao23009dc2013-08-22 15:36:42 -0700328 bool direct_to_ddms, bool sampling_enabled, int interval_us) {
Ian Rogers62d6c772013-02-27 08:32:07 -0800329 Thread* self = Thread::Current();
330 {
331 MutexLock mu(self, *Locks::trace_lock_);
332 if (the_trace_ != NULL) {
333 LOG(ERROR) << "Trace already in progress, ignoring this request";
334 return;
335 }
jeffhaoe343b762011-12-05 16:36:44 -0800336 }
Ian Rogers62d6c772013-02-27 08:32:07 -0800337 Runtime* runtime = Runtime::Current();
338 runtime->GetThreadList()->SuspendAll();
jeffhaoa9ef3fd2011-12-13 18:33:43 -0800339
jeffhao2692b572011-12-16 15:42:28 -0800340 // Open trace file if not going directly to ddms.
Ian Rogers700a4022014-05-19 16:49:03 -0700341 std::unique_ptr<File> trace_file;
jeffhaoa9ef3fd2011-12-13 18:33:43 -0800342 if (!direct_to_ddms) {
343 if (trace_fd < 0) {
Brian Carlstrom7571e8b2013-08-12 17:04:14 -0700344 trace_file.reset(OS::CreateEmptyFile(trace_filename));
jeffhaoa9ef3fd2011-12-13 18:33:43 -0800345 } else {
Ian Rogers62d6c772013-02-27 08:32:07 -0800346 trace_file.reset(new File(trace_fd, "tracefile"));
Elliott Hughes76160052012-12-12 16:31:20 -0800347 trace_file->DisableAutoClose();
jeffhaoa9ef3fd2011-12-13 18:33:43 -0800348 }
Ian Rogers62d6c772013-02-27 08:32:07 -0800349 if (trace_file.get() == NULL) {
jeffhaob5e81852012-03-12 11:15:45 -0700350 PLOG(ERROR) << "Unable to open trace file '" << trace_filename << "'";
Ian Rogers62d6c772013-02-27 08:32:07 -0800351 runtime->GetThreadList()->ResumeAll();
352 ScopedObjectAccess soa(self);
353 ThrowRuntimeException("Unable to open trace file '%s'", trace_filename);
jeffhaoa9ef3fd2011-12-13 18:33:43 -0800354 return;
355 }
356 }
jeffhaoa9ef3fd2011-12-13 18:33:43 -0800357
jeffhao2692b572011-12-16 15:42:28 -0800358 // Create Trace object.
Ian Rogers62d6c772013-02-27 08:32:07 -0800359 {
360 MutexLock mu(self, *Locks::trace_lock_);
Brian Carlstromdf629502013-07-17 22:39:56 -0700361 if (the_trace_ != NULL) {
Ian Rogers62d6c772013-02-27 08:32:07 -0800362 LOG(ERROR) << "Trace already in progress, ignoring this request";
363 } else {
Jeff Hao23009dc2013-08-22 15:36:42 -0700364 the_trace_ = new Trace(trace_file.release(), buffer_size, flags, sampling_enabled);
jeffhao0791adc2012-04-04 11:14:32 -0700365
Ian Rogers62d6c772013-02-27 08:32:07 -0800366 // Enable count of allocs if specified in the flags.
367 if ((flags && kTraceCountAllocs) != 0) {
368 runtime->SetStatsEnabled(true);
369 }
370
Jeff Hao23009dc2013-08-22 15:36:42 -0700371
372
373 if (sampling_enabled) {
374 CHECK_PTHREAD_CALL(pthread_create, (&sampling_pthread_, NULL, &RunSamplingThread,
375 reinterpret_cast<void*>(interval_us)),
376 "Sampling profiler thread");
Jeff Hao0abc72e2013-08-13 13:45:14 -0700377 } else {
378 runtime->GetInstrumentation()->AddListener(the_trace_,
379 instrumentation::Instrumentation::kMethodEntered |
380 instrumentation::Instrumentation::kMethodExited |
381 instrumentation::Instrumentation::kMethodUnwind);
Sebastien Hertz138dbfc2013-12-04 18:15:25 +0100382 runtime->GetInstrumentation()->EnableMethodTracing();
Jeff Hao0abc72e2013-08-13 13:45:14 -0700383 }
Ian Rogers62d6c772013-02-27 08:32:07 -0800384 }
jeffhao0791adc2012-04-04 11:14:32 -0700385 }
Ian Rogers62d6c772013-02-27 08:32:07 -0800386 runtime->GetThreadList()->ResumeAll();
jeffhao2692b572011-12-16 15:42:28 -0800387}
388
389void Trace::Stop() {
Ian Rogers62d6c772013-02-27 08:32:07 -0800390 Runtime* runtime = Runtime::Current();
391 runtime->GetThreadList()->SuspendAll();
392 Trace* the_trace = NULL;
Jeff Hao0abc72e2013-08-13 13:45:14 -0700393 pthread_t sampling_pthread = 0U;
Ian Rogers62d6c772013-02-27 08:32:07 -0800394 {
395 MutexLock mu(Thread::Current(), *Locks::trace_lock_);
396 if (the_trace_ == NULL) {
397 LOG(ERROR) << "Trace stop requested, but no trace currently running";
398 } else {
399 the_trace = the_trace_;
400 the_trace_ = NULL;
Jeff Hao0abc72e2013-08-13 13:45:14 -0700401 sampling_pthread = sampling_pthread_;
402 sampling_pthread_ = 0U;
Ian Rogers62d6c772013-02-27 08:32:07 -0800403 }
jeffhao2692b572011-12-16 15:42:28 -0800404 }
Ian Rogers62d6c772013-02-27 08:32:07 -0800405 if (the_trace != NULL) {
406 the_trace->FinishTracing();
Jeff Hao0abc72e2013-08-13 13:45:14 -0700407
Jeff Hao23009dc2013-08-22 15:36:42 -0700408 if (the_trace->sampling_enabled_) {
Jeff Hao5ce4b172013-08-16 16:27:18 -0700409 MutexLock mu(Thread::Current(), *Locks::thread_list_lock_);
410 runtime->GetThreadList()->ForEach(ClearThreadStackTraceAndClockBase, NULL);
411 } else {
Sebastien Hertz138dbfc2013-12-04 18:15:25 +0100412 runtime->GetInstrumentation()->DisableMethodTracing();
Jeff Hao0abc72e2013-08-13 13:45:14 -0700413 runtime->GetInstrumentation()->RemoveListener(the_trace,
414 instrumentation::Instrumentation::kMethodEntered |
415 instrumentation::Instrumentation::kMethodExited |
416 instrumentation::Instrumentation::kMethodUnwind);
417 }
Ian Rogers62d6c772013-02-27 08:32:07 -0800418 delete the_trace;
419 }
420 runtime->GetThreadList()->ResumeAll();
Jeff Hao0abc72e2013-08-13 13:45:14 -0700421
Jeff Hao23009dc2013-08-22 15:36:42 -0700422 if (sampling_pthread != 0U) {
Jeff Hao0abc72e2013-08-13 13:45:14 -0700423 CHECK_PTHREAD_CALL(pthread_join, (sampling_pthread, NULL), "sampling thread shutdown");
424 }
jeffhao2692b572011-12-16 15:42:28 -0800425}
426
jeffhaob5e81852012-03-12 11:15:45 -0700427void Trace::Shutdown() {
Jeff Hao64caa7d2013-08-29 11:18:01 -0700428 if (GetMethodTracingMode() != kTracingInactive) {
Ian Rogers62d6c772013-02-27 08:32:07 -0800429 Stop();
jeffhaob5e81852012-03-12 11:15:45 -0700430 }
jeffhaob5e81852012-03-12 11:15:45 -0700431}
432
Jeff Hao64caa7d2013-08-29 11:18:01 -0700433TracingMode Trace::GetMethodTracingMode() {
Ian Rogers62d6c772013-02-27 08:32:07 -0800434 MutexLock mu(Thread::Current(), *Locks::trace_lock_);
Jeff Hao64caa7d2013-08-29 11:18:01 -0700435 if (the_trace_ == NULL) {
436 return kTracingInactive;
437 } else if (the_trace_->sampling_enabled_) {
438 return kSampleProfilingActive;
439 } else {
440 return kMethodTracingActive;
441 }
Ian Rogers62d6c772013-02-27 08:32:07 -0800442}
jeffhaoa9ef3fd2011-12-13 18:33:43 -0800443
Jeff Hao23009dc2013-08-22 15:36:42 -0700444Trace::Trace(File* trace_file, int buffer_size, int flags, bool sampling_enabled)
Ian Rogers62d6c772013-02-27 08:32:07 -0800445 : trace_file_(trace_file), buf_(new uint8_t[buffer_size]()), flags_(flags),
Jeff Hao23009dc2013-08-22 15:36:42 -0700446 sampling_enabled_(sampling_enabled), clock_source_(default_clock_source_),
Jeff Haoc5d824a2014-07-28 18:35:38 -0700447 buffer_size_(buffer_size), start_time_(MicroTime()),
448 clock_overhead_ns_(GetClockOverheadNanoSeconds()), cur_offset_(0), overflow_(false) {
jeffhaoa9ef3fd2011-12-13 18:33:43 -0800449 // Set up the beginning of the trace.
Ian Rogers62d6c772013-02-27 08:32:07 -0800450 uint16_t trace_version = GetTraceVersion(clock_source_);
jeffhao2692b572011-12-16 15:42:28 -0800451 memset(buf_.get(), 0, kTraceHeaderLength);
452 Append4LE(buf_.get(), kTraceMagicValue);
Ian Rogers62d6c772013-02-27 08:32:07 -0800453 Append2LE(buf_.get() + 4, trace_version);
jeffhao2692b572011-12-16 15:42:28 -0800454 Append2LE(buf_.get() + 6, kTraceHeaderLength);
455 Append8LE(buf_.get() + 8, start_time_);
Ian Rogers62d6c772013-02-27 08:32:07 -0800456 if (trace_version >= kTraceVersionDualClock) {
457 uint16_t record_size = GetRecordSize(clock_source_);
458 Append2LE(buf_.get() + 16, record_size);
jeffhaoa9ef3fd2011-12-13 18:33:43 -0800459 }
jeffhaoa9ef3fd2011-12-13 18:33:43 -0800460
jeffhao2692b572011-12-16 15:42:28 -0800461 // Update current offset.
Ian Rogers8ab25ef2014-07-09 18:00:50 -0700462 cur_offset_.StoreRelaxed(kTraceHeaderLength);
Ian Rogers62d6c772013-02-27 08:32:07 -0800463}
jeffhaoa9ef3fd2011-12-13 18:33:43 -0800464
Ian Rogerse63db272014-07-15 15:36:11 -0700465static void DumpBuf(uint8_t* buf, size_t buf_size, TraceClockSource clock_source)
Ian Rogers62d6c772013-02-27 08:32:07 -0800466 SHARED_LOCKS_REQUIRED(Locks::mutator_lock_) {
467 uint8_t* ptr = buf + kTraceHeaderLength;
468 uint8_t* end = buf + buf_size;
469
470 while (ptr < end) {
471 uint32_t tmid = ptr[2] | (ptr[3] << 8) | (ptr[4] << 16) | (ptr[5] << 24);
Brian Carlstromea46f952013-07-30 01:26:50 -0700472 mirror::ArtMethod* method = DecodeTraceMethodId(tmid);
Ian Rogers62d6c772013-02-27 08:32:07 -0800473 TraceAction action = DecodeTraceAction(tmid);
474 LOG(INFO) << PrettyMethod(method) << " " << static_cast<int>(action);
475 ptr += GetRecordSize(clock_source);
476 }
jeffhaoe343b762011-12-05 16:36:44 -0800477}
478
jeffhao2692b572011-12-16 15:42:28 -0800479void Trace::FinishTracing() {
jeffhaoa9ef3fd2011-12-13 18:33:43 -0800480 // Compute elapsed time.
481 uint64_t elapsed = MicroTime() - start_time_;
482
Ian Rogers8ab25ef2014-07-09 18:00:50 -0700483 size_t final_offset = cur_offset_.LoadRelaxed();
jeffhaoa9ef3fd2011-12-13 18:33:43 -0800484
jeffhao0791adc2012-04-04 11:14:32 -0700485 if ((flags_ & kTraceCountAllocs) != 0) {
486 Runtime::Current()->SetStatsEnabled(false);
487 }
488
Brian Carlstromea46f952013-07-30 01:26:50 -0700489 std::set<mirror::ArtMethod*> visited_methods;
Ian Rogers62d6c772013-02-27 08:32:07 -0800490 GetVisitedMethods(final_offset, &visited_methods);
jeffhaoa9ef3fd2011-12-13 18:33:43 -0800491
492 std::ostringstream os;
493
494 os << StringPrintf("%cversion\n", kTraceTokenChar);
Ian Rogers62d6c772013-02-27 08:32:07 -0800495 os << StringPrintf("%d\n", GetTraceVersion(clock_source_));
jeffhaoa9ef3fd2011-12-13 18:33:43 -0800496 os << StringPrintf("data-file-overflow=%s\n", overflow_ ? "true" : "false");
497 if (UseThreadCpuClock()) {
498 if (UseWallClock()) {
499 os << StringPrintf("clock=dual\n");
500 } else {
501 os << StringPrintf("clock=thread-cpu\n");
502 }
503 } else {
504 os << StringPrintf("clock=wall\n");
505 }
Ian Rogersef7d42f2014-01-06 12:55:46 -0800506 os << StringPrintf("elapsed-time-usec=%" PRIu64 "\n", elapsed);
Ian Rogers62d6c772013-02-27 08:32:07 -0800507 size_t num_records = (final_offset - kTraceHeaderLength) / GetRecordSize(clock_source_);
508 os << StringPrintf("num-method-calls=%zd\n", num_records);
Jeff Haoc5d824a2014-07-28 18:35:38 -0700509 os << StringPrintf("clock-call-overhead-nsec=%d\n", clock_overhead_ns_);
jeffhaoa9ef3fd2011-12-13 18:33:43 -0800510 os << StringPrintf("vm=art\n");
jeffhao0791adc2012-04-04 11:14:32 -0700511 if ((flags_ & kTraceCountAllocs) != 0) {
512 os << StringPrintf("alloc-count=%d\n", Runtime::Current()->GetStat(KIND_ALLOCATED_OBJECTS));
513 os << StringPrintf("alloc-size=%d\n", Runtime::Current()->GetStat(KIND_ALLOCATED_BYTES));
514 os << StringPrintf("gc-count=%d\n", Runtime::Current()->GetStat(KIND_GC_INVOCATIONS));
515 }
jeffhaoa9ef3fd2011-12-13 18:33:43 -0800516 os << StringPrintf("%cthreads\n", kTraceTokenChar);
517 DumpThreadList(os);
518 os << StringPrintf("%cmethods\n", kTraceTokenChar);
Ian Rogers62d6c772013-02-27 08:32:07 -0800519 DumpMethodList(os, visited_methods);
jeffhaoa9ef3fd2011-12-13 18:33:43 -0800520 os << StringPrintf("%cend\n", kTraceTokenChar);
521
522 std::string header(os.str());
jeffhao2692b572011-12-16 15:42:28 -0800523 if (trace_file_.get() == NULL) {
Elliott Hughes7b9d9962012-04-20 18:48:18 -0700524 iovec iov[2];
jeffhaoa9ef3fd2011-12-13 18:33:43 -0800525 iov[0].iov_base = reinterpret_cast<void*>(const_cast<char*>(header.c_str()));
526 iov[0].iov_len = header.length();
jeffhao2692b572011-12-16 15:42:28 -0800527 iov[1].iov_base = buf_.get();
jeffhaoa9ef3fd2011-12-13 18:33:43 -0800528 iov[1].iov_len = final_offset;
529 Dbg::DdmSendChunkV(CHUNK_TYPE("MPSE"), iov, 2);
Ian Rogers62d6c772013-02-27 08:32:07 -0800530 const bool kDumpTraceInfo = false;
531 if (kDumpTraceInfo) {
532 LOG(INFO) << "Trace sent:\n" << header;
533 DumpBuf(buf_.get(), final_offset, clock_source_);
534 }
jeffhaoa9ef3fd2011-12-13 18:33:43 -0800535 } else {
536 if (!trace_file_->WriteFully(header.c_str(), header.length()) ||
jeffhao2692b572011-12-16 15:42:28 -0800537 !trace_file_->WriteFully(buf_.get(), final_offset)) {
Elliott Hughes7b9d9962012-04-20 18:48:18 -0700538 std::string detail(StringPrintf("Trace data write failed: %s", strerror(errno)));
539 PLOG(ERROR) << detail;
Ian Rogers62d6c772013-02-27 08:32:07 -0800540 ThrowRuntimeException("%s", detail.c_str());
jeffhaoa9ef3fd2011-12-13 18:33:43 -0800541 }
jeffhaoa9ef3fd2011-12-13 18:33:43 -0800542 }
jeffhaoa9ef3fd2011-12-13 18:33:43 -0800543}
544
Ian Rogers62d6c772013-02-27 08:32:07 -0800545void Trace::DexPcMoved(Thread* thread, mirror::Object* this_object,
Ian Rogersef7d42f2014-01-06 12:55:46 -0800546 mirror::ArtMethod* method, uint32_t new_dex_pc) {
Ian Rogers62d6c772013-02-27 08:32:07 -0800547 // We're not recorded to listen to this kind of event, so complain.
548 LOG(ERROR) << "Unexpected dex PC event in tracing " << PrettyMethod(method) << " " << new_dex_pc;
549};
jeffhaoa9ef3fd2011-12-13 18:33:43 -0800550
Sebastien Hertz3f52eaf2014-04-04 17:50:18 +0200551void Trace::FieldRead(Thread* /*thread*/, mirror::Object* this_object,
552 mirror::ArtMethod* method, uint32_t dex_pc, mirror::ArtField* field)
553 SHARED_LOCKS_REQUIRED(Locks::mutator_lock_) {
554 // We're not recorded to listen to this kind of event, so complain.
555 LOG(ERROR) << "Unexpected field read event in tracing " << PrettyMethod(method) << " " << dex_pc;
556}
557
558void Trace::FieldWritten(Thread* /*thread*/, mirror::Object* this_object,
559 mirror::ArtMethod* method, uint32_t dex_pc, mirror::ArtField* field,
560 const JValue& field_value)
561 SHARED_LOCKS_REQUIRED(Locks::mutator_lock_) {
562 // We're not recorded to listen to this kind of event, so complain.
563 LOG(ERROR) << "Unexpected field write event in tracing " << PrettyMethod(method) << " " << dex_pc;
564}
565
Ian Rogers62d6c772013-02-27 08:32:07 -0800566void Trace::MethodEntered(Thread* thread, mirror::Object* this_object,
Ian Rogersef7d42f2014-01-06 12:55:46 -0800567 mirror::ArtMethod* method, uint32_t dex_pc) {
Jeff Haoc1ff4b72013-08-19 11:33:10 -0700568 uint32_t thread_clock_diff = 0;
569 uint32_t wall_clock_diff = 0;
570 ReadClocks(thread, &thread_clock_diff, &wall_clock_diff);
571 LogMethodTraceEvent(thread, method, instrumentation::Instrumentation::kMethodEntered,
572 thread_clock_diff, wall_clock_diff);
Ian Rogers62d6c772013-02-27 08:32:07 -0800573}
574
575void Trace::MethodExited(Thread* thread, mirror::Object* this_object,
Ian Rogersef7d42f2014-01-06 12:55:46 -0800576 mirror::ArtMethod* method, uint32_t dex_pc,
Ian Rogers62d6c772013-02-27 08:32:07 -0800577 const JValue& return_value) {
578 UNUSED(return_value);
Jeff Haoc1ff4b72013-08-19 11:33:10 -0700579 uint32_t thread_clock_diff = 0;
580 uint32_t wall_clock_diff = 0;
581 ReadClocks(thread, &thread_clock_diff, &wall_clock_diff);
582 LogMethodTraceEvent(thread, method, instrumentation::Instrumentation::kMethodExited,
583 thread_clock_diff, wall_clock_diff);
Ian Rogers62d6c772013-02-27 08:32:07 -0800584}
585
Sebastien Hertz51db44a2013-11-19 10:00:29 +0100586void Trace::MethodUnwind(Thread* thread, mirror::Object* this_object,
Ian Rogersef7d42f2014-01-06 12:55:46 -0800587 mirror::ArtMethod* method, uint32_t dex_pc) {
Jeff Haoc1ff4b72013-08-19 11:33:10 -0700588 uint32_t thread_clock_diff = 0;
589 uint32_t wall_clock_diff = 0;
590 ReadClocks(thread, &thread_clock_diff, &wall_clock_diff);
591 LogMethodTraceEvent(thread, method, instrumentation::Instrumentation::kMethodUnwind,
592 thread_clock_diff, wall_clock_diff);
Ian Rogers62d6c772013-02-27 08:32:07 -0800593}
594
595void Trace::ExceptionCaught(Thread* thread, const ThrowLocation& throw_location,
Brian Carlstromea46f952013-07-30 01:26:50 -0700596 mirror::ArtMethod* catch_method, uint32_t catch_dex_pc,
Ian Rogers62d6c772013-02-27 08:32:07 -0800597 mirror::Throwable* exception_object)
598 SHARED_LOCKS_REQUIRED(Locks::mutator_lock_) {
599 LOG(ERROR) << "Unexpected exception caught event in tracing";
600}
601
Jeff Haoc1ff4b72013-08-19 11:33:10 -0700602void Trace::ReadClocks(Thread* thread, uint32_t* thread_clock_diff, uint32_t* wall_clock_diff) {
603 if (UseThreadCpuClock()) {
604 uint64_t clock_base = thread->GetTraceClockBase();
605 if (UNLIKELY(clock_base == 0)) {
606 // First event, record the base time in the map.
607 uint64_t time = thread->GetCpuMicroTime();
608 thread->SetTraceClockBase(time);
609 } else {
610 *thread_clock_diff = thread->GetCpuMicroTime() - clock_base;
611 }
612 }
613 if (UseWallClock()) {
614 *wall_clock_diff = MicroTime() - start_time_;
615 }
616}
617
Ian Rogersef7d42f2014-01-06 12:55:46 -0800618void Trace::LogMethodTraceEvent(Thread* thread, mirror::ArtMethod* method,
Jeff Haoc1ff4b72013-08-19 11:33:10 -0700619 instrumentation::Instrumentation::InstrumentationEvent event,
620 uint32_t thread_clock_diff, uint32_t wall_clock_diff) {
jeffhaoa9ef3fd2011-12-13 18:33:43 -0800621 // Advance cur_offset_ atomically.
622 int32_t new_offset;
623 int32_t old_offset;
624 do {
Ian Rogers8ab25ef2014-07-09 18:00:50 -0700625 old_offset = cur_offset_.LoadRelaxed();
Ian Rogers62d6c772013-02-27 08:32:07 -0800626 new_offset = old_offset + GetRecordSize(clock_source_);
jeffhaoa9ef3fd2011-12-13 18:33:43 -0800627 if (new_offset > buffer_size_) {
628 overflow_ = true;
629 return;
630 }
Ian Rogers54fb8fd2014-07-09 23:16:06 -0700631 } while (!cur_offset_.CompareExchangeWeakSequentiallyConsistent(old_offset, new_offset));
jeffhaoa9ef3fd2011-12-13 18:33:43 -0800632
Ian Rogers62d6c772013-02-27 08:32:07 -0800633 TraceAction action = kTraceMethodEnter;
634 switch (event) {
635 case instrumentation::Instrumentation::kMethodEntered:
636 action = kTraceMethodEnter;
637 break;
638 case instrumentation::Instrumentation::kMethodExited:
639 action = kTraceMethodExit;
640 break;
641 case instrumentation::Instrumentation::kMethodUnwind:
642 action = kTraceUnroll;
643 break;
644 default:
645 UNIMPLEMENTED(FATAL) << "Unexpected event: " << event;
646 }
647
648 uint32_t method_value = EncodeTraceMethodAndAction(method, action);
jeffhaoa9ef3fd2011-12-13 18:33:43 -0800649
650 // Write data
jeffhao2692b572011-12-16 15:42:28 -0800651 uint8_t* ptr = buf_.get() + old_offset;
Ian Rogers62d6c772013-02-27 08:32:07 -0800652 Append2LE(ptr, thread->GetTid());
jeffhaoa9ef3fd2011-12-13 18:33:43 -0800653 Append4LE(ptr + 2, method_value);
654 ptr += 6;
655
656 if (UseThreadCpuClock()) {
jeffhaoa9ef3fd2011-12-13 18:33:43 -0800657 Append4LE(ptr, thread_clock_diff);
658 ptr += 4;
659 }
jeffhaoa9ef3fd2011-12-13 18:33:43 -0800660 if (UseWallClock()) {
jeffhaoa9ef3fd2011-12-13 18:33:43 -0800661 Append4LE(ptr, wall_clock_diff);
662 }
663}
664
Ian Rogers62d6c772013-02-27 08:32:07 -0800665void Trace::GetVisitedMethods(size_t buf_size,
Brian Carlstromea46f952013-07-30 01:26:50 -0700666 std::set<mirror::ArtMethod*>* visited_methods) {
jeffhao2692b572011-12-16 15:42:28 -0800667 uint8_t* ptr = buf_.get() + kTraceHeaderLength;
Ian Rogers62d6c772013-02-27 08:32:07 -0800668 uint8_t* end = buf_.get() + buf_size;
jeffhaoa9ef3fd2011-12-13 18:33:43 -0800669
670 while (ptr < end) {
Ian Rogers62d6c772013-02-27 08:32:07 -0800671 uint32_t tmid = ptr[2] | (ptr[3] << 8) | (ptr[4] << 16) | (ptr[5] << 24);
Brian Carlstromea46f952013-07-30 01:26:50 -0700672 mirror::ArtMethod* method = DecodeTraceMethodId(tmid);
Ian Rogers62d6c772013-02-27 08:32:07 -0800673 visited_methods->insert(method);
674 ptr += GetRecordSize(clock_source_);
jeffhaoa9ef3fd2011-12-13 18:33:43 -0800675 }
676}
677
Mathieu Chartier02e25112013-08-14 16:14:24 -0700678void Trace::DumpMethodList(std::ostream& os, const std::set<mirror::ArtMethod*>& visited_methods) {
Mathieu Chartier02e25112013-08-14 16:14:24 -0700679 for (const auto& method : visited_methods) {
Ian Rogers0399dde2012-06-06 17:09:28 -0700680 os << StringPrintf("%p\t%s\t%s\t%s\t%s\n", method,
Mathieu Chartierbfd9a432014-05-21 17:43:44 -0700681 PrettyDescriptor(method->GetDeclaringClassDescriptor()).c_str(), method->GetName(),
682 method->GetSignature().ToString().c_str(), method->GetDeclaringClassSourceFile());
jeffhaoa9ef3fd2011-12-13 18:33:43 -0800683 }
jeffhaoa9ef3fd2011-12-13 18:33:43 -0800684}
685
686static void DumpThread(Thread* t, void* arg) {
Elliott Hughesffb465f2012-03-01 18:46:05 -0800687 std::ostream& os = *reinterpret_cast<std::ostream*>(arg);
688 std::string name;
689 t->GetThreadName(name);
690 os << t->GetTid() << "\t" << name << "\n";
jeffhaoa9ef3fd2011-12-13 18:33:43 -0800691}
692
693void Trace::DumpThreadList(std::ostream& os) {
Ian Rogers81d425b2012-09-27 16:03:43 -0700694 Thread* self = Thread::Current();
695 Locks::thread_list_lock_->AssertNotHeld(self);
696 MutexLock mu(self, *Locks::thread_list_lock_);
jeffhaoa9ef3fd2011-12-13 18:33:43 -0800697 Runtime::Current()->GetThreadList()->ForEach(DumpThread, &os);
jeffhaoe343b762011-12-05 16:36:44 -0800698}
699
jeffhaoe343b762011-12-05 16:36:44 -0800700} // namespace art