Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (C) 2014 The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
| 17 | #include "inliner.h" |
| 18 | |
Mathieu Chartier | e401d14 | 2015-04-22 13:56:20 -0700 | [diff] [blame] | 19 | #include "art_method-inl.h" |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 20 | #include "builder.h" |
| 21 | #include "class_linker.h" |
| 22 | #include "constant_folding.h" |
| 23 | #include "dead_code_elimination.h" |
| 24 | #include "driver/compiler_driver-inl.h" |
Calin Juravle | ec74835 | 2015-07-29 13:52:12 +0100 | [diff] [blame] | 25 | #include "driver/compiler_options.h" |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 26 | #include "driver/dex_compilation_unit.h" |
| 27 | #include "instruction_simplifier.h" |
Scott Wakeling | d60a1af | 2015-07-22 14:32:44 +0100 | [diff] [blame] | 28 | #include "intrinsics.h" |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 29 | #include "mirror/class_loader.h" |
| 30 | #include "mirror/dex_cache.h" |
| 31 | #include "nodes.h" |
Nicolas Geoffray | 335005e | 2015-06-25 10:01:47 +0100 | [diff] [blame] | 32 | #include "optimizing_compiler.h" |
Nicolas Geoffray | 454a481 | 2015-06-09 10:37:32 +0100 | [diff] [blame] | 33 | #include "reference_type_propagation.h" |
Nicolas Geoffray | 259136f | 2014-12-17 23:21:58 +0000 | [diff] [blame] | 34 | #include "register_allocator.h" |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 35 | #include "ssa_phi_elimination.h" |
| 36 | #include "scoped_thread_state_change.h" |
| 37 | #include "thread.h" |
Calin Juravle | f1c6d9e | 2015-04-13 18:42:21 +0100 | [diff] [blame] | 38 | #include "dex/verified_method.h" |
| 39 | #include "dex/verification_results.h" |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 40 | |
| 41 | namespace art { |
| 42 | |
Nicolas Geoffray | e418dda | 2015-08-11 20:03:09 -0700 | [diff] [blame] | 43 | static constexpr size_t kMaximumNumberOfHInstructions = 12; |
| 44 | |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 45 | void HInliner::Run() { |
Calin Juravle | 8f96df8 | 2015-07-29 15:58:48 +0100 | [diff] [blame] | 46 | const CompilerOptions& compiler_options = compiler_driver_->GetCompilerOptions(); |
| 47 | if ((compiler_options.GetInlineDepthLimit() == 0) |
| 48 | || (compiler_options.GetInlineMaxCodeUnits() == 0)) { |
| 49 | return; |
| 50 | } |
Nicolas Geoffray | e50b8d2 | 2015-03-13 08:57:42 +0000 | [diff] [blame] | 51 | if (graph_->IsDebuggable()) { |
| 52 | // For simplicity, we currently never inline when the graph is debuggable. This avoids |
| 53 | // doing some logic in the runtime to discover if a method could have been inlined. |
| 54 | return; |
| 55 | } |
Vladimir Marko | fa6b93c | 2015-09-15 10:15:55 +0100 | [diff] [blame] | 56 | const ArenaVector<HBasicBlock*>& blocks = graph_->GetReversePostOrder(); |
| 57 | DCHECK(!blocks.empty()); |
| 58 | HBasicBlock* next_block = blocks[0]; |
| 59 | for (size_t i = 0; i < blocks.size(); ++i) { |
Nicolas Geoffray | d23eeef | 2015-05-18 22:31:29 +0100 | [diff] [blame] | 60 | // Because we are changing the graph when inlining, we need to remember the next block. |
| 61 | // This avoids doing the inlining work again on the inlined blocks. |
Vladimir Marko | fa6b93c | 2015-09-15 10:15:55 +0100 | [diff] [blame] | 62 | if (blocks[i] != next_block) { |
Nicolas Geoffray | d23eeef | 2015-05-18 22:31:29 +0100 | [diff] [blame] | 63 | continue; |
| 64 | } |
| 65 | HBasicBlock* block = next_block; |
Vladimir Marko | fa6b93c | 2015-09-15 10:15:55 +0100 | [diff] [blame] | 66 | next_block = (i == blocks.size() - 1) ? nullptr : blocks[i + 1]; |
Nicolas Geoffray | ef87c5d | 2015-01-30 12:41:14 +0000 | [diff] [blame] | 67 | for (HInstruction* instruction = block->GetFirstInstruction(); instruction != nullptr;) { |
| 68 | HInstruction* next = instruction->GetNext(); |
Nicolas Geoffray | 454a481 | 2015-06-09 10:37:32 +0100 | [diff] [blame] | 69 | HInvoke* call = instruction->AsInvoke(); |
Razvan A Lupusoru | 3e90a96 | 2015-03-27 13:44:44 -0700 | [diff] [blame] | 70 | // As long as the call is not intrinsified, it is worth trying to inline. |
| 71 | if (call != nullptr && call->GetIntrinsic() == Intrinsics::kNone) { |
Nicolas Geoffray | 7904129 | 2015-03-26 10:05:54 +0000 | [diff] [blame] | 72 | // We use the original invoke type to ensure the resolution of the called method |
| 73 | // works properly. |
Vladimir Marko | 5815501 | 2015-08-19 12:49:41 +0000 | [diff] [blame] | 74 | if (!TryInline(call)) { |
Nicolas Geoffray | 335005e | 2015-06-25 10:01:47 +0100 | [diff] [blame] | 75 | if (kIsDebugBuild && IsCompilingWithCoreImage()) { |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 76 | std::string callee_name = |
Nicolas Geoffray | ef87c5d | 2015-01-30 12:41:14 +0000 | [diff] [blame] | 77 | PrettyMethod(call->GetDexMethodIndex(), *outer_compilation_unit_.GetDexFile()); |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 78 | bool should_inline = callee_name.find("$inline$") != std::string::npos; |
| 79 | CHECK(!should_inline) << "Could not inline " << callee_name; |
| 80 | } |
Guillaume "Vermeille" Sanchez | e918d38 | 2015-06-03 15:32:41 +0100 | [diff] [blame] | 81 | } else { |
Nicolas Geoffray | 335005e | 2015-06-25 10:01:47 +0100 | [diff] [blame] | 82 | if (kIsDebugBuild && IsCompilingWithCoreImage()) { |
Guillaume "Vermeille" Sanchez | e918d38 | 2015-06-03 15:32:41 +0100 | [diff] [blame] | 83 | std::string callee_name = |
| 84 | PrettyMethod(call->GetDexMethodIndex(), *outer_compilation_unit_.GetDexFile()); |
| 85 | bool must_not_inline = callee_name.find("$noinline$") != std::string::npos; |
| 86 | CHECK(!must_not_inline) << "Should not have inlined " << callee_name; |
| 87 | } |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 88 | } |
| 89 | } |
Nicolas Geoffray | ef87c5d | 2015-01-30 12:41:14 +0000 | [diff] [blame] | 90 | instruction = next; |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 91 | } |
| 92 | } |
| 93 | } |
| 94 | |
Nicolas Geoffray | 454a481 | 2015-06-09 10:37:32 +0100 | [diff] [blame] | 95 | static bool IsMethodOrDeclaringClassFinal(ArtMethod* method) |
Mathieu Chartier | 9044347 | 2015-07-16 20:32:27 -0700 | [diff] [blame] | 96 | SHARED_REQUIRES(Locks::mutator_lock_) { |
Nicolas Geoffray | 454a481 | 2015-06-09 10:37:32 +0100 | [diff] [blame] | 97 | return method->IsFinal() || method->GetDeclaringClass()->IsFinal(); |
| 98 | } |
| 99 | |
| 100 | /** |
| 101 | * Given the `resolved_method` looked up in the dex cache, try to find |
| 102 | * the actual runtime target of an interface or virtual call. |
| 103 | * Return nullptr if the runtime target cannot be proven. |
| 104 | */ |
| 105 | static ArtMethod* FindVirtualOrInterfaceTarget(HInvoke* invoke, ArtMethod* resolved_method) |
Mathieu Chartier | 9044347 | 2015-07-16 20:32:27 -0700 | [diff] [blame] | 106 | SHARED_REQUIRES(Locks::mutator_lock_) { |
Nicolas Geoffray | 454a481 | 2015-06-09 10:37:32 +0100 | [diff] [blame] | 107 | if (IsMethodOrDeclaringClassFinal(resolved_method)) { |
| 108 | // No need to lookup further, the resolved method will be the target. |
| 109 | return resolved_method; |
| 110 | } |
| 111 | |
| 112 | HInstruction* receiver = invoke->InputAt(0); |
| 113 | if (receiver->IsNullCheck()) { |
| 114 | // Due to multiple levels of inlining within the same pass, it might be that |
| 115 | // null check does not have the reference type of the actual receiver. |
| 116 | receiver = receiver->InputAt(0); |
| 117 | } |
| 118 | ReferenceTypeInfo info = receiver->GetReferenceTypeInfo(); |
Calin Juravle | 2e76830 | 2015-07-28 14:41:11 +0000 | [diff] [blame] | 119 | DCHECK(info.IsValid()) << "Invalid RTI for " << receiver->DebugName(); |
| 120 | if (!info.IsExact()) { |
Nicolas Geoffray | 454a481 | 2015-06-09 10:37:32 +0100 | [diff] [blame] | 121 | // We currently only support inlining with known receivers. |
| 122 | // TODO: Remove this check, we should be able to inline final methods |
| 123 | // on unknown receivers. |
| 124 | return nullptr; |
| 125 | } else if (info.GetTypeHandle()->IsInterface()) { |
| 126 | // Statically knowing that the receiver has an interface type cannot |
| 127 | // help us find what is the target method. |
| 128 | return nullptr; |
| 129 | } else if (!resolved_method->GetDeclaringClass()->IsAssignableFrom(info.GetTypeHandle().Get())) { |
| 130 | // The method that we're trying to call is not in the receiver's class or super classes. |
| 131 | return nullptr; |
| 132 | } |
| 133 | |
| 134 | ClassLinker* cl = Runtime::Current()->GetClassLinker(); |
| 135 | size_t pointer_size = cl->GetImagePointerSize(); |
| 136 | if (invoke->IsInvokeInterface()) { |
| 137 | resolved_method = info.GetTypeHandle()->FindVirtualMethodForInterface( |
| 138 | resolved_method, pointer_size); |
| 139 | } else { |
| 140 | DCHECK(invoke->IsInvokeVirtual()); |
| 141 | resolved_method = info.GetTypeHandle()->FindVirtualMethodForVirtual( |
| 142 | resolved_method, pointer_size); |
| 143 | } |
| 144 | |
| 145 | if (resolved_method == nullptr) { |
| 146 | // The information we had on the receiver was not enough to find |
| 147 | // the target method. Since we check above the exact type of the receiver, |
| 148 | // the only reason this can happen is an IncompatibleClassChangeError. |
| 149 | return nullptr; |
| 150 | } else if (resolved_method->IsAbstract()) { |
| 151 | // The information we had on the receiver was not enough to find |
| 152 | // the target method. Since we check above the exact type of the receiver, |
| 153 | // the only reason this can happen is an IncompatibleClassChangeError. |
| 154 | return nullptr; |
| 155 | } else if (IsMethodOrDeclaringClassFinal(resolved_method)) { |
| 156 | // A final method has to be the target method. |
| 157 | return resolved_method; |
| 158 | } else if (info.IsExact()) { |
| 159 | // If we found a method and the receiver's concrete type is statically |
| 160 | // known, we know for sure the target. |
| 161 | return resolved_method; |
| 162 | } else { |
| 163 | // Even if we did find a method, the receiver type was not enough to |
| 164 | // statically find the runtime target. |
| 165 | return nullptr; |
| 166 | } |
| 167 | } |
| 168 | |
| 169 | static uint32_t FindMethodIndexIn(ArtMethod* method, |
| 170 | const DexFile& dex_file, |
| 171 | uint32_t referrer_index) |
Mathieu Chartier | 9044347 | 2015-07-16 20:32:27 -0700 | [diff] [blame] | 172 | SHARED_REQUIRES(Locks::mutator_lock_) { |
Nicolas Geoffray | 454a481 | 2015-06-09 10:37:32 +0100 | [diff] [blame] | 173 | if (method->GetDexFile()->GetLocation().compare(dex_file.GetLocation()) == 0) { |
| 174 | return method->GetDexMethodIndex(); |
| 175 | } else { |
| 176 | return method->FindDexMethodIndexInOtherDexFile(dex_file, referrer_index); |
| 177 | } |
| 178 | } |
| 179 | |
Nicolas Geoffray | e418dda | 2015-08-11 20:03:09 -0700 | [diff] [blame] | 180 | bool HInliner::TryInline(HInvoke* invoke_instruction) { |
Calin Juravle | 175dc73 | 2015-08-25 15:42:32 +0100 | [diff] [blame] | 181 | if (invoke_instruction->IsInvokeUnresolved()) { |
| 182 | return false; // Don't bother to move further if we know the method is unresolved. |
| 183 | } |
| 184 | |
Vladimir Marko | 5815501 | 2015-08-19 12:49:41 +0000 | [diff] [blame] | 185 | uint32_t method_index = invoke_instruction->GetDexMethodIndex(); |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 186 | ScopedObjectAccess soa(Thread::Current()); |
Nicolas Geoffray | 9437b78 | 2015-03-25 10:08:51 +0000 | [diff] [blame] | 187 | const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile(); |
| 188 | VLOG(compiler) << "Try inlining " << PrettyMethod(method_index, caller_dex_file); |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 189 | |
Nicolas Geoffray | 3507105 | 2015-06-09 15:43:38 +0100 | [diff] [blame] | 190 | ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker(); |
| 191 | // We can query the dex cache directly. The verifier has populated it already. |
Vladimir Marko | 5815501 | 2015-08-19 12:49:41 +0000 | [diff] [blame] | 192 | ArtMethod* resolved_method; |
| 193 | if (invoke_instruction->IsInvokeStaticOrDirect()) { |
| 194 | MethodReference ref = invoke_instruction->AsInvokeStaticOrDirect()->GetTargetMethod(); |
Mathieu Chartier | 736b560 | 2015-09-02 14:54:11 -0700 | [diff] [blame] | 195 | mirror::DexCache* const dex_cache = (&caller_dex_file == ref.dex_file) |
| 196 | ? caller_compilation_unit_.GetDexCache().Get() |
| 197 | : class_linker->FindDexCache(soa.Self(), *ref.dex_file); |
| 198 | resolved_method = dex_cache->GetResolvedMethod( |
Vladimir Marko | 5815501 | 2015-08-19 12:49:41 +0000 | [diff] [blame] | 199 | ref.dex_method_index, class_linker->GetImagePointerSize()); |
| 200 | } else { |
Mathieu Chartier | 736b560 | 2015-09-02 14:54:11 -0700 | [diff] [blame] | 201 | resolved_method = caller_compilation_unit_.GetDexCache().Get()->GetResolvedMethod( |
Vladimir Marko | 5815501 | 2015-08-19 12:49:41 +0000 | [diff] [blame] | 202 | method_index, class_linker->GetImagePointerSize()); |
| 203 | } |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 204 | |
Mathieu Chartier | e401d14 | 2015-04-22 13:56:20 -0700 | [diff] [blame] | 205 | if (resolved_method == nullptr) { |
Calin Juravle | 175dc73 | 2015-08-25 15:42:32 +0100 | [diff] [blame] | 206 | // TODO: Can this still happen? |
Nicolas Geoffray | 3507105 | 2015-06-09 15:43:38 +0100 | [diff] [blame] | 207 | // Method cannot be resolved if it is in another dex file we do not have access to. |
Nicolas Geoffray | 9437b78 | 2015-03-25 10:08:51 +0000 | [diff] [blame] | 208 | VLOG(compiler) << "Method cannot be resolved " << PrettyMethod(method_index, caller_dex_file); |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 209 | return false; |
| 210 | } |
| 211 | |
Nicolas Geoffray | 454a481 | 2015-06-09 10:37:32 +0100 | [diff] [blame] | 212 | if (!invoke_instruction->IsInvokeStaticOrDirect()) { |
| 213 | resolved_method = FindVirtualOrInterfaceTarget(invoke_instruction, resolved_method); |
| 214 | if (resolved_method == nullptr) { |
| 215 | VLOG(compiler) << "Interface or virtual call to " |
| 216 | << PrettyMethod(method_index, caller_dex_file) |
| 217 | << " could not be statically determined"; |
| 218 | return false; |
| 219 | } |
| 220 | // We have found a method, but we need to find where that method is for the caller's |
| 221 | // dex file. |
| 222 | method_index = FindMethodIndexIn(resolved_method, caller_dex_file, method_index); |
| 223 | if (method_index == DexFile::kDexNoIndex) { |
| 224 | VLOG(compiler) << "Interface or virtual call to " |
| 225 | << PrettyMethod(resolved_method) |
| 226 | << " cannot be inlined because unaccessible to caller"; |
| 227 | return false; |
| 228 | } |
| 229 | } |
| 230 | |
Vladimir Marko | 5815501 | 2015-08-19 12:49:41 +0000 | [diff] [blame] | 231 | bool same_dex_file = |
| 232 | IsSameDexFile(*outer_compilation_unit_.GetDexFile(), *resolved_method->GetDexFile()); |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 233 | |
| 234 | const DexFile::CodeItem* code_item = resolved_method->GetCodeItem(); |
| 235 | |
| 236 | if (code_item == nullptr) { |
Nicolas Geoffray | 9437b78 | 2015-03-25 10:08:51 +0000 | [diff] [blame] | 237 | VLOG(compiler) << "Method " << PrettyMethod(method_index, caller_dex_file) |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 238 | << " is not inlined because it is native"; |
| 239 | return false; |
| 240 | } |
| 241 | |
Calin Juravle | ec74835 | 2015-07-29 13:52:12 +0100 | [diff] [blame] | 242 | size_t inline_max_code_units = compiler_driver_->GetCompilerOptions().GetInlineMaxCodeUnits(); |
| 243 | if (code_item->insns_size_in_code_units_ > inline_max_code_units) { |
Nicolas Geoffray | 9437b78 | 2015-03-25 10:08:51 +0000 | [diff] [blame] | 244 | VLOG(compiler) << "Method " << PrettyMethod(method_index, caller_dex_file) |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 245 | << " is too big to inline"; |
| 246 | return false; |
| 247 | } |
| 248 | |
| 249 | if (code_item->tries_size_ != 0) { |
Nicolas Geoffray | 9437b78 | 2015-03-25 10:08:51 +0000 | [diff] [blame] | 250 | VLOG(compiler) << "Method " << PrettyMethod(method_index, caller_dex_file) |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 251 | << " is not inlined because of try block"; |
| 252 | return false; |
| 253 | } |
| 254 | |
Nicolas Geoffray | 481303b | 2015-10-02 12:38:40 +0100 | [diff] [blame] | 255 | if (!resolved_method->GetDeclaringClass()->IsVerified()) { |
Nicolas Geoffray | ccc6197 | 2015-10-01 14:34:20 +0100 | [diff] [blame] | 256 | uint16_t class_def_idx = resolved_method->GetDeclaringClass()->GetDexClassDefIndex(); |
| 257 | if (!compiler_driver_->IsMethodVerifiedWithoutFailures( |
| 258 | resolved_method->GetDexMethodIndex(), class_def_idx, *resolved_method->GetDexFile())) { |
| 259 | VLOG(compiler) << "Method " << PrettyMethod(method_index, caller_dex_file) |
| 260 | << " couldn't be verified, so it cannot be inlined"; |
| 261 | return false; |
| 262 | } |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 263 | } |
| 264 | |
Roland Levillain | 4c0eb42 | 2015-04-24 16:43:49 +0100 | [diff] [blame] | 265 | if (invoke_instruction->IsInvokeStaticOrDirect() && |
| 266 | invoke_instruction->AsInvokeStaticOrDirect()->IsStaticWithImplicitClinitCheck()) { |
| 267 | // Case of a static method that cannot be inlined because it implicitly |
| 268 | // requires an initialization check of its declaring class. |
| 269 | VLOG(compiler) << "Method " << PrettyMethod(method_index, caller_dex_file) |
| 270 | << " is not inlined because it is static and requires a clinit" |
| 271 | << " check that cannot be emitted due to Dex cache limitations"; |
| 272 | return false; |
| 273 | } |
| 274 | |
Guillaume "Vermeille" Sanchez | ae09d2d | 2015-05-29 10:52:55 +0100 | [diff] [blame] | 275 | if (!TryBuildAndInline(resolved_method, invoke_instruction, same_dex_file)) { |
Nicolas Geoffray | c0365b1 | 2015-03-18 18:31:52 +0000 | [diff] [blame] | 276 | return false; |
| 277 | } |
| 278 | |
Nicolas Geoffray | 9437b78 | 2015-03-25 10:08:51 +0000 | [diff] [blame] | 279 | VLOG(compiler) << "Successfully inlined " << PrettyMethod(method_index, caller_dex_file); |
Nicolas Geoffray | c0365b1 | 2015-03-18 18:31:52 +0000 | [diff] [blame] | 280 | MaybeRecordStat(kInlinedInvoke); |
| 281 | return true; |
| 282 | } |
| 283 | |
Mathieu Chartier | e401d14 | 2015-04-22 13:56:20 -0700 | [diff] [blame] | 284 | bool HInliner::TryBuildAndInline(ArtMethod* resolved_method, |
Nicolas Geoffray | c0365b1 | 2015-03-18 18:31:52 +0000 | [diff] [blame] | 285 | HInvoke* invoke_instruction, |
Nicolas Geoffray | e418dda | 2015-08-11 20:03:09 -0700 | [diff] [blame] | 286 | bool same_dex_file) { |
Nicolas Geoffray | c0365b1 | 2015-03-18 18:31:52 +0000 | [diff] [blame] | 287 | ScopedObjectAccess soa(Thread::Current()); |
| 288 | const DexFile::CodeItem* code_item = resolved_method->GetCodeItem(); |
Guillaume "Vermeille" Sanchez | ae09d2d | 2015-05-29 10:52:55 +0100 | [diff] [blame] | 289 | const DexFile& callee_dex_file = *resolved_method->GetDexFile(); |
| 290 | uint32_t method_index = resolved_method->GetDexMethodIndex(); |
Calin Juravle | 2e76830 | 2015-07-28 14:41:11 +0000 | [diff] [blame] | 291 | ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker(); |
Mathieu Chartier | 736b560 | 2015-09-02 14:54:11 -0700 | [diff] [blame] | 292 | Handle<mirror::DexCache> dex_cache(handles_->NewHandle(resolved_method->GetDexCache())); |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 293 | DexCompilationUnit dex_compilation_unit( |
| 294 | nullptr, |
Nicolas Geoffray | 9437b78 | 2015-03-25 10:08:51 +0000 | [diff] [blame] | 295 | caller_compilation_unit_.GetClassLoader(), |
Calin Juravle | 2e76830 | 2015-07-28 14:41:11 +0000 | [diff] [blame] | 296 | class_linker, |
Nicolas Geoffray | 8dbf0cf | 2015-08-11 02:14:38 +0000 | [diff] [blame] | 297 | callee_dex_file, |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 298 | code_item, |
| 299 | resolved_method->GetDeclaringClass()->GetDexClassDefIndex(), |
Nicolas Geoffray | 8dbf0cf | 2015-08-11 02:14:38 +0000 | [diff] [blame] | 300 | method_index, |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 301 | resolved_method->GetAccessFlags(), |
Mathieu Chartier | 736b560 | 2015-09-02 14:54:11 -0700 | [diff] [blame] | 302 | compiler_driver_->GetVerifiedMethod(&callee_dex_file, method_index), |
| 303 | dex_cache); |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 304 | |
Calin Juravle | 3cd4fc8 | 2015-05-14 15:15:42 +0100 | [diff] [blame] | 305 | bool requires_ctor_barrier = false; |
| 306 | |
| 307 | if (dex_compilation_unit.IsConstructor()) { |
| 308 | // If it's a super invocation and we already generate a barrier there's no need |
| 309 | // to generate another one. |
| 310 | // We identify super calls by looking at the "this" pointer. If its value is the |
| 311 | // same as the local "this" pointer then we must have a super invocation. |
| 312 | bool is_super_invocation = invoke_instruction->InputAt(0)->IsParameterValue() |
| 313 | && invoke_instruction->InputAt(0)->AsParameterValue()->IsThis(); |
| 314 | if (is_super_invocation && graph_->ShouldGenerateConstructorBarrier()) { |
| 315 | requires_ctor_barrier = false; |
| 316 | } else { |
| 317 | Thread* self = Thread::Current(); |
| 318 | requires_ctor_barrier = compiler_driver_->RequiresConstructorBarrier(self, |
| 319 | dex_compilation_unit.GetDexFile(), |
| 320 | dex_compilation_unit.GetClassDefIndex()); |
| 321 | } |
| 322 | } |
| 323 | |
Nicolas Geoffray | 3507105 | 2015-06-09 15:43:38 +0100 | [diff] [blame] | 324 | InvokeType invoke_type = invoke_instruction->GetOriginalInvokeType(); |
| 325 | if (invoke_type == kInterface) { |
| 326 | // We have statically resolved the dispatch. To please the class linker |
| 327 | // at runtime, we change this call as if it was a virtual call. |
| 328 | invoke_type = kVirtual; |
| 329 | } |
Nicolas Geoffray | e0fe7ae | 2015-03-09 10:02:49 +0000 | [diff] [blame] | 330 | HGraph* callee_graph = new (graph_->GetArena()) HGraph( |
Nicolas Geoffray | 0a23d74 | 2015-05-07 11:57:35 +0100 | [diff] [blame] | 331 | graph_->GetArena(), |
Guillaume "Vermeille" Sanchez | ae09d2d | 2015-05-29 10:52:55 +0100 | [diff] [blame] | 332 | callee_dex_file, |
Nicolas Geoffray | 0a23d74 | 2015-05-07 11:57:35 +0100 | [diff] [blame] | 333 | method_index, |
Calin Juravle | 3cd4fc8 | 2015-05-14 15:15:42 +0100 | [diff] [blame] | 334 | requires_ctor_barrier, |
Mathieu Chartier | e401d14 | 2015-04-22 13:56:20 -0700 | [diff] [blame] | 335 | compiler_driver_->GetInstructionSet(), |
Nicolas Geoffray | 3507105 | 2015-06-09 15:43:38 +0100 | [diff] [blame] | 336 | invoke_type, |
Nicolas Geoffray | 0a23d74 | 2015-05-07 11:57:35 +0100 | [diff] [blame] | 337 | graph_->IsDebuggable(), |
| 338 | graph_->GetCurrentInstructionId()); |
David Brazdil | 5e8b137 | 2015-01-23 14:39:08 +0000 | [diff] [blame] | 339 | |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 340 | OptimizingCompilerStats inline_stats; |
David Brazdil | 5e8b137 | 2015-01-23 14:39:08 +0000 | [diff] [blame] | 341 | HGraphBuilder builder(callee_graph, |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 342 | &dex_compilation_unit, |
| 343 | &outer_compilation_unit_, |
Nicolas Geoffray | 9437b78 | 2015-03-25 10:08:51 +0000 | [diff] [blame] | 344 | resolved_method->GetDexFile(), |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 345 | compiler_driver_, |
Nicolas Geoffray | 9523a3e | 2015-07-17 11:51:28 +0000 | [diff] [blame] | 346 | &inline_stats, |
Mathieu Chartier | 736b560 | 2015-09-02 14:54:11 -0700 | [diff] [blame] | 347 | resolved_method->GetQuickenedInfo(), |
| 348 | dex_cache); |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 349 | |
David Brazdil | 5e8b137 | 2015-01-23 14:39:08 +0000 | [diff] [blame] | 350 | if (!builder.BuildGraph(*code_item)) { |
Guillaume "Vermeille" Sanchez | ae09d2d | 2015-05-29 10:52:55 +0100 | [diff] [blame] | 351 | VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file) |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 352 | << " could not be built, so cannot be inlined"; |
| 353 | return false; |
| 354 | } |
| 355 | |
Nicolas Geoffray | 259136f | 2014-12-17 23:21:58 +0000 | [diff] [blame] | 356 | if (!RegisterAllocator::CanAllocateRegistersFor(*callee_graph, |
| 357 | compiler_driver_->GetInstructionSet())) { |
Guillaume "Vermeille" Sanchez | ae09d2d | 2015-05-29 10:52:55 +0100 | [diff] [blame] | 358 | VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file) |
Nicolas Geoffray | 259136f | 2014-12-17 23:21:58 +0000 | [diff] [blame] | 359 | << " cannot be inlined because of the register allocator"; |
| 360 | return false; |
| 361 | } |
| 362 | |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 363 | if (!callee_graph->TryBuildingSsa()) { |
Guillaume "Vermeille" Sanchez | ae09d2d | 2015-05-29 10:52:55 +0100 | [diff] [blame] | 364 | VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file) |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 365 | << " could not be transformed to SSA"; |
| 366 | return false; |
| 367 | } |
| 368 | |
Nicolas Geoffray | e418dda | 2015-08-11 20:03:09 -0700 | [diff] [blame] | 369 | size_t parameter_index = 0; |
| 370 | for (HInstructionIterator instructions(callee_graph->GetEntryBlock()->GetInstructions()); |
| 371 | !instructions.Done(); |
| 372 | instructions.Advance()) { |
| 373 | HInstruction* current = instructions.Current(); |
| 374 | if (current->IsParameterValue()) { |
| 375 | HInstruction* argument = invoke_instruction->InputAt(parameter_index++); |
| 376 | if (argument->IsNullConstant()) { |
| 377 | current->ReplaceWith(callee_graph->GetNullConstant()); |
| 378 | } else if (argument->IsIntConstant()) { |
| 379 | current->ReplaceWith(callee_graph->GetIntConstant(argument->AsIntConstant()->GetValue())); |
| 380 | } else if (argument->IsLongConstant()) { |
| 381 | current->ReplaceWith(callee_graph->GetLongConstant(argument->AsLongConstant()->GetValue())); |
| 382 | } else if (argument->IsFloatConstant()) { |
| 383 | current->ReplaceWith( |
| 384 | callee_graph->GetFloatConstant(argument->AsFloatConstant()->GetValue())); |
| 385 | } else if (argument->IsDoubleConstant()) { |
| 386 | current->ReplaceWith( |
| 387 | callee_graph->GetDoubleConstant(argument->AsDoubleConstant()->GetValue())); |
| 388 | } else if (argument->GetType() == Primitive::kPrimNot) { |
| 389 | current->SetReferenceTypeInfo(argument->GetReferenceTypeInfo()); |
| 390 | current->AsParameterValue()->SetCanBeNull(argument->CanBeNull()); |
| 391 | } |
| 392 | } |
| 393 | } |
| 394 | |
Nicolas Geoffray | ef87c5d | 2015-01-30 12:41:14 +0000 | [diff] [blame] | 395 | // Run simple optimizations on the graph. |
Calin Juravle | 7a9c885 | 2015-04-21 14:07:50 +0100 | [diff] [blame] | 396 | HDeadCodeElimination dce(callee_graph, stats_); |
Nicolas Geoffray | ef87c5d | 2015-01-30 12:41:14 +0000 | [diff] [blame] | 397 | HConstantFolding fold(callee_graph); |
Nicolas Geoffray | 454a481 | 2015-06-09 10:37:32 +0100 | [diff] [blame] | 398 | ReferenceTypePropagation type_propagation(callee_graph, handles_); |
Calin Juravle | acf735c | 2015-02-12 15:25:22 +0000 | [diff] [blame] | 399 | InstructionSimplifier simplify(callee_graph, stats_); |
Scott Wakeling | d60a1af | 2015-07-22 14:32:44 +0100 | [diff] [blame] | 400 | IntrinsicsRecognizer intrinsics(callee_graph, compiler_driver_); |
Nicolas Geoffray | ef87c5d | 2015-01-30 12:41:14 +0000 | [diff] [blame] | 401 | |
| 402 | HOptimization* optimizations[] = { |
Scott Wakeling | d60a1af | 2015-07-22 14:32:44 +0100 | [diff] [blame] | 403 | &intrinsics, |
Nicolas Geoffray | 454a481 | 2015-06-09 10:37:32 +0100 | [diff] [blame] | 404 | &type_propagation, |
Nicolas Geoffray | ef87c5d | 2015-01-30 12:41:14 +0000 | [diff] [blame] | 405 | &simplify, |
Nicolas Geoffray | e418dda | 2015-08-11 20:03:09 -0700 | [diff] [blame] | 406 | &dce, |
| 407 | &fold, |
Nicolas Geoffray | ef87c5d | 2015-01-30 12:41:14 +0000 | [diff] [blame] | 408 | }; |
| 409 | |
| 410 | for (size_t i = 0; i < arraysize(optimizations); ++i) { |
| 411 | HOptimization* optimization = optimizations[i]; |
| 412 | optimization->Run(); |
| 413 | } |
| 414 | |
Nicolas Geoffray | e418dda | 2015-08-11 20:03:09 -0700 | [diff] [blame] | 415 | size_t number_of_instructions_budget = kMaximumNumberOfHInstructions; |
Calin Juravle | ec74835 | 2015-07-29 13:52:12 +0100 | [diff] [blame] | 416 | if (depth_ + 1 < compiler_driver_->GetCompilerOptions().GetInlineDepthLimit()) { |
Nicolas Geoffray | 9437b78 | 2015-03-25 10:08:51 +0000 | [diff] [blame] | 417 | HInliner inliner(callee_graph, |
| 418 | outer_compilation_unit_, |
| 419 | dex_compilation_unit, |
| 420 | compiler_driver_, |
Nicolas Geoffray | 454a481 | 2015-06-09 10:37:32 +0100 | [diff] [blame] | 421 | handles_, |
Nicolas Geoffray | 9437b78 | 2015-03-25 10:08:51 +0000 | [diff] [blame] | 422 | stats_, |
| 423 | depth_ + 1); |
Nicolas Geoffray | ef87c5d | 2015-01-30 12:41:14 +0000 | [diff] [blame] | 424 | inliner.Run(); |
Nicolas Geoffray | e418dda | 2015-08-11 20:03:09 -0700 | [diff] [blame] | 425 | number_of_instructions_budget += inliner.number_of_inlined_instructions_; |
Nicolas Geoffray | ef87c5d | 2015-01-30 12:41:14 +0000 | [diff] [blame] | 426 | } |
| 427 | |
Nicolas Geoffray | d23eeef | 2015-05-18 22:31:29 +0100 | [diff] [blame] | 428 | // TODO: We should abort only if all predecessors throw. However, |
| 429 | // HGraph::InlineInto currently does not handle an exit block with |
| 430 | // a throw predecessor. |
| 431 | HBasicBlock* exit_block = callee_graph->GetExitBlock(); |
| 432 | if (exit_block == nullptr) { |
Guillaume "Vermeille" Sanchez | ae09d2d | 2015-05-29 10:52:55 +0100 | [diff] [blame] | 433 | VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file) |
Nicolas Geoffray | d23eeef | 2015-05-18 22:31:29 +0100 | [diff] [blame] | 434 | << " could not be inlined because it has an infinite loop"; |
Nicolas Geoffray | d23eeef | 2015-05-18 22:31:29 +0100 | [diff] [blame] | 435 | return false; |
| 436 | } |
| 437 | |
| 438 | bool has_throw_predecessor = false; |
Vladimir Marko | 6058455 | 2015-09-03 13:35:12 +0000 | [diff] [blame] | 439 | for (HBasicBlock* predecessor : exit_block->GetPredecessors()) { |
| 440 | if (predecessor->GetLastInstruction()->IsThrow()) { |
Nicolas Geoffray | d23eeef | 2015-05-18 22:31:29 +0100 | [diff] [blame] | 441 | has_throw_predecessor = true; |
| 442 | break; |
| 443 | } |
| 444 | } |
| 445 | if (has_throw_predecessor) { |
Guillaume "Vermeille" Sanchez | ae09d2d | 2015-05-29 10:52:55 +0100 | [diff] [blame] | 446 | VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file) |
Nicolas Geoffray | d23eeef | 2015-05-18 22:31:29 +0100 | [diff] [blame] | 447 | << " could not be inlined because one branch always throws"; |
Nicolas Geoffray | d23eeef | 2015-05-18 22:31:29 +0100 | [diff] [blame] | 448 | return false; |
| 449 | } |
| 450 | |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 451 | HReversePostOrderIterator it(*callee_graph); |
Nicolas Geoffray | ef87c5d | 2015-01-30 12:41:14 +0000 | [diff] [blame] | 452 | it.Advance(); // Past the entry block, it does not contain instructions that prevent inlining. |
Nicolas Geoffray | e418dda | 2015-08-11 20:03:09 -0700 | [diff] [blame] | 453 | size_t number_of_instructions = 0; |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 454 | for (; !it.Done(); it.Advance()) { |
| 455 | HBasicBlock* block = it.Current(); |
| 456 | if (block->IsLoopHeader()) { |
Guillaume "Vermeille" Sanchez | ae09d2d | 2015-05-29 10:52:55 +0100 | [diff] [blame] | 457 | VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file) |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 458 | << " could not be inlined because it contains a loop"; |
| 459 | return false; |
| 460 | } |
| 461 | |
| 462 | for (HInstructionIterator instr_it(block->GetInstructions()); |
| 463 | !instr_it.Done(); |
| 464 | instr_it.Advance()) { |
Nicolas Geoffray | e418dda | 2015-08-11 20:03:09 -0700 | [diff] [blame] | 465 | if (number_of_instructions++ == number_of_instructions_budget) { |
| 466 | VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file) |
| 467 | << " could not be inlined because it is too big."; |
| 468 | return false; |
| 469 | } |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 470 | HInstruction* current = instr_it.Current(); |
Nicolas Geoffray | 276d9da | 2015-02-02 18:24:11 +0000 | [diff] [blame] | 471 | |
Nicolas Geoffray | d23eeef | 2015-05-18 22:31:29 +0100 | [diff] [blame] | 472 | if (current->IsInvokeInterface()) { |
| 473 | // Disable inlining of interface calls. The cost in case of entering the |
| 474 | // resolution conflict is currently too high. |
Guillaume "Vermeille" Sanchez | ae09d2d | 2015-05-29 10:52:55 +0100 | [diff] [blame] | 475 | VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file) |
Nicolas Geoffray | d23eeef | 2015-05-18 22:31:29 +0100 | [diff] [blame] | 476 | << " could not be inlined because it has an interface call."; |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 477 | return false; |
| 478 | } |
| 479 | |
Nicolas Geoffray | d23eeef | 2015-05-18 22:31:29 +0100 | [diff] [blame] | 480 | if (!same_dex_file && current->NeedsEnvironment()) { |
Guillaume "Vermeille" Sanchez | ae09d2d | 2015-05-29 10:52:55 +0100 | [diff] [blame] | 481 | VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file) |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 482 | << " could not be inlined because " << current->DebugName() |
Nicolas Geoffray | d23eeef | 2015-05-18 22:31:29 +0100 | [diff] [blame] | 483 | << " needs an environment and is in a different dex file"; |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 484 | return false; |
| 485 | } |
Nicolas Geoffray | 9437b78 | 2015-03-25 10:08:51 +0000 | [diff] [blame] | 486 | |
Nicolas Geoffray | d23eeef | 2015-05-18 22:31:29 +0100 | [diff] [blame] | 487 | if (!same_dex_file && current->NeedsDexCache()) { |
Guillaume "Vermeille" Sanchez | ae09d2d | 2015-05-29 10:52:55 +0100 | [diff] [blame] | 488 | VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file) |
Nicolas Geoffray | 9437b78 | 2015-03-25 10:08:51 +0000 | [diff] [blame] | 489 | << " could not be inlined because " << current->DebugName() |
| 490 | << " it is in a different dex file and requires access to the dex cache"; |
| 491 | return false; |
| 492 | } |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 493 | } |
| 494 | } |
Nicolas Geoffray | e418dda | 2015-08-11 20:03:09 -0700 | [diff] [blame] | 495 | number_of_inlined_instructions_ += number_of_instructions; |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 496 | |
Calin Juravle | 2e76830 | 2015-07-28 14:41:11 +0000 | [diff] [blame] | 497 | HInstruction* return_replacement = callee_graph->InlineInto(graph_, invoke_instruction); |
| 498 | |
| 499 | // When merging the graph we might create a new NullConstant in the caller graph which does |
| 500 | // not have the chance to be typed. We assign the correct type here so that we can keep the |
| 501 | // assertion that every reference has a valid type. This also simplifies checks along the way. |
| 502 | HNullConstant* null_constant = graph_->GetNullConstant(); |
| 503 | if (!null_constant->GetReferenceTypeInfo().IsValid()) { |
| 504 | ReferenceTypeInfo::TypeHandle obj_handle = |
| 505 | handles_->NewHandle(class_linker->GetClassRoot(ClassLinker::kJavaLangObject)); |
| 506 | null_constant->SetReferenceTypeInfo( |
| 507 | ReferenceTypeInfo::Create(obj_handle, false /* is_exact */)); |
| 508 | } |
| 509 | |
| 510 | if ((return_replacement != nullptr) |
| 511 | && (return_replacement->GetType() == Primitive::kPrimNot)) { |
| 512 | if (!return_replacement->GetReferenceTypeInfo().IsValid()) { |
| 513 | // Make sure that we have a valid type for the return. We may get an invalid one when |
| 514 | // we inline invokes with multiple branches and create a Phi for the result. |
| 515 | // TODO: we could be more precise by merging the phi inputs but that requires |
| 516 | // some functionality from the reference type propagation. |
| 517 | DCHECK(return_replacement->IsPhi()); |
Vladimir Marko | 05792b9 | 2015-08-03 11:56:49 +0100 | [diff] [blame] | 518 | size_t pointer_size = Runtime::Current()->GetClassLinker()->GetImagePointerSize(); |
Calin Juravle | 2e76830 | 2015-07-28 14:41:11 +0000 | [diff] [blame] | 519 | ReferenceTypeInfo::TypeHandle return_handle = |
Vladimir Marko | 05792b9 | 2015-08-03 11:56:49 +0100 | [diff] [blame] | 520 | handles_->NewHandle(resolved_method->GetReturnType(true /* resolve */, pointer_size)); |
Calin Juravle | 2e76830 | 2015-07-28 14:41:11 +0000 | [diff] [blame] | 521 | return_replacement->SetReferenceTypeInfo(ReferenceTypeInfo::Create( |
David Brazdil | baf89b8 | 2015-09-15 11:36:54 +0100 | [diff] [blame] | 522 | return_handle, return_handle->CannotBeAssignedFromOtherTypes() /* is_exact */)); |
Calin Juravle | 2e76830 | 2015-07-28 14:41:11 +0000 | [diff] [blame] | 523 | } |
| 524 | } |
Nicolas Geoffray | 7c5367b | 2014-12-17 10:13:46 +0000 | [diff] [blame] | 525 | |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 526 | return true; |
| 527 | } |
| 528 | |
| 529 | } // namespace art |