| commit | a652c00c8eb0906ff6b9f81c9d1a7972ce973ad0 | [log] [tgz] |
|---|---|---|
| author | Tao Bao <tbao@google.com> | Thu Mar 01 19:31:38 2018 -0800 |
| committer | Tao Bao <tbao@google.com> | Fri Mar 02 13:20:43 2018 -0800 |
| tree | e6e95ee56ca72f5633d3e491ca0c59a57c264c1b | |
| parent | 1fa15d7491df2231f067b32d63746557af61f2ea [diff] |
releasetools: Fix a mismatching close. There's a mismatch in WriteABOTAPackageWithBrilloScript(). temp_zip_file = tempfile.NamedTemporaryFile() ... common.ZipClose(temp_zip_file) It's benign since common.ZipClose() happens to be calling "temp_zip_file.close()". This CL moves the use of tempfile to common.MakeTempFile(), so that the tempfile will be cleaned up automatically as part of the call to common.Cleanup(). (Not fixing the close() directly, since the nearby lines will be refactored into another function shortly.) Also remove one assert in the same function, which trivially holds in the current code. Test: Generate an A/B OTA. Change-Id: I53b375d1150820de718dec0ead55abf5f4951071
This is the Makefile-based portion of the Android Build System.
For documentation on how to run a build, see Usage.txt
For a list of behavioral changes useful for Android.mk writers see Changes.md
For an outdated reference on Android.mk files, see build-system.html. Our Android.mk files look similar, but are entirely different from the Android.mk files used by the NDK build system. When searching for documentation elsewhere, ensure that it is for the platform build system -- most are not.
This Makefile-based system is in the process of being replaced with Soong, a new build system written in Go. During the transition, all of these makefiles are read by Kati, and generate a ninja file instead of being executed directly. That's combined with a ninja file read by Soong so that the build graph of the two systems can be combined and run as one.