commit | dba59eeabd21c91d67d6a6ce365141deb56ed0f7 | [log] [tgz] |
---|---|---|
author | Tao Bao <tbao@google.com> | Tue Jan 09 13:21:02 2018 -0800 |
committer | Tao Bao <tbao@google.com> | Thu Mar 01 10:03:31 2018 -0800 |
tree | cd661256d85642e33326588fea01928dd8caab41 | |
parent | 01670eb1412a20702690a5ff9f5cfa55e657f212 [diff] |
releasetools: Don't return ZipFile from common.UnzipTemp(). In addition to the unzipping work, common.UnzipTemp() kindly bundles an open ZipFile object as part of the return value. It doesn't look very helpful to the callers though. It also looks less obvious that the caller needs to properly close the handle (missing the close here is benign though). This CL just removes the ZipFile object out of the return value, and leaves the work to callers. Test: `m dist` on both of A/B and non-A/B target. Test: python -m unittest test_add_img_to_target_files Test: python -m unittest test_common Test: python -m unittest test_ota_from_target_files Test: Check the callers to common.UnzipTemp() in code search. Change-Id: Id47da3fd42a0e76d6ae8851f05780db319ee48cf
This is the Makefile-based portion of the Android Build System.
For documentation on how to run a build, see Usage.txt
For a list of behavioral changes useful for Android.mk writers see Changes.md
For an outdated reference on Android.mk files, see build-system.html. Our Android.mk files look similar, but are entirely different from the Android.mk files used by the NDK build system. When searching for documentation elsewhere, ensure that it is for the platform build system -- most are not.
This Makefile-based system is in the process of being replaced with Soong, a new build system written in Go. During the transition, all of these makefiles are read by Kati, and generate a ninja file instead of being executed directly. That's combined with a ninja file read by Soong so that the build graph of the two systems can be combined and run as one.