commit | f47bf0fecfb13443b88c1026f28727b5377a9577 | [log] [tgz] |
---|---|---|
author | Tao Bao <tbao@google.com> | Wed Mar 21 23:28:51 2018 -0700 |
committer | Tao Bao <tbao@google.com> | Thu Mar 22 10:27:04 2018 -0700 |
tree | 082c2991eb12c4d23390d96aa742dadee81c7b64 | |
parent | 2ebcf419e46cb7c77532feeea9aee3ac59f18d69 [diff] |
releasetools: Fix an issue in GetMinSdkVersion. The following is a buggy pattern that won't capture anything into err. The issue is benign, since a failed run would be eventually captured by a subsequent check. p = Run(["aapt", ...], stdout=subprocess.PIPE) output, err = p.communicate() if err: raise ... This CL changes the error detection to be based on the return code from aapt. It also adds some sanity test to ensure the call to aapt works. The test app is built from AOSP com.android.cts.ctsshim (chosen mostly because of its small size). Test: python -m unittest test_common Change-Id: I337f141bd0fc5f0801dfc628c601b88b7640789c
This is the Makefile-based portion of the Android Build System.
For documentation on how to run a build, see Usage.txt
For a list of behavioral changes useful for Android.mk writers see Changes.md
For an outdated reference on Android.mk files, see build-system.html. Our Android.mk files look similar, but are entirely different from the Android.mk files used by the NDK build system. When searching for documentation elsewhere, ensure that it is for the platform build system -- most are not.
This Makefile-based system is in the process of being replaced with Soong, a new build system written in Go. During the transition, all of these makefiles are read by Kati, and generate a ninja file instead of being executed directly. That's combined with a ninja file read by Soong so that the build graph of the two systems can be combined and run as one.