gerrit-public.fairphone.software / platform / build / blueprint / 5dc6759951022a4f943dabe222900ebf8c6335cb
| commit | 5dc6759951022a4f943dabe222900ebf8c6335cb | [log] [tgz] |
|---|---|---|
| author | Colin Cross <ccross@android.com> | Mon Aug 24 14:46:13 2020 -0700 |
| committer | Colin Cross <ccross@android.com> | Wed Sep 09 18:29:15 2020 -0700 |
| tree | efd6fc4b98207d950b8f383c5b55fa949cd863cc | |
| parent | 5df74a8e3866129732ee83eed5bfadbe70ffebae [diff] |
Fix AddFarVariationDependencies subset checks AddFarVariationDependencies claims to take the first variant that matches all the requested variations, but it did nothing of the sort. It took the first variant that either matched or did not contain each of the requested variations. A module with no variations was always matched, and requesting variations that didn't apply to a module still matched (for example, requesting an image variation for a host module that was ignored by the image mutator). Fix AddFarVariationDependencies by making subset actually check for subsets. Test: Test_findVariant Change-Id: I10063fec342db2a1c0685a7db08e4a650d14bd4e
2 files changed
tree: efd6fc4b98207d950b8f383c5b55fa949cd863cc
- .github/
- bootstrap/
- bpfmt/
- bpmodify/
- deptools/
- gotestmain/
- gotestrunner/
- loadplugins/
- microfactory/
- parser/
- pathtools/
- proptools/
- tests/
- .gitignore
- .gofmt.sh
- blueprint.bash
- blueprint_impl.bash
- Blueprints
- bootstrap.bash
- context.go
- context_test.go
- CONTRIBUTING.md
- doc.go
- glob.go
- glob_test.go
- go.mod
- LICENSE
- live_tracker.go
- mangle.go
- module_ctx.go
- module_ctx_test.go
- name_interface.go
- ninja_defs.go
- ninja_strings.go
- ninja_strings_test.go
- ninja_writer.go
- ninja_writer_test.go
- package_ctx.go
- README.md
- scope.go
- singleton_ctx.go
- splice_modules_test.go
- visit_test.go
README.md
Blueprint Build System
Blueprint is a meta-build system that reads in Blueprints files that describe modules that need to be built, and produces a Ninja manifest describing the commands that need to be run and their dependencies. Where most build systems use built-in rules or a domain-specific language to describe the logic for converting module descriptions to build rules, Blueprint delegates this to per-project build logic written in Go. For large, heterogenous projects this allows the inherent complexity of the build logic to be maintained in a high-level language, while still allowing simple changes to individual modules by modifying easy to understand Blueprints files.