commit 90e52cec561a406ad5683cd384148632273719d4
author Shinichiro Hamaji <shinichiro.hamaji@gmail.com> Wed Feb 10 13:53:41 2016 +0900
committer Shinichiro Hamaji <shinichiro.hamaji@gmail.com> Wed Feb 10 13:53:41 2016 +0900
tree 7cefec2fa13a02d2d48d00d1fbf25fb5040cbb23
parent 499e1db4df0f54cb52285c9890fb98685b46a740

[C++] Remove unnecessary allocation for SimpleVar

eval.cc

diff --git a/eval.cc b/eval.cc
index f21e185..3dfc0e6 100644
--- a/eval.cc
+++ b/eval.cc
@@ -54,9 +54,12 @@
   Var* rhs = NULL;
   bool needs_assign = true;
   switch (op) {
-    case AssignOp::COLON_EQ:
-      rhs = new SimpleVar(rhs_v->Eval(this), origin);
+    case AssignOp::COLON_EQ: {
+      SimpleVar* sv = new SimpleVar(origin);
+      rhs_v->Eval(this, sv->mutable_value());
+      rhs = sv;
       break;
+    }
     case AssignOp::EQ:
       rhs = new RecursiveVar(rhs_v, origin, orig_rhs);
       break;

var.cc

diff --git a/var.cc b/var.cc
index d21dc4f..9fac956 100644
--- a/var.cc
+++ b/var.cc
@@ -47,6 +47,10 @@
   CHECK(false);
 }
 
+SimpleVar::SimpleVar(VarOrigin origin)
+    : origin_(origin) {
+}
+
 SimpleVar::SimpleVar(const string& v, VarOrigin origin)
     : v_(v), origin_(origin) {
 }

var.h

diff --git a/var.h b/var.h
index 3bae262..c3bb233 100644
--- a/var.h
+++ b/var.h
@@ -62,6 +62,7 @@
 
 class SimpleVar : public Var {
  public:
+  explicit SimpleVar(VarOrigin origin);
   SimpleVar(const string& v, VarOrigin origin);
 
   virtual const char* Flavor() const {
@@ -79,6 +80,8 @@
 
   virtual string DebugString() const override;
 
+  string* mutable_value() { return &v_; }
+
  private:
   string v_;
   VarOrigin origin_;