exec.go - platform/build/kati - Gitiles

 package main

 import (
 	"fmt"
 	"os"
 	"os/exec"
 	"path/filepath"
 	"strings"
 	"syscall"
 	"time"
 )

 type Executor struct {
 	rules         map[string]*Rule
 	implicitRules []*Rule
 	suffixRules   map[string][]*Rule
 	firstRule     *Rule
 	shell         string

 	// target -> timestamp
 	done map[string]int64
 }

 func newExecutor() *Executor {
 	return &Executor{
 		rules:       make(map[string]*Rule),
 		suffixRules: make(map[string][]*Rule),
 		done:        make(map[string]int64),
 	}
 }

 // TODO(ukai): use time.Time?
 func getTimestamp(filename string) int64 {
 	st, err := os.Stat(filename)
 	if err != nil {
 		return -2
 	}
 	return st.ModTime().Unix()
 }

 func (ex *Executor) exists(target string) bool {
 	_, present := ex.rules[target]
 	if present {
 		return true
 	}
 	rule, present := ex.rules[".PHONY"]
 	if present {
 		for _, input := range rule.inputs {
 			if target == input {
 				return true
 			}
 		}
 	}
 	return exists(target)
 }

 type runner struct {
 	output      string
 	cmd         string
 	echo        bool
 	dryRun      bool
 	ignoreError bool
 	shell       string
 }

 func evalCmd(ev *Evaluator, r runner, s string, shell string) []runner {
 	r = newRunner(r, s, shell)
 	if strings.IndexByte(r.cmd, '$') < 0 {
 		// fast path
 		return []runner{r}
 	}
 	cmds := ev.evalExpr(r.cmd)
 	var runners []runner
 	for _, cmd := range strings.Split(cmds, "\n") {
 		runners = append(runners, newRunner(r, cmd, shell))
 	}
 	return runners
 }

 func newRunner(r runner, s string, shell string) runner {
 	r.shell = shell
 	for {
 		s = trimLeftSpace(s)
 		if s == "" {
 			return runner{}
 		}
 		switch s[0] {
 		case '@':
 			if !r.dryRun {
 				r.echo = false
 			}
 			s = s[1:]
 			continue
 		case '-':
 			r.ignoreError = true
 			s = s[1:]
 			continue
 		}
 		break
 	}
 	r.cmd = s
 	return r
 }

 func (r runner) run() error {
 	if r.echo {
 		fmt.Printf("%s\n", r.cmd)
 	}
 	if r.dryRun {
 		return nil
 	}
 	args := []string{r.shell, "-c", r.cmd}
 	cmd := exec.Cmd{
 		Path: args[0],
 		Args: args,
 	}
 	out, err := cmd.CombinedOutput()
 	fmt.Printf("%s", out)
 	exit := exitStatus(err)
 	if r.ignoreError && exit != 0 {
 		fmt.Printf("[%s] Error %d (ignored)\n", r.output, exit)
 		err = nil
 	}
 	return err
 }

 func exitStatus(err error) int {
 	if err == nil {
 		return 0
 	}
 	exit := 1
 	if err, ok := err.(*exec.ExitError); ok {
 		if w, ok := err.ProcessState.Sys().(syscall.WaitStatus); ok {
 			return w.ExitStatus()
 		}
 	}
 	return exit
 }

 func replaceSuffix(s string, newsuf string) string {
 	// TODO: Factor out the logic around suffix rules and use
 	// it from substitution references.
 	// http://www.gnu.org/software/make/manual/make.html#Substitution-Refs
 	return fmt.Sprintf("%s.%s", stripExt(s), newsuf)
 }

 func (ex *Executor) canPickImplicitRule(rule *Rule, output string) bool {
 	outputPattern := rule.outputPatterns[0]
 	if !matchPattern(outputPattern, output) {
 		return false
 	}
 	for _, input := range rule.inputs {
 		input = substPattern(outputPattern, input, output)
 		if !ex.exists(input) {
 			return false
 		}
 	}
 	return true
 }

 func (ex *Executor) pickRule(output string) (*Rule, bool) {
 	rule, present := ex.rules[output]
 	if present {
 		if len(rule.cmds) > 0 {
 			return rule, true
 		}
 		// If none of the explicit rules for a target has commands,
 		// then `make' searches for an applicable implicit rule to
 		// find some commands.
 	}

 	for _, irule := range ex.implicitRules {
 		if !ex.canPickImplicitRule(irule, output) {
 			continue
 		}
 		if rule != nil {
 			r := &Rule{}
 			*r = *rule
 			r.outputPatterns = irule.outputPatterns
 			// implicit rule's prerequisites will be used for $<
 			r.inputs = append(irule.inputs, r.inputs...)
 			if irule.vars != nil {
 				r.vars = NewVarTab(rule.vars)
 				for k, v := range irule.vars.m {
 					r.vars.Assign(k, v)
 				}
 			}
 			r.cmds = irule.cmds
 			// TODO(ukai): filename, lineno?
 			r.cmdLineno = irule.cmdLineno
 			return r, true
 		}
 		// TODO(ukai): check len(irule.cmd) ?
 		return irule, true
 	}

 	outputSuffix := filepath.Ext(output)
 	if !strings.HasPrefix(outputSuffix, ".") {
 		return rule, rule != nil
 	}
 	rules, present := ex.suffixRules[outputSuffix[1:]]
 	if !present {
 		return rule, rule != nil
 	}
 	for _, irule := range rules {
 		if len(irule.inputs) != 1 {
 			panic(fmt.Sprintf("unexpected number of input for a suffix rule (%d)", len(irule.inputs)))
 		}
 		if !ex.exists(replaceSuffix(output, irule.inputs[0])) {
 			continue
 		}
 		if rule != nil {
 			r := &Rule{}
 			*r = *rule
 			// TODO(ukai): input order is correct?
 			r.inputs = append([]string{replaceSuffix(output, irule.inputs[0])}, r.inputs...)
 			r.vars = NewVarTab(rule.vars)
 			if irule.vars != nil {
 				for k, v := range irule.vars.m {
 					r.vars.Assign(k, v)
 				}
 			}
 			r.cmds = irule.cmds
 			// TODO(ukai): filename, lineno?
 			r.cmdLineno = irule.cmdLineno
 			return r, true
 		}
 		// TODO(ukai): check len(irule.cmd) ?
 		return irule, true
 	}
 	return rule, rule != nil
 }

 func (ex *Executor) build(vars *VarTab, output string, neededBy string) (int64, error) {
 	Log("Building: %s", output)
 	outputTs, ok := ex.done[output]
 	if ok {
 		Log("Building: %s already done: %d", output, outputTs)
 		return outputTs, nil
 	}
 	outputTs = getTimestamp(output)

 	rule, present := ex.pickRule(output)
 	if !present {
 		if outputTs >= 0 {
 			return outputTs, nil
 		}
 		if neededBy == "" {
 			ErrorNoLocation("*** No rule to make target %q.", output)
 		} else {
 			ErrorNoLocation("*** No rule to make target %q, needed by %q.", output, neededBy)
 		}
 		return outputTs, fmt.Errorf("no rule to make target %q", output)
 	}
 	if rule.vars != nil {
 		vars = NewVarTab(vars)
 		for k, v := range rule.vars.m {
 			vars.Assign(k, v)
 		}
 	}

 	latest := int64(-1)
 	var actualInputs []string
 	Log("Building: %s inputs:%q", output, rule.inputs)
 	for _, input := range rule.inputs {
 		if len(rule.outputPatterns) > 0 {
 			if len(rule.outputPatterns) > 1 {
 				panic("TODO: multiple output pattern is not supported yet")
 			}
 			input = substPattern(rule.outputPatterns[0], input, output)
 		} else if rule.isSuffixRule {
 			input = replaceSuffix(output, input)
 		}
 		actualInputs = append(actualInputs, input)

 		ts, err := ex.build(vars, input, output)
 		if err != nil {
 			return outputTs, err
 		}
 		if latest < ts {
 			latest = ts
 		}
 	}

 	for _, input := range rule.orderOnlyInputs {
 		if exists(input) {
 			continue
 		}
 		ts, err := ex.build(vars, input, output)
 		if err != nil {
 			return outputTs, err
 		}
 		if latest < ts {
 			latest = ts
 		}
 	}

 	if outputTs >= latest {
 		return outputTs, nil
 	}

 	localVars := NewVarTab(vars)
 	// automatic variables.
 	localVars.Assign("@", SimpleVar{value: []byte(output), origin: "automatic"})
 	if len(actualInputs) > 0 {
 		localVars.Assign("<", SimpleVar{
 			value:  []byte(actualInputs[0]),
 			origin: "automatic",
 		})
 		localVars.Assign("^", SimpleVar{
 			value:  []byte(strings.Join(actualInputs, " ")),
 			origin: "automatic",
 		})
 	}
 	ev := newEvaluator(localVars.Vars())
 	ev.filename = rule.filename
 	ev.lineno = rule.cmdLineno
 	var runners []runner
 	Log("Building: %s cmds:%q", output, rule.cmds)
 	r := runner{
 		output: output,
 		echo:   true,
 		dryRun: dryRunFlag,
 	}
 	for _, cmd := range rule.cmds {
 		runners = append(runners, evalCmd(ev, r, cmd, ex.shell)...)
 	}
 	for _, r := range runners {
 		err := r.run()
 		if err != nil {
 			exit := exitStatus(err)
 			fmt.Printf("[%s] Error %d: %v\n", r.output, exit, err)
 			return outputTs, err
 		}
 	}

 	outputTs = getTimestamp(output)
 	if outputTs < 0 {
 		outputTs = time.Now().Unix()
 	}
 	ex.done[output] = outputTs
 	Log("Building: %s done %d", output, outputTs)
 	return outputTs, nil
 }

 func (ex *Executor) populateSuffixRule(rule *Rule, output string) bool {
 	if len(output) == 0 || output[0] != '.' {
 		return false
 	}
 	rest := output[1:]
 	dotIndex := strings.IndexByte(rest, '.')
 	// If there is only a single dot or the third dot, this is not a
 	// suffix rule.
 	if dotIndex < 0 || strings.IndexByte(rest[dotIndex+1:], '.') >= 0 {
 		return false
 	}

 	// This is a suffix rule.
 	inputSuffix := rest[:dotIndex]
 	outputSuffix := rest[dotIndex+1:]
 	r := &Rule{}
 	*r = *rule
 	r.inputs = []string{inputSuffix}
 	r.isSuffixRule = true
 	ex.suffixRules[outputSuffix] = append([]*Rule{r}, ex.suffixRules[outputSuffix]...)
 	return true
 }

 func (ex *Executor) populateExplicitRule(rule *Rule) {
 	// It seems rules with no outputs are siliently ignored.
 	if len(rule.outputs) == 0 {
 		return
 	}
 	for _, output := range rule.outputs {
 		output = filepath.Clean(output)

 		isSuffixRule := ex.populateSuffixRule(rule, output)

 		if oldRule, present := ex.rules[output]; present {
 			if oldRule.vars != nil || rule.vars != nil {
 				oldRule.isDoubleColon = rule.isDoubleColon
 				switch {
 				case rule.vars == nil && oldRule.vars != nil:
 					rule.vars = oldRule.vars
 				case rule.vars != nil && oldRule.vars == nil:
 				case rule.vars != nil && oldRule.vars != nil:
 					// parent would be the same vars?
 					for k, v := range rule.vars.m {
 						oldRule.vars.m[k] = v
 					}
 					rule.vars = oldRule.vars
 				}
 			}
 			if oldRule.isDoubleColon != rule.isDoubleColon {
 				Error(rule.filename, rule.lineno, "*** target file %q has both : and :: entries.", output)
 			}
 			if len(oldRule.cmds) > 0 && len(rule.cmds) > 0 && !isSuffixRule && !rule.isDoubleColon {
 				Warn(rule.filename, rule.cmdLineno, "overriding commands for target %q", output)
 				Warn(oldRule.filename, oldRule.cmdLineno, "ignoring old commands for target %q", output)
 			}
 			r := &Rule{}
 			*r = *rule
 			if rule.isDoubleColon {
 				r.cmds = append(oldRule.cmds, r.cmds...)
 			} else if len(oldRule.cmds) > 0 && len(rule.cmds) == 0 {
 				r.cmds = oldRule.cmds
 			}
 			r.inputs = append(r.inputs, oldRule.inputs...)
 			r.orderOnlyInputs = append(r.orderOnlyInputs, oldRule.orderOnlyInputs...)
 			ex.rules[output] = r
 		} else {
 			ex.rules[output] = rule
 			if ex.firstRule == nil && !strings.HasPrefix(output, ".") {
 				ex.firstRule = rule
 			}
 		}
 	}
 }

 func (ex *Executor) populateImplicitRule(rule *Rule) {
 	for _, outputPattern := range rule.outputPatterns {
 		r := &Rule{}
 		*r = *rule
 		r.outputPatterns = []string{outputPattern}
 		ex.implicitRules = append(ex.implicitRules, r)
 	}
 }

 func (ex *Executor) populateRules(er *EvalResult) {
 	for _, rule := range er.rules {
 		for i, input := range rule.inputs {
 			rule.inputs[i] = filepath.Clean(input)
 		}
 		for i, orderOnlyInput := range rule.orderOnlyInputs {
 			rule.orderOnlyInputs[i] = filepath.Clean(orderOnlyInput)
 		}
 		ex.populateExplicitRule(rule)

 		if len(rule.outputs) == 0 {
 			ex.populateImplicitRule(rule)
 		}
 	}

 	// Reverse the implicit rule for easier lookup.
 	for i, r := range ex.implicitRules {
 		if i >= len(ex.implicitRules)/2 {
 			break
 		}
 		j := len(ex.implicitRules) - i - 1
 		ex.implicitRules[i] = ex.implicitRules[j]
 		ex.implicitRules[j] = r
 	}
 }

 func (ex *Executor) exec(er *EvalResult, targets []string, vars *VarTab) error {
 	// TODO: We should move this to somewhere around evalCmd so that
 	// we can handle SHELL in target specific variables.
 	shellVar := vars.Lookup("SHELL")
 	ex.shell = shellVar.String()

 	ex.populateRules(er)

 	if len(targets) == 0 {
 		if ex.firstRule == nil {
 			ErrorNoLocation("*** No targets.")
 		}
 		targets = append(targets, ex.firstRule.outputs[0])
 	}

 	for _, target := range targets {
 		_, err := ex.build(vars, target, "")
 		if err != nil {
 			return err
 		}
 	}
 	return nil
 }

 func Exec(er *EvalResult, targets []string, vars *VarTab) error {
 	ex := newExecutor()
 	return ex.exec(er, targets, vars)
 }
	package main

	import (
	"fmt"
	"os"
	"os/exec"
	"path/filepath"
	"strings"
	"syscall"
	"time"
	)

	type Executor struct {
	rules map[string]*Rule
	implicitRules []*Rule
	suffixRules map[string][]*Rule
	firstRule *Rule
	shell string

	// target -> timestamp
	done map[string]int64
	}

	func newExecutor() *Executor {
	return &Executor{
	rules: make(map[string]*Rule),
	suffixRules: make(map[string][]*Rule),
	done: make(map[string]int64),
	}
	}

	// TODO(ukai): use time.Time?
	func getTimestamp(filename string) int64 {
	st, err := os.Stat(filename)
	if err != nil {
	return -2
	}
	return st.ModTime().Unix()
	}

	func (ex *Executor) exists(target string) bool {
	_, present := ex.rules[target]
	if present {
	return true
	}
	rule, present := ex.rules[".PHONY"]
	if present {
	for _, input := range rule.inputs {
	if target == input {
	return true
	}
	}
	}
	return exists(target)
	}

	type runner struct {
	output string
	cmd string
	echo bool
	dryRun bool
	ignoreError bool
	shell string
	}

	func evalCmd(ev *Evaluator, r runner, s string, shell string) []runner {
	r = newRunner(r, s, shell)
	if strings.IndexByte(r.cmd, '$') < 0 {
	// fast path
	return []runner{r}
	}
	cmds := ev.evalExpr(r.cmd)
	var runners []runner
	for _, cmd := range strings.Split(cmds, "\n") {
	runners = append(runners, newRunner(r, cmd, shell))
	}
	return runners
	}

	func newRunner(r runner, s string, shell string) runner {
	r.shell = shell
	for {
	s = trimLeftSpace(s)
	if s == "" {
	return runner{}
	}
	switch s[0] {
	case '@':
	if !r.dryRun {
	r.echo = false
	}
	s = s[1:]
	continue
	case '-':
	r.ignoreError = true
	s = s[1:]
	continue
	}
	break
	}
	r.cmd = s
	return r
	}

	func (r runner) run() error {
	if r.echo {
	fmt.Printf("%s\n", r.cmd)
	}
	if r.dryRun {
	return nil
	}
	args := []string{r.shell, "-c", r.cmd}
	cmd := exec.Cmd{
	Path: args[0],
	Args: args,
	}
	out, err := cmd.CombinedOutput()
	fmt.Printf("%s", out)
	exit := exitStatus(err)
	if r.ignoreError && exit != 0 {
	fmt.Printf("[%s] Error %d (ignored)\n", r.output, exit)
	err = nil
	}
	return err
	}

	func exitStatus(err error) int {
	if err == nil {
	return 0
	}
	exit := 1
	if err, ok := err.(*exec.ExitError); ok {
	if w, ok := err.ProcessState.Sys().(syscall.WaitStatus); ok {
	return w.ExitStatus()
	}
	}
	return exit
	}

	func replaceSuffix(s string, newsuf string) string {
	// TODO: Factor out the logic around suffix rules and use
	// it from substitution references.
	// http://www.gnu.org/software/make/manual/make.html#Substitution-Refs
	return fmt.Sprintf("%s.%s", stripExt(s), newsuf)
	}

	func (ex Executor) canPickImplicitRule(rule Rule, output string) bool {
	outputPattern := rule.outputPatterns[0]
	if !matchPattern(outputPattern, output) {
	return false
	}
	for _, input := range rule.inputs {
	input = substPattern(outputPattern, input, output)
	if !ex.exists(input) {
	return false
	}
	}
	return true
	}

	func (ex Executor) pickRule(output string) (Rule, bool) {
	rule, present := ex.rules[output]
	if present {
	if len(rule.cmds) > 0 {
	return rule, true
	}
	// If none of the explicit rules for a target has commands,
	// then `make' searches for an applicable implicit rule to
	// find some commands.
	}

	for _, irule := range ex.implicitRules {
	if !ex.canPickImplicitRule(irule, output) {
	continue
	}
	if rule != nil {
	r := &Rule{}
	r = rule
	r.outputPatterns = irule.outputPatterns
	// implicit rule's prerequisites will be used for $<
	r.inputs = append(irule.inputs, r.inputs...)
	if irule.vars != nil {
	r.vars = NewVarTab(rule.vars)
	for k, v := range irule.vars.m {
	r.vars.Assign(k, v)
	}
	}
	r.cmds = irule.cmds
	// TODO(ukai): filename, lineno?
	r.cmdLineno = irule.cmdLineno
	return r, true
	}
	// TODO(ukai): check len(irule.cmd) ?
	return irule, true
	}

	outputSuffix := filepath.Ext(output)
	if !strings.HasPrefix(outputSuffix, ".") {
	return rule, rule != nil
	}
	rules, present := ex.suffixRules[outputSuffix[1:]]
	if !present {
	return rule, rule != nil
	}
	for _, irule := range rules {
	if len(irule.inputs) != 1 {
	panic(fmt.Sprintf("unexpected number of input for a suffix rule (%d)", len(irule.inputs)))
	}
	if !ex.exists(replaceSuffix(output, irule.inputs[0])) {
	continue
	}
	if rule != nil {
	r := &Rule{}
	r = rule
	// TODO(ukai): input order is correct?
	r.inputs = append([]string{replaceSuffix(output, irule.inputs[0])}, r.inputs...)
	r.vars = NewVarTab(rule.vars)
	if irule.vars != nil {
	for k, v := range irule.vars.m {
	r.vars.Assign(k, v)
	}
	}
	r.cmds = irule.cmds
	// TODO(ukai): filename, lineno?
	r.cmdLineno = irule.cmdLineno
	return r, true
	}
	// TODO(ukai): check len(irule.cmd) ?
	return irule, true
	}
	return rule, rule != nil
	}

	func (ex Executor) build(vars VarTab, output string, neededBy string) (int64, error) {
	Log("Building: %s", output)
	outputTs, ok := ex.done[output]
	if ok {
	Log("Building: %s already done: %d", output, outputTs)
	return outputTs, nil
	}
	outputTs = getTimestamp(output)

	rule, present := ex.pickRule(output)
	if !present {
	if outputTs >= 0 {
	return outputTs, nil
	}
	if neededBy == "" {
	ErrorNoLocation("*** No rule to make target %q.", output)
	} else {
	ErrorNoLocation("*** No rule to make target %q, needed by %q.", output, neededBy)
	}
	return outputTs, fmt.Errorf("no rule to make target %q", output)
	}
	if rule.vars != nil {
	vars = NewVarTab(vars)
	for k, v := range rule.vars.m {
	vars.Assign(k, v)
	}
	}

	latest := int64(-1)
	var actualInputs []string
	Log("Building: %s inputs:%q", output, rule.inputs)
	for _, input := range rule.inputs {
	if len(rule.outputPatterns) > 0 {
	if len(rule.outputPatterns) > 1 {
	panic("TODO: multiple output pattern is not supported yet")
	}
	input = substPattern(rule.outputPatterns[0], input, output)
	} else if rule.isSuffixRule {
	input = replaceSuffix(output, input)
	}
	actualInputs = append(actualInputs, input)

	ts, err := ex.build(vars, input, output)
	if err != nil {
	return outputTs, err
	}
	if latest < ts {
	latest = ts
	}
	}

	for _, input := range rule.orderOnlyInputs {
	if exists(input) {
	continue
	}
	ts, err := ex.build(vars, input, output)
	if err != nil {
	return outputTs, err
	}
	if latest < ts {
	latest = ts
	}
	}

	if outputTs >= latest {
	return outputTs, nil
	}

	localVars := NewVarTab(vars)
	// automatic variables.
	localVars.Assign("@", SimpleVar{value: []byte(output), origin: "automatic"})
	if len(actualInputs) > 0 {
	localVars.Assign("<", SimpleVar{
	value: []byte(actualInputs[0]),
	origin: "automatic",
	})
	localVars.Assign("^", SimpleVar{
	value: []byte(strings.Join(actualInputs, " ")),
	origin: "automatic",
	})
	}
	ev := newEvaluator(localVars.Vars())
	ev.filename = rule.filename
	ev.lineno = rule.cmdLineno
	var runners []runner
	Log("Building: %s cmds:%q", output, rule.cmds)
	r := runner{
	output: output,
	echo: true,
	dryRun: dryRunFlag,
	}
	for _, cmd := range rule.cmds {
	runners = append(runners, evalCmd(ev, r, cmd, ex.shell)...)
	}
	for _, r := range runners {
	err := r.run()
	if err != nil {
	exit := exitStatus(err)
	fmt.Printf("[%s] Error %d: %v\n", r.output, exit, err)
	return outputTs, err
	}
	}

	outputTs = getTimestamp(output)
	if outputTs < 0 {
	outputTs = time.Now().Unix()
	}
	ex.done[output] = outputTs
	Log("Building: %s done %d", output, outputTs)
	return outputTs, nil
	}

	func (ex Executor) populateSuffixRule(rule Rule, output string) bool {
	if len(output) == 0 \|\| output[0] != '.' {
	return false
	}
	rest := output[1:]
	dotIndex := strings.IndexByte(rest, '.')
	// If there is only a single dot or the third dot, this is not a
	// suffix rule.
	if dotIndex < 0 \|\| strings.IndexByte(rest[dotIndex+1:], '.') >= 0 {
	return false
	}

	// This is a suffix rule.
	inputSuffix := rest[:dotIndex]
	outputSuffix := rest[dotIndex+1:]
	r := &Rule{}
	r = rule
	r.inputs = []string{inputSuffix}
	r.isSuffixRule = true
	ex.suffixRules[outputSuffix] = append([]*Rule{r}, ex.suffixRules[outputSuffix]...)
	return true
	}

	func (ex Executor) populateExplicitRule(rule Rule) {
	// It seems rules with no outputs are siliently ignored.
	if len(rule.outputs) == 0 {
	return
	}
	for _, output := range rule.outputs {
	output = filepath.Clean(output)

	isSuffixRule := ex.populateSuffixRule(rule, output)

	if oldRule, present := ex.rules[output]; present {
	if oldRule.vars != nil \|\| rule.vars != nil {
	oldRule.isDoubleColon = rule.isDoubleColon
	switch {
	case rule.vars == nil && oldRule.vars != nil:
	rule.vars = oldRule.vars
	case rule.vars != nil && oldRule.vars == nil:
	case rule.vars != nil && oldRule.vars != nil:
	// parent would be the same vars?
	for k, v := range rule.vars.m {
	oldRule.vars.m[k] = v
	}
	rule.vars = oldRule.vars
	}
	}
	if oldRule.isDoubleColon != rule.isDoubleColon {
	Error(rule.filename, rule.lineno, "*** target file %q has both : and :: entries.", output)
	}
	if len(oldRule.cmds) > 0 && len(rule.cmds) > 0 && !isSuffixRule && !rule.isDoubleColon {
	Warn(rule.filename, rule.cmdLineno, "overriding commands for target %q", output)
	Warn(oldRule.filename, oldRule.cmdLineno, "ignoring old commands for target %q", output)
	}
	r := &Rule{}
	r = rule
	if rule.isDoubleColon {
	r.cmds = append(oldRule.cmds, r.cmds...)
	} else if len(oldRule.cmds) > 0 && len(rule.cmds) == 0 {
	r.cmds = oldRule.cmds
	}
	r.inputs = append(r.inputs, oldRule.inputs...)
	r.orderOnlyInputs = append(r.orderOnlyInputs, oldRule.orderOnlyInputs...)
	ex.rules[output] = r
	} else {
	ex.rules[output] = rule
	if ex.firstRule == nil && !strings.HasPrefix(output, ".") {
	ex.firstRule = rule
	}
	}
	}
	}

	func (ex Executor) populateImplicitRule(rule Rule) {
	for _, outputPattern := range rule.outputPatterns {
	r := &Rule{}
	r = rule
	r.outputPatterns = []string{outputPattern}
	ex.implicitRules = append(ex.implicitRules, r)
	}
	}

	func (ex Executor) populateRules(er EvalResult) {
	for _, rule := range er.rules {
	for i, input := range rule.inputs {
	rule.inputs[i] = filepath.Clean(input)
	}
	for i, orderOnlyInput := range rule.orderOnlyInputs {
	rule.orderOnlyInputs[i] = filepath.Clean(orderOnlyInput)
	}
	ex.populateExplicitRule(rule)

	if len(rule.outputs) == 0 {
	ex.populateImplicitRule(rule)
	}
	}

	// Reverse the implicit rule for easier lookup.
	for i, r := range ex.implicitRules {
	if i >= len(ex.implicitRules)/2 {
	break
	}
	j := len(ex.implicitRules) - i - 1
	ex.implicitRules[i] = ex.implicitRules[j]
	ex.implicitRules[j] = r
	}
	}

	func (ex Executor) exec(er EvalResult, targets []string, vars *VarTab) error {
	// TODO: We should move this to somewhere around evalCmd so that
	// we can handle SHELL in target specific variables.
	shellVar := vars.Lookup("SHELL")
	ex.shell = shellVar.String()

	ex.populateRules(er)

	if len(targets) == 0 {
	if ex.firstRule == nil {
	ErrorNoLocation("*** No targets.")
	}
	targets = append(targets, ex.firstRule.outputs[0])
	}

	for _, target := range targets {
	_, err := ex.build(vars, target, "")
	if err != nil {
	return err
	}
	}
	return nil
	}

	func Exec(er EvalResult, targets []string, vars VarTab) error {
	ex := newExecutor()
	return ex.exec(er, targets, vars)
	}