tree 8b9a02a3e3f306493ad0c10590d21402d3cc6802
parent 511a000f970565f867a239e34f7153d39795ffa7
author Jeff Sharkey <jsharkey@android.com> 1562880471 -0600
committer JP Sugarbroad <jpsugar@google.com> 1576022589 -0800

RESTRICT AUTOMERGE
Strict SQLiteQueryBuilder needs to be stricter.

Malicious callers can leak side-channel information by using
subqueries in any untrusted inputs where SQLite allows "expr" values.

This change offers setStrictGrammar() to prevent this by outright
blocking subqueries in WHERE and HAVING clauses, and by requiring
that GROUP BY and ORDER BY clauses be composed only of valid columns.

This change also offers setStrictColumns() to require that all
untrusted column names are valid, such as those in ContentValues.

Relaxes to always allow aggregation operators on returned columns,
since untrusted callers can always calculate these manually.

Bug: 135270103
Bug: 135269143
Test: cts-tradefed run cts -m CtsDatabaseTestCases -t android.database.sqlite.cts.SQLiteQueryBuilderTest
Change-Id: I6b247672aaaccfa922d8328ceda109cde8acb273
(cherry picked from commit 6df8d632c5cfa87e92743d8a1ceca1b5d3ec1f81)