commit 5387824f19033ed51a945fbc8c2b574998404b3d
author Andy McFadden <fadden@android.com> Fri Mar 05 07:24:27 2010 -0800
committer Andy McFadden <fadden@android.com> Fri Mar 05 12:07:05 2010 -0800
tree d921096e958678d9b53295cd020011c85da8fd9d
parent 3fa53fd17aeb69685f91c32eb9d480d17503b7b4

Add instructions for volatile wide fields.

This adds four new instructions for accessing volatile wide fields (long
and double).  The JLS requires that such accesses are atomic, but the
VM doesn't otherwise make guarantees about the atomicity of reads and
writes on 64-bit fields.

There are no behavioral changes.  This just adds definitions for the new
instructions and a couple of tests.  The current implementation is just
the non-volatile form of the instructions or a C stub, but since we're
not generating them it doesn't really matter yet.

Also:
 - bumped Dalvik version to 1.3.0
 - added a note to the x86-atom TODO list

For bug 1633591.

vm/compiler/Dataflow.c

diff --git a/vm/compiler/Dataflow.c b/vm/compiler/Dataflow.c
index 787ac15..0f90c9e 100644
--- a/vm/compiler/Dataflow.c
+++ b/vm/compiler/Dataflow.c
@@ -725,16 +725,16 @@
     // E7 OP_UNUSED_E7
     DF_NOP,
 
-    // E8 OP_UNUSED_E8
+    // E8 OP_IGET_WIDE_VOLATILE
     DF_NOP,
 
-    // E9 OP_UNUSED_E9
+    // E9 OP_IPUT_WIDE_VOLATILE
     DF_NOP,
 
-    // EA OP_UNUSED_EA
+    // EA OP_SGET_WIDE_VOLATILE
     DF_NOP,
 
-    // EB OP_UNUSED_EB
+    // EB OP_SPUT_WIDE_VOLATILE
     DF_NOP,
 
     // EC OP_BREAKPOINT