Add symbol table function to get TFunction for a built-in op
Built-in function parameter qualifiers are stored in the symbol table.
Some AST traversers need the qualifier information for ops to
determine whether a node is being written to. Add an utility function
that maps a TIntermAggregate node to a symbol table entry, so that the
traversers can get to this information in a convenient way.
This will be necessary for adding more built-ins that have out
parameters from ESSL 3.10.
BUG=angleproject:1730
TEST=angle_unittests
Change-Id: I4bc622d70b2326a04cc858ff1258c22320c590dc
Reviewed-on: https://chromium-review.googlesource.com/431109
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
diff --git a/src/compiler/translator/IntermTraverse.cpp b/src/compiler/translator/IntermTraverse.cpp
index b5d42cc..b58b27c 100644
--- a/src/compiler/translator/IntermTraverse.cpp
+++ b/src/compiler/translator/IntermTraverse.cpp
@@ -680,26 +680,9 @@
// Find the built-in function corresponding to this op so that we can determine the
// in/out qualifiers of its parameters.
TFunction *builtInFunc = nullptr;
- TString opString = GetOperatorString(node->getOp());
- if (!node->isConstructor() && !opString.empty())
+ if (!node->isConstructor() && node->getOp() != EOpFunctionCall)
{
- // The return type doesn't affect the mangled name of the function, which is used
- // to look it up from the symbol table.
- TType dummyReturnType;
- TFunction call(&opString, &dummyReturnType, node->getOp());
- for (auto *child : *sequence)
- {
- TType *paramType = child->getAsTyped()->getTypePointer();
- TConstParameter p(paramType);
- call.addParameter(p);
- }
-
- TSymbol *sym = mSymbolTable.findBuiltIn(call.getMangledName(), mShaderVersion);
- if (sym != nullptr && sym->isFunction())
- {
- builtInFunc = static_cast<TFunction *>(sym);
- ASSERT(builtInFunc->getParamCount() == sequence->size());
- }
+ builtInFunc = mSymbolTable.findBuiltInOp(node, mShaderVersion);
}
size_t paramIndex = 0;