commit 02032bda51852a851501cbf7a2380ae67f2f7b05
author Olli Etuaho <oetuaho@nvidia.com> Fri Oct 13 18:10:17 2017 +0300
committer Commit Bot <commit-bot@chromium.org> Thu Oct 19 15:50:05 2017 +0000
tree a8757d0bd76b2b837f41cca598cc5cb4832fb3b2
parent cbcb96fcda67b3059f92486f295bc2cfcb8e2d53

Generate an error if no XFB varyings are in use

GLES specifies an error if BeginTransformFeedback is called when no
binding points would be used.

BUG=angleproject:2184
TEST=angle_end2end_tests

Change-Id: Ie4489b5ba63885e718dafdcdaacc02b603959be3
Reviewed-on: https://chromium-review.googlesource.com/719136
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>

src/libANGLE/validationES3.cpp

diff --git a/src/libANGLE/validationES3.cpp b/src/libANGLE/validationES3.cpp
index 4f9c1e1..37a76d3 100644
--- a/src/libANGLE/validationES3.cpp
+++ b/src/libANGLE/validationES3.cpp
@@ -2139,6 +2139,20 @@
         }
     }
 
+    auto program = context->getGLState().getProgram();
+
+    if (!program)
+    {
+        ANGLE_VALIDATION_ERR(context, InvalidOperation(), ProgramNotBound);
+        return false;
+    }
+
+    if (program->getTransformFeedbackVaryingCount() == 0)
+    {
+        ANGLE_VALIDATION_ERR(context, InvalidOperation(), NoTransformFeedbackOutputVariables);
+        return false;
+    }
+
     return true;
 }